Re: [libvirt] [PATCH] fix numa-related (and kernel-dependent) test failures

On Mon, Dec 15, 2008 at 03:36:07PM -0500, Dave Allan wrote: Jim Meyering wrote: Whoops. That was the wrong patch. Here's the patch I intended: From e7dce174d5bc7f4097125e9bbc14dc0fa2518355 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Mon, 15 Dec 2008 17:53:32 +0100

Re: [libvirt] [PATCH] [OpenVZ] Segmentation fault

As a general rule the public virDomainPtr objects should not be passed down into internal methods. Likewise, when creating / defining a VM, the virGetDomain call should be the last one in the normal execution path of the method. Thus, just pass the 'virConnectPtr' instance to

Re: [libvirt] [PATCH] [OpenVZ] Segmentation fault

On Tue, Dec 16, 2008 at 04:34:15PM +0300, Anton Protopopov wrote: 2008/12/16 Daniel P. Berrange berra...@redhat.com On Tue, Dec 16, 2008 at 03:05:30PM +0300, Anton Protopopov wrote: 2008/12/13 Ivan Vovk iv...@intermedia.net You can't have one public driver API method, calling into

Re: [libvirt] [PATCH] Avoid GCC extensions

On Mon, Dec 15, 2008 at 11:58:06AM -0800, john.le...@sun.com wrote: diff --git a/src/domain_conf.h b/src/domain_conf.h --- a/src/domain_conf.h +++ b/src/domain_conf.h @@ -307,12 +307,13 @@ struct _virDomainHostdevDef { unsigned slot; unsigned

Re: [libvirt] [OpenVZ]

On Tue, Dec 16, 2008 at 03:02:29PM +0300, Anton Protopopov wrote: If it is, then here is a result of command [r...@snow tmp]# LIBVIRT_DEBUG=yes virsh create ju ham 21 Segmentation fault Now I have a patch (see next message), that fixes that problem. Nevertheless, the other problem

Re: [libvirt] [PATCH] [OpenVZ] Segmentation fault

2008/12/16 Daniel P. Berrange berra...@redhat.com On Tue, Dec 16, 2008 at 03:05:30PM +0300, Anton Protopopov wrote: 2008/12/13 Ivan Vovk iv...@intermedia.net Hello, after updating to the last official release 0.5.1 my application stopped working. No errors to the log file

Re: [libvirt] [PATCH] [OpenVZ] Segmentation fault

On Tue, Dec 16, 2008 at 03:05:30PM +0300, Anton Protopopov wrote: 2008/12/13 Ivan Vovk iv...@intermedia.net Hello, after updating to the last official release 0.5.1 my application stopped working. No errors to the log file though i raised exceptions where it was possible. i

[libvirt] [PATCH] [OpenVZ] Segmentation fault

2008/12/13 Ivan Vovk iv...@intermedia.net Hello, after updating to the last official release 0.5.1 my application stopped working. No errors to the log file though i raised exceptions where it was possible. i checked with virsh xml description used for creating OpenVZ container and got

Re: [libvirt] [OpenVZ]

If it is, then here is a result of command [r...@snow tmp]# LIBVIRT_DEBUG=yes virsh create ju ham 21 Segmentation fault Now I have a patch (see next message), that fixes that problem. Nevertheless, the other problem is still here and its name is 'pthread usage': [r...@snow tmp]#

Re: [libvirt] Re: [RFC] sVirt 0.20

On Mon, 15 Dec 2008, James Morris wrote: On Thu, 11 Dec 2008, Daniel P. Berrange wrote: * a virNodeInfo is a structure filled by virNodeGetInfo() and providing @@ -504,6 +567,10 @@ int virDomainSetMaxMemory (virDomainPtr domain, int

Re: [libvirt] Re: [RFC] sVirt 0.20

On Wed, 17 Dec 2008, James Morris wrote: On Mon, 15 Dec 2008, James Morris wrote: On Thu, 11 Dec 2008, Daniel P. Berrange wrote: * a virNodeInfo is a structure filled by virNodeGetInfo() and providing @@ -504,6 +567,10 @@ int virDomainSetMaxMemory

[libvirt] libvirtd crashing with network bridge configuration

Dear Developers, Users, I'm trying to package libvirt for our distribution, however, having some problems past the libvirt 0.4.3 series. Everything compiles and installs fine. With versions above and including 0.5.1, I'm getting the following errors in the dmesg output: virbr0: Dropping

[libvirt] [PATCH] rpcgen fixes

# HG changeset patch # User john.le...@sun.com # Date 1229399266 28800 # Node ID 12c9b283b11f5e20b9dcc91e3d10a862da5d6e81 # Parent 1ba824db09286ebc758e035211da2c533bbd1e0f rpcgen fixes quad_t is not a portable type, but rather than force rpcgen every build, we just patch in the fixes needed.

[libvirt] [PATCH] Fix register/deregister driver method declaration

# HG changeset patch # User john.le...@sun.com # Date 1229399267 28800 # Node ID 357ed6194907962940e31382fe988f3b64bd1968 # Parent 1d913a11d0b4df41c6a749ea34a5a2f37cb2c903 Fix register/deregister driver method declaration Callback parameter should be of type virConnectDomainEventCallback.

[libvirt] [PATCH] Fix statement not reached compiler error

# HG changeset patch # User john.le...@sun.com # Date 1229399267 28800 # Node ID 77dceb31cae41057c4274517f5c3246e47545de3 # Parent 8b69f84c9498d05ae03f5389eb83290aaeab23e6 Fix statement not reached compiler error Signed-off-by: John Levon john.le...@sun.com diff --git a/src/remote_internal.c

[libvirt] [PATCH] Portability fixes for directory storage backend

# HG changeset patch # User john.le...@sun.com # Date 1229399267 28800 # Node ID 53a18080ea210168c044d7ade8dd8db0881d5c85 # Parent cd2fb266824178c4d63296b587eeedb2360f9f1c Portability fixes for directory storage backend Signed-off-by: John Levon john.le...@sun.com diff --git a/configure.in

[libvirt] [PATCH] qemud compile fixes

# HG changeset patch # User john.le...@sun.com # Date 1229399267 28800 # Node ID a6c317b5fe1b4081ccb40ba90af7d31298cf6b44 # Parent a8109ee7d505787957468ebd03b09c613e3372cf qemud compile fixes Let qemud/ compile with Sun cc. Signed-off-by: John Levon john.le...@sun.com diff --git

[libvirt] [PATCH] Improve compiler flag checking

# HG changeset patch # User john.le...@sun.com # Date 1229399267 28800 # Node ID 1f7707a3d49b20397011897cdc04c347322ad0c5 # Parent a6c317b5fe1b4081ccb40ba90af7d31298cf6b44 Improve compiler flag checking Some compilers (including GCC) don't set the return value consistently if an erroneous option

[libvirt] [PATCH] Fix qemud link

# HG changeset patch # User john.le...@sun.com # Date 1229399267 28800 # Node ID 57c76efe37988edc64beb12ca5dc1ff5863f0085 # Parent 1f7707a3d49b20397011897cdc04c347322ad0c5 Fix qemud link Order the LDADDs such that symbols are correctly resolved (namely asprintf() and getdelim()). Signed-off-by:

[libvirt] [PATCH] Makefile portability in qemud

# HG changeset patch # User john.le...@sun.com # Date 1229399267 28800 # Node ID 35512df785342cd15214790e17e0c1f4d2182b32 # Parent 57c76efe37988edc64beb12ca5dc1ff5863f0085 Makefile portability in qemud Neither uuidgen nor sed -i are portable - only make the edit on platforms that can do so.

[libvirt] [PATCH] Fix GCC hard-coding in python/

# HG changeset patch # User john.le...@sun.com # Date 1229399267 28800 # Node ID b105e5a7cd6190e0b952a1587d7e80f39d02e63c # Parent 35512df785342cd15214790e17e0c1f4d2182b32 Fix GCC hard-coding in python/ Signed-off-by: John Levon john.le...@sun.com diff --git a/acinclude.m4 b/acinclude.m4 ---

[libvirt] [PATCH] __FUNCTION__ is not portable

# HG changeset patch # User john.le...@sun.com # Date 1229399267 28800 # Node ID ee6ccfc062f49f514d7ae8924d5a596b18441fee # Parent b105e5a7cd6190e0b952a1587d7e80f39d02e63c __FUNCTION__ is not portable __func__ is. Some places aren't covered by the back-compat define (why is that there?)

[libvirt] [PATCH] Fix compiler warnings in test code

# HG changeset patch # User john.le...@sun.com # Date 1229399267 28800 # Node ID 1b81ac255ad765ab782829e7fe0a55dc7bab72ab # Parent ee6ccfc062f49f514d7ae8924d5a596b18441fee Fix compiler warnings in test code Signed-off-by: John Levon john.le...@sun.com diff --git a/src/test.c b/src/test.c ---

[libvirt] [PATCH] pid_t portability in virExec()

# HG changeset patch # User john.le...@sun.com # Date 1229399267 28800 # Node ID 020f8b8e9340287a6ab3d869b359e39b905cd0ff # Parent 1b81ac255ad765ab782829e7fe0a55dc7bab72ab pid_t portability in virExec() Use the right type for handling process IDs. Signed-off-by: John Levon john.le...@sun.com

[libvirt] [PATCH] Fix _FILE_OFFSET_BITS re-definition

# HG changeset patch # User john.le...@sun.com # Date 1229399267 28800 # Node ID db36391b739c117f5887388f65f31e6a9d2d361b # Parent 020f8b8e9340287a6ab3d869b359e39b905cd0ff Fix _FILE_OFFSET_BITS re-definition Since config.h contains the _FILE_OFFSET_BITS setting (a little dubious in itself), it

[libvirt] [PATCH] Fix compiler error when !HAVE_POLKIT

# HG changeset patch # User john.le...@sun.com # Date 1229399439 28800 # Node ID f622c9de5e2488de8ae16bc7a0b50d8fa76af364 # Parent db36391b739c117f5887388f65f31e6a9d2d361b Fix compiler error when !HAVE_POLKIT Signed-off-by: John Levon john.le...@sun.com diff --git a/qemud/remote.c

Re: [libvirt] [PATCH] fix numa-related (and kernel-dependent) test failures

Daniel Veillard veill...@redhat.com wrote: ... All tests pass for me with that patch. Looks good. Same for me, +1 ! Thanks. Pushed with this comment: fix numa-related (and kernel-dependent) test failures This change is required on some kernels due to the way a change in