Re: [libvirt] [PATCH] Add copy-on-write image support

2009-01-12 Thread Miloslav Trmač
Hello, here's a version of the patch updated to apply against current CVS. Mirek Index: ChangeLog === RCS file: /data/cvs/libvirt/ChangeLog,v retrieving revision 1.1867 diff -u -r1.1867 ChangeLog --- ChangeLog 11 Jan 2009

[libvirt] [PATCH] PCI passthrough docs, tests and minor change

2009-01-12 Thread Daniel Veillard
The following add the documentation for the PCI passthrough, extends the RNG and add an extra test for the QEmu parsing to args and serialization back to XML. I also noticed that we parse (and save) and extra PCI domain argument, but it's not actually used when calling qemu, so I assume it's a

Re: [libvirt] interface.script not launched (KVM/qemu)

2009-01-12 Thread Daniel P. Berrange
On Sat, Jan 10, 2009 at 04:22:59PM +0100, Daniel Schwager wrote: Hi, I use kvm and libvirt for running windows on a fedora-core9. Problem: I defined a interface script which should run, if the KVM/qemu starts, but libvirt does not tell kvm to use the script: Part of my domain.xml:

Re: [libvirt] Bridge interface and script

2009-01-12 Thread Daniel P. Berrange
On Fri, Jan 09, 2009 at 10:26:52PM +, John Levon wrote: With current libvirt, it's not possible to specify a script for VIR_DOMAIN_NET_TYPE_BRIDGE. Is this just an oversight, or intentional? That's intentional - if you want to use a generic network script then use the type=ethernet style

Re: [libvirt] adding tests....

2009-01-12 Thread Daniel P. Berrange
On Thu, Jan 08, 2009 at 08:55:31PM +0100, Jim Meyering wrote: In adding a couple of tests, I noticed that libvirtd --config=no-such didn't diagnose my mistake. I fixed that with the first patch below: diagnose libvirtd --config=no-such-file * qemud/qemud.c

Re: [libvirt] text console install

2009-01-12 Thread Daniel P. Berrange
On Sat, Jan 10, 2009 at 09:35:57AM +0100, Michael Kress wrote: Hi, I'm not able to get a text console install of any distribution (CentOS-5.2 for example). I'm using the following command: virt-install -n myname -f myimage.img -s 10 -c /iso/CentOS-5.2-x86_64-bin-DVD.iso --accelerate -r 1024

Re: [libvirt] [PATCH] fix non-srcdir build failure

2009-01-12 Thread Daniel P. Berrange
On Thu, Jan 08, 2009 at 08:56:36PM +0100, Jim Meyering wrote: make distcheck was failing. This fixes it and adds some quotes. ACK. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org

Re: [libvirt] [PATCH] PCI passthrough docs, tests and minor change

2009-01-12 Thread Mark McLoughlin
On Mon, 2009-01-12 at 11:30 +0100, Daniel Veillard wrote: + For PCI devices the element carries 3 attributes allowing to designate + the device as can be found with the codelspci/code command, the + codebus/code attribute allows the hexadecimal values 0 to ff, the +

Re: [libvirt] [PATCH] PCI passthrough docs, tests and minor change

2009-01-12 Thread Daniel P. Berrange
On Mon, Jan 12, 2009 at 11:17:52AM +, Mark McLoughlin wrote: On Mon, 2009-01-12 at 11:30 +0100, Daniel Veillard wrote: + For PCI devices the element carries 3 attributes allowing to designate + the device as can be found with the codelspci/code command, the +

Re: [libvirt] [PATCH 5/5] read saved vm status on libvirtd startup

2009-01-12 Thread Daniel P. Berrange
On Sun, Jan 11, 2009 at 02:09:26PM +0100, Guido G?nther wrote: On Mon, Dec 15, 2008 at 11:27:27AM +, Daniel P. Berrange wrote: [..snip..] +vm-stdin_fd = qemudGetProcFD(vm-pid, 0); +vm-stdout_fd = qemudGetProcFD(vm-pid, 1); +vm-stderr_fd =

Re: [libvirt] [PATCH] PCI passthrough docs, tests and minor change

2009-01-12 Thread Daniel P. Berrange
On Mon, Jan 12, 2009 at 11:30:51AM +0100, Daniel Veillard wrote: The following add the documentation for the PCI passthrough, extends the RNG and add an extra test for the QEmu parsing to args and serialization back to XML. I also noticed that we parse (and save) and extra PCI domain

Re: [libvirt] [PATCH] PCI passthrough docs, tests and minor change

2009-01-12 Thread Daniel Veillard
On Mon, Jan 12, 2009 at 11:23:51AM +, Daniel P. Berrange wrote: On Mon, Jan 12, 2009 at 11:17:52AM +, Mark McLoughlin wrote: On Mon, 2009-01-12 at 11:30 +0100, Daniel Veillard wrote: + For PCI devices the element carries 3 attributes allowing to designate + the

Re: [libvirt] Question, new libvirt driver - OpenNebula.

2009-01-12 Thread Daniel P. Berrange
On Fri, Jan 09, 2009 at 05:33:56PM +0100, Abel M?guez Rodr?guez wrote:     We have updated the libvirt implementation for OpenNebula to libvirt- 0.5.1  release, made use of the internal XML handling  API and the existing infrastructure for error, data structures, etc...     Now we are

Re: [libvirt] [PATCH] PCI passthrough docs, tests and minor change

2009-01-12 Thread Daniel P. Berrange
On Mon, Jan 12, 2009 at 12:55:14PM +0100, Daniel Veillard wrote: On Mon, Jan 12, 2009 at 11:46:38AM +, Daniel P. Berrange wrote: I also noticed that we parse (and save) and extra PCI domain argument, but it's not actually used when calling qemu, so I assume it's a missing feature

Re: [libvirt] [PATCH] PCI passthrough docs, tests and minor change

2009-01-12 Thread Daniel Veillard
On Mon, Jan 12, 2009 at 11:46:38AM +, Daniel P. Berrange wrote: I also noticed that we parse (and save) and extra PCI domain argument, but it's not actually used when calling qemu, so I assume it's a missing feature for QEmu and just decided to patch the code to not save the extra

Re: [libvirt] adding tests....

2009-01-12 Thread Jim Meyering
Daniel P. Berrange berra...@redhat.com wrote: +if (remote_config_file == NULL) { +static const char *default_config_file + = SYSCONF_DIR /libvirt/libvirtd.conf; +remote_config_file = + (access(default_config_file, X_OK) == 0 + ? default_config_file + :

Re: [libvirt] adding tests....

2009-01-12 Thread Daniel P. Berrange
On Mon, Jan 12, 2009 at 01:28:41PM +0100, Jim Meyering wrote: Daniel P. Berrange berra...@redhat.com wrote: +if (remote_config_file == NULL) { + static const char *default_config_file += SYSCONF_DIR /libvirt/libvirtd.conf; + remote_config_file = +

Re: [libvirt] adding tests....

2009-01-12 Thread Jim Meyering
Daniel P. Berrange berra...@redhat.com wrote: On Mon, Jan 12, 2009 at 01:28:41PM +0100, Jim Meyering wrote: Daniel P. Berrange berra...@redhat.com wrote: +if (remote_config_file == NULL) { + static const char *default_config_file + = SYSCONF_DIR /libvirt/libvirtd.conf; +

Re: [libvirt] adding tests....

2009-01-12 Thread Daniel P. Berrange
On Mon, Jan 12, 2009 at 02:18:05PM +0100, Jim Meyering wrote: Daniel P. Berrange berra...@redhat.com wrote: On Mon, Jan 12, 2009 at 01:28:41PM +0100, Jim Meyering wrote: Daniel P. Berrange berra...@redhat.com wrote: +if (remote_config_file == NULL) { + static const char

Re: [libvirt] adding tests....

2009-01-12 Thread Jim Meyering
Daniel P. Berrange berra...@redhat.com wrote: ... The QEMU driver runs as non-root too. This is what the qemu:///session URI is used for. Likewise with the UML driver. The existing tests that invoke libvirtd fail quite frequently for me already due to them activating the QEMU / UML drivers. We

Re: [libvirt] [PATCH] PCI passthrough docs, tests and minor change

2009-01-12 Thread Daniel Veillard
On Mon, Jan 12, 2009 at 11:17:52AM +, Mark McLoughlin wrote: On Mon, 2009-01-12 at 11:30 +0100, Daniel Veillard wrote: + For PCI devices the element carries 3 attributes allowing to designate + the device as can be found with the codelspci/code command, the +

Re: [libvirt] [PATCH 5/5] read saved vm status on libvirtd startup

2009-01-12 Thread Daniel P. Berrange
On Mon, Jan 12, 2009 at 04:37:50PM +0100, Guido G?nther wrote: On Mon, Jan 12, 2009 at 11:30:19AM +, Daniel P. Berrange wrote: There's different needs for each file descriptor - stdin_fd - this is only ever used for incoming migration data all other times it is hooked up to

[libvirt] [PATCH] Fix invocation of rpcgen

2009-01-12 Thread Richard W.M. Jones
Currently if rpcgen != glibc's rpcgen, then it gets a bit confused with the temporary files. Also it's best to call the rpcgen that configure detected and not some random rpcgen that happens to be in the path. The attached patch fixes this. Rich. -- Richard Jones, Emerging Technologies, Red

Re: [libvirt] proposal: allow use of bool: HACKING: discuss C types

2009-01-12 Thread Richard W.M. Jones
On Wed, Dec 17, 2008 at 09:08:36PM +, Daniel P. Berrange wrote: Ok, if you want to re-post the HACKING file also mentioning that 'bool' shouldn't be used in our public APIs wire protocol, What's wrong with using it in the wire protocol? XDR provides bool_t (as int) and converts 'bool' in

Re: [libvirt] [PATCH] fix non-srcdir build failure

2009-01-12 Thread Jim Meyering
Daniel P. Berrange berra...@redhat.com wrote: On Thu, Jan 08, 2009 at 08:56:36PM +0100, Jim Meyering wrote: make distcheck was failing. This fixes it and adds some quotes. ACK. Thanks. I've applied that, as well as these two: tests: quiet virsh-all diagnose libvirtd

Re: [libvirt] [PATCH] Fix remote_protocol header for Solaris

2009-01-12 Thread Richard W.M. Jones
On Mon, Dec 15, 2008 at 11:05:10AM -0800, john.le...@sun.com wrote: # HG changeset patch # User john.le...@sun.com # Date 1229367889 28800 # Node ID 46a487775d4b35c32455a5ca8eb3009d10a02c5b # Parent a1f24e9f8a1fbf191c71172ae986110b7e98fc32 Fix remote_protocol header for Solaris quad_t is

Re: [libvirt] [PATCH] Fix remote_protocol header for Solaris

2009-01-12 Thread Richard W.M. Jones
On Mon, Dec 15, 2008 at 09:55:19PM +, Daniel P. Berrange wrote: On Mon, Dec 15, 2008 at 11:05:10AM -0800, john.le...@sun.com wrote: ++ ++#if defined(__sun) ++#include rpc/xdr.h ++#define u_quad_t uint64_t ++#define quad_t int64_t ++#define xdr_u_quad_t xdr_uint64_t ++#define

Re: [libvirt] [PATCH] Avoid GCC extensions

2009-01-12 Thread Richard W.M. Jones
On Mon, Dec 15, 2008 at 09:38:52PM +, Daniel P. Berrange wrote: On Mon, Dec 15, 2008 at 11:58:06AM -0800, john.le...@sun.com wrote: # HG changeset patch # User john.le...@sun.com # Date 1229367890 28800 # Node ID 6a8e82d7d2e166880fed8d7ad860a3e2e93d62be # Parent

Re: [libvirt] adding tests....

2009-01-12 Thread Jim Meyering
Jim Meyering j...@meyering.net wrote: Daniel P. Berrange berra...@redhat.com wrote: ... The QEMU driver runs as non-root too. This is what the qemu:///session URI is used for. Likewise with the UML driver. The existing tests that invoke libvirtd fail quite frequently for me already due to

Re: [libvirt] [PATCH] Fix remote_protocol header for Solaris

2009-01-12 Thread John Levon
On Mon, Jan 12, 2009 at 06:25:17PM +, Richard W.M. Jones wrote: Fix remote_protocol header for Solaris quad_t is not a portable type, but rather than force rpcgen every build, we just patch in the fixes needed. Perhaps a better solution to this might be to get PortableXDR working

Re: [libvirt] [PATCH] Fix remote_protocol header for Solaris

2009-01-12 Thread Richard W.M. Jones
On Mon, Jan 12, 2009 at 06:48:51PM +, John Levon wrote: On Mon, Jan 12, 2009 at 06:25:17PM +, Richard W.M. Jones wrote: Fix remote_protocol header for Solaris quad_t is not a portable type, but rather than force rpcgen every build, we just patch in the fixes needed.

Re: [libvirt] [PATCH] Fix remote_protocol header for Solaris

2009-01-12 Thread Daniel P. Berrange
On Mon, Jan 12, 2009 at 06:29:38PM +, Richard W.M. Jones wrote: On Mon, Dec 15, 2008 at 09:55:19PM +, Daniel P. Berrange wrote: On Mon, Dec 15, 2008 at 11:05:10AM -0800, john.le...@sun.com wrote: ++ ++#if defined(__sun) ++#include rpc/xdr.h ++#define u_quad_t uint64_t

Re: [libvirt] [PATCH] Fix invocation of rpcgen

2009-01-12 Thread Daniel P. Berrange
On Mon, Jan 12, 2009 at 04:22:51PM +, Richard W.M. Jones wrote: Currently if rpcgen != glibc's rpcgen, then it gets a bit confused with the temporary files. Also it's best to call the rpcgen that configure detected and not some random rpcgen that happens to be in the path. The attached

Re: [libvirt] [PATCH] Fix remote_protocol header for Solaris

2009-01-12 Thread Daniel P. Berrange
On Mon, Jan 12, 2009 at 06:48:51PM +, John Levon wrote: On Mon, Jan 12, 2009 at 06:25:17PM +, Richard W.M. Jones wrote: Fix remote_protocol header for Solaris quad_t is not a portable type, but rather than force rpcgen every build, we just patch in the fixes needed.

Re: [libvirt] [PATCH] Fix remote_protocol header for Solaris

2009-01-12 Thread Richard W.M. Jones
On Mon, Jan 12, 2009 at 07:59:44PM +, Daniel P. Berrange wrote: On Mon, Jan 12, 2009 at 06:29:38PM +, Richard W.M. Jones wrote: On Mon, Dec 15, 2008 at 09:55:19PM +, Daniel P. Berrange wrote: On Mon, Dec 15, 2008 at 11:05:10AM -0800, john.le...@sun.com wrote: ++ ++#if

Re: [libvirt] Bridge interface and script

2009-01-12 Thread John Levon
On Mon, Jan 12, 2009 at 10:54:58AM +, Daniel P. Berrange wrote: With current libvirt, it's not possible to specify a script for VIR_DOMAIN_NET_TYPE_BRIDGE. Is this just an oversight, or intentional? That's intentional - if you want to use a generic network script then use the

Re: [libvirt] Bridge interface and script

2009-01-12 Thread Daniel P. Berrange
On Mon, Jan 12, 2009 at 09:09:32PM +, John Levon wrote: On Mon, Jan 12, 2009 at 10:54:58AM +, Daniel P. Berrange wrote: With current libvirt, it's not possible to specify a script for VIR_DOMAIN_NET_TYPE_BRIDGE. Is this just an oversight, or intentional? That's intentional -

Re: [libvirt] Bridge interface and script

2009-01-12 Thread John Levon
On Mon, Jan 12, 2009 at 09:38:42PM +, Daniel P. Berrange wrote: With current libvirt, it's not possible to specify a script for VIR_DOMAIN_NET_TYPE_BRIDGE. Is this just an oversight, or intentional? That's intentional - if you want to use a generic network script then use

[libvirt] [ANN] sVirt v0.30

2009-01-12 Thread James Morris
This is to announce the release of v0.30 of sVirt, a project to add security labeling support to Linux-based virtualization. Project page: http://www.selinuxproject.org/page/SVirt Download: http://namei.org/svirt/svirt-0.30.tar.bz2 This release is an update in response to feedback

Re: [libvirt] proposal: allow use of bool: HACKING: discuss C types

2009-01-12 Thread Jim Meyering
Richard W.M. Jones rjo...@redhat.com wrote: On Wed, Dec 17, 2008 at 09:08:36PM +, Daniel P. Berrange wrote: Ok, if you want to re-post the HACKING file also mentioning that 'bool' shouldn't be used in our public APIs wire protocol, What's wrong with using it in the wire protocol? XDR