[libvirt] vTPM support in libvirt

2009-06-25 Thread Andreas Sommer
I'm wondering if there will be vTPM support in libvirt in the near future?! Xen does support it already with the configuration vtpm = ['instance=1,backend=0'], for example. So it would be great if the libvirt XML format supported it, too... For example like this: devices vtpm instance=1

Re: [libvirt] [PATCH] OpenNebula driver changes

2009-06-25 Thread Daniel P. Berrange
On Wed, Jun 24, 2009 at 10:55:31PM +0200, Ruben S. Montero wrote: Hi Daniel These are great news indeed!. We are already doing the testing of the driver. THANK YOU VERY MUCH for your help It would be good to get a page on the libvirt website outlining how to use the OpenNebula driver. At

Re: [libvirt] [PATCH 4/3] Control LXC capabilities

2009-06-25 Thread Daniel P. Berrange
On Tue, Jun 23, 2009 at 07:45:34PM -0700, Casey Schaufler wrote: Serge E. Hallyn wrote: Quoting Daniel P. Berrange (berra...@redhat.com): This patch updates the LXC driver to make use of libcap-ng for managing process capabilities. Previously Ryota Ozaki had provided code to remove

Re: [libvirt] hooking a physical nic to a bridge with net-create

2009-06-25 Thread Daniel P. Berrange
On Wed, Jun 24, 2009 at 09:05:40PM -0700, Shahar Klein wrote: I tried the virInterface that is already in 0.6.4 but got this: libvir: error : this function is not supported by the hypervisor: virInterfaceDefineXML ERROR virInterfaceDefineXML Can I use netcf just to get the feeling of it?

Re: [libvirt] [PATCH 4/5] free extent fix

2009-06-25 Thread Daniel P. Berrange
On Wed, Jun 24, 2009 at 11:19:37AM +0200, Henrik Persson wrote: Parted reports that the first block of the disk is free, even if it is occupied by the partition table. --- libvirt-0.6.4.patches/src/storage_backend_disk.c 2009-06-23 18:17:19.039168000 +0200 +++

Re: [libvirt] [PATCH 3/5] disk geometry

2009-06-25 Thread Daniel P. Berrange
On Wed, Jun 24, 2009 at 11:17:49AM +0200, Henrik Persson wrote: Reads the disk geometry to be able to align disk partitions on cylinder boundries. Msdos partition tables really like this stuff. --- libvirt-0.6.4.org/src/parthelper.c2009-06-23 13:07:38.167048000 +0200 +++

Re: [libvirt] [PATCH 1/5] Add type of free area

2009-06-25 Thread Daniel P. Berrange
On Wed, Jun 24, 2009 at 11:12:18AM +0200, Henrik Persson wrote: This patch adds the type of the free area, since this is important when creating logical partitions. --- libvirt-0.6.4.org/src/storage_conf.h 2009-06-23 13:11:05.624511000 +0200 +++ libvirt-0.6.4/src/storage_conf.h

Re: [libvirt] [PATCH 2/5] Add partition type

2009-06-25 Thread Daniel P. Berrange
On Wed, Jun 24, 2009 at 11:14:29AM +0200, Henrik Persson wrote: This patch add the partition type (primary, extended, logical) in internal libvirt data structure. This is important when deciding what kind of partition should be created. --- libvirt-0.6.4.org/src/storage_conf.h

Re: [libvirt] [PATCH 5/5] create storage volumes

2009-06-25 Thread Daniel P. Berrange
On Wed, Jun 24, 2009 at 11:21:48AM +0200, Henrik Persson wrote: This patch does the last magic to be able to create storage volumes when using a disk as backend --- libvirt-0.6.4.patches/src/storage_backend_disk.c 2009-06-23 18:17:30.885038000 +0200 +++

Re: [libvirt] vTPM support in libvirt

2009-06-25 Thread Daniel P. Berrange
On Thu, Jun 25, 2009 at 09:16:26AM +0100, Andreas Sommer wrote: I'm wondering if there will be vTPM support in libvirt in the near future?! Xen does support it already with the configuration vtpm = ['instance=1,backend=0'], for example. So it would be great if the libvirt XML format

Re: [libvirt] Fix the no debug build

2009-06-25 Thread Daniel P. Berrange
On Wed, Jun 24, 2009 at 12:55:57PM -0400, Amy Griffis wrote: The --enable-debug=no build breaks building the UML driver because of __VA_ARGS__ in the virLogMessage macro. I fixed this by converting umlLog() calls to use the standard logging macros instead. The only problem I see with doing

Re: [libvirt] Memory leak in node_device_conf.c

2009-06-25 Thread Daniel P. Berrange
On Tue, Jun 23, 2009 at 04:08:53PM -0400, Dave Allan wrote: I found what I assume is a memory leak in the node device code while working on a separate problem; patch attached. Dave diff --git a/src/node_device_conf.c b/src/node_device_conf.c index 1fbf9dc..56a9bb5 100644 ---

Re: [libvirt] [PATCH] OpenNebula driver changes

2009-06-25 Thread Ruben S. Montero
OK, we'll do so... On Thu, Jun 25, 2009 at 10:58 AM, Daniel P. Berrange berra...@redhat.com wrote: On Wed, Jun 24, 2009 at 10:55:31PM +0200, Ruben S. Montero wrote: Hi Daniel These are great news indeed!. We are already doing the testing of the driver. THANK YOU VERY MUCH for your help It

[libvirt] VMware ESX driver status update

2009-06-25 Thread Matthias Bolte
Hi, I'm still working on the VMX config to domain XML mapping for dump/create XML, but it's not complete yet. I got distracted by other urgent, Uni related work that had to be done first. So I won't be able to complete the dump/create XML implementation until tomorrow (freeze for the 0.6.5

Re: [libvirt] virStorageVolCreateXMLFrom

2009-06-25 Thread Kenneth Nagin
Daniel P. Berrange berra...@redhat.com wrote on 22/06/2009 12:08:39: On Mon, Jun 22, 2009 at 09:59:00AM +0300, Kenneth Nagin wrote: I'd like to get a better understanding of the virStorageVolCreateXMLFrom api Its name and signature imply that it is a cloning operation that copies a

Re: [libvirt] vTPM support in libvirt

2009-06-25 Thread Andreas Sommer
I agree on ignoring backend for now. The instance parameter defines a vTPM ID associated to that domain. There's a file vtpm.db which lists all mappings between domain UUID and vTPM ID, which means as long as you set a UUID for each of your domains, the correct vTPM is selected automatically

Re: [libvirt] [PATCH] fix virsh dominfo returns error when virNodeGetSecurityModel() is not supported.

2009-06-25 Thread Daniel Veillard
On Thu, Jun 25, 2009 at 09:29:48AM +0900, Tatsuro Enokura wrote: Hi Dan, Tatsuro Enokura wrote: I don't think that is neccessary. You'll only invoke virDomainGetSecurityLabel if virNodeGetSecurityModel() was asuccessfull and the returned secmodel is not the empty string. In such a scenario

Re: [libvirt] [PATCH] fix virsh dominfo returns error when virNodeGetSecurityModel() is not supported.

2009-06-25 Thread Daniel P. Berrange
On Thu, Jun 25, 2009 at 03:43:12PM +0200, Daniel Veillard wrote: On Thu, Jun 25, 2009 at 09:29:48AM +0900, Tatsuro Enokura wrote: Hi Dan, Tatsuro Enokura wrote: I don't think that is neccessary. You'll only invoke virDomainGetSecurityLabel if virNodeGetSecurityModel() was asuccessfull

[libvirt] Re: [netcf-devel] Multiple interfaces with identical mac-addresses

2009-06-25 Thread Laine Stump
(expanding Cc to include libvir-list, because this is more of a libvirt issue) On 06/24/2009 01:52 PM, David Lutterkort wrote: On Wed, 2009-06-24 at 18:22 +0100, Daniel P. Berrange wrote: On Wed, Jun 24, 2009 at 10:20:00AM -0700, David Lutterkort wrote: On Tue, 2009-06-23 at 21:47

Re: [libvirt] Re: [netcf-devel] Multiple interfaces with identical mac-addresses

2009-06-25 Thread Dave Allan
Laine Stump wrote: (expanding Cc to include libvir-list, because this is more of a libvirt issue) On 06/24/2009 01:52 PM, David Lutterkort wrote: On Wed, 2009-06-24 at 18:22 +0100, Daniel P. Berrange wrote: On Wed, Jun 24, 2009 at 10:20:00AM -0700, David Lutterkort wrote: On Tue,

Re: [libvirt] [PATCH] Do a correct format mapping of partitions 2

2009-06-25 Thread Daniel Veillard
On Tue, Jun 23, 2009 at 12:47:58PM +0200, Henrik Persson wrote: I make a new try from a different mail client now. Hi Henrik, Okay, got it but there is a problem: +/* Get partition type */ +if(ped_partition_is_active(part)) { +

Re: [libvirt] Memory leak in node_device_conf.c

2009-06-25 Thread Daniel Veillard
On Tue, Jun 23, 2009 at 04:08:53PM -0400, Dave Allan wrote: I found what I assume is a memory leak in the node device code while working on a separate problem; patch attached. Okay, applied and commited ! thanks :-) Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit

Re: [libvirt] Fix the no debug build

2009-06-25 Thread Daniel Veillard
On Wed, Jun 24, 2009 at 12:55:57PM -0400, Amy Griffis wrote: The --enable-debug=no build breaks building the UML driver because of __VA_ARGS__ in the virLogMessage macro. I fixed this by converting umlLog() calls to use the standard logging macros instead. The only problem I see with doing

Re: [libvirt] [PATCH] Fix reading storage pool defs on driver startup

2009-06-25 Thread Daniel Veillard
On Wed, Jun 24, 2009 at 06:11:04PM -0400, Cole Robinson wrote: The recent storage refactoring I committed broke reading pool definitions from disk on driver startup: the result was that none of your pools would be defined. Frankly not sure how I managed to miss the brokenness, sorry about

[libvirt] [PATCH 0/1] Fix bogus WWNs

2009-06-25 Thread David Allan
When HBA kernel modules are loaded while libvirt is running, libvirt will often read bogus WWNs from sysfs as at least some modules trigger the HAL event notifying libvirt of adapters' existence before the sysfs info is correct. The following patch causes libvirt to reread the WWNs whenever

[libvirt] [PATCH 1/1] Fix bogus WWNs

2009-06-25 Thread David Allan
--- src/node_device.c | 34 +++ src/node_device_hal.h |4 + src/node_device_hal_linux.c | 134 +-- 3 files changed, 104 insertions(+), 68 deletions(-) diff --git a/src/node_device.c b/src/node_device.c index 8de6495..cda14fa

Re: [libvirt] VMware ESX driver status update

2009-06-25 Thread Daniel Veillard
On Thu, Jun 25, 2009 at 12:11:26PM +0200, Matthias Bolte wrote: Hi, I'm still working on the VMX config to domain XML mapping for dump/create XML, but it's not complete yet. I got distracted by other urgent, Uni related work that had to be done first. Okay :-) So I won't be able to

Re: [libvirt] VMware ESX driver status update

2009-06-25 Thread Hugh O. Brock
On Thu, Jun 25, 2009 at 05:26:45PM +0200, Daniel Veillard wrote: On Thu, Jun 25, 2009 at 12:11:26PM +0200, Matthias Bolte wrote: One problem here is the essential guestOS field of the VMX config, see http://sanbarrow.com/vmx/vmx-guestos.html . For a first try I would set it to 'other' by

RE: [libvirt] [PATCH 5/5] create storage volumes

2009-06-25 Thread Henrik Persson E
Hi, Well it doesn't really do the trick, since it maps to linux-lvm and linux-raid which is not a valid fs-type for parted. But maybe I should update the enum to reflect the valid fs-types of parted if that was the intention of the enum? /Henrik -Original Message- From: Daniel P.

Re: [libvirt] [PATCH 5/5] create storage volumes

2009-06-25 Thread Daniel P. Berrange
On Thu, Jun 25, 2009 at 06:05:49PM +0200, Henrik Persson E wrote: Hi, Well it doesn't really do the trick, since it maps to linux-lvm and linux-raid which is not a valid fs-type for parted. But maybe I should update the enum to reflect the valid fs-types of parted if that was the

Re: [libvirt] vTPM support in libvirt

2009-06-25 Thread Andreas Sommer
Hi again, I found out that the important files for the patch will be - domain_conf.c - util.h - domain_conf.h - xm_internal.c Guess I could figure out how to code it, but I still need to know how to install libvirt from sources. There's no documentation about it... Andreas Sommer wrote: I

Re: [libvirt] vTPM support in libvirt

2009-06-25 Thread Dave Allan
Andreas Sommer wrote: Hi again, I found out that the important files for the patch will be - domain_conf.c - util.h - domain_conf.h - xm_internal.c Guess I could figure out how to code it, but I still need to know how to install libvirt from sources. There's no documentation about it... You

[libvirt] [PATCH] Don't disable all logging with --disable-debug

2009-06-25 Thread Amy Griffis
This patch changes the automake conditional for debugging to disable only the debug output, not the entire logging module. Since the logging symbols are always visible now, I moved them to libvirt_private.syms and got rid of libvirt_debug.syms. I noticed that debugFlag wasn't being used anymore,

Re: [libvirt] VMware ESX driver status update

2009-06-25 Thread Matthias Bolte
2009/6/25 Daniel Veillard veill...@redhat.com: So I won't be able to complete the dump/create XML implementation until tomorrow (freeze for the 0.6.5 release) that was requested in order to get the driver merged into the official repository. But well, with the short release cycle of libvirt

Re: [libvirt] [PATCH 4/3] Control LXC capabilities

2009-06-25 Thread Casey Schaufler
Daniel P. Berrange wrote: On Tue, Jun 23, 2009 at 07:45:34PM -0700, Casey Schaufler wrote: Serge E. Hallyn wrote: Quoting Daniel P. Berrange (berra...@redhat.com): This patch updates the LXC driver to make use of libcap-ng for managing process capabilities. Previously