Re: [libvirt] Interface driver and ESX support

2009-09-10 Thread Shahar Klein
I'm not sure what you mean about mapping lets take the pnics as a study case for me do I need to define a structure similar to this: http://www.vmware.com/support/developer/vc-sdk/visdk400pubs/ReferenceGuide/vim.host.PhysicalNic.html and also take care for it's allocation?

[libvirt] [PATCH 2/5] Update capabilities schema to allow multiple machines per domain

2009-09-10 Thread Mark McLoughlin
* docs/schemas/capabilities.rng: allow multiple machines per domain just like they are allowed for guests --- docs/schemas/capability.rng |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/schemas/capability.rng b/docs/schemas/capability.rng index dbfe1c5..a9daa40

[libvirt] [PATCH 1/5] Add esx and tcp migration uri transports to capabilities schema

2009-09-10 Thread Mark McLoughlin
* docs/schemas/capabilities.rng: include esx and tcp uri_transport --- docs/schemas/capability.rng |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/docs/schemas/capability.rng b/docs/schemas/capability.rng index 1e3c5f3..dbfe1c5 100644 --- a/docs/schemas/capability.rng

[libvirt] [PATCH 3/5] Add arm arch to capabilities schema

2009-09-10 Thread Mark McLoughlin
* docs/schemas/capabilities.rng: add arm and sort arches --- docs/schemas/capability.rng |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/docs/schemas/capability.rng b/docs/schemas/capability.rng index a9daa40..3e8944c 100644 --- a/docs/schemas/capability.rng +++

[libvirt] [PATCH 4/5] Add a more featureful qemu capabilities test data

2009-09-10 Thread Mark McLoughlin
Things added include - x86_64 host - Migration features - NUMA topology - Security model - Canonical machine types - Domain machine types - An arm guest - More machine types for mips, mipsel, sparc and ppc - An x86_64 xenner guest This file was generated on a Fedora 12 machine

Re: [libvirt] [PATCH] Close logfile fd after spawning qemu

2009-09-10 Thread Daniel Veillard
On Thu, Sep 10, 2009 at 02:13:56PM +0900, Ryota Ozaki wrote: Hi, This patch closes logfile fd after spawing qemu in qemudStartVMDaemon. The fd seems to be closed in the error path, but not in the normal path. The fd is passed to virExecDaemonize though, but looks not being closed inside it.

Re: [libvirt] [PATCH] Close logfile fd after spawning qemu

2009-09-10 Thread Mark McLoughlin
On Thu, 2009-09-10 at 11:04 +0200, Daniel Veillard wrote: On Thu, Sep 10, 2009 at 02:13:56PM +0900, Ryota Ozaki wrote: Hi, This patch closes logfile fd after spawing qemu in qemudStartVMDaemon. The fd seems to be closed in the error path, but not in the normal path. The fd is passed to

Re: [libvirt] [PATCH] Reintroduce lzop compression

2009-09-10 Thread Daniel Veillard
On Wed, Sep 09, 2009 at 03:59:22PM -0500, Charles Duffy wrote: From 3c4f6568623ed420a9e71da33b9ce74abda289a8 Mon Sep 17 00:00:00 2001 From: Charles Duffy charles_du...@dell.com Date: Wed, 9 Sep 2009 15:53:25 -0500 Subject: [PATCH] Reintroduce support for lzop compression lzop was removed

Re: [libvirt] [PATCH] Close logfile fd after spawning qemu

2009-09-10 Thread Ryota Ozaki
On Thu, Sep 10, 2009 at 6:04 PM, Daniel Veillardveill...@redhat.com wrote:  Hum, it's not quite simple. It's passed down to __virExec() where it is provided as the stdout/stderr to use, it's not closed there on the parent though. I guess it's safe to close it at that point at the end of

Re: [libvirt] [PATCH] Fix handling of Xen(ner) detection

2009-09-10 Thread Daniel P. Berrange
On Fri, Sep 04, 2009 at 03:15:53PM +0200, Daniel Veillard wrote: On Fri, Aug 28, 2009 at 11:21:07AM +0100, Daniel P. Berrange wrote: Latest upstream QEMU can be built with Xen support, which introduces a -xen-domid argument. This was mistakenly detected as -domid due to old Xenner support.

[libvirt] [PATCH] qemu_driver.c: factor out more duplication

2009-09-10 Thread Jim Meyering
Charles Duffy wrote: From 3c4f6568623ed420a9e71da33b9ce74abda289a8 Mon Sep 17 00:00:00 2001 From: Charles Duffy charles_du...@dell.com Date: Wed, 9 Sep 2009 15:53:25 -0500 Subject: [PATCH] Reintroduce support for lzop compression lzop was removed due to some confusion over whether it provided

Re: [libvirt] [PATCH] Fix misc thread locking bugs / bogus warnings

2009-09-10 Thread Daniel P. Berrange
On Tue, Sep 08, 2009 at 04:33:24PM +0200, Daniel Veillard wrote: On Wed, Sep 02, 2009 at 02:11:50PM +0100, Daniel P. Berrange wrote: Fix all thread locking bugs reported by object-locking test case. NB, some of the driver locking is getting too coarse. Driver mutexes really need to be

Re: [libvirt] [PATCH] Close logfile fd after spawning qemu

2009-09-10 Thread Daniel Veillard
On Thu, Sep 10, 2009 at 10:15:58AM +0100, Mark McLoughlin wrote: On Thu, 2009-09-10 at 11:04 +0200, Daniel Veillard wrote: On Thu, Sep 10, 2009 at 02:13:56PM +0900, Ryota Ozaki wrote: Hi, This patch closes logfile fd after spawing qemu in qemudStartVMDaemon. The fd seems to be

Re: [libvirt] [PATCH 02/11] Avoid polling on FDs with no events enabled

2009-09-10 Thread Chris Lalancette
Chris Lalancette wrote: Daniel Veillard wrote: On Mon, Aug 24, 2009 at 09:51:05PM +0100, Daniel P. Berrange wrote: If a file descriptor with events=0 was added to the libvirtd event loop, it would still be added to the poll() fds' array. While it wouldn't see any POLLIN/OUT events, it'd still

Re: [libvirt] [PATCH] qemu_driver.c: factor out more duplication

2009-09-10 Thread Daniel Veillard
On Thu, Sep 10, 2009 at 11:34:37AM +0200, Jim Meyering wrote: Charles Duffy wrote: From 3c4f6568623ed420a9e71da33b9ce74abda289a8 Mon Sep 17 00:00:00 2001 From: Charles Duffy charles_du...@dell.com Date: Wed, 9 Sep 2009 15:53:25 -0500 Subject: [PATCH] Reintroduce support for lzop

Re: [libvirt] 2 patches: dead increment and 4 useless (always-false) disjuncts

2009-09-10 Thread Daniel P. Berrange
On Tue, Sep 08, 2009 at 10:35:07AM +0200, Daniel Veillard wrote: On Mon, Sep 07, 2009 at 06:33:13PM +0200, Jim Meyering wrote: Daniel Veillard wrote: On Mon, Sep 07, 2009 at 05:37:24PM +0200, Jim Meyering wrote: From 74f57af2010f9cbe2315d625c6502a0b259e6802 Mon Sep 17 00:00:00 2001

Re: [libvirt] [PATCH] Close logfile fd after spawning qemu

2009-09-10 Thread Ryota Ozaki
On Thu, Sep 10, 2009 at 6:35 PM, Daniel Veillardveill...@redhat.com wrote: On Thu, Sep 10, 2009 at 10:15:58AM +0100, Mark McLoughlin wrote: On Thu, 2009-09-10 at 11:04 +0200, Daniel Veillard wrote: On Thu, Sep 10, 2009 at 02:13:56PM +0900, Ryota Ozaki wrote: Hi, This patch closes

[libvirt] [PATCH] Fix regression from Avoid polling on FDs with no events

2009-09-10 Thread Chris Lalancette
After the mentioned patch was applied, I noticed that shutting down a kvm guest from inside (i.e. poweroff) caused the guest to shutdown, but not removed from the list of active guests. DanB pointed out that the problem is that the virEventAddHandle() call in the qemu driver was asking to watch

Re: [libvirt] [PATCH] qemu_driver.c: factor out more duplication

2009-09-10 Thread Jim Meyering
Daniel Veillard wrote: ... This completes the job: From 05b3f087b7ac29cebd22dfdf099f8fb36a31c86a Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Thu, 10 Sep 2009 11:26:00 +0200 Subject: [PATCH] qemu_driver.c: factor out more duplication * src/qemu_driver.c

Re: [libvirt] [PATCH] Fix regression from Avoid polling on FDs with no events

2009-09-10 Thread Daniel P. Berrange
On Thu, Sep 10, 2009 at 11:50:36AM +0200, Chris Lalancette wrote: After the mentioned patch was applied, I noticed that shutting down a kvm guest from inside (i.e. poweroff) caused the guest to shutdown, but not removed from the list of active guests. DanB pointed out that the problem is that

Re: [libvirt] [PATCH] Fix regression from Avoid polling on FDs with no events

2009-09-10 Thread Chris Lalancette
Daniel P. Berrange wrote: On Thu, Sep 10, 2009 at 11:50:36AM +0200, Chris Lalancette wrote: After the mentioned patch was applied, I noticed that shutting down a kvm guest from inside (i.e. poweroff) caused the guest to shutdown, but not removed from the list of active guests. DanB pointed

Re: [libvirt] [PATCH 1/5] Add esx and tcp migration uri transports to capabilities schema

2009-09-10 Thread Daniel Veillard
On Thu, Sep 10, 2009 at 09:59:01AM +0100, Mark McLoughlin wrote: * docs/schemas/capabilities.rng: include esx and tcp uri_transport --- docs/schemas/capability.rng |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/docs/schemas/capability.rng

Re: [libvirt] [PATCH 2/5] Update capabilities schema to allow multiple machines per domain

2009-09-10 Thread Daniel Veillard
On Thu, Sep 10, 2009 at 09:59:02AM +0100, Mark McLoughlin wrote: * docs/schemas/capabilities.rng: allow multiple machines per domain just like they are allowed for guests --- docs/schemas/capability.rng |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [libvirt] [PATCH 3/5] Add arm arch to capabilities schema

2009-09-10 Thread Daniel Veillard
On Thu, Sep 10, 2009 at 09:59:03AM +0100, Mark McLoughlin wrote: * docs/schemas/capabilities.rng: add arm and sort arches --- docs/schemas/capability.rng |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/docs/schemas/capability.rng

Re: [libvirt] [PATCH 4/5] Add a more featureful qemu capabilities test data

2009-09-10 Thread Daniel Veillard
On Thu, Sep 10, 2009 at 09:59:04AM +0100, Mark McLoughlin wrote: Things added include - x86_64 host - Migration features - NUMA topology - Security model - Canonical machine types - Domain machine types - An arm guest - More machine types for mips, mipsel, sparc and ppc

Re: [libvirt] [PATCH 5/5] Add qemu -help test data for qemu-kvm-0.11.0-rc2

2009-09-10 Thread Daniel Veillard
On Thu, Sep 10, 2009 at 09:59:05AM +0100, Mark McLoughlin wrote: * tests/qemuhelpdata/qemu-kvm-0.11.0-rc2: add data * tests/qemuhelptest.c: add expected output --- .gnulib|2 +- tests/qemuhelpdata/qemu-kvm-0.11.0-rc2 | 177

[libvirt] [PATCH 04/10] Re-factor qemu test machine allocation code

2009-09-10 Thread Mark McLoughlin
* test/testutilsqemu.c: split out code to testQemuAllocMachines() and make use of the ARRAY_CARDINALITY macro --- tests/testutilsqemu.c | 30 +- 1 files changed, 21 insertions(+), 9 deletions(-) diff --git a/tests/testutilsqemu.c b/tests/testutilsqemu.c index

[libvirt] [PATCH 01/10] Fix formatting of machine types in capabilities XML

2009-09-10 Thread Mark McLoughlin
* src/capabilities.c: fix machine type formatting in virCapabilitiesFormatXML() --- src/capabilities.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/capabilities.c b/src/capabilities.c index 289180d..38fe7fc 100644 --- a/src/capabilities.c +++

[libvirt] [PATCH 02/10] Dump qemu driver capabilities if test debugging enabled

2009-09-10 Thread Mark McLoughlin
* src/testutils.[ch]: make testDebug externally available * src/testutilsqemu.c: if VIR_TEST_DEBUG is set, dump the qemu driver capabilities to stderr --- tests/testutils.c |3 ++- tests/testutils.h |2 ++ tests/testutilsqemu.c | 14 ++ 3 files changed, 18

[libvirt] [PATCH 05/10] Test qemu machine aliases

2009-09-10 Thread Mark McLoughlin
* tests/testutilsqemu.c: make 'pc' an alias for qemu-system-x86_64 * tests/qemuxml2argvdata/qemuxml2argv-machine-aliases1.*, tests/qemuxml2argvtest.c: add a test which uses qemu-system-x86_64 and make sure the machine type is canonicalized. --- .../qemuxml2argv-machine-aliases1.args

[libvirt] [PATCH 09/10] Simplify and fix qemudCanonicalizeMachine()

2009-09-10 Thread Mark McLoughlin
The algorithm is quite simple: If the emulator matches a guest's domain: if domain has machine type info: check the domain's machine type info else check the guest's default machine type info else if the emulator matches the guest's default emulator: check the guest's

[libvirt] [PATCH 10/10] Test that domain-specific qemu machine types are used correctly

2009-09-10 Thread Mark McLoughlin
* tests/testutilsqemu.c: add a machine types list for /usr/bin/kvm which doesn't have any aliases, while the guest has aliases * tests/qemuxml2argvdata/qemuxml2argv-machine-aliases2.*, tests/qemuxml2argvtest.c: add a test using /usr/bin/kvm and make sure that 'pc' machine type doesn't get

[libvirt] [PATCH 08/10] Probe machine types from kvm binary too

2009-09-10 Thread Mark McLoughlin
Currently we only probe the main qemu binary for machine types, but we should also probe the kvm binary. * src/qemu_conf.c: probe kvm binary machines in qemudCapsInitGuest() --- src/qemu_conf.c | 50 ++ 1 files changed, 42 insertions(+), 8

[libvirt] [PATCH 07/10] Look up machine types from all domains in qemudGetOldMachines()

2009-09-10 Thread Mark McLoughlin
Rather than just looking at the default domain info, look at all domains * src/qemu_conf.c: look at all domains in qemudGetOldMachines() --- src/qemu_conf.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/src/qemu_conf.c b/src/qemu_conf.c index 882f9f9..0d498c2

[libvirt] [PATCH 06/10] Split up qemudGetOldMachines()

2009-09-10 Thread Mark McLoughlin
We need to look at all the domain infos in guest capabilities, not just the defaults. In order to allow that, split out a qemudGetOldMachinesFromInfo() from qemudGetOldMachines(). We'll make more use of it in the next patch. * src/qemu_conf.c: split out qemudGetOldMachinesFromInfo() from

Re: [libvirt][qemu] unable to start guest under kvm

2009-09-10 Thread Mark McLoughlin
Hi, Okay, I've got this fixed for certain now. Definitely. I think. The problem turned out to be that qemudCanonicalizeMachine() was using the alias in the default machine types if the domain's machine types didn't have an alias that matched. We even have a test for this

Re: [libvirt] [PATCH 5/5] Add qemu -help test data for qemu-kvm-0.11.0-rc2

2009-09-10 Thread Mark McLoughlin
On Thu, 2009-09-10 at 13:32 +0200, Daniel Veillard wrote: On Thu, Sep 10, 2009 at 09:59:05AM +0100, Mark McLoughlin wrote: * tests/qemuhelpdata/qemu-kvm-0.11.0-rc2: add data * tests/qemuhelptest.c: add expected output --- .gnulib|2 +-

Re: [libvirt] Resubmission: [PATCH 1/6] sVirt AppArmor security driver

2009-09-10 Thread Daniel P. Berrange
On Tue, Sep 08, 2009 at 04:19:59PM -0500, Jamie Strandboge wrote: On Tue, 08 Sep 2009, Jamie Strandboge wrote: [PATCH 1*] patch_1a_reenable-nonfile-labels.patch: When James Morris originally submitted his sVirt patches (as seen in libvirt 0.6.1), he did not require on disk labelling

Re: [libvirt] Resubmission: [PATCH 2/6] sVirt AppArmor security driver

2009-09-10 Thread Daniel P. Berrange
On Tue, Sep 08, 2009 at 04:20:43PM -0500, Jamie Strandboge wrote: On Tue, 08 Sep 2009, Jamie Strandboge wrote: [PATCH 2] patch_2_security_c.patch: Updates src/security.c for AppArmor -- Jamie Strandboge | http://www.canonical.com diff -Nurp

[libvirt] [PATCH 03/10] Canonicalize the qemu machine type in qemuxml2argvtest

2009-09-10 Thread Mark McLoughlin
This doesn't have any affect on the current tests because we don't have any machine aliases in the current test data. * src/qemu_conf.h, src/qemu_driver.c: expose qemudCanonicalizeMachine() for the tests * tests/qemuxml2argvtest.c: canonicalize the machine type --- src/qemu_conf.h |

Re: [libvirt] Resubmission: [PATCH 5/6] sVirt AppArmor security driver

2009-09-10 Thread Daniel P. Berrange
On Tue, Sep 08, 2009 at 04:22:56PM -0500, Jamie Strandboge wrote: diff -Nurp ./libvirt.orig/examples/apparmor/usr.sbin.libvirtd ./libvirt/examples/apparmor/usr.sbin.libvirtd --- ./libvirt.orig/examples/apparmor/usr.sbin.libvirtd1969-12-31 18:00:00.0 -0600 +++

Re: [libvirt] Resubmission: [PATCH 6/6] sVirt AppArmor security driver

2009-09-10 Thread Daniel P. Berrange
On Tue, Sep 08, 2009 at 04:23:34PM -0500, Jamie Strandboge wrote: On Tue, 08 Sep 2009, Jamie Strandboge wrote: [PATCH 6] patch_6_autoconf.patch: Updates Makefile.am and configure.in for AppArmor. It is based on and should operate the same as the SELinux configuration. --

Re: [libvirt] Resubmission: [PATCH 4/6] sVirt AppArmor security driver

2009-09-10 Thread Daniel P. Berrange
On Tue, Sep 08, 2009 at 04:22:14PM -0500, Jamie Strandboge wrote: On Tue, 08 Sep 2009, Jamie Strandboge wrote: [PATCH 4] patch_4_tests.patch: Adds tests for virt-aa-helper and the security driver. secaatest.c is identical to seclabeltest.c except it initializes the 'apparmor' driver

Re: [libvirt] [PATCH 01/10] Fix formatting of machine types in capabilities XML

2009-09-10 Thread Daniel Veillard
On Thu, Sep 10, 2009 at 12:35:09PM +0100, Mark McLoughlin wrote: * src/capabilities.c: fix machine type formatting in virCapabilitiesFormatXML() --- src/capabilities.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/capabilities.c b/src/capabilities.c index

Re: [libvirt] [PATCH 02/10] Dump qemu driver capabilities if test debugging enabled

2009-09-10 Thread Daniel Veillard
On Thu, Sep 10, 2009 at 12:35:10PM +0100, Mark McLoughlin wrote: * src/testutils.[ch]: make testDebug externally available * src/testutilsqemu.c: if VIR_TEST_DEBUG is set, dump the qemu driver capabilities to stderr ACK, useful ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT

Re: [libvirt] [PATCH 03/10] Canonicalize the qemu machine type in qemuxml2argvtest

2009-09-10 Thread Daniel Veillard
On Thu, Sep 10, 2009 at 12:35:11PM +0100, Mark McLoughlin wrote: This doesn't have any affect on the current tests because we don't have any machine aliases in the current test data. * src/qemu_conf.h, src/qemu_driver.c: expose qemudCanonicalizeMachine() for the tests *

Re: [libvirt] [PATCH 04/10] Re-factor qemu test machine allocation code

2009-09-10 Thread Daniel Veillard
On Thu, Sep 10, 2009 at 12:35:12PM +0100, Mark McLoughlin wrote: * test/testutilsqemu.c: split out code to testQemuAllocMachines() and make use of the ARRAY_CARDINALITY macro --- tests/testutilsqemu.c | 30 +- 1 files changed, 21 insertions(+), 9 deletions(-)

Re: [libvirt] [PATCH 05/10] Test qemu machine aliases

2009-09-10 Thread Daniel Veillard
On Thu, Sep 10, 2009 at 12:35:13PM +0100, Mark McLoughlin wrote: * tests/testutilsqemu.c: make 'pc' an alias for qemu-system-x86_64 * tests/qemuxml2argvdata/qemuxml2argv-machine-aliases1.*, tests/qemuxml2argvtest.c: add a test which uses qemu-system-x86_64 and make sure the machine type

Re: [libvirt] Resubmission: [PATCH 3/6] sVirt AppArmor security driver

2009-09-10 Thread Daniel P. Berrange
On Tue, Sep 08, 2009 at 04:21:23PM -0500, Jamie Strandboge wrote: diff -Nurp ./libvirt.orig/src/security_apparmor.c ./libvirt/src/security_apparmor.c --- ./libvirt.orig/src/security_apparmor.c1969-12-31 18:00:00.0 -0600 +++ ./libvirt/src/security_apparmor.c 2009-09-08

Re: [libvirt] [PATCH 06/10] Split up qemudGetOldMachines()

2009-09-10 Thread Daniel Veillard
On Thu, Sep 10, 2009 at 12:35:14PM +0100, Mark McLoughlin wrote: We need to look at all the domain infos in guest capabilities, not just the defaults. In order to allow that, split out a qemudGetOldMachinesFromInfo() from qemudGetOldMachines(). We'll make more use of it in the next patch.

Re: [libvirt] [PATCH 07/10] Look up machine types from all domains in qemudGetOldMachines()

2009-09-10 Thread Daniel Veillard
On Thu, Sep 10, 2009 at 12:35:15PM +0100, Mark McLoughlin wrote: Rather than just looking at the default domain info, look at all domains * src/qemu_conf.c: look at all domains in qemudGetOldMachines() --- I'm not entierely clear of what this actually does, but it sounds fine. Not 100%

Re: [libvirt] [PATCH 08/10] Probe machine types from kvm binary too

2009-09-10 Thread Daniel Veillard
On Thu, Sep 10, 2009 at 12:35:16PM +0100, Mark McLoughlin wrote: Currently we only probe the main qemu binary for machine types, but we should also probe the kvm binary. * src/qemu_conf.c: probe kvm binary machines in qemudCapsInitGuest() --- src/qemu_conf.c | 50

Re: [libvirt] [PATCH 09/10] Simplify and fix qemudCanonicalizeMachine()

2009-09-10 Thread Daniel Veillard
On Thu, Sep 10, 2009 at 12:35:17PM +0100, Mark McLoughlin wrote: The algorithm is quite simple: If the emulator matches a guest's domain: if domain has machine type info: check the domain's machine type info else check the guest's default machine type info else if

Re: [libvirt] [PATCH 10/10] Test that domain-specific qemu machine types are used correctly

2009-09-10 Thread Daniel Veillard
On Thu, Sep 10, 2009 at 12:35:18PM +0100, Mark McLoughlin wrote: * tests/testutilsqemu.c: add a machine types list for /usr/bin/kvm which doesn't have any aliases, while the guest has aliases * tests/qemuxml2argvdata/qemuxml2argv-machine-aliases2.*, tests/qemuxml2argvtest.c: add a test

Re: [libvirt] libvir: QEMU error : remoteDomainProcessEvent: unmarshalling msg

2009-09-10 Thread Daniel P. Berrange
On Mon, Sep 07, 2009 at 05:46:51PM +0300, Kenneth Nagin wrote: Chris Lalancette clala...@redhat.com wrote on 07/09/2009 17:29:10: Kenneth Nagin wrote: I am monitoring events using the example event monitor, event-test, but remoteDomainProcessEvent is outputing an unmarshalling msg error

Re: [libvirt] Re: [PATCH] also allow use of XZ for Qemu image compression

2009-09-10 Thread Charles Duffy
Jim Meyering wrote: Daniel Veillard wrote: Hum, I realize that support of LZOP was added after 0.7.0, so we never made a release with it (well except for git snapshot which may have been pushed). I wonder if the best is not to just drop the lzop option altogether and stick xz as a package

Re: [libvirt] [PATCH 09/10] Simplify and fix qemudCanonicalizeMachine()

2009-09-10 Thread Mark McLoughlin
On Thu, 2009-09-10 at 14:13 +0200, Daniel Veillard wrote: On Thu, Sep 10, 2009 at 12:35:17PM +0100, Mark McLoughlin wrote: The algorithm is quite simple: If the emulator matches a guest's domain: if domain has machine type info: check the domain's machine type info

[libvirt] Trouble booting Xen VM with NFS root file system

2009-09-10 Thread Matthias Schmidt
Hi, I'm currently trying to boot a Xen VM with the root file system on NFS via libvirt. Previously we used a small python script and xm create to boot a number of VMs (which worked fine). Now I'm trying to integrate that functionality in a python project which uses libvirt, but sadly booting

[libvirt] [PATCH] Fix use of dlopen modules

2009-09-10 Thread Daniel P. Berrange
Remove the bogus dependancy between node_device.c storage_backend.c by moving the virWaitForDevices into util.h where it can be shared safely * src/storage_backend_disk.c, src/storage_backend_logical.c, src/storage_backend_mpath.c, src/storage_backend_scsi.c: Replace

Re: [libvirt] [PATCH] Fix use of dlopen modules

2009-09-10 Thread Daniel Veillard
On Thu, Sep 10, 2009 at 02:31:00PM +0100, Daniel P. Berrange wrote: Remove the bogus dependancy between node_device.c storage_backend.c by moving the virWaitForDevices into util.h where it can be shared safely * src/storage_backend_disk.c, src/storage_backend_logical.c,

Re: [libvirt] [PATCH] Fix use of dlopen modules

2009-09-10 Thread Daniel P. Berrange
On Thu, Sep 10, 2009 at 03:57:07PM +0200, Daniel Veillard wrote: On Thu, Sep 10, 2009 at 02:31:00PM +0100, Daniel P. Berrange wrote: Remove the bogus dependancy between node_device.c storage_backend.c by moving the virWaitForDevices into util.h where it can be shared safely *

Re: [libvirt] [PATCH 01/10] Add usage to secret docs

2009-09-10 Thread Daniel P. Berrange
On Tue, Sep 08, 2009 at 10:43:30AM +0200, Daniel Veillard wrote: On Mon, Sep 07, 2009 at 04:12:36PM +0200, Miloslav Trma?? wrote: * docs/formatsecret.html.in, docs/formatsecret.html: Document usage type='volume', replacing stand-alone volume. * docs/schemas/secret.rng: Update schema to

Re: [libvirt] [PATCH 08/10] Consolidate cont into qemudMonitorSendCont()

2009-09-10 Thread Daniel P. Berrange
On Mon, Sep 07, 2009 at 04:12:43PM +0200, Miloslav Trma?? wrote: The interface allows qemudMonitorSendCont() to report errors that are not overridden by its callers. Also fix a potential infinite loop in qemuDomainCoreDump() if sending cont repeatedly fails. Changes since the fourth

Re: [libvirt] [PATCH 02/10] Add VIR_SECRET_GET_VALUE_INTERNAL_CALL.

2009-09-10 Thread Daniel P. Berrange
On Mon, Sep 07, 2009 at 04:12:37PM +0200, Miloslav Trma?? wrote: Add a VIR_SECRET_GET_VALUE_INTERNAL_CALL flag value, replacing the originally separate libvirt_internal_call parameter. The flag is used to differentiate external virSecretGetValue() calls from internal calls by libvirt drivers

Re: [libvirt] Interface driver and ESX support

2009-09-10 Thread Matthias Bolte
2009/9/10 Shahar Klein shaharkl...@yahoo.com: I'm not sure what you mean about mapping lets take the pnics as a study case for me do I need to define a structure similar to this: http://www.vmware.com/support/developer/vc-sdk/visdk400pubs/ReferenceGuide/vim.host.PhysicalNic.html and also take

[libvirt] [RFC,PATCH] network: add 'netboot' option to dhcp config

2009-09-10 Thread Jeremy Kerr
Currently, libvirtd will start a dnsmasq process for the virtual network, but (aside from killing the dnsmasq process and replacing it), there's no way to define tftp boot options. This change introduces a 'netboot' tag to the dhcp configuration: network namedefault/name bridge