Re: [libvirt] 0.7.1 compile fails on opensuse 11.1

2009-09-23 Thread Dominik Klein
1 https://bugzilla.novell.com/show_bug.cgi?id=54094 That bug # is incorrect and I had no luck searching bugzilla for such a bug description. Can you check the bug id again? I missed a 2 there. Copy/paste error. Sorry. https://bugzilla.novell.com/show_bug.cgi?id=540942 Regards Dominik

Re: [libvirt] 0.7.1 compile fails on opensuse 11.1

2009-09-23 Thread Dominik Klein
Pritesh Kothari wrote: it seems openSuSE 11.1 does not come with a pkgconfig for the device-mapper-devel package. I created a bug [1] for opensuse but was also told to mention it here so configure.in could be patched once the bug was fixed. Hi All, Just fixed this for ubuntu (should work

[libvirt] [PATCH] Fix up make check

2009-09-23 Thread Chris Lalancette
While running make check, I noticed that it was actually using the virsh binary from my system, in /usr/bin/virsh, and not the one that was just compiled. This doesn't seem to be the intent, so I changed all of the test scripts to point to the one built in-tree, not the system one.

Re: [libvirt] [PATCH] network: add 'bootp' and 'tftp' config

2009-09-23 Thread Paolo Bonzini
Since everyone seems to be happy with this now, I've pushed it. Thanks Chris! Paolo -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] qemu_driver migrateuri handling broken?

2009-09-23 Thread Chris Lalancette
Gregor Schaffrath wrote: On Mon, Sep 21, 2009 at 12:46:46PM +0100, Daniel P. Berrange wrote: On Wed, Sep 16, 2009 at 05:42:50PM +0200, Gregor Schaffrath wrote: Hi all. Short summary on DV's request ;) I ran into a problem migrating kvm machines with libvirt-0.6.5: 1) At first, using the

Re: [libvirt] Re: OpenVZ : The restriction of domain name should be addressed

2009-09-23 Thread Chris Lalancette
Yuji NISHIDA wrote: Hi Daniel Fixed patch according to your comments in openvzDomainDefineCmd func. --- a/src/openvz_driver.c +++ b/src/openvz_driver.c @@ -101,6 +101,9 @@ static int openvzDomainDefineCmd(virConnectPtr conn, virDomainDefPtr vmdef) {

Re: [libvirt] virsh capabilities, kvm with apic and toggle

2009-09-23 Thread Chris Lalancette
Garry Dolley wrote: When I run 'virsh capabilities' on a libvirt 0.6.4 system with qemu 0.10 and kvm-84, one of the results I get is: guest os_typehvm/os_type arch name='x86_64' wordsize64/wordsize emulator/usr/bin/qemu-system-x86_64/emulator

Re: [libvirt] qemu_driver migrateuri handling broken?

2009-09-23 Thread Daniel P. Berrange
On Wed, Sep 23, 2009 at 10:05:36AM +0200, Chris Lalancette wrote: Gregor Schaffrath wrote: On Mon, Sep 21, 2009 at 12:46:46PM +0100, Daniel P. Berrange wrote: On Wed, Sep 16, 2009 at 05:42:50PM +0200, Gregor Schaffrath wrote: Hi all. Short summary on DV's request ;) I ran into a

Re: [libvirt] [PATCH] Fix up make check

2009-09-23 Thread Daniel P. Berrange
On Wed, Sep 23, 2009 at 09:33:58AM +0200, Chris Lalancette wrote: While running make check, I noticed that it was actually using the virsh binary from my system, in /usr/bin/virsh, and not the one that was just compiled. This doesn't seem to be the intent, so I changed all of the test scripts

Re: [libvirt] 0.7.1 compile fails on opensuse 11.1

2009-09-23 Thread Pritesh Kothari
Hi Dominik, The patch is attached below. It does not work for me. After applying the patch, configure still fails with checking for DEVMAPPER... no configure: error: You must install device-mapper-devel = 0.0 to compile libvirt Since it is still showing the old message, I guess the patch

Re: [libvirt] [PATCH] Fix up make check

2009-09-23 Thread Chris Lalancette
Daniel P. Berrange wrote: On Wed, Sep 23, 2009 at 09:33:58AM +0200, Chris Lalancette wrote: While running make check, I noticed that it was actually using the virsh binary from my system, in /usr/bin/virsh, and not the one that was just compiled. This doesn't seem to be the intent, so I

[libvirt] [PATCH] Fix up make check

2009-09-23 Thread Chris Lalancette
While running make check, I noticed that it was actually using the virsh binary from my system, in /usr/bin/virsh, and not the one that was just compiled. This is actually caused by a bug in Makefile.am, where we didn't update the PATH to include tools. While here, I also updated all of the

Re: [libvirt] ESX [01/12]: Add esxNodeGetFreeMemory()

2009-09-23 Thread Daniel Veillard
On Mon, Sep 14, 2009 at 02:40:13AM +0200, Matthias Bolte wrote: * src/esx/esx_driver.c: add esxNodeGetFreeMemory(), cache IP address * src/esx/esx_vi.[ch]: refactor resource pool query into esxVI_GetResourcePool() * src/esx/esx_vi_types.[ch]: bind VI type ResourcePoolResourceUsage Okay, I

Re: [libvirt] ESX: Check if a datastore is accessible before accessing its URL property

2009-09-23 Thread Daniel Veillard
On Wed, Sep 16, 2009 at 06:59:32PM +0200, Matthias Bolte wrote: An inaccessible datastore has no valid URL property. * src/esx/esx_vi.c: esxVI_LookupDatastoreByName(): check if datastore is accessible before accessing its URL property * src/esx/esx_vmx.c: update to changed datastore

[libvirt] building libvirtd fails on libxml-2

2009-09-23 Thread Dan Bar Dov
I'm running on Centos5.3 Building using: ./autogen.sh --prefix=/usr configure fails with checking libxml2 xml2-config = 2.6.0 ... configure: error: Could not find libxml2 anywhere (see config.log for details). but rpm -qa | grep libxml2 libxml2-python-2.6.26-2.1.2.7 libxml2-2.6.26-2.1.2.7

Re: [libvirt] building libvirtd fails on libxml-2

2009-09-23 Thread Paolo Bonzini
On 09/23/2009 03:23 PM, Dan Bar Dov wrote: I'm running on Centos5.3 Building using: ./autogen.sh --prefix=/usr configure fails with checking libxml2 xml2-config = 2.6.0 ... configure: error: Could not find libxml2 anywhere (see config.log for details). but rpm -qa | grep libxml2

Re: [libvirt] RFC: Rename / move / delete files in GIT

2009-09-23 Thread Mark McLoughlin
On Tue, 2009-09-15 at 11:38 +0100, Daniel P. Berrange wrote: With the 0.7.1 relesae out of the way I'd like to suggest that we take this time to move around some files in GIT to correct some long standing wierd/bad naming decisions :-) The qemud/ directory is better named 'daemon', and

Re: [libvirt] [PATCH] Allow control over QEMU audio backend

2009-09-23 Thread Daniel Veillard
On Tue, Sep 22, 2009 at 11:45:02AM +0100, Daniel P. Berrange wrote: When using VNC for graphics + keyboard + mouse, we shouldn't then use the host OS for audio. Audio should go back over VNC. When using SDL for graphics, we should use the host OS for audio since that's where the display is.

Re: [libvirt] [PATCH] Allow control over QEMU audio backend

2009-09-23 Thread Daniel P. Berrange
On Wed, Sep 23, 2009 at 04:27:30PM +0200, Daniel Veillard wrote: On Tue, Sep 22, 2009 at 11:45:02AM +0100, Daniel P. Berrange wrote: When using VNC for graphics + keyboard + mouse, we shouldn't then use the host OS for audio. Audio should go back over VNC. When using SDL for graphics,

Re: [libvirt] RFC: Rename / move / delete files in GIT

2009-09-23 Thread Daniel P. Berrange
On Wed, Sep 23, 2009 at 03:25:28PM +0100, Mark McLoughlin wrote: On Tue, 2009-09-15 at 11:38 +0100, Daniel P. Berrange wrote: With the 0.7.1 relesae out of the way I'd like to suggest that we take this time to move around some files in GIT to correct some long standing wierd/bad naming

Re: [libvirt] building libvirtd fails on libxml-2

2009-09-23 Thread Daniel Veillard
On Wed, Sep 23, 2009 at 04:21:32PM +0200, Paolo Bonzini wrote: On 09/23/2009 03:23 PM, Dan Bar Dov wrote: I'm running on Centos5.3 Building using: ./autogen.sh --prefix=/usr configure fails with checking libxml2 xml2-config = 2.6.0 ... configure: error: Could not find libxml2 anywhere (see

Re: [libvirt] building libvirtd fails on libxml-2

2009-09-23 Thread Dan Bar Dov
Right. Now after it compiled and installed, I get: ImportError: No module named libvirtmod That after I manually entered the python dir and installed libvirt.py since the Makefile has all of the python generation and installation commented out. What I cannot figure out is what generates

Re: [libvirt] Re: OpenVZ : The restriction of domain name should be addressed

2009-09-23 Thread Daniel Veillard
On Wed, Sep 23, 2009 at 10:22:51AM +0200, Chris Lalancette wrote: Yuji NISHIDA wrote: Hi Daniel Fixed patch according to your comments in openvzDomainDefineCmd func. --- a/src/openvz_driver.c +++ b/src/openvz_driver.c @@ -101,6 +101,9 @@ static int

Re: [libvirt] building libvirtd fails on libxml-2

2009-09-23 Thread Dan Bar Dov
Looks like make install in the python dir does nothing: [r...@earth python]# pwd /root/Desktop/libvirt-0.7.1/python [r...@earth python]# make Making all in . make[1]: Entering directory `/root/Desktop/libvirt-0.7.1/python' make[1]: Nothing to be done for `all-am'. make[1]: Leaving directory

[libvirt] [PATCH] Fix a typo in virDiskHasValidPciAddr()

2009-09-23 Thread Jiri Denemark
Signed-off-by: Jiri Denemark jdene...@redhat.com --- src/conf/domain_conf.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 09368d9..d494e54 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -125,7

[libvirt] [PATCH 0/5] Python fixes

2009-09-23 Thread Cole Robinson
The following series fixes some functional (and cosmetic) issues with the python bindings. Thanks, Cole Cole Robinson (5): python: Don't generate conflicting conn.createXML functions. python: Add a newline between virConnect and virNode for readability. python: Don't generate bindings for

[libvirt] [PATCH 1/5] python: Don't generate conflicting conn.createXML functions.

2009-09-23 Thread Cole Robinson
A special case in the generator wasn't doing its job, and duplicate conn.createXML functions were being generated. The bindings diff is: $ diff -rup ../tmp libvirt.py --- ../tmp 2009-09-23 11:57:11.649203000 -0400 +++ libvirt.py 2009-09-23 11:58:15.165391000 -0400 @@ -1079,14 +1079,6 @@ class

[libvirt] [PATCH 2/5] python: Add a newline between virConnect and virNode for readability.

2009-09-23 Thread Cole Robinson
In the generated bindings, they are squashed on top of each other. Signed-off-by: Cole Robinson crobi...@redhat.com --- python/virConnect.py |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/python/virConnect.py b/python/virConnect.py index 1fdf548..096a1ba 100644 ---

[libvirt] [PATCH 4/5] python: Use a pure python implementation of 'vir*GetConnect'

2009-09-23 Thread Cole Robinson
The API docs explictly warn that we shouldn't use the C vir*GetConnect calls in bindings: doing so can close the internal connection pointer and cause things to get screwy. Implement these calls in python. Signed-off-by: Cole Robinson crobi...@redhat.com --- python/generator.py | 21

[libvirt] [PATCH 5/5] python: Fix generated virInterface method names

2009-09-23 Thread Cole Robinson
A mistake in the generator was causing virInterface methods to be generated with unpredicatable names ('ceUndefine', instead of just 'undefine'). This fixes the method names to match existing convention. Does anyone care if we are breaking API compat? My guess is that no one is using the python

Re: [libvirt] [PATCH 2/5] python: Add a newline between virConnect and virNode for readability.

2009-09-23 Thread Daniel P. Berrange
On Wed, Sep 23, 2009 at 01:01:25PM -0400, Cole Robinson wrote: In the generated bindings, they are squashed on top of each other. Signed-off-by: Cole Robinson crobi...@redhat.com --- python/virConnect.py |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git

Re: [libvirt] [PATCH 5/5] python: Fix generated virInterface method names

2009-09-23 Thread Daniel P. Berrange
On Wed, Sep 23, 2009 at 01:01:28PM -0400, Cole Robinson wrote: A mistake in the generator was causing virInterface methods to be generated with unpredicatable names ('ceUndefine', instead of just 'undefine'). This fixes the method names to match existing convention. Does anyone care if we

[libvirt] Miscellaneous fixes to build with -Werror

2009-09-23 Thread Charles Duffy
HACKING suggests compiling with --enable-compile-warnings=error before submitting any patches; however, current master fails for me on this account (CentOS 5.3; gcc 4.1.2). Please see attached. I suspect most of these should be uncontroversial -- but wonder if perhaps virStrcpy uses would be

Re: [libvirt] [PATCH 2/5] python: Add a newline between virConnect and virNode for readability.

2009-09-23 Thread Cole Robinson
On 09/23/2009 01:09 PM, Daniel P. Berrange wrote: On Wed, Sep 23, 2009 at 01:01:25PM -0400, Cole Robinson wrote: In the generated bindings, they are squashed on top of each other. Signed-off-by: Cole Robinson crobi...@redhat.com --- python/virConnect.py |1 + 1 files changed, 1

[libvirt] Unable to read QEMU help output: Interrupted system call doing virDomainRestore() on current master

2009-09-23 Thread Charles Duffy
Howdy. I've had this issue since yesterday, but avoided reporting it until determining today that it occurs on an unmodified upstream tree as well as my own local branch: $ virsh restore ramsave error: Failed to restore domain from ramsave error: Unable to read QEMU help output: Interrupted

Re: [libvirt] Unable to read QEMU help output: Interrupted system call doing virDomainRestore() on current master

2009-09-23 Thread Charles Duffy
Charles Duffy wrote: $ virsh restore ramsave error: Failed to restore domain from ramsave error: Unable to read QEMU help output: Interrupted system call This happens immediately (no delay) and only on restore; virsh start behaves as usual. To be explicit (as I wasn't earlier) -- this is