Re: [libvirt] [PATCH] Support reporting live interface IP/netmask.

2009-09-30 Thread Paolo Bonzini
This patch adds the flag VIR_INTERFACE_XML_INACTIVE to virInterfaceGetXMLDesc's flags. What about calling it instead VIR_INTERFACE_XML_CONFIG and adding a dummy (0) VIR_INTERFACE_XML_DEVICE, and corresponding --config/--device flags to the virsh command? This would match the source

[libvirt] Re: [PATCH 1/6] Move file format enum to libvirt_util

2009-09-30 Thread Daniel P. Berrange
On Tue, Sep 29, 2009 at 09:56:44AM +0100, Mark McLoughlin wrote: Rename virStorageVolFormatFileSystem to virStorageFileFormat and move to src/util/storage_file.[ch] * src/Makefile.am: add src/util/storage_file.[ch] * src/conf/storage_conf.[ch]: move enum from here ... *

[libvirt] Re: [PATCH 2/6] Split virStorageGetMetadataFromFD() from virStorageBackendProbeTarget()

2009-09-30 Thread Daniel P. Berrange
On Tue, Sep 29, 2009 at 09:56:45AM +0100, Mark McLoughlin wrote: Prepare the code probing a file's format and associated metadata for moving into libvirt_util. * src/storage/storage_backend_fs.c: re-factor the format and metadata probing code in preparation for moving it ---

[libvirt] Re: [PATCH 4/6] Move virStorageGetMetadataFromFD() to libvirt_util

2009-09-30 Thread Daniel P. Berrange
On Tue, Sep 29, 2009 at 09:56:47AM +0100, Mark McLoughlin wrote: Finally, we get to the point of all this. Move virStorageGetMetadataFromFD() to virStorageFileGetMetadataFromFD() and move to src/util/storage_file.[ch] There's no functional changes in this patch, just code movement *

[libvirt] Re: [PATCH 5/6] Add virStorageFileGetMetadata() helper

2009-09-30 Thread Daniel P. Berrange
On Tue, Sep 29, 2009 at 09:56:48AM +0100, Mark McLoughlin wrote: * src/util/storage_file.c: add virStorageFileGetMetadata() so that the caller does not need to open the file --- src/libvirt_private.syms |1 + src/util/storage_file.c | 20

[libvirt] Re: [PATCH 6/6] Re-label image file backing stores

2009-09-30 Thread Daniel P. Berrange
On Tue, Sep 29, 2009 at 09:56:49AM +0100, Mark McLoughlin wrote: Use virStorageFileGetMetadata() to find any backing stores for images and re-label them Without this, qemu cannot access qcow2 backing files, see: https://bugzilla.redhat.com/497131 * src/security/security_selinux.c:

Re: [libvirt] Resubmission #2: [PATCH 1/3] sVirt AppArmor security driver

2009-09-30 Thread Daniel P. Berrange
On Fri, Sep 25, 2009 at 05:47:35PM -0500, Jamie Strandboge wrote: On Fri, 25 Sep 2009, Jamie Strandboge wrote: [PATCH 1] patch_1_reenable-nonfile-labels.patch (Updated based on prior feedback): When James Morris originally submitted his sVirt patches (as seen in libvirt 0.6.1), he did

[libvirt] [PATCH] minor fix's

2009-09-30 Thread Pritesh Kothari
Hi All, Just minor fix's. Regards, Pritesh diff --git a/daemon/dispatch.c b/daemon/dispatch.c index e9fe260..011d523 100644 --- a/daemon/dispatch.c +++ b/daemon/dispatch.c @@ -594,7 +594,7 @@ remoteSendStreamData(struct qemud_client *client, struct qemud_client_message *msg; XDR xdr;

Re: [libvirt] Resubmission #2: [PATCH 2/3] sVirt AppArmor security driver

2009-09-30 Thread Daniel P. Berrange
On Fri, Sep 25, 2009 at 05:49:01PM -0500, Jamie Strandboge wrote: diff -Naurp libvirt.orig/src/security/security_apparmor.c libvirt/src/security/security_apparmor.c --- libvirt.orig/src/security/security_apparmor.c 1969-12-31 18:00:00.0 -0600 +++

Re: [libvirt] [PATCH] minor fix's

2009-09-30 Thread Matthias Bolte
2009/9/30 Pritesh Kothari pritesh.koth...@sun.com: Hi All, Just minor fix's. Regards, Pritesh I came across this 64bit compile problem (with -Werror) as well, but I would fix it differently: Change the signature of remoteSendStreamData() to use unsigned int instead of size_t. This is

Re: [libvirt] Fix apibuild.py warnings

2009-09-30 Thread Daniel Veillard
On Wed, Sep 30, 2009 at 12:56:47PM +0200, Matthias Bolte wrote: apibuild.py warns about misformatted function comment for virStreamEventAddCallback, virStreamEventUpdateCallback and virStreamEventRemoveCallback. The attached patch adds the missing ':' and contains the resulting changes in

[libvirt] Tunnelled migration

2009-09-30 Thread Chris Lalancette
At long last, now that the stream stuff is committed to the tree, I can repost the tunnelled migration patches. Note that these patches will conflict in some places with danpb's previously posted PEER2PEER patches, but it should be easy to resolve the differences. -- Libvir-list mailing list

[libvirt] [PATCH] Fix up a few typos in the tree.

2009-09-30 Thread Chris Lalancette
Signed-off-by: Chris Lalancette clala...@redhat.com --- daemon/THREADING.txt|2 +- docs/drvqemu.html.in|2 +- libvirt.spec.in |2 +- src/esx/esx_driver.c|2 +- src/libvirt.c |2 +- src/openvz/openvz_driver.c

[libvirt] [PATCH] Let remoteClientStream only do RX if requested.

2009-09-30 Thread Chris Lalancette
Right now, the stream stuff assumes that a stream is always going to be used for transmit. This is not the case, and in fact doesn't work with the tunnelled migration stuff. Add a flag to remoteClientStream() to allow it to do RX only. Signed-off-by: Chris Lalancette clala...@redhat.com ---

[libvirt] [PATCH] Add a qemu feature flag for unix socket migration.

2009-09-30 Thread Chris Lalancette
Signed-off-by: Chris Lalancette clala...@redhat.com --- src/qemu/qemu_conf.c |2 ++ src/qemu/qemu_conf.h |1 + 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 2db38df..ac63570 100644 --- a/src/qemu/qemu_conf.c +++

[libvirt] [PATCH] Various monitor cleanups related to migration.

2009-09-30 Thread Chris Lalancette
The upcoming tunnelled migration needs to be able to set a migration in progress in the background, as well as be able to cancel a migration when a problem has happened. This patch allows for both of these to properly work. Signed-off-by: Chris Lalancette clala...@redhat.com ---

[libvirt] [PATCH] Tunnelled migration.

2009-09-30 Thread Chris Lalancette
Implementation of tunnelled migration, using a Unix Domain Socket on the qemu backend. Note that this requires very new versions of qemu (0.10.7 at least) in order to get the appropriate bugfixes. Signed-off-by: Chris Lalancette clala...@redhat.com --- daemon/remote.c | 45

Re: [libvirt] Fix apibuild.py warnings

2009-09-30 Thread Daniel P. Berrange
On Wed, Sep 30, 2009 at 12:56:47PM +0200, Matthias Bolte wrote: apibuild.py warns about misformatted function comment for virStreamEventAddCallback, virStreamEventUpdateCallback and virStreamEventRemoveCallback. Opps, we should make that into a fatal error really, so its easily spotted fixed

Re: [libvirt] [PATCH] Pass remote_message_header to the dispatch functions.

2009-09-30 Thread Daniel P. Berrange
On Wed, Sep 30, 2009 at 01:27:15PM +0200, Chris Lalancette wrote: This is necessary for the dispatch functions to be able to use streams in the future. Signed-off-by: Chris Lalancette clala...@redhat.com --- daemon/dispatch.c |2 +- daemon/remote.c

Re: [libvirt] [PATCH] Fix up a few typos in the tree.

2009-09-30 Thread Daniel P. Berrange
On Wed, Sep 30, 2009 at 01:27:17PM +0200, Chris Lalancette wrote: Signed-off-by: Chris Lalancette clala...@redhat.com --- daemon/THREADING.txt|2 +- docs/drvqemu.html.in|2 +- libvirt.spec.in |2 +- src/esx/esx_driver.c|2

Re: [libvirt] [PATCH] Let remoteClientStream only do RX if requested.

2009-09-30 Thread Daniel P. Berrange
On Wed, Sep 30, 2009 at 01:27:18PM +0200, Chris Lalancette wrote: Right now, the stream stuff assumes that a stream is always going to be used for transmit. This is not the case, and in fact doesn't work with the tunnelled migration stuff. Add a flag to remoteClientStream() to allow it to do

Re: [libvirt] [PATCH] Add a qemu feature flag for unix socket migration.

2009-09-30 Thread Daniel P. Berrange
On Wed, Sep 30, 2009 at 01:27:19PM +0200, Chris Lalancette wrote: Signed-off-by: Chris Lalancette clala...@redhat.com --- src/qemu/qemu_conf.c |2 ++ src/qemu/qemu_conf.h |1 + 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_conf.c

Re: [libvirt] [PATCH] Various monitor cleanups related to migration.

2009-09-30 Thread Daniel P. Berrange
On Wed, Sep 30, 2009 at 01:27:20PM +0200, Chris Lalancette wrote: The upcoming tunnelled migration needs to be able to set a migration in progress in the background, as well as be able to cancel a migration when a problem has happened. This patch allows for both of these to properly work.

Re: [libvirt] [PATCH] Tunnelled migration.

2009-09-30 Thread Daniel P. Berrange
On Wed, Sep 30, 2009 at 01:27:21PM +0200, Chris Lalancette wrote: +static int doTunnelMigrate(virDomainPtr dom, + virDomainObjPtr vm, + const char *uri, + unsigned long flags, + const char

Re: [libvirt] [PATCH] Various monitor cleanups related to migration.

2009-09-30 Thread Chris Lalancette
Daniel P. Berrange wrote: On Wed, Sep 30, 2009 at 01:27:20PM +0200, Chris Lalancette wrote: The upcoming tunnelled migration needs to be able to set a migration in progress in the background, as well as be able to cancel a migration when a problem has happened. This patch allows for both of

[libvirt] [PATCH] fixes to allow 'make rpm' to work again

2009-09-30 Thread Daniel Veillard
Just a few oversights: - examples/domain-events has no makefile, but domain-events/events-c does - we should still add examples/domain-events/events-python to the tarballs in make dist - python/libvirtclass.txt seems to have vanished from dist and builds not a big deal but

[libvirt] [PATCH] Allows for a description tag for domains

2009-09-30 Thread Daniel Veillard
https://bugzilla.redhat.com/show_bug.cgi?id=523639 feature request which makes sense to me, the simple patch attached seems to be sufficient, one can define and have the description back in the dump. Doesn't try to keep the location of the tag, it always get serialized after uuid. The only

[libvirt] [PATCH] Fix emission of domain events messages

2009-09-30 Thread Daniel P. Berrange
The code which updated the message length after writing the payload wrote the updated length word in the wrong place since the XDR object was given a buffer pointing to the start of the header payload, rather than message start. * daemon/remote.c: Fix updating of event message length so that we

[libvirt] Tunnelled migration

2009-09-30 Thread Chris Lalancette
At long last, now that the stream stuff is committed to the tree, I can repost the tunnelled migration patches. Note that these patches will conflict in some places with danpb's previously posted PEER2PEER patches, but it should be easy to resolve the differences. V2: Rework the monitor patch to

[libvirt] [PATCH] Tunnelled migration.

2009-09-30 Thread Chris Lalancette
Implementation of tunnelled migration, using a Unix Domain Socket on the qemu backend. Note that this requires very new versions of qemu (0.10.7 at least) in order to get the appropriate bugfixes. Signed-off-by: Chris Lalancette clala...@redhat.com --- daemon/remote.c | 44

Re: [libvirt] [PATCH] Allows for a description tag for domains

2009-09-30 Thread Matthias Bolte
2009/9/30 Daniel Veillard veill...@redhat.com:  https://bugzilla.redhat.com/show_bug.cgi?id=523639 feature request which makes sense to me, the simple patch attached seems to be sufficient, one can define and have the description back in the dump. Doesn't try to keep the location of the tag,

Re: [libvirt] [PATCH] Fix emission of domain events messages

2009-09-30 Thread Daniel Veillard
On Wed, Sep 30, 2009 at 02:34:46PM +0100, Daniel P. Berrange wrote: The code which updated the message length after writing the payload wrote the updated length word in the wrong place since the XDR object was given a buffer pointing to the start of the header payload, rather than message

Re: [libvirt] [PATCH] Fix emission of domain events messages

2009-09-30 Thread Daniel P. Berrange
On Wed, Sep 30, 2009 at 03:51:21PM +0200, Daniel Veillard wrote: On Wed, Sep 30, 2009 at 02:34:46PM +0100, Daniel P. Berrange wrote: The code which updated the message length after writing the payload wrote the updated length word in the wrong place since the XDR object was given a buffer

Re: [libvirt] [PATCH] Various monitor improvements for migration.

2009-09-30 Thread Daniel P. Berrange
On Wed, Sep 30, 2009 at 03:38:45PM +0200, Chris Lalancette wrote: The upcoming tunnelled migration needs to be able to set a migration in progress in the background, as well as be able to cancel a migration when a problem has happened. This patch allows for both of these to properly work.

Re: [libvirt] [PATCH] Tunnelled migration.

2009-09-30 Thread Daniel P. Berrange
On Wed, Sep 30, 2009 at 03:38:46PM +0200, Chris Lalancette wrote: Implementation of tunnelled migration, using a Unix Domain Socket on the qemu backend. Note that this requires very new versions of qemu (0.10.7 at least) in order to get the appropriate bugfixes. Signed-off-by: Chris

Re: [libvirt] [PATCH] fixes to allow 'make rpm' to work again

2009-09-30 Thread Daniel P. Berrange
On Wed, Sep 30, 2009 at 02:29:44PM +0200, Daniel Veillard wrote: Just a few oversights: - examples/domain-events has no makefile, but domain-events/events-c does - we should still add examples/domain-events/events-python to the tarballs in make dist -

Re: [libvirt] [PATCH] Allows for a description tag for domains

2009-09-30 Thread Daniel Veillard
On Wed, Sep 30, 2009 at 03:49:05PM +0200, Matthias Bolte wrote: 2009/9/30 Daniel Veillard veill...@redhat.com:  https://bugzilla.redhat.com/show_bug.cgi?id=523639 feature request which makes sense to me, the simple patch attached seems to be sufficient, one can define and have the

Re: [libvirt] [PATCH] Allows for a description tag for domains

2009-09-30 Thread Daniel P. Berrange
On Wed, Sep 30, 2009 at 02:58:07PM +0200, Daniel Veillard wrote: https://bugzilla.redhat.com/show_bug.cgi?id=523639 feature request which makes sense to me, the simple patch attached seems to be sufficient, one can define and have the description back in the dump. Doesn't try to keep the

Re: [libvirt] [PATCH] fixes to allow 'make rpm' to work again

2009-09-30 Thread Daniel Veillard
On Wed, Sep 30, 2009 at 03:13:47PM +0100, Daniel P. Berrange wrote: On Wed, Sep 30, 2009 at 02:29:44PM +0200, Daniel Veillard wrote: Just a few oversights: - examples/domain-events has no makefile, but domain-events/events-c does - we should still add

Re: [libvirt] [PATCH] Allows for a description tag for domains

2009-09-30 Thread Daniel P. Berrange
On Wed, Sep 30, 2009 at 03:49:05PM +0200, Matthias Bolte wrote: 2009/9/30 Daniel Veillard veill...@redhat.com:  https://bugzilla.redhat.com/show_bug.cgi?id=523639 feature request which makes sense to me, the simple patch attached seems to be sufficient, one can define and have the

Re: [libvirt] [PATCH] fixes to allow 'make rpm' to work again

2009-09-30 Thread Daniel P. Berrange
On Wed, Sep 30, 2009 at 04:21:48PM +0200, Daniel Veillard wrote: On Wed, Sep 30, 2009 at 03:13:47PM +0100, Daniel P. Berrange wrote: On Wed, Sep 30, 2009 at 02:29:44PM +0200, Daniel Veillard wrote: Just a few oversights: - examples/domain-events has no makefile, but

Re: [libvirt] [PATCH] Allows for a description tag for domains

2009-09-30 Thread Daniel Veillard
On Wed, Sep 30, 2009 at 03:22:43PM +0100, Daniel P. Berrange wrote: On Wed, Sep 30, 2009 at 03:49:05PM +0200, Matthias Bolte wrote: 2009/9/30 Daniel Veillard veill...@redhat.com:  https://bugzilla.redhat.com/show_bug.cgi?id=523639 feature request which makes sense to me, the simple

[libvirt] [PATCH] incorrect error message in virDomainNetDefParseXML

2009-09-30 Thread Florian Vichot
When declaring a interface type=bridge tag, source needs a bridge attribute, but the parser complains about a missing dev attribute. Florian diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 868e865..86da022 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@

Re: [libvirt] [PATCH] Allows for a description tag for domains

2009-09-30 Thread Daniel P. Berrange
On Wed, Sep 30, 2009 at 04:37:46PM +0200, Daniel Veillard wrote: On Wed, Sep 30, 2009 at 03:22:43PM +0100, Daniel P. Berrange wrote: On Wed, Sep 30, 2009 at 03:49:05PM +0200, Matthias Bolte wrote: 2009/9/30 Daniel Veillard veill...@redhat.com:  

[libvirt] [PATCH] Avoid a libvirtd crash on broken input 523418

2009-09-30 Thread Daniel Veillard
A simple typo in an XML domain file could lead to a crash, because we called STRPREFIX() on the looked up value without checking it was non-null. Patch is trivial, and should go in but I wonder if we shouldn't make those STR macros safer too like turning #define STRPREFIX(a,b)

[libvirt] virsh destroy deletes extra VMs

2009-09-30 Thread Shi Jin
Hi there, I am running Ubuntu 9.04 X64 server with KVM/libvirt. I recently found that the virsh destroy command actually delete VMs it should not delete. For example, please see the following screen copy: r...@node1:/srv/cloud/ImgRep/WinXP# virsh list Connecting to uri: qemu:///system Id Name

Re: [libvirt] virsh destroy deletes extra VMs

2009-09-30 Thread Mark McLoughlin
On Wed, 2009-09-30 at 09:34 -0700, Shi Jin wrote: Hi there, I am running Ubuntu 9.04 X64 server with KVM/libvirt. I recently found that the virsh destroy command actually delete VMs it should not delete. For example, please see the following screen copy: r...@node1:/srv/cloud/ImgRep/WinXP#

Re: [libvirt] [PATCH] Allows for a description tag for domains

2009-09-30 Thread Mark McLoughlin
On Wed, 2009-09-30 at 14:58 +0200, Daniel Veillard wrote: https://bugzilla.redhat.com/show_bug.cgi?id=523639 feature request which makes sense to me, the simple patch attached seems to be sufficient, one can define and have the description back in the dump. Doesn't try to keep the location

Re: [libvirt] [PATCH] Avoid a libvirtd crash on broken input 523418

2009-09-30 Thread Mark McLoughlin
On Wed, 2009-09-30 at 18:33 +0200, Daniel Veillard wrote: diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 868e865..9cf0af1 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -1032,7 +1032,8 @@ virDomainNetDefParseXML(virConnectPtr conn, } else

Re: [libvirt] [PATCH] incorrect error message in virDomainNetDefParseXML

2009-09-30 Thread Mark McLoughlin
On Wed, 2009-09-30 at 16:41 +0200, Florian Vichot wrote: When declaring a interface type=bridge tag, source needs a bridge attribute, but the parser complains about a missing dev attribute. Florian diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 868e865..86da022 100644

Re: [libvirt] [PATCH] incorrect error message in virDomainNetDefParseXML

2009-09-30 Thread Daniel Veillard
On Wed, Sep 30, 2009 at 04:41:38PM +0200, Florian Vichot wrote: When declaring a interface type=bridge tag, source needs a bridge attribute, but the parser complains about a missing dev attribute. Okay, trivial, applied, thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT

Re: [libvirt] [PATCH] incorrect error message in virDomainNetDefParseXML

2009-09-30 Thread Daniel Veillard
On Wed, Sep 30, 2009 at 05:51:07PM +0100, Mark McLoughlin wrote: On Wed, 2009-09-30 at 16:41 +0200, Florian Vichot wrote: When declaring a interface type=bridge tag, source needs a bridge attribute, but the parser complains about a missing dev attribute. Florian diff --git

[libvirt] [PATCH] Fix USB device re-labelling

2009-09-30 Thread Mark McLoughlin
A simple misplaced break out of a switch results in: libvir: error : Failed to open file '/sys/bus/pci/devices/:00:54c./vendor': No such file or directory libvir: error : Failed to open file '/sys/bus/pci/devices/:00:54c./device': No such file or directory libvir: error : this

[libvirt] Update libvirt API and refs XML files

2009-09-30 Thread Matthias Bolte
Commit 47c8709564ac3f2ec5b4a3830ac213e69b4a44d5 Fix up a few typos in the tree triggered changes in docs/libvirt-api.xml and docs/libvirt-refs.xml. The attached patch contains this changes. The files docs/libvirt-api.xml and docs/libvirt-refs.xml are generated by apibuild.py, why are this

Re: [libvirt] virsh destroy deletes extra VMs

2009-09-30 Thread Shi Jin
Thanks a lot. I just upgraded my ubuntu 9.04 server to 9.10 alpha 6 so that the libvirt is upgraded from 0.6.1 to 0.7.0 and the problem is gone. -- Shi Jin, PhD --- On Wed, 9/30/09, Mark McLoughlin mar...@redhat.com wrote: From: Mark McLoughlin mar...@redhat.com Subject: Re: [libvirt]