Daniel Veillard wrote:
Pardon ? I'm pushing libvirt release about every month
sometime more often ... You're mixing issues IMHO !
Sorry, but I was talking about virtinst and the other GUIs.
http://virt-manager.et.redhat.com/download.html shows just
the releases from end of July (and
On Mon, Nov 02, 2009 at 03:52:28PM -0500, Cole Robinson wrote:
Hi all,
The attached patch adds a new API call for retrieving the libvirt
version used by a connection: virConnectGetLibvirtVersion. Without this,
there is currently no way to determine the libvirt version of a remote
qemu
On Tue, Nov 03, 2009 at 04:20:07PM +0100, Chris Lalancette wrote:
Cole Robinson wrote:
On 11/03/2009 07:35 AM, Chris Lalancette wrote:
When building with --disable-nls, I got a few messages like this:
storage/storage_backend.c: In function 'virStorageBackendCreateQemuImg':
* src/util/network.c: Add htons and ntohs in virSocket(Get|Set)Port
---
src/util/network.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/util/network.c b/src/util/network.c
index d67340a..56426e7 100644
--- a/src/util/network.c
+++ b/src/util/network.c
@@
Hello Daniel,
I'm running cluster of libvirt-managed KVM's, and I'm having quite a lot
of problems with libvirt concurrent access. It seems that this batch of
patches might fix some of those, right? Should I test them or wait till
next release before digging further into it and reporting?
thanks
On Tue, Nov 03, 2009 at 02:49:55PM -0500, Daniel P. Berrange wrote:
* src/util/pci.c, src/util/pci.h: Make the pciDeviceList struct
opaque to callers of the API. Add accessor methods for managing
devices in the list
* src/qemu/qemu_driver.c: Update to use APIs instead of directly
On Tue, Nov 03, 2009 at 02:49:56PM -0500, Daniel P. Berrange wrote:
* src/util/threads-pthread.c: pthreads APIs do not set errno, instead
the return value is the positive errno. Set errno based on the return
value in the wrappers
---
src/util/threads-pthread.c | 26
* src/util/network.c: Allocate an additional byte for virSocketFormatAddr's
return buffer
---
src/util/network.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/util/network.c b/src/util/network.c
index 56426e7..f6588c7 100644
--- a/src/util/network.c
+++
On Tue, Nov 03, 2009 at 02:49:57PM -0500, Daniel P. Berrange wrote:
* src/util/threads.h, src/util/threads-pthread.c,
src/libvirt_private.syms: Add virCondWaitUntil()
---
src/libvirt_private.syms |1 +
src/util/threads-pthread.c | 15 +++
src/util/threads.h |
On Wed, Nov 04, 2009 at 11:00:14AM +, Matthew Booth wrote:
* src/util/network.c: Allocate an additional byte for virSocketFormatAddr's
return buffer
---
src/util/network.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/util/network.c
On Tue, Nov 03, 2009 at 02:49:58PM -0500, Daniel P. Berrange wrote:
The qemu_driver.c code should not contain any code that interacts
with the QEMU monitor at a low level. A previous commit moved all
the command invocations out. This change moves out the code which
actually opens the monitor
On Tue, Nov 03, 2009 at 04:07:38PM +, Matthew Booth wrote:
@@ -1325,6 +1332,7 @@ virDomainChrDefParseXML(virConnectPtr conn,
char *path = NULL;
char *mode = NULL;
char *protocol = NULL;
+const char *targetType = NULL;
virDomainChrDefPtr def;
if
On Tue, Nov 03, 2009 at 04:07:39PM +, Matthew Booth wrote:
---
src/qemu/qemu_conf.c |2 ++
src/qemu/qemu_conf.h |1 +
2 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index 4fd158c..e5d19ef 100644
---
On Tue, Nov 03, 2009 at 04:07:40PM +, Matthew Booth wrote:
Note that, on its own, this patch will generate a warning about an unused
static
function.
+/* This function outputs a -chardev command line option which describes only
the
+ * host side of the character device */
+static int
On Wed, Nov 04, 2009 at 11:20:10AM +, Richard W.M. Jones wrote:
OK ... We assume therefore that qemu contains support for the
relatively new -chardev feature?
Right, I see this feature is detected in patch 4/4.
Rich.
--
Richard Jones, Virtualization Group, Red Hat
On Tue, Nov 03, 2009 at 04:11:48PM +, Matthew Booth wrote:
This patch allows the following to be specified in a qemu domain:
The patch looks sensible. What would be the problem with merging this
functionality into libvirt? It seems it could be useful for someone
supporting a RHEL 5
2009/11/3 Dave Bryson da...@miceda.org:
I'm new to libvirt. Is it possible to use the python binding with the
latest ESX support? If so, does anyone have a simple example I can try?
Thanks in advance!
Dave
Yes, just use the libvirt Python bindings as you would with Xen or
QEmu. There are
On 04/11/09 11:06, Richard W.M. Jones wrote:
Are you sure about this? According to the man page for inet_ntop the
INET*_ADDRSTRLEN macro should be long enough already:
AF_INET
src points to a struct in_addr (in network byte order) which is
converted to
Hi all,
I have started a vm using virsh create domain.xml and it starts for a
second and then its destroyed automatically. When I do xm create -f
xm cfg it works fine.
I don't know if this is relevant but
virsh net-list --all
Name State Autostart
On 04/11/09 11:30, Richard W.M. Jones wrote:
On Tue, Nov 03, 2009 at 04:11:48PM +, Matthew Booth wrote:
This patch allows the following to be specified in a qemu domain:
The patch looks sensible. What would be the problem with merging this
functionality into libvirt? It seems it could
Ok, I see that I get a kernel panic when starting with virsh but not
with xen create. Seems to be strange.
There is no apparent difference between the xm cfg and the xml description.
On Wed, Nov 4, 2009 at 12:54 PM, Ricardo Tiago rti...@gmail.com wrote:
Hi all,
I have started a vm using
On Wed, Nov 04, 2009 at 11:52:00AM +0100, Nikola Ciprich wrote:
Hello Daniel,
I'm running cluster of libvirt-managed KVM's, and I'm having quite a lot
of problems with libvirt concurrent access. It seems that this batch of
patches might fix some of those, right? Should I test them or wait
On Wed, Nov 4, 2009 at 6:02 AM, Daniel P. Berrange berra...@redhat.com wrote:
On Tue, Nov 03, 2009 at 12:23:26AM +0900, Ryota Ozaki wrote:
Note that this patch is not mature yet and still proof-
of-concept prototype, although it actually works.
Current implementation of lxc driver creates
On Wed, Nov 04, 2009 at 09:46:01PM +0900, Ryota Ozaki wrote:
On Wed, Nov 4, 2009 at 6:02 AM, Daniel P. Berrange berra...@redhat.com
wrote:
On Tue, Nov 03, 2009 at 12:23:26AM +0900, Ryota Ozaki wrote:
Note that this patch is not mature yet and still proof-
of-concept prototype, although it
On Wed, Nov 4, 2009 at 9:49 PM, Daniel P. Berrange berra...@redhat.com wrote:
On Wed, Nov 04, 2009 at 09:46:01PM +0900, Ryota Ozaki wrote:
On Wed, Nov 4, 2009 at 6:02 AM, Daniel P. Berrange berra...@redhat.com
wrote:
On Tue, Nov 03, 2009 at 12:23:26AM +0900, Ryota Ozaki wrote:
Note that
On Tue, Nov 03, 2009 at 11:50:52PM +0100, Daniel Veillard wrote:
On Tue, Oct 27, 2009 at 12:36:14PM +0100, Gerhard Stenzel wrote:
This patch adds MAC address based port filtering to the qemu driver.
Signed-off-by: Gerhard Stenzel gerhard.sten...@de.ibm.com
[...]
On Tue, Nov 03, 2009 at 02:49:59PM -0500, Daniel P. Berrange wrote:
Introduce a new qemuDomainObjPrivate object which is used to store
the private QEMU specific data associated with each virDomainObjPtr
instance. This contains a single member, an instance of the new
qemuMonitorPtr object which
On Tue, Nov 03, 2009 at 02:50:00PM -0500, Daniel P. Berrange wrote:
Decouple the monitor code from the virDomainDefPtr structure
by moving the disk encryption lookup code back into the
qemu_driver.c file. Instead provide a function callback to
the monitor code which can be invoked to retrieve
On Wed, Nov 04, 2009 at 12:45:06PM +0100, Matthias Bolte wrote:
2009/11/3 Dave Bryson da...@miceda.org:
I'm new to libvirt. Is it possible to use the python binding with the
latest ESX support? If so, does anyone have a simple example I can try?
Thanks in advance!
Dave
Yes, just
On Wed, 2009-11-04 at 12:55 +, Daniel P. Berrange wrote:
On Tue, Nov 03, 2009 at 11:50:52PM +0100, Daniel Veillard wrote:
...
Mark pointed out to me offlist, that this filtering is a little too
restrictive because it also blocks multicast + broadcast packets. We
can fix that easily
Agree virBuffer is nicer here, although it's not used anywhere else in
qemu_conf.c. Here's an updated patch which uses a virBuffer instead.
--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Note that, on its own, this patch will generate a warning about an unused static
function.
---
src/qemu/qemu_conf.c | 68 ++
1 files changed, 68 insertions(+), 0 deletions(-)
diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index
On Tue, Nov 03, 2009 at 04:11:48PM +, Matthew Booth wrote:
This patch allows the following to be specified in a qemu domain:
channel type='unix'
source mode='bind' path='/tmp/vmchannel'/
target type='vmchannel' deviceid='0200'/
/channel
This will output the following on the qemu
On Tue, 2009-11-03 at 23:17 +0100, Daniel Veillard wrote:
On Tue, Oct 27, 2009 at 12:36:09PM +0100, Gerhard Stenzel wrote:
This patch adds the files which implement the ebtables wrapper.
Signed-off-by: Gerhard Stenzel gerhard.sten...@de.ibm.com
...
+/**
+ * ebtablesSaveRules:
+ *
This is substantially the same as the last set. I don't think I changed patches
1 and 2 at all.
Patch 3 is updated to use a virBuffer as Rich Jones recommended.
Patch 4 is updated slightly for the above change, and there are a couple of
other trivial tidy ups in there.
Patch 5 is new. QEMU's
Currently a character device's target (it's interface in the guest) has only a
single property: port. This patch is in preparation for adding targets which
require other properties.
Target properties are moved into a union in virDomainChrDef, and a targetType
field is added to identify which
---
src/qemu/qemu_conf.c |2 ++
src/qemu/qemu_conf.h |1 +
2 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index 19b2d36..2981b51 100644
--- a/src/qemu/qemu_conf.c
+++ b/src/qemu/qemu_conf.c
@@ -894,6 +894,8 @@ static unsigned int
Note that, on its own, this patch will generate a warning about an unused static
function.
---
src/qemu/qemu_conf.c | 68 ++
1 files changed, 68 insertions(+), 0 deletions(-)
diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index
* src/conf/domain_conf.c: Throw an error if guestfwd address isn't IPv4
---
src/conf/domain_conf.c |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 94bce1e..ec2a1bc 100644
--- a/src/conf/domain_conf.c
+++
This patch allows the following to be specified in a qemu domain:
channel type='pipe'
source path='/tmp/guestfwd'/
target type='guestfwd' address='10.0.2.1' port='4600'/
/channel
This will output the following on the qemu command line:
-chardev pipe,id=channel0,path=/tmp/guestfwd \
-net
On Tue, Nov 03, 2009 at 02:50:01PM -0500, Daniel P. Berrange wrote:
Change the QEMU driver to not directly invoke the text mode monitor
APIs. Instead add a generic wrapper layer, which will eventually
invoke either the text or JSON protocol code as needed. Pass an
qemuMonitorPtr object into
Gerry Reno wrote:
Setup:
HOST: F11 x86_64
GUEST: F12beta x86_64
I have a number of guests setup on this host and all connect without a
problem with the 'br0' bridge on the host. I created a new guest and
loaded F12beta on it. I defined it to also use 'br0' networking but
this guest cannot
On Tue, Nov 03, 2009 at 02:50:03PM -0500, Daniel P. Berrange wrote:
Add reference counting on the virDomainObjPtr objects. With the
forthcoming asynchronous QEMU monitor, it will be neccessary to
release the lock on virDomainObjPtr while waiting for a monitor
command response. It is neccessary
On Tue, Nov 03, 2009 at 02:50:04PM -0500, Daniel P. Berrange wrote:
Change the QEMU monitor file handle watch to poll for both
read write events, as well as EOF. All I/O to/from the
QEMU monitor FD is now done in the event callback thread.
When the QEMU driver needs to send a command, it
This patch series fix and cleanup over whole lxc codes.
I want to clean up before adding more in them.
Thanks,
ozaki-r
Ryota Ozaki (3):
LXC fix wrong or out-of-date function descriptions
LXC cleanup and fix lxcError
LXC cleanup deep indentation in lxcDomainSetAutostart
---
src/lxc/lxc_container.c | 26 +++---
src/lxc/lxc_controller.c | 12 +++-
src/lxc/lxc_driver.c | 15 ++-
src/lxc/veth.c |4 ++--
4 files changed, 34 insertions(+), 23 deletions(-)
diff --git a/src/lxc/lxc_container.c
Most of cleanups are just capitalizing their messages though,
some fixes wrong error messages and awkward indentations, and
improves error messages.
---
src/lxc/lxc_container.c | 59 +-
src/lxc/lxc_controller.c | 28 ++--
src/lxc/lxc_driver.c | 103
---
src/lxc/lxc_driver.c | 61 +++--
1 files changed, 34 insertions(+), 27 deletions(-)
diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c
index 9f20d05..a917a46 100644
--- a/src/lxc/lxc_driver.c
+++ b/src/lxc/lxc_driver.c
@@ -1992,39 +1992,46
Hi.
I cannot answer for the sync when the host is suspended, but I think the
best way is to save your guest (virsh save guest /past/to/backup), take
your snapshot, restore the guest (virsh restore /path/to/backup), then
run the backup (of the snapshot and the saved state file).
I've writtent a
On Tue, Nov 03, 2009 at 02:50:05PM -0500, Daniel P. Berrange wrote:
QEMU monitor commands may sleep for a prolonged period of time.
If the virDomainObjPtr or qemu driver lock is held this will
needlessly block execution of many other API calls. it also
prevents asynchronous monitor events from
On Tue, Nov 03, 2009 at 02:50:06PM -0500, Daniel P. Berrange wrote:
Some monitor commands may take a very long time to complete. It is
not desirable to block other incoming API calls forever. With this
change, if an existing API call is holding the job lock, additional
API calls will not wait
On Tue, Nov 03, 2009 at 02:50:07PM -0500, Daniel P. Berrange wrote:
Start for on detecting dispatching async events fed into the
QEMU monitor.
In RHEL-5 fork of QEMU, the 'notify' command turns on events,
and events are prefixed with a leading '#' character.
hum, and that's likely to
On Wed, Nov 04, 2009 at 06:35:03PM +0100, Daniel Veillard wrote:
On Tue, Nov 03, 2009 at 02:50:06PM -0500, Daniel P. Berrange wrote:
Some monitor commands may take a very long time to complete. It is
not desirable to block other incoming API calls forever. With this
change, if an existing
This patch updates qemudBuildCommandLineChrDevStr to use a virBuffer instead of
a char[]. This is slightly tidier, and it makes it cleaner to (ap|pre)pend the
output in other command lines.
* src/qemu/qemu_conf.c: Update qemudBuildCommandLineChrDevStr to use a virBuffer
---
src/qemu/qemu_conf.c
This patch adds a (macro-wrapped) sentinel attribute to functions
that take a NULL-terminated variable argument list. This is a nice
debugging aid.
* src/internal.h (ATTRIBUTE_SENTINEL): New.
* src/util/buf.c (virBufferStrcat): Use it.
* src/util/ebtables.c (ebtablesAddRemoveRule): Use it.
*
Seems like a bad merge conflict.
* src/qemu/qemu_driver.c (qemudDomainMigratePerform): Do call
doPeer2PeerMigrate for VIR_MIGRATE_PEER2PEER.
---
Note: untested beyond compiling.
src/qemu/qemu_driver.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git
On Tue, Nov 03, 2009 at 02:50:09PM -0500, Daniel P. Berrange wrote:
Initial support for the new QEMU monitor protocol using JSON
as the data encoding format instead of plain text
* src/qemu/qemu_conf.c, src/qemu/qemu_conf.h: Hack to turn on QMP
mode
* src/qemu/qemu_monitor.c: Delegate to
On Wed, Nov 04, 2009 at 04:21:58PM +, Matthew Booth wrote:
Currently a character device's target (it's interface in the guest) has only a
single property: port. This patch is in preparation for adding targets which
require other properties.
Target properties are moved into a union in
On Wed, Nov 04, 2009 at 04:21:59PM +, Matthew Booth wrote:
---
src/qemu/qemu_conf.c |2 ++
src/qemu/qemu_conf.h |1 +
2 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index 19b2d36..2981b51 100644
---
On Wed, Nov 04, 2009 at 04:22:00PM +, Matthew Booth wrote:
Note that, on its own, this patch will generate a warning about an unused
static
function.
That says this patch should be squashed with the next one
---
src/qemu/qemu_conf.c | 68
On Wed, Nov 04, 2009 at 04:22:02PM +, Matthew Booth wrote:
* src/conf/domain_conf.c: Throw an error if guestfwd address isn't IPv4
---
src/conf/domain_conf.c |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
On Thu, Nov 05, 2009 at 02:19:12AM +0900, Ryota Ozaki wrote:
---
src/lxc/lxc_container.c | 26 +++---
src/lxc/lxc_controller.c | 12 +++-
src/lxc/lxc_driver.c | 15 ++-
src/lxc/veth.c |4 ++--
4 files changed, 34
On Thu, Nov 05, 2009 at 02:19:13AM +0900, Ryota Ozaki wrote:
Most of cleanups are just capitalizing their messages though,
some fixes wrong error messages and awkward indentations, and
improves error messages.
---
src/lxc/lxc_container.c | 59 +-
On Thu, Nov 05, 2009 at 02:19:14AM +0900, Ryota Ozaki wrote:
---
src/lxc/lxc_driver.c | 61 +++--
1 files changed, 34 insertions(+), 27 deletions(-)
diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c
index 9f20d05..a917a46 100644
---
On Wed, Nov 04, 2009 at 06:49:47PM +0100, Paolo Bonzini wrote:
This patch adds a (macro-wrapped) sentinel attribute to functions
that take a NULL-terminated variable argument list. This is a nice
debugging aid.
* src/internal.h (ATTRIBUTE_SENTINEL): New.
* src/util/buf.c (virBufferStrcat):
Performs changes needed when stopping a VM (which are currently duplicated
in several places, and forgotten in others).
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/test/test_driver.c | 42 +++---
1 files changed, 23 insertions(+), 19
This matches the expected behavior of state drivers such as QEMU.
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/test/test_driver.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 35299d5..343834c
Current implementation of lxc driver creates vethN named
interface(s) in the host and passes as it is to a container.
The reason why it doesn't use ethN is due to the limitation
that one namespace cannot have multiple iterfaces that have
an identical name so that we give up creating ethN named
Code to check for a VM duplicate in create/define/restore is present in
various forms throughout several drivers. Break this code out into its
own function (virDomainObjIsDuplicate) and use where applicable.
Cole Robinson (2):
qemu: Break out function to check if we can create/define/restore
Use this function in the qemu, uml, lxc, and test drivers.
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/conf/domain_conf.c | 64 +
src/conf/domain_conf.h |4 ++
src/libvirt_private.syms |1 +
src/lxc/lxc_driver.c | 68
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/qemu/qemu_driver.c | 30 --
1 files changed, 4 insertions(+), 26 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 20621d1..53f7398 100644
--- a/src/qemu/qemu_driver.c
+++
Dave Allan wrote:
Chris Lalancette wrote:
Daniel P. Berrange wrote:
On Wed, Oct 28, 2009 at 12:16:40PM +0100, Chris Lalancette wrote:
Dave Allan wrote:
Attached is a fully functional version of the node device udev
based backend, incorporating all the feedback from earlier
revisions. I
72 matches
Mail list logo
