This API call sets maximum tolerable time for which the domain is allowed
to be
paused at the end of live migration. It's supposed to be called while the
domain is being live-migrated as a reaction to migration progress.
Changes in version 3:
- use milliseconds instead of
On Fri, Mar 19, 2010 at 04:21:43PM -0400, Ric Foster wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=526913
Will this bug get fixed? I had hoped the using CLVM would keep the
guest disk image from getting corrupted if a running guest was
inadvertently started on another cluster node.
On 03/18/2010 06:04 PM, Eric Blake wrote:
ACK. I had to double-check MSDN to make sure that threads-win32 already
creates recursive mutex by default.
I don't supposed you read if its possible to make it non-recursive, since
the orginal impl is supposed to be non-recursive !
Committed. Thank you!
-- bk
On 03/20/2010 03:18 PM, Matthias Bolte wrote:
The Connect and Network classes already had finalize, add it to all
other classes that wrap libvirt objects to unify the behavior.
---
src/main/java/org/libvirt/Device.java |5 +
On Fri, Mar 19, 2010 at 03:38:49PM +, Daniel P. Berrange wrote:
The current API for domain events has a number of problems
- Only allows for domain lifecycle change events
- Does not allow the same callback to be registered multiple times
- Does not allow filtering of events to a
On Thu, Mar 18, 2010 at 02:48:46PM +0100, Daniel Veillard wrote:
On Wed, Mar 17, 2010 at 09:11:07PM +0100, Guido Günther wrote:
Hi,
virsh dominfo domain crashes with:
#0 strlen () at ../sysdeps/i386/i486/strlen.S:69
#1 0x080891c9 in qemudNodeGetSecurityModel (conn=0x8133940,
On Fri, Mar 19, 2010 at 03:38:50PM +, Daniel P. Berrange wrote:
The virtual box driver was directly accesing the domain events
structs instead of using the APIs provided. To prevent this kind
of abuse, make the struct definitions private, forcing use of the
internal APIs. This requires
On Fri, Mar 19, 2010 at 03:38:51PM +, Daniel P. Berrange wrote:
The internal domain events APIs are designed to handle the lifecycle
events. This needs to be refactored to allow arbitrary new event
types to be handled.
* The signature of virDomainEventDispatchFunc changes to use
On Fri, Mar 19, 2010 at 03:38:52PM +, Daniel P. Berrange wrote:
The current internal domain events API tracks callbacks based on
the function pointer, and only supports lifecycle events. This
adds new internal APIs for registering callbacks for other event
types. These new APIs are
This can be triggered by the qemuStartVMDaemon cleanup path if a
VM references a non-existent USB device (by product) in the XML.
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/security/security_selinux.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git
On Sat, Mar 20, 2010 at 06:14:44PM +0100, Matthias Bolte wrote:
---
tests/test-lib.sh | 10 ++
tests/testutils.c |2 +-
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/tests/test-lib.sh b/tests/test-lib.sh
index 43265f3..57fd438 100644
--- a/tests/test-lib.sh
On Mon, Mar 22, 2010 at 01:53:50AM +0100, Matthias Bolte wrote:
This is actually a consequence of the reworked required parameter
checking: Unify the required parameter check into a Validate function
instead of doing it separately im the (de)serialization part.
The required parameter
On Mon, Mar 22, 2010 at 01:55:05AM +0100, Matthias Bolte wrote:
Replace 'method' with 'function' and get the filename's suffix right.
---
src/esx/esx_device_monitor.c |2 +-
src/esx/esx_driver.c |4 ++--
src/esx/esx_driver.h |4 ++--
On Mon, Mar 22, 2010 at 01:56:46AM +0100, Matthias Bolte wrote:
Used in esxDomainLookupByName and to be used in esxDomainDefineXML later.
---
src/esx/esx_driver.c | 66 +
src/esx/esx_vi.c | 72
On Mon, Mar 22, 2010 at 02:25:32AM +0100, Matthias Bolte wrote:
---
configure.ac |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/configure.ac b/configure.ac
index 654b9a8..1a3c788 100644
--- a/configure.ac
+++ b/configure.ac
@@ -61,6 +61,7 @@ gl_INIT
On Mon, Mar 22, 2010 at 01:55:45AM +0100, Matthias Bolte wrote:
If esxVI_String_DeepCopyValue or esxVI_SelectionSpec_AppendToList fail
then selectionSpec would leak. Add a free call in the failure path to
fix the leak.
---
src/esx/esx_vi.c |4 ++--
1 files changed, 2 insertions(+), 2
On Mon, Mar 22, 2010 at 02:25:31AM +0100, Matthias Bolte wrote:
---
bootstrap.conf |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/bootstrap.conf b/bootstrap.conf
index 157092f..fb862ad 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -56,6 +56,7 @@ strsep
On Mon, Mar 22, 2010 at 02:25:34AM +0100, Matthias Bolte wrote:
This symbol is conditional, it would need to be exported conditional to
work properly with MinGW. So just remove it, as no other driver register
function is listed in the symbols files.
---
src/libvirt_private.syms |4
On Mon, Mar 22, 2010 at 02:25:33AM +0100, Matthias Bolte wrote:
This is necessary for MinGW builds.
---
src/Makefile.am |7 ++-
src/libvirt_daemon.syms | 10 ++
src/libvirt_private.syms |5 -
3 files changed, 16 insertions(+), 6 deletions(-)
create mode
On Mon, Mar 22, 2010 at 02:25:35AM +0100, Matthias Bolte wrote:
Use the __declspec(dllexport/dllimport) stuff to export the symbol,
otherwise accessing virConnectAuthPtrDefault triggers a segfault.
---
configure.ac | 11 +++
docs/apibuild.py |1 +
On Mon, Mar 22, 2010 at 02:25:36AM +0100, Matthias Bolte wrote:
The MinGW linker needs the libvirt.def file.
---
configure.ac|5 +
src/.gitignore |1 +
src/Makefile.am | 15 +++
3 files changed, 17 insertions(+), 4 deletions(-)
diff --git a/src/Makefile.am
On Mon, Mar 22, 2010 at 02:25:37AM +0100, Matthias Bolte wrote:
MinGW and gnulib don't provide SA_SIGINFO on Windows.
---
tools/virsh.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index 32895b2..1c932bd 100644
---
On Mon, Mar 22, 2010 at 02:25:39AM +0100, Matthias Bolte wrote:
Add dummy bodies for HAVE_GETPWUID_R and HAVE_MNTENT_H dependent
functions for MinGW builds.
---
src/util/util.c | 54 --
src/util/util.h |4
2 files changed, 52
On Mon, Mar 22, 2010 at 02:25:41AM +0100, Matthias Bolte wrote:
Even if gnulib can provide stubs, it won't help that much. So just
replace affected util functions (virFileOperation and virDirCreate)
with stubs on Windows. Both functions aren't used on libvirt's
client side, so this is fine for
On Mon, Mar 22, 2010 at 02:25:38AM +0100, Matthias Bolte wrote:
Now the virsh tests compile at least.
---
tests/testutils.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/tests/testutils.c b/tests/testutils.c
index 8764673..4f17e51 100644
---
On Mon, Mar 22, 2010 at 02:25:40AM +0100, Matthias Bolte wrote:
rsync is used to download .po files, but SKIP_PO=true is set and
downloading .po files is skipped.
This also fixes a problem with MinGW builds, because rsync is not
available for MinGW.
---
bootstrap.conf |1 -
1 files
On Mon, Mar 22, 2010 at 02:25:43AM +0100, Matthias Bolte wrote:
sscanf doesn't support the L modifier on Windows and gnulib has no
replacement for the scanf functions. Just replace the function with
a stub on Windows, because it's not used on the libvirt client side.
---
src/util/pci.c |
On Mon, Mar 22, 2010 at 02:25:44AM +0100, Matthias Bolte wrote:
Correctly disable pthread related code if pthread is not avialable,
in order to get it compile with MinGW on Windows.
---
src/remote/remote_driver.c |6 ++
src/util/util.c| 10 ++
2 files changed,
On Mon, Mar 22, 2010 at 02:25:42AM +0100, Matthias Bolte wrote:
MSYS' ln doesn't work well in the way bootstrap uses it with relative paths.
---
bootstrap.conf |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/bootstrap.conf b/bootstrap.conf
index
On Sun, Mar 21, 2010 at 08:07:15PM -0600, Jim Fehlig wrote:
Patch for libvirtd segfault discussed on IRC recently ...
Regards,
Jim
commit f034c0bfd7089ba3400b7a44b97540c4a8785e35
Author: Jim Fehlig jfeh...@novell.com
Date: Sun Mar 21 19:59:13 2010 -0600
Avoid libvirtd crash
On Mon, Mar 22, 2010 at 02:25:45AM +0100, Matthias Bolte wrote:
virSetCloseExec and virExecDaemonize were missing a body on Windows.
---
src/util/util.c | 34 ++
1 files changed, 30 insertions(+), 4 deletions(-)
ACK
Daniel
--
|: Red Hat, Engineering,
On Mon, Mar 22, 2010 at 10:48:32AM -0400, Cole Robinson wrote:
This can be triggered by the qemuStartVMDaemon cleanup path if a
VM references a non-existent USB device (by product) in the XML.
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/security/security_selinux.c |3 ++-
On 03/22/2010 11:05 AM, Daniel P. Berrange wrote:
On Mon, Mar 22, 2010 at 10:48:32AM -0400, Cole Robinson wrote:
This can be triggered by the qemuStartVMDaemon cleanup path if a
VM references a non-existent USB device (by product) in the XML.
Signed-off-by: Cole Robinson crobi...@redhat.com
On Fri, Mar 19, 2010 at 03:38:53PM +, Daniel P. Berrange wrote:
The libvirtd daemon impl will need to switch over to using the
new event APIs. To make this simpler, ensure all drivers currently
providing events support both the new APIs and old APIs.
ACK,
quite a bit of reformatting
On Fri, Mar 19, 2010 at 03:38:54PM +, Daniel P. Berrange wrote:
This wires up the remote driver to handle the new events APIs.
The public API allows an application to request a callback filters
events to a specific domain object, and register multiple callbacks
for the same event type. On
Daniel P. Berrange wrote:
On Sun, Mar 21, 2010 at 08:07:15PM -0600, Jim Fehlig wrote:
commit f034c0bfd7089ba3400b7a44b97540c4a8785e35
Author: Jim Fehlig jfeh...@novell.com
Date: Sun Mar 21 19:59:13 2010 -0600
Avoid libvirtd crash when cgroups is not configured on host
On Fri, Mar 19, 2010 at 03:38:55PM +, Daniel P. Berrange wrote:
Convert the domain events example program to use the new
events APIs for one of its callback registrations to demo the
new API and interoperability with the old API.
* examples/domain-events/events-c/event-test.c: Convert to
On Fri, Mar 19, 2010 at 03:38:56PM +, Daniel P. Berrange wrote:
To avoid confusion, rename the current REMOTE_PROC_DOMAIN_EVENT
message to REMOTE_PROC_DOMAIN_EVENT_LIFECYCLE. This does not
cause ABI problems, since the names are only relevant at the source
code level. On the wire they
On 03/20/2010 11:14 AM, Matthias Bolte wrote:
if test $verbose = 0 ; then
mod=`eval expr \( $counter + 1 \) % 40`
-for i in `seq $mod 40`
-do
- echo -n
-done
+if test $mod != 0 -a $mod != 1 ; then
test cond1 -a cond2 is not portable. Use test cond1 test
On Fri, Mar 19, 2010 at 03:38:57PM +, Daniel P. Berrange wrote:
The reboot event is not a normal lifecycle event, since the
virtual machine on the host does not change state. Rather the
guest OS is resetting the virtual CPUs. ie, the QEMU process
does not restart. Thus, this does not
On 03/19/2010 09:39 AM, Daniel P. Berrange wrote:
This introduces a new event type
VIR_DOMAIN_EVENT_ID_IO_ERROR
This event includes the action that is about to be taken
as a result of the watchdog triggering
typedef enum {
VIR_DOMAIN_EVENT_IO_ERROR_NONE = 0,
On 03/19/2010 09:39 AM, Daniel P. Berrange wrote:
This introduces a new event type
VIR_DOMAIN_EVENT_ID_GRAPHICS
The same event can be emitted in 3 scenarioes
s/scenarioes/scenarios/
typedef enum {
VIR_DOMAIN_EVENT_GRAPHICS_CONNECT = 0,
On 03/22/2010 08:54 AM, Daniel P. Berrange wrote:
On Mon, Mar 22, 2010 at 02:25:31AM +0100, Matthias Bolte wrote:
---
bootstrap.conf |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/bootstrap.conf b/bootstrap.conf
index 157092f..fb862ad 100644
--- a/bootstrap.conf
On Fri, Mar 19, 2010 at 03:38:58PM +, Daniel P. Berrange wrote:
This introduces a new event type
VIR_DOMAIN_EVENT_ID_RTC_CHANGE
This event includes the new UTC offset measured in seconds.
Thus there is a new callback definition for this event type
typedef void
On Mon, Mar 22, 2010 at 10:15:35AM -0600, Eric Blake wrote:
On 03/22/2010 08:54 AM, Daniel P. Berrange wrote:
On Mon, Mar 22, 2010 at 02:25:31AM +0100, Matthias Bolte wrote:
---
bootstrap.conf |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/bootstrap.conf
On Mon, Mar 22, 2010 at 05:17:42PM +0100, Daniel Veillard wrote:
On Fri, Mar 19, 2010 at 03:38:58PM +, Daniel P. Berrange wrote:
This introduces a new event type
VIR_DOMAIN_EVENT_ID_RTC_CHANGE
This event includes the new UTC offset measured in seconds.
Thus there is a new
On 03/22/2010 09:00 AM, Daniel P. Berrange wrote:
On Mon, Mar 22, 2010 at 02:25:37AM +0100, Matthias Bolte wrote:
MinGW and gnulib don't provide SA_SIGINFO on Windows.
ACK, though we could fallback to the old style signal handler for Win32
gnulib provides sigaction, and even SIGPIPE
On Fri, Mar 19, 2010 at 03:38:59PM +, Daniel P. Berrange wrote:
This introduces a new event type
VIR_DOMAIN_EVENT_ID_WATCHDOG
This event includes the action that is about to be taken
as a result of the watchdog triggering
typedef enum {
VIR_DOMAIN_EVENT_WATCHDOG_NONE = 0,
On Fri, Mar 19, 2010 at 03:39:00PM +, Daniel P. Berrange wrote:
This introduces a new event type
VIR_DOMAIN_EVENT_ID_IO_ERROR
This event includes the action that is about to be taken
as a result of the watchdog triggering
typedef enum {
VIR_DOMAIN_EVENT_IO_ERROR_NONE = 0,
On Mon, Mar 22, 2010 at 05:37:02PM +0100, Daniel Veillard wrote:
On Fri, Mar 19, 2010 at 03:38:59PM +, Daniel P. Berrange wrote:
This introduces a new event type
VIR_DOMAIN_EVENT_ID_WATCHDOG
This event includes the action that is about to be taken
as a result of the watchdog
On 03/22/2010 09:03 AM, Daniel P. Berrange wrote:
On Mon, Mar 22, 2010 at 02:25:43AM +0100, Matthias Bolte wrote:
sscanf doesn't support the L modifier on Windows and gnulib has no
replacement for the scanf functions. Just replace the function with
a stub on Windows, because it's not used on
On Fri, Mar 19, 2010 at 03:39:01PM +, Daniel P. Berrange wrote:
This introduces a new event type
VIR_DOMAIN_EVENT_ID_GRAPHICS
The same event can be emitted in 3 scenarioes
typedef enum {
VIR_DOMAIN_EVENT_GRAPHICS_CONNECT = 0,
VIR_DOMAIN_EVENT_GRAPHICS_INITIALIZE,
On Mon, Mar 22, 2010 at 04:20:59PM +, Daniel P. Berrange wrote:
On Mon, Mar 22, 2010 at 05:17:42PM +0100, Daniel Veillard wrote:
[...]
--- a/include/libvirt/libvirt.h.in
+++ b/include/libvirt/libvirt.h.in
@@ -1842,6 +1842,10 @@ int virDomainAbortJob(virDomainPtr dom);
typedef
On Mon, Mar 22, 2010 at 04:43:25PM +, Daniel P. Berrange wrote:
On Mon, Mar 22, 2010 at 05:37:02PM +0100, Daniel Veillard wrote:
On Fri, Mar 19, 2010 at 03:38:59PM +, Daniel P. Berrange wrote:
+typedef enum {
+VIR_DOMAIN_EVENT_WATCHDOG_NONE = 0,
+
On Mon, Mar 22, 2010 at 10:54:09AM -0600, Eric Blake wrote:
On 03/22/2010 09:03 AM, Daniel P. Berrange wrote:
On Mon, Mar 22, 2010 at 02:25:43AM +0100, Matthias Bolte wrote:
sscanf doesn't support the L modifier on Windows and gnulib has no
replacement for the scanf functions. Just replace
Hi,
I'm still having problems getting a virStoragePoolDefPtr from
virStoragePoolDefParseString(xml). I've tried the example xmls
in libvirt but still getting NULL.
Can someone check if the following xml when passed to
virStoragePoolDefParseString(..) returns a pointer to virStoragePoolDefPtr,
so
On Mon, Mar 22, 2010 at 06:08:46PM +, Sharadha Prabhakar (3P) wrote:
Hi,
I'm still having problems getting a virStoragePoolDefPtr from
virStoragePoolDefParseString(xml). I've tried the example xmls
in libvirt but still getting NULL.
Can someone check if the following xml when passed to
Picks up fix for gethostname compilation problems on mingw.
* .gnulib: Update to latest.
* build-aux/.gitignore: Regenerate.
---
There is also a gnulib issue with MinGW on Windows pending.
Eric and I are working on a patch for it.
This should fix it.
This patch introduces a new virDomainUpdateDeviceFlags() API to allow
the configuration of a device to be changed on the fly. It ports the
existing CDROM media change code in all drivers to use this new API
(keeps old support too). It then adds VNC password change support
in the QEMU driver using
The current virDomainAttachDevice API can be (ab)used to change
the media of an existing CDROM/Floppy device. Going forward there
will be more devices that can be configured on the fly and overloading
virDomainAttachDevice for this is not too pleasant. This patch adds
a new
Use the new virDomainUpdateDeviceFlags API to allow the VNC password
to be changed on the fly
* src/internal.h: Define STREQ_NULLABLE() which is like STREQ()
but does not crash if either argument is NULL, and treats two
NULLs as equal.
* src/libvirt_private.syms: Export
This defines the wire format for the new virDomainUpdateDeviceFlags()
API, and implements the server client side of the marshalling code.
* daemon/remote.c: Server side dispatch for virDomainUpdateDeviceFlags
* src/remote/remote_driver.c: Client side serialization for
To allow the new virDomainUpdateDeviceFlags() API to be universally
used with all drivers, this patch adds an impl to all the current
drivers which support CDROM or Floppy disk media change via the
current virDomainAttachDeviceFlags API
* src/qemu/qemu_driver.c, src/vbox/vbox_tmpl.c,
Expand the parser for the standalone device XML format to
allow inclusion of the graphics device type
* src/conf/domain_conf.h: Add virDomainGraphicsDef to
the virDomainDeviceDef struct
* src/conf/domain_conf.c: Wire up parser for virDomainGraphicsDef
to virDomainDeviceDefParse method
---
Hi,
I've mentioned this to a few folks already but I wanted to start a
proper thread.
We're struggling in qemu with usability and one area that concerns me is
the disparity in features that are supported by qemu vs what's
implemented in libvirt.
This isn't necessarily libvirt's problem if
On Mon, Mar 22, 2010 at 02:25:00PM -0500, Anthony Liguori wrote:
Hi,
I've mentioned this to a few folks already but I wanted to start a
proper thread.
We're struggling in qemu with usability and one area that concerns me is
the disparity in features that are supported by qemu vs what's
On 03/22/2010 01:05 PM, Daniel P. Berrange wrote:
--- a/src/libvirt.c
+++ b/src/libvirt.c
@@ -5147,6 +5147,10 @@ error:
* Create a virtual device attachment to backend. This function,
* having hotplug semantics, is only allowed on an active domain.
*
+ * For compatability, this
On Mon, Mar 22, 2010 at 02:25:00PM -0500, Anthony Liguori wrote:
Hi,
I've mentioned this to a few folks already but I wanted to start a
proper thread.
We're struggling in qemu with usability and one area that concerns me is
the disparity in features that are supported by qemu vs what's
On Mon, Mar 22, 2010 at 09:17:21PM +0100, Matthias Bolte wrote:
2010/3/22 Daniel P. Berrange berra...@redhat.com:
On Sat, Mar 20, 2010 at 06:14:44PM +0100, Matthias Bolte wrote:
---
tests/test-lib.sh | 10 ++
tests/testutils.c | 2 +-
2 files changed, 7 insertions(+), 5
On 03/22/2010 01:05 PM, Daniel P. Berrange wrote:
+if (virDomainUpdateDeviceFlags (dom, args-xml, args-flags) == -1) {
+virDomainFree(dom);
Inconsistency in whether there is a space before ( in function calls.
Which style is intended, or are both permitted?
Otherwise, ACK.
--
On 03/21/2010 11:21 AM, Sagar Dixit wrote:
Hi,
I came across http://wiki.libvirt.org/page/TodoSecureMigration
and very much interested in contributing to the feature.
I am looking for a mentor / more details on this project.
Do contact me if anyone is interested..
Actually, it was
Jim Meyering wrote:
Daniel P. Berrange wrote:
On Fri, Mar 19, 2010 at 05:00:21PM +0100, Jim Meyering wrote:
Per discussion a week or so ago,
here's a fix for virDomainDiskDefAssignAddress.
However, this change is incomplete, because making that function
reject erroneous input has exposed
source file=''/ results in def-disks[i]-src == NULL. But
vboxDomainDefineXML didn't check def-disks[i]-src for NULL
and expected it to be a valid string.
Add checks for def-disks[i]-src != NULL to fix the segfault.
---
src/vbox/vbox_tmpl.c |6 --
1 files changed, 4 insertions(+), 2
On 03/22/2010 01:05 PM, Daniel P. Berrange wrote:
To allow the new virDomainUpdateDeviceFlags() API to be universally
used with all drivers, this patch adds an impl to all the current
drivers which support CDROM or Floppy disk media change via the
current virDomainAttachDeviceFlags API
+
On 03/22/2010 02:40 PM, Matthias Bolte wrote:
source file=''/ results in def-disks[i]-src == NULL. But
vboxDomainDefineXML didn't check def-disks[i]-src for NULL
and expected it to be a valid string.
Add checks for def-disks[i]-src != NULL to fix the segfault.
ACK, but did you catch all the
On 03/22/2010 02:38 PM, Jim Meyering wrote:
Here's the final piece.
Here's the final series.
I'm including the result of Dan's review as a separate patch
only for review. I'll fold it into the 3/4 before pushing.
ACK from me on the series.
--
Eric Blake ebl...@redhat.com
On 03/22/2010 01:05 PM, Daniel P. Berrange wrote:
Use the new virDomainUpdateDeviceFlags API to allow the VNC password
to be changed on the fly
* src/internal.h: Define STREQ_NULLABLE() which is like STREQ()
but does not crash if either argument is NULL, and treats two
NULLs as equal.
Hi Chris,
Thanks for the reply. I was actually looking to implement / support
tunnelled migration of OpenVZ or LXC containers using libvirt APIs
Is that feasible ?
- Sagar
On Mon, Mar 22, 2010 at 4:29 PM, Chris Lalancette clala...@redhat.comwrote:
On 03/21/2010 11:21 AM, Sagar Dixit wrote:
On 03/22/2010 03:10 PM, Daniel P. Berrange wrote:
This isn't necessarily libvirt's problem if it's mission is to provide a
common hypervisor API that covers the most commonly used features.
That is more or less our current mission. If this mission leads to QEMU
creating a non-libvirt
On 03/22/2010 04:33 PM, Gerd Hoffmann wrote:
Hi,
Stepping back a bit first, there are the two core areas in which
people can
be limited by libvirt currently.
2. Command line flags
For me: This one, and monitor access.
libvirt is very unfriendly to qemu hackers. There is no easy
On 03/22/2010 05:33 PM, Gerd Hoffmann wrote:
Hi,
Stepping back a bit first, there are the two core areas in which
people can
be limited by libvirt currently.
2. Command line flags
For me: This one, and monitor access.
libvirt is very unfriendly to qemu hackers. There is no
2010/3/22 Daniel P. Berrange berra...@redhat.com:
On Mon, Mar 22, 2010 at 01:55:05AM +0100, Matthias Bolte wrote:
Replace 'method' with 'function' and get the filename's suffix right.
---
src/esx/esx_device_monitor.c | 2 +-
src/esx/esx_driver.c | 4 ++--
2010/3/22 Daniel P. Berrange berra...@redhat.com:
On Mon, Mar 22, 2010 at 01:53:50AM +0100, Matthias Bolte wrote:
This is actually a consequence of the reworked required parameter
checking: Unify the required parameter check into a Validate function
instead of doing it separately im the
2010/3/22 Daniel P. Berrange berra...@redhat.com:
On Mon, Mar 22, 2010 at 01:55:45AM +0100, Matthias Bolte wrote:
If esxVI_String_DeepCopyValue or esxVI_SelectionSpec_AppendToList fail
then selectionSpec would leak. Add a free call in the failure path to
fix the leak.
---
src/esx/esx_vi.c |
2010/3/22 Daniel P. Berrange berra...@redhat.com:
On Mon, Mar 22, 2010 at 01:56:46AM +0100, Matthias Bolte wrote:
Used in esxDomainLookupByName and to be used in esxDomainDefineXML later.
---
src/esx/esx_driver.c | 66 +
src/esx/esx_vi.c |
2010/3/22 Daniel P. Berrange berra...@redhat.com:
On Mon, Mar 22, 2010 at 02:25:34AM +0100, Matthias Bolte wrote:
This symbol is conditional, it would need to be exported conditional to
work properly with MinGW. So just remove it, as no other driver register
function is listed in the symbols
2010/3/22 Daniel P. Berrange berra...@redhat.com:
On Mon, Mar 22, 2010 at 02:25:32AM +0100, Matthias Bolte wrote:
---
configure.ac | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/configure.ac b/configure.ac
index 654b9a8..1a3c788 100644
--- a/configure.ac
+++
2010/3/22 Daniel P. Berrange berra...@redhat.com:
On Mon, Mar 22, 2010 at 02:25:33AM +0100, Matthias Bolte wrote:
This is necessary for MinGW builds.
---
src/Makefile.am | 7 ++-
src/libvirt_daemon.syms | 10 ++
src/libvirt_private.syms | 5 -
3 files
2010/3/22 Daniel P. Berrange berra...@redhat.com:
On Mon, Mar 22, 2010 at 02:25:38AM +0100, Matthias Bolte wrote:
Now the virsh tests compile at least.
---
tests/testutils.c | 6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/tests/testutils.c b/tests/testutils.c
2010/3/22 Daniel P. Berrange berra...@redhat.com:
On Mon, Mar 22, 2010 at 02:25:45AM +0100, Matthias Bolte wrote:
virSetCloseExec and virExecDaemonize were missing a body on Windows.
---
src/util/util.c | 34 ++
1 files changed, 30 insertions(+), 4
2010/3/22 Daniel P. Berrange berra...@redhat.com:
On Mon, Mar 22, 2010 at 02:25:35AM +0100, Matthias Bolte wrote:
Use the __declspec(dllexport/dllimport) stuff to export the symbol,
otherwise accessing virConnectAuthPtrDefault triggers a segfault.
---
configure.ac | 11
2010/3/22 Daniel P. Berrange berra...@redhat.com:
On Mon, Mar 22, 2010 at 02:25:39AM +0100, Matthias Bolte wrote:
Add dummy bodies for HAVE_GETPWUID_R and HAVE_MNTENT_H dependent
functions for MinGW builds.
---
src/util/util.c | 54
--
2010/3/22 Daniel P. Berrange berra...@redhat.com:
On Mon, Mar 22, 2010 at 02:25:44AM +0100, Matthias Bolte wrote:
Correctly disable pthread related code if pthread is not avialable,
in order to get it compile with MinGW on Windows.
---
src/remote/remote_driver.c | 6 ++
2010/3/22 Daniel P. Berrange berra...@redhat.com:
On Mon, Mar 22, 2010 at 02:25:40AM +0100, Matthias Bolte wrote:
rsync is used to download .po files, but SKIP_PO=true is set and
downloading .po files is skipped.
This also fixes a problem with MinGW builds, because rsync is not
available for
2010/3/22 Daniel P. Berrange berra...@redhat.com:
On Mon, Mar 22, 2010 at 02:25:41AM +0100, Matthias Bolte wrote:
Even if gnulib can provide stubs, it won't help that much. So just
replace affected util functions (virFileOperation and virDirCreate)
with stubs on Windows. Both functions aren't
2010/3/22 Daniel P. Berrange berra...@redhat.com:
On Mon, Mar 22, 2010 at 02:25:42AM +0100, Matthias Bolte wrote:
MSYS' ln doesn't work well in the way bootstrap uses it with relative paths.
---
bootstrap.conf | 6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git
The API reference website [1] for virterror contains the API reference
for virterror as expected. But the complete libvirt API reference,
that is already found at [2], is appended too.
I looked into the XSLT process that generates those two HTML files
from the libvirt-api.xml to understand why
97 matches
Mail list logo
