Re: [libvirt] small bug in spec file (0.8.0)

2010-04-13 Thread Daniel Veillard
On Mon, Apr 12, 2010 at 11:23:54PM +0200, Daniel Berteaud wrote: Hi. I've downloaded libvirt 0.8.0, and tried to re-build a rpm (on CentOS 5.4 x86_64), and found that there's a small bug in the spec file. Line 608: rm -rf $RPM_BUILD_ROOT%{_sysconfdir}/logrotate.d/libvirtd.qemu Should

Re: [libvirt] [PATCH] build: include usleep gnulib module

2010-04-13 Thread Daniel Veillard
On Mon, Apr 12, 2010 at 03:58:58PM -0600, Eric Blake wrote: Without this module, attempts to sleep for 1 or more seconds on mingw instead become a no-delay no-op. * bootstrap.conf (gnulib_modules): Add usleep. --- bootstrap.conf |1 + 1 files changed, 1 insertions(+), 0 deletions(-)

Re: [libvirt] [PATCH] build: fix syntax-check problems

2010-04-13 Thread Daniel Veillard
On Mon, Apr 12, 2010 at 04:46:37PM -0600, Eric Blake wrote: * .x-sc_prohibit_gettext_noop: Add new exemption. * .x-sc_prohibit_test_minus_ao: Likewise. * Makefile.am (EXTRA_DIST): Distribute new files. * .gitignore: Ignore built file. --- Pushing as obvious, since otherwise 'make

Re: [libvirt] small bug in spec file (0.8.0)

2010-04-13 Thread Daniel P. Berrange
On Mon, Apr 12, 2010 at 11:23:54PM +0200, Daniel Berteaud wrote: Hi. I've downloaded libvirt 0.8.0, and tried to re-build a rpm (on CentOS 5.4 x86_64), and found that there's a small bug in the spec file. Line 608: rm -rf $RPM_BUILD_ROOT%{_sysconfdir}/logrotate.d/libvirtd.qemu Should

Re: [libvirt] Domain not stable while created...

2010-04-13 Thread Sankamesh
Thanks Mr.Stefan I was getting some errors when i ran like xm create libvirt-ttylinux.conf Mounting root filesystem. mount: could not find filesystem

[libvirt] [PATCH v2] Consolidate interface related functions in interface.c

2010-04-13 Thread Stefan Berger
Changes from v1 to v2: - changed function name prefixes to 'iface' from previous 'Iface' I am consolidating network interface related functions used in nwfilter and macvtap code in utils/interface.c. All function names are prefixed with 'Iface'. The following functions are now available through

[libvirt] [PATCH] Fix nodeinfotest on NUMA machines

2010-04-13 Thread Daniel P. Berrange
The nodeinfotest was reliant on the host NUMA topology, but all the test data files assumed 1 single NUMA node. This test thus failed on any NUMA machine with 1 node * tests/nodeinfotest.c: Hardcode 1 single numa node --- tests/nodeinfotest.c |5 + 1 files changed, 5 insertions(+), 0

Re: [libvirt] [PATCH] Fix nodeinfotest on NUMA machines

2010-04-13 Thread Daniel Veillard
On Tue, Apr 13, 2010 at 11:40:23AM +0100, Daniel P. Berrange wrote: The nodeinfotest was reliant on the host NUMA topology, but all the test data files assumed 1 single NUMA node. This test thus failed on any NUMA machine with 1 node * tests/nodeinfotest.c: Hardcode 1 single numa node ---

Re: [libvirt] [PATCH] build: include usleep gnulib module

2010-04-13 Thread Eric Blake
On 04/13/2010 02:43 AM, Daniel Veillard wrote: On Mon, Apr 12, 2010 at 03:58:58PM -0600, Eric Blake wrote: Without this module, attempts to sleep for 1 or more seconds on mingw instead become a no-delay no-op. ACK, Thanks; applied. -- Eric Blake ebl...@redhat.com+1-801-349-2682

Re: [libvirt] [PATCH v2] Consolidate interface related functions in interface.c

2010-04-13 Thread Eric Blake
On 04/13/2010 04:34 AM, Stefan Berger wrote: Changes from v1 to v2: - changed function name prefixes to 'iface' from previous 'Iface' I am consolidating network interface related functions used in nwfilter and macvtap code in utils/interface.c. All function names are prefixed with

Re: [libvirt] [PATCH v2] Consolidate interface related functions in interface.c

2010-04-13 Thread Stefan Berger
Eric Blake ebl...@redhat.com wrote on 04/13/2010 10:15:01 AM: On 04/13/2010 04:34 AM, Stefan Berger wrote: Changes from v1 to v2: - changed function name prefixes to 'iface' from previous 'Iface' I am consolidating network interface related functions used in nwfilter and

Re: [libvirt] [PATCH] 0/10AppArmor driver updates

2010-04-13 Thread Jamie Strandboge
Top posting since this is only a reminder... I was wondering if this could be re-reviewed now that 0.8 is out. Thanks! Jamie On Tue, 2010-04-06 at 16:56 -0500, Jamie Strandboge wrote: On Tue, 2010-04-06 at 23:05 +0200, Daniel Veillard wrote: On Mon, Apr 05, 2010 at 04:15:06PM -0500, Jamie

Re: [libvirt] small bug in spec file (0.8.0)

2010-04-13 Thread Daniel Berteaud
Le mardi 13 avril 2010 à 10:00 +0100, Daniel P. Berrange a écrit : On Mon, Apr 12, 2010 at 11:23:54PM +0200, Daniel Berteaud wrote: It isn't as hard as it might seem:-) For general reference, if anyone else is wondering about a easy way to make some quick fixes for libvirt in GIT, this is

[libvirt] [PATCH v2 1/2] Introduce virCheckFlags for consistent flags checking

2010-04-13 Thread Jiri Denemark
The idea is that every API implementation in driver which has flags parameter should first call virCheckFlags() macro to check the function was called with supported flags: virCheckFlags(VIR_SUPPORTED_FLAG_1 | VIR_SUPPORTED_FLAG_2 |

[libvirt] [PATCH v2 0/2] Enhance checking of supported flags in drivers

2010-04-13 Thread Jiri Denemark
I think we need a simple and consistent way of checking whether flags passed to API entry points in drivers are valid/supported or not. So far some entry points don't check flags at all and some checks for 0 when no flags are expected/supported. The first patch introduces a macro which can be

[libvirt] [PATCH v2 2/2] Use virCheckFlags for APIs added in 0.8.0

2010-04-13 Thread Jiri Denemark
--- src/esx/esx_driver.c | 43 - src/nwfilter/nwfilter_driver.c |4 ++- src/qemu/qemu_driver.c | 68 +++- src/storage/storage_driver.c |6 +--- src/vbox/vbox_tmpl.c | 41 ---

[libvirt] [PATCH] nwfilter: use virFindFileInPath for needed CLI tools

2010-04-13 Thread Stefan Berger
I am getting rid of determining the path to necessary CLI tools at compile time. Instead, now the firewall driver has an initialization function that uses virFindFileInPath() to determine the path to necessary CLI tools and a shutdown function to free allocated memory. The rest of the patch mostly

[libvirt] [PATCH] Implement forgotten backend of virInterfaceIsActive()

2010-04-13 Thread Laine Stump
Somehow the backend of this function was never implemented in libvirt's netcf driver, and nobody noticed until now. (The required netcf function was already in place, so nothing needs to change there.) --- src/interface/netcf_driver.c | 31 ++- 1 files changed, 30

[libvirt] hellolibvirt: no hypervisor driver available for xen:///

2010-04-13 Thread Ganesh Pagade
Hi, I downloaded and built the latest libvirt source code 0.8. I installed the library in a custom directory libvirt-0.8.0-install/ keeping all other configurations default. After this I tried to execute the example hellolibvirt: [hellolibvirt]# ./hellolibvirt xen Attempting to connect to

[libvirt] [RFC PATCH 0/5] Qemu Monitor Passthrough

2010-04-13 Thread Chris Lalancette
Hello, As we discussed on the list, here are RFC patches that allow both qemu monitor passthrough and the ability to specify extra arguments to be passed on the qemu command-line. I've specifically not done the more complicated regex command-line editing for now, since we don't have

[libvirt] [RFC PATCH 1/5] Qemu Monitor API entry point.

2010-04-13 Thread Chris Lalancette
Signed-off-by: Chris Lalancette clala...@redhat.com --- include/libvirt/Makefile.am|1 + include/libvirt/libvirt_qemu.h | 30 src/Makefile.am| 11 - src/driver.h |5 ++ src/esx/esx_driver.c |1 + src/internal.h

[libvirt] [RFC PATCH 3/5] Qemu remote protocol.

2010-04-13 Thread Chris Lalancette
Signed-off-by: Chris Lalancette clala...@redhat.com --- daemon/Makefile.am| 25 +- daemon/dispatch.c | 171 +++-- daemon/libvirtd.h |1 + daemon/qemu_dispatch_args.h |5 +

[libvirt] [RFC PATCH 4/5] Qemu implementation of qemuMonitorCommand.

2010-04-13 Thread Chris Lalancette
Signed-off-by: Chris Lalancette clala...@redhat.com --- src/qemu/qemu_conf.c | 28 ++ src/qemu/qemu_conf.h |6 ++ src/qemu/qemu_driver.c | 190 -- src/qemu/qemu_monitor.c | 14 +++ src/qemu/qemu_monitor.h |2

[libvirt] [RFC PATCH 5/5] Implement virsh monitor-command

2010-04-13 Thread Chris Lalancette
Signed-off-by: Chris Lalancette clala...@redhat.com --- tools/Makefile.am |1 + tools/virsh.c | 66 + 2 files changed, 67 insertions(+), 0 deletions(-) diff --git a/tools/Makefile.am b/tools/Makefile.am index 33a3216..b1c2691 100644

[libvirt] FYI: pushed trivial patches

2010-04-13 Thread Chris Lalancette
I just pushed these 4 trivial patches: From 9295dfda8632aeb19f2c7553b35817f01381491a Mon Sep 17 00:00:00 2001 From: Chris Lalancette clala...@redhat.com Date: Wed, 7 Apr 2010 11:23:11 -0400 Subject: [PATCH] Fix up formatting of remote protocol stuff. Signed-off-by: Chris Lalancette

[libvirt] [PATCH] Fix build of openvz on RHEL-5.

2010-04-13 Thread Chris Lalancette
When building libvirt on RHEL-5, I saw this error: cc1: warnings being treated as errors openvz/openvz_conf.c: In function 'openvzGetVPSUUID': openvz/openvz_conf.c:835: warning: 'saveptr' may be used uninitialized in this function make[3]: *** [libvirt_driver_openvz_la-openvz_conf.lo] Error 1

Re: [libvirt] [PATCH] Fix build of openvz on RHEL-5.

2010-04-13 Thread Eric Blake
On 04/13/2010 01:45 PM, Chris Lalancette wrote: When building libvirt on RHEL-5, I saw this error: cc1: warnings being treated as errors openvz/openvz_conf.c: In function 'openvzGetVPSUUID': openvz/openvz_conf.c:835: warning: 'saveptr' may be used uninitialized in this function make[3]:

[libvirt] [RFC] maint: forbid most files without extension

2010-04-13 Thread Eric Blake
* .gitignore: Add rule that requires . in name, then add exemptions. --- Given Chris' recent accident in committing a binary file, then blasting the list with it, here's a (hack) approach to prevent a relapse in the future. It assumes that non-binary files either have an extension, or are easy

Re: [libvirt] [PATCH] Fix build of openvz on RHEL-5.

2010-04-13 Thread Chris Lalancette
On 04/13/2010 03:57 PM, Eric Blake wrote: On 04/13/2010 01:45 PM, Chris Lalancette wrote: When building libvirt on RHEL-5, I saw this error: cc1: warnings being treated as errors openvz/openvz_conf.c: In function 'openvzGetVPSUUID': openvz/openvz_conf.c:835: warning: 'saveptr' may be used