[libvirt] VolumeCreateXML XML description for ESX

2010-12-02 Thread Sherif Nagy
Hello, I am using libvirt 0.8.6 python bindings can someone point me to where i find the XML description of creating volumes using storagecolumecreateXML function ? i am getting libvir: ESX error : internal error Volume name 'name.vmdk' doesn't have expected format 'directory/file' thank

Re: [libvirt] make syntax-check - make: *** [sc_check_author_list] Error 1 on libvirt-0.8.5

2010-12-02 Thread Kenneth Nagin
Best Regards, Kenneth Nagin Ph: +972-4-8296227 Cell: 054-6976227 Fx: +972-4- 8296113 https://researcher.ibm.com/researcher/view.php?person=il-NAGIN http://www.reservoir-fp7.eu/ A lie can travel halfway round the world while the truth is putting on its shoes. -- Mark Twain Eric Blake

Re: [libvirt] [PATCH] schemas: Fix cpu element schema

2010-12-02 Thread Jiri Denemark
diff --git a/docs/schemas/domain.rng b/docs/schemas/domain.rng index fb44335..08ebefb 100644 --- a/docs/schemas/domain.rng +++ b/docs/schemas/domain.rng @@ -1745,6 +1745,8 @@ ref name=cpuModel/ optional ref name=cpuVendor/ +

Re: [libvirt] [PATCH 0/2] Add tests for CPU selection in qemu driver

2010-12-02 Thread Jiri Denemark
Jiri Denemark (2): tests: Support for faking emulator in qemuxml2argv tests: Add tests for CPU selection in qemu driver I made the change requested by Eric and pushed both patches. Thanks for the review. Jirka -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] VolumeCreateXML XML description for ESX

2010-12-02 Thread Justin Clift
On 02/12/2010, at 8:18 PM, Sherif Nagy wrote: Hello, I am using libvirt 0.8.6 python bindings can someone point me to where i find the XML description of creating volumes using storagecolumecreateXML function ? i am getting libvir: ESX error : internal error Volume name 'name.vmdk'

Re: [libvirt] [PATCH v3 4/5] Add a watchdog action `dump'

2010-12-02 Thread Daniel P. Berrange
On Wed, Dec 01, 2010 at 06:39:14PM -0700, Eric Blake wrote: On 12/01/2010 05:50 PM, Hu Tao wrote: On Tue, Nov 30, 2010 at 03:21:36PM -0700, Eric Blake wrote: ...snip... -libvirt_qemu_la_SOURCES = libvirt-qemu.c +libvirt_qemu_la_SOURCES = libvirt-qemu.c util/threadpool.c Why is

Re: [libvirt] Release of libvirt 0.8.6

2010-12-02 Thread Daniel P. Berrange
On Thu, Dec 02, 2010 at 02:47:22AM +1100, Justin Clift wrote: On 02/12/2010, at 2:26 AM, Diego Elio Pettenò wrote: Il giorno mar, 30/11/2010 alle 21.09 +0100, Daniel Veillard ha scritto: As indicated 10 days ago, today was time for a release, I didn't had much time so I simply generated

Re: [libvirt] Release of libvirt 0.8.6

2010-12-02 Thread Daniel P. Berrange
On Thu, Dec 02, 2010 at 05:47:01AM +1100, Justin Clift wrote: On 02/12/2010, at 5:26 AM, Diego Elio Pettenò wrote: Il giorno gio, 02/12/2010 alle 02.47 +1100, Justin Clift ha scritto: Looks like it might be time to put some kind of regression testing in place, as a go/no-go release

Re: [libvirt] Release of libvirt 0.8.6

2010-12-02 Thread Justin Clift
On 02/12/2010, at 9:58 PM, Daniel P. Berrange wrote: snip I think this is really viable, because it implies we need another Err... not really viable yeah? week prior to creating the pre-release where we do what we currently do with pre-release stabalization. With a monthly release cycle,

Re: [libvirt] VolumeCreateXML XML description for ESX

2010-12-02 Thread Sherif Nagy
yes i am using same template like KVM but it is not working, seems ESX driver has a different XML structure since it is using datatstore /dir/filename.vdk structure. so any idea what is the XML structure for creating the XML for volumes using the ESX driver? On Thu, Dec 2, 2010 at 12:48 PM,

Re: [libvirt] VolumeCreateXML XML description for ESX

2010-12-02 Thread Justin Clift
Matthias, sounds like there's a bug or we need to update the docs? On 02/12/2010, at 11:02 PM, Sherif Nagy wrote: yes i am using same template like KVM but it is not working, seems ESX driver has a different XML structure since it is using datatstore /dir/filename.vdk structure. so any

Re: [libvirt] VolumeCreateXML XML description for ESX

2010-12-02 Thread Sherif Nagy
The XML i am trying to use is volumenametest_vm.vmdk/namekey/keyallocation0/allocationcapacity unit='G'2/capacity/volume or volumenametest_vm.vmdk/namedirectorytest_vmfiletest_vm.vmdk/file/directorykey/keyallocation0/allocationcapacity unit='G'2/capacity/volume and if i added directory and file

Re: [libvirt] [PATCH 1/8] Thread pool impl

2010-12-02 Thread Daniel P. Berrange
On Thu, Dec 02, 2010 at 09:43:12AM +0800, Hu Tao wrote: On Wed, Dec 01, 2010 at 05:26:27PM +, Daniel P. Berrange wrote: From: Hu Tao hu...@cn.fujitsu.com * src/util/threadpool.c, src/util/threadpool.h: Thread pool implementation * src/Makefile.am: Build thread pool ---

Re: [libvirt] [PATCH v4 RESEND 1/4] threadpool impl

2010-12-02 Thread Daniel P. Berrange
On Thu, Dec 02, 2010 at 03:26:57PM +0800, Hu Tao wrote: +virThreadPoolPtr virThreadPoolNew(size_t minWorkers, + size_t maxWorkers, + virThreadPoolJobFunc func, + void *opaque) +{ +

Re: [libvirt] VolumeCreateXML XML description for ESX

2010-12-02 Thread Matthias Bolte
This XML snippet should work volume nametest_vm/test_vm.vmdk/name allocation0/allocation capacity unit='G'2/capacity /volume The error message says that the volume name doesn't have the expected format directory/file. The might be misleading here, they don't refer to XML elements. I can

Re: [libvirt] [PATCH v4 RESEND 3/4] Add a watchdog action `dump'

2010-12-02 Thread Daniel P. Berrange
On Thu, Dec 02, 2010 at 03:30:10PM +0800, Hu Tao wrote: diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf index f4f965e..ba41f80 100644 --- a/src/qemu/qemu.conf +++ b/src/qemu/qemu.conf @@ -191,6 +191,11 @@ # save_image_format = raw # dump_image_format = raw +# When a domain is

Re: [libvirt] [PATCH v4 RESEND 2/4] Add a new function doCoreDump

2010-12-02 Thread Daniel P. Berrange
On Thu, Dec 02, 2010 at 03:30:03PM +0800, Hu Tao wrote: This patch prepares for the next patch. --- src/qemu/qemu_driver.c | 132 +++- 1 files changed, 74 insertions(+), 58 deletions(-) ACK, looks fine to me. Daniel -- libvir-list mailing list

Re: [libvirt] [PATCH v4 RESEND 4/4] Using threadpool API to manage qemud worker

2010-12-02 Thread Daniel P. Berrange
On Thu, Dec 02, 2010 at 03:30:23PM +0800, Hu Tao wrote: --- daemon/libvirtd.c | 172 + daemon/libvirtd.h |4 + 2 files changed, 33 insertions(+), 143 deletions(-) diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c index

Re: [libvirt] GNU awk vs BSD awk?

2010-12-02 Thread Daniel P. Berrange
On Thu, Dec 02, 2010 at 03:08:28PM +1100, Justin Clift wrote: Hi Eric, One of the OSX Homebrew guys, CC'd, has asked (casually) whether our dependency on GNU awk is very deeply ingrained, or if we could be convinced to allow usage of other make's instead (ie BSD). Figured I'd ask you

Re: [libvirt] [PATCH 0/2] smbios fixes

2010-12-02 Thread Daniel P. Berrange
On Wed, Dec 01, 2010 at 05:12:08PM -0700, Eric Blake wrote: In testing smbios mode='host'/, I noticed a couple of problems. First, qemu rejected the command line we gave it (invalid UUID); ifixingthat showed that all other arguments were being given literal which then made the guest smbios

Re: [libvirt] [PATCH 2/8] Fix memory leak in logging setup

2010-12-02 Thread Daniel P. Berrange
On Wed, Dec 01, 2010 at 12:21:51PM -0700, Eric Blake wrote: On 12/01/2010 10:26 AM, Daniel P. Berrange wrote: The logging setup requires const char * strings, but the virLogSetFromEnv() strdup's the env variables, thus causing a memory leak * src/util/logging.c: Avoid strdup'ing env

Re: [libvirt] [PATCH 3/8] Tweak daemon event debug to include errno

2010-12-02 Thread Daniel P. Berrange
On Wed, Dec 01, 2010 at 12:22:53PM -0700, Eric Blake wrote: On 12/01/2010 10:26 AM, Daniel P. Berrange wrote: * daemon/event.c: Include errno in debug info upon poll() failure --- daemon/event.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/daemon/event.c

Re: [libvirt] [PATCH 4/8] Introduce generic objects for building XDR RPC servers/clients

2010-12-02 Thread Daniel P. Berrange
On Wed, Dec 01, 2010 at 12:30:25PM -0700, Eric Blake wrote: On 12/01/2010 10:26 AM, Daniel P. Berrange wrote: Introduces a set of generic objects which are to be used in building RPC servers/clients based on XDR. - virNetMessageHeader - standardize the XDR format for any RPC

[libvirt] [PATCH] man pages: update the description for the virsh help command

2010-12-02 Thread Justin Clift
Now includes information on keyword usage, and provides examples. --- tools/virsh.pod | 37 ++--- 1 files changed, 34 insertions(+), 3 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index c97786a..66654a7 100644 --- a/tools/virsh.pod +++

Re: [libvirt] VolumeCreateXML XML description for ESX

2010-12-02 Thread Sherif Nagy
Great ! it did pass the error of directory/file thank you for the support now i have another problem of creating the VMDK image with this XML volumenametest_vm/test_vm.vmdk/nameallocation0/allocationcapacity unit='G'2/capacitytargetformat type='vmdk'//target/volume and error libvir: ESX error :

Re: [libvirt] Looking for Hypervisor Vulerability Example

2010-12-02 Thread Daniel P. Berrange
On Tue, Nov 30, 2010 at 01:08:12PM -0800, Shi Jin wrote: Hi there, I am researching on virtualization security and particularly on sVirt. From this sVirt presentation[1] and this RHEL-6 documentation on sVirt [2], I read: If there is a security flaw in the hypervisor that can be

Re: [libvirt] [PATCH] add network disk support

2010-12-02 Thread Daniel P. Berrange
On Fri, Nov 26, 2010 at 05:49:56AM +0900, MORITA Kazutaka wrote: This patch adds network disk support to libvirt/QEMU. The currently supported protcols are nbd, rbd, and sheepdog. The XML syntax is like this: disk type=network device=disk driver name=qemu type=raw /

[libvirt] [PATCH] Create file in virFileWriteStr() if it doesn't exist

2010-12-02 Thread Jean-Baptiste Rouault
This patch adds a virFileWriteStrEx() function with a third parameter to set the created file permissions. virFileWriteStr() calls this new function with a default value for the mode parameter. --- src/util/util.c | 11 --- src/util/util.h |1 + 2 files changed, 9 insertions(+), 3

[libvirt] [RFC] cgroups net_cls controller implementation

2010-12-02 Thread D. Herrendoerfer
This a basic implemantation to support the net_cls feature of cgroups. It adds the setting of a net_cls.classid value to the existing cgroups setup in the qemu driver. The classid is specified in the qemu.conf file. This enables the use of the tc utility to manage traffic from/to vitual

[libvirt] [Patch v2] Add VMware Workstation and Player driver

2010-12-02 Thread Jean-Baptiste Rouault
Many changes since v2 based on Matthias review (http://www.redhat.com/archives/libvir-list/2010-November/msg00799.html). popen() calls will be removed when the new virCommand API is available. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv2 1/8] util: add virVasprintf

2010-12-02 Thread Daniel P. Berrange
On Tue, Nov 23, 2010 at 04:49:54PM -0700, Eric Blake wrote: * src/util/util.h (virVasprintf): New declaration. * src/util/util.c (virVasprintf): New function. (virAsprintf): Use it. * src/util/virtaudit.c (virAuditSend): Likewise. * src/libvirt_private.syms: Export it. * cfg.mk

Re: [libvirt] [PATCHv2 2/8] util: fix saferead type

2010-12-02 Thread Daniel P. Berrange
On Tue, Nov 23, 2010 at 04:49:55PM -0700, Eric Blake wrote: * src/util/util.c (saferead): Fix return type. (safewrite): Fix indentation. --- v2: new patch. Not really essential to the series, so much as a trivial cleanup I noticed while in the area. src/util/util.c | 64

Re: [libvirt] [PATCHv2 3/8] Introduce new APIs for spawning processes

2010-12-02 Thread Daniel P. Berrange
On Tue, Nov 23, 2010 at 04:49:56PM -0700, Eric Blake wrote: From: Daniel P. Berrange berra...@redhat.com This introduces a new set of APIs in src/util/command.h to use for invoking commands. This is intended to replace all current usage of virRun and virExec variants, with a more flexible

Re: [libvirt] [PATCHv2 4/8] virCommand: docs for usage of new command APIs

2010-12-02 Thread Daniel P. Berrange
On Tue, Nov 23, 2010 at 04:49:57PM -0700, Eric Blake wrote: From: Daniel P. Berrange berra...@redhat.com * docs/internals/command.html.in: New file. * docs/Makefile.am: Build new docs. * docs/subsite.xsl: New glue file. * docs/internals.html.in, docs/sitemap.html.in: Update glue. ---

Re: [libvirt] [PATCHv2 7/8] uml: convert to virCommand

2010-12-02 Thread Daniel P. Berrange
On Tue, Nov 23, 2010 at 04:50:00PM -0700, Eric Blake wrote: From: Daniel P. Berrange berra...@redhat.com * src/uml/uml_conf.c (umlBuildCommandLineChr) (umlBuildCommandLine): Rewrite with virCommand. * src/uml/uml_conf.h (umlBuildCommandLine): Update signature. * src/uml/uml_driver.c

Re: [libvirt] [PATCHv2 5/8] Port hooks and iptables code to new command execution APIs

2010-12-02 Thread Daniel P. Berrange
On Tue, Nov 23, 2010 at 04:49:58PM -0700, Eric Blake wrote: From: Daniel P. Berrange berra...@redhat.com This proof of concept shows how two existing uses of virExec and virRun can be ported to the new virCommand APIs, and how much simpler the code becomes ACK Daniel -- libvir-list

Re: [libvirt] Release of libvirt 0.8.6

2010-12-02 Thread Diego Elio Pettenò
Il giorno gio, 02/12/2010 alle 10.58 +, Daniel P. Berrange ha scritto: I think this is really viable, because it implies we need another week prior to creating the pre-release where we do what we currently do with pre-release stabalization. Note that I said “one week or less”. - A

Re: [libvirt] [PATCHv2 6/8] qemu: convert to virCommand

2010-12-02 Thread Daniel P. Berrange
On Tue, Nov 23, 2010 at 04:49:59PM -0700, Eric Blake wrote: * src/qemu/qemu_conf.c (qemudExtractVersionInfo): Check for file before executing it here, rather than in callers. (qemudBuildCommandLine): Rewrite with virCommand. * src/qemu/qemu_conf.h (qemudBuildCommandLine): Update signature. *

Re: [libvirt] [PATCHv2 8/8] Remove bogus includes

2010-12-02 Thread Daniel P. Berrange
On Tue, Nov 23, 2010 at 04:50:01PM -0700, Eric Blake wrote: From: Daniel P. Berrange berra...@redhat.com --- v2: rearrange to later in the series; no other change. Passes for me with macvtap compilation enabled, so I'm not sure if it still suffers from the same problem as the v1

Re: [libvirt] [PATCHv2 3/8] Introduce new APIs for spawning processes

2010-12-02 Thread Daniel P. Berrange
On Wed, Dec 01, 2010 at 04:39:25PM -0700, Eric Blake wrote: On 11/23/2010 04:49 PM, Eric Blake wrote: From: Daniel P. Berrange berra...@redhat.com This introduces a new set of APIs in src/util/command.h to use for invoking commands. This is intended to replace all current usage of

Re: [libvirt] [PATCHv2 3/8] Introduce new APIs for spawning processes

2010-12-02 Thread Daniel P. Berrange
On Wed, Dec 01, 2010 at 10:42:40PM +0100, Matthias Bolte wrote: 2010/11/24 Eric Blake ebl...@redhat.com: +/* + * Manage input and output to the child process. + */ +static int +virCommandProcessIO(virCommandPtr cmd) +{ +    int infd = -1, outfd = -1, errfd = -1; +    size_t inlen

Re: [libvirt] [PATCHv2 3/8] Introduce new APIs for spawning processes

2010-12-02 Thread Matthias Bolte
2010/12/2 Daniel P. Berrange berra...@redhat.com: On Wed, Dec 01, 2010 at 10:42:40PM +0100, Matthias Bolte wrote: 2010/11/24 Eric Blake ebl...@redhat.com: +/* + * Manage input and output to the child process. + */ +static int +virCommandProcessIO(virCommandPtr cmd) +{ +    int infd

Re: [libvirt] Release of libvirt 0.8.6

2010-12-02 Thread Justin Clift
On 03/12/2010, at 1:03 AM, Diego Elio Pettenò wrote: - A official list of supported platforms / OS combinations - Run a test build on each combination before release - Actually follow the 'bug fixes' only rule leading upto release no matter how simple the new feature might appear. And let

Re: [libvirt] GNU awk vs BSD awk?

2010-12-02 Thread Eric Blake
On 12/01/2010 09:08 PM, Justin Clift wrote: Hi Eric, One of the OSX Homebrew guys, CC'd, has asked (casually) whether our dependency on GNU awk is very deeply ingrained, or if we could be convinced to allow usage of other make's instead (ie BSD). GNU awk, or GNU make? There's a

Re: [libvirt] [PATCH 0/2] smbios fixes

2010-12-02 Thread Eric Blake
On 12/02/2010 05:47 AM, Daniel P. Berrange wrote: On Wed, Dec 01, 2010 at 05:12:08PM -0700, Eric Blake wrote: In testing smbios mode='host'/, I noticed a couple of problems. First, qemu rejected the command line we gave it (invalid UUID); ifixingthat showed that all other arguments were being

Re: [libvirt] [PATCH] man pages: update the description for the virsh help command

2010-12-02 Thread Eric Blake
On 12/02/2010 06:04 AM, Justin Clift wrote: Now includes information on keyword usage, and provides examples. --- tools/virsh.pod | 37 ++--- 1 files changed, 34 insertions(+), 3 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index

Re: [libvirt] GNU awk vs BSD awk?

2010-12-02 Thread Justin Clift
On 03/12/2010, at 4:29 AM, Eric Blake wrote: On 12/01/2010 09:08 PM, Justin Clift wrote: Hi Eric, One of the OSX Homebrew guys, CC'd, has asked (casually) whether our dependency on GNU awk is very deeply ingrained, or if we could be convinced to allow usage of other make's instead (ie

Re: [libvirt] GNU awk vs BSD awk?

2010-12-02 Thread Justin Clift
On 03/12/2010, at 5:18 AM, Justin Clift wrote: Looks like good timing of that question on Mike's part, and I'll submit a new 0.8.6 package that doesn't have the gawk dependency. Done. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv2 2/8] util: fix saferead type

2010-12-02 Thread Eric Blake
On 12/02/2010 06:58 AM, Daniel P. Berrange wrote: On Tue, Nov 23, 2010 at 04:49:55PM -0700, Eric Blake wrote: * src/util/util.c (saferead): Fix return type. (safewrite): Fix indentation. --- v2: new patch. Not really essential to the series, so much as a trivial cleanup I noticed while in

Re: [libvirt] [PATCH 0/2] smbios fixes

2010-12-02 Thread Gleb Natapov
On Thu, Dec 02, 2010 at 10:36:59AM -0700, Eric Blake wrote: On 12/02/2010 05:47 AM, Daniel P. Berrange wrote: On Wed, Dec 01, 2010 at 05:12:08PM -0700, Eric Blake wrote: In testing smbios mode='host'/, I noticed a couple of problems. First, qemu rejected the command line we gave it (invalid

Re: [libvirt] [PATCH 0/2] smbios fixes

2010-12-02 Thread Daniel P. Berrange
On Thu, Dec 02, 2010 at 09:44:47PM +0200, Gleb Natapov wrote: On Thu, Dec 02, 2010 at 10:36:59AM -0700, Eric Blake wrote: On 12/02/2010 05:47 AM, Daniel P. Berrange wrote: On Wed, Dec 01, 2010 at 05:12:08PM -0700, Eric Blake wrote: In testing smbios mode='host'/, I noticed a couple of

Re: [libvirt] [PATCH 0/2] smbios fixes

2010-12-02 Thread Gleb Natapov
On Thu, Dec 02, 2010 at 07:56:03PM +, Daniel P. Berrange wrote: On Thu, Dec 02, 2010 at 09:44:47PM +0200, Gleb Natapov wrote: On Thu, Dec 02, 2010 at 10:36:59AM -0700, Eric Blake wrote: On 12/02/2010 05:47 AM, Daniel P. Berrange wrote: On Wed, Dec 01, 2010 at 05:12:08PM -0700, Eric

Re: [libvirt] [PATCH 0/2] smbios fixes

2010-12-02 Thread Daniel P. Berrange
On Thu, Dec 02, 2010 at 10:04:59PM +0200, Gleb Natapov wrote: On Thu, Dec 02, 2010 at 07:56:03PM +, Daniel P. Berrange wrote: On Thu, Dec 02, 2010 at 09:44:47PM +0200, Gleb Natapov wrote: On Thu, Dec 02, 2010 at 10:36:59AM -0700, Eric Blake wrote: On 12/02/2010 05:47 AM, Daniel P.

Re: [libvirt] [RFC] new preferences requirement

2010-12-02 Thread Dan Kenigsberg
On Wed, Dec 01, 2010 at 10:26:35AM +, Daniel P. Berrange wrote: On Wed, Dec 01, 2010 at 05:35:38PM +0800, Osier Yang wrote: Hi, all We have some new requirements of preferences, I listed which of them I known, and think is useful as follows: 1) for the path of x509

Re: [libvirt] [PATCHv2 3/8] Introduce new APIs for spawning processes

2010-12-02 Thread Eric Blake
On 12/01/2010 02:42 PM, Matthias Bolte wrote: +++ b/cfg.mk @@ -77,6 +77,7 @@ useless_free_options =\ --name=virCapabilitiesFreeHostNUMACell \ --name=virCapabilitiesFreeMachines \ --name=virCgroupFree \ +

Re: [libvirt] Looking for Hypervisor Vulerability Example

2010-12-02 Thread Shi Jin
James Morris' presentation is referring to this published demonstration of exploiting Xen a few years ago   http://www.securityfocus.com/archive/1/497376   http://invisiblethingslab.com/resources/misc08/xenfb-adventures-10.pdf The key difference sVirt makes is at chapter 3.4 in the

Re: [libvirt] [PATCHv2 8/8] Remove bogus includes

2010-12-02 Thread Eric Blake
On 12/02/2010 07:08 AM, Daniel P. Berrange wrote: On Tue, Nov 23, 2010 at 04:50:01PM -0700, Eric Blake wrote: From: Daniel P. Berrange berra...@redhat.com --- v2: rearrange to later in the series; no other change. Passes for me with macvtap compilation enabled, so I'm not sure if it still

Re: [libvirt] [PATCH] virsh: move two commands from domain group to storage pool group

2010-12-02 Thread Eric Blake
On 12/01/2010 09:34 PM, Justin Clift wrote: On 02/12/2010, at 11:25 AM, Osier Yang wrote: * tools/virsh.c (find-storage-pool-sources-as and find-storage-pool-sources should't be in command group Domain Management, move them to group Storage Pool. --- tools/virsh.c |8 1 files

Re: [libvirt] make syntax-check - make: *** [sc_check_author_list] Error 1 on libvirt-0.8.5

2010-12-02 Thread Eric Blake
[adding bug-gnulib, thanks to some issues with 'make syntax-check' in gnulib-provided files] On 12/02/2010 02:25 AM, Kenneth Nagin wrote: I am receiving syntax error when compiling libvirt-0.8.5. However, make without syntax-check completes successfully. check_author_list %aE

Re: [libvirt] [PATCH v4 RESEND 1/4] threadpool impl

2010-12-02 Thread Eric Blake
On 12/02/2010 05:28 AM, Daniel P. Berrange wrote: +virThreadPoolPtr virThreadPoolNew(size_t minWorkers, + size_t maxWorkers, + virThreadPoolJobFunc func, + void *opaque) ATTRIBUTE_NONNULL(3) +

Re: [libvirt] [PATCH] Create file in virFileWriteStr() if it doesn't exist

2010-12-02 Thread Eric Blake
On 12/02/2010 06:23 AM, Jean-Baptiste Rouault wrote: This patch adds a virFileWriteStrEx() function with a third parameter to set the created file permissions. I'm not a fan of Microsoft's naming conventions (Ex conveys no meaning, and it doesn't scale well to future extensions[1]). Can we

[libvirt] [PATCH] util: allow creation of file with virFileWriteStr

2010-12-02 Thread Eric Blake
Making this change will allow the future patches to use virFileWriteStr to create a file, rather than its current limitation of only working on pre-existing files. * src/util/util.h (virFileWriteStr): Alter signature. * src/util/util.c (virFileWriteStr): Allow file creation. *

[libvirt] [PATCH] openvz: convert popen to virCommand

2010-12-02 Thread Eric Blake
popen must be matched with pclose (not fclose), or it will leak resources. Furthermore, it is a lousy interface when it comes to signal handling. We're much better off using our decent command wrapper. * src/openvz/openvz_conf.c (openvzLoadDomains, openvzGetVEID): Replace popen with virCommand

Re: [libvirt] [PATCH v4 RESEND 1/4] threadpool impl

2010-12-02 Thread Hu Tao
On Thu, Dec 02, 2010 at 12:28:17PM +, Daniel P. Berrange wrote: On Thu, Dec 02, 2010 at 03:26:57PM +0800, Hu Tao wrote: +virThreadPoolPtr virThreadPoolNew(size_t minWorkers, + size_t maxWorkers, + virThreadPoolJobFunc

Re: [libvirt] [PATCH v4 RESEND 1/4] threadpool impl

2010-12-02 Thread Hu Tao
On Thu, Dec 02, 2010 at 12:28:17PM +, Daniel P. Berrange wrote: ...snip... + +if (virThreadCreate(pool-workers[pool-nWorkers - 1], +true, +virThreadPoolWorker, +pool) 0) { +

Re: [libvirt] Release of libvirt 0.8.6

2010-12-02 Thread Jim Fehlig
Daniel P. Berrange wrote: Concept wise, do you reckon something like this would work: + a new libvirt-announce mailing list, low trafic, purely for release announcements and similar Along with us announcing a 'release candidate build through it (instead of the present approach). If

Re: [libvirt] [PATCH v4 RESEND 4/4] Using threadpool API to manage qemud worker

2010-12-02 Thread Hu Tao
On Thu, Dec 02, 2010 at 12:42:19PM +, Daniel P. Berrange wrote: ...snip... - -/* Caller must hold server lock */ -static struct qemud_client *qemudPendingJob(struct qemud_server *server) +static void qemudWorker(void *data, void *opaque ATTRIBUTE_UNUSED) { -int i; -for

[libvirt] [PATCH v5 0/4] Support of auto-dump on watchdog event in libvirtd

2010-12-02 Thread Hu Tao
This patch series adds a new watchdog action `dump' which lets libvirtd can do auto-dump when receiving a watchdog event from qemu guest. In order to make the function work, there must be a watchdog device added to guest, and guest must have a watchdog daemon running, for example,

Re: [libvirt] Release of libvirt 0.8.6

2010-12-02 Thread Justin Clift
On 03/12/2010, at 4:04 PM, Jim Fehlig wrote: I can deploy a release candidate tarball to the libvirt package in this project quickly to test building across these various SuSE products. I suspect there is an opportunity for some automation here as well. Whichever way we go, I think automation

[libvirt] [PATCH v5 4/4] Using threadpool API to manage qemud worker

2010-12-02 Thread Hu Tao
--- daemon/libvirtd.c | 172 + daemon/libvirtd.h |2 + 2 files changed, 31 insertions(+), 143 deletions(-) diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c index 791b3dc..effa45f 100644 --- a/daemon/libvirtd.c +++ b/daemon/libvirtd.c @@

[libvirt] [PATCH v5 3/4] Add a watchdog action `dump'

2010-12-02 Thread Hu Tao
`dump' watchdog action lets libvirtd to dump the guest when receives a watchdog event (which probably means a guest crash) Currently only qemu is supported. --- src/conf/domain_conf.c |1 + src/conf/domain_conf.h |1 + src/qemu/libvirtd_qemu.aug |1 +

[libvirt] [PATCH v5 1/4] threadpool impl

2010-12-02 Thread Hu Tao
* src/util/threadpool.c, src/util/threadpool.h: Thread pool implementation * src/Makefile.am: Build thread pool * src/libvirt_private.syms: Export public functions --- cfg.mk |1 + src/Makefile.am |1 + src/libvirt_private.syms |6 + src/util/threadpool.c

[libvirt] [PATCH v5 2/4] Add a new function doCoreDump

2010-12-02 Thread Hu Tao
This patch prepares for the next patch. --- src/qemu/qemu_driver.c | 132 +++- 1 files changed, 74 insertions(+), 58 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 1a7c1ad..e534195 100644 --- a/src/qemu/qemu_driver.c

[libvirt] directory storage pools reported available space

2010-12-02 Thread Ryan Harper
We recently had an issue with not being able to allocate the full capacity of a directory based storage pool. The reported value via pool-info was larger than what was available to the image creator. Looking at the storage code, in virStorageBackendFileSystemRefresh() we're using statvfs, and

Re: [libvirt] directory storage pools reported available space

2010-12-02 Thread Osier Yang
于 2010年12月03日 14:00, Ryan Harper 写道: We recently had an issue with not being able to allocate the full capacity of a directory based storage pool. The reported value via pool-info was larger than what was available to the image creator. Looking at the storage code, in

Re: [libvirt] Release of libvirt 0.8.6

2010-12-02 Thread Zdenek Styblik
On 12/02/2010 03:03 PM, Diego Elio Pettenò wrote: Il giorno gio, 02/12/2010 alle 10.58 +, Daniel P. Berrange ha scritto: I think this is really viable, because it implies we need another week prior to creating the pre-release where we do what we currently do with pre-release

Re: [libvirt] [PATCH] man pages: update the description for the virsh help command

2010-12-02 Thread Justin Clift
On 03/12/2010, at 4:47 AM, Eric Blake wrote: On the other hand, I'm thinking we implemented the help command slightly wrong by specifying that it takes two optional strings. Really, it only takes one optional string, which is a command-or-group. For instance, with the current code, 'virsh

Re: [libvirt] [PATCH] man pages: update the description for the virsh help command

2010-12-02 Thread Osier Yang
于 2010年12月03日 01:47, Eric Blake 写道: On 12/02/2010 06:04 AM, Justin Clift wrote: Now includes information on keyword usage, and provides examples. --- tools/virsh.pod | 37 ++--- 1 files changed, 34 insertions(+), 3 deletions(-) diff --git a/tools/virsh.pod

[libvirt] [PATCH] virsh: Remove redundant optional option for cmdHelp

2010-12-02 Thread Osier Yang
Remove the optional option group, as cmdHelp should accepts only one option, and rename option command as command-or-group, (virsh help supports both command and command group now, and user nealy uses the options, so it doesn't matter much for it being longer, :-) * tools/virsh.c ---

Re: [libvirt] [PATCH] man pages: update the description for the virsh help command

2010-12-02 Thread Osier Yang
于 2010年12月03日 14:50, Justin Clift 写道: On 03/12/2010, at 4:47 AM, Eric Blake wrote: On the other hand, I'm thinking we implemented the help command slightly wrong by specifying that it takes two optional strings. Really, it only takes one optional string, which is a command-or-group. For