Re: [libvirt] [PATCH] daemon: Fix core dumps if unix_sock_group is set

2011-01-07 Thread Eric Blake
On 01/07/2011 05:30 AM, Jiri Denemark wrote: >>> Setting unix_sock_group to something else than default "root" in >>> /etc/libvirt/libvirtd.conf prevents system libvirtd from dumping core on >>> crash. This is because we used setgid(unix_sock_group) before binding to >>> /var/run/libvirt/libvirt-so

Re: [libvirt] libvirt 0.8.7 msys and xdr weirdness

2011-01-07 Thread Eric Blake
> At first I wanted to say works for me, as I had tested the 0.8.7 RC1 > successfully, but then I checked the local diff in my tree and saw > that I had fixed a problem in portablexdr that I hadn't converted in a > proper patch yet. > > The problem was that libvirt's configure script recently star

Re: [libvirt] [PATCH 2/2] qemu: Update password support in the QEMU driver

2011-01-07 Thread Jiri Denemark
> Use the new set_password and expire_password monitor commands > to set password. > > We try to use that command first when setting a VNC/SPICE password. If > that doesn't work we fallback to the legacy VNC only password. > > Based on patch by Daniel P. Berrange . > --- > src/qemu/qemu_driver.c

Re: [libvirt] libvirt 0.8.7 msys and xdr weirdness

2011-01-07 Thread Matthias Bolte
2011/1/5 Justin Clift : > Hi Matthias, > > Have you tried out libvirt 0.8.7 yet with your msys scripts? > > Giving it a shot here, but am hitting problems with the --with-remote part.   > ./configure isn't finding the XDR library. > >  checking for xdrmem_create in -lportablexdr... no >  checking f

[libvirt] [PATCH 2/2] qemu: Update password support in the QEMU driver

2011-01-07 Thread Marc-André Lureau
From: Marc-André Lureau Use the new set_password and expire_password monitor commands to set password. We try to use that command first when setting a VNC/SPICE password. If that doesn't work we fallback to the legacy VNC only password. Based on patch by Daniel P. Berrange . --- src/qemu/qemu_

[libvirt] [PATCH 1/2] qemu: add set_password and expire_password monitor commands

2011-01-07 Thread Marc-André Lureau
From: Marc-André Lureau --- src/qemu/qemu_monitor.c | 77 ++ src/qemu/qemu_monitor.h |7 src/qemu/qemu_monitor_json.c | 56 ++ src/qemu/qemu_monitor_json.h |7 src/qemu/qemu_monitor_text.c | 69

[libvirt] [PATCH 0/2] Update qemu password support

2011-01-07 Thread Marc-André Lureau
Hi, Recently, QEMU learned set_password and expire_password monitor commands. http://qemu.com/qemu.git/commit/?id=7572150c189c6553c2448334116ab717680de66d The following patches make use of these new commands if available, and fallback on VNC-only password support. Marc-André Lureau (2): qemu:

Re: [libvirt] RFC: exposing a config setting to force vhost-net support on/off

2011-01-07 Thread Laine Stump
On 01/07/2011 10:55 AM, Daniel P. Berrange wrote: On Wed, Jan 05, 2011 at 09:57:42AM -0500, Laine Stump wrote: On 01/05/2011 05:19 AM, Daniel P. Berrange wrote: We should try to keep terminology matching the disk so I think with omission of resulting in us automatically adding either 'q

Re: [libvirt] [PATCH v3] Refactor the security drivers to simplify usage

2011-01-07 Thread Eric Blake
On 01/07/2011 12:15 PM, Eric Blake wrote: > On 01/07/2011 08:39 AM, Daniel P. Berrange wrote: >> This pair of checks for NULL clutters up the code, making the driver >> calls 2 lines longer than they really need to be. The goal of the >> patchset is to change the calling convention to simply >> >>

Re: [libvirt] [PATCH] Add AM_MAINTAINER_MODE

2011-01-07 Thread Guido Günther
On Fri, Jan 07, 2011 at 08:50:15AM -0700, Eric Blake wrote: > On 01/07/2011 03:34 AM, Guido Günther wrote: > > Hi, > > attached patchs adds AM_MAINTAINER_MODE and keeps it enabled by > > defaults. This allows downstreams to turn it of via: > > > > ./configure --disable-maintainer-mode > > > > as

Re: [libvirt] [PATCH v3] Refactor the security drivers to simplify usage

2011-01-07 Thread Eric Blake
On 01/07/2011 08:39 AM, Daniel P. Berrange wrote: > This pair of checks for NULL clutters up the code, making the driver > calls 2 lines longer than they really need to be. The goal of the > patchset is to change the calling convention to simply > > if (virSecurityManagerSetHostdevLabel(driver->

Re: [libvirt] [PATCH] esx: Move occurrence check into esxVI_LookupObjectContentByType

2011-01-07 Thread Matthias Bolte
2011/1/4 Eric Blake : > On 12/30/2010 05:36 AM, Matthias Bolte wrote: >> This simplifies the callers of esxVI_LookupObjectContentByType. > >> >>  src/esx/esx_driver.c |   19 ++-- >>  src/esx/esx_vi.c     |  128 >> - >>  src/esx/esx_vi.h     |    

Re: [libvirt] RFC: exposing a config setting to force vhost-net support on/off

2011-01-07 Thread Daniel P. Berrange
On Wed, Jan 05, 2011 at 09:57:42AM -0500, Laine Stump wrote: > On 01/05/2011 05:19 AM, Daniel P. Berrange wrote: > > > >We should try to keep terminology matching the disk > >so I think > > > > > > > >with omission of resulting in us automatically > >adding either 'qemu' or 'vhost' to the XML.

Re: [libvirt] [PATCH] Add AM_MAINTAINER_MODE

2011-01-07 Thread Eric Blake
On 01/07/2011 03:34 AM, Guido Günther wrote: > Hi, > attached patchs adds AM_MAINTAINER_MODE and keeps it enabled by > defaults. This allows downstreams to turn it of via: > > ./configure --disable-maintainer-mode > > as discussed in > > https://www.redhat.com/archives/virt-tools-list/2010-Octob

Re: [libvirt] [PATCH] Refactor the security drivers to simplify usage

2011-01-07 Thread Daniel P. Berrange
On Thu, Jan 06, 2011 at 11:21:45AM -0700, Eric Blake wrote: > On 01/06/2011 05:35 AM, Daniel P. Berrange wrote: > > The current security driver usage requires horrible code like > > > > if (driver->securityDriver && > > driver->securityDriver->domainSetSecurityHostdevLabel && > >

Re: [libvirt] hypervisor feature - hardware assisted paging

2011-01-07 Thread Jim Fehlig
Chris Lalancette wrote: > On 01/04/11 - 10:41:07AM, Jim Fehlig wrote: > >> I'm looking into a bug where a libvirt-created xen HVM guest boots >> *very* slowly on an EPT-enabled machine, particularly when the guest has >> a dedicated PCI device. >> >> xen-unstable c/s 16931 [1] introduced a per-g

Re: [libvirt] [PATCH] Fix instructions on 'vnc_password' to describe current behaviour

2011-01-07 Thread Neil Wilson
On Fri, 2011-01-07 at 14:51 +, Daniel P. Berrange wrote: > On Fri, Jan 07, 2011 at 02:38:05PM +, Daniel P. Berrange wrote: > > On Fri, Jan 07, 2011 at 02:17:37PM +, Neil Wilson wrote: > > > This documentation change fixes the description of vnc_password in > > > qemu.conf to fit the beh

Re: [libvirt] [PATCH] Fix instructions on 'vnc_password' to describe current behaviour

2011-01-07 Thread Daniel P. Berrange
On Fri, Jan 07, 2011 at 02:38:05PM +, Daniel P. Berrange wrote: > On Fri, Jan 07, 2011 at 02:17:37PM +, Neil Wilson wrote: > > This documentation change fixes the description of vnc_password in > > qemu.conf to fit the behaviour introduced in commit > > ab952024f42726a291d2c0ceda10071b88da7

Re: [libvirt] [PATCH] Fix instructions on 'vnc_password' to describe current behaviour

2011-01-07 Thread Daniel P. Berrange
On Fri, Jan 07, 2011 at 02:17:37PM +, Neil Wilson wrote: > This documentation change fixes the description of vnc_password in > qemu.conf to fit the behaviour introduced in commit > ab952024f42726a291d2c0ceda10071b88da7533 which treats a non-existent VNC > password and an empty string password

[libvirt] [PATCH] Fix instructions on 'vnc_password' to describe current behaviour

2011-01-07 Thread Neil Wilson
This documentation change fixes the description of vnc_password in qemu.conf to fit the behaviour introduced in commit ab952024f42726a291d2c0ceda10071b88da7533 which treats a non-existent VNC password and an empty string password in the same way. Addresses https://bugzilla.redhat.com/show_bug.cgi?

Re: [libvirt] [PATCH v2] esx: Add domain autostart support

2011-01-07 Thread Matthias Bolte
2011/1/7 Eric Blake : > On 01/06/2011 02:55 PM, Matthias Bolte wrote: >> --- >> >> v2: >>  - Don't enable the general autostart option if this affects the autostart >>    behavior of other domains. >>  - Refactor the lookup code for AutoStartDefaults and AutoStartPowerInfo into >>    functions. > >

Re: [libvirt] [PATCH] daemon: Fix core dumps if unix_sock_group is set

2011-01-07 Thread Jiri Denemark
> > Setting unix_sock_group to something else than default "root" in > > /etc/libvirt/libvirtd.conf prevents system libvirtd from dumping core on > > crash. This is because we used setgid(unix_sock_group) before binding to > > /var/run/libvirt/libvirt-sock* and setgid() back to original group. > >

Re: [libvirt] [PATCH] daemon: Fix core dumps if unix_sock_group is set

2011-01-07 Thread Daniel P. Berrange
On Fri, Jan 07, 2011 at 12:50:25PM +0100, Jiri Denemark wrote: > Setting unix_sock_group to something else than default "root" in > /etc/libvirt/libvirtd.conf prevents system libvirtd from dumping core on > crash. This is because we used setgid(unix_sock_group) before binding to > /var/run/libvirt/

Re: [libvirt] Implementing VNC per VM access control lists

2011-01-07 Thread Daniel P. Berrange
On Fri, Jan 07, 2011 at 11:56:30AM +, Neil Wilson wrote: > On Fri, 2011-01-07 at 11:47 +, Daniel P. Berrange wrote: > > > > The option only really makes sense if either vnc_tls_x509_verify or > > > vnc_sasl is set as well, so it may be worth only activating 'acl' in the > > > code if eithe

Re: [libvirt] Implementing VNC per VM access control lists

2011-01-07 Thread Neil Wilson
Eric, Thanks for the reply. On Thu, 2011-01-06 at 11:33 -0700, Eric Blake wrote: > When we first designed qemu:commandline, we debated about making it > smart enough to allow rewriting of existing arguments (rather than only > allowing addition of new arguments). This definitely sounds like a

Re: [libvirt] Implementing VNC per VM access control lists

2011-01-07 Thread Neil Wilson
On Fri, 2011-01-07 at 11:47 +, Daniel P. Berrange wrote: > > The option only really makes sense if either vnc_tls_x509_verify or > > vnc_sasl is set as well, so it may be worth only activating 'acl' in the > > code if either of those two are also on. > > If you enable 'acl' and don't add any

[libvirt] [PATCH] daemon: Fix core dumps if unix_sock_group is set

2011-01-07 Thread Jiri Denemark
Setting unix_sock_group to something else than default "root" in /etc/libvirt/libvirtd.conf prevents system libvirtd from dumping core on crash. This is because we used setgid(unix_sock_group) before binding to /var/run/libvirt/libvirt-sock* and setgid() back to original group. However, if a proces

Re: [libvirt] Implementing VNC per VM access control lists

2011-01-07 Thread Daniel P. Berrange
On Thu, Jan 06, 2011 at 06:00:12PM +, Neil Wilson wrote: > Having looked through this, I'm thinking that the simplest thing that > would be useful at the moment is simply to have an option in > the /etc/libvirt/qemu.conf that adds the acl option to the vnc switch in > qemu. > > It means that u

Re: [libvirt] [PATCHv2] handle DNS over IPv6

2011-01-07 Thread Daniel P. Berrange
On Thu, Jan 06, 2011 at 09:45:04PM +0100, Paweł Krześniak wrote: > 2011/1/6 Daniel P. Berrange : > > While it is shorter to just use '--interface brname' this comes > > at the price of loosing compatibility with older dnsmasq which > > we still wish to support. > > sure. RHEL5 is important target

[libvirt] [PATCH] Add AM_MAINTAINER_MODE

2011-01-07 Thread Guido Günther
Hi, attached patchs adds AM_MAINTAINER_MODE and keeps it enabled by defaults. This allows downstreams to turn it of via: ./configure --disable-maintainer-mode as discussed in https://www.redhat.com/archives/virt-tools-list/2010-October/msg00049.html O.k. to apply? Cheers, -- Guido >From 0af1bd

Re: [libvirt] Need a better word than "allocated" or "ascertained"

2011-01-07 Thread Nikunj A. Dadhania
CC'ing Balbir.. On Fri, 07 Jan 2011 10:33:08 +0100, Zdenek Styblik wrote: > On 01/07/2011 10:10 AM, Justin Clift wrote: > > On 07/01/2011, at 6:12 PM, Nikunj A. Dadhania wrote: > > > >>> Guaranteed sounds best to me. > >>> > >> Thats not Gauranteed to the best of my knowlegde > >> > >> Balbir

Re: [libvirt] Need a better word than "allocated" or "ascertained"

2011-01-07 Thread Zdenek Styblik
On 01/07/2011 10:10 AM, Justin Clift wrote: > On 07/01/2011, at 6:12 PM, Nikunj A. Dadhania wrote: > >>> Guaranteed sounds best to me. >>> >> Thats not Gauranteed to the best of my knowlegde >> >> Balbir suggest "enforced", I guessed i dropped it somewhere. >> https://www.redhat.com/archives/libvi

Re: [libvirt] Need a better word than "allocated" or "ascertained"

2011-01-07 Thread Justin Clift
On 07/01/2011, at 6:12 PM, Nikunj A. Dadhania wrote: >> Guaranteed sounds best to me. >> > Thats not Gauranteed to the best of my knowlegde > > Balbir suggest "enforced", I guessed i dropped it somewhere. > https://www.redhat.com/archives/libvir-list/2010-August/msg00712.html Balbir's suggested

Re: [libvirt] Release of libvirt-0.8.7

2011-01-07 Thread Laine Stump
(adding netcf-devel to the Cc list) On 01/06/2011 10:02 PM, Patrick Mullaney wrote: On Thu, 2011-01-06 at 17:00 -0700, Jim Fehlig wrote: Laine Stump wrote: As far as I know, the SuSE port was actually complete at one time, and was included in a released product (not sure what the product is),

Re: [libvirt] Release of libvirt-0.8.7

2011-01-07 Thread Zdenek Styblik
On 01/06/2011 06:00 PM, Zdenek Styblik wrote: [...] Please, send eventual replies to stybla /at/ turnovfree.net. Thank you, Thunderbird for switching 'From:' e-mail without letting me know! :( Grh! I hate when this happens. Z. -- Zdenek Styblik Net/Linux admin OS TurnovFree.net email: sty...@tu