* Nikunj A. Dadhania nik...@linux.vnet.ibm.com [2011-01-07 15:23:54]:
CC'ing Balbir..
On Fri, 07 Jan 2011 10:33:08 +0100, Zdenek Styblik sty...@turnovfree.net
wrote:
On 01/07/2011 10:10 AM, Justin Clift wrote:
On 07/01/2011, at 6:12 PM, Nikunj A. Dadhania wrote:
snip
Guaranteed
Hi,
Here's the patch to add basic ACL support to QEMU within libvirt. Like
SASL it's ignored by RHEL5's default qemu. Newer qemu picks it up as
expected and you can manipulate the acls using 'virsh'.
diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf
index ba41f80..7ab5eee 100644
---
Hey subscribers,
I have a problem with the actual libvirt/virsh release and qemu-kvm
0.13. if i want to save the actual status of my virtual machine i get
the following error:
lserver ~ # virsh save windows /virtual/windows_ram
error: Failed to save domain windows to /virtual/windows_ram
On Fri, Jan 07, 2011 at 12:29:40PM -0700, Eric Blake wrote:
On 01/07/2011 12:15 PM, Eric Blake wrote:
On 01/07/2011 08:39 AM, Daniel P. Berrange wrote:
This pair of checks for NULL clutters up the code, making the driver
calls 2 lines longer than they really need to be. The goal of the
If you use fchown(sock-fd) then you avoid any possible race issues.
Except that it doesn't work. That was the first thing I tried but fchown()
doesn't seem to work on unix sockets. The socket will still ended up with
root:root ownership regardless on where I put fchown() -- either
On Mon, Jan 10, 2011 at 11:20:31AM +0800, Wen Congyang wrote:
When we migrate a guest from remote host to localhost by p2p, the libvirtd
on remote host will be deadlock. This patch fixes a bug and we can avoid
the deadlock with this patch.
The steps to reproduce this bug:
# virsh -c
Recently, QEMU learned set_password and expire_password monitor commands.
http://qemu.com/qemu.git/commit/?id=7572150c189c6553c2448334116ab717680de66d
The following patches make use of these new commands if available, and
fallback on VNC-only password support.
Change since v1:
- moved
From: Marc-André Lureau marcandre.lur...@redhat.com
---
src/qemu/qemu_monitor.c | 77 ++
src/qemu/qemu_monitor.h |7
src/qemu/qemu_monitor_json.c | 56 ++
src/qemu/qemu_monitor_json.h |7
From: Marc-André Lureau marcandre.lur...@redhat.com
We try to use that command first when setting a VNC/SPICE password. If
that doesn't work we fallback to the legacy VNC only password
Allow an expiry time to be set, if that doesn't work, throw an error
if they try to use SPICE.
Change since
On 10/01/2011, at 5:41 PM, Daniel Veillard wrote:
[ Cc'ing back the list ]
On Sun, Jan 09, 2011 at 03:11:29AM +1100, Justin Clift wrote:
Hi Daniel,
Noticing these php warning's showing up in the apache libvirt.org error log:
[Sat Jan 08 17:09:24 2011] [error] [client 64.217.19.104] PHP
On 10/01/2011, at 7:55 PM, Balbir Singh wrote:
enforced is same as policing or forcing, whether or not the
application likes it. A soft limit is enforced when we hit resource
contention (that is the operating system finds it has to do work to
find free memory for applications), soft limits
On 01/10/2011 09:55 AM, Balbir Singh wrote:
* Nikunj A. Dadhania nik...@linux.vnet.ibm.com [2011-01-07 15:23:54]:
[...]
Or what happens when memory reaches 'soft-limit'?
enforced is same as policing or forcing, whether or not the
application likes it. A soft limit is enforced when we hit
2011/1/8 Justin Clift jcl...@redhat.com:
Hi Matthias,
Just came across an interesting (non fatal) bug with the new VirtualBox code
on
windows.
When starting virsh on a windows system that *doesn't* have VirtualBox
installed,
virsh prints an error to the users terminal about missing
Don't report an error when the VirtualBox registry key is missing,
as this just indicates that VirtualBox is not installed in general.
This matches the behavior of the XPCOM glue that silently ignores
a missing VBoxXPCOMC.so.
---
src/vbox/vbox_MSCOMGlue.c |2 --
1 files changed, 0
On 11/01/2011, at 1:05 AM, Matthias Bolte wrote:
Shows that I didn't test this on a Windows system without VirtualBox :(
That log message should be relaxed to info or debug level or even be
removed entirely as this is not error at all, as it just means that
VirtualBox is not installed.
2011/1/8 Justin Clift jcl...@redhat.com:
Hi guys,
Created the windows libvirt 0.8.7 installer using Matthias's updated
scripting:
http://libvirt.org/sources/win32_experimental/Libvirt-0.8.7-0.exe
Does someone have time to test and confirm it's ok, before we point to it from
the website?
On Mon, Jan 10, 2011 at 03:51:42PM +0100, Matthias Bolte wrote:
2011/1/8 Justin Clift jcl...@redhat.com:
Hi guys,
Created the windows libvirt 0.8.7 installer using Matthias's updated
scripting:
http://libvirt.org/sources/win32_experimental/Libvirt-0.8.7-0.exe
Does someone have
* Zdenek Styblik sty...@turnovfree.net [2011-01-10 14:08:43]:
On 01/10/2011 09:55 AM, Balbir Singh wrote:
* Nikunj A. Dadhania nik...@linux.vnet.ibm.com [2011-01-07 15:23:54]:
[...]
Or what happens when memory reaches 'soft-limit'?
enforced is same as policing or forcing, whether or
QEMU supports serving VNC over a unix domain socket rather than traditional
TCP host/port. This is specified with:
graphics type='vnc' socket='/foo/bar/baz'/
Currently not hooked up with the security driver, I'll wait for Dan's
big reorg. I also have a virtinst/virt-manager patch queued locally
In QEMU, the card itself is a PCI device, but it requires
-device hda-output in order to actually get sound to the host. AIUI this
is just HDA configuration and does not require stable addressing, so
is not presently represented in the XML.
Additionally, qemu supports audio input with '-device
On 11/01/2011, at 1:07 AM, Balbir Singh wrote:
* Zdenek Styblik sty...@turnovfree.net [2011-01-10 14:08:43]:
snip
A soft limit is enforced when host is running short on free resources or
during resource contention. Guest's resources are then pushed to
soft-limit as an attempt to regain free
On 01/10/2011 07:09 AM, Matthias Bolte wrote:
Don't report an error when the VirtualBox registry key is missing,
as this just indicates that VirtualBox is not installed in general.
This matches the behavior of the XPCOM glue that silently ignores
a missing VBoxXPCOMC.so.
---
On 01/09/2011 04:18 AM, Osier Yang wrote:
If invalid type is specified, e.g.
serial type='foo'
target port='0'/
/serial
We replace 'foo' with null type implicitly, without reporting an
error message to tell the user, and start or edit the domain
will be success.
It's not good to
On 12/08/2010 10:12 AM, Cole Robinson wrote:
On Fedore 14, virt-manager spews a bunch of warnings to the console:
/usr/lib64/python2.7/site-packages/libvirt.py:1781:
PendingDeprecationWarning: The CObject type is marked Pending Deprecation in
Python 2.7. Please use capsule objects
I noticed that there is quite a bit of code duplication among the
drivers that support domain events. This patch series is an attempt
to consolidate the shared logic.
Patch #1 is the bugfix for https://bugzilla.redhat.com/show_bug.cgi?id=624252
which started me down this path. It can be applied
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/test/test_driver.c | 104 ++-
1 files changed, 31 insertions(+), 73 deletions(-)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index ddff160..87350e8 100644
---
After the remote driver runs an event callback, it unconditionally disables the
loop timer, thinking it just flushed every queued event. This doesn't work
correctly though if an event is queued while a callback is running.
The events actually aren't being lost, it's just that the event loop
Make it easy to change debugging if being used by a client program.
Signed-off-by: Cole Robinson crobi...@redhat.com
---
examples/domain-events/events-python/event-test.py | 37 ++-
1 files changed, 19 insertions(+), 18 deletions(-)
diff --git
The same code for queueing, flushing, and deregistering events exists
in multiple drivers, which will soon use these common functions.
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/conf/domain_event.c | 74 ++-
src/conf/domain_event.h |
This structure will be used to unify lots of duplicated event handling code
across the state drivers.
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/conf/domain_event.c | 91 --
src/conf/domain_event.h | 47 +---
2
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/libvirt_private.syms |6 +++
src/qemu/qemu_conf.h |6 +---
src/qemu/qemu_driver.c | 80 +++---
3 files changed, 33 insertions(+), 59 deletions(-)
diff --git
One functionality change here is that we no longer force enable the event
timeout for every queued event, only enable it for the first event after
the queue has been flushed. This is how other drivers have already done it,
and it haven't encountered problems in practice.
Signed-off-by: Cole
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/lxc/lxc_conf.h |6 +---
src/lxc/lxc_driver.c | 76 --
2 files changed, 25 insertions(+), 57 deletions(-)
diff --git a/src/lxc/lxc_conf.h b/src/lxc/lxc_conf.h
index f820d6d..308a3dd
On 01/10/2011 10:19 AM, Cole Robinson wrote:
In QEMU, the card itself is a PCI device, but it requires
-device hda-output in order to actually get sound to the host. AIUI this
is just HDA configuration and does not require stable addressing, so
is not presently represented in the XML.
On 01/10/2011 10:15 AM, Cole Robinson wrote:
QEMU supports serving VNC over a unix domain socket rather than traditional
TCP host/port. This is specified with:
graphics type='vnc' socket='/foo/bar/baz'/
Currently not hooked up with the security driver, I'll wait for Dan's
big reorg. I
On 01/10/2011 10:38 AM, Cole Robinson wrote:
After the remote driver runs an event callback, it unconditionally disables
the
loop timer, thinking it just flushed every queued event. This doesn't work
correctly though if an event is queued while a callback is running.
The events actually
On 01/10/2011 10:38 AM, Cole Robinson wrote:
Make it easy to change debugging if being used by a client program.
Signed-off-by: Cole Robinson crobi...@redhat.com
---
examples/domain-events/events-python/event-test.py | 37 ++-
1 files changed, 19 insertions(+), 18
On 01/10/2011 12:44 PM, Eric Blake wrote:
On 01/10/2011 10:19 AM, Cole Robinson wrote:
In QEMU, the card itself is a PCI device, but it requires
-device hda-output in order to actually get sound to the host. AIUI this
is just HDA configuration and does not require stable addressing, so
is not
On Mon, Jan 10, 2011 at 12:19:07PM -0500, Cole Robinson wrote:
In QEMU, the card itself is a PCI device, but it requires
-device hda-output in order to actually get sound to the host. AIUI this
is just HDA configuration and does not require stable addressing, so
is not presently represented in
On Mon, Jan 10, 2011 at 10:44:29AM -0700, Eric Blake wrote:
On 01/10/2011 10:19 AM, Cole Robinson wrote:
In QEMU, the card itself is a PCI device, but it requires
-device hda-output in order to actually get sound to the host. AIUI this
is just HDA configuration and does not require stable
On Mon, Jan 10, 2011 at 12:58:09PM -0500, Cole Robinson wrote:
On 01/10/2011 12:44 PM, Eric Blake wrote:
On 01/10/2011 10:19 AM, Cole Robinson wrote:
In QEMU, the card itself is a PCI device, but it requires
-device hda-output in order to actually get sound to the host. AIUI this
is just
On 01/10/2011 10:38 AM, Cole Robinson wrote:
This structure will be used to unify lots of duplicated event handling code
across the state drivers.
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/conf/domain_event.c | 91 --
On 01/10/2011 12:40 PM, Eric Blake wrote:
On 01/10/2011 10:15 AM, Cole Robinson wrote:
QEMU supports serving VNC over a unix domain socket rather than traditional
TCP host/port. This is specified with:
graphics type='vnc' socket='/foo/bar/baz'/
Currently not hooked up with the security
On Mon, Jan 10, 2011 at 12:15:59PM -0500, Cole Robinson wrote:
QEMU supports serving VNC over a unix domain socket rather than traditional
TCP host/port. This is specified with:
graphics type='vnc' socket='/foo/bar/baz'/
Currently not hooked up with the security driver, I'll wait for Dan's
On 01/10/2011 10:38 AM, Cole Robinson wrote:
The same code for queueing, flushing, and deregistering events exists
in multiple drivers, which will soon use these common functions.
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/conf/domain_event.c | 74
On 01/10/2011 10:38 AM, Cole Robinson wrote:
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/libvirt_private.syms |6 +++
src/qemu/qemu_conf.h |6 +---
src/qemu/qemu_driver.c | 80
+++---
3 files changed, 33 insertions(+),
On 01/10/2011 10:38 AM, Cole Robinson wrote:
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/libvirt_private.syms |6 +++
src/qemu/qemu_conf.h |6 +---
src/qemu/qemu_driver.c | 80
+++---
3 files changed, 33 insertions(+),
On 01/10/2011 10:38 AM, Cole Robinson wrote:
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/lxc/lxc_conf.h |6 +---
src/lxc/lxc_driver.c | 76
--
2 files changed, 25 insertions(+), 57 deletions(-)
ACK
--
Eric Blake
On 01/10/2011 10:38 AM, Cole Robinson wrote:
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/test/test_driver.c | 104 ++-
1 files changed, 31 insertions(+), 73 deletions(-)
ACK.
--
Eric Blake ebl...@redhat.com+1-801-349-2682
On Thu, Jan 06, 2011 at 02:27:14PM +0100, Jiri Denemark wrote:
As different snapshot methods may require different input data, new
diskSnapshot XML element is introduced to describe disk snapshot method:
diskSnapshot method='qemu|lvm|btrfs|...'
!-- required data depending on the
On 01/10/2011 10:38 AM, Cole Robinson wrote:
One functionality change here is that we no longer force enable the event
timeout for every queued event, only enable it for the first event after
the queue has been flushed. This is how other drivers have already done it,
and it haven't encountered
On 01/07/2011 12:09 AM, Nikunj A. Dadhania wrote:
From: Nikunj A. Dadhania nik...@linux.vnet.ibm.com
Display unlimited when the memory cgroup settings says so. Unlimited is
represented by INT64_MAX in memory cgroup.
Signed-off-by: Nikunj A. Dadhania nik...@linux.vnet.ibm.com
Reported-by:
On 01/10/2011 12:36 PM, Cole Robinson wrote:
On 12/08/2010 10:12 AM, Cole Robinson wrote:
On Fedore 14, virt-manager spews a bunch of warnings to the console:
/usr/lib64/python2.7/site-packages/libvirt.py:1781: PendingDeprecationWarning: The CObject type is marked Pending Deprecation in
On 11/01/2011, at 12:08 AM, Zdenek Styblik wrote:
--- SNIP ---
A soft limit is enforced when host is running short on free resources or
during resource contention. Guest's resources are then pushed to
soft-limit as an attempt to regain free resources.
Limit is in kilobytes.
Applies to QEMU
On 01/10/2011 12:40 PM, Justin Clift wrote:
On 11/01/2011, at 12:08 AM, Zdenek Styblik wrote:
--- SNIP ---
A soft limit is enforced when host is running short on free resources or
during resource contention. Guest's resources are then pushed to
soft-limit as an attempt to regain free
On 11/01/2011, at 6:49 AM, Eric Blake wrote:
On 01/10/2011 12:40 PM, Justin Clift wrote:
On 11/01/2011, at 12:08 AM, Zdenek Styblik wrote:
--- SNIP ---
A soft limit is enforced when host is running short on free resources or
during resource contention. Guest's resources are then pushed to
On 01/10/2011 01:45 PM, Eric Blake wrote:
On 01/10/2011 10:38 AM, Cole Robinson wrote:
One functionality change here is that we no longer force enable the event
timeout for every queued event, only enable it for the first event after
the queue has been flushed. This is how other drivers have
On 01/10/2011 02:07 PM, Laine Stump wrote:
On 01/10/2011 12:36 PM, Cole Robinson wrote:
On 12/08/2010 10:12 AM, Cole Robinson wrote:
On Fedore 14, virt-manager spews a bunch of warnings to the console:
/usr/lib64/python2.7/site-packages/libvirt.py:1781:
PendingDeprecationWarning: The
The same code for queueing, flushing, and deregistering events exists
in multiple drivers, which will soon use these common functions.
v2:
Adjust libvirt_private.syms
isDispatching bool fixes
NONNULL tagging
Signed-off-by: Cole Robinson crobi...@redhat.com
---
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/lxc/lxc_conf.h |6 +---
src/lxc/lxc_driver.c | 76 --
2 files changed, 25 insertions(+), 57 deletions(-)
diff --git a/src/lxc/lxc_conf.h b/src/lxc/lxc_conf.h
index f820d6d..308a3dd
I noticed that there is quite a bit of code duplication among the
drivers that support domain events. This patch series is an attempt
to consolidate the shared logic.
v2:
2 patches were applied
Addressed Eric's comments:
NONNULL tagging
Use bool for isDispatching
Move
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/test/test_driver.c | 104 ++-
1 files changed, 31 insertions(+), 73 deletions(-)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index ddff160..87350e8 100644
---
One functionality change here is that we no longer force enable the event
timeout for every queued event, only enable it for the first event after
the queue has been flushed. This is how other drivers have already done it,
and it haven't encountered problems in practice.
Signed-off-by: Cole
This structure will be used to unify lots of duplicated event handling code
across the state drivers.
v2:
Check for state == NULL in StateFree
Add NONNULL tagging
Use bool for isDispatching
Signed-off-by: Cole Robinson crobi...@redhat.com
---
cfg.mk |1 +
v2:
Drop libvirt_private.syms changes
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/qemu/qemu_conf.h |6 +---
src/qemu/qemu_driver.c | 80 +++
2 files changed, 27 insertions(+), 59 deletions(-)
diff --git a/src/qemu/qemu_conf.h
---
Pushed this under the trivial rule.
docs/virshcmdref.html.in | 16
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/docs/virshcmdref.html.in b/docs/virshcmdref.html.in
index 76eb822..4845312 100644
--- a/docs/virshcmdref.html.in
+++ b/docs/virshcmdref.html.in
On 01/10/2011 01:28 PM, Cole Robinson wrote:
I noticed that there is quite a bit of code duplication among the
drivers that support domain events. This patch series is an attempt
to consolidate the shared logic.
v2:
2 patches were applied
Addressed Eric's comments:
NONNULL
On 11/01/2011, at 7:35 AM, Justin Clift wrote:
---
Pushed this under the trivial rule.
docs/virshcmdref.html.in | 16
1 files changed, 8 insertions(+), 8 deletions(-)
Pushed this already under the trivial rule.
--
libvir-list mailing list
libvir-list@redhat.com
On 11/01/2011, at 1:09 AM, Matthias Bolte wrote:
Don't report an error when the VirtualBox registry key is missing,
as this just indicates that VirtualBox is not installed in general.
This matches the behavior of the XPCOM glue that silently ignores
a missing VBoxXPCOMC.so.
---
On 11/01/2011, at 1:51 AM, Matthias Bolte wrote:
The readme suggests (at least to me) that the TLS certs for libvirt's
TLS transport and the ESX driver using HTTPS are the same:
TLS certificates are needed prior to connecting to either
QEMU instances with TLS, or connecting to VMware
* src/util/network.c (virSocketAddrMask): Zero out port, so that
iptables can initialize just the netmask, then call
virSocketFormatAddr without an uninitialized read in getnameinfo.
---
I'm not sure if this is the best patch; an alternative would be
to call memset(network,0,sizeof network) in
* src/conf/network_conf.c (virNetworkDefParseXML): Release ipNodes.
---
Another memleak found by valgrind; shown with additional context
to make review easier.
src/conf/network_conf.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/src/conf/network_conf.c
* src/cpu/cpu_x86.c (x86ModelLoad): Free data before overwriting.
---
Yet another valgrind finding; 320 bytes per domain XML parse.
src/cpu/cpu_x86.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c
index df1e431..ae8e5e7 100644
At 01/10/2011 07:02 PM, Daniel P. Berrange Write:
On Mon, Jan 10, 2011 at 11:20:31AM +0800, Wen Congyang wrote:
When we migrate a guest from remote host to localhost by p2p, the libvirtd
on remote host will be deadlock. This patch fixes a bug and we can avoid
the deadlock with this patch.
Hi,
I am trying to create a VM using the Python bindings of Libvirt. I can
successfully create VM from a XML template, but I can't find any way to
define the guest OS type/variant like CentOS 5.5 64bit for my VM. The native
format converted from XML is always guestOS=other-64 - which doesn't tell
On 01/10/2011 05:28 PM, Eric Blake wrote:
* src/util/network.c (virSocketAddrMask): Zero out port, so that
iptables can initialize just the netmask, then call
virSocketFormatAddr without an uninitialized read in getnameinfo.
---
I'm not sure if this is the best patch; an alternative would be
to
At 01/05/2011 10:53 AM, Wen Congyang Write:
If the memory of guest OS is changed constantly, the live migration
can not be ended ever for ever.
We can use the command 'virsh migrate-setmaxdowntime' to control the
live migration. But the value of maxdowntime is diffcult to calculate
because
libvir-list-boun...@redhat.com wrote on 01/10/2011 06:59:12 PM:
From: Eric Blake ebl...@redhat.com
To: libvir-list@redhat.com
Date: 01/10/2011 07:08 PM
Subject: [libvirt] [PATCH] cpu: plug memory leak
Sent by: libvir-list-boun...@redhat.com
* src/cpu/cpu_x86.c (x86ModelLoad): Free data
On 01/10/2011 05:38 PM, Eric Blake wrote:
* src/conf/network_conf.c (virNetworkDefParseXML): Release ipNodes.
---
Another memleak found by valgrind; shown with additional context
to make review easier.
src/conf/network_conf.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
On 01/10/2011 05:28 PM, Eric Blake wrote:
* src/util/network.c (virSocketAddrMask): Zero out port, so that
iptables can initialize just the netmask, then call
virSocketFormatAddr without an uninitialized read in getnameinfo.
---
I'm not sure if this is the best patch; an alternative would be
to
On Mon, 10 Jan 2011 12:02:36 -0700, Eric Blake ebl...@redhat.com wrote:
On 01/07/2011 12:09 AM, Nikunj A. Dadhania wrote:
From: Nikunj A. Dadhania nik...@linux.vnet.ibm.com
Display unlimited when the memory cgroup settings says so. Unlimited is
represented by INT64_MAX in memory cgroup.
If the emulator doesn't support SDL graphic, we should reject
the use of SDL graphic xml with error messages, but not ignore
it silently.
* src/qemu/qemu_command.c
---
src/qemu/qemu_command.c | 12 +---
1 files changed, 9 insertions(+), 3 deletions(-)
diff --git
82 matches
Mail list logo
