[libvirt] [PATCH v4] memtune: Let virsh know the unlimited value for memory tunables

2011-01-12 Thread Nikunj A. Dadhania
On Wed, 12 Jan 2011 10:21:04 -0700, Eric Blake wrote: > On 01/12/2011 12:56 AM, Nikunj A. Dadhania wrote: > > Here is the patch, now the set calls are also ull. > > > > Still virCgroupGetMemoryUsage is not changed, this will require changes > > in virDomainInfoPtr (info->memory). I am not sure i

[libvirt] [PATCH] Add XML config switch to enable/disable vhost-net support

2011-01-12 Thread Laine Stump
This patch is in response to https://bugzilla.redhat.com/show_bug.cgi?id=643050 The existing libvirt support for the vhost-net backend to the virtio network driver happens automatically - if the vhost-net device is available, it is always enabled, otherwise the standard userland virtio backend

[libvirt] [PATCH] Enable tuning of qemu network tap device "sndbuf" size

2011-01-12 Thread Laine Stump
This is in response to a request in: https://bugzilla.redhat.com/show_bug.cgi?id=665293 In short, under heavy load, it's possible for qemu's networking to lock up due to the tap device's default 1MB sndbuf being inadequate. adding "sndbuf=0" to the qemu commandline -netdevice option will allev

Re: [libvirt] [PATCH] Fix crash in SELinuxSecurityVerify

2011-01-12 Thread Osier Yang
于 2011年01月13日 13:30, Laine Stump 写道: When attempting to edit a domain, libvirtd segfaulted in SELinuxSecurityVerify() on this line: if (!STREQ(virSecurityManagerGetModel(mgr), secdef->model)) { because secdef->model was NULL. There is STREQ_NULLABLE defined in internal.h, but seems it's ne

[libvirt] [PATCH] Fix crash in SELinuxSecurityVerify

2011-01-12 Thread Laine Stump
When attempting to edit a domain, libvirtd segfaulted in SELinuxSecurityVerify() on this line: if (!STREQ(virSecurityManagerGetModel(mgr), secdef->model)) { because secdef->model was NULL. Although I'm too tired to investigate in depth, I noticed that all the other functions in that file that d

Re: [libvirt] cont command failing via JSON monitor on restore

2011-01-12 Thread Laine Stump
On 01/12/2011 05:13 PM, Jim Fehlig wrote: libvirt 0.8.7 qemu 0.13 I'm looking into a problem with qemu save/restore via JSON monitor. On restore, the vm is left in a paused state with following error returned for 'cont' command An incoming migration is expected before this command can be execu

Re: [libvirt] [PATCH] build: restore mingw build

2011-01-12 Thread Eric Blake
On 01/12/2011 05:50 PM, Eric Blake wrote: > On 01/12/2011 05:44 PM, Eric Blake wrote: >> * bootstrap.conf (gnulib_modules): Add chmod. >> --- >> >> Pushing under the build-breaker rule; ./autobuild.sh failed to >> cross-compile to mingw due to commit d596c6d requiring chown(). >> The gnulib functio

Re: [libvirt] esx driver: XML format for guest OS type/variant

2011-01-12 Thread Jake Xu
Thanks everyone. It's time to go home now. I will finish reading the thread and respond later. Jake On Wed, Jan 12, 2011 at 4:09 PM, Richard W.M. Jones wrote: > On Wed, Jan 12, 2011 at 03:16:00PM -0700, Eric Blake wrote: > > It may be worth adding an optional XML element that records a string to

Re: [libvirt] [v3] qemu: Reject SDL graphic if it's not supported by qemu

2011-01-12 Thread Osier Yang
于 2011年01月13日 00:54, Eric Blake 写道: > On 01/12/2011 07:44 AM, Osier Yang wrote: >> If the emulator doesn't support SDL graphic, we should reject >> the use of SDL graphic xml with error messages, but not ignore >> it silently, and pretend things are fine. >> >> "-sdl" flag was exposed explicitly by

Re: [libvirt] [PATCH v2 2/2] doc: improve the documentation of desturi

2011-01-12 Thread Wen Congyang
At 01/13/2011 12:54 AM, Eric Blake Write: > On 01/12/2011 05:25 AM, Daniel P. Berrange wrote: >> On Wed, Jan 12, 2011 at 02:12:39PM +0800, Wen Congyang wrote: >>> >>> Signed-off-by: Wen Congyang >>> >>> +=item * normal migration: the I is an address of the target host >>> as >>> +seen from the cl

Re: [libvirt] [PATCH] build: restore mingw build

2011-01-12 Thread Eric Blake
On 01/12/2011 05:44 PM, Eric Blake wrote: > * bootstrap.conf (gnulib_modules): Add chmod. > --- > > Pushing under the build-breaker rule; ./autobuild.sh failed to > cross-compile to mingw due to commit d596c6d requiring chown(). > The gnulib function is just an always-failing stub on mingw, > but

[libvirt] [PATCH] build: restore mingw build

2011-01-12 Thread Eric Blake
* bootstrap.conf (gnulib_modules): Add chmod. --- Pushing under the build-breaker rule; ./autobuild.sh failed to cross-compile to mingw due to commit d596c6d requiring chown(). The gnulib function is just an always-failing stub on mingw, but at least it lets things link again. bootstrap.conf |

Re: [libvirt] esx driver: XML format for guest OS type/variant

2011-01-12 Thread Richard W.M. Jones
On Wed, Jan 12, 2011 at 03:16:00PM -0700, Eric Blake wrote: > It may be worth adding an optional XML element that records a string to > use for the guestOS argument. In fact, the libguestfs tool suite > already has some pretty decent ways to guess the OS of an arbitrary VM > guest (even when using

[libvirt] openvzReadNetworkConf:318 : out of memory

2011-01-12 Thread Nathan Stratton
I have been working to get libvirt to work with openvz and kvm. I have had no issues with KVM but libvirt is hit or miss. Sometimes I get it to work, but most of the time I get back "out of memory". I have tried all recent versions of libvirt and vzctl from openvz. Any pointers? 17:52:31.974

Re: [libvirt] [PATCHv3] handle DNS over IPv6

2011-01-12 Thread Eric Blake
On 01/12/2011 02:24 PM, Paweł Krześniak wrote: > 2011/1/7 Daniel P. Berrange : >> Practically no apps >> will be do this and so they typically can't make use of >> the link-local address. > > I agree. > v2 of patch attached. Can you convince your mailer to send patches with mime type text/plain,

Re: [libvirt] esx driver: XML format for guest OS type/variant

2011-01-12 Thread Richard W.M. Jones
On Wed, Jan 12, 2011 at 03:51:04PM -0700, Eric Blake wrote: > [adding Richard Jones, as he is more familiar with OS inspection] > > On 01/12/2011 03:29 PM, Matthias Bolte wrote: > > > > One thing I wonder about is, where to get the list of possible values > > for the guest OS type and variation f

Re: [libvirt] esx driver: XML format for guest OS type/variant

2011-01-12 Thread Eric Blake
[adding Richard Jones, as he is more familiar with OS inspection] On 01/12/2011 03:29 PM, Matthias Bolte wrote: > > One thing I wonder about is, where to get the list of possible values > for the guest OS type and variation from? Do we use what > virt-install/virt-manager currently use and map th

Re: [libvirt] esx driver: XML format for guest OS type/variant

2011-01-12 Thread Matthias Bolte
2011/1/12 Justin Clift : > On 11/01/2011, at 12:53 PM, Jake Xu wrote: >> Hi, >> >> I am trying to create a VM using the Python bindings of Libvirt. I can >> successfully create VM from a XML template, but I can't find any way to >> define the guest OS type/variant like CentOS 5.5 64bit for my VM.

Re: [libvirt] esx driver: XML format for guest OS type/variant

2011-01-12 Thread Matthias Bolte
2011/1/12 Eric Blake : > On 01/10/2011 06:53 PM, Jake Xu wrote: >> Hi, >> >> I am trying to create a VM using the Python bindings of Libvirt. I can >> successfully create VM from a XML template, but I can't find any way to >> define the guest OS type/variant like CentOS 5.5 64bit for my VM. The nat

Re: [libvirt] esx driver: XML format for guest OS type/variant

2011-01-12 Thread Matthias Bolte
2011/1/11 Jake Xu : > Hi, > I am trying to create a VM using the Python bindings of Libvirt. I can > successfully create VM from a XML template, but I can't find any way to > define the guest OS type/variant like CentOS 5.5 64bit for my VM. The native > format converted from XML is always guestOS="

Re: [libvirt] [PATCH 0/4] Add HAP to domain features

2011-01-12 Thread Jim Fehlig
Any comments on this patch set? In hindsight, I probably should have sent this as a single patch but I wanted to break out #3 since I wasn't sure about the capabilities advertisement. In doing so I went a little overboard ... Thanks, Jim Jim Fehlig wrote: > Hardware features such as Extended Pa

Re: [libvirt] esx driver: XML format for guest OS type/variant

2011-01-12 Thread Eric Blake
On 01/10/2011 06:53 PM, Jake Xu wrote: > Hi, > > I am trying to create a VM using the Python bindings of Libvirt. I can > successfully create VM from a XML template, but I can't find any way to > define the guest OS type/variant like CentOS 5.5 64bit for my VM. The native > format converted from X

[libvirt] cont command failing via JSON monitor on restore

2011-01-12 Thread Jim Fehlig
libvirt 0.8.7 qemu 0.13 I'm looking into a problem with qemu save/restore via JSON monitor. On restore, the vm is left in a paused state with following error returned for 'cont' command An incoming migration is expected before this command can be executed I was trying to debug the issue in gdb,

Re: [libvirt] [PATCH] docs: clarify that virsh setvcpus and setmem only work on active domains

2011-01-12 Thread Justin Clift
On 13/01/2011, at 8:54 AM, Eric Blake wrote: > On 01/12/2011 02:24 PM, Justin Clift wrote: >> Addresses BZ # 622534: >> >> https://bugzilla.redhat.com/show_bug.cgi?id=622534 >> --- >> tools/virsh.pod | 28 ++-- >> 1 files changed, 18 insertions(+), 10 deletions(-) >> >>

Re: [libvirt] [PATCH] docs: clarify that virsh setvcpus and setmem only work on active domains

2011-01-12 Thread Eric Blake
On 01/12/2011 02:24 PM, Justin Clift wrote: > Addresses BZ # 622534: > > https://bugzilla.redhat.com/show_bug.cgi?id=622534 > --- > tools/virsh.pod | 28 ++-- > 1 files changed, 18 insertions(+), 10 deletions(-) > > diff --git a/tools/virsh.pod b/tools/virsh.pod > ind

Re: [libvirt] esx driver: XML format for guest OS type/variant

2011-01-12 Thread Justin Clift
On 11/01/2011, at 12:53 PM, Jake Xu wrote: > Hi, > > I am trying to create a VM using the Python bindings of Libvirt. I can > successfully create VM from a XML template, but I can't find any way to > define the guest OS type/variant like CentOS 5.5 64bit for my VM. The native > format converted

Re: [libvirt] [PATCH 7/7] security: Allow disabling security on a per VM basis

2011-01-12 Thread Eric Blake
On 01/12/2011 10:23 AM, Cole Robinson wrote: > Make the SecurityManager explicitly handle the case when seclabel > model='none'. > > Signed-off-by: Cole Robinson > --- > src/security/security_manager.c| 90 > +--- > .../qemuxml2xml-seclabel-model-none-in.xm

Re: [libvirt] [PATCH] esx: Fix memory leak in HostSystem managed object free function

2011-01-12 Thread Matthias Bolte
2011/1/11 Eric Blake : > On 01/11/2011 01:41 PM, Matthias Bolte wrote: >> --- >>  src/esx/esx_vi_types.c |    1 + >>  1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/src/esx/esx_vi_types.c b/src/esx/esx_vi_types.c >> index 4ee4110..f3df2b5 100644 >> --- a/src/esx/esx_vi_types.c

Re: [libvirt] [PATCH 6/7] domain: Always validate seclabel model

2011-01-12 Thread Eric Blake
On 01/12/2011 10:23 AM, Cole Robinson wrote: > This will help facilitate disabling seclabel for an individual VM. One > functional change is that the user can now hardcode type='dynamic', but > there was no good reason to deny it anyways. > > Signed-off-by: Cole Robinson > --- > src/conf/domain_

[libvirt] [PATCH] docs: fix trivial typos in currentMemory description

2011-01-12 Thread Justin Clift
--- Pushed this already as a trivial patch. docs/formatdomain.html.in |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index e9fcea1..99068ad 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -

[libvirt] [PATCH] docs: clarify that virsh setvcpus and setmem only work on active domains

2011-01-12 Thread Justin Clift
Addresses BZ # 622534: https://bugzilla.redhat.com/show_bug.cgi?id=622534 --- tools/virsh.pod | 28 ++-- 1 files changed, 18 insertions(+), 10 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 0e03d68..b4c6ff7 100644 --- a/tools/virsh.pod +++ b/tools/v

Re: [libvirt] [PATCHv3] handle DNS over IPv6

2011-01-12 Thread Paweł Krześniak
2011/1/7 Daniel P. Berrange : > Practically no apps > will be do this and so they typically can't make use of > the link-local address. I agree. v2 of patch attached. -- Pawel handle-dns.patch Description: Binary data -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/ma

Re: [libvirt] [PATCH v3] memtune: Let virsh know the unlimited value for memory tunables

2011-01-12 Thread Matthias Bolte
2011/1/12 Eric Blake : > On 01/12/2011 12:56 AM, Nikunj A. Dadhania wrote: >> Here is the patch, now the set calls are also ull. >> +++ b/tools/virsh.c >> @@ -2987,9 +2987,14 @@ cmdMemtune(vshControl * ctl, const vshCmd * cmd) >>                               params[i].value.l); >>                

Re: [libvirt] [PATCH 5/7] domain: Handle seclabel model with an enum

2011-01-12 Thread Eric Blake
On 01/12/2011 10:23 AM, Cole Robinson wrote: > This allows us to explicitly handle the 'default' seclabel case, as > well as provide easier model validation. > > Signed-off-by: Cole Robinson > --- I'm not so sure about this one. I didn't see any coding bugs in the actual patch, but design-wise:

Re: [libvirt] [PATCH 4/7] qemu: Fix segfault if defining a domain without

2011-01-12 Thread Eric Blake
On 01/12/2011 10:23 AM, Cole Robinson wrote: > If the selinux driver is the default, it will lead to a null dereference. > This change should still yeild the intended result, since a null model > basically implies 'use the default'. > > Signed-off-by: Cole Robinson > --- > src/security/security_

Re: [libvirt] [PATCH 3/7] security: Add virSecurityIsSpecifiedDriver

2011-01-12 Thread Eric Blake
On 01/12/2011 10:22 AM, Cole Robinson wrote: > > Signed-off-by: Cole Robinson > --- > src/security/security_apparmor.c |7 +-- > src/security/security_driver.c | 19 +++ > src/security/security_driver.h |3 +++ > src/security/security_selinux.c | 29 +

Re: [libvirt] [PATCH 2/7] security: Use virDomainSeclabelDefClear

2011-01-12 Thread Eric Blake
On 01/12/2011 10:22 AM, Cole Robinson wrote: > Renamed from virSecurityLabelDefFree. I like the rename, but... > > Signed-off-by: Cole Robinson > --- > cfg.mk |1 + > src/conf/domain_conf.c | 17 + > src/conf/domain_conf.h |

[libvirt] [PATCHv2 2/2] tests: virsh is no longer in builddir/src

2011-01-12 Thread Eric Blake
Commit 870dba0 (Mar 2008) added builddir/src to PATH to pick up virsh. Later, virsh was moved to tools; commit db68d6b (Oct 2009) noticed this, but only added the new location rather than deleting the old location. * tests/Makefile.am (path_add): Drop now-useless directory. Suggested by Daniel P.

[libvirt] [PATCHv2 1/2] virFindFileInPath: only find executable non-directory

2011-01-12 Thread Eric Blake
Without this patch, at least tests/daemon-conf (which sticks $builddir/src in the PATH) tries to execute the directory $builddir/src/qemu rather than a real qemu binary. * src/util/util.h (virFileExists): Adjust prototype. (virFileIsExecutable): New prototype. * src/util/util.c (virFindFileInPath)

Re: [libvirt] [PATCH 1/7] tests: Add qemuxml2xml tests for handling

2011-01-12 Thread Eric Blake
On 01/12/2011 10:22 AM, Cole Robinson wrote: > +++ b/tests/domainschematest > @@ -4,7 +4,7 @@ > . $srcdir/test-lib.sh > . $abs_srcdir/schematestutils.sh > > -DIRS="domainschemadata qemuxml2argvdata sexpr2xmldata xmconfigdata > xml2sexprdata qemuxml2xmloutdata" > +DIRS="domainschemadata qemuxml

Re: [libvirt] [PATCH] virFindFileInPath: only find executable non-directory

2011-01-12 Thread Eric Blake
On 01/12/2011 10:39 AM, Daniel P. Berrange wrote: > On Wed, Jan 12, 2011 at 09:24:57AM -0700, Eric Blake wrote: >> Without this patch, at least tests/daemon-conf (which sticks >> $builddir/src in the PATH) tries to execute the directory >> $builddir/src/qemu rather than the real /usr/bin/qemu binar

Re: [libvirt] [PATCH 0/7] security: Allow disabling security per VM

2011-01-12 Thread Daniel P. Berrange
On Wed, Jan 12, 2011 at 12:22:56PM -0500, Cole Robinson wrote: > Enabling a security driver in qemu.conf is currently all or nothing. > The option to disable security on a per VM basis can be a useful debugging > tool or work around for frustrated users. > > Patches 1-3 and 5-6 are prep and cleanu

Re: [libvirt] [PATCH] virFindFileInPath: only find executable non-directory

2011-01-12 Thread Daniel P. Berrange
On Wed, Jan 12, 2011 at 09:24:57AM -0700, Eric Blake wrote: > Without this patch, at least tests/daemon-conf (which sticks > $builddir/src in the PATH) tries to execute the directory > $builddir/src/qemu rather than the real /usr/bin/qemu binary. Not looking at your patch, I have to question why o

[libvirt] [PATCH 2/3] qemu: Allow serving VNC over a unix domain socket

2011-01-12 Thread Cole Robinson
QEMU supports serving VNC over a unix domain socket rather than traditional TCP host/port. This is specified with: This provides better security access control than VNC listening on 127.0.0.1, but will cause issues with tools that rely on the lax security (virt-manager in fedora runs as regular

[libvirt] [PATCH 1/3] qemu: Set domain def transient at beginning of startup process

2011-01-12 Thread Cole Robinson
This will allow us to record transient runtime state in vm->def, like default VNC parameters. Accomplish this by adding an extra 'live' parameter to SetDefTransient, with similar semantics to the 'live' flag for AssignDef. Signed-off-by: Cole Robinson --- src/conf/domain_conf.c | 11 --

[libvirt] [PATCH 0/3 v2] qemu: Allow serving VNC over a unix domain socket

2011-01-12 Thread Cole Robinson
This series enables use of qemu's -vnc unix:/some/socket/path functionality. A qemu.conf option is provided to make this the default for VNC devices without an explicit listen or socket value. Serving VNC over a unix socket prevents unprivileged local users from accessing a guest's console. The do

[libvirt] [PATCH 3/3] qemu: Add conf option to auto setup VNC unix sockets

2011-01-12 Thread Cole Robinson
If vnc_auto_unix_socket is enabled, any VNC devices without a hardcoded listen or socket value will be setup to serve over a unix socket in /var/lib/libvirt/qemu/$vmname.vnc. We store the generated socket path in the transient VM definition at CLI build time. Signed-off-by: Cole Robinson --- sr

[libvirt] [PATCH 6/7] domain: Always validate seclabel model

2011-01-12 Thread Cole Robinson
This will help facilitate disabling seclabel for an individual VM. One functional change is that the user can now hardcode type='dynamic', but there was no good reason to deny it anyways. Signed-off-by: Cole Robinson --- src/conf/domain_conf.c | 34 ++---

[libvirt] [PATCH 3/7] security: Add virSecurityIsSpecifiedDriver

2011-01-12 Thread Cole Robinson
Signed-off-by: Cole Robinson --- src/security/security_apparmor.c |7 +-- src/security/security_driver.c | 19 +++ src/security/security_driver.h |3 +++ src/security/security_selinux.c | 29 + 4 files changed, 28 insertions(+), 30

[libvirt] [PATCH 7/7] security: Allow disabling security on a per VM basis

2011-01-12 Thread Cole Robinson
Make the SecurityManager explicitly handle the case when seclabel model='none'. Signed-off-by: Cole Robinson --- src/security/security_manager.c| 90 +--- .../qemuxml2xml-seclabel-model-none-in.xml | 21 + .../qemuxml2xml-seclabel-model-none-ou

[libvirt] [PATCH 2/7] security: Use virDomainSeclabelDefClear

2011-01-12 Thread Cole Robinson
Renamed from virSecurityLabelDefFree. Signed-off-by: Cole Robinson --- cfg.mk |1 + src/conf/domain_conf.c | 17 + src/conf/domain_conf.h |1 + src/libvirt_private.syms |2 +- src/qemu/qemu_driver.c |

Re: [libvirt] [PATCH v3] memtune: Let virsh know the unlimited value for memory tunables

2011-01-12 Thread Eric Blake
On 01/12/2011 12:56 AM, Nikunj A. Dadhania wrote: > Here is the patch, now the set calls are also ull. > > Still virCgroupGetMemoryUsage is not changed, this will require changes > in virDomainInfoPtr (info->memory). I am not sure if I should have them > in this patch. It can be a separate patch

[libvirt] [PATCH 5/7] domain: Handle seclabel model with an enum

2011-01-12 Thread Cole Robinson
This allows us to explicitly handle the 'default' seclabel case, as well as provide easier model validation. Signed-off-by: Cole Robinson --- src/conf/domain_conf.c | 38 ++ src/conf/domain_conf.h | 14 -- src/security/secur

[libvirt] [PATCH 4/7] qemu: Fix segfault if defining a domain without

2011-01-12 Thread Cole Robinson
If the selinux driver is the default, it will lead to a null dereference. This change should still yeild the intended result, since a null model basically implies 'use the default'. Signed-off-by: Cole Robinson --- src/security/security_driver.c |3 ++- 1 files changed, 2 insertions(+), 1 de

[libvirt] [PATCH 1/7] tests: Add qemuxml2xml tests for handling

2011-01-12 Thread Cole Robinson
Signed-off-by: Cole Robinson --- docs/schemas/domain.rng| 13 - tests/domainschematest |2 +- .../qemuxml2xml-balloon-device-auto-out.xml| 25 + .../qemuxml2xml-channel-virtio-auto-out.xml| 54 +

[libvirt] [PATCH 0/7] security: Allow disabling security per VM

2011-01-12 Thread Cole Robinson
Enabling a security driver in qemu.conf is currently all or nothing. The option to disable security on a per VM basis can be a useful debugging tool or work around for frustrated users. Patches 1-3 and 5-6 are prep and cleanup work. Patch 4 fixes an easily triggerable segfault when defining a doma

Re: [libvirt] [v3] qemu: Reject SDL graphic if it's not supported by qemu

2011-01-12 Thread Eric Blake
On 01/12/2011 07:44 AM, Osier Yang wrote: > If the emulator doesn't support SDL graphic, we should reject > the use of SDL graphic xml with error messages, but not ignore > it silently, and pretend things are fine. > > "-sdl" flag was exposed explicitly by qemu since 0.10.0, more detail: > http://

Re: [libvirt] [PATCH v2 2/2] doc: improve the documentation of desturi

2011-01-12 Thread Eric Blake
On 01/12/2011 05:25 AM, Daniel P. Berrange wrote: > On Wed, Jan 12, 2011 at 02:12:39PM +0800, Wen Congyang wrote: >> >> Signed-off-by: Wen Congyang >> >> +=item * normal migration: the I is an address of the target host as >> +seen from the client machine. >> + >> +=item * peer2peer migration: the

Re: [libvirt] [PATCH] docs: reorder apps page alphabetically, plus add libguestfs entries

2011-01-12 Thread Justin Clift
On 13/01/2011, at 2:47 AM, Eric Blake wrote: > On 01/12/2011 07:26 AM, Justin Clift wrote: >> --- >> Temporary rendered version online here: >> http://justinclift.fedorapeople.org/libvirt_website/apps.html >> docs/apps.html.in | 133 >> +++-- >> 1 f

[libvirt] [PATCH] virFindFileInPath: only find executable non-directory

2011-01-12 Thread Eric Blake
Without this patch, at least tests/daemon-conf (which sticks $builddir/src in the PATH) tries to execute the directory $builddir/src/qemu rather than the real /usr/bin/qemu binary. That was fine when qemu_capabilities silently ignored execution failure, but not so good once it is converted to use

Re: [libvirt] [PATCH] memtune: Let virsh know the unlimited value for memory tunables

2011-01-12 Thread Justin Clift
On 07/01/2011, at 6:09 PM, Nikunj A. Dadhania wrote: > From: Nikunj A. Dadhania > > Display unlimited when the memory cgroup settings says so. Unlimited is > represented by INT64_MAX in memory cgroup. > > Signed-off-by: Nikunj A. Dadhania > Reported-by: Justin Clift As an aside, just created

Re: [libvirt] [PATCH] docs: reorder apps page alphabetically, plus add libguestfs entries

2011-01-12 Thread Eric Blake
On 01/12/2011 07:26 AM, Justin Clift wrote: > --- > Temporary rendered version online here: > http://justinclift.fedorapeople.org/libvirt_website/apps.html > docs/apps.html.in | 133 > +++-- > 1 files changed, 78 insertions(+), 55 deletions(-) A

Re: [libvirt] [PATCH] Basic support for VDE networking

2011-01-12 Thread Justin Clift
On 12/01/2011, at 11:29 PM, Daniel P. Berrange wrote: > On Tue, Jan 11, 2011 at 04:12:57PM +0100, Renzo Davoli wrote: >> I have seen several messages asking for VDE networking support. >> There is an item also in your todo web page. >> http://libvirt.org/todo.html >> I have developed a patch to pro

[libvirt] [v3] qemu: Reject SDL graphic if it's not supported by qemu

2011-01-12 Thread Osier Yang
If the emulator doesn't support SDL graphic, we should reject the use of SDL graphic xml with error messages, but not ignore it silently, and pretend things are fine. "-sdl" flag was exposed explicitly by qemu since 0.10.0, more detail: http://www.redhat.com/archives/libvir-list/2011-January/msg00

Re: [libvirt] [v2] qemu: Reject SDL graphic if it's not supported by qemu

2011-01-12 Thread Osier Yang
于 2011年01月12日 20:24, Daniel P. Berrange 写道: On Wed, Jan 12, 2011 at 06:06:04PM +0800, Osier Yang wrote: If the emulator doesn't support SDL graphic, we should reject the use of SDL graphic xml with error messages, but not ignore it silently, and pretend things are fine. "-sdl" flag was exposed

[libvirt] [PATCH] docs: reorder apps page alphabetically, plus add libguestfs entries

2011-01-12 Thread Justin Clift
--- Temporary rendered version online here: http://justinclift.fedorapeople.org/libvirt_website/apps.html docs/apps.html.in | 133 +++-- 1 files changed, 78 insertions(+), 55 deletions(-) diff --git a/docs/apps.html.in b/docs/apps.html.in index 8

Re: [libvirt] [virt-tools-list] Best final spot for the in depth libvirt user docs?

2011-01-12 Thread Daniel P. Berrange
On Thu, Jan 13, 2011 at 12:38:28AM +1100, Justin Clift wrote: > On 13/01/2011, at 12:32 AM, Richard W.M. Jones wrote: > > On Wed, Jan 12, 2011 at 11:36:55PM +1100, Justin Clift wrote: > >> Hi Richard, > >> > >> Tidying things up in regards to some of the documentation, and it's > >> probably time

Re: [libvirt] Best final spot for the in depth libvirt user docs?

2011-01-12 Thread Justin Clift
On 13/01/2011, at 12:32 AM, Richard W.M. Jones wrote: > On Wed, Jan 12, 2011 at 11:36:55PM +1100, Justin Clift wrote: >> Hi Richard, >> >> Tidying things up in regards to some of the documentation, and it's probably >> time >> to move the in depth content from the libvirt.org wiki, to it's final

Re: [libvirt] Best final spot for the in depth libvirt user docs?

2011-01-12 Thread Richard W.M. Jones
On Wed, Jan 12, 2011 at 11:36:55PM +1100, Justin Clift wrote: > Hi Richard, > > Tidying things up in regards to some of the documentation, and it's probably > time > to move the in depth content from the libvirt.org wiki, to it's final resting > spot(s?). > > Do you reckon these would be better

[libvirt] Best final spot for the in depth libvirt user docs?

2011-01-12 Thread Justin Clift
Hi Richard, Tidying things up in regards to some of the documentation, and it's probably time to move the in depth content from the libvirt.org wiki, to it's final resting spot(s?). Do you reckon these would be better moved to the virt-tools.org site, or the libvirt.org site? SSH Setup (conc

Re: [libvirt] [PATCH] Basic support for VDE networking

2011-01-12 Thread Daniel P. Berrange
On Tue, Jan 11, 2011 at 04:12:57PM +0100, Renzo Davoli wrote: > I have seen several messages asking for VDE networking support. > There is an item also in your todo web page. > http://libvirt.org/todo.html > I have developed a patch to provide a basic support for VDE. > It defines and manages the s

Re: [libvirt] [PATCH v2 2/2] doc: improve the documentation of desturi

2011-01-12 Thread Daniel P. Berrange
On Wed, Jan 12, 2011 at 02:12:39PM +0800, Wen Congyang wrote: > > Signed-off-by: Wen Congyang > > --- > tools/virsh.c |2 +- > tools/virsh.pod | 13 + > 2 files changed, 14 insertions(+), 1 deletions(-) > > diff --git a/tools/virsh.c b/tools/virsh.c > index 55e2a68..018e363

Re: [libvirt] [PATCH v2 1/2] report error when specifying wrong desturi

2011-01-12 Thread Daniel P. Berrange
On Wed, Jan 12, 2011 at 02:12:29PM +0800, Wen Congyang wrote: > When we do peer2peer migration, the dest uri is an address of the > target host as seen from the source machine. So we must specify > the ip or hostname of target host in dest uri. If we do not specify > it, report an error to the user

Re: [libvirt] [v2] qemu: Reject SDL graphic if it's not supported by qemu

2011-01-12 Thread Daniel P. Berrange
On Wed, Jan 12, 2011 at 06:06:04PM +0800, Osier Yang wrote: > If the emulator doesn't support SDL graphic, we should reject > the use of SDL graphic xml with error messages, but not ignore > it silently, and pretend things are fine. > > "-sdl" flag was exposed explicitly by qemu since 0.10.0, more

Re: [libvirt] compressing .git/ can save 15%

2011-01-12 Thread Jim Meyering
Daniel Veillard wrote: > On Wed, Jan 12, 2011 at 12:01:12PM +0100, Jim Meyering wrote: >> Daniel Veillard wrote: >> ... >> > xmlsoft:~ -> cat bin/GitMaintainance >> > #!/bin/sh >> > # Garbage collect the libvirt GIT repository >> > git --git-dir /git/libvirt.git gc > $HOME/tmp/GitMaintainance.log 2

Re: [libvirt] compressing .git/ can save 15%

2011-01-12 Thread Daniel Veillard
On Wed, Jan 12, 2011 at 12:01:12PM +0100, Jim Meyering wrote: > Daniel Veillard wrote: > ... > > xmlsoft:~ -> cat bin/GitMaintainance > > #!/bin/sh > > # Garbage collect the libvirt GIT repository > > git --git-dir /git/libvirt.git gc > $HOME/tmp/GitMaintainance.log 2>&1 > > xmlsoft:~ -> crontab -l

Re: [libvirt] compressing .git/ can save 15%

2011-01-12 Thread Jim Meyering
Daniel Veillard wrote: ... > xmlsoft:~ -> cat bin/GitMaintainance > #!/bin/sh > # Garbage collect the libvirt GIT repository > git --git-dir /git/libvirt.git gc > $HOME/tmp/GitMaintainance.log 2>&1 > xmlsoft:~ -> crontab -l | grep GitMaintainance > 4 4 * * Sun /u/veillard/bin/GitMaintainance > xmls

Re: [libvirt] tests/daemon-conf bug

2011-01-12 Thread Daniel P. Berrange
On Tue, Jan 11, 2011 at 05:19:08PM -0700, Eric Blake wrote: > Right now, the daemon-conf test fires up an instance of libvirtd, but > that instance tries to probe the installed location of cpu_map.xml > rather than an in-tree location, which means the test is liable to fail > if run on a just built

Re: [libvirt] compressing .git/ can save 15%

2011-01-12 Thread Daniel Veillard
On Wed, Jan 12, 2011 at 11:14:23AM +0100, Jim Meyering wrote: > Hi DV, Hi Jim ! > I ran this on a fresh clone of libvirt: > > $ du -sh .git; git gc --aggressive; du -sh .git > 54M .git > ... > 45M .git > > I propose to do the same thing on the server, libvirt.org. > It

[libvirt] compressing .git/ can save 15%

2011-01-12 Thread Jim Meyering
Hi DV, I ran this on a fresh clone of libvirt: $ du -sh .git; git gc --aggressive; du -sh .git 54M .git ... 45M .git I propose to do the same thing on the server, libvirt.org. It's not a big deal, but decreased bandwidth wouldn't hurt, and the slightly smaller on-disk rep

[libvirt] [v2] qemu: Reject SDL graphic if it's not supported by qemu

2011-01-12 Thread Osier Yang
If the emulator doesn't support SDL graphic, we should reject the use of SDL graphic xml with error messages, but not ignore it silently, and pretend things are fine. "-sdl" flag was exposed explicitly by qemu since 0.10.0, more detail: http://www.redhat.com/archives/libvir-list/2011-January/msg00

Re: [libvirt] [PATCH] qemu: Reject SDL graphic if it's not supported by qemu

2011-01-12 Thread Osier Yang
于 2011年01月11日 23:33, Eric Blake 写道: On 01/11/2011 04:29 AM, Daniel P. Berrange wrote: On Tue, Jan 11, 2011 at 03:43:07PM +0800, Osier Yang wrote: If the emulator doesn't support SDL graphic, we should reject the use of SDL graphic xml with error messages, but not ignore it silently. * src/qemu

[libvirt] [PATCH v3] memtune: Let virsh know the unlimited value for memory tunables

2011-01-12 Thread Nikunj A. Dadhania
On Tue, 11 Jan 2011 08:19:30 -0700, Eric Blake wrote: > On 01/10/2011 10:18 PM, Nikunj A. Dadhania wrote: [snip] > > @@ -907,7 +907,7 @@ int virCgroupSetMemoryHardLimit(virCgroupPtr group, > > unsigned long kb) > > * > > * Returns: 0 on success > > */ > > -int virCgroupGetMemoryHardLimit(vi