Re: [libvirt] Planning for next release and discussions on project process

2011-01-27 Thread Hu Tao
On Thu, Jan 27, 2011 at 03:09:07PM +0800, Daniel Veillard wrote: So we are around the end of the month, i.e. the time where I usually come out and suggest to enter a freeze within a few days for the next release. However, looking at the git history I note that we have only around 125

Re: [libvirt] [PATCH] [v2] storage: Round up capacity for LVM volume creation

2011-01-27 Thread Daniel Veillard
On Mon, Jan 24, 2011 at 10:22:31PM +0800, Osier Yang wrote: If vol-capacity is odd, the capacity will be rounded down by devision, this patch is to round it up instead of rounding down, to be safer in case of one writes to the volume with the size he used to create. *

Re: [libvirt] [PATCH v3] remote: Add extra parameter pkipath for URI

2011-01-27 Thread Daniel Veillard
On Thu, Jan 27, 2011 at 02:08:36PM +0800, Osier Yang wrote: This new parameter allows user specifies where the client cerficate, client key, CA certificate of x509 is, instead of hardcoding it. If 'pkipath' is not specified, and the user is not root, try to find files in $HOME/.pki/libvirt, as

Re: [libvirt] Planning for next release and discussions on project process

2011-01-27 Thread Daniel Veillard
On Thu, Jan 27, 2011 at 03:48:54PM +0800, Hu Tao wrote: On Thu, Jan 27, 2011 at 03:09:07PM +0800, Daniel Veillard wrote: One possibility could be to use a mix of IRC channel gathering and an Etherpad file (very convenient tool try it), I just created one at

[libvirt] [PATCH] docs: Add docs for new extra parameter pkipath

2011-01-27 Thread Osier Yang
* docs/remote.html.in --- docs/remote.html.in | 30 ++ 1 files changed, 30 insertions(+), 0 deletions(-) diff --git a/docs/remote.html.in b/docs/remote.html.in index b0fdb7c..a68d0fa 100644 --- a/docs/remote.html.in +++ b/docs/remote.html.in @@ -308,6 +308,22 @@

Re: [libvirt] [PATCH] cgroup : remove the ns_cgroup

2011-01-27 Thread Daniel Lezcano
On 01/27/2011 02:45 AM, Andrew Morton wrote: On Thu, 27 Jan 2011 09:08:51 +0800 Li Zefanl...@cn.fujitsu.com wrote: Andrew Morton wrote: On Tue, 25 Jan 2011 10:39:48 +0100 Daniel Lezcanodaniel.lezc...@free.fr wrote: This patch removes the ns_cgroup as suggested in the following thread: I

[libvirt] [PATCH 1/2] Get cpuMhz of virNodeGetInfo() from cpufreq/cpuinfo_max_freq, if exist

2011-01-27 Thread Minoru Usui
virNodeGetInfo() gets from /sys/devices/system/cpu/cpu0/cpufreq/cpuinfo_max_freq, first. Signed-off-by: Minoru Usui u...@mxm.nes.nec.co.jp --- src/nodeinfo.c | 29 ++--- 1 files changed, 22 insertions(+), 7 deletions(-) diff --git a/src/nodeinfo.c b/src/nodeinfo.c

[libvirt] [PATCH 0/2] Fix cpuMhz of virNodeGetInfo() don't returns maximum cpu frequency

2011-01-27 Thread Minoru Usui
cpuMhz of virNodeGetInfo() should return maximum cpu frequency. (See. http://fossplanet.com/f13/%5Blibvirt%5D-%5Brfd%5D-add-modify-some-api-functions-about-host-information-95995/#post323949) virNodeGetInfo() gets it from cpu MHz of /proc/cpuinfo, but this value is scaled by cpu power saving

[libvirt] [PATCH 2/2] Add test for nodeinfo-7 of nodeinfotest for cpu power saving environment.

2011-01-27 Thread Minoru Usui
Add test for nodeinfo-7 of nodeinfotest for cpu power saving environment. Signed-off-by: Minoru Usui u...@mxm.nes.nec.co.jp --- tests/nodeinfodata/linux-nodeinfo-7.cpuinfo| 200 .../nodeinfodata/linux-nodeinfo-7.cpuinfo_max_freq |1 +

[libvirt] [PATCH] docs: fix incorrect XML element mentioned by setmem text

2011-01-27 Thread Justin Clift
--- Pushed this under the trivial rule, as it's definitely wrong. The setmaxmem text can follow when ready. tools/virsh.pod |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 1f15fef..4e8b295 100644 --- a/tools/virsh.pod +++

[libvirt] [PATCH] Prevent overfilling of self-pipe in python event loop

2011-01-27 Thread Daniel P. Berrange
If the event loop takes a very long time todo something, it is possible for the 'self pipe' buffer to become full at which point the entire event loop + remote driver deadlock. Use a boolean flag to ensure we have strict one-in, one-out behaviour on writes/reads of the 'self pipe' ---

Re: [libvirt] [PATCH] Prevent overfilling of self-pipe in python event loop

2011-01-27 Thread Daniel Veillard
On Thu, Jan 27, 2011 at 12:56:24PM +, Daniel P. Berrange wrote: If the event loop takes a very long time todo something, it is possible for the 'self pipe' buffer to become full at which point the entire event loop + remote driver deadlock. Use a boolean flag to ensure we have strict

Re: [libvirt] [PATCH] docs: Add docs for new extra parameter pkipath

2011-01-27 Thread Justin Clift
On 27/01/2011, at 8:01 PM, Osier Yang wrote: * docs/remote.html.in --- docs/remote.html.in | 30 ++ 1 files changed, 30 insertions(+), 0 deletions(-) diff --git a/docs/remote.html.in b/docs/remote.html.in index b0fdb7c..a68d0fa 100644 --- a/docs/remote.html.in

Re: [libvirt] [PATCH] docs: Add docs for new extra parameter pkipath

2011-01-27 Thread Osier Yang
于 2011年01月27日 21:42, Justin Clift 写道: On 27/01/2011, at 8:01 PM, Osier Yang wrote: * docs/remote.html.in --- docs/remote.html.in | 30 ++ 1 files changed, 30 insertions(+), 0 deletions(-) diff --git a/docs/remote.html.in b/docs/remote.html.in index b0fdb7c..a68d0fa

[libvirt] [PATCH v2] docs: Add docs for new extra parameter pkipath

2011-01-27 Thread Osier Yang
* docs/remote.html.in --- docs/remote.html.in | 29 + 1 files changed, 29 insertions(+), 0 deletions(-) diff --git a/docs/remote.html.in b/docs/remote.html.in index b0fdb7c..51afa07 100644 --- a/docs/remote.html.in +++ b/docs/remote.html.in @@ -308,6 +308,21 @@ Note

Re: [libvirt] [PATCH v2] docs: Add docs for new extra parameter pkipath

2011-01-27 Thread Justin Clift
On 28/01/2011, at 1:08 AM, Osier Yang wrote: * docs/remote.html.in --- docs/remote.html.in | 29 + 1 files changed, 29 insertions(+), 0 deletions(-) diff --git a/docs/remote.html.in b/docs/remote.html.in index b0fdb7c..51afa07 100644 --- a/docs/remote.html.in

Re: [libvirt] [PATCH v2] docs: Add docs for new extra parameter pkipath

2011-01-27 Thread Osier Yang
于 2011年01月27日 22:22, Justin Clift 写道: On 28/01/2011, at 1:08 AM, Osier Yang wrote: * docs/remote.html.in --- docs/remote.html.in | 29 + 1 files changed, 29 insertions(+), 0 deletions(-) diff --git a/docs/remote.html.in b/docs/remote.html.in index b0fdb7c..51afa07

[libvirt] [PATCH] docs: expand the man page text for virsh setmaxmem

2011-01-27 Thread Justin Clift
Addresses BZ # 622534: https://bugzilla.redhat.com/show_bug.cgi?id=622534 --- tools/virsh.pod | 17 ++--- 1 files changed, 14 insertions(+), 3 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 4e8b295..0d37512 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@

Re: [libvirt] [PATCHv2] event: fix two event-handling bugs

2011-01-27 Thread Daniel P. Berrange
On Fri, Jan 21, 2011 at 01:06:58PM -0700, Eric Blake wrote: The first bug has been present since before the time that commit f8a519 (Dec 2008) tried to make the dispatch loop re-entrant. Dereferencing eventLoop.handles outside the lock risks crashing, since any other thread could have

Re: [libvirt] [PATCH] docs: expand the man page text for virsh setmaxmem

2011-01-27 Thread Matthias Bolte
2011/1/27 Justin Clift jcl...@redhat.com: Addresses BZ # 622534:  https://bugzilla.redhat.com/show_bug.cgi?id=622534 ---  tools/virsh.pod |   17 ++---  1 files changed, 14 insertions(+), 3 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 4e8b295..0d37512

Re: [libvirt] [PATCH] docs: expand the man page text for virsh setmaxmem

2011-01-27 Thread Justin Clift
On 28/01/2011, at 3:10 AM, Matthias Bolte wrote: snip I didn't post the patch yet, as it isn't finished yet. When my patch gets accepted your patch needs some small tweaks :) Heh, no worries. Can I can this as an ACK (for libvirt 0.8.7 thus far) though? :) Happy to tweak it again

Re: [libvirt] [PATCH] docs: expand the man page text for virsh setmaxmem

2011-01-27 Thread Eric Blake
On 01/27/2011 09:10 AM, Matthias Bolte wrote: 2011/1/27 Justin Clift jcl...@redhat.com: +Some hypervisors require a larger granularity than kilobytes, rounding down +or rejecting requests that are not an even multiple of the desired amount. +vSphere/ESX is one of these, requiring the parameter

Re: [libvirt] [PATCHv2] event: fix two event-handling bugs

2011-01-27 Thread Eric Blake
On 01/27/2011 09:09 AM, Daniel P. Berrange wrote: The second is a regression introduced in commit e6b68d7 (Nov 2010). ACK Now pushed. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital

Re: [libvirt] [PATCH] docs: expand the man page text for virsh setmaxmem

2011-01-27 Thread Justin Clift
On 28/01/2011, at 3:19 AM, Eric Blake wrote: Do we need three examples, or would two be sufficient? For example, vSphere/ESX has a 4MB granularity, so 263168 (257MB) would be rejected while 266240 (260MB) is valid. Yeah, that'd work too. I'll just that example then push it. -- libvir-list

Re: [libvirt] [PATCH] docs: expand the man page text for virsh setmaxmem

2011-01-27 Thread Eric Blake
On 01/27/2011 09:20 AM, Justin Clift wrote: On 28/01/2011, at 3:19 AM, Eric Blake wrote: Do we need three examples, or would two be sufficient? For example, vSphere/ESX has a 4MB granularity, so 263168 (257MB) would be rejected while 266240 (260MB) is valid. Yeah, that'd work too. I'll

Re: [libvirt] [PATCH 1/1] Do not use virtio-serial port 0 for generic ports

2011-01-27 Thread Eric Blake
On 01/26/2011 09:05 PM, Dave Allan wrote: diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d5445a4..08c21e5 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -5328,7 +5328,7 @@ static virDomainDefPtr virDomainDefParseXML(virCapsPtr caps, if

Re: [libvirt] [PATCH] docs: expand the man page text for virsh setmaxmem

2011-01-27 Thread Justin Clift
On 28/01/2011, at 3:29 AM, Eric Blake wrote: On 01/27/2011 09:20 AM, Justin Clift wrote: On 28/01/2011, at 3:19 AM, Eric Blake wrote: Do we need three examples, or would two be sufficient? For example, vSphere/ESX has a 4MB granularity, so 263168 (257MB) would be rejected while 266240

[libvirt] [PATCH] Imprint all logs with version + package build information

2011-01-27 Thread Daniel P. Berrange
The logging functions are enhanced so that immediately prior to the first log message being printed to any output channel, the libvirt package version will be printed. eg $ LIBVIRT_DEBUG=1 virsh 18:13:28.013: 17536: info : libvirt version: 0.8.7 18:13:28.013: 17536: debug : virInitialize:361

[libvirt] [PATCH] tests: Fix virtio channel tests

2011-01-27 Thread Jiri Denemark
--- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -5328,7 +5328,7 @@ static virDomainDefPtr virDomainDefParseXML(virCapsPtr caps, if (chr-info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_SERIAL chr-info.addr.vioserial.port == 0) { -

[libvirt] beginner's project

2011-01-27 Thread Eric Blake
This idea sprang from an IRC conversation, but I don't have time to do it myself at the moment. If you're looking for a great way to help development, it would be nice to teach tests/testutils.c:virtTestLoadFile how to read a file with backslash-newline pairs and flatten those into a single

[libvirt] [PATCH] Remove double close of qemu monitor

2011-01-27 Thread Daniel P. Berrange
When qemuMonitorSetCapabilities() fails, there is no need to call qemuMonitorClose(), because the caller will already see the error code and tear down the entire VM. The extra call to qemuMonitorClose resulted in a double-free due to it removing a ref count prematurely. * src/qemu/qemu_driver.c:

[libvirt] [PATCH] Remove bogus log warning lines when launching QEMU

2011-01-27 Thread Daniel P. Berrange
The refactoring of QEMU command startup was comitted with a couple of VIR_WARN lines left in from debugging. * src/qemu/qemu_driver.c: Remove log warning lines --- src/qemu/qemu_driver.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c

[libvirt] [PATCH] Remove bogus log warning lines when launching QEMU

2011-01-27 Thread Daniel P. Berrange
The refactoring of QEMU command startup was comitted with a couple of VIR_WARN lines left in from debugging. * src/qemu/qemu_driver.c: Remove log warning lines --- src/qemu/qemu_driver.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c

Re: [libvirt] [PATCH] Remove bogus log warning lines when launching QEMU

2011-01-27 Thread Eric Blake
On 01/27/2011 11:40 AM, Daniel P. Berrange wrote: The refactoring of QEMU command startup was comitted with s/comitted/committed/ a couple of VIR_WARN lines left in from debugging. * src/qemu/qemu_driver.c: Remove log warning lines --- src/qemu/qemu_driver.c |2 -- 1 files changed,

Re: [libvirt] [PATCH] Remove double close of qemu monitor

2011-01-27 Thread Eric Blake
On 01/27/2011 11:29 AM, Daniel P. Berrange wrote: When qemuMonitorSetCapabilities() fails, there is no need to call qemuMonitorClose(), because the caller will already see the error code and tear down the entire VM. The extra call to qemuMonitorClose resulted in a double-free due to it

Re: [libvirt] [PATCH] tests: Fix virtio channel tests

2011-01-27 Thread Eric Blake
On 01/27/2011 11:29 AM, Jiri Denemark wrote: --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -5328,7 +5328,7 @@ static virDomainDefPtr virDomainDefParseXML(virCapsPtr caps, if (chr-info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_SERIAL

[libvirt] Domain callback, the new way

2011-01-27 Thread arnaud.champion
?Hi, I'm working on c# bindings, on domain callback. I have successfully binded the old way to manage callbacks via the old virConnectDomainEventRegister function. Now I'm trying to work with the new API contract with virConnectDomainEventRegisterAny... I'm looking for a sample (in C for

Re: [libvirt] [PATCH] Imprint all logs with version + package build information

2011-01-27 Thread Eric Blake
[adding bug-gnulib] On 01/27/2011 11:21 AM, Daniel P. Berrange wrote: The logging functions are enhanced so that immediately prior to the first log message being printed to any output channel, the libvirt package version will be printed. eg $ LIBVIRT_DEBUG=1 virsh 18:13:28.013: 17536:

Re: [libvirt] [PATCH] tests: Fix virtio channel tests

2011-01-27 Thread Jiri Denemark
Phooey - this broke 'make check' for qemuxml2argvtest qemuxml2xmltest. The attached fix fixes that... ACK. Pushed, thanks. Jirka -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Domain callback, the new way

2011-01-27 Thread arnaud.champion
?Oups, sorry, I have just seen the domain-event sample in source code that show to use it. Thanks Arnaud From: arnaud.champ...@devatom.fr Sent: Thursday, January 27, 2011 9:04 PM To: libvir-list@redhat.com Subject: [libvirt] Domain callback, the new way Hi, I'm working on c# bindings, on

Re: [libvirt] [PATCH 1/2] avoid vm to be deleted if qemuConnectMonitor failed

2011-01-27 Thread Eric Blake
On 01/26/2011 08:17 AM, Daniel P. Berrange wrote: On Tue, Jan 25, 2011 at 02:43:43PM +0800, Wen Congyang wrote: The reason of libvirtd cores dump is that: We add vm-refs when we alloc the memory, and decrease it in the function qemuHandleMonitorEOF() in other thread. We add vm-refs in the

Re: [libvirt] [PATCH] avoid shutting down the vm twice

2011-01-27 Thread Eric Blake
On 01/26/2011 08:18 PM, Wen Congyang wrote: Steps to reproduce this bug: 1. use gdb to debug libvirtd, and set breakpoint in the function qemuConnectMonitor() 2. start a vm, and the libvirtd will be stopped in qemuConnectMonitor() 3. kill -STOP $(cat /var/run/libvirt/qemu/domain.pid) 4.

Re: [libvirt] [PATCH v2] qemu: Warning prompt if invalid dump image format specified

2011-01-27 Thread Eric Blake
On 01/26/2011 04:06 AM, Osier Yang wrote: +++ b/src/qemu/qemu_driver.c @@ -4806,16 +4806,15 @@ getCompressionType(struct qemud_driver *driver) if (driver-dumpImageFormat) { compress = qemudSaveCompressionTypeFromString(driver-dumpImageFormat); if (compress 0) { -

Re: [libvirt] chardev aliases [was: [RFC PATCHv2 5/5] WIP: smartcard: turn on qemu support]

2011-01-27 Thread Eric Blake
On 01/26/2011 05:29 AM, Daniel P. Berrange wrote: On Tue, Jan 25, 2011 at 03:04:57PM -0700, Eric Blake wrote: On 01/14/2011 06:46 AM, Daniel P. Berrange wrote: The 'id' setting for the chardev should really have a prefix on it, because we won't want it to be the same as the 'id' setting used

[libvirt] syntax-check vs. close [was: [PATCH 1/3] Cancel migration if user presses Ctrl-C when migration is in progress]

2011-01-27 Thread Eric Blake
On 01/25/2011 12:05 AM, Wen Congyang wrote: +cleanup: +if (dom) +virDomainFree(dom); My bad for thinking this was a violation of the useless-if-before-free rule; virDomainFree is _not_ free-like: it returns an int, and issues an error if domain is NULL. +if (p[0] != -1) {

Re: [libvirt] Rudimentary (basic) s390x architecture functions for libvirt

2011-01-27 Thread Patrick Siegl
Thanks for the good advice regarding the 'qemu monitor' and starting virtual machines with 'cont' on this monitor. Thank telnet, virtual machines can start with param '-S' on s390x. :-) In the 'qemu_command.c' I had commented out so much because you build a virtual machine with the PCI-Bus. But

Re: [libvirt] [PATCH] esx: Don't try to change max-memory of an active domain

2011-01-27 Thread Eric Blake
On 01/27/2011 02:35 PM, Matthias Bolte wrote: Report an VIR_ERR_OPERATION_INVALID error in that case instead of letting the SOAP call fail with an VIR_ERR_INTERNAL_ERROR error. --- src/esx/esx_driver.c | 21 ++--- 1 files changed, 18 insertions(+), 3 deletions(-) ACK. --

Re: [libvirt] [PATCH 0/3] Add some new features into migration

2011-01-27 Thread Eric Blake
On 01/26/2011 05:30 AM, Daniel P. Berrange wrote: This patch set adds three new features into migration: 1. Cancel migration if user presses Ctrl-C when migration is in progress 2. show migration's progress 3. auto-suspend the guest OS at timeout, where the migration will complete offline

[libvirt] Raising events for testing

2011-01-27 Thread arnaud.champion
?Hi, I have binded the new API for domain events and callbacks in C#. It seems to work (LifeCycle events works for sure, I have tested them). Now I want to test other event types and I don't know how to raise them for test (RTC change, WatchDog, Graphics and so on...). Anyone can point me on

Re: [libvirt] [PATCH 3/3] qemu: Add conf option to auto setup VNC unix sockets

2011-01-27 Thread Eric Blake
On 01/21/2011 02:23 PM, Cole Robinson wrote: Here's the diff: diff --git a/daemon/test_libvirtd.aug b/daemon/test_libvirtd.aug index 5f8b644..31fa643 100644 --- a/daemon/test_libvirtd.aug +++ b/daemon/test_libvirtd.aug @@ -271,6 +271,9 @@ log_filters=\a\ # Auditing: audit_level = 2 +

Re: [libvirt] [PATCH v2] docs: Add docs for new extra parameter pkipath

2011-01-27 Thread Daniel Veillard
On Thu, Jan 27, 2011 at 10:27:09PM +0800, Osier Yang wrote: 于 2011年01月27日 22:22, Justin Clift 写道: [..] +tr +td +codepkipath/code +/td +td tls/td +td + Specifies x509 certificates path for the client. if any of the + CA certificate, client certificate, and client key is missing, + the

Re: [libvirt] [PATCH] Report error more accurate if failes on attaching device.

2011-01-27 Thread Eric Blake
s/error more accurate if failes on attaching/more accurate error on failure to attach/ On 01/27/2011 12:21 AM, Hu Tao wrote: When attaching device from a xml file and the device is mis-configured, virsh gives mis-leading message out of memory. This patch fixes this. And if you got an actual

Re: [libvirt] [PATCH] Report error more accurate if failes on attaching device.

2011-01-27 Thread Eric Blake
On 01/27/2011 08:14 PM, Eric Blake wrote: s/error more accurate if failes on attaching/more accurate error on failure to attach/ On 01/27/2011 12:21 AM, Hu Tao wrote: When attaching device from a xml file and the device is mis-configured, virsh gives mis-leading message out of memory. This

[libvirt] [PATCH] qemu: fix error messages

2011-01-27 Thread Eric Blake
Regression in commit caa805ea let a lot of bad messages slip in. * cfg.mk (msg_gen_function): Fix function name. * src/qemu/qemu_cgroup.c (qemuRemoveCgroup): Fix fallout from 'make syntax-check'. * src/qemu/qemu_driver.c (qemudDomainGetInfo) (qemuDomainWaitForMigrationComplete,

Re: [libvirt] [PATCH v2] docs: Add docs for new extra parameter pkipath

2011-01-27 Thread Eric Blake
On 01/27/2011 07:22 AM, Justin Clift wrote: +td + Specifies x509 certificates path for the client. if any of the + CA certificate, client certificate, and client key is missing, + the connection will fail with a fatal error. Not sure if this is an emailer problem or something,

Re: [libvirt] [PATCH] Report error more accurate if failes on attaching device.

2011-01-27 Thread Hu Tao
On Thu, Jan 27, 2011 at 08:26:10PM -0700, Eric Blake wrote: On 01/27/2011 08:14 PM, Eric Blake wrote: s/error more accurate if failes on attaching/more accurate error on failure to attach/ On 01/27/2011 12:21 AM, Hu Tao wrote: When attaching device from a xml file and the device is

Re: [libvirt] [PATCH v2] docs: Add docs for new extra parameter pkipath

2011-01-27 Thread Osier Yang
于 2011年01月28日 11:48, Eric Blake 写道: On 01/27/2011 07:22 AM, Justin Clift wrote: +td + Specifies x509 certificates path for the client. if any of the + CA certificate, client certificate, and client key is missing, + the connection will fail with a fatal error. Not sure if this is an

Re: [libvirt] [PATCH 3/4 v2] qemu: Implement blkio tunable XML configuration and parsing.

2011-01-27 Thread Nikunj A. Dadhania
On Thu, 27 Jan 2011 13:19:25 +0800, Gui Jianfeng guijianf...@cn.fujitsu.com wrote: Implement blkio tunable XML configuration and parsing. Signed-off-by: Gui Jianfeng guijianf...@cn.fujitsu.com --- src/conf/domain_conf.c | 15 ++- src/conf/domain_conf.h |4

Re: [libvirt] [PATCH 4/4] LXC: LXC Blkio weight configuration support.

2011-01-27 Thread Nikunj A. Dadhania
On Thu, 27 Jan 2011 13:19:48 +0800, Gui Jianfeng guijianf...@cn.fujitsu.com wrote: LXC Blkio weight configuration support. Signed-off-by: Gui Jianfeng guijianf...@cn.fujitsu.com --- src/lxc/lxc_controller.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git

Re: [libvirt] [PATCH v2] docs: Add docs for new extra parameter pkipath

2011-01-27 Thread Justin Clift
On 28/01/2011, at 1:41 PM, Daniel Veillard wrote: snip Honnestly one or 2 spaces in HTML does not matter, the HTML renderer will just make it equivalent to one space (with space being characters 0x20, CR, LF, and tabs), so except for purely core review, that doesn't change much on the user

Re: [libvirt] [PATCH] esx: Don't try to change max-memory of an active domain

2011-01-27 Thread Justin Clift
On 28/01/2011, at 8:56 AM, Eric Blake wrote: On 01/27/2011 02:35 PM, Matthias Bolte wrote: Report an VIR_ERR_OPERATION_INVALID error in that case instead of letting the SOAP call fail with an VIR_ERR_INTERNAL_ERROR error. --- src/esx/esx_driver.c | 21 ++--- 1 files changed,

[libvirt] [RFC/PATCH REPOST] Adding persistent entry for cpu tunable

2011-01-27 Thread Nikunj A. Dadhania
From: Nikunj A. Dadhania nik...@linux.vnet.ibm.com Make cpu share persistent and add support for parsing them. docs/formatdomain.html.in: Document cputune element src/conf/domain_conf.c,src/conf/domain_conf.h: Add cputune element parsing src/lxc/lxc_controller.c: Use the parsed cputune shares

Re: [libvirt] [RFC/PATCH REPOST] Adding persistent entry for cpu tunable

2011-01-27 Thread Osier Yang
于 2011年01月28日 13:23, Nikunj A. Dadhania 写道: From: Nikunj A. Dadhanianik...@linux.vnet.ibm.com Make cpu share persistent and add support for parsing them. docs/formatdomain.html.in: Document cputune element src/conf/domain_conf.c,src/conf/domain_conf.h: Add cputune element parsing