[libvirt] [PATCH v2] xen: Prevent updating device when attaching a device

2011-02-09 Thread Osier Yang
When attaching a device that already exists, xend driver updates the device with device_configure, it causes problems (e.g. for disk device, 'device_configure' only can be used to update device like CDROM), on the other hand, we provide additional API (virDomainUpdateDevice) to update device, this

Re: [libvirt] [PATCH] docs: Clarify usage of vram and heads

2011-02-09 Thread Matthias Bolte
2011/2/9 Osier Yang jy...@redhat.com: Though attributes vram and heads of video element are generic, they are only useful for vbox driver currently. That's not true, the vram attribute is supported by the esx and vmware driver too. Matthias -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH v2] xen: Prevent updating device when attaching a device

2011-02-09 Thread Osier Yang
于 2011年02月09日 16:51, Osier Yang 写道: When attaching a device that already exists, xend driver updates the device with device_configure, it causes problems (e.g. for disk device, 'device_configure' only can be used to update device like CDROM), on the other hand, we provide additional API

Re: [libvirt] [PATCH] docs: Clarify usage of vram and heads

2011-02-09 Thread Osier Yang
于 2011年02月09日 17:37, Matthias Bolte 写道: 2011/2/9 Osier Yangjy...@redhat.com: Though attributes vram and heads of video element are generic, they are only useful for vbox driver currently. That's not true, the vram attribute is supported by the esx and vmware driver too. so only these 3

Re: [libvirt] [PATCH] docs: Clarify usage of vram and heads

2011-02-09 Thread Osier Yang
于 2011年02月09日 17:37, Matthias Bolte 写道: 2011/2/9 Osier Yangjy...@redhat.com: Though attributes vram and heads of video element are generic, they are only useful for vbox driver currently. That's not true, the vram attribute is supported by the esx and vmware driver too. ah, yeah, recall I

[libvirt] [PATCH 2/2] Give each virtual network bridge its own fixed MAC address

2011-02-09 Thread Laine Stump
This fixes https://bugzilla.redhat.com/show_bug.cgi?id=609463 The problem was that, since a bridge always acquires the MAC address of the connected interface with the numerically lowest MAC, as guests are started and stopped, it was possible for the MAC address to change over time, and this

[libvirt] [PATCH 0/2] Give each virtual network bridge its own fixed MAC address

2011-02-09 Thread Laine Stump
This fixes https://bugzilla.redhat.com/show_bug.cgi?id=609463 As usual for me, this series has a problem searching for a more elegant solution. See PATCH 2/2 for details. Is it too late to put this in 0.8.8? (assuming a solution to that problem, of course). -- libvir-list mailing list

[libvirt] [PATCH 1/2] Allow brAddTap to create a tap device that is down

2011-02-09 Thread Laine Stump
An upcoming patch has a use for a tap device to be created that doesn't need to be actually put into the up state, and keeping it down keeps the output of ifconfig from being unnecessarily cluttered (ifconfig won't show down interfaces unless you add -a). bridge.[ch]: add up as an arg to

Re: [libvirt] [PATCH libvirt-site] Add libvirt-php information page

2011-02-09 Thread Michal Novotny
On 02/09/2011 02:48 AM, Daniel Veillard wrote: On Tue, Feb 08, 2011 at 01:33:44PM +0100, Michal Novotny wrote: Hi, this is the patch to add libvirt-php information page with some basic information on libvirt-php project compilation, contribution and other useful information. Michal

Re: [libvirt] [PATCH RFC] Don't use CLONE_NEWUSER for now

2011-02-09 Thread Daniel P. Berrange
On Tue, Feb 08, 2011 at 08:58:24PM -0600, Serge E. Hallyn wrote: Until now, user namespaces have not done much, but (for that reason) have been innocuous to glob in with other CLONE_ flags. Upcoming userns development, however, will make tasks cloned with CLONE_NEWUSER far more restricted.

Re: [libvirt] [PATCH] docs: Clarify usage of vram and heads

2011-02-09 Thread Daniel P. Berrange
On Wed, Feb 09, 2011 at 05:39:46PM +0800, Osier Yang wrote: 于 2011年02月09日 17:37, Matthias Bolte 写道: 2011/2/9 Osier Yangjy...@redhat.com: Though attributes vram and heads of video element are generic, they are only useful for vbox driver currently. That's not true, the vram attribute is

[libvirt] Strange nodedev-dumpxml ??

2011-02-09 Thread arnaud.champion
?Hi, I have maybe a strange thing on a nodedev-dumpxml virsh result : virsh # nodedev-dumpxml block_sr0 device nameblock_sr0/name parentscsi_0_0_1_0/parent capability type='storage' block/dev/sr0/block busscsi/bus drive_typecdrom/drive_type modelDVD RW DRU-190S/model

Re: [libvirt] [PATCH] Reserve PCI addresses 3 and 4 on qemu-system-ppc

2011-02-09 Thread Niels de Vos
On Mon, Feb 7, 2011 at 5:12 PM, Eric Blake ebl...@redhat.com wrote: On 02/07/2011 05:13 AM, Daniel P. Berrange wrote: Oh fun, it is actually worse than this. On PPC slot 1 is occupied by the VGA adapter, while slot 2 is the IDE controller, so we'll need to make some more complex changes here.

[libvirt] [libvirt-php 1/2] Introduce set_error() function and fix error handling/formatting

2011-02-09 Thread Michal Novotny
Hi, this is the patch to switch error reporting facility to set_error() function which is having the original code. This is useful to set error from every place we need instead of setting it just by libvirt error handler. This was mainly done to bail with error in the case you call libvirt

[libvirt] [libvirt-php 0/2] Introduce set_error() function and fix compilation warnings

2011-02-09 Thread Michal Novotny
Hi, this is the patch to introduce set_error() function to be able to set error from everywhere we want (and not just using the libvirt error handler), e.g. when the API function is not available in the libvirt version the user is using. Also, the formatting and error handling has been fixed.

Re: [libvirt] Strange nodedev-dumpxml ??

2011-02-09 Thread Daniel P. Berrange
On Wed, Feb 09, 2011 at 01:39:33PM +0100, arnaud.champ...@devatom.fr wrote: ?Hi, I have maybe a strange thing on a nodedev-dumpxml virsh result : virsh # nodedev-dumpxml block_sr0 device nameblock_sr0/name parentscsi_0_0_1_0/parent capability type='storage'

[libvirt] [libvirt-php 2/2] Fix compilation warnings

2011-02-09 Thread Michal Novotny
Hi, this is the patch to fix the compilation warnings like: libvirt.c: In function ‘zif_libvirt_node_get_info’: libvirt.c:613:2: warning: passing argument 4 of ‘add_assoc_string_ex’ makes pointer from integer without a cast /usr/include/php/Zend/zend_API.h:360:45: note: expected ‘char *’ but

Re: [libvirt] [PATCH 1/2] Allow brAddTap to create a tap device that is down

2011-02-09 Thread Daniel P. Berrange
On Wed, Feb 09, 2011 at 04:53:31AM -0500, Laine Stump wrote: An upcoming patch has a use for a tap device to be created that doesn't need to be actually put into the up state, and keeping it down keeps the output of ifconfig from being unnecessarily cluttered (ifconfig won't show down

Re: [libvirt] [PATCH 2/2] Give each virtual network bridge its own fixed MAC address

2011-02-09 Thread Daniel P. Berrange
On Wed, Feb 09, 2011 at 04:53:32AM -0500, Laine Stump wrote: This fixes https://bugzilla.redhat.com/show_bug.cgi?id=609463 The problem was that, since a bridge always acquires the MAC address of the connected interface with the numerically lowest MAC, as guests are started and stopped, it

[libvirt] [libvirt-snmp][PATCH] Created .gitignore to ignore generated/compiled files.

2011-02-09 Thread Michal Privoznik
I've forgotten to add .gitignore to let git ignore some garbage. --- .gitignore | 27 +++ src/.gitignore | 10 ++ 2 files changed, 37 insertions(+), 0 deletions(-) create mode 100644 .gitignore create mode 100644 src/.gitignore diff --git a/.gitignore

Re: [libvirt] [libvirt-php 2/2] Fix compilation warnings

2011-02-09 Thread Daniel Veillard
On Wed, Feb 09, 2011 at 02:11:40PM +0100, Michal Novotny wrote: Hi, this is the patch to fix the compilation warnings like: libvirt.c: In function ‘zif_libvirt_node_get_info’: libvirt.c:613:2: warning: passing argument 4 of ‘add_assoc_string_ex’ makes pointer from integer without a cast

Re: [libvirt] [PATCH v2] xen: Prevent updating device when attaching a device

2011-02-09 Thread Daniel P. Berrange
On Wed, Feb 09, 2011 at 04:51:27PM +0800, Osier Yang wrote: When attaching a device that already exists, xend driver updates the device with device_configure, it causes problems (e.g. for disk device, 'device_configure' only can be used to update device like CDROM), on the other hand, we

Re: [libvirt] [libvirt-php 2/2] Fix compilation warnings

2011-02-09 Thread Michal Novotny
On 02/09/2011 02:57 PM, Daniel Veillard wrote: On Wed, Feb 09, 2011 at 02:11:40PM +0100, Michal Novotny wrote: Hi, this is the patch to fix the compilation warnings like: libvirt.c: In function ‘zif_libvirt_node_get_info’: libvirt.c:613:2: warning: passing argument 4 of ‘add_assoc_string_ex’

Re: [libvirt] [PATCH v2] storage: Allow to delete device mapper disk partition

2011-02-09 Thread Eric Blake
On 02/08/2011 08:02 PM, Osier Yang wrote: 于 2011年02月09日 01:12, Eric Blake 写道: On 02/08/2011 03:30 AM, Osier Yang wrote: +bool +virIsDevMapperDevice(const char *devname) +{ +struct stat buf; + +if (devname +!stat(devname,buf) One other thing - the check for devname being

Re: [libvirt] [PATCH RFC] Don't use CLONE_NEWUSER for now

2011-02-09 Thread Eric Blake
On 02/09/2011 04:02 AM, Daniel P. Berrange wrote: This patch assumes that noone really needs the user namespaces to be enabled. If that is wrong, then we can try a more baroque patch where we create a file owned by a test userid with 700 perms and, if we can't access it after setuid'ing to

Re: [libvirt] [PATCH] Reserve PCI addresses 3 and 4 on qemu-system-ppc

2011-02-09 Thread Eric Blake
On 02/09/2011 05:55 AM, Niels de Vos wrote: I'm wondering whether we should just have a separate method for each combo rather than trying to make one method do everything. Definitely sounds like the sort of thing where we need an arch-specific callback function that can report the correct

[libvirt] [libvirt-snmp][PATCH] New environment variable managing connection URI.

2011-02-09 Thread Michal Privoznik
Add environment variable LIBVIRT_MIB_CONNECT_URI to control URI which snmp agent is connecting to. It is now possible to connect to all hypervisors (including test:///) instead of hardcoded qemu:///system, which is used now by default when variable is not set. --- src/libvirtSnmp.c |5 -

Re: [libvirt] [libvirt-snmp][PATCH] Created .gitignore to ignore generated/compiled files.

2011-02-09 Thread Eric Blake
On 02/09/2011 06:48 AM, Michal Privoznik wrote: I've forgotten to add .gitignore to let git ignore some garbage. --- .gitignore | 27 +++ src/.gitignore | 10 ++ .gitignore can be hierarchical. I prefer to have a single ignore file at the top level,

[libvirt] [RFC PATCH 0/6] Switch over qemu command line capabilities to virBitmap

2011-02-09 Thread Jiri Denemark
There are two main reasons behind this patchset: - we are getting very close to 64 flags which is the maximum we can use with unsigned long long - by using LL constants in enum we already violates C99 constraint that enum values have to fit into int This is a very conflict-prone patchset so

[libvirt] [RFC PATCH 1/6] util: Add API for converting virBitmap into printable string

2011-02-09 Thread Jiri Denemark
--- src/libvirt_private.syms |1 + src/util/bitmap.c| 32 +++- src/util/bitmap.h|3 +++ 3 files changed, 35 insertions(+), 1 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index b9e3efe..335d12f 100644 ---

[libvirt] [RFC PATCH 6/6] tests: Use virBitmap for qemu command line caps

2011-02-09 Thread Jiri Denemark
This needs to be squashed into the previous patch but is provided separately for easier review. --- src/qemu/qemu_capabilities.c | 14 + src/qemu/qemu_capabilities.h |2 + tests/qemuhelptest.c | 727 +- tests/qemuxml2argvtest.c | 468

Re: [libvirt] [RFC PATCH 2/6] qemu: Rename QEMUD_CMD_FLAG_* to QEMU_CAPS_*

2011-02-09 Thread Eric Blake
On 02/09/2011 09:01 AM, Jiri Denemark wrote: The new names comply more with the fact that they are all members of enum qemuCapsFlags. --- src/qemu/qemu_capabilities.c | 128 src/qemu/qemu_capabilities.h | 120 src/qemu/qemu_command.c | 246

Re: [libvirt] [RFC PATCH 1/6] util: Add API for converting virBitmap into printable string

2011-02-09 Thread Eric Blake
On 02/09/2011 09:01 AM, Jiri Denemark wrote: --- src/libvirt_private.syms |1 + src/util/bitmap.c| 32 +++- src/util/bitmap.h|3 +++ 3 files changed, 35 insertions(+), 1 deletions(-) +char *virBitmapString(virBitmapPtr bitmap) +{ +

[libvirt] [PATCH] Adjust some log levels in udev driver

2011-02-09 Thread Daniel P. Berrange
Most of te VIR_INFO calls in the udev driver are only relevant to developers so can switch to VIR_DEBUG. Failure to initialize libpciaccess though is a fatal error * src/node_device/node_device_udev.c: Adjust log levels --- src/node_device/node_device_udev.c | 44

Re: [libvirt] [PATCH] Adjust some log levels in udev driver

2011-02-09 Thread Dave Allan
On Wed, Feb 09, 2011 at 04:42:31PM +, Daniel P. Berrange wrote: Most of te VIR_INFO calls in the udev driver are only relevant to developers so can switch to VIR_DEBUG. Failure to initialize libpciaccess though is a fatal error * src/node_device/node_device_udev.c: Adjust log levels ---

Re: [libvirt] [PATCH] Adjust some log levels in udev driver

2011-02-09 Thread Eric Blake
On 02/09/2011 09:42 AM, Daniel P. Berrange wrote: Most of te VIR_INFO calls in the udev driver are only relevant s/te/the/ to developers so can switch to VIR_DEBUG. Failure to initialize libpciaccess though is a fatal error * src/node_device/node_device_udev.c: Adjust log levels ---

[libvirt] [PATCH 0/6] Introduce a new migration protocol to QEMU driver

2011-02-09 Thread Daniel P. Berrange
The current migration protocol has several flaws - No initial hook on the source host to do work before the dst VM is launched - No ability to restart src VM if dst fails to recv all migration data, but src successfully sent it all This introduces a new 5 step migration process to

[libvirt] [PATCH 4/6] Remote driver implementation of new migration API

2011-02-09 Thread Daniel P. Berrange
* src/remote/remote_protocol.x: Define wire protocol for migration protocol v3 * daemon/remote.c: Server side dispatch * src/remote/remote_driver.c: Client side serialization * src/remote/remote_protocol.c, src/remote/remote_protocol.h, daemon/remote_dispatch_args.h,

[libvirt] [PATCH 5/6] Introduce migration cookies to QEMU driver

2011-02-09 Thread Daniel P. Berrange
The migration protocol has support for a 'cookie' parameter which is an opaque array of bytes as far as libvirt is concerned. Drivers may use this for passing around arbitrary extra data they might need during migration. The QEMU driver needs todo a few things: - Pass hostname/uuid to allow

[libvirt] [PATCH 6/6] Implement migration v3 protocol in QEMU driver

2011-02-09 Thread Daniel P. Berrange
Implement the v3 migration protocol, which has two extra steps, 'begin' on the source host and 'confirm' on the source host. All other methods also gain both input and output cookies to allow bi-directional data passing at all stages * src/qemu/qemu_driver.c: Wire up migrate v3 APIs *

Re: [libvirt] [RFC PATCH 3/6] qemu: Use helper functions for handling cmd line capabilities

2011-02-09 Thread Eric Blake
On 02/09/2011 09:02 AM, Jiri Denemark wrote: --- No comment in the commit message about the name of the new helper methods? src/qemu/qemu_capabilities.c | 152 ++-- src/qemu/qemu_capabilities.h |9 ++ src/qemu/qemu_command.c | 260

Re: [libvirt] [RFC PATCH 4/6] qemu: Rename qemud\?CmdFlags to qemuCaps

2011-02-09 Thread Eric Blake
On 02/09/2011 09:02 AM, Jiri Denemark wrote: The new name comply more with the fact that it contains a set of qemuCapsFlags. --- src/qemu/qemu_capabilities.c | 10 +- src/qemu/qemu_capabilities.h |8 +- src/qemu/qemu_command.c | 368 +-

[libvirt] [PATCHv2 2/2] Add txmode attribute to interface XML for virtio backend

2011-02-09 Thread Laine Stump
This is in response to: https://bugzilla.redhat.com/show_bug.cgi?id=629662 Explanation qemu's virtio-net-pci driver allows setting the algorithm used for tx packets to either bh or timer. This is done by adding ,tx=bh or ,tx=timer to the -device virtio-net-pci commandline option. 'bh'

Re: [libvirt] [virt-tools-list] difference between blkid of a system and uuid of virtual machine by virt-manager

2011-02-09 Thread Cole Robinson
On 02/08/2011 02:06 PM, Tapas Mishra wrote: I want to know what is the difference between the output blkid command shows and the uuid which is set by virt-manager while creating a guest. Suppose in case of a re installation sort of situation I want to do a fresh install and restore things

Re: [libvirt] [RFC PATCH 5/6] qemu: Switch over command line capabilities to virBitmap

2011-02-09 Thread Eric Blake
On 02/09/2011 09:02 AM, Jiri Denemark wrote: This is done for two reasons: - we are getting very close to 64 flags which is the maximum we can use with unsigned long long - by using LL constants in enum we already violates C99 constraint that enum values have to fit into int Does gcc

Re: [libvirt] [RFC PATCH 6/6] tests: Use virBitmap for qemu command line caps

2011-02-09 Thread Eric Blake
On 02/09/2011 09:02 AM, Jiri Denemark wrote: This needs to be squashed into the previous patch but is provided separately for easier review. --- src/qemu/qemu_capabilities.c | 14 + src/qemu/qemu_capabilities.h |2 + tests/qemuhelptest.c | 727

[libvirt] [PATCH libvirt site] Change PHP binding link to new one hosted on libvirt.org

2011-02-09 Thread Michal Novotny
Signed-off-by: Michal Novotny minov...@redhat.com --- docs/bindings.html.in |8 docs/sitemap.html.in |4 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/docs/bindings.html.in b/docs/bindings.html.in index 87d894d..2d936a0 100644 --- a/docs/bindings.html.in

Re: [libvirt] [PATCH] maint: whitespace cleanup

2011-02-09 Thread Eric Blake
On 02/04/2011 11:25 AM, Eric Blake wrote: * cfg.mk (sc_TAB_in_indentation): Check more files. * .dir-locals.el (html-mode): Let emacs help out. * docs/internals/command.html.in: Fix offenders. * docs/formatdomain.html.in: Likewise. * docs/internals.html.in: Likewise. Reported by Jiri

Re: [libvirt] [PATCH libvirt site] Change PHP binding link to new one hosted on libvirt.org

2011-02-09 Thread Eric Blake
On 02/09/2011 10:52 AM, Michal Novotny wrote: Signed-off-by: Michal Novotny minov...@redhat.com --- docs/bindings.html.in |8 docs/sitemap.html.in |4 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/docs/bindings.html.in b/docs/bindings.html.in index

Re: [libvirt] [PATCHv2 2/2] Add txmode attribute to interface XML for virtio backend

2011-02-09 Thread Eric Blake
On 02/09/2011 10:14 AM, Laine Stump wrote: The resulting difference, according to the qemu developer who added the option is: bh makes tx more asynchronous and reduces latency, but potentially causes more processor bandwidth contention since the cpu doing the tx isn't

Re: [libvirt] [PATCH] build: distribute 'make syntax-check' tweaks

2011-02-09 Thread Eric Blake
On 02/01/2011 03:36 PM, Eric Blake wrote: * Makefile.am (EXTRA_DIST): Distribute cfg.mk. --- I noticed that the 0.8.7 tarball lacks cfg.mk, so running 'make syntax-check' on that tarball is bound to have problems (without that file, you don't exempt tests in gnulib's maint.mk that libvirt

Re: [libvirt] [PATCH libvirt site] Change PHP binding link to new one hosted on libvirt.org

2011-02-09 Thread Michal Novotny
On 02/09/2011 07:32 PM, Eric Blake wrote: On 02/09/2011 10:52 AM, Michal Novotny wrote: Signed-off-by: Michal Novotnyminov...@redhat.com --- docs/bindings.html.in |8 docs/sitemap.html.in |4 2 files changed, 4 insertions(+), 8 deletions(-) diff --git

Re: [libvirt] consistency of virsh help output

2011-02-09 Thread Eric Blake
On 02/06/2011 02:29 AM, Zdenek Styblik wrote: I didn't say we should take one way or another; neither I've said I'm going to. I merely wanted to point out at differences, which I think, create a bit of confusion. As suggested in my hasty reply, perhaps we should have a vote or poll. It

[libvirt] [PATCH libvirt-site v2] Add information about libvirt-php new location [was Change PHP binding link to new one hosted on libvirt.org]

2011-02-09 Thread Michal Novotny
Signed-off-by: Michal Novotny minov...@redhat.com --- docs/bindings.html.in |8 +++--- docs/php.html.in | 57 ++-- 2 files changed, 7 insertions(+), 58 deletions(-) diff --git a/docs/bindings.html.in b/docs/bindings.html.in index

Re: [libvirt] [PATCH libvirt site] Change PHP binding link to new one hosted on libvirt.org

2011-02-09 Thread Michal Novotny
On 02/09/2011 07:37 PM, Eric Blake wrote: On 02/09/2011 11:34 AM, Michal Novotny wrote: -li -a href=php.htmlPHP/a -spanoverview of the PHP API bindings/span -/li But this removes the reference without also removing docs/php.html.in; would it be better to keep the reference, and make sure that

Re: [libvirt] [PATCH] build: distribute 'make syntax-check' tweaks

2011-02-09 Thread Laine Stump
On 02/01/2011 05:36 PM, Eric Blake wrote: * Makefile.am (EXTRA_DIST): Distribute cfg.mk. --- I noticed that the 0.8.7 tarball lacks cfg.mk, so running 'make syntax-check' on that tarball is bound to have problems (without that file, you don't exempt tests in gnulib's maint.mk that libvirt is

Re: [libvirt] [PATCH] maint: whitespace cleanup

2011-02-09 Thread Laine Stump
On 02/04/2011 01:25 PM, Eric Blake wrote: * cfg.mk (sc_TAB_in_indentation): Check more files. * .dir-locals.el (html-mode): Let emacs help out. * docs/internals/command.html.in: Fix offenders. * docs/formatdomain.html.in: Likewise. * docs/internals.html.in: Likewise. Reported by Jiri Denemark.

[libvirt] [PATCH libvirt-site v2] Add information about libvirt-php new location [was Change PHP binding link to new one hosted on libvirt.org]

2011-02-09 Thread Michal Novotny
Signed-off-by: Michal Novotny minov...@redhat.com --- docs/bindings.html.in |8 +++--- docs/php.html.in | 57 ++-- 2 files changed, 7 insertions(+), 58 deletions(-) diff --git a/docs/bindings.html.in b/docs/bindings.html.in index

Re: [libvirt] [PATCH libvirt-site v2] Add information about libvirt-php new location [was Change PHP binding link to new one hosted on libvirt.org]

2011-02-09 Thread Eric Blake
On 02/09/2011 11:44 AM, Michal Novotny wrote: Signed-off-by: Michal Novotny minov...@redhat.com That created a rather long commit subject for 'git am', so I pruned it. p The project is now maintained by Michal Novotny and it's heavily based on Radek's

Re: [libvirt] [PATCH] maint: whitespace cleanup

2011-02-09 Thread Eric Blake
On 02/09/2011 11:52 AM, Laine Stump wrote: On 02/04/2011 01:25 PM, Eric Blake wrote: * cfg.mk (sc_TAB_in_indentation): Check more files. * .dir-locals.el (html-mode): Let emacs help out. * docs/internals/command.html.in: Fix offenders. * docs/formatdomain.html.in: Likewise. *

Re: [libvirt] [PATCH] build: distribute 'make syntax-check' tweaks

2011-02-09 Thread Eric Blake
On 02/09/2011 11:49 AM, Laine Stump wrote: On 02/01/2011 05:36 PM, Eric Blake wrote: * Makefile.am (EXTRA_DIST): Distribute cfg.mk. --- I noticed that the 0.8.7 tarball lacks cfg.mk, so running 'make syntax-check' on that tarball is bound to have problems (without that file, you don't

Re: [libvirt] [PATCH 1/6] Split all QEMU process mangement code into separate file

2011-02-09 Thread Eric Blake
On 02/09/2011 09:58 AM, Daniel P. Berrange wrote: Move the qemudStartVMDaemon and qemudShutdownVMDaemon methods into a separate file, renaming them to qemuProcessStart, qemuProcessStop. All helper methods called by these are also moved renamed to match * src/Makefile.am: Add

Re: [libvirt] [PATCH 2/6] Move all the QEMU migration code to a new file

2011-02-09 Thread Eric Blake
On 02/09/2011 09:58 AM, Daniel P. Berrange wrote: The introduction of the v3 migration protocol, along with support for migration cookies, will significantly expand the size of the migration code. Move it all to a separate file to make it more manageable The functions are not moved 100%.

Re: [libvirt] [PATCH 3/6] Introduce yet another migration version in API.

2011-02-09 Thread Eric Blake
On 02/09/2011 09:58 AM, Daniel P. Berrange wrote: This patch attempts to introduce a version 3 that uses the improved 5 step sequence * Src: Begin - Generate XML to pass to dst - Generate optional cookie to pass to dst * Dst: Prepare - Get ready to

Re: [libvirt] [PATCH 1/2] Get cpuMhz of virNodeGetInfo() from cpufreq/cpuinfo_max_freq, if exist

2011-02-09 Thread Minoru Usui
Hi, Eric On Tue, 1 Feb 2011 10:26:36 +0900 Minoru Usui u...@mxm.nes.nec.co.jp wrote: Hi, Eric On Mon, 31 Jan 2011 15:46:39 -0700 Eric Blake ebl...@redhat.com wrote: On 01/27/2011 02:51 AM, Minoru Usui wrote: virNodeGetInfo() gets from

[libvirt] [PATCH 0/2] set QEMUD_CMD_FLAG_PCI_MULTIBUS for x86_64 and i686 architectures

2011-02-09 Thread Wen Congyang
When we attach a interface to a guest machine, we receive the following error messages: [root@wency ~]# virsh attach-interface RHEL6RC network default error: Failed to attach interface error: internal error unable to execute QEMU command 'device_add': Bus 'pci' not found This bug was caused by

[libvirt] [PATCH 1/2] QEMUD_CMD_FLAG_PCI_MULTIBUS should be set in the function qemuCapsExtractVersionInfo()

2011-02-09 Thread Wen Congyang
The flag QEMUD_CMD_FLAG_PCI_MULTIBUS is used in the function qemuBuildDeviceAddressStr(). All callers get qemuCmdFlags by the function qemuCapsExtractVersionInfo() except that testCompareXMLToArgvFiles() in qemuxml2argvtest.c. So we should set QEMUD_CMD_FLAG_PCI_MULTIBUS in the function

[libvirt] [PATCH 2/2] tests: set QEMUD_CMD_FLAG_PCI_MULTIBUS in testCompareXMLToArgvFiles()

2011-02-09 Thread Wen Congyang
set QEMUD_CMD_FLAG_PCI_MULTIBUS before calling qemuBuildCommandLine() as the flags is not set by qemuCapsExtractVersionInfo(). Signed-off-by: Wen Congyang we...@cn.fujitsu.com --- tests/qemuxml2argvtest.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git

Re: [libvirt] [RFC PATCH 0/6] Switch over qemu command line capabilities to virBitmap

2011-02-09 Thread Daniel Veillard
On Wed, Feb 09, 2011 at 05:01:57PM +0100, Jiri Denemark wrote: There are two main reasons behind this patchset: - we are getting very close to 64 flags which is the maximum we can use with unsigned long long - by using LL constants in enum we already violates C99 constraint that enum

Re: [libvirt] [libvirt-snmp][PATCH] New environment variable managing connection URI.

2011-02-09 Thread Daniel Veillard
On Wed, Feb 09, 2011 at 04:43:25PM +0100, Michal Privoznik wrote: Add environment variable LIBVIRT_MIB_CONNECT_URI to control URI which snmp agent is connecting to. It is now possible to connect to all hypervisors (including test:///) instead of hardcoded qemu:///system, which is used now by

[libvirt] Entering freeze for libvirt-0.8.8

2011-02-09 Thread Daniel Veillard
We're entering the week freeze for 0.8.8, so let's delay new feature until the end of next week and let's focuse on bug fixes. I have put an initial release candidate at: ftp://libvirt.org/libvirt/libvirt-0.8.8-rc1.tar.gz it seems to compile and work fine for me. there is however a small

Re: [libvirt] [PATCH v2] xen: Prevent updating device when attaching a device

2011-02-09 Thread Daniel Veillard
On Wed, Feb 09, 2011 at 02:01:25PM +, Daniel P. Berrange wrote: On Wed, Feb 09, 2011 at 04:51:27PM +0800, Osier Yang wrote: When attaching a device that already exists, xend driver updates the device with device_configure, it causes problems (e.g. for disk device, 'device_configure'

Re: [libvirt] Entering freeze for libvirt-0.8.8

2011-02-09 Thread Osier Yang
Works fine (simple checking with domain cycle operations)on my F14, also no problem of compiling, (make, make check, make rpm, make dist, etc). Regards Osier 于 2011年02月10日 11:43, Daniel Veillard 写道: We're entering the week freeze for 0.8.8, so let's delay new feature until the end of next

Re: [libvirt] consistency of virsh help output

2011-02-09 Thread Zdenek Styblik
On 02/09/2011 07:26 PM, Eric Blake wrote: [...] attach-diskdomain source target [driver] When understood, it's ok. And the majority of virsh commands have this format; except 19; I would stick with it. I also like the shorter form. Fine :o) I don't mind either of those.