[libvirt] [RFC] Add persistent XML for cpu tunables

2011-03-29 Thread Osier Yang
Example of cputune XML: cputune shares2048/shares vcpupin vcpu='0' cpuset='0-4,^1'/ vcpupin vcpu='1' cpuset='1,3'/ vcpupin vcpu='2' cpuset='0,2'/ /cputune shares is to define the the proportional weighted cpu share for the domain. vcpupin is to define the cpu affinities of

[libvirt] [PATCH 3/8] cputune: Add data structures presenting cputune xml

2011-03-29 Thread Osier Yang
Also related new functions' declaration. --- src/conf/domain_conf.h | 26 ++ src/libvirt_private.syms |4 2 files changed, 30 insertions(+), 0 deletions(-) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 1e8223f..10e73cb 100644 ---

[libvirt] [PATCH 2/8] cputune: Add document for cputune xml

2011-03-29 Thread Osier Yang
* docs/formatdomain.html.in --- docs/formatdomain.html.in | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 64b0b74..53055d7 100644 --- a/docs/formatdomain.html.in +++

[libvirt] [PATCH 6/8] cputune: support cputune for lxc driver

2011-03-29 Thread Osier Yang
LXC driver doesn't support vcpu affinity yet, so just need to modify it to support cpu shares. --- src/lxc/lxc_controller.c | 10 ++ src/lxc/lxc_driver.c |2 ++ 2 files changed, 12 insertions(+), 0 deletions(-) diff --git a/src/lxc/lxc_controller.c b/src/lxc/lxc_controller.c

[libvirt] [PATCH 1/8] cputune: Add xml schema for cputune xml

2011-03-29 Thread Osier Yang
Sample of cputune xml: cputune shares2048/shares vcpupin vcpu='0' cpuset='0-4,^3'/ vcpupin vcpu='1' cpuset='1,2'/ /cputune * docs/schemas/domain.rng --- docs/schemas/domain.rng | 32 1 files changed, 32 insertions(+), 0 deletions(-) diff --git

[libvirt] [PATCH 4/8] cputune: implementations of parsing and formating cputune xml

2011-03-29 Thread Osier Yang
implementations of following functions: virDomainVcpupinIsDuplicate virDomainVcpupinFindByVcpu virDomainVcpupinAdd Update virDomainDefParseXML to parse, and virDomainDefFormatXML to build cputune xml, also implementations of new internal helper functions. --- src/conf/domain_conf.c | 280

[libvirt] [PATCH 7/8] cputune: support cputune for xend driver

2011-03-29 Thread Osier Yang
Not sure if it's the correct way to add cputune xml for xend driver, and besides, seems xm driver and xen hypervisor also support vcpu affinity, do we need to add support for them too? --- src/xen/xend_internal.c | 30 ++ 1 files changed, 26 insertions(+), 4

[libvirt] [PATCH 8/8] cputune: new tests for testing cputune xml

2011-03-29 Thread Osier Yang
--- tests/qemuxml2argvdata/qemuxml2argv-cputune.xml | 31 +++ tests/qemuxml2argvtest.c|1 + tests/qemuxml2xmltest.c |1 + 3 files changed, 33 insertions(+), 0 deletions(-) create mode 100644

Re: [libvirt] mingw: virsh event loop failure in current git

2011-03-29 Thread Paolo Bonzini
On 03/29/2011 01:27 AM, Eric Blake wrote: Paolo, any thoughts on the best approach to take? (I know which way I'm leaning, but want some feedback before I give away my bias). Without guessing what your bias is, I also :) prefer to implement {g,s}et_nonblock_flag functions. It would use

[libvirt] [PATCH] do not send monitor command after monitor met error

2011-03-29 Thread Wen Congyang
If the monitor met a error, and we will call qemuProcessHandleMonitorEOF(). But we may try to send monitor command after qemuProcessHandleMonitorEOF() returned. Then libvirtd will be blocked in qemuMonitorSend(). Steps to reproduce this bug: 1. use gdb to attach libvirtd, and set a breakpoint in

Re: [libvirt] [RFC] Add persistent XML for cpu tunables

2011-03-29 Thread Daniel Veillard
On Tue, Mar 29, 2011 at 02:32:18PM +0800, Osier Yang wrote: Example of cputune XML: cputune shares2048/shares vcpupin vcpu='0' cpuset='0-4,^1'/ vcpupin vcpu='1' cpuset='1,3'/ vcpupin vcpu='2' cpuset='0,2'/ /cputune shares is to define the the proportional weighted cpu

[libvirt] [PATCH 5/8] cputune: support cputune for qemu driver

2011-03-29 Thread Osier Yang
When domain startup, setting cpu affinity and cpu shares according to the cputune xml specified in domain xml. Modify qemudDomainPinVcpu to update domain config for vcpupin, and modify qemuSetSchedulerParameters to update domain config for cpu shares. * src/qemu/qemu_cgroup.c *

Re: [libvirt] [PATCH 1/8] cputune: Add xml schema for cputune xml

2011-03-29 Thread Daniel Veillard
On Tue, Mar 29, 2011 at 02:32:19PM +0800, Osier Yang wrote: Sample of cputune xml: cputune shares2048/shares vcpupin vcpu='0' cpuset='0-4,^3'/ vcpupin vcpu='1' cpuset='1,2'/ /cputune * docs/schemas/domain.rng --- docs/schemas/domain.rng | 32

Re: [libvirt] [PATCH 2/8] cputune: Add document for cputune xml

2011-03-29 Thread Daniel Veillard
On Tue, Mar 29, 2011 at 02:32:20PM +0800, Osier Yang wrote: * docs/formatdomain.html.in --- docs/formatdomain.html.in | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 64b0b74..53055d7

Re: [libvirt] [PATCH 3/8] cputune: Add data structures presenting cputune xml

2011-03-29 Thread Daniel Veillard
On Tue, Mar 29, 2011 at 02:32:21PM +0800, Osier Yang wrote: Also related new functions' declaration. --- src/conf/domain_conf.h | 26 ++ src/libvirt_private.syms |4 2 files changed, 30 insertions(+), 0 deletions(-) diff --git a/src/conf/domain_conf.h

Re: [libvirt] [PATCH 3/8] cputune: Add data structures presenting cputune xml

2011-03-29 Thread Osier Yang
于 2011年03月29日 15:35, Daniel Veillard 写道: On Tue, Mar 29, 2011 at 02:32:21PM +0800, Osier Yang wrote: Also related new functions' declaration. --- src/conf/domain_conf.h | 26 ++ src/libvirt_private.syms |4 2 files changed, 30 insertions(+), 0

Re: [libvirt] [PATCH 4/8] cputune: implementations of parsing and formating cputune xml

2011-03-29 Thread Daniel Veillard
On Tue, Mar 29, 2011 at 02:32:22PM +0800, Osier Yang wrote: implementations of following functions: virDomainVcpupinIsDuplicate virDomainVcpupinFindByVcpu virDomainVcpupinAdd Update virDomainDefParseXML to parse, and virDomainDefFormatXML to build cputune xml, also implementations of

Re: [libvirt] [RFC] Add persistent XML for cpu tunables

2011-03-29 Thread Matthias Bolte
2011/3/29 Daniel Veillard veill...@redhat.com: On Tue, Mar 29, 2011 at 02:32:18PM +0800, Osier Yang wrote: Example of cputune XML:   cputune     shares2048/shares     vcpupin vcpu='0' cpuset='0-4,^1'/     vcpupin vcpu='1' cpuset='1,3'/     vcpupin vcpu='2' cpuset='0,2'/   /cputune shares

Re: [libvirt] [PATCH 5/8] cputune: support cputune for qemu driver

2011-03-29 Thread Daniel Veillard
On Tue, Mar 29, 2011 at 02:32:23PM +0800, Osier Yang wrote: When domain startup, setting cpu affinity and cpu shares according to the cputune xml specified in domain xml. Modify qemudDomainPinVcpu to update domain config for vcpupin, and modify qemuSetSchedulerParameters to update domain

Re: [libvirt] [PATCH 1/8] cputune: Add xml schema for cputune xml

2011-03-29 Thread Matthias Bolte
2011/3/29 Daniel Veillard veill...@redhat.com: On Tue, Mar 29, 2011 at 02:32:19PM +0800, Osier Yang wrote: Sample of cputune xml:   cputune     shares2048/shares     vcpupin vcpu='0' cpuset='0-4,^3'/     vcpupin vcpu='1' cpuset='1,2'/   /cputune * docs/schemas/domain.rng ---  

Re: [libvirt] [PATCH 1/8] cputune: Add xml schema for cputune xml

2011-03-29 Thread Osier Yang
于 2011年03月29日 16:10, Matthias Bolte 写道: 2011/3/29 Daniel Veillardveill...@redhat.com: On Tue, Mar 29, 2011 at 02:32:19PM +0800, Osier Yang wrote: Sample of cputune xml: cputune shares2048/shares vcpupin vcpu='0' cpuset='0-4,^3'/ vcpupin vcpu='1' cpuset='1,2'/ /cputune *

Re: [libvirt] [RFC] Add persistent XML for cpu tunables

2011-03-29 Thread Nikunj A. Dadhania
On Tue, 29 Mar 2011 15:31:19 +0800, Daniel Veillard veill...@redhat.com wrote: On Tue, Mar 29, 2011 at 02:32:18PM +0800, Osier Yang wrote: Example of cputune XML: cputune shares2048/shares vcpupin vcpu='0' cpuset='0-4,^1'/ vcpupin vcpu='1' cpuset='1,3'/ vcpupin

Re: [libvirt] libvir-list Digest, Vol 64, Issue 243

2011-03-29 Thread SanitYey o
Hello, I want to know, could libvirt open a console for a specific guest os? like Virt Manager or virt-viewer does. How can I fetch a console or VNC screen by libvirt? Or do I need some other method? how do I use vncdisplay or gtk-vnc to get that? thank you very much ! Best Regards.

[libvirt] [PATCH 1/8 v2] cputune: Add xml schema for cputune xml

2011-03-29 Thread Osier Yang
Sample of cputune xml: cputune shares2048/shares vcpupin vcpu='0' cpuset='0-4,^3'/ vcpupin vcpu='1' cpuset='1,2'/ /cputune * docs/schemas/domain.rng --- docs/schemas/domain.rng | 31 +++ 1 files changed, 31 insertions(+), 0 deletions(-) diff --git

[libvirt] [PATCH 2/8 v2] cputune: Add document for cputune xml

2011-03-29 Thread Osier Yang
--- docs/formatdomain.html.in | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 64b0b74..3375fe9 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -346,6 +346,26 @@

Re: [libvirt] [RFC] Add persistent XML for cpu tunables

2011-03-29 Thread Osier Yang
于 2011年03月29日 16:18, Nikunj A. Dadhania 写道: On Tue, 29 Mar 2011 15:31:19 +0800, Daniel Veillardveill...@redhat.com wrote: On Tue, Mar 29, 2011 at 02:32:18PM +0800, Osier Yang wrote: Example of cputune XML: cputune shares2048/shares vcpupin vcpu='0' cpuset='0-4,^1'/ vcpupin

Re: [libvirt] [PATCH 6/8] cputune: support cputune for lxc driver

2011-03-29 Thread Daniel Veillard
On Tue, Mar 29, 2011 at 02:32:24PM +0800, Osier Yang wrote: LXC driver doesn't support vcpu affinity yet, so just need to modify it to support cpu shares. --- src/lxc/lxc_controller.c | 10 ++ src/lxc/lxc_driver.c |2 ++ 2 files changed, 12 insertions(+), 0 deletions(-)

Re: [libvirt] [PATCH 7/8] cputune: support cputune for xend driver

2011-03-29 Thread Daniel Veillard
On Tue, Mar 29, 2011 at 02:32:25PM +0800, Osier Yang wrote: Not sure if it's the correct way to add cputune xml for xend driver, and besides, seems xm driver and xen hypervisor also support vcpu affinity, do we need to add support for them too? --- src/xen/xend_internal.c | 30

Re: [libvirt] [PATCH 8/8] cputune: new tests for testing cputune xml

2011-03-29 Thread Daniel Veillard
On Tue, Mar 29, 2011 at 02:32:26PM +0800, Osier Yang wrote: --- tests/qemuxml2argvdata/qemuxml2argv-cputune.xml | 31 +++ tests/qemuxml2argvtest.c|1 + tests/qemuxml2xmltest.c |1 + 3 files changed, 33

Re: [libvirt] [PATCH 8/8] cputune: new tests for testing cputune xml

2011-03-29 Thread Osier Yang
于 2011年03月29日 17:04, Daniel Veillard 写道: On Tue, Mar 29, 2011 at 02:32:26PM +0800, Osier Yang wrote: --- tests/qemuxml2argvdata/qemuxml2argv-cputune.xml | 31 +++ tests/qemuxml2argvtest.c|1 + tests/qemuxml2xmltest.c

Re: [libvirt] [PATCH 1/8 v2] cputune: Add xml schema for cputune xml

2011-03-29 Thread Daniel Veillard
On Tue, Mar 29, 2011 at 04:48:30PM +0800, Osier Yang wrote: Sample of cputune xml: cputune shares2048/shares vcpupin vcpu='0' cpuset='0-4,^3'/ vcpupin vcpu='1' cpuset='1,2'/ /cputune * docs/schemas/domain.rng --- docs/schemas/domain.rng | 31

Re: [libvirt] Update on the goal page, patch and discussion

2011-03-29 Thread Daniel Veillard
On Fri, Mar 25, 2011 at 09:41:53AM -0600, Eric Blake wrote: On 03/24/2011 04:40 AM, Daniel Veillard wrote: [...] -modify, monitor, control, migrate and stop the domains, within the limits -of the support of the hypervisor for those operations. Multiple nodes may -be

Re: [libvirt] [PATCH 2/8 v2] cputune: Add document for cputune xml

2011-03-29 Thread Daniel Veillard
On Tue, Mar 29, 2011 at 04:49:50PM +0800, Osier Yang wrote: --- docs/formatdomain.html.in | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 64b0b74..3375fe9 100644 ---

Re: [libvirt] [PATCH] Update event loop example programs to demonstrate best practice

2011-03-29 Thread Daniel P. Berrange
On Wed, Mar 23, 2011 at 09:31:56AM -0600, Eric Blake wrote: On 03/23/2011 09:24 AM, Daniel P. Berrange wrote: The example C event loop code is a nasty hack and not compliant with the require API semantics. Delete this, so that developers don't mistakenly copy it. Instead call the new public

[libvirt] [PATCH 2/2] check whether qemuMonitorJSONHMP() failed

2011-03-29 Thread Wen Congyang
If qemu quited unexpectedly when we call qemuMonitorJSONHMP(), libvirt will crash. Steps to reproduce this bug: 1. use gdb to attach libvirtd, and set a breakpoint in the function qemuMonitorSetCapabilities() 2. start a vm 3. let the libvirtd to run until qemuMonitorJSONSetCapabilities()

Re: [libvirt] [PATCH 2/2] check whether qemuMonitorJSONHMP() failed

2011-03-29 Thread Daniel P. Berrange
On Tue, Mar 29, 2011 at 05:48:48PM +0800, Wen Congyang wrote: If qemu quited unexpectedly when we call qemuMonitorJSONHMP(), libvirt will crash. Steps to reproduce this bug: 1. use gdb to attach libvirtd, and set a breakpoint in the function qemuMonitorSetCapabilities() 2. start a vm 3.

Re: [libvirt] [PATCH] do not send monitor command after monitor met error

2011-03-29 Thread Daniel P. Berrange
On Tue, Mar 29, 2011 at 03:22:40PM +0800, Wen Congyang wrote: If the monitor met a error, and we will call qemuProcessHandleMonitorEOF(). But we may try to send monitor command after qemuProcessHandleMonitorEOF() returned. Then libvirtd will be blocked in qemuMonitorSend(). Steps to

[libvirt] [PATCH] Add missing checks for QEMU domain state in tunables APIs

2011-03-29 Thread Daniel P. Berrange
The methods qemuDomain{Get,Set}{Memory,Blkio,Scheduler}Parameters all forgot to do a check on virDomainIsActive(), resulting in bogus error messages from later parts of their impl * src/qemu/qemu_driver.c: Add missing checks on virDomainIsActive() --- src/qemu/qemu_driver.c | 38

Re: [libvirt] [PATCH 4/8] tests: don't alter state in $HOME

2011-03-29 Thread Paolo Bonzini
On 03/28/2011 06:02 PM, Eric Blake wrote: On 03/27/2011 02:59 AM, Laine Stump wrote: On 03/26/2011 08:12 AM, Eric Blake wrote: Diego reported a bug where virsh tries to initialize a readline history directory during 'make check' run as root, but fails because /root was read-only. It turns out

[libvirt] [BUG] qemu quited unexpectedly will cause libvirtd crashed

2011-03-29 Thread Wen Congyang
When I edit the domain's config file like this: = disk type='file' device='disk' driver name='qemu' type='qcow2'/ source file='/var/lib/libvirt/images/test3.img'/ target dev='sdb' bus='scsi'/ address type='drive' controller='0' bus='0' unit='10'/

Re: [libvirt] [PATCH] Add missing checks for QEMU domain state in tunables APIs

2011-03-29 Thread Daniel Veillard
On Tue, Mar 29, 2011 at 11:03:21AM +0100, Daniel P. Berrange wrote: The methods qemuDomain{Get,Set}{Memory,Blkio,Scheduler}Parameters all forgot to do a check on virDomainIsActive(), resulting in bogus error messages from later parts of their impl * src/qemu/qemu_driver.c: Add missing checks

Re: [libvirt] [PATCH] Add support for DNS TXT records

2011-03-29 Thread Michal Novotny
[snip] It would be great to: 1) add user-class and vendor-class tags inside dhcp that allow filtering according to user/vendor classes Well, I didn't know this is supported by DNSMasq but it seems to be (according to the manpage at least): -U,

Re: [libvirt] [PATCH] Add support for DNS TXT records

2011-03-29 Thread Paolo Bonzini
On 03/29/2011 12:52 PM, Michal Novotny wrote: [snip] It would be great to: 1) adduser-class andvendor-class tags insidedhcp that allow filtering according to user/vendor classes Well, I didn't know this is supported by DNSMasq but it seems to be Yes, I am using it. :) -4,

Re: [libvirt] [PATCH] Add support for DNS TXT records

2011-03-29 Thread Paolo Bonzini
On 03/29/2011 12:52 PM, Michal Novotny wrote: [snip] It would be great to: 1) adduser-class andvendor-class tags insidedhcp that allow filtering according to user/vendor classes Well, I didn't know this is supported by DNSMasq but it seems to be Yes, I am using it. :) -4,

Re: [libvirt] [PATCH] Add support for DNS TXT records

2011-03-29 Thread Michal Novotny
On 03/29/2011 01:16 PM, Paolo Bonzini wrote: On 03/29/2011 12:52 PM, Michal Novotny wrote: [snip] It would be great to: 1) adduser-class andvendor-class tags insidedhcp that allow filtering according to user/vendor classes Well, I didn't know this is supported by DNSMasq but it seems to

Re: [libvirt] Entering 0.9.0 freeze week, RC1 version to test

2011-03-29 Thread Justin Clift
Hey all, virsh in 0.9.0 RC1 doesn't work properly. There's a hang at start up: $ virsh waits forever Control-C breaks out ok, dropping back to bash prompt. The pieces compiled in were: $ virsh -V Virsh command line tool of libvirt 0.9.0 See web site at http://libvirt.org/

Re: [libvirt] Entering 0.9.0 freeze week, RC1 version to test

2011-03-29 Thread Justin Clift
On 29/03/2011, at 10:53 PM, Justin Clift wrote: Hey all, virsh in 0.9.0 RC1 doesn't work properly. There's a hang at Oops, forgot to clarify. ... doesn't work properly on OSX (10.6) that is. + Justin -- libvir-list mailing list libvir-list@redhat.com

[libvirt] FYI, Unable to create cgroup for ...

2011-03-29 Thread Jim Meyering
In case someone else encounters this... Today none of my VMs would start on F15: # virsh create rawhide.xml error: Failed to create domain from rawhide.xml error: Unable to create cgroup for rawhide: No such file or directory Luckily, I noticed that Rich Jones had the same problem a

Re: [libvirt] mingw: virsh event loop failure in current git

2011-03-29 Thread Bastien ROUCARIES
On Tue, Mar 29, 2011 at 8:48 AM, Paolo Bonzini bonz...@gnu.org wrote: On 03/29/2011 01:27 AM, Eric Blake wrote: Paolo, any thoughts on the best approach to take?  (I know which way I'm leaning, but want some feedback before I give away my bias). Without guessing what your bias is, I also :)

[libvirt] [PATCH] maint: ignore new built file

2011-03-29 Thread Eric Blake
* .gitignore: Exclude libvirt_iohelper. --- Pushing under the trivial rule. .gitignore |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index e8c907e..ba4d351 100644 --- a/.gitignore +++ b/.gitignore @@ -52,6 +52,7 @@ /mkinstalldirs /po/

Re: [libvirt] [PATCHv2 0/8] Additional functionality for libxl driver

2011-03-29 Thread Daniel Veillard
On Mon, Mar 28, 2011 at 05:47:48PM +0800, Daniel Veillard wrote: On Mon, Mar 28, 2011 at 10:32:47AM +0200, Markus Groß wrote: This series of patches adds new functionality to the libxl driver. V2: - Incorporated review from Jim Fehlig - Allow domainGetSchedulerType only on active

Re: [libvirt] [PATCH] qemu: fix regression with fd labeling on migration

2011-03-29 Thread Eric Blake
On 03/28/2011 08:33 PM, Daniel Veillard wrote: On Mon, Mar 28, 2011 at 04:33:58PM -0600, Eric Blake wrote: My earlier testing for commit 34fa0de0 was done while starting just-built libvirt from an unconfined_t shell, where the fds happened to work when transferring to qemu. But when installed

Re: [libvirt] [PATCH] qemu: improve error message on failed fd transfer

2011-03-29 Thread Eric Blake
On 03/28/2011 08:29 PM, Daniel Veillard wrote: On Mon, Mar 28, 2011 at 03:19:30PM -0600, Eric Blake wrote: First fallout of fd: migration - it looks like SELinux enforcing _does_ require fd labeling (running uninstalled libvirtd from an unconstrained shell had no problems, but once faked out

Re: [libvirt] [PATCH 2/2] check whether qemuMonitorJSONHMP() failed

2011-03-29 Thread Jiri Denemark
On Tue, Mar 29, 2011 at 17:48:48 +0800, Wen Congyang wrote: diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index eed83f4..647e2bb 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -906,7 +906,14 @@ int qemuMonitorSetCapabilities(qemuMonitorPtr mon)

[libvirt] [PATCH] qemu: Fix media eject with qemu-0.12.*

2011-03-29 Thread Jiri Denemark
In qemu-0.12.* device '...' is locked message was changed to Device ... so libvirt was no longer detecting this as an error. --- bootstrap.conf |1 + src/qemu/qemu_monitor_text.c |2 +- 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/bootstrap.conf

Re: [libvirt] [PATCH 1/8 v2] cputune: Add xml schema for cputune xml

2011-03-29 Thread Osier Yang
于 2011年03月29日 17:09, Daniel Veillard 写道: On Tue, Mar 29, 2011 at 04:48:30PM +0800, Osier Yang wrote: Sample of cputune xml: cputune shares2048/shares vcpupin vcpu='0' cpuset='0-4,^3'/ vcpupin vcpu='1' cpuset='1,2'/ /cputune * docs/schemas/domain.rng ---

[libvirt] 0.9.0 freeze week, RC2 version to test

2011-03-29 Thread Daniel Veillard
On Mon, Mar 28, 2011 at 02:25:38PM +0800, Daniel Veillard wrote: [...] I will regenerate a rc2 as soon as Eric pending patch queue and outgoing fd patches are in as I think they should really make 0.9.0 There may be more infrastrcucture patches from Dan too, I'm unsure and as usual pushing bug

Re: [libvirt] [PATCH] Add support for DNS TXT records

2011-03-29 Thread Paolo Bonzini
On 03/29/2011 01:37 PM, Michal Novotny wrote: On 03/29/2011 01:16 PM, Paolo Bonzini wrote: On 03/29/2011 12:52 PM, Michal Novotny wrote: [snip] It would be great to: 1) adduser-class andvendor-class tags insidedhcp that allow filtering according to user/vendor classes Well, I didn't

Re: [libvirt] [PATCH] Add support for DNS TXT records

2011-03-29 Thread Michal Novotny
[snip] Great. Good to implement this then however I'm not sure about the network-id parameter for DNSMasq. What should network-id tag mean and what should it match? It can be a progressive number. You use it later to limit the scope of --dhcp-boot options. Oh, I see. It could make sense

Re: [libvirt] [PATCH] Add support for DNS TXT records

2011-03-29 Thread Paolo Bonzini
On 03/29/2011 05:08 PM, Michal Novotny wrote: Ok, however vendor-class and user-class should be used together and therefore it could be committed into one commit, right? The next commit could be the dhcp-mac one... right ? No, they can be one patch series, but they should be separate commits.

Re: [libvirt] [Libvirt-announce] 0.9.0 freeze week, RC2 version to test

2011-03-29 Thread Justin Clift
On 30/03/2011, at 1:46 AM, Daniel Veillard wrote: On Mon, Mar 28, 2011 at 02:25:38PM +0800, Daniel Veillard wrote: [...] I will regenerate a rc2 as soon as Eric pending patch queue and outgoing fd patches are in as I think they should really make 0.9.0 There may be more infrastrcucture

Re: [libvirt] [PATCH] Add support for DNS TXT records

2011-03-29 Thread Michal Novotny
On 03/29/2011 05:12 PM, Paolo Bonzini wrote: On 03/29/2011 05:08 PM, Michal Novotny wrote: Ok, however vendor-class and user-class should be used together and therefore it could be committed into one commit, right? The next commit could be the dhcp-mac one... right ? No, they can be one patch

Re: [libvirt] cont command failing via JSON monitor on restore

2011-03-29 Thread Philipp Hahn
Hello, Am Donnerstag 20 Januar 2011 04:05:46 schrieb Jim Fehlig: I think a patch addressing the issue in the JSON monitor, where we can reliably detect the error, is a good start. Would that be okay? Also, recall that I cannot reproduce the issue with qemu 0.13. We can reliably reproduct

Re: [libvirt] [PATCH] Add support for DNS TXT records

2011-03-29 Thread Laine Stump
On 03/29/2011 06:52 AM, Michal Novotny wrote: [snip] So I guess we should disable the spaces in the name since it's being interpreted like \032 characters as can be seen in the dig output - we should either disable such a definition entirely or change spaces (' ') to dashes ('-'). But escaping

Re: [libvirt] [PATCH] Add support for DNS TXT records

2011-03-29 Thread Paweł Krześniak
On Fri, Mar 25, 2011 at 22:02, Laine Stump la...@laine.org wrote: As a matter of fact, I think that not only is this useful, but configuring other capabilities presented by dnsmasq would be good. I think you'll find a kindred spirit in Paweł Krześniak, who was also wanting some other dnsmasq

Re: [libvirt] 0.9.0 freeze week, RC2 version to test

2011-03-29 Thread Daniel Veillard
On Tue, Mar 29, 2011 at 11:17:17PM +0800, Daniel Veillard wrote: On Tue, Mar 29, 2011 at 10:46:59PM +0800, Daniel Veillard wrote: On Mon, Mar 28, 2011 at 02:25:38PM +0800, Daniel Veillard wrote: [...] I will regenerate a rc2 as soon as Eric pending patch queue and outgoing fd patches

[libvirt] [PATCH] qemu: unlock qemu driver before return

2011-03-29 Thread Hu Tao
--- src/qemu/qemu_driver.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 104e92d..6e3edde 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -2068,12 +2068,14 @@ static int

Re: [libvirt] [PATCH] qemu: unlock qemu driver before return

2011-03-29 Thread Wen Congyang
At 03/30/2011 09:49 AM, Hu Tao Write: --- src/qemu/qemu_driver.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 104e92d..6e3edde 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -2068,12

Re: [libvirt] 0.9.0 freeze week, RC2 version to test

2011-03-29 Thread Osier Yang
于 2011年03月29日 22:46, Daniel Veillard 写道: On Mon, Mar 28, 2011 at 02:25:38PM +0800, Daniel Veillard wrote: [...] I will regenerate a rc2 as soon as Eric pending patch queue and outgoing fd patches are in as I think they should really make 0.9.0 There may be more infrastrcucture patches from Dan

Re: [libvirt] [PATCH] qemu: unlock qemu driver before return

2011-03-29 Thread Daniel Veillard
On Wed, Mar 30, 2011 at 09:49:29AM +0800, Hu Tao wrote: --- src/qemu/qemu_driver.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 104e92d..6e3edde 100644 --- a/src/qemu/qemu_driver.c +++

Re: [libvirt] 0.9.0 freeze week, RC2 version to test

2011-03-29 Thread Osier Yang
于 2011年03月30日 10:36, Osier Yang 写道: 于 2011年03月29日 22:46, Daniel Veillard 写道: On Mon, Mar 28, 2011 at 02:25:38PM +0800, Daniel Veillard wrote: [...] I will regenerate a rc2 as soon as Eric pending patch queue and outgoing fd patches are in as I think they should really make 0.9.0 There may be

[libvirt] [PATCH] qemu: Fix improper logic of qemuCgroupSetup

2011-03-29 Thread Osier Yang
It throws errors as long as the cgroup controller is not available, regardless of whether we really want to use it to do setup or not, which is not what we want, fixing it with throwing error when need to use the controller. And change VIR_WARN to qemuReportError for memory controller

Re: [libvirt] [PATCH] qemu: unlock qemu driver before return

2011-03-29 Thread Wen Congyang
When I checked all the place where calling qemuDriverLock(), I found some problem. The details of the problem is here: https://www.redhat.com/archives/libvir-list/2011-March/msg01409.html When I modify the function processWatchdogEvent(), I found that wdEvent-vm may be freed before

[libvirt] [PATCH 2/3] qemu: unlock qemu driver and vm before returning from processWatchdogEvent()

2011-03-29 Thread Wen Congyang
--- src/qemu/qemu_driver.c | 28 +++- 1 files changed, 19 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index f843dc8..d79d61b 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -2403,19 +2403,22 @@ static

[libvirt] [PATCH 3/3] hold an extra reference while handling watchdog event

2011-03-29 Thread Wen Congyang
If the domain is not persistent, and qemu quited unexpectedly before calling processWatchdogEvent(), vm will be freed and the function processWatchdogEvent() will be dangerous. --- src/qemu/qemu_driver.c | 10 ++ src/qemu/qemu_process.c |4 2 files changed, 10 insertions(+),

[libvirt] [PATCH 1/3] qemu: avoid qemu_driver being unlocked twice when virThreadPoolNew() failed

2011-03-29 Thread Wen Congyang
--- src/qemu/qemu_driver.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index dd12dc8..f843dc8 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -628,10 +628,14 @@ qemudStartup(int privileged) {

Re: [libvirt] [PATCH 1/3] qemu: avoid qemu_driver being unlocked twice when virThreadPoolNew() failed

2011-03-29 Thread Hu Tao
On Wed, Mar 30, 2011 at 12:34:47PM +0800, Wen Congyang wrote: --- src/qemu/qemu_driver.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index dd12dc8..f843dc8 100644 --- a/src/qemu/qemu_driver.c +++