[libvirt] [PATCH] time_t is not a long on FreeBSD, need to add casts

2011-05-13 Thread Matthias Bolte
--- src/conf/domain_conf.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d3efec6..875f90e 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -9115,7 +9115,7 @@ virDomainSnapshotDefPtr

Re: [libvirt] [PATCH] Documentation on tests suites and new API test suite

2011-05-13 Thread Daniel Veillard
On Tue, May 10, 2011 at 10:46:11AM -0600, Eric Blake wrote: On 05/10/2011 12:21 AM, Daniel Veillard wrote: I hesitated between creating a new doc section and trying to reuse one existing, but it didn't fit well in any of the existing section, though that could have been added under

[libvirt] [PATCH] virsh: Fix uninitialized variable warning

2011-05-13 Thread Matthias Bolte
Reported on FreeBSD only. --- tools/virsh.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index fbeb7c8..3baa015 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -11131,7 +11131,7 @@ vshCmddefHelp(vshControl *ctl, const char *cmdname)

[libvirt] [PATCH] virsh: time_t is not a long on FreeBSD

2011-05-13 Thread Matthias Bolte
localtime_r expects time_t. --- tools/virsh.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 3baa015..93a504e 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -10406,7 +10406,8 @@ cmdSnapshotList(vshControl *ctl, const vshCmd

Re: [libvirt] libvirt, FreeBSD portability inquiry

2011-05-13 Thread Matthias Bolte
2011/5/12 Jason Helfman jhelf...@e-e.com: Hi, I am interested in porting libvirt to FreeBSD, and am curious if there may be anything that may not be possible at this point in respect to the libvirt source code to be aware of. Here is the log of the build of the software: I know it has been

[libvirt] [PATCH 0/3] Fix some building errors

2011-05-13 Thread Wen Congyang
Wen Congyang (3): build: generate files when building without libvirtd build: probes.d and libvirtd.stp should be part of tarball test: all test_scripts should be part of tarball when building without libvirtd daemon/Makefile.am | 110

[libvirt] [PATCH 1/3] build: generate files when building without libvirtd

2011-05-13 Thread Wen Congyang
Steps to reproduce this problem: 1. # ./autogen.sh --without-libvirtd 2. # make dist ... make[1]: Entering directory `/home/wency/source/libvirt-nodaemon/daemon' make[1]: *** No rule to make target `remote_dispatch_prototypes.h', needed by `distdir'. Stop. make[1]: Leaving directory

[libvirt] [PATCH 3/3] test: all test_scripts should be part of tarball when building without libvirtd

2011-05-13 Thread Wen Congyang
Steps to reproduce this problem: 1. # ./autogen.sh --without-libvirtd 2. # make dist 3. # rpmbuild --nodeps --define _sourcedir `pwd` -ba libvirt.spec ... make check-TESTS make[1]: Entering directory `/home/wency/rpmbuild/BUILD/libvirt-0.9.1/tests' make[1]: *** No rule to make target

Re: [libvirt] [RFC PATCH] support multifunction PCI device

2011-05-13 Thread Paolo Bonzini
On 05/11/2011 09:55 AM, Daniel P. Berrange wrote: Hmm, that's kinda wierd i'm suprised it works, particularly for LSI since I thought guest drivers would need support for multifunction too. For well-behaved {kernel,device,driver}s multifunction should be totally transparent. Example from

Re: [libvirt] [PATCH v4 0/8] Add support for taking screenshots of domain console

2011-05-13 Thread Michal Prívozník
On 05/12/2011 06:48 PM, Daniel P. Berrange wrote: On Thu, May 12, 2011 at 06:29:07PM +0200, Michal Privoznik wrote: ... So, eg with a config like video model type='qxl' vram='9216' heads='2'/ alias id='video0'/ /video video model type='qxl' vram='9216'

Re: [libvirt] [PATCH v4 0/8] Add support for taking screenshots of domain console

2011-05-13 Thread Daniel P. Berrange
On Fri, May 13, 2011 at 10:34:24AM +0200, Michal Prívozník wrote: On 05/12/2011 06:48 PM, Daniel P. Berrange wrote: On Thu, May 12, 2011 at 06:29:07PM +0200, Michal Privoznik wrote: ... So, eg with a config like video model type='qxl' vram='9216' heads='2'/ alias

Re: [libvirt] [PATCH v4 1/8] screenshot: Defining the public API

2011-05-13 Thread Daniel P. Berrange
On Thu, May 12, 2011 at 06:29:08PM +0200, Michal Privoznik wrote: Add public API for taking screenshots of current domain console. * include/libvirt/libvirt.h.in: add virDomainScreenshot * src/libvirt_public.syms: Export new symbol --- include/libvirt/libvirt.h.in |8

Re: [libvirt] [PATCH v4 2/8] screenshot: Defining the internal API

2011-05-13 Thread Daniel P. Berrange
On Thu, May 12, 2011 at 06:29:09PM +0200, Michal Privoznik wrote: * src/driver.h: Stub code for new API * src/esx/esx_driver.c, src/libxl/libxl_driver.c, src/lxc/lxc_driver.c, src/openvz/openvz_driver.c, src/phyp/phyp_driver.c, src/qemu/qemu_driver.c, rc/remote/remote_driver.c,

Re: [libvirt] [PATCH v4 3/8] screenshot: Implementing the public API

2011-05-13 Thread Daniel P. Berrange
On Thu, May 12, 2011 at 06:29:10PM +0200, Michal Privoznik wrote: * src/libvirt.c: new function virDomainScreenshot --- src/libvirt.c | 60 + 1 files changed, 60 insertions(+), 0 deletions(-) diff --git a/src/libvirt.c

Re: [libvirt] [PATCH v4 4/8] screenshot: Implementing the remote protocol

2011-05-13 Thread Daniel P. Berrange
On Thu, May 12, 2011 at 06:29:11PM +0200, Michal Privoznik wrote: * src/remote/remote_protocol.x: Wire protocol definition * daemon/remote.c: Daemon part * src/remote/remote_driver.c: Client part * src/remote_protocol-structs: Add structures --- daemon/remote.c | 57

Re: [libvirt] [PATCH v4 7/8] qemu: Implement the driver methods

2011-05-13 Thread Daniel P. Berrange
On Thu, May 12, 2011 at 06:29:14PM +0200, Michal Privoznik wrote: * src/qemu/qemu_driver.c: new qemuDomainScreenshot() function * src/qemu/qemu_monitor.c, src/qemu/qemu_monitor.h, src/qemu/qemu_monitor_json.c, src/qemu/qemu_monitor_json.h, src/qemu/qemu_monitor_text.c,

Re: [libvirt] [PATCH v4 6/8] virFDStream: Add option for delete file after it's opening

2011-05-13 Thread Daniel P. Berrange
On Thu, May 12, 2011 at 06:29:13PM +0200, Michal Privoznik wrote: This is needed if we want to transfer a temporary file. If the transfer is done with iohelper, we might run into a race condition, where we unlink() file before iohelper is executed. * src/fdstream.c, src/fdstream.h,

Re: [libvirt] [PATCH v4 8/8] vbox: Implement the driver methods

2011-05-13 Thread Daniel P. Berrange
On Thu, May 12, 2011 at 06:29:15PM +0200, Michal Privoznik wrote: * src/vbox/vbox_tmpl.c: New vboxDomainScreenshot() function --- src/vbox/vbox_tmpl.c | 133 ++ 1 files changed, 133 insertions(+), 0 deletions(-) diff --git

Re: [libvirt] [PATCH 2/7] domain_event: Add common domain event queue/flush helpers

2011-05-13 Thread Daniel P. Berrange
On Thu, May 12, 2011 at 01:14:26PM -0400, Cole Robinson wrote: The same code for queueing, flushing, and deregistering events exists in multiple drivers, which will soon use these common functions. v2: Adjust libvirt_private.syms isDispatching bool fixes NONNULL tagging v3:

Re: [libvirt] [PATCH 6/7] libxl: Convert to virDomainEventState

2011-05-13 Thread Daniel P. Berrange
On Thu, May 12, 2011 at 01:14:30PM -0400, Cole Robinson wrote: Signed-off-by: Cole Robinson crobi...@redhat.com --- src/libxl/libxl_conf.h |6 +--- src/libxl/libxl_driver.c | 80 + 2 files changed, 24 insertions(+), 62 deletions(-)

Re: [libvirt] [PATCH 4/7] lxc: Use virDomainEventState helpers

2011-05-13 Thread Daniel P. Berrange
On Thu, May 12, 2011 at 01:14:28PM -0400, Cole Robinson wrote: v3: Adjust for new virDomainEventStateNew argument Signed-off-by: Cole Robinson crobi...@redhat.com --- src/lxc/lxc_conf.h |6 +--- src/lxc/lxc_driver.c | 74 ++--- 2

Re: [libvirt] [PATCH 7/7] remote: Use virDomainEventState helpers

2011-05-13 Thread Daniel P. Berrange
On Thu, May 12, 2011 at 01:14:31PM -0400, Cole Robinson wrote: One functionality change here is that we no longer force enable the event timeout for every queued event, only enable it for the first event after the queue has been flushed. This is how other drivers have already done it, and I

Re: [libvirt] [PATCH 5/7] test: Use virDomainEventState helpers

2011-05-13 Thread Daniel P. Berrange
On Thu, May 12, 2011 at 01:14:29PM -0400, Cole Robinson wrote: v3: Adjust for new virDomainEventStateNew argument Signed-off-by: Cole Robinson crobi...@redhat.com --- src/test/test_driver.c | 105 +++- 1 files changed, 32 insertions(+),

Re: [libvirt] [PATCH] domain: Require init for container guests

2011-05-13 Thread Daniel P. Berrange
On Thu, May 12, 2011 at 05:47:42PM -0400, Cole Robinson wrote: Use capabilities to allow a driver to register a default init if none is specified in the XML. Openvz was already open-coding this to be /sbin/init LXC currently falls over if no init is specified, so an explicit error is an

Re: [libvirt] [PATCH 1/7] domain_event: Add virDomainEventState structure

2011-05-13 Thread Daniel P. Berrange
On Thu, May 12, 2011 at 01:14:25PM -0400, Cole Robinson wrote: This structure will be used to unify lots of duplicated event handling code across the state drivers. v2: Check for state == NULL in StateFree Add NONNULL tagging Use bool for isDispatching Signed-off-by: Cole

Re: [libvirt] inquiry, get native capabilities of the host

2011-05-13 Thread Daniel P. Berrange
On Thu, May 12, 2011 at 03:39:44PM -0700, Dong-In David Kang wrote: Hello, I'm interested in getting native capabilities of host CPU using libvirt. I've looked at .../src/cpu/cpu_map.xml. And it does describe native capabilities of host CPU very well. But, libvirt always returns a

Re: [libvirt] [PATCH 3/7] qemu: Use virDomainEventState helpers

2011-05-13 Thread Daniel P. Berrange
On Thu, May 12, 2011 at 01:14:27PM -0400, Cole Robinson wrote: v2: Drop libvirt_private.syms changes v3: Adjust for new virDomainEventStateNew argument Signed-off-by: Cole Robinson crobi...@redhat.com --- src/qemu/qemu_conf.h |6 +- src/qemu/qemu_domain.c | 29

Re: [libvirt] [PATCH] configure: Fix mpath check on non-Linux systems

2011-05-13 Thread Daniel P. Berrange
On Fri, May 13, 2011 at 07:51:24AM +0200, Matthias Bolte wrote: --- configure.ac | 14 +- 1 files changed, 9 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index a2ce97e..4f5c2d7 100644 --- a/configure.ac +++ b/configure.ac @@ -1667,11 +1667,15 @@

Re: [libvirt] inquiry, get native capabilities of the host

2011-05-13 Thread Jiri Denemark
Hi, On Thu, May 12, 2011 at 15:39:44 -0700, Dong-In David Kang wrote: I'm interested in getting native capabilities of host CPU using libvirt. I've looked at .../src/cpu/cpu_map.xml. And it does describe native capabilities of host CPU very well. But, libvirt always returns a subset of the

Re: [libvirt] [PATCH 1/3] build: generate files when building without libvirtd

2011-05-13 Thread Daniel P. Berrange
On Fri, May 13, 2011 at 04:02:13PM +0800, Wen Congyang wrote: Steps to reproduce this problem: 1. # ./autogen.sh --without-libvirtd 2. # make dist ... make[1]: Entering directory `/home/wency/source/libvirt-nodaemon/daemon' make[1]: *** No rule to make target

Re: [libvirt] [PATCH] command: Fix compilation on FreeBSD

2011-05-13 Thread Daniel P. Berrange
On Fri, May 13, 2011 at 07:53:06AM +0200, Matthias Bolte wrote: kill, SIGTERM and SIGKILL require additional headers. --- src/util/command.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/util/command.c b/src/util/command.c index b488d55..b2a873b 100644 ---

Re: [libvirt] [PATCH] time_t is not a long on FreeBSD, need to add casts

2011-05-13 Thread Daniel P. Berrange
On Fri, May 13, 2011 at 07:53:29AM +0200, Matthias Bolte wrote: --- src/conf/domain_conf.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d3efec6..875f90e 100644 --- a/src/conf/domain_conf.c +++

Re: [libvirt] [PATCH] virsh: time_t is not a long on FreeBSD

2011-05-13 Thread Daniel P. Berrange
On Fri, May 13, 2011 at 08:31:28AM +0200, Matthias Bolte wrote: localtime_r expects time_t. --- tools/virsh.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 3baa015..93a504e 100644 --- a/tools/virsh.c +++

Re: [libvirt] [numatune PATCH v2] Support NUMA tuning

2011-05-13 Thread Daniel P. Berrange
On Thu, May 12, 2011 at 11:01:09PM +0800, Osier Yang wrote: 于 2011年05月12日 22:11, Eric Blake 写道: On 05/12/2011 05:01 AM, Osier Yang wrote: The new XML is like: numatune memory model=interleave nodeset=+0-4,8-12/ numatune Compatibility with numactl syntax is an explicit non-goal.

Re: [libvirt] [PATCH] virsh: Fix uninitialized variable warning

2011-05-13 Thread Daniel P. Berrange
On Fri, May 13, 2011 at 08:29:00AM +0200, Matthias Bolte wrote: Reported on FreeBSD only. --- tools/virsh.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index fbeb7c8..3baa015 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@

Re: [libvirt] [PATCH 2/3] build: probes.d and libvirtd.stp should be part of tarball

2011-05-13 Thread Daniel P. Berrange
On Fri, May 13, 2011 at 04:02:50PM +0800, Wen Congyang wrote: Steps to reproduce this problem: 1. # ./autogen.sh --without-libvirtd 2. # make dist 3. # rpmbuild --nodeps --define _sourcedir `pwd` -ba libvirt.spec ... make[2]: Entering directory

Re: [libvirt] [PATCH 3/3] test: all test_scripts should be part of tarball when building without libvirtd

2011-05-13 Thread Daniel P. Berrange
On Fri, May 13, 2011 at 04:03:20PM +0800, Wen Congyang wrote: Steps to reproduce this problem: 1. # ./autogen.sh --without-libvirtd 2. # make dist 3. # rpmbuild --nodeps --define _sourcedir `pwd` -ba libvirt.spec ... make check-TESTS make[1]: Entering directory

Re: [libvirt] why is network i/o always zero?

2011-05-13 Thread Daniel P. Berrange
On Wed, May 11, 2011 at 09:32:53PM +0800, 黄亮 wrote: hi all I'm using Xen on CentOS.I wanna monitor the network activity of a domain. When I use Domain.InterfaceStats( ... ), which is the C# binding of virDomainInterfaceStats, it returns -1. I wonder if the function is not supported by

Re: [libvirt] [PATCH v2 3/9] virDomainGetState public API implementation

2011-05-13 Thread Daniel P. Berrange
On Tue, May 10, 2011 at 03:39:05PM +0200, Jiri Denemark wrote: --- Notes: Version 2: - rebased - unsigned int flags src/libvirt.c | 51 +++ 1 files changed, 51 insertions(+), 0 deletions(-) diff --git a/src/libvirt.c

Re: [libvirt] [PATCH v2 5/9] virsh: Prefer virDomainGetState over virDomainGetInfo

2011-05-13 Thread Daniel P. Berrange
On Tue, May 10, 2011 at 03:39:07PM +0200, Jiri Denemark wrote: --- Notes: Version 2: - rebased - unsigned int flags - noGetState renamed as useGetInfo tools/virsh.c | 195 +++-- 1 files changed, 162 insertions(+), 33

Re: [libvirt] [PATCH v2 1/9] virDomainGetState public API

2011-05-13 Thread Daniel P. Berrange
On Tue, May 10, 2011 at 03:39:03PM +0200, Jiri Denemark wrote: This API is supposed to replace virDomainGetInfo when the only purpose of calling it is getting current domain status. --- Notes: Version 2: - rebased - unsigned int flags parameter - updated version info in

Re: [libvirt] [PATCH v2 4/9] Wire protocol format and dispatcher for virDomainGetState

2011-05-13 Thread Daniel P. Berrange
On Tue, May 10, 2011 at 03:39:06PM +0200, Jiri Denemark wrote: --- Notes: Version 2: - rebased - unsigned int flags daemon/remote.c | 33 + daemon/remote_generator.pl |3 ++- src/remote/remote_protocol.x | 13

Re: [libvirt] [PATCH v2 2/9] Internal driver API for virDomainGetState

2011-05-13 Thread Daniel P. Berrange
On Tue, May 10, 2011 at 03:39:04PM +0200, Jiri Denemark wrote: --- Notes: Version 2: - rebased - unsigned int flags parameter - avoid changing xenUnifiedDriver internal callback struct src/driver.h |6 ++ src/esx/esx_driver.c |1 +

Re: [libvirt] [PATCH v2 6/9] remote: Implement virDomainGetState

2011-05-13 Thread Daniel P. Berrange
On Tue, May 10, 2011 at 03:39:08PM +0200, Jiri Denemark wrote: --- Notes: Version 2: - rebased - unsigned int flags daemon/remote_generator.pl |3 ++- src/remote/remote_driver.c | 35 ++- 2 files changed, 36 insertions(+), 2 deletions(-)

Re: [libvirt] [PATCH v2 7/9] Implement basic virDomainGetState in all drivers

2011-05-13 Thread Daniel P. Berrange
On Tue, May 10, 2011 at 03:39:09PM +0200, Jiri Denemark wrote: Reason is currently always set to 0 (i.e., *_UNKNOWN). --- Notes: Version 2: - rebased - unsigned int flags - simplified implementation in esx driver per Matthias' suggestion - call internal xen drivers

Re: [libvirt] [PATCH] qemu: allow blkstat/blkinfo calls during migration

2011-05-13 Thread Federico Simoncelli
- Original Message - From: Eric Blake ebl...@redhat.com To: Federico Simoncelli fsimo...@redhat.com Cc: libvir-list@redhat.com Sent: Friday, May 13, 2011 1:38:45 AM Subject: Re: [PATCH] qemu: allow blkstat/blkinfo calls during migration On 05/11/2011 07:26 AM, Federico Simoncelli

[libvirt] [PATCH] qemu: allow blkstat/blkinfo calls during migration

2011-05-13 Thread Federico Simoncelli
Originally most of libvirt domain-specific calls were blocking during a migration. A new mechanism to allow specific calls (blkstat/blkinfo) to be executed in such condition has been implemented. In the long term it'd be desirable to get a more general solution to mark further APIs as migration

[libvirt] [PATCH] virsh: Improve editing

2011-05-13 Thread Michal Privoznik
When users (pool-/net-)edit and they make a mistake, temporary file and thus all changes are gone. Better way is to let them decide if they want to get back to edit and correct what's wrong. However, this is suitable only in interactive mode. --- tools/virsh.c | 42

Re: [libvirt] [PATCH v4 8/8] vbox: Implement the driver methods

2011-05-13 Thread Michal Prívozník
On 05/13/2011 11:21 AM, Daniel P. Berrange wrote: On Thu, May 12, 2011 at 06:29:15PM +0200, Michal Privoznik wrote: * src/vbox/vbox_tmpl.c: New vboxDomainScreenshot() function --- src/vbox/vbox_tmpl.c | 133 ++ 1 files changed, 133

Re: [libvirt] [PATCH 1/3] build: generate files when building without libvirtd

2011-05-13 Thread Eric Blake
On 05/13/2011 03:36 AM, Daniel P. Berrange wrote: On Fri, May 13, 2011 at 04:02:13PM +0800, Wen Congyang wrote: Steps to reproduce this problem: 1. # ./autogen.sh --without-libvirtd 2. # make dist ... make[1]: Entering directory `/home/wency/source/libvirt-nodaemon/daemon' make[1]:

Re: [libvirt] [PATCH] command: Fix compilation on FreeBSD

2011-05-13 Thread Eric Blake
On 05/12/2011 11:53 PM, Matthias Bolte wrote: kill, SIGTERM and SIGKILL require additional headers. --- src/util/command.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/util/command.c b/src/util/command.c index b488d55..b2a873b 100644 ---

Re: [libvirt] [PATCH] time_t is not a long on FreeBSD, need to add casts

2011-05-13 Thread Eric Blake
On 05/12/2011 11:53 PM, Matthias Bolte wrote: --- src/conf/domain_conf.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d3efec6..875f90e 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c

Re: [libvirt] [PATCH] Fix messages using VIR_ERR_XML_ERROR

2011-05-13 Thread Michal Prívozník
On 05/12/2011 11:47 PM, Cole Robinson wrote: This error code has existed since the dawn of time, yet the messages it generates are almost universally busted. Here's a small sampling: src/conf/domain_conf.c:4889 : XML description for missing root element is not well formed or invalid

Re: [libvirt] [PATCH] virsh: Correctly initialize libvirt

2011-05-13 Thread Jiri Denemark
On Tue, May 10, 2011 at 10:53:40 +0100, Daniel P. Berrange wrote: On Mon, May 09, 2011 at 04:04:41PM +0200, Matthias Bolte wrote: 2011/5/9 Jiri Denemark jdene...@redhat.com: virsh didn't call virInitialize(), which (among other things) initializes virLastErr thread local variable. As a

Re: [libvirt] [PATCH] virsh: Improve editing

2011-05-13 Thread Jiri Denemark
On Fri, May 13, 2011 at 12:34:25 +0200, Michal Privoznik wrote: When users (pool-/net-)edit and they make a mistake, temporary file and thus all changes are gone. Better way is to let them decide if they want to get back to edit and correct what's wrong. However, this is suitable only in

Re: [libvirt] inquiry, get native capabilities of the host

2011-05-13 Thread Dong-In David Kang
Hi Jiri, Thank you for the valuable information. That's exactly what I want to get. Let me tell you what I'm doing now. I'm extending OpenStack (cloud computing infrastructure) for high performance computing. Before spawning a cloud instance, I want to check the full capability of the host

[libvirt] Allow hvsupport.html.in to be auto-generated

2011-05-13 Thread Daniel P. Berrange
The hvsupport.html.in file is constantly out of date, because when updating the drivers to add new APIs, people often (always) forget to update the hvsupport.html.in file. To solve this we can instead store version number annotations in the drivers themselves, so it is not easily missed. Then the

[libvirt] [PATCH 1/4] Tweak driver naming for consistency with public API

2011-05-13 Thread Daniel P. Berrange
Fix some driver names: s/virDrvCPUCompare/virDrvCompareCPU/ s/virDrvCPUBaseline/virDrvBaselineCPU/ s/virDrvQemuDomainMonitorCommand/virDrvDomainQemuMonitorCommand/ s/virDrvSecretNumOfSecrets/virDrvNumOfSecrets/ s/virDrvSecretListSecrets/virDrvListSecrets/ And some driver struct field

[libvirt] [PATCH 3/4] Automatically generate the hvsupport.html.in file from source files

2011-05-13 Thread Daniel P. Berrange
The hvsupport.html.in file is forever out of date. By annotating the driver struct tables in each driver with version information, we can auto-generate the hvsupport.html.in file. Annotating the drivers will be mandatory for new patches, ensuring hvsupport.html.in is never out of date again. *

Re: [libvirt] [PATCH] virsh: Improve editing

2011-05-13 Thread Daniel P. Berrange
On Fri, May 13, 2011 at 02:57:08PM +0200, Jiri Denemark wrote: On Fri, May 13, 2011 at 12:34:25 +0200, Michal Privoznik wrote: When users (pool-/net-)edit and they make a mistake, temporary file and thus all changes are gone. Better way is to let them decide if they want to get back to edit

[libvirt] [PATCH] screenshot: Expose the new API in virsh

2011-05-13 Thread Michal Privoznik
* tools/virsh.c: Add screenshot command * tools/virsh.pod: Document new command * src/libvirt.c: Fix off-be-one error --- src/libvirt.c |2 +- tools/virsh.c | 97 +++ tools/virsh.pod |9 + 3 files changed, 107 insertions(+), 1

Re: [libvirt] [PATCH] virsh: Improve editing

2011-05-13 Thread Cole Robinson
On 05/13/2011 08:57 AM, Jiri Denemark wrote: On Fri, May 13, 2011 at 12:34:25 +0200, Michal Privoznik wrote: When users (pool-/net-)edit and they make a mistake, temporary file and thus all changes are gone. Better way is to let them decide if they want to get back to edit and correct what's

Re: [libvirt] [PATCH] xml: Make sure virXpathNodeSet always sets an error

2011-05-13 Thread Cole Robinson
On 05/12/2011 07:03 PM, Eric Blake wrote: On 05/12/2011 03:47 PM, Cole Robinson wrote: And update callers to actually respect the error Signed-off-by: Cole Robinson crobi...@redhat.com --- src/conf/domain_conf.c | 38

Re: [libvirt] [PATCH] domain: Require init for container guests

2011-05-13 Thread Cole Robinson
On 05/13/2011 05:27 AM, Daniel P. Berrange wrote: On Thu, May 12, 2011 at 05:47:42PM -0400, Cole Robinson wrote: Use capabilities to allow a driver to register a default init if none is specified in the XML. Openvz was already open-coding this to be /sbin/init LXC currently falls over if no

Re: [libvirt] [PATCH] xml: Use virXMLParse* helpers everywhere

2011-05-13 Thread Cole Robinson
On 05/12/2011 08:53 PM, Eric Blake wrote: On 05/12/2011 03:47 PM, Cole Robinson wrote: virt-aa-helper isn't even compile tested since I don't have the setup for it. I tested the patch out on Ubuntu, and the virt-aa-helper stuff did indeed have problems. Signed-off-by: Cole Robinson

Re: [libvirt] [PATCH] virsh: Improve editing

2011-05-13 Thread Laine Stump
On 05/13/2011 10:23 AM, Cole Robinson wrote: On 05/13/2011 08:57 AM, Jiri Denemark wrote: On Fri, May 13, 2011 at 12:34:25 +0200, Michal Privoznik wrote: When users (pool-/net-)edit and they make a mistake, temporary file and thus all changes are gone. Better way is to let them decide if they

Re: [libvirt] libvirt, FreeBSD portability inquiry

2011-05-13 Thread Eric Blake
On 05/13/2011 12:38 AM, Matthias Bolte wrote: 2011/5/12 Jason Helfman jhelf...@e-e.com: Hi, I am interested in porting libvirt to FreeBSD, and am curious if there may be anything that may not be possible at this point in respect to the libvirt source code to be aware of. Here is the log of

Re: [libvirt] [PATCH 6/7] libxl: Convert to virDomainEventState

2011-05-13 Thread Eric Blake
On 05/12/2011 11:14 AM, Cole Robinson wrote: Signed-off-by: Cole Robinson crobi...@redhat.com --- src/libxl/libxl_conf.h |6 +--- src/libxl/libxl_driver.c | 80 + 2 files changed, 24 insertions(+), 62 deletions(-) The conversion wasn't

Re: [libvirt] [PATCH 6/7] libxl: Convert to virDomainEventState

2011-05-13 Thread Cole Robinson
On 05/13/2011 01:18 PM, Eric Blake wrote: On 05/12/2011 11:14 AM, Cole Robinson wrote: Signed-off-by: Cole Robinson crobi...@redhat.com --- src/libxl/libxl_conf.h |6 +--- src/libxl/libxl_driver.c | 80 + 2 files changed, 24

Re: [libvirt] [PATCH 02/16] util: Combine __virExec and virExecWithHook

2011-05-13 Thread Cole Robinson
On 05/10/2011 07:07 PM, Eric Blake wrote: On 05/10/2011 02:07 PM, Cole Robinson wrote: All callers were expecting argv logging, so the split is unneeded. Not quite true - virCommandRunAsync already does an independent VIR_DEBUG of argv/envp prior to calling virExecWithHook, so we are

[libvirt] [PATCH 2/9] openvz: Convert virExec usage to virCommand

2011-05-13 Thread Cole Robinson
v2: Use virCommand's autocleanup Signed-off-by: Cole Robinson crobi...@redhat.com --- src/openvz/openvz_conf.c | 37 + src/openvz/openvz_driver.c | 55 +++ 2 files changed, 41 insertions(+), 51 deletions(-) diff --git

[libvirt] [PATCH 0/9 v2] More virCommand conversions and cleanups

2011-05-13 Thread Cole Robinson
The following series converts all users of several older command wrappers (virRunWithHook, virExecDaemonize, and virExec) to use virCommand. The remaining functionality is then moved out of util.c and into command.c v2: Committed some patches Dropped final patch, can be submitted

[libvirt] [PATCH 1/9] storage: iscsi: Convert virExec to virCommand

2011-05-13 Thread Cole Robinson
v2: Use virCommand auto-cleanup Signed-off-by: Cole Robinson crobi...@redhat.com --- src/storage/storage_backend_iscsi.c | 23 +++ 1 files changed, 11 insertions(+), 12 deletions(-) diff --git a/src/storage/storage_backend_iscsi.c b/src/storage/storage_backend_iscsi.c

[libvirt] [PATCH 3/9] qemu: Convert virExec usage to virCommand

2011-05-13 Thread Cole Robinson
v2: Have virCommand cleanup intermediate process for us Signed-off-by: Cole Robinson crobi...@redhat.com --- src/qemu/qemu_driver.c | 35 +++ src/qemu/qemu_process.c |2 +- 2 files changed, 12 insertions(+), 25 deletions(-) diff --git

[libvirt] [PATCH 5/9] storage_backend: Fix error reporting with regex helper

2011-05-13 Thread Cole Robinson
Some clients overwrite the error from the regex helper, or do half-baked error reporting with the exitstatus. Signed-off-by: Cole Robinson crobi...@redhat.com --- src/storage/storage_backend.c | 11 +-- src/storage/storage_backend.h |3 +--

[libvirt] [PATCH 6/9] storage_backend: Convert virRunWithHook usage to virCommand

2011-05-13 Thread Cole Robinson
virRunWithHook is now unused, so we can drop it. Tested w/ raw + qcow2 volume creation and copying. v2: Use opaque data to skip hook second time around Simply command building Signed-off-by: Cole Robinson crobi...@redhat.com --- src/libvirt_private.syms |1 -

[libvirt] [PATCH 8/9] util: Implement virRun as a wrapper around virCommand

2011-05-13 Thread Cole Robinson
v2: Simplify command building Handle command building failure Signed-off-by: Cole Robinson crobi...@redhat.com --- src/util/util.c | 74 -- 1 files changed, 6 insertions(+), 68 deletions(-) diff --git a/src/util/util.c

[libvirt] [PATCH 7/9] util: Remove unused virExec wrapper

2011-05-13 Thread Cole Robinson
Signed-off-by: Cole Robinson crobi...@redhat.com --- src/libvirt_private.syms |1 - src/util/util.c | 35 --- src/util/util.h |8 3 files changed, 0 insertions(+), 44 deletions(-) diff --git a/src/libvirt_private.syms

[libvirt] [PATCH 4/9] storage: Covert regex helpers to virCommand

2011-05-13 Thread Cole Robinson
v2: Simplify command creation Add a missing virCommandFree Use virCommand auto-cleanup for async process Signed-off-by: Cole Robinson crobi...@redhat.com --- src/storage/storage_backend.c | 91 +--- 1 files changed, 21 insertions(+), 70

[libvirt] [PATCH 9/9] Move virRun, virExec*, virFork to util/command

2011-05-13 Thread Cole Robinson
Seems reasonable to have all command wrappers in the same place v2: Dont move SetInherit Signed-off-by: Cole Robinson crobi...@redhat.com --- cfg.mk|2 +- src/libvirt_private.syms |5 +- src/lxc/veth.c|

Re: [libvirt] [PATCH] esx: Move the Event type from the VI generator to manually written code

2011-05-13 Thread Eric Blake
On 05/01/2011 01:57 PM, Matthias Bolte wrote: Accept all types on deserialization in order to accept all Event subtypes. This will be used for the upcoming domain event support. --- src/esx/esx_vi_generator.input | 21 src/esx/esx_vi_generator.py|1 -

Re: [libvirt] [PATCH 1/9] storage: iscsi: Convert virExec to virCommand

2011-05-13 Thread Eric Blake
On 05/13/2011 02:10 PM, Cole Robinson wrote: v2: Use virCommand auto-cleanup Signed-off-by: Cole Robinson crobi...@redhat.com --- src/storage/storage_backend_iscsi.c | 23 +++ 1 files changed, 11 insertions(+), 12 deletions(-) memset(line, 0, LINE_SIZE);

Re: [libvirt] [PATCH] esx: Generate implicit _this macros

2011-05-13 Thread Eric Blake
On 05/01/2011 01:57 PM, Matthias Bolte wrote: --- src/Makefile.am |1 + src/esx/esx_vi_generator.py | 48 -- src/esx/esx_vi_methods.c| 40 +++ 3 files changed, 32 insertions(+), 57 deletions(-)

Re: [libvirt] [PATCH] esx: Remove 1000 lines of generated but unused code

2011-05-13 Thread Eric Blake
On 05/01/2011 01:57 PM, Matthias Bolte wrote: Don't make all object and enum types (de)serializable by default. Detect this from the input file instead. --- src/esx/esx_vi_generator.py | 167 +++--- 1 files changed, 123 insertions(+), 44 deletions(-) Too

Re: [libvirt] [PATCH 2/9] openvz: Convert virExec usage to virCommand

2011-05-13 Thread Eric Blake
On 05/13/2011 02:10 PM, Cole Robinson wrote: v2: Use virCommand's autocleanup Signed-off-by: Cole Robinson crobi...@redhat.com --- src/openvz/openvz_conf.c | 37 + src/openvz/openvz_driver.c | 55 +++ 2 files

Re: [libvirt] [PATCH] esx: Improve list usage detection in the generator

2011-05-13 Thread Eric Blake
On 05/01/2011 01:57 PM, Matthias Bolte wrote: Detect it based on usage as parameter and return type too. --- src/esx/esx_vi_generator.py | 41 +++-- 1 files changed, 31 insertions(+), 10 deletions(-) Again, my python is not strong, but this compiles

Re: [libvirt] [PATCH 3/9] qemu: Convert virExec usage to virCommand

2011-05-13 Thread Eric Blake
On 05/13/2011 02:10 PM, Cole Robinson wrote: v2: Have virCommand cleanup intermediate process for us Signed-off-by: Cole Robinson crobi...@redhat.com --- src/qemu/qemu_driver.c | 35 +++ src/qemu/qemu_process.c |2 +- 2 files changed, 12

Re: [libvirt] [PATCH 4/9] storage: Covert regex helpers to virCommand

2011-05-13 Thread Eric Blake
On 05/13/2011 02:10 PM, Cole Robinson wrote: v2: Simplify command creation Add a missing virCommandFree Use virCommand auto-cleanup for async process Signed-off-by: Cole Robinson crobi...@redhat.com --- ACK. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt

Re: [libvirt] [PATCH] esx: Improve dynamic cast detection in the generator

2011-05-13 Thread Eric Blake
On 05/01/2011 01:57 PM, Matthias Bolte wrote: Detect it based on usage as parameter, return type and member of other object types. --- src/esx/esx_vi_generator.py | 32 ++-- 1 files changed, 18 insertions(+), 14 deletions(-) Very much like the last one. ACK.

Re: [libvirt] [PATCH] esx: Refactor common code in the generator

2011-05-13 Thread Eric Blake
On 05/01/2011 01:57 PM, Matthias Bolte wrote: Move common code from Property and Paramater into new Member class. s/Paramater/Parameter/ Rename the other base class to Type. --- src/esx/esx_vi_generator.py | 95 +-- 1 files changed, 38

Re: [libvirt] [PATCH] esx: Change generated method parameter autobinding

2011-05-13 Thread Eric Blake
On 05/01/2011 01:57 PM, Matthias Bolte wrote: Instead of specifing the type of the managed object directly specify s/specifing/specifying/ the ServiceContent member name. This way the mapping dictionary can be removed. --- src/esx/esx_vi_generator.input | 36

Re: [libvirt] [PATCH 5/9] storage_backend: Fix error reporting with regex helper

2011-05-13 Thread Eric Blake
On 05/13/2011 02:10 PM, Cole Robinson wrote: Some clients overwrite the error from the regex helper, or do half-baked error reporting with the exitstatus. Signed-off-by: Cole Robinson crobi...@redhat.com --- src/storage/storage_backend.c | 11 +--

Re: [libvirt] [PATCH 6/9] storage_backend: Convert virRunWithHook usage to virCommand

2011-05-13 Thread Eric Blake
On 05/13/2011 02:10 PM, Cole Robinson wrote: virRunWithHook is now unused, so we can drop it. Tested w/ raw + qcow2 volume creation and copying. v2: Use opaque data to skip hook second time around Simply command building Signed-off-by: Cole Robinson crobi...@redhat.com ---

Re: [libvirt] [PATCH 7/9] util: Remove unused virExec wrapper

2011-05-13 Thread Eric Blake
On 05/13/2011 02:10 PM, Cole Robinson wrote: Signed-off-by: Cole Robinson crobi...@redhat.com --- src/libvirt_private.syms |1 - src/util/util.c | 35 --- src/util/util.h |8 3 files changed, 0 insertions(+), 44

Re: [libvirt] [PATCH 8/9] util: Implement virRun as a wrapper around virCommand

2011-05-13 Thread Eric Blake
On 05/13/2011 02:10 PM, Cole Robinson wrote: v2: Simplify command building Handle command building failure Signed-off-by: Cole Robinson crobi...@redhat.com --- src/util/util.c | 74 -- 1 files changed, 6 insertions(+), 68

Re: [libvirt] [PATCH 9/9] Move virRun, virExec*, virFork to util/command

2011-05-13 Thread Eric Blake
On 05/13/2011 02:10 PM, Cole Robinson wrote: Seems reasonable to have all command wrappers in the same place v2: Dont move SetInherit Signed-off-by: Cole Robinson crobi...@redhat.com --- cfg.mk|2 +- src/libvirt_private.syms

Re: [libvirt] [PATCH v2 9/9] qemu: Update domain state when reconnecting monitor

2011-05-13 Thread Eric Blake
On 05/10/2011 07:39 AM, Jiri Denemark wrote: A qemu domain can get paused when libvirtd is stopped (e.g., because of I/O error) so we should check its current state when reconnecting to it. --- Notes: Version 2: - new patch Good catch. I see danpb reviewed the rest of the series,

Re: [libvirt] [PATCH] qemu: allow blkstat/blkinfo calls during migration

2011-05-13 Thread Eric Blake
On 05/13/2011 04:11 AM, Federico Simoncelli wrote: Originally most of libvirt domain-specific calls were blocking during a migration. A new mechanism to allow specific calls (blkstat/blkinfo) to be executed in such condition has been implemented. In the long term it'd be desirable to get a

Re: [libvirt] [PATCH v4 0/8] Add support for taking screenshots of domain console

2011-05-13 Thread Eric Blake
On 05/13/2011 02:56 AM, Daniel P. Berrange wrote: On Fri, May 13, 2011 at 10:34:24AM +0200, Michal Prívozník wrote: Then, screen is calculated as Screen Device Head 0 video0 0 1 video0 1 2 video1 0 3 video1 1 4 video1 2 5 video1 3

Re: [libvirt] [PATCH v4 6/8] virFDStream: Add option for delete file after it's opening

2011-05-13 Thread Eric Blake
On 05/13/2011 03:18 AM, Daniel P. Berrange wrote: On Thu, May 12, 2011 at 06:29:13PM +0200, Michal Privoznik wrote: This is needed if we want to transfer a temporary file. If the transfer is done with iohelper, we might run into a race condition, where we unlink() file before iohelper is

  1   2   >