Re: [libvirt] compile fail on FreeBSD

2011-11-11 Thread Eric Blake
On 11/11/2011 05:45 PM, Jason Helfman wrote: > On Fri, Nov 11, 2011 at 05:31:14PM -0700, Eric Blake thus spake: >> This failure on FreeBSD 8.2 popped up this week, and I suspect Dan's >> virnetdev refactoring, but haven't had time to further investigate and >> fix it: >> >> util/virnetdev.c: In fun

Re: [libvirt] compile fail on FreeBSD

2011-11-11 Thread Jason Helfman
On Fri, Nov 11, 2011 at 05:31:14PM -0700, Eric Blake thus spake: This failure on FreeBSD 8.2 popped up this week, and I suspect Dan's virnetdev refactoring, but haven't had time to further investigate and fix it: util/virnetdev.c: In function 'virNetDevExists': util/virnetdev.c:93: error: storag

Re: [libvirt] [PATCH 3/5] API: add trivial qemu support for VIR_TYPED_PARAM_STRING

2011-11-11 Thread Eric Blake
On 11/08/2011 05:36 AM, Stefan Berger wrote: > On 11/08/2011 06:00 AM, Hu Tao wrote: >> From: Eric Blake >> >> Qemu will be the first driver to make use of a typed string in the >> next round of additions. Separate out the trivial addition. >> > ACK I've pushed 1-3 before running out of time tod

[libvirt] compile fail on FreeBSD

2011-11-11 Thread Eric Blake
This failure on FreeBSD 8.2 popped up this week, and I suspect Dan's virnetdev refactoring, but haven't had time to further investigate and fix it: util/virnetdev.c: In function 'virNetDevExists': util/virnetdev.c:93: error: storage size of 'ifr' isn't known util/virnetdev.c:95: warning: implicit

Re: [libvirt] [PATCH] util: Compile error

2011-11-11 Thread Stefan Berger
On 11/11/2011 06:23 PM, Eric Blake wrote: On 11/11/2011 01:36 AM, Eli Qiao wrote: 于 2011年11月11日 16:33, Dong Xu Wang 写道: Sorry, the title is "util: Compile error", what's the usage of this patch? Without applying this, it will cause error while compiling? yes , when run make ,it will cause und

Re: [libvirt] [PATCH] util: Compile error

2011-11-11 Thread Eric Blake
On 11/11/2011 04:23 PM, Eric Blake wrote: > On 11/11/2011 01:36 AM, Eli Qiao wrote: >> >> >> 于 2011年11月11日 16:33, Dong Xu Wang 写道: >>> Sorry, the title is "util: Compile error", what's the usage of this >>> patch? >>> Without applying this, it will cause error while compiling? >> yes , when run mak

Re: [libvirt] [PATCH] qemu: fix domjobabort regression

2011-11-11 Thread Eric Blake
On 11/10/2011 04:43 PM, Jim Fehlig wrote: >>> In the 'virsh save --bypass-cache' case, we pass a pipe instead of a >>> regular fd, but using a pipe adds I/O overhead, so always passing a >>> pipe just so qemu can see EAGAIN doesn't seem nice. >>> >>> The ultimate fix needs to come from qemu - backg

Re: [libvirt] [PATCH] fix two bugs in bridge_driver.c

2011-11-11 Thread Eric Blake
On 11/11/2011 03:45 AM, Daniel P. Berrange wrote: > On Fri, Nov 11, 2011 at 04:20:19PM +0800, Hu Tao wrote: >> The reason is that the function virNetDevExists is now returns 1 if >> the device exists, comparing to the former one returns 0 if the device >> exists. But with only this fix will cause

Re: [libvirt] [PATCH] util: Compile error

2011-11-11 Thread Eric Blake
On 11/11/2011 01:36 AM, Eli Qiao wrote: > > > 于 2011年11月11日 16:33, Dong Xu Wang 写道: >> Sorry, the title is "util: Compile error", what's the usage of this >> patch? >> Without applying this, it will cause error while compiling? > yes , when run make ,it will cause undefined symbols error. Can yo

Re: [libvirt] [libvirt-glib 33/37] Implement gvir_config_device_chardev_set_source

2011-11-11 Thread Marc-André Lureau
On Thu, Nov 10, 2011 at 9:34 PM, Christophe Fergeau wrote: > +    source_type = > gvir_config_chardev_source_class_get_nick(G_OBJECT_TYPE(source)); > I don't see why this is necessarily a class method, I virtual method would have the same result (but simpler to use). I don't understand the desi

Re: [libvirt] [libvirt-glib 32/37] Add gobject boilerplate for chardev handling

2011-11-11 Thread Marc-André Lureau
On Thu, Nov 10, 2011 at 9:34 PM, Christophe Fergeau wrote: > +       gvir_config_device_chardev_set_source; > +       gvir_config_device_chardev_set_target; There is no definition for these symbols in this commit, you could include it here. -- Marc-André Lureau -- libvir-list mailing list libv

Re: [libvirt] Non-zero constant warning on RHEL 6.1 with 0.9.7

2011-11-11 Thread Justin Clift
On 12/11/2011, at 8:06 AM, Eric Blake wrote: > On 11/08/2011 11:46 PM, Justin Clift wrote: >> Hi guys, >> >> Just checking 0.9.7 on RHEL 6.1 x86_64. Noticed this when compiling >> with make -j 3: >> >>CC libvirt_lxc-command.o >> util/buf.c: In function 'virBufferEscape': >> util/buf.c:

Re: [libvirt] [PATCH] build: drop useless dirent.h includes

2011-11-11 Thread Eric Blake
On 11/07/2011 10:50 AM, Eric Blake wrote: > * .gnulib: Update to latest, for improved syntax-check. > * src/lxc/lxc_container.c (includes): Drop unused include. > * src/network/bridge_driver.c: Likewise. > * src/node_device/node_device_linux_sysfs.c: Likewise. > * src/openvz/openvz_driver.c: Likewi

Re: [libvirt] Non-zero constant warning on RHEL 6.1 with 0.9.7

2011-11-11 Thread Eric Blake
On 11/08/2011 11:46 PM, Justin Clift wrote: > Hi guys, > > Just checking 0.9.7 on RHEL 6.1 x86_64. Noticed this when compiling > with make -j 3: > > CC libvirt_lxc-command.o > util/buf.c: In function 'virBufferEscape': > util/buf.c:469: warning: logical '&&' with non-zero constant wi

Re: [libvirt] [Qemu-devel] qemu and qemu.git -> Migration + disk stress introduces qcow2 corruptions

2011-11-11 Thread Anthony Liguori
On 11/11/2011 08:44 AM, Kevin Wolf wrote: Am 11.11.2011 15:35, schrieb Anthony Liguori: This is not a bug fix, this is a new feature. We're long past feature freeze. It's not a simple and obvious fix either. It only partially fixes the problem and introduces other problems. It's not a good ca

Re: [libvirt] [libvirt-glib 31/37] Add GVirConfigDeviceVideo

2011-11-11 Thread Marc-André Lureau
ack On Thu, Nov 10, 2011 at 9:34 PM, Christophe Fergeau wrote: > --- >  libvirt-gconfig/Makefile.am                    |    2 + >  libvirt-gconfig/libvirt-gconfig-device-video.c |  133 > >  libvirt-gconfig/libvirt-gconfig-device-video.h |   82 +++ >  libvirt-

Re: [libvirt] [libvirt-glib 30/37] Add basic GVirConfigGraphicsSpice

2011-11-11 Thread Marc-André Lureau
Same comment as for "interface", do we want to have specialized classes for various type. In this case, you should also add a base Graphics class. > +GVirConfigGraphicsSpice *gvir_config_graphics_spice_new_from_xml(const gchar > *xml, > +                                                          

Re: [libvirt] [libvirt-glib 28/37] Add GVirConfigInterfaceNetwork

2011-11-11 Thread Marc-André Lureau
On Thu, Nov 10, 2011 at 9:34 PM, Christophe Fergeau wrote: > Make GVirConfigInterface an abstract base class, and move the > actual code in subclasses. This will make handling of the various > types of network interfaces more understandable and more logical > with respect to the corresponding XML.

Re: [libvirt] [libvirt-glib 29/37] Add GVirConfigDeviceInput

2011-11-11 Thread Marc-André Lureau
just a comment about naming. If we use prefix "Device" before devices class, I think it should be done for the rest of the class for consistency. > +void gvir_config_device_input_set_bus(GVirConfigDeviceInput *input, > +                                      const char *bus) > +{ > +    xmlNodePtr

Re: [libvirt] [libvirt-glib 27/37] Add to creation test

2011-11-11 Thread Marc-André Lureau
ack On Thu, Nov 10, 2011 at 9:33 PM, Christophe Fergeau wrote: > --- >  libvirt-gconfig/tests/test-domain-create.c |   13 - >  1 files changed, 12 insertions(+), 1 deletions(-) > > diff --git a/libvirt-gconfig/tests/test-domain-create.c > b/libvirt-gconfig/tests/test-domain-create.c

Re: [libvirt] [PATCH] Add support for systemd init service

2011-11-11 Thread Eric Blake
On 11/11/2011 07:32 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > This patch adds support for a systemd init service for libvirtd > and libvirt-guests. The libvirtd.service is *not* written to use > socket activation, since we want libvirtd to start on boot so it > can do guest a

Re: [libvirt] [libvirt-glib 25/37] Add gvir_config_interface_set_network_type

2011-11-11 Thread Marc-André Lureau
it's missing include of libvirt-gconfig-helpers-private.h On Fri, Nov 11, 2011 at 7:45 PM, Marc-André Lureau wrote: > ack > > -- > Marc-André Lureau > -- Marc-André Lureau -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [libvirt-glib 26/37] Add gvir_config_interface_set_source

2011-11-11 Thread Marc-André Lureau
On Thu, Nov 10, 2011 at 9:33 PM, Christophe Fergeau wrote: > The way it's done is just a band-aid though. The need for this > 'type' member in GVirConfigInterface and GVirConfigDeviceDisk is > a clear indication that they should be separate class. You mean there should be a seperate class for sou

Re: [libvirt] [libvirt-glib 23/37] Add test for adding a disk device

2011-11-11 Thread Marc-André Lureau
On Thu, Nov 10, 2011 at 9:33 PM, Christophe Fergeau wrote: >  devices = g_list_append(devices, disk); > +    gvir_config_domain_set_devices(domain, devices); > +    g_list_free(devices); > +    devices = NULL; Hmm, I realize this is a bit more tricky. You give up devices element owner ship but n

Re: [libvirt] [libvirt-glib 25/37] Add gvir_config_interface_set_network_type

2011-11-11 Thread Marc-André Lureau
ack -- Marc-André Lureau -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [libvirt-glib 24/37] GVirConfigInterface derives from GVirConfigDevice

2011-11-11 Thread Marc-André Lureau
ack -- Marc-André Lureau -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] xenapi: remove unused variable

2011-11-11 Thread Eric Blake
CC libvirt_driver_xenapi_la-xenapi_driver.lo xenapi/xenapi_driver.c: In function 'xenapiDomainGetVcpus': xenapi/xenapi_driver.c:1209:21: error: variable 'cpus' set but not used [-Werror=unused-but-set-variable] * src/xenapi/xenapi_driver.c (xenapiDomainGetVcpus): Silence compiler warning. -

Re: [libvirt] [libvirt-glib 22/37] More GVirConfigDeviceDisk setters

2011-11-11 Thread Marc-André Lureau
On Thu, Nov 10, 2011 at 9:33 PM, Christophe Fergeau wrote: > --- >  libvirt-gconfig/libvirt-gconfig-device-disk.c |   88 > - >  libvirt-gconfig/libvirt-gconfig-device-disk.h |   10 +++ >  libvirt-gconfig/libvirt-gconfig.sym           |    7 ++- >  3 files changed, 102 inse

Re: [libvirt] [libvirt-glib 21/37] Add gvir_config_domain_set_devices

2011-11-11 Thread Marc-André Lureau
ack -- Marc-André Lureau -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] Problem with listDomains() in Xen

2011-11-11 Thread PREETHI RAMESH
This question concerns the usage of the listDomains(). When I run this piece of code in KVM, it works perfectly fine but throws an array out of bounds exception in Xen. Connect conn=null; conn = new Connect("xen:///", true); int[] id = conn.listDomains(); System.out.println("lD of VM " +id[0])

[libvirt] [PATCH 5/6] Refactor code for enabling/disabling I/O callback in remote client

2011-11-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" * src/rpc/virnetclient.c: Add helper for setting I/O callback events --- src/rpc/virnetclient.c | 15 +-- 1 files changed, 13 insertions(+), 2 deletions(-) diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c index c4136b4..96d1886 100644 --- a/s

[libvirt] [PATCH 6/6] Allow non-blocking message sending on virNetClient

2011-11-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Split the existing virNetClientSend into two parts virNetClientSend and virNetClientSendNoReply, instead of having a 'bool expectReply' parameter. Add a new virNetClientSendNonBlock which returns 2 on full send, 1 on partial send, 0 on no send, -1 on error If a partia

[libvirt] [PATCH 2/6] Explicitly track whether the buck is held in remote client

2011-11-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Instead of inferring whether the buck is held from the waitDispatch pointer, use an explicit 'bool haveTheBuck' field * src/rpc/virnetclient.c: Explicitly track the buck --- src/rpc/virnetclient.c | 18 +++--- 1 files changed, 11 insertions(+), 7 deletio

[libvirt] [PATCH 4/6] Split virNetClientSend into 2 methods

2011-11-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Stop multiplexing virNetClientSend for two different purposes, instead add virNetClientSendWithReply and virNetClientSendNoReply * src/rpc/virnetclient.c, src/rpc/virnetclient.h: Replace virNetClientSend with virNetClientSendWithReply and virNetClientSendNoReply *

[libvirt] [PATCH 1/6] Remove all linked list handling from remote client event loop

2011-11-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Directly messing around with the linked list is potentially dangerous. Introduce some helper APIs to deal with list manipulating the list * src/rpc/virnetclient.c: Create linked list handlers --- src/rpc/virnetclient.c | 207 +-

[libvirt] [PATCH 0/6] Handle non-blocking I/O in client send

2011-11-11 Thread Daniel P. Berrange
This is an update to https://www.redhat.com/archives/libvir-list/2011-November/msg00339.html I pulled out alot of the generic cleanup to make the last hard bit easier to review -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 3/6] Refactor code for passing the buck in the remote client

2011-11-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Remove some duplication by pulling the code for passing the buck out into a helper method * src/rpc/virnetclient.c: Introduce virNetClientIOEventLoopPassTheBuck --- src/rpc/virnetclient.c | 35 +++ 1 files changed, 19 insertions(+), 1

Re: [libvirt] [PATCH] Add support for systemd init service

2011-11-11 Thread Paolo Bonzini
On 11/11/2011 03:32 PM, Daniel P. Berrange wrote: +%makeinstall SYSTEMD_UNIT_DIR=%{?buildroot:%{buildroot}}%{_unitdir} Is this correct since DESTDIR is prepended to it? Shouldn't it just be just %{_unitdir}? Otherwise looks good; it would be nicer to make it a configure option, but that's n

Re: [libvirt] [libvirt-glib 20/37] Improve gvir_config_object_new_child

2011-11-11 Thread Marc-André Lureau
Having gvir_config_object_add_child() and gvir_config_object_replace_child() would be more obvious (even the internal code should be splitted) On Thu, Nov 10, 2011 at 9:33 PM, Christophe Fergeau wrote: > Add an "overwrite" boolean argument to indicate what to do when > the child we are about to c

Re: [libvirt] [libvirt-glib 18/37] Add gobject boilerplate for GVirConfigDeviceDisk

2011-11-11 Thread Marc-André Lureau
> +static void gvir_config_device_disk_class_init(GVirConfigDeviceDiskClass > *klass) > +{ > + > +    g_type_class_add_private(klass, sizeof(GVirConfigDeviceDiskPrivate)); > +} There is an extra line here, in previous patch too. Is that intended? otherwise, ack. -- Marc-André Lureau -- libvir

Re: [libvirt] [libvirt-glib 17/37] Add gobject boilerplate for GVirConfigDevice

2011-11-11 Thread Marc-André Lureau
ack -- Marc-André Lureau -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [libvirt-glib 15/37] Add test for GVirConfigOs

2011-11-11 Thread Marc-André Lureau
ack On Thu, Nov 10, 2011 at 9:33 PM, Christophe Fergeau wrote: > --- >  libvirt-gconfig/tests/test-domain-create.c |   19 ++- >  1 files changed, 18 insertions(+), 1 deletions(-) > > diff --git a/libvirt-gconfig/tests/test-domain-create.c > b/libvirt-gconfig/tests/test-domain-cre

Re: [libvirt] [libvirt-glib 16/37] Add GVirConfigDomain::vcpu

2011-11-11 Thread Marc-André Lureau
ack On Thu, Nov 10, 2011 at 9:33 PM, Christophe Fergeau wrote: > --- >  libvirt-gconfig/libvirt-gconfig-domain.c   |   29 > >  libvirt-gconfig/libvirt-gconfig-domain.h   |    3 ++ >  libvirt-gconfig/libvirt-gconfig.sym        |    2 + >  libvirt-gconfig/tests/test-do

Re: [libvirt] [libvirt-glib 14/37] Implement gvir_config_domain_set_os

2011-11-11 Thread Marc-André Lureau
On Thu, Nov 10, 2011 at 9:33 PM, Christophe Fergeau wrote: > +/* Must come last since it uses types defined in the other headers */ > +#include This is weird, can't libvirt-gconfig/libvirt-gconfig-domain.h include libvirt-gconfig/libvirt-gconfig-clock.h (and others) instead? -- Marc-André Lure

Re: [libvirt] [libvirt-glib 13/37] Add gvir_config_os_set_{machine, arch}

2011-11-11 Thread Marc-André Lureau
It could be merged with previous patches. -- Marc-André Lureau -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [libvirt-glib 12/37] Add more GVirConfigOs setters

2011-11-11 Thread Marc-André Lureau
Hi Please merge with previous patch. > +    if (enable) > +        xmlNewProp(node, (xmlChar*)"enable", (xmlChar*)"yes"); > +    else > +        xmlNewProp(node, (xmlChar*)"enable", (xmlChar*)"no"); > +} might be useful to have use a gchar * gvir_config_yes_no (bool condition) > +        if (st

Re: [libvirt] [libvirt-glib 11/37] Implement gvir_config_os_set_os_type

2011-11-11 Thread Marc-André Lureau
it's actually missing gvir_config_os_set_os_type in the sym file, that you added in following patch. I would suggest to merge the two patches. -- Marc-André Lureau -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] 0.9.7 virsh console regression?

2011-11-11 Thread Michal Privoznik
On 10.11.2011 00:26, Albert W. Hopkins wrote: > Hi folks, > > I have a few "headless" qemu domains that use serial consoles. > Typically i connect to the consoles with > > # virsh console > > However with 0.9.7 I get > > Connected to domain gentoo-base > Escape characte

Re: [libvirt] [libvirt-glib 11/37] Implement gvir_config_os_set_os_type

2011-11-11 Thread Marc-André Lureau
On Thu, Nov 10, 2011 at 9:33 PM, Christophe Fergeau wrote: > --- >  libvirt-gconfig/libvirt-gconfig-os.c |   14 ++ >  libvirt-gconfig/libvirt-gconfig-os.h |    6 ++ >  libvirt-gconfig/libvirt-gconfig.sym  |    1 + >  3 files changed, 21 insertions(+), 0 deletions(-) > > diff --git

Re: [libvirt] [libvirt-glib 08/37] Create clock object in domain creation test

2011-11-11 Thread Marc-André Lureau
ack -- Marc-André Lureau -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [libvirt-glib 09/37] Add gobject boilerplate for GVirConfigOs

2011-11-11 Thread Marc-André Lureau
ack On Thu, Nov 10, 2011 at 9:33 PM, Christophe Fergeau wrote: > --- >  libvirt-gconfig/Makefile.am          |    2 + >  libvirt-gconfig/libvirt-gconfig-os.c |   80 > ++ >  libvirt-gconfig/libvirt-gconfig-os.h |   67 >  libvirt-gconfig

Re: [libvirt] [libvirt-glib 10/37] Add gvir_config_genum_get_nick helper

2011-11-11 Thread Marc-André Lureau
ack On Thu, Nov 10, 2011 at 9:33 PM, Christophe Fergeau wrote: > We will often need to convert from an enum to its string > representation, add an helper for that to avoid duplicating that > code. > --- >  libvirt-gconfig/libvirt-gconfig-clock.c           |   15 ++- >  libvirt-gconfig

Re: [libvirt] [libvirt-glib 07/37] Implement gvir_config_clock_set_offset

2011-11-11 Thread Marc-André Lureau
Hi On Thu, Nov 10, 2011 at 9:33 PM, Christophe Fergeau wrote: > --- >  libvirt-gconfig/libvirt-gconfig-clock.c |   19 +++ >  libvirt-gconfig/libvirt-gconfig-clock.h |    8 >  libvirt-gconfig/libvirt-gconfig.sym     |    2 ++ >  3 files changed, 29 insertions(+), 0 deletio

Re: [libvirt] [libvirt-glib 06/37] Use glib-mkenums to register enums with glib

2011-11-11 Thread Marc-André Lureau
actually, @@ -28,6 +31,8 @@ GCONFIG_SOURCE_FILES = \ libvirt-gconfig-clock.c \ libvirt-gconfig-domain.c \ libvirt-gconfig-domain-snapshot.c \ + libvirt-gconfig-enum-types.c \ + libvi

Re: [libvirt] [libvirt-glib 06/37] Use glib-mkenums to register enums with glib

2011-11-11 Thread Marc-André Lureau
ack -- Marc-André Lureau -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [libvirt-glib 05/37] Add gvir_config_domain_set_clock

2011-11-11 Thread Marc-André Lureau
On Thu, Nov 10, 2011 at 9:33 PM, Christophe Fergeau wrote: > The implementation is likely to need to be completed later. We > might want to store pointers from GVirConfigDomain to the associated > GVirConfigClock, from GVirConfigClock to the GVirConfigDomain that > contains it. Since I'm not sure

Re: [libvirt] [libvirt-glib 04/37] Add some GVirConfigClock setters

2011-11-11 Thread Marc-André Lureau
Hi On Thu, Nov 10, 2011 at 9:33 PM, Christophe Fergeau wrote: > --- >  libvirt-gconfig/libvirt-gconfig-clock.c  |   32 > ++ >  libvirt-gconfig/libvirt-gconfig-clock.h  |    5 >  libvirt-gconfig/libvirt-gconfig-domain.c |    1 + >  libvirt-gconfig/libvirt-gconfig-

Re: [libvirt] [Qemu-devel] qemu and qemu.git -> Migration + disk stress introduces qcow2 corruptions

2011-11-11 Thread Kevin Wolf
Am 11.11.2011 15:35, schrieb Anthony Liguori: > On 11/11/2011 08:29 AM, Kevin Wolf wrote: >> Am 11.11.2011 15:03, schrieb Anthony Liguori: >>> On 11/11/2011 04:15 AM, Kevin Wolf wrote: Am 10.11.2011 22:30, schrieb Anthony Liguori: > Live migration with qcow2 or any other image format is ju

Re: [libvirt] [Qemu-devel] qemu and qemu.git -> Migration + disk stress introduces qcow2 corruptions

2011-11-11 Thread Anthony Liguori
On 11/11/2011 08:29 AM, Kevin Wolf wrote: Am 11.11.2011 15:03, schrieb Anthony Liguori: On 11/11/2011 04:15 AM, Kevin Wolf wrote: Am 10.11.2011 22:30, schrieb Anthony Liguori: Live migration with qcow2 or any other image format is just not going to work right now even with proper clustered sto

[libvirt] [PATCH] Add support for systemd init service

2011-11-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" This patch adds support for a systemd init service for libvirtd and libvirt-guests. The libvirtd.service is *not* written to use socket activation, since we want libvirtd to start on boot so it can do guest auto-start. The libvirt-guests.service is pretty lame, just ex

Re: [libvirt] [PATCH 06/14] Add support for systemd init service

2011-11-11 Thread Daniel P. Berrange
On Wed, Nov 09, 2011 at 09:27:20AM +0100, Guido Günther wrote: > Hi Daniel, > > On Thu, Jul 07, 2011 at 03:17:24PM +0100, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > > > This patch adds support for a systemd init service for libvirtd > > and libvirt-guests. The libvirtd.service

Re: [libvirt] [libvirt-glib 03/37] Add gobject boilerplate for GVirConfigClock and GVirConfigTimer

2011-11-11 Thread Marc-André Lureau
Hi On Thu, Nov 10, 2011 at 9:33 PM, Christophe Fergeau wrote: > +struct _GVirConfigClockPrivate > +{ > +    gboolean unused; > +}; (does it really matter if the struct is empty?) > +G_DEFINE_TYPE(GVirConfigClock, gvir_config_clock, GVIR_TYPE_CONFIG_OBJECT); > + > + > +static void gvir_config_cl

Re: [libvirt] [libvirt-glib 02/37] Use new helpers to simplify gvir_config_domain_set_features

2011-11-11 Thread Marc-André Lureau
ack On Thu, Nov 10, 2011 at 9:33 PM, Christophe Fergeau wrote: > --- >  libvirt-gconfig/libvirt-gconfig-domain.c |   17 +++-- >  1 files changed, 3 insertions(+), 14 deletions(-) > > diff --git a/libvirt-gconfig/libvirt-gconfig-domain.c > b/libvirt-gconfig/libvirt-gconfig-domain.c >

Re: [libvirt] [libvirt-glib 01/37] Add gvir_config_object_new_child helper

2011-11-11 Thread Marc-André Lureau
hi The functions declaration should be put in -private.h . Marking definition G_GNUC_INTERNAL would also make it more obvious. It would also less confuse gir-scanner which doesn't know about libxml types. On Thu, Nov 10, 2011 at 9:33 PM, Christophe Fergeau wrote: > This allows us to factor the

Re: [libvirt] [Qemu-devel] qemu and qemu.git -> Migration + disk stress introduces qcow2 corruptions

2011-11-11 Thread Kevin Wolf
Am 11.11.2011 15:03, schrieb Anthony Liguori: > On 11/11/2011 04:15 AM, Kevin Wolf wrote: >> Am 10.11.2011 22:30, schrieb Anthony Liguori: >>> Live migration with qcow2 or any other image format is just not going to >>> work >>> right now even with proper clustered storage. I think doing a block

Re: [libvirt] [Qemu-devel] qemu and qemu.git -> Migration + disk stress introduces qcow2 corruptions

2011-11-11 Thread Anthony Liguori
On 11/11/2011 04:15 AM, Kevin Wolf wrote: Am 10.11.2011 22:30, schrieb Anthony Liguori: Live migration with qcow2 or any other image format is just not going to work right now even with proper clustered storage. I think doing a block level flush cache interface and letting block devices decide

[libvirt] Open Source Virtualization and Cloud at FOSDEM

2011-11-11 Thread Mark McLoughlin
Hey, Here's one for the calendar - a 2 day track at FOSDEM devoted to Open Source Virtualization and Cloud. Hope to see you there! :) Cheers, Mark. Forwarded Message > From: Thierry Carrez > To: openst...@lists.launchpad.net > Subject: [Openstack] OpenStack at FOSDEM > Date:

Re: [libvirt] [PATCH 2/3] Routine to truncate virBuffer

2011-11-11 Thread Bharata B Rao
On Mon, Nov 07, 2011 at 11:12:07AM -0700, Eric Blake wrote: > On 11/06/2011 06:58 AM, Bharata B Rao wrote: > >Routine to truncate virBuffer > > > >From: Bharata B Rao > > > >Add a helper to truncate virBuffer. > > > >/** > > * virBufferTruncate: > > >+++ b/src/util/buf.c > >@@ -123,6 +123,31 @@ v

Re: [libvirt] [Qemu-devel] Long QEMU main loop pauses during migration (to file) under heavy load

2011-11-11 Thread Daniel P. Berrange
On Fri, Nov 11, 2011 at 01:03:20PM +, Daniel P. Berrange wrote: > Libvirt recently introduced a change to the way it does 'save to file' > with QEMU. Historically QEMU has a 32MB/s I/O limit on migration by > default. When saving to file, we didn't want any artificial limit, > but rather to max

[libvirt] Long QEMU main loop pauses during migration (to file) under heavy load

2011-11-11 Thread Daniel P. Berrange
Libvirt recently introduced a change to the way it does 'save to file' with QEMU. Historically QEMU has a 32MB/s I/O limit on migration by default. When saving to file, we didn't want any artificial limit, but rather to max out the underlying storage. So when doing save to file, we set a large band

[libvirt] [PATCH v2 1/2] XML definitions for guest NUMA and parsing routines

2011-11-11 Thread Bharata B Rao
XML definitions for guest NUMA and parsing routines. From: Bharata B Rao This patch adds XML definitions for guest NUMA specification and contains routines to parse the same. The guest NUMA specification looks like this: ...

[libvirt] [PATCH v2 0/2] Guest NUMA topology support

2011-11-11 Thread Bharata B Rao
Hi, This is v2 of the patchset that adds support for specifying NUMA topology for guests. ... ... This change allows libvirt to generate -numa options for QEMU/KVM. This patchset passes all tests except daemon-conf t

[libvirt] [PATCH v2 2/2] qemu: Generate -numa option

2011-11-11 Thread Bharata B Rao
qemu: Generate -numa option From: Bharata B Rao Add routines to generate -numa QEMU command line option based on ... XML specifications. Signed-off-by: Bharata B Rao --- src/conf/cpu_conf.c|3 + src/qemu/qemu_command.c| 63 +

Re: [libvirt] [PATCH 3/3] qemu: Generate -numa command line option

2011-11-11 Thread Bharata B Rao
On Mon, Nov 07, 2011 at 11:47:10AM -0700, Eric Blake wrote: > On 11/06/2011 06:59 AM, Bharata B Rao wrote: > >qemu: Generate -numa option > > > >From: Bharata B Rao > > > >Add routines to generate -numa QEMU command line option based on > > ... XML specifications. > > > >Signed-off-by: Bharata B

Re: [libvirt] [PATCH 1/3] XML definitions for guest NUMA

2011-11-11 Thread Bharata B Rao
On Mon, Nov 07, 2011 at 11:35:27AM -0700, Eric Blake wrote: > On 11/06/2011 06:57 AM, Bharata B Rao wrote: > >XML definitions for guest NUMA and parsing routines. > > > >From: Bharata B Rao > > > >This patch adds XML definitions for guest NUMA specification and contains > >routines to parse the sam

[libvirt] [PATCH 2/7] kvmtool: Add documents

2011-11-11 Thread Osier Yang
The document is rather rough now, but at least contains an domain config example of all the current supported XMLs, and tells how to play with the driver. --- docs/drivers.html.in|1 + docs/drvkvmtool.html.in | 87 +++ docs/index.html.in |

[libvirt] [PATCH 6/7] conf: Set source type of the stub console

2011-11-11 Thread Osier Yang
As "serials[0]->source.type". This is for kvm tool driver only supports one console currently, and it setup ptys (redirect the stdout/stderr of kvm tool process to the master pty, and the slave pty path will be set to source path of the console) for connect to the guest via console. If the console

[libvirt] [PATCH 5/7] kvmtool: Add new domain type

2011-11-11 Thread Osier Yang
It's named as "kvmtool". --- src/conf/domain_conf.c |4 +++- src/conf/domain_conf.h |1 + 2 files changed, 4 insertions(+), 1 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 58f4d0f..55121d8 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @

Re: [libvirt] Add driver support for Native Linux KVM Tool

2011-11-11 Thread Osier Yang
Sorry, I missed the title. :( Osier On 11/11/2011 07:56 PM, Osier Yang wrote: Hi, all This is a basic implementation of libvirt Native Linux KVM Tool driver. Note that this is just made with my own interest and spare time, it's not an endorsement/effort by Red Hat, and it isn't supported by Red

[libvirt] [PATCH 1/7] kvmtool: Add configure support

2011-11-11 Thread Osier Yang
Assumes the binary of "Native Linux KVM Tool" will be named as "kvmtool", and installed to "/usr/bin". --- configure.ac | 24 1 files changed, 24 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac index 3b7535e..bcb2a40 100644 --- a/configure.ac +++

[libvirt] [PATCH 3/7] kvmtool: Add new enums and error codes for the driver

2011-11-11 Thread Osier Yang
--- include/libvirt/virterror.h |1 + src/driver.h|1 + src/util/virterror.c|3 +++ 3 files changed, 5 insertions(+), 0 deletions(-) diff --git a/include/libvirt/virterror.h b/include/libvirt/virterror.h index a8549b7..deda42d 100644 --- a/include/libvirt/virte

[libvirt] [PATCH] kvm tools: Introduce an ENV variable for the state dir

2011-11-11 Thread Osier Yang
Which is named as "KVMTOOL_STATE_DIR", so that the user can configure the path of state directly as he wants. --- tools/kvm/main.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/tools/kvm/main.c b/tools/kvm/main.c index 05bc82c..37b2b1d 100644 --- a/tools/kvm/main.c

[libvirt] (no subject)

2011-11-11 Thread Osier Yang
Hi, all This is a basic implementation of libvirt Native Linux KVM Tool driver. Note that this is just made with my own interest and spare time, it's not an endorsement/effort by Red Hat, and it isn't supported by Red Hat officially. Basically, the driver is designed as *stateful*, as KVM tool do

[libvirt] [PATCH 4/7] kvmtool: Add hook support for kvmtool domain

2011-11-11 Thread Osier Yang
Just like QEMU and LXC, kvm driver intends to support running hook script before domain starting and after domain shutdown too. --- src/util/hooks.c | 11 ++- src/util/hooks.h |8 2 files changed, 18 insertions(+), 1 deletions(-) diff --git a/src/util/hooks.c b/src/util/hoo

Re: [libvirt] [PATCH] fix two bugs in bridge_driver.c

2011-11-11 Thread Daniel P. Berrange
On Fri, Nov 11, 2011 at 04:20:19PM +0800, Hu Tao wrote: > steps to reproduce: > > 1. having a network xml file(named default.xml) like this one: > > > default > c5322c4c-81d0-4985-a363-ad6389780d89 > > > > > > > > > > in /etc/libvirt/qemu/networks/, and mark it

Re: [libvirt] [Qemu-devel] qemu and qemu.git -> Migration + disk stress introduces qcow2 corruptions

2011-11-11 Thread Kevin Wolf
Am 10.11.2011 22:30, schrieb Anthony Liguori: > Live migration with qcow2 or any other image format is just not going to work > right now even with proper clustered storage. I think doing a block level > flush > cache interface and letting block devices decide how to do it is the best > approa

Re: [libvirt] [PATCH] util: Compile error

2011-11-11 Thread Daniel P. Berrange
On Fri, Nov 11, 2011 at 01:50:46PM +0800, ta...@linux.vnet.ibm.com wrote: > From: Eli Qiao > > Add virnetdev.h,virnetdevbridge.h,virnetdevtap.h to private symbols > > Signed-off-by: Eli Qiao > --- > src/libvirt_private.syms | 29 + > 1 files changed, 29 insertions

Re: [libvirt] [PATCH] util: Compile error

2011-11-11 Thread Eli Qiao
于 2011年11月11日 16:33, Dong Xu Wang 写道: Sorry, the title is "util: Compile error", what's the usage of this patch? Without applying this, it will cause error while compiling? yes , when run make ,it will cause undefined symbols error. 2011/11/11: From: Eli Qiao Add virnetdev.h,virnetdevbridge

Re: [libvirt] [PATCH] util: Compile error

2011-11-11 Thread Dong Xu Wang
Sorry, the title is "util: Compile error", what's the usage of this patch? Without applying this, it will cause error while compiling? 2011/11/11 : > From: Eli Qiao > > Add virnetdev.h,virnetdevbridge.h,virnetdevtap.h to private symbols > > Signed-off-by: Eli Qiao > --- >  src/libvirt_private.s

[libvirt] [PATCH] fix two bugs in bridge_driver.c

2011-11-11 Thread Hu Tao
steps to reproduce: 1. having a network xml file(named default.xml) like this one: default c5322c4c-81d0-4985-a363-ad6389780d89 in /etc/libvirt/qemu/networks/, and mark it as autostart: $ ls -l /etc/libvirt/qemu/networks/autostart total 0 lrwxrwxrwx 1 root roo