- Original Message -
From: Eric Blake ebl...@redhat.com
To: Guan Nan Ren g...@redhat.com
Cc: libvir-list@redhat.com
Sent: Tuesday, January 24, 2012 8:56:30 PM
Subject: Re: [libvirt] [PATCH v2] Add two NUMA tuning python bindings APIs
On 01/24/2012 05:07 AM, Guan Nan Ren wrote:
static
On Tue, Jan 24, 2012 at 15:59:10 -0700, Eric Blake wrote:
On 01/24/2012 03:53 PM, Jiri Denemark wrote:
Direct boot (using kernel, initrd, and command line) is used by
virt-install/virt-manager for network install. While any bootindex has
no direct effect since -kernel is always first, we
On Tue, Jan 24, 2012 at 11:53:38AM -0700, Eric Blake wrote:
Systemd detects containers based on whether they have
an environment variable starting with 'container=lxc';
using a longer name fits the expectations, while also
allowing detection of who created the container.
Requested by
On Tue, Jan 24, 2012 at 21:21:32 +0100, Michal Privoznik wrote:
Since we have qemu guest agent support in libvirt,
we can start wiring up some things that GA already
knows how to do. One of them is file system freeze
and thaw. Domain snapshots can profit from this
functionality.
Michal
On 25.01.2012 11:02, Jiri Denemark wrote:
On Tue, Jan 24, 2012 at 21:21:32 +0100, Michal Privoznik wrote:
Since we have qemu guest agent support in libvirt,
we can start wiring up some things that GA already
knows how to do. One of them is file system freeze
and thaw. Domain snapshots can
Hi,
I have some problems on my application with memory leak when call
list_domains method.
I'm using libvirt 0.8.3 and Sys::Virt 0.2.4 Perl Module.
Does anyone have any idea what's the problem?
Regards,
--
Carlos Rodrigues c...@eurotux.com
Eurotux Informática, S.A. [http://eurotux.com]
On 23.01.2012 14:30, Jiri Denemark wrote:
We already provide ways to detect when a domain has been paused as a
result of I/O error, but there was no way of getting the exact error or
even the device that experienced it. This new API may be used for both.
---
include/libvirt/libvirt.h.in |
On 25.01.2012 12:04, Michal Privoznik wrote:
On 23.01.2012 14:30, Jiri Denemark wrote:
We already provide ways to detect when a domain has been paused as a
result of I/O error, but there was no way of getting the exact error or
even the device that experienced it. This new API may be used for
On 23.01.2012 14:30, Jiri Denemark wrote:
---
tools/virsh.c | 111
+++
tools/virsh.pod | 11 +
2 files changed, 122 insertions(+), 0 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index d635b56..92029fd 100644
---
On 23.01.2012 14:30, Jiri Denemark wrote:
---
src/qemu/qemu_conf.h |1 +
src/qemu/qemu_driver.c | 82
++
src/qemu/qemu_monitor.c | 40
src/qemu/qemu_monitor.h |1 +
This is an update of
https://www.redhat.com/archives/libvir-list/2012-January/msg00418.html
Changes since v1:
- Pushed the first 2 patches which passed review
- Update to include all Eric's suggested changes
- Rebase to latest GIT master
--
libvir-list mailing list
libvir-list@redhat.com
From: Daniel P. Berrange berra...@redhat.com
For the sake of backwards compat, LXC guests are *not*
confined by default. This is because it is not practical
to dynamically relabel containers using large filesystem
trees. Applications can create confined containers though,
by giving suitable XML
From: Daniel P. Berrange berra...@redhat.com
Revert parsing changes:
commit 302fe95ffa1bc5f1c61c0beb31a1adfbc38c668e
Author: Eric Blake ebl...@redhat.com
Date: Wed Jan 4 16:01:24 2012 -0700
seclabel: fix regression in libvirtd restart
commit
From: Daniel P. Berrange berra...@redhat.com
To allow the container to access /dev and /dev/pts when under
sVirt, set an explicit mount option. Also set a max size on
the /dev mount to prevent DOS on memory usage
* src/lxc/lxc_container.c: Set /dev mount context
* src/lxc/lxc_controller.c: Set
From: Daniel P. Berrange berra...@redhat.com
Curently security labels can be of type 'dynamic' or 'static'.
If no security label is given, then 'dynamic' is assumed. The
current code takes advantage of this default, and avoids even
saving seclabel elements with type='dynamic' to disk. This
means
From: Daniel P. Berrange berra...@redhat.com
This re-introduces parsing formatting for per device seclabels.
There is a new virDomainDeviceSeclabelPtr struct and corresponding
APIs for parsing/formatting.
---
src/conf/domain_conf.c | 132 ++--
On 01/23/2012 04:59 PM, Eric Blake wrote:
On 01/18/2012 09:20 AM, Stefan Berger wrote:
Compare two filter definitions for equality and only rebuild/instantiate
the new filter if the two filters are found to be different. This improves
performance during an update of a filter with no obvious
From: Daniel P. Berrange berra...@redhat.com
---
docs/formatdomain.html.in |4
docs/schemas/domaincommon.rng |5 +
2 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index dfb010d..1d0211d 100644
---
From: Daniel P. Berrange berra...@redhat.com
If no interface elements are included in an LXC guest XML
description, then the LXC guest will just see the host's
network interfaces. It is desirable to be able to hide the
host interfaces, without having to define any guest interfaces.
This patch
On 01/25/2012 07:35 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
---
docs/formatdomain.html.in |4
docs/schemas/domaincommon.rng |5 +
2 files changed, 9 insertions(+), 0 deletions(-)
ACK.
--
Eric Blake ebl...@redhat.com
Is there a later version of this patch than V3?
This _needs_ to be accepted into libvirt 0.9.10 (ie. in 2 days) in
order for us to get this into RHEL 6.3.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming blog: http://rwmj.wordpress.com
I wrote a patch to change the mapping between a virtual bridge interface
and the host bridge while the host is up. It's based on commit
6fba577e505611e6c25c68e322942eab7754de7e. The host and the interface
definition I used for testing are also attached.
I would be glad if the patch could be
Quoting Daniel P. Berrange (berra...@redhat.com):
On Tue, Jan 24, 2012 at 11:53:38AM -0700, Eric Blake wrote:
Systemd detects containers based on whether they have
an environment variable starting with 'container=lxc';
using a longer name fits the expectations, while also
allowing
On 01/23/2012 07:09 PM, Daniel P. Berrange wrote:
On Mon, Jan 23, 2012 at 06:53:17PM +0100, Peter Krempa wrote:
The domain schema enforced restrictions on the domain name string that
the code doesn't. This patch relaxes the check, leaving the restrictions
on the driver or hypervisor.
---
And
On 01/25/2012 07:35 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
If no interface elements are included in an LXC guest XML
description, then the LXC guest will just see the host's
network interfaces. It is desirable to be able to hide the
host interfaces,
The domain schema enforced restrictions on the domain name string that
the code doesn't. This patch relaxes the check, leaving the restrictions
on the driver or hypervisor. The only invalid character is a newline.
---
docs/schemas/domaincommon.rng |2 +-
1 files changed, 1 insertions(+), 1
On 01/25/2012 08:18 AM, Serge Hallyn wrote:
Quoting Daniel P. Berrange (berra...@redhat.com):
On Tue, Jan 24, 2012 at 11:53:38AM -0700, Eric Blake wrote:
Systemd detects containers based on whether they have
an environment variable starting with 'container=lxc';
using a longer name fits the
On 01/25/2012 08:49 AM, Peter Krempa wrote:
The domain schema enforced restrictions on the domain name string that
the code doesn't. This patch relaxes the check, leaving the restrictions
on the driver or hypervisor. The only invalid character is a newline.
---
docs/schemas/domaincommon.rng
On Wed, Jan 18, 2012 at 11:34:16AM -0700, Eric Blake wrote:
On 01/18/2012 09:23 AM, Daniel P. Berrange wrote:
@@ -1636,9 +1637,10 @@ cleanup:
}
-static unsigned long virCgroupPidCode(const void *name)
+static int32_t virCgroupPidCode(const void *name, int32_t seed)
{
-
From: Daniel P. Berrange berra...@redhat.com
In preparation for conversion over to use the Murmurhash3
algorithm, convert various virHash APIs to use size_t or
uint32 for their return values/parameters, instead of the
variable size 'unsigned long' or 'int' types
---
src/util/cgroup.c |4 +-
This is a followup to
https://www.redhat.com/archives/libvir-list/2012-January/msg00734.html
Changes in v2:
- Replace virRandom with virRandomBits as per Eric's suggested impl
- Move virRandom* functions to virrandom.{c,h}
- Move virHash impl to virhash.{c,h}
- Remove use of le32toh()
From: Daniel P. Berrange berra...@redhat.com
The old virRandom() API was not generating good random numbers.
Replace it with a new API virRandomBits which instead of being
told the upper limit, gets told the number of bits of randomness
required.
* src/util/virrandom.c, src/util/virrandom.h: Add
From: Daniel P. Berrange berra...@redhat.com
Recent discussions have illustrated the potential for DOS attacks
with the hash table implementations used by most languages and
libraries.
https://lwn.net/Articles/474912/
libvirt has an internal hash table impl, and uses hash tables for
a
On 01/25/2012 09:38 AM, Daniel P. Berrange wrote:
-static unsigned long virCgroupPidCode(const void *name)
+static int32_t virCgroupPidCode(const void *name, int32_t seed)
{
-return (unsigned long)name;
+unsigned long pid = (unsigned long)name;
+return virHashCodeGen(pid,
When interface is expanded to allow passthrough with extra
dev-dependent network interface info, the host-side address of the
device will need to be added to virDomainNetDef. It will be much
simpler if this is done with a common typedefed struct rather than
inlining the same struct stuff.
---
When support for the rombar option was added, it was only added for
PCI passthrough devices, configured with hostdev. The same option is
available for any network device that is attached to the guest's PCI
bus. This patch allows setting rombar for any PCI network device type.
After adding cases
This patchset started out as cleanup to make it easier to add in
support for doing PCI passthrough via the interface element (to be
used to attach a host network device to a guest after performing some
network-device-specific setup), but turned out to also make it much
easier to add support for
There is another identical call 4 lines up in the same function.
---
src/conf/domain_conf.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index e872396..471b0a2 100644
--- a/src/conf/domain_conf.c
+++
This patch addresses: https://bugzilla.redhat.com/show_bug.cgi?id=781562
Along with the rombar option that controls whether or not a boot rom
is made visible to the guest, qemu also has a romfile option that
allows specifying a binary file to present as the ROM BIOS of any
emulated or passthrough
Since these two items are now in the virDomainDeviceInfo struct, it
makes sense to parse/format them in the functions written to
parse/format that structure. Not all types of devices allow them, so
two internal flags are added to indicate when it is appropriate to do
so.
I was lucky - only one
On Wed, Jan 25, 2012 at 09:55:25AM -0700, Eric Blake wrote:
On 01/25/2012 09:38 AM, Daniel P. Berrange wrote:
-static unsigned long virCgroupPidCode(const void *name)
+static int32_t virCgroupPidCode(const void *name, int32_t seed)
{
-return (unsigned long)name;
+unsigned long
On 01/25/2012 09:55 AM, Eric Blake wrote:
+
+return le32toh(r);
endian.h, and thus le32toh(), is not yet standardized (although POSIX
will be adding it in the future), nor is it currently provided by
gnulib. We'd have to get that fixed first.
The le32toh call was only here because the
On F16 at least, empty volume groups don't have a directory under /dev.
The directory only appears once a logical volume is created.
This tickles some behavior in BackendStablePath which ends with
libvirt sleeping for 5 seconds while waiting for the directory to appear.
This causes all sorts of
On 01/25/2012 09:38 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The old virRandom() API was not generating good random numbers.
Replace it with a new API virRandomBits which instead of being
told the upper limit, gets told the number of bits of randomness
On 01/25/2012 11:15 AM, Cole Robinson wrote:
On F16 at least, empty volume groups don't have a directory under /dev.
The directory only appears once a logical volume is created.
This tickles some behavior in BackendStablePath which ends with
libvirt sleeping for 5 seconds while waiting for
On 01/25/2012 09:38 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
In preparation for conversion over to use the Murmurhash3
algorithm, convert various virHash APIs to use size_t or
uint32 for their return values/parameters, instead of the
variable size 'unsigned
On 01/25/2012 09:38 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
In preparation for the patch to include Murmurhash3, which
introduces a virhashcode.h and virhashcode.c files, rename
the existing hash.h and hash.c to virhash.h and virhash.c
respectively.
---
On 01/25/2012 11:44 AM, Eric Blake wrote:
On 01/25/2012 09:38 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
In preparation for the patch to include Murmurhash3, which
introduces a virhashcode.h and virhashcode.c files, rename
the existing hash.h and hash.c to
On 01/25/2012 01:23 PM, Eric Blake wrote:
On 01/25/2012 11:15 AM, Cole Robinson wrote:
On F16 at least, empty volume groups don't have a directory under /dev.
The directory only appears once a logical volume is created.
This tickles some behavior in BackendStablePath which ends with
libvirt
Add missing function if !HAVE_GETPWUID_R.
---
src/util/util.c |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/src/util/util.c b/src/util/util.c
index c00c2f9..33bcf29 100644
--- a/src/util/util.c
+++ b/src/util/util.c
@@ -2471,6 +2471,15 @@ virSetUIDGID(uid_t uid
When a filter is updated, compare it and the original one for equality
so that unnecessary instantiations of rules can be avoided.
v3:
- introducing a function to instantiate all running VMs' filters; call
it upon nwfilter driver reload
- reworked function comparing filters; determining
Compare two filters' XML for equality and only rebuild/instantiate the new
filter if the new and current filters are found to be different. This
improves performance during an update of a filter with no obvious change
or the reloading of filters during a 'kill -SIGHUP'
---
Introduce a function that rebuilds all running VMs' filters. Call
this function when reloading the nwfilter driver.
This addresses a problem introduced by the 2nd patch that typically
causes no filters to be reinstantiate anymore upon driver reload
since their XML has not changed. Yet the current
On 01/25/2012 09:38 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Recent discussions have illustrated the potential for DOS attacks
with the hash table implementations used by most languages and
libraries.
https://lwn.net/Articles/474912/
libvirt has an
On 01/25/2012 11:54 AM, Marc-André Lureau wrote:
Add missing function if !HAVE_GETPWUID_R.
---
src/util/util.c |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/src/util/util.c b/src/util/util.c
index c00c2f9..33bcf29 100644
--- a/src/util/util.c
+++
windows.h is included by threads.h.
winsock2.h should be included before.
Avoid the following warning:
In file included from ../gnulib/lib/unistd.h:51:0,
from ../src/util/util.h:30,
from rpc/virkeepalive.c:29:
Define PID_FORMAT and fix warnings for mingw64 x86_64 build.
Unfortunately, gnu_printf attribute check expect %lld while normal
printf is PRId64. So one warning remains.
---
src/rpc/virnetsocket.c |4 ++--
src/util/command.c | 10 +-
src/util/util.h|8
---
tools/virsh.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index 41c..246e638 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -3703,7 +3703,7 @@ vshGenFileName(vshControl *ctl, virDomainPtr dom, const
char *mime)
/* add
On 01/25/2012 11:58 AM, Stefan Berger wrote:
Introduce a function that rebuilds all running VMs' filters. Call
this function when reloading the nwfilter driver.
This addresses a problem introduced by the 2nd patch that typically
causes no filters to be reinstantiate anymore upon driver
On 12/16/2011 09:58 AM, shao...@linux.vnet.ibm.com wrote:
From: ShaoHe Feng shao...@linux.vnet.ibm.com
Basically, this feature can go along with qemu monitor passthrough.
That way, if we use new commands in the monitor that generate new events, we
want some way to receive those new events
On 01/25/2012 11:58 AM, Stefan Berger wrote:
Compare two filters' XML for equality and only rebuild/instantiate the new
filter if the new and current filters are found to be different. This
improves performance during an update of a filter with no obvious change
or the reloading of filters
On 01/25/2012 01:13 PM, Marc-André Lureau wrote:
Fixes the following warning:
util/virterror.c:1242:31: warning: declaration of 'errcode' shadows a global
declaration [-Wshadow]
Which header is polluting the namespace with a non-standard name?
---
src/util/virterror.c |8
1
On 01/25/2012 01:13 PM, Marc-André Lureau wrote:
windows.h is included by threads.h.
winsock2.h should be included before.
Avoid the following warning:
In file included from ../gnulib/lib/unistd.h:51:0,
from ../src/util/util.h:30,
from
- Mensaje original -
On 01/25/2012 01:13 PM, Marc-André Lureau wrote:
windows.h is included by threads.h.
winsock2.h should be included before.
Avoid the following warning:
In file included from ../gnulib/lib/unistd.h:51:0,
from ../src/util/util.h:30,
- Mensaje original -
On 01/25/2012 01:13 PM, Marc-André Lureau wrote:
Fixes the following warning:
util/virterror.c:1242:31: warning: declaration of 'errcode' shadows
a global declaration [-Wshadow]
Which header is polluting the namespace with a non-standard name?
crtdefs.h
On 01/25/2012 03:16 PM, Marc-André Lureau wrote:
NACK. I agree that things should be fixed, but the fix should live
in
the problematic threads.h inclusion pattern, not in the downstream
virkeepalive.c.
I agree, but ff we follow that reasoning, windows.h should include
winsock2.h,
Hi
- Mensaje original -
On 01/25/2012 03:16 PM, Marc-André Lureau wrote:
Btw, I don't mind testing patches, but using mingw64 is almost a
'yum install' away :)
What repo? The mingw64 compiler isn't in Fedora 16 proper.
The Fedora mingw64 project repo:
On Wed, Jan 25, 2012 at 02:16:14PM -0700, Eric Blake wrote:
On 12/16/2011 09:58 AM, shao...@linux.vnet.ibm.com wrote:
From: ShaoHe Feng shao...@linux.vnet.ibm.com
Basically, this feature can go along with qemu monitor passthrough.
That way, if we use new commands in the monitor that
On 01/25/2012 03:42 PM, Marc-André Lureau wrote:
Hi
- Mensaje original -
On 01/25/2012 03:16 PM, Marc-André Lureau wrote:
Btw, I don't mind testing patches, but using mingw64 is almost a
'yum install' away :)
What repo? The mingw64 compiler isn't in Fedora 16 proper.
The
On 01/25/2012 01:13 PM, Marc-André Lureau wrote:
Define PID_FORMAT and fix warnings for mingw64 x86_64 build.
Unfortunately, gnu_printf attribute check expect %lld while normal
printf is PRId64. So one warning remains.
---
src/rpc/virnetsocket.c |4 ++--
src/util/command.c | 10
Convert daemon code to handle 64-bit pid_t (even though at the
moment, it is not compiled on mingw).
* daemon/remote.c (remoteDispatchAuthList)
(remoteDispatchAuthPolkit): Print pid_t via %lld.
---
daemon/remote.c | 50 +-
1 files changed, 29
On 01/25/2012 05:22 PM, Marc-André Lureau wrote:
the decision should _not_ be based on _WIN64, but instead on a
configure-time test on the underlying type of pid_t. And since
_that_
gets difficult, I'd almost rather go with the simpler approach of:
% PRIdMAX, (intmax_t) pid
everywhere
On 01/25/2012 01:13 PM, Marc-André Lureau wrote:
Fix a few warnings with mingw64 x86_64.
---
src/util/logging.c |8
src/util/threads-win32.c |2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
ACK and pushed.
What a shame that (intptr_t) is the only portable type
Hi everyone,
In Boxes we'll need to change the size of the storage volumes (we
use qcow2 files) but turns out that there is no virStorageVolResize()
yet[1]. In my chat with Daniel on IRC, he mentioned that this would be
a trivial task so I thought I should try to do it myself. I've been
looking
On 01/25/2012 09:58 AM, Laine Stump wrote:
When interface is expanded to allow passthrough with extra
dev-dependent network interface info, the host-side address of the
device will need to be added to virDomainNetDef. It will be much
simpler if this is done with a common typedefed struct
On 01/25/2012 09:58 AM, Laine Stump wrote:
To help consolidate the commonality between virDomainHostdevDef and
virDomainInterface into as few members as possible (and because I
think it makes sense), this patch moves the rombar and bootIndex
members into the info member that is common to both
On 01/25/2012 09:58 AM, Laine Stump wrote:
Since these two items are now in the virDomainDeviceInfo struct, it
makes sense to parse/format them in the functions written to
parse/format that structure. Not all types of devices allow them, so
two internal flags are added to indicate when it is
On 01/25/2012 09:58 AM, Laine Stump wrote:
When support for the rombar option was added, it was only added for
PCI passthrough devices, configured with hostdev. The same option is
available for any network device that is attached to the guest's PCI
bus. This patch allows setting rombar for any
On 01/25/2012 08:08 PM, Eric Blake wrote:
On 01/25/2012 09:58 AM, Laine Stump wrote:
When support for the rombar option was added, it was only added for
PCI passthrough devices, configured with hostdev. The same option is
available for any network device that is attached to the guest's PCI
s/suport/support in the subject
actually, that makes the subject a bit long; how about just:
s/suport for //
On 01/25/2012 09:58 AM, Laine Stump wrote:
This patch addresses: https://bugzilla.redhat.com/show_bug.cgi?id=781562
Always fun to finally get to the real driver of the series.
On 12/02/2011 01:32 PM, Anthony Liguori wrote:
But we already have to call 'qemu -h' for other reasons; so we might as
well be efficient and learn as much as possible from that result than by
calling both 'qemu -h' and 'qemu -qmp ...', in order to probe what qemu
supports.
Also, 'qemu -qmp'
I'm getting tired of remembering to backport RHEL-specific
patches when building upstream libvirt on RHEL 6.x or CentOS.
All the affected versions of RHEL qemu-kvm have backported
enough patches to a) make JSON useful, and b) modify the
-help text to mention libvirt as the preferred interface;
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
In this particular case 'for' seems like a more natural choice as then
we don't need to update the iterator (which we were forgetting to do and
causing a hang in Boxes).
---
libvirt-gconfig/libvirt-gconfig-helpers.c |5 +
1 files changed, 1
Typo introduced in commit 4e9953a.
* tools/virsh.pod (snapshot-create): Fix pod error.
---
Pushing under the trivial rule.
It bothers me that I have to use RHEL 5 to catch obvious errors,
and that newer perl is too lax to flag bugs like this.
tools/virsh.pod |2 +-
1 files changed, 1
The qemu developers have made it clear that modern qemu will no
longer guarantee human monitor command stability; furthermore,
some features, such as async events, are only supported via qmp.
If we are compiled without support for handling JSON, we cannot
expect to sanely interact with modern
Hello,
On Thursday 26 January 2012 06:10:28 Zeeshan Ali (Khattak) wrote:
-it = node-children;
-while (it != NULL) {
+for (it = node-children; it != NULL; it = it-next) {
...
-xmlNodePtr next = it-next;
...
cont = iter_func(it, opaque);
...
-it = next;
Hi,
I agree, that it would be nice, if I even could change the host network
backend, although we do not need this functionality.
For our purpose we can go with the current host network backend and
connect that just to a different bridge. Essentially this is just a
brctl-invocation. Hendrik
87 matches
Mail list logo
