On 31.01.2012 18:22, Laine Stump wrote:
On 01/31/2012 11:16 AM, Michal Privoznik wrote:
In qemuDomainShutdownFlags if we try to use guest agent,
which has error or is not configured, we jump go endjob
label even if we haven't started any job yet. This may
lead to the daemon crash:
1) virsh
On 01.02.2012 01:30, Eric Blake wrote:
On 01/31/2012 05:51 AM, Michal Privoznik wrote:
which contained some useless lines, copied code, NULL
dereference.
---
src/libvirt.c |4 ++--
src/qemu/qemu_driver.c | 44
2 files changed, 18
On Tue, Jan 31, 2012 at 20:57:54 -0700, Eric Blake wrote:
On 01/31/2012 12:26 PM, Jiri Denemark wrote:
---
python/libvirt-override-api.xml |6
python/libvirt-override.c | 50
+++
2 files changed, 56 insertions(+), 0 deletions(-)
From: Alex Jia a...@redhat.com
Detected by valgrind. Leaks introduced in commit 973af236.
* src/network/bridge_driver.c: fix memory leaks on failure and successful path.
* How to reproduce?
% make -C tests check TESTS=networkxml2argvtest
% cd tests valgrind -v --leak-check=full
If we are building not on a WIN32 architecture and without HAVE_CAPNG
virSetCapabilities has unused argument and virClearCapabilities
is unused as well.
---
Pushed under build breaker rule.
src/util/command.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git
On 01.02.2012 08:00, alex@redhat.com wrote:
From: Alex Jia a...@redhat.com
* python/libvirt-override-virStream.py: fix a copy-paste error in sendAll().
Signed-off-by: Alex Jia a...@redhat.com
---
python/libvirt-override-virStream.py |2 +-
1 files changed, 1 insertions(+), 1
On 12.01.2012 18:52, Michal Privoznik wrote:
One of my latest patches (d8db0f9690) created support for setting
the limit for the maximum of opened files by qemu user. However,
since libvirtd keeps one FD opened per domain (well, for qemu at least)
it will likely hit this limit on huge
On Tue, Jan 31, 2012 at 20:26:09 +0100, Jiri Denemark wrote:
We already provide ways to detect when a domain has been paused as a
result of I/O error, but there was no way of getting the exact error or
even the device that experienced it. This new API may be used for both.
I fixed the memory
On Wed, Feb 01, 2012 at 02:27:28AM +0200, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Add wrapper for virStorageVolResize().
---
libvirt-gobject/libvirt-gobject-storage-vol.c | 45
+
libvirt-gobject/libvirt-gobject-storage-vol.h
I'm working on a patch to change the network an interface is associated
with while the guest is running.
So one part of this is of course changing the bridge the interface is
actually connected to. I already considered the way your described (from
domain to net to bridge) but I'm wondering if
On Wed, Feb 01, 2012 at 12:03:43PM +0100, Christophe Fergeau wrote:
On Wed, Feb 01, 2012 at 02:27:28AM +0200, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Add wrapper for virStorageVolResize().
---
libvirt-gobject/libvirt-gobject-storage-vol.c | 45
On Thu, Jan 12, 2012 at 06:52:52PM +0100, Michal Privoznik wrote:
One of my latest patches (d8db0f9690) created support for setting
the limit for the maximum of opened files by qemu user. However,
since libvirtd keeps one FD opened per domain (well, for qemu at least)
it will likely hit this
This patch adds support for the new api into the qemu driver to support
modification and retireval of domain description and title. This patch
does not add support for modifying the metadata element.
---
src/qemu/qemu_driver.c | 174
1 files
This patch adds a new element title to the domain XML. This attribute
can hold a short title defined by the user to ease the identification of
domains. The title may not contain newlines and should be reasonably short.
*docs/formatdomain.html.in
*docs/schemas/domaincommon.rng
- add
This third version incorporates fixes of Eric's review and a rebase on
the top of Jirka's new API.
Differences to v2:
xml: Add element title to allow short description of domains
- Move title before description
- fix tests to accomodate this
- remove forgotten length
This patch adds API to modify domain metadata for running and stopped
domains. The api supports changing description, title as well as the
newly added metadata element. The API has support for storing data in
the metadata element using xml namespaces.
* include/libvirt/libvirt.h.in
*
This patch adds a new command desc to show and modify titles and
description for the domains using the new API.
This patch also adds a new flag for the list command to show titles in
the domain list, to allow easy identification of VMs by storing a short
description.
Example:
virsh # list
This patch adds an internal function vmwareGetVMStatus to
get the real state of the domain. This function is used in
various places in the driver, in particular to detect when
the domain has been shut down by the user with the halt
command.
---
src/vmware/vmware_driver.c | 83
There are some changes made to the conf code to handle some new tags
like title or to add some metadata to a domain description in the
last days.
I'm wondering if there is a more generic (read better) way to handle
those extra data in xml config elements.
I think it would be far more reasonable
On Jan 26, 2012, at 5:57 PM, Daniel P. Berrange wrote:
On Fri, Jan 20, 2012 at 03:56:26PM +0100, D. Herrendoerfer wrote:
From: D. Herrendoerfer d.herrendoer...@herrendoerfer.name
This code adds an event service for netlink messages addressed
to libvirt and passes the message to registered
Hi All,
I am getting this error, while trying to compile latest git src.
./autogen.sh --prefix=$HOME/usr --enable-compile-warnings=error
running bootstrap...
./bootstrap: Error: 'python-config' not found
./bootstrap: Please install the prerequisite programs
Failed to bootstrap, please
On Wed, Feb 01, 2012 at 19:49:43 +0530, Deepak C Shetty wrote:
Hi All,
I am getting this error, while trying to compile latest git src.
./autogen.sh --prefix=$HOME/usr --enable-compile-warnings=error
running bootstrap...
./bootstrap: Error: 'python-config' not found
./bootstrap:
On 02/01/2012 07:56 PM, Jiri Denemark wrote:
On Wed, Feb 01, 2012 at 19:49:43 +0530, Deepak C Shetty wrote:
Hi All,
I am getting this error, while trying to compile latest git src.
./autogen.sh --prefix=$HOME/usr --enable-compile-warnings=error
running bootstrap...
./bootstrap: Error:
make all-am
make[3]: Entering directory `/home/dpkshetty/work/libvirt/libvirt/daemon'
GENqemu_dispatch.h
GENremote_dispatch.h
CC libvirtd-remote_protocol.o
CC libvirtd-qemu_protocol.o
CC libvirtd-remote.o
CC libvirtd-libvirtd.o
CC libvirtd-stream.o
In
GCC complaints about uninitialized use of len, which however is only
used when errors != NULL and in that case len is always initialized.
It's trivial to silence this by always initializing len.
---
Pushed as both trivial and build-breaking.
daemon/remote.c |2 +-
1 files changed, 1
On 02/01/2012 07:01 AM, Hendrik Schwartke wrote:
There are some changes made to the conf code to handle some new tags
like title or to add some metadata to a domain description in the
last days.
I'm wondering if there is a more generic (read better) way to handle
those extra data in xml
Requesting zheeshan to look, as this API was added recently by him, as i
see on the list...
On 02/01/2012 08:25 PM, Deepak C Shetty wrote:
make all-am
make[3]: Entering directory `/home/dpkshetty/work/libvirt/libvirt/daemon'
GENqemu_dispatch.h
GENremote_dispatch.h
CC
Ok, seems that i missed something here. I tried to add some additional
data to a domain description on monday but haven't a closer look at it.
I missed that I have to use the metadata-tag. So adding domain
type='kvm' id='25' xmlns:t=urn:foo t:x=55.../domain doesn't work,
or does it?
However,
On 02/01/2012 06:03 AM, Peter Krempa wrote:
This patch adds API to modify domain metadata for running and stopped
domains. The api supports changing description, title as well as the
newly added metadata element. The API has support for storing data in
the metadata element using xml
On 02/01/2012 11:01 AM, Deepak C Shetty wrote:
Requesting zheeshan to look, as this API was added recently by him, as
i see on the list...
jdenemar just pushed a fix.
On 02/01/2012 08:25 PM, Deepak C Shetty wrote:
make all-am
make[3]: Entering directory
On 02/01/2012 06:03 AM, Peter Krempa wrote:
This patch adds a new element title to the domain XML. This attribute
can hold a short title defined by the user to ease the identification of
domains. The title may not contain newlines and should be reasonably short.
*docs/formatdomain.html.in
On 02/01/2012 06:03 AM, Peter Krempa wrote:
This patch adds a new command desc to show and modify titles and
description for the domains using the new API.
This patch also adds a new flag for the list command to show titles in
the domain list, to allow easy identification of VMs by storing a
On 02/01/2012 06:03 AM, Peter Krempa wrote:
This patch adds support for the new api into the qemu driver to support
modification and retireval of domain description and title. This patch
s/retireval/retrieval/
does not add support for modifying the metadata element.
That's fair, as the
On 02/01/2012 10:05 PM, Laine Stump wrote:
On 02/01/2012 11:01 AM, Deepak C Shetty wrote:
Requesting zheeshan to look, as this API was added recently by him,
as i see on the list...
jdenemar just pushed a fix.
Do you mean the 'bogus warning about the uninit variable' fix, it does
not fix
If we issue guest command and GA is not running, the issuing thread
will block endlessly. We can check for GA presence by issuing
guest-sync with unique ID (timestamp). We don't want to issue real
command as even if GA is not running, once it is started, it process
all commands written to GA
[please don't top-post on technical lists]
On 02/01/2012 09:22 AM, Hendrik Schwartke wrote:
Ok, seems that i missed something here. I tried to add some additional
data to a domain description on monday but haven't a closer look at it.
I missed that I have to use the metadata-tag. So adding
On 01/25/2012 07:12 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
This re-introduces parsing formatting for per device seclabels.
There is a new virDomainDeviceSeclabelPtr struct and corresponding
APIs for parsing/formatting.
---
src/conf/domain_conf.c | 132
On 01/25/2012 07:12 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Revert parsing changes:
commit 302fe95ffa1bc5f1c61c0beb31a1adfbc38c668e
Author: Eric Blake ebl...@redhat.com
Date: Wed Jan 4 16:01:24 2012 -0700
seclabel: fix regression in
On 01/25/2012 07:12 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Curently security labels can be of type 'dynamic' or 'static'.
s/Curently/Currently/
If no security label is given, then 'dynamic' is assumed. The
current code takes advantage of this default,
On Tue, Jan 31, 2012 at 4:01 AM, Daniel P. Berrange berra...@redhat.com wrote:
I do like the idea of using the virtual port construct even in the
initial interface only case. For example:
interface type='bridge'
bridge name='br0'
virtualport type=openvswitch
parameters
On 02/01/2012 12:05 AM, Eric Blake wrote:
Qemu is adding the ability to do a partial rebase. That is, given:
base- intermediate- current
virDomainBlockPull will produce:
current
but qemu now has the ability to leave base in the chain, to produce:
base- current
Note that current qemu can
On 02/01/2012 12:06 AM, Eric Blake wrote:
Nice and simple.
Nice and ACKed :-)
* src/remote/remote_protocol.x (REMOTE_PROC_DOMAIN_BLOCK_REBASE):
New RPC.
* src/remote/remote_driver.c (remote_driver): Wire it up.
* src/remote_protocol-structs: Regenerate.
---
src/remote/remote_driver.c |
On Wed, Feb 1, 2012 at 2:02 PM, Daniel P. Berrange berra...@redhat.com wrote:
On Wed, Feb 01, 2012 at 12:03:43PM +0100, Christophe Fergeau wrote:
On Wed, Feb 01, 2012 at 02:27:28AM +0200, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Add wrapper for
On Wed, Feb 1, 2012 at 1:03 PM, Christophe Fergeau cferg...@redhat.com wrote:
On Wed, Feb 01, 2012 at 02:27:28AM +0200, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
+ GError **err)
+{
+ GVirStoragePoolInfo* pool_info = NULL;
On 02/01/2012 12:06 AM, Eric Blake wrote:
This is a trivial implementation, which works with the current
released qemu 1.0 with backports of preliminary block pull but
no partial rebase. Future patches will update the monitor handling
to support an optional parameter for partial rebase; but as
On 02/01/2012 12:44 PM, Zeeshan Ali (Khattak) wrote:
+ * @flags: the flags
+ * @err: Return location for errors, or NULL
+ *
+ * Changes the capacity of the storage volume @vol to @capacity.
+ *
+ * Returns: the new capacity of the volume on success, 0 otherwise
+ */
+gboolean
On 02/01/2012 12:40 PM, Laine Stump wrote:
On 02/01/2012 12:05 AM, Eric Blake wrote:
Qemu is adding the ability to do a partial rebase. That is, given:
base- intermediate- current
virDomainBlockPull will produce:
current
but qemu now has the ability to leave base in the chain, to
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Add wrapper for virStorageVolResize().
---
libvirt-gobject/libvirt-gobject-storage-vol.c | 27 +
libvirt-gobject/libvirt-gobject-storage-vol.h | 20 ++
libvirt-gobject/libvirt-gobject.sym |1
On 02/01/2012 12:00 PM, Deepak C Shetty wrote:
On 02/01/2012 10:05 PM, Laine Stump wrote:
On 02/01/2012 11:01 AM, Deepak C Shetty wrote:
Requesting zheeshan to look, as this API was added recently by him,
as i see on the list...
jdenemar just pushed a fix.
Do you mean the 'bogus warning
This was forgotten when the function was initially written (not
noticed because it wasn't used at the time). It's required for proper
compilation with modules enabled after applying the recent rawio
patches.
---
src/libvirt_private.syms |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
This was forgotten when the function was originally written (not
noticed because it wasn't used at the time). It's required for
proper compilation with modules enabled after applying the recent
virStorageVolResize patches.
---
src/libvirt_private.syms |2 +-
1 files changed, 1 insertions(+),
Both of these pushed under the build-breaker rule.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Dňa 1.2.2012 23:09, Eric Blake wrote / napísal(a):
On 02/01/2012 09:49 AM, Eric Blake wrote:
On 02/01/2012 06:03 AM, Peter Krempa wrote:
This patch adds a new command desc to show and modify titles and
description for the domains using the new API.
+/* strip a possible newline at the
On 02/01/2012 09:49 AM, Eric Blake wrote:
On 02/01/2012 06:03 AM, Peter Krempa wrote:
This patch adds a new command desc to show and modify titles and
description for the domains using the new API.
+/* strip a possible newline at the end of file */
+/* some editors enforce a
On 02/01/2012 12:53 PM, Laine Stump wrote:
On 02/01/2012 12:06 AM, Eric Blake wrote:
This is a trivial implementation, which works with the current
released qemu 1.0 with backports of preliminary block pull but
no partial rebase. Future patches will update the monitor handling
to support an
Dňa 1.2.2012 23:35, Eric Blake wrote / napísal(a):
On 02/01/2012 06:03 AM, Peter Krempa wrote:
This third version incorporates fixes of Eric's review and a rebase on
the top of Jirka's new API.
In the interest of sparing you further rebase headaches (and in part
because I had already
On 02/01/2012 02:22 AM, a...@redhat.com wrote:
From: Alex Jia a...@redhat.com
Detected by valgrind. Leaks introduced in commit 973af236.
* src/network/bridge_driver.c: fix memory leaks on failure and successful
path.
* How to reproduce?
% make -C tests check TESTS=networkxml2argvtest
On 01/31/2012 10:08 AM, Philipp Hahn wrote:
libvirt supports 4 different versions of the user-land XenD daemon. When
queried the daemon just returns its generation number, which is hard to
match to the version of the Xen tools.
Replace the magic generation numbers by named macro definitions
On 01/30/2012 10:44 AM, Philipp Hahn wrote:
virnettlscontexttest uses gnutls_x509_crt_set_subject_alt_name() and
GNUTLS_FSAN_APPEND, which - according to
http://www.gnu.org/software/gnutls/manual/gnutls.html - are only
available since 2.6.0.
Since libvirt still works fine with gnutls-1.0.25
On 02/01/2012 04:17 PM, Eric Blake wrote:
@@ -516,7 +520,6 @@ networkBuildDnsmasqArgv(virNetworkObjPtr network,
int i;
for (i = 0; i dns-ntxtrecords; i++) {
-char *record = NULL;
if (virAsprintf(record, %s,%s,
On 01/30/2012 10:13 AM, Philipp Hahn wrote:
The path to the dnsmasq binary can be configured while in the test data
the path is hard-coded to /usr/bin/. This break the test suite if a the
binary is located in a different location, like /usr/local/sbin/.
Replace the hard coded path in the
On 01/26/2012 10:16 AM, Peter Krempa wrote:
This patch changes behavior of virPidFileRead to enable passing NULL as
path to the binary the pid file should be checked against to skip this
check. This enables using this function for reading files that have same
semantics as pid files, but belong
On 01/26/2012 10:16 AM, Peter Krempa wrote:
This patch adds a set of flags to be used with the virDomainOpenConsole
API call to specify if the user wishes to interrupt an existing console
session or just to try open a new one.
VIR_DOMAIN_CONSOLE_SAFE - specifies that the console connection
Replace calls to fwrite() and fscanf() with more portable-friendly
version, such as snprintf() and virStrToLong().
---
src/util/virpidfile.c | 42 +-
1 files changed, 25 insertions(+), 17 deletions(-)
diff --git a/src/util/virpidfile.c
It seems all the code use pid_t type properly, so it is safe
to drop that check now.
---
src/util/command.c|3 ---
src/util/virpidfile.c |2 --
2 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/src/util/command.c b/src/util/command.c
index 1e4c206..ce992a6 100644
---
Define PID_FORMAT and fix warnings for mingw64 x86_64 build.
---
configure.ac |1 +
src/rpc/virnetsocket.c |4 ++--
src/util/command.c | 10 +-
src/util/util.h|7 +++
src/util/virpidfile.c |6 +++---
5 files changed, 18 insertions(+), 10
I haven't investigated what is missing in the Makefiles, but I'm getting
link failures on RHEL 5:
../src/.libs/libvirt_driver_nwfilter.a(libvirt_driver_nwfilter_la-nwfilter_ebiptables_driver.o):
In function `_printDataType':
/home/dummy/libvirt/src/nwfilter/nwfilter_ebiptables_driver.c:306:
---
.gnulib |2 +-
bootstrap | 16
2 files changed, 13 insertions(+), 5 deletions(-)
diff --git a/.gnulib b/.gnulib
index dd6b2d7..2f0ed93 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit dd6b2d751b3c6ad417f6a4c48f2adb9d27cc59d2
+Subproject commit
On 02/01/2012 05:28 PM, Marc-André Lureau wrote:
---
.gnulib |2 +-
bootstrap | 16
2 files changed, 13 insertions(+), 5 deletions(-)
diff --git a/.gnulib b/.gnulib
index dd6b2d7..2f0ed93 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit
On 01/26/2012 10:16 AM, Peter Krempa wrote:
This patch adds support for the newly introduced
VIR_DOMAIN_CONSOLE_FORCE and VIR_DOMAIN_CONSOLE_SAFE flags. The console
command now has an optional parameter --force that specifies that the
user wants to forcibly interrupt an ongoing console session
Thanks for your change and pushed.
Regards,
Alex
- Original Message -
From: Eric Blake ebl...@redhat.com
Cc: a...@redhat.com, libvir-list@redhat.com
Sent: Thursday, February 2, 2012 7:44:21 AM
Subject: Re: [libvirt] [PATCHv4] network: Avoid memory leaks on
networkBuildDnsmasqArgv
On
Thanks Laine, that worked.
On 02/02/2012 02:46 AM, Laine Stump wrote:
On 02/01/2012 12:00 PM, Deepak C Shetty wrote:
On 02/01/2012 10:05 PM, Laine Stump wrote:
On 02/01/2012 11:01 AM, Deepak C Shetty wrote:
Requesting zheeshan to look, as this API was added recently by him,
as i see on the
Hello Eric,
Am Donnerstag 02 Februar 2012 00:28:37 schrieben Sie:
On 01/31/2012 10:08 AM, Philipp Hahn wrote:
...
+#define XEND_CONFIG_VERSION_3_0_2 1
+#define XEND_CONFIG_VERSION_3_0_3 2
+#define XEND_CONFIG_VERSION_3_0_4 3
+#define XEND_CONFIG_VERSION_3_1_0 4
This fails 'make
From: Alex Jia a...@redhat.com
Detected by valgrind. Leak is introduced in commit 3bb6bcf.
Free 'vol' memory before allocating memory, the codes will miss one time
free when 'vol_i = nvolumes' in for loop, so plug memory leak.
* tools/virsh.c: fix memory leak on cmdUndefine.
* How to
virFileOpenAs previously would only try opening a file as the current
user, or as a different user, but wouldn't try both methods in a
single call. This made it cumbersome to use as a replacement for
open(2). Additionally, it had a lot of historical baggage that led to
it being difficult to
I believe this version addresses all the issues Eric raised in his
review of V3, *except* those that we agreed should be left for a later patch.
Patch 2/2 is unchanged all the way since v1.
Patch 1/2 has the following changes from V3:
* The last ditch attempt to open the file in the parent
This eliminates the warning message reported in:
https://bugzilla.redhat.com/show_bug.cgi?id=624447
It was caused by a failure to open an image file that is not
accessible by root (the uid libvirtd is running as) because it's on a
root-squash NFS share, owned by a different user, with
77 matches
Mail list logo
