Re: [libvirt] [Qemu-devel] [RFC PATCH 0/4] block: file descriptor passing using -filefd and getfd_file

2012-05-22 Thread Kevin Wolf
Am 21.05.2012 22:19, schrieb Corey Bryant: libvirt's sVirt security driver provides SELinux MAC isolation for Qemu guest processes and their corresponding image files. In other words, sVirt uses SELinux to prevent a QEMU process from opening files that do not belong to it. sVirt provides

[libvirt] [PATCH] fix building error on non fedora system

2012-05-22 Thread Wen Congyang
We forget to define with_storage_rbd if the system is not fedora, or the version is less than 16. --- libvirt.spec.in |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 8c4a2fd..0b83969 100644 --- a/libvirt.spec.in +++

[libvirt] [PATCHv2] qemu_hotplug: Don't free the PCI device structure after hot-unplug

2012-05-22 Thread Peter Krempa
The pciDevice structure corresponding to the device being hot-unplugged was freed after it was stolen from activeList. The pointer was still used for eg-inactive list. This patch removes the free of the structure and frees it only if reset fails on the device. --- I've added a check for activePci

[libvirt] [libvirt-glib] Check arguments to public libvirt-gobject methods

2012-05-22 Thread Christophe Fergeau
Some public methods in libvirt-gobject don't have g_return_if_fail checks on their arguments. It happens that GNOME Boxes tries to call gvir_connection_find_storage_pool_by_name with a NULL GVirConnection causing a crash https://bugzilla.gnome.org/show_bug.cgi?id=676216 While GNOME Boxes needs to

Re: [libvirt] [Qemu-devel] [RFC PATCH 2/4] qmp/hmp: Add getfd_file monitor command

2012-05-22 Thread Stefan Hajnoczi
On Mon, May 21, 2012 at 9:19 PM, Corey Bryant cor...@linux.vnet.ibm.com wrote: I think Eric has raised the main questions about duplicating getfd and rules regarding canonical file names (QEMU mashes filenames together if the backing filename is relative!). +    if (qemu_isdigit(filename[0])) {

Re: [libvirt] [PATCH 2/2] virsh: Allow users to reedit rejected XML

2012-05-22 Thread Michal Privoznik
On 18.05.2012 19:27, Eric Blake wrote: On 05/18/2012 06:48 AM, Michal Privoznik wrote: If users *-edit but make a mistake in XML all changes are permanently lost. However, if virsh is not running within a script we can as user if he wants to re-edit the file s/as/ask/ and correct the

Re: [libvirt] [PATCH 10/10] Enable driver modules in libvirt RPM

2012-05-22 Thread Eric Blake
On 05/21/2012 01:59 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Turn on loadable modules for libvirtd. Add new sub-RPMs libvirt-daemon-driver-XXX, one for each loadable .so. Modify the libvirt-daemon-YYY RPMs to depend on each of the individual drivers they

Re: [libvirt] [Qemu-devel] [RFC PATCH 0/4] block: file descriptor passing using -filefd and getfd_file

2012-05-22 Thread Eric Blake
On 05/22/2012 02:18 AM, Kevin Wolf wrote: This patch series adds the -filefd command-line option and the getfd_file monitor command. This will enable libvirt to open a file and push the corresponding filename and file descriptor to QEMU. When QEMU needs to open a file, it will first check

Re: [libvirt] [Qemu-devel] [RFC PATCH 0/4] block: file descriptor passing using -filefd and getfd_file

2012-05-22 Thread Kevin Wolf
Am 22.05.2012 14:02, schrieb Eric Blake: On 05/22/2012 02:18 AM, Kevin Wolf wrote: This patch series adds the -filefd command-line option and the getfd_file monitor command. This will enable libvirt to open a file and push the corresponding filename and file descriptor to QEMU. When QEMU

Re: [libvirt] [PATCHv2] qemu_hotplug: Don't free the PCI device structure after hot-unplug

2012-05-22 Thread Eric Blake
On 05/22/2012 03:00 AM, Peter Krempa wrote: The pciDevice structure corresponding to the device being hot-unplugged was freed after it was stolen from activeList. The pointer was still used for eg-inactive list. This patch removes the free of the structure and frees it only if reset fails on

Re: [libvirt] [PATCH 2/2] virsh: Allow users to reedit rejected XML

2012-05-22 Thread Eric Blake
On 05/22/2012 03:49 AM, Michal Privoznik wrote: On 18.05.2012 19:27, Eric Blake wrote: On 05/18/2012 06:48 AM, Michal Privoznik wrote: If users *-edit but make a mistake in XML all changes are permanently lost. However, if virsh is not running within a script we can as user if he wants to

Re: [libvirt] [PATCH] fix building error on non fedora system

2012-05-22 Thread Eric Blake
On 05/22/2012 02:07 AM, Wen Congyang wrote: We forget to define with_storage_rbd if the system is not fedora, or the version is less than 16. --- libvirt.spec.in |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index

Re: [libvirt] [libvirt-glib] Add getter for GVirConfigDomainOS.arch

2012-05-22 Thread Zeeshan Ali (Khattak)
On Mon, May 21, 2012 at 7:14 PM, Daniel P. Berrange berra...@redhat.com wrote: On Mon, May 21, 2012 at 07:06:32PM +0300, Zeeshan Ali (Khattak) wrote: On Mon, May 21, 2012 at 3:13 PM, Christophe Fergeau cferg...@redhat.com wrote: On Sat, May 19, 2012 at 05:45:31AM +0300, Zeeshan Ali (Khattak)

Re: [libvirt] [Qemu-devel] [RFC PATCH 1/4] qemu-options: Add -filefd command line option

2012-05-22 Thread Corey Bryant
On 05/21/2012 05:40 PM, Eric Blake wrote: On 05/21/2012 02:19 PM, Corey Bryant wrote: This patch provides support for the -filefd command line option. This option will allow passing of a filename and its corresponding file descriptor to QEMU at exec time. Signed-off-by: Corey

[libvirt] [PATCH] Revert rpc: Discard non-blocking calls only when necessary

2012-05-22 Thread Jiri Denemark
This reverts commit b1e374a7ac56927cfe62435179bf0bba1e08b372, which was rather bad since I failed to consider all sides of the issue. Thus, the reverted patch actually breaks more than what it fixes and clients (which may even be libvirtd during p2p migrations) will likely end up with a corrupted

Re: [libvirt] [Qemu-devel] [RFC PATCH 2/4] qmp/hmp: Add getfd_file monitor command

2012-05-22 Thread Corey Bryant
On 05/21/2012 05:48 PM, Eric Blake wrote: On 05/21/2012 02:19 PM, Corey Bryant wrote: This patch provides support for the getfd_file monitor command. This command will allow passing of a filename and its corresponding file descriptor to a guest via the monitor. This command could be

Re: [libvirt] [Qemu-devel] [RFC PATCH 1/4] qemu-options: Add -filefd command line option

2012-05-22 Thread Kevin Wolf
Am 22.05.2012 15:25, schrieb Corey Bryant: On 05/21/2012 05:40 PM, Eric Blake wrote: On 05/21/2012 02:19 PM, Corey Bryant wrote: This patch provides support for the -filefd command line option. This option will allow passing of a filename and its corresponding file descriptor to QEMU at

Re: [libvirt] [PATCH 3/5] remote: implement remote protocol for virConnectListAllDomains()

2012-05-22 Thread Peter Krempa
On 05/22/2012 01:30 AM, Eric Blake wrote: On 05/20/2012 09:56 AM, Peter Krempa wrote: This patch wires up the RPC protocol handlers for virConnectListAllDomains(). The RPC generator has no support for the way how virConnectListAllDomains() returns the results so the handler code had to be done

[libvirt] [PATCH] qemu: configurable VNC port boundaries for domains

2012-05-22 Thread Martin Kletzander
The defines QEMU_VNC_PORT_MIN and QEMU_VNC_PORT_MAX were used to find free port when starting domains. As this was hardcoded to the same ports as default VNC servers, there were races with these other programs. This patch includes the possibility to change the default starting port as well as the

Re: [libvirt] [Qemu-devel] [RFC PATCH 3/4] block: Enable QEMU to retrieve passed fd before attempting open

2012-05-22 Thread Corey Bryant
On 05/21/2012 05:50 PM, Eric Blake wrote: On 05/21/2012 02:19 PM, Corey Bryant wrote: With this patch, when QEMU needs to open a file, it will first check to see if a matching filename/fd pair were passed via the -filefd command line option or the getfd_file monitor command. If a match is

Re: [libvirt] [Qemu-devel] [RFC PATCH 2/4] qmp/hmp: Add getfd_file monitor command

2012-05-22 Thread Corey Bryant
On 05/22/2012 05:18 AM, Stefan Hajnoczi wrote: On Mon, May 21, 2012 at 9:19 PM, Corey Bryantcor...@linux.vnet.ibm.com wrote: I think Eric has raised the main questions about duplicating getfd and rules regarding canonical file names (QEMU mashes filenames together if the backing filename is

Re: [libvirt] [Qemu-devel] [RFC PATCH 1/4] qemu-options: Add -filefd command line option

2012-05-22 Thread Stefan Hajnoczi
On Tue, May 22, 2012 at 2:38 PM, Kevin Wolf kw...@redhat.com wrote: Am 22.05.2012 15:25, schrieb Corey Bryant: On 05/21/2012 05:40 PM, Eric Blake wrote: On 05/21/2012 02:19 PM, Corey Bryant wrote: This patch provides support for the -filefd command line option. This option will allow

Re: [libvirt] [PATCH 3/5] remote: implement remote protocol for virConnectListAllDomains()

2012-05-22 Thread Eric Blake
On 05/22/2012 08:05 AM, Peter Krempa wrote: + +struct remote_connect_list_all_domains_ret { +remote_nonnull_domain domains; This is an unbounded array; we aren't using any of these anywhere else. I wonder if reusing REMOTE_DOMAIN_ID_LIST_MAX would be reasonable instead. Then again,

Re: [libvirt] [Qemu-devel] [RFC PATCH 0/4] block: file descriptor passing using -filefd and getfd_file

2012-05-22 Thread Corey Bryant
On 05/22/2012 04:18 AM, Kevin Wolf wrote: Am 21.05.2012 22:19, schrieb Corey Bryant: libvirt's sVirt security driver provides SELinux MAC isolation for Qemu guest processes and their corresponding image files. In other words, sVirt uses SELinux to prevent a QEMU process from opening files

Re: [libvirt] [Qemu-devel] [RFC PATCH 1/4] qemu-options: Add -filefd command line option

2012-05-22 Thread Kevin Wolf
Am 22.05.2012 16:26, schrieb Stefan Hajnoczi: On Tue, May 22, 2012 at 2:38 PM, Kevin Wolf kw...@redhat.com wrote: Am 22.05.2012 15:25, schrieb Corey Bryant: On 05/21/2012 05:40 PM, Eric Blake wrote: On 05/21/2012 02:19 PM, Corey Bryant wrote: This patch provides support for the -filefd

Re: [libvirt] [PATCHv2 1/4] Introduce filesystem limits to virDomainFSDef

2012-05-22 Thread Eric Blake
On 05/11/2012 03:14 PM, Guido Günther wrote: --- docs/formatdomain.html.in | 12 ++ docs/schemas/domaincommon.rng | 12 ++ src/conf/domain_conf.c| 88 +++-- src/conf/domain_conf.h|2 + 4 files changed, 111

Re: [libvirt] [Qemu-devel] [RFC PATCH 0/4] block: file descriptor passing using -filefd and getfd_file

2012-05-22 Thread Kevin Wolf
Am 22.05.2012 16:30, schrieb Corey Bryant: On 05/22/2012 04:18 AM, Kevin Wolf wrote: Am 21.05.2012 22:19, schrieb Corey Bryant: libvirt's sVirt security driver provides SELinux MAC isolation for Qemu guest processes and their corresponding image files. In other words, sVirt uses SELinux

Re: [libvirt] [PATCHv2 2/4] openvz: support file system quota reporting

2012-05-22 Thread Eric Blake
On 05/11/2012 03:14 PM, Guido Günther wrote: --- src/openvz/openvz_conf.c| 16 tests/domainschemadata/domain-openvz-simple.xml |2 ++ 2 files changed, 18 insertions(+) +param = DISKSPACE; +ret = openvzReadVPSConfigParam(veid,

Re: [libvirt] [PATCHv2 4/4] Use virParseScaledValue in virDomainParseMemory

2012-05-22 Thread Eric Blake
On 05/11/2012 03:14 PM, Guido Günther wrote: --- src/conf/domain_conf.c | 37 - 1 file changed, 4 insertions(+), 33 deletions(-) Ah, here's what I was wondering about in patch 1/4. I'd rebase this to happen at the same time as you create

Re: [libvirt] [PATCHv2 3/4] openvz: add quota argument when creating container

2012-05-22 Thread Eric Blake
On 05/11/2012 03:14 PM, Guido Günther wrote: --- src/openvz/openvz_driver.c | 54 +++- 1 file changed, 53 insertions(+), 1 deletion(-) +if (fss-type == VIR_DOMAIN_FS_TYPE_TEMPLATE) { +if (fss-space_soft_limit) { +sl =

Re: [libvirt] [PATCH] qemu: configurable VNC port boundaries for domains

2012-05-22 Thread Dave Allan
On Tue, May 22, 2012 at 04:10:03PM +0200, Martin Kletzander wrote: The defines QEMU_VNC_PORT_MIN and QEMU_VNC_PORT_MAX were used to find free port when starting domains. As this was hardcoded to the same ports as default VNC servers, there were races with these other programs. This patch

Re: [libvirt] [Qemu-devel] [RFC PATCH 0/4] block: file descriptor passing using -filefd and getfd_file

2012-05-22 Thread Eric Blake
On 05/22/2012 08:45 AM, Kevin Wolf wrote: I understand that open(/dev/fd/42) would be the same as dup(42), but I'm not sure that I'm entirely clear on how this would work. Could you give an example? With your approach you open the file outside qemu, pass the fd to qemu along with a file

Re: [libvirt] [PATCH] qemu: configurable VNC port boundaries for domains

2012-05-22 Thread Eric Blake
On 05/22/2012 09:00 AM, Dave Allan wrote: On Tue, May 22, 2012 at 04:10:03PM +0200, Martin Kletzander wrote: The defines QEMU_VNC_PORT_MIN and QEMU_VNC_PORT_MAX were used to find free port when starting domains. As this was hardcoded to the same ports as default VNC servers, there were races

Re: [libvirt] [Qemu-devel] [RFC PATCH 0/4] block: file descriptor passing using -filefd and getfd_file

2012-05-22 Thread Kevin Wolf
Am 22.05.2012 17:01, schrieb Eric Blake: On 05/22/2012 08:45 AM, Kevin Wolf wrote: I understand that open(/dev/fd/42) would be the same as dup(42), but I'm not sure that I'm entirely clear on how this would work. Could you give an example? With your approach you open the file outside

Re: [libvirt] [Qemu-devel] [RFC PATCH 0/4] block: file descriptor passing using -filefd and getfd_file

2012-05-22 Thread Corey Bryant
On 05/22/2012 10:45 AM, Kevin Wolf wrote: Am 22.05.2012 16:30, schrieb Corey Bryant: On 05/22/2012 04:18 AM, Kevin Wolf wrote: Am 21.05.2012 22:19, schrieb Corey Bryant: libvirt's sVirt security driver provides SELinux MAC isolation for Qemu guest processes and their corresponding image

[libvirt] [PATCH][libvirt-glib] glib-events: Allow zero timeouts for timer

2012-05-22 Thread Michal Privoznik
In libvirt, it's perfectly possible and widely used to have disabled timers (timeout=-1) and fire them up 'randomly' with timeout=0. However, with current mapping into glib mainloop it's not possible and causing troubles. --- libvirt-glib/libvirt-glib-event.c |2 +- 1 files changed, 1

[libvirt] [PATCH] util: export virBufferTrim

2012-05-22 Thread Laine Stump
This was forgotten in commit cdb87b1c4b3c325c61e2a6a7d8edcca3ca73a765. Pushed under build-breaker rule (broke builds with modules turned on) --- src/libvirt_private.syms |1 + 1 file changed, 1 insertion(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index

Re: [libvirt] [Qemu-devel] [RFC PATCH 0/4] block: file descriptor passing using -filefd and getfd_file

2012-05-22 Thread Kevin Wolf
Am 22.05.2012 17:29, schrieb Corey Bryant: On 05/22/2012 10:45 AM, Kevin Wolf wrote: Am 22.05.2012 16:30, schrieb Corey Bryant: On 05/22/2012 04:18 AM, Kevin Wolf wrote: Am 21.05.2012 22:19, schrieb Corey Bryant: libvirt's sVirt security driver provides SELinux MAC isolation for Qemu

Re: [libvirt] [PATCH 2/2] virsh: Allow users to reedit rejected XML

2012-05-22 Thread Michal Privoznik
On 22.05.2012 14:41, Eric Blake wrote: On 05/22/2012 03:49 AM, Michal Privoznik wrote: On 18.05.2012 19:27, Eric Blake wrote: On 05/18/2012 06:48 AM, Michal Privoznik wrote: If users *-edit but make a mistake in XML all changes are permanently lost. However, if virsh is not running within a

[libvirt] [libvirt-glib 1/2] Add gvir_config_object_get_attribute_uint64()

2012-05-22 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org Another internal libvirt-gconfig helper to get unint64 XML attributes. --- libvirt-gconfig/libvirt-gconfig-object-private.h |4 libvirt-gconfig/libvirt-gconfig-object.c | 15 +++ 2 files changed, 19 insertions(+), 0

[libvirt] [libvirt-glib 2/2] API to deal with topology information of CPU capabilities

2012-05-22 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- libvirt-gconfig/Makefile.am|2 + .../libvirt-gconfig-capabilities-cpu-topology.c| 83 .../libvirt-gconfig-capabilities-cpu-topology.h| 71 +

[libvirt] JSON license is non-free - how are we affected?

2012-05-22 Thread Eric Blake
The QMP monitor uses JSON as its underlying base. However, when you read the license of JSON [1], you will note that it has a pretty severe limitation (The Software shall be used for Good, not Evil). In fact, this limitation is severe enough that the FSF has declared that the JSON license is

Re: [libvirt] JSON license is non-free - how are we affected?

2012-05-22 Thread Paolo Bonzini
Il 22/05/2012 17:51, Eric Blake ha scritto: Is the JSON license only applicable to code downloaded from json.org, but not to the actual JSON language specification? Yes, of course. I think not even Oracle disagrees. If so, does that mean that a clean-room implementation of JSON (the

Re: [libvirt] [PATCH][libvirt-glib] glib-events: Allow zero timeouts for timer

2012-05-22 Thread Christophe Fergeau
On Tue, May 22, 2012 at 05:37:25PM +0200, Michal Privoznik wrote: In libvirt, it's perfectly possible and widely used to have disabled timers (timeout=-1) and fire them up 'randomly' with timeout=0. However, with current mapping into glib mainloop it's not possible and causing troubles. The

Re: [libvirt] [Qemu-devel] [RFC PATCH 0/4] block: file descriptor passing using -filefd and getfd_file

2012-05-22 Thread Corey Bryant
On 05/22/2012 11:39 AM, Kevin Wolf wrote: Am 22.05.2012 17:29, schrieb Corey Bryant: On 05/22/2012 10:45 AM, Kevin Wolf wrote: Am 22.05.2012 16:30, schrieb Corey Bryant: On 05/22/2012 04:18 AM, Kevin Wolf wrote: Am 21.05.2012 22:19, schrieb Corey Bryant: libvirt's sVirt security

Re: [libvirt] [Qemu-devel] [RFC PATCH 0/4] block: file descriptor passing using -filefd and getfd_file

2012-05-22 Thread Eric Blake
On 05/22/2012 09:29 AM, Corey Bryant wrote: I understand that open(/dev/fd/42) would be the same as dup(42), but I'm not sure that I'm entirely clear on how this would work. Could you give an example? Instead you could use the existing getfd command and avoid the translation: (qemu)

Re: [libvirt] [PATCH 2/2] virsh: Allow users to reedit rejected XML

2012-05-22 Thread Eric Blake
On 05/22/2012 09:45 AM, Michal Privoznik wrote: Failed. [R]eedit/[S]tart over again/[Q]uit? Eww. That does raise an interesting question. Maybe it's better to make it a two part question: I don't like being asked twice. I think users would prefer one question with many answers, e.g.

Re: [libvirt] [PATCHv2] qemu_hotplug: Don't free the PCI device structure after hot-unplug

2012-05-22 Thread Peter Krempa
On 05/22/2012 02:42 PM, Eric Blake wrote: On 05/22/2012 03:00 AM, Peter Krempa wrote: The pciDevice structure corresponding to the device being hot-unplugged was freed after it was stolen from activeList. The pointer was still used for eg-inactive list. This patch removes the free of the

Re: [libvirt] JSON license is non-free - how are we affected?

2012-05-22 Thread Eric Blake
On 05/22/2012 09:58 AM, Paolo Bonzini wrote: Il 22/05/2012 17:51, Eric Blake ha scritto: Is the JSON license only applicable to code downloaded from json.org, but not to the actual JSON language specification? Yes, of course. I think not even Oracle disagrees. If so, does that mean that

Re: [libvirt] [Qemu-devel] JSON license is non-free - how are we affected?

2012-05-22 Thread Anthony Liguori
On 05/22/2012 10:51 AM, Eric Blake wrote: The QMP monitor uses JSON as its underlying base. However, when you read the license of JSON [1], you will note that it has a pretty severe limitation (The Software shall be used for Good, not Evil). In fact, this limitation is severe enough that the

Re: [libvirt] [Qemu-devel] [RFC PATCH 0/4] block: file descriptor passing using -filefd and getfd_file

2012-05-22 Thread Corey Bryant
On 05/22/2012 12:15 PM, Eric Blake wrote: On 05/22/2012 09:29 AM, Corey Bryant wrote: I understand that open(/dev/fd/42) would be the same as dup(42), but I'm not sure that I'm entirely clear on how this would work. Could you give an example? Instead you could use the existing getfd

Re: [libvirt] [PATCH] qemu: configurable VNC port boundaries for domains

2012-05-22 Thread Dave Allan
On Tue, May 22, 2012 at 09:09:55AM -0600, Eric Blake wrote: On 05/22/2012 09:00 AM, Dave Allan wrote: On Tue, May 22, 2012 at 04:10:03PM +0200, Martin Kletzander wrote: The defines QEMU_VNC_PORT_MIN and QEMU_VNC_PORT_MAX were used to find free port when starting domains. As this was

Re: [libvirt] [PATCH] Revert rpc: Discard non-blocking calls only when necessary

2012-05-22 Thread Eric Blake
On 05/22/2012 07:34 AM, Jiri Denemark wrote: This reverts commit b1e374a7ac56927cfe62435179bf0bba1e08b372, which was rather bad since I failed to consider all sides of the issue. Thus, the reverted patch actually breaks more than what it fixes and clients (which may even be libvirtd during p2p

Re: [libvirt] [Qemu-devel] [RFC PATCH 2/4] qmp/hmp: Add getfd_file monitor command

2012-05-22 Thread Luiz Capitulino
On Tue, 22 May 2012 10:18:22 +0100 Stefan Hajnoczi stefa...@gmail.com wrote: QMP commands should be added to qapi-schema.json as described in docs/writing-qmp-commands.txt. Looks like there's consensus on dropping this patch and enhancing getfd to return the fd number. This would require to

Re: [libvirt] [Qemu-devel] [RFC PATCH 2/4] qmp/hmp: Add getfd_file monitor command

2012-05-22 Thread Corey Bryant
On 05/22/2012 03:06 PM, Luiz Capitulino wrote: On Tue, 22 May 2012 10:18:22 +0100 Stefan Hajnoczistefa...@gmail.com wrote: QMP commands should be added to qapi-schema.json as described in docs/writing-qmp-commands.txt. Looks like there's consensus on dropping this patch and enhancing

Re: [libvirt] [Qemu-devel] [RFC PATCH 2/4] qmp/hmp: Add getfd_file monitor command

2012-05-22 Thread Luiz Capitulino
On Tue, 22 May 2012 16:02:19 -0400 Corey Bryant cor...@linux.vnet.ibm.com wrote: But there's a small problem. Today getfd commands are closely tied to the Monitor. In Anthony's development tree, the getfd commands are tied to the new QMP server's session support. Asking you to integrate

Re: [libvirt] [PATCH 2/5] python: add API exports for virConnectListAllDomains()

2012-05-22 Thread Eric Blake
On 05/20/2012 09:56 AM, Peter Krempa wrote: This patch adds export of the new API function virConnectListAllDomains() to the libvirt-python bindings. The virConnect object now has method listAllDomains that takes only the flags parameter and returns a python list of virDomain object

Re: [libvirt] [PATCH] Revert rpc: Discard non-blocking calls only when necessary

2012-05-22 Thread Jiri Denemark
On Tue, May 22, 2012 at 11:34:33 -0600, Eric Blake wrote: On 05/22/2012 07:34 AM, Jiri Denemark wrote: This reverts commit b1e374a7ac56927cfe62435179bf0bba1e08b372, which was rather bad since I failed to consider all sides of the issue. Thus, the reverted patch actually breaks more than

Re: [libvirt] [Qemu-devel] [RFC PATCH 2/4] qmp/hmp: Add getfd_file monitor command

2012-05-22 Thread Corey Bryant
On 05/22/2012 04:26 PM, Luiz Capitulino wrote: On Tue, 22 May 2012 16:02:19 -0400 Corey Bryantcor...@linux.vnet.ibm.com wrote: But there's a small problem. Today getfd commands are closely tied to the Monitor. In Anthony's development tree, the getfd commands are tied to the new QMP

Re: [libvirt] [PATCH v2] [TCK] nwfilter: Add test cases for ipset

2012-05-22 Thread Stefan Berger
On 04/27/2012 10:19 AM, Eric Blake wrote: On 04/27/2012 05:25 AM, Stefan Berger wrote: Add test cases for ipset support. Since ipset may not be available on all system, the first line of the XML file containing the test filter has been extended with a specially formatted XML comment containing

[libvirt] [PATCH] Fix for parallel port passtrough for QEMU

2012-05-22 Thread Beat.Joerg
Hi As requested by Dave, I send this to the list. I came across a bug that the command line generated for passtrough of the host parallel port /dev/parport0 by libvirt for QEMU is incorrect. It currently produces: -chardev tty,id=charparallel0,path=/dev/parport0 -device