Re: [libvirt] Unable to make libvirt-0.9.13

2012-07-12 Thread B Veera-B37207
Hi Eric, I am compiling on Power PC Architecture Board. As you said I compiled with 'make V=1' , Output file is attached with this mail. Regards, Veera. -Original Message- From: Eric Blake [mailto:ebl...@redhat.com] Sent: Wednesday, July 11, 2012 8:00 PM To: B Veera-B37207 Cc:

Re: [libvirt] Unable to make libvirt

2012-07-12 Thread B Veera-B37207
Hi, Platform : Power PC When I am doing make V=1 libtool: link: gcc -std=gnu99 -shared -fPIC -DPIC -Wl,--whole-archive ./.libs/libvirt_util.a ./.libs/libvirt_conf.a ./.libs/libvirt_cpu.a ./.libs/libvirt_v mx.a ./.libs/libvirt_driver.a ./.libs/libvirt_driver_test.a

Re: [libvirt] [PATCH] Fix directory removal in virStorageBackendFileSystemVolDelete

2012-07-12 Thread Sascha Peilicke
On 07/11/2012 05:42 PM, Daniel P. Berrange wrote: On Wed, Jul 11, 2012 at 03:21:27PM +0200, Sascha Peilicke wrote: --- src/storage/storage_backend_fs.c | 28 +++- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/src/storage/storage_backend_fs.c

Re: [libvirt] [PATCH] qemu: Set swap_hard_limit before hard_limit

2012-07-12 Thread Hu Tao
On Thu, Jul 12, 2012 at 05:03:52PM +0800, Osier Yang wrote: Setting hard_limit larger than previous swap_hard_limit must fail, it's not that good if one wants to change the swap_hard_limit and hard_limit together. E.g. % virsh memtune rhel6 hard_limit : 100 soft_limit : 100

Re: [libvirt] [PATCH 0/6] Add usb controller model=none

2012-07-12 Thread Peter Krempa
On 07/09/12 19:29, Peter Krempa wrote: This series adds support for completely disabling USB bus for a host if a user requires this. For this to work a new USB controller model none was added that removes the USB bus. The controller is added in patches 2-4. Patch 1 cleans up some nits (and is

[libvirt] [PATCHv2 3/6] domain_conf: Add helpers to verify if device configuration is valid

2012-07-12 Thread Peter Krempa
This patch adds helpers that validate domain's device configuration. This will be needed later on to verify devices being hot-plugged to guests. If the guest has no USB bus, then it's not valid to plug a USB device to that guest. --- src/conf/domain_conf.c | 43

[libvirt] [PATCHv2 4/6] qemu: Add support for none USB controller

2012-07-12 Thread Peter Krempa
This patch enables the none USB controller for qemu guests and adds valdiation on hot-plugged devices if the guest has USB disabled. --- src/qemu/qemu_command.c |7 +++ src/qemu/qemu_driver.c |6 ++ 2 files changed, 13 insertions(+), 0 deletions(-) diff --git

[libvirt] [PATCHv2 0/6] Add usb controller model=none

2012-07-12 Thread Peter Krempa
This is a rebase of the previous version. There are no changes except solving conflicts in tests/qemuxml2argvtest.c after new tests were added lately. This series adds support for completely disabling USB bus for a host if a user requires this. For this to work a new USB controller model none

[libvirt] [PATCHv2 1/6] maint: Clean up coding style

2012-07-12 Thread Peter Krempa
Style changes split out from next patch. --- src/conf/domain_conf.c | 23 +-- src/qemu/qemu_command.c | 19 +++ src/qemu/qemu_driver.c |7 +++ 3 files changed, 27 insertions(+), 22 deletions(-) diff --git a/src/conf/domain_conf.c

[libvirt] [PATCHv2 5/6] tests: Add support for catching domain XML parsing errors

2012-07-12 Thread Peter Krempa
This patch enhances qemuxml2argvtest to deal with sematicaly incorrect domain XMLs, that generate errors while parsing. This patch cleans up macros that invoke the tests and changes boolean flags to a bit array flag variable. --- tests/qemuxml2argvtest.c | 505

[libvirt] [PATCHv2 2/6] domain_conf: Add USB controler model none

2012-07-12 Thread Peter Krempa
Libvirt adds a USB controller to the guest even if the user does not specify any in the XML. This is due to back-compat reasons. To allow disabling USB for a guest this patch adds a new USB controller type none that disables USB support for the guest. --- docs/schemas/domaincommon.rng |1 +

[libvirt] [PATCHv2 6/6] tests: Add tests to check the new USB none controller

2012-07-12 Thread Peter Krempa
This patch adds a set of tests to check parsing of domain XMLs that use the none controller and some forbidden situations concerning it. --- .../qemuxml2argvdata/qemuxml2argv-usb-none-hub.xml | 19 ++ .../qemuxml2argv-usb-none-other.xml| 19 ++

Re: [libvirt] Libvirt iSCSI APIs

2012-07-12 Thread Daniel P. Berrange
On Wed, Jul 11, 2012 at 05:28:07PM -0700, Ata Bohra wrote: Hi All, I am interested in extending libvirt APIs to support iSCSI operations such as: add/remove targets, list targets, list remote LUNs, rescan luns etc. The intention is to provide an interface that external programs

Re: [libvirt] Libvirt iSCSI APIs

2012-07-12 Thread Daniel P. Berrange
On Thu, Jul 12, 2012 at 11:24:30AM +0800, Osier Yang wrote: On 2012年07月12日 08:28, Ata Bohra wrote: Hi All, I am interested in extending libvirt APIs to support iSCSI operations such as: add/remove targets, list targets, list remote LUNs, rescan luns etc. Nice. The intention is to

Re: [libvirt] [PATCH] qemu: Set swap_hard_limit before hard_limit

2012-07-12 Thread Osier Yang
On 2012年07月12日 17:19, Hu Tao wrote: On Thu, Jul 12, 2012 at 05:03:52PM +0800, Osier Yang wrote: Setting hard_limit larger than previous swap_hard_limit must fail, it's not that good if one wants to change the swap_hard_limit and hard_limit together. E.g. % virsh memtune rhel6 hard_limit :

[libvirt] [PATCHv3] docs: Improve patch submission guidelines

2012-07-12 Thread Michal Privoznik
We should really advise (new) developers to send rebased patches that apply cleanly and use git-send-email rather than all other obscure ways. --- diff to v2: -Eric's suggestions worked in HACKING | 37 - docs/hacking.html.in | 49

[libvirt] [PATCH] qemu: Set swap_hard_limit before hard_limit

2012-07-12 Thread Osier Yang
Setting hard_limit larger than previous swap_hard_limit must fail, it's not that good if one wants to change the swap_hard_limit and hard_limit together. E.g. % virsh memtune rhel6 hard_limit : 100 soft_limit : 100 swap_hard_limit: 100 % virsh memtune rhel6 --hard-limit

[libvirt] [PATCH] qemu: Do not fail virConnectCompareCPU if host CPU is not known

2012-07-12 Thread Jiri Denemark
When host CPU could not be properly detected, virConnectCompareCPU will just report that any CPU is incompatible with host CPU instead of failing. --- src/qemu/qemu_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c

Re: [libvirt] [PATCHv2] fix failure when building with --disable-debug

2012-07-12 Thread Eric Blake
On 07/11/2012 07:28 PM, Hu Tao wrote: # define VIR_DEBUG_INT(category, f, l, ...)\ -do { } while (0) +virLogEatParam((void*)category, f, l, __VA_ARGS__) Any reason we have to use a cast, instead of just creating our eat function with the correct type parameter in the first

Re: [libvirt] [PATCH 0/5]dnsmasq SRV/TXT RR and Host xml parsing upgrade and bug fix

2012-07-12 Thread Guannan Ren
On 07/09/2012 02:44 PM, Guannan Ren wrote: On 07/08/2012 06:53 PM, Guannan Ren wrote: The set of patches aims to three kind of jobs. First, for SRV RR, in order to strictly comform to RFC 2782, the patch changed and upgraded codes in following parts. The format of SRV RR:

[libvirt] [PATCH] Fix daemon auto-spawning

2012-07-12 Thread Christophe Fergeau
Commit 32a9aac switched libvirt to use the XDG base directories to locate most of its data/config. In particular, the per-user socket for qemu:///session is now stored in the XDG runtime directory. This directory is located by looking at the XDG_RUNTIME_DIR environment variable, with a fallback to

Re: [libvirt] trying to build 0.9.13 on F17: cannot find -lcrypto

2012-07-12 Thread Christophe Fergeau
Hey, On Wed, Jul 11, 2012 at 03:42:20PM +0100, Daniel P. Berrange wrote: On Wed, Jul 11, 2012 at 10:23:21AM -0400, Cole Robinson wrote: I think this comes from rbd support, from configure.ac: LIBRBD_LIBS=-lrbd -lrados -lcrypto from this commit:

Re: [libvirt] [PATCH] Fix daemon auto-spawning

2012-07-12 Thread Daniel P. Berrange
On Thu, Jul 12, 2012 at 02:09:33PM +0200, Christophe Fergeau wrote: Commit 32a9aac switched libvirt to use the XDG base directories to locate most of its data/config. In particular, the per-user socket for qemu:///session is now stored in the XDG runtime directory. This directory is located by

Re: [libvirt] trying to build 0.9.13 on F17: cannot find -lcrypto

2012-07-12 Thread Daniel P. Berrange
On Thu, Jul 12, 2012 at 02:20:11PM +0200, Christophe Fergeau wrote: Hey, On Wed, Jul 11, 2012 at 03:42:20PM +0100, Daniel P. Berrange wrote: On Wed, Jul 11, 2012 at 10:23:21AM -0400, Cole Robinson wrote: I think this comes from rbd support, from configure.ac: LIBRBD_LIBS=-lrbd

Re: [libvirt] [PATCH] Fix daemon auto-spawning

2012-07-12 Thread Christophe Fergeau
On Thu, Jul 12, 2012 at 01:23:15PM +0100, Daniel P. Berrange wrote: --- src/rpc/virnetsocket.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c index 0b32ffe..08dfbb0 100644 --- a/src/rpc/virnetsocket.c +++

Re: [libvirt] [PATCH v8 2/8] parallels: add functions to list domains and get info

2012-07-12 Thread Peter Krempa
On 07/04/12 19:42, Dmitry Guryanov wrote: PARALLELS driver is 'stateless', like vmware or openvz drivers. It collects information about domains during startup using command-line utility prlctl. VMs in PARALLELS are identified by UUIDs or unique names, which can be used as respective fields in

Re: [libvirt] [PATCH v8 3/8] parallels: implement functions for domain life cycle management

2012-07-12 Thread Peter Krempa
On 07/04/12 19:42, Dmitry Guryanov wrote: Add functions for create/shutdown/destroy and suspend/resume domain. Signed-off-by: Dmitry Guryanov dgurya...@parallels.com --- src/parallels/parallels_driver.c | 149 ++ src/parallels/parallels_driver.h |1 +

[libvirt] [PATCH] Clarify direct migration

2012-07-12 Thread Jiri Denemark
When --direct is used when migrating a domain running on a hypervisor that does not support direct migration (such as QEMU), the caller would get the following error message: this function is not supported by the connection driver: virDomainMigrateToURI2 which is a complete nonsense

[libvirt] [PATCH] ARMHF: CPU Support for armhf.

2012-07-12 Thread Chuck Short
Adding CPU encoder/decoder for armhf to avoid runtime error messages. Signed-off-by: Chuck Short chuck.sh...@canonical.com --- src/Makefile.am |1 + src/cpu/cpu.c |2 ++ src/cpu/cpu_arm.c | 76 + src/cpu/cpu_arm.h | 32

Re: [libvirt] [PATCH] ARMHF: CPU Support for armhf.

2012-07-12 Thread Jiri Denemark
On Thu, Jul 12, 2012 at 10:58:12 -0400, Chuck Short wrote: Adding CPU encoder/decoder for armhf to avoid runtime error messages. Can you be more specific about the error messages you are trying to fix with this patch? Signed-off-by: Chuck Short chuck.sh...@canonical.com --- src/Makefile.am

Re: [libvirt] [PATCH] ARMHF: CPU Support for armhf.

2012-07-12 Thread Chuck Short
On Thu, 12 Jul 2012 17:09:27 +0200 Jiri Denemark jdene...@redhat.com wrote: On Thu, Jul 12, 2012 at 10:58:12 -0400, Chuck Short wrote: Adding CPU encoder/decoder for armhf to avoid runtime error messages. Can you be more specific about the error messages you are trying to fix with this

[libvirt] [PATCH 0/2] Avoid touching monitor when fetching guest XML or info

2012-07-12 Thread Guannan Ren
The virDomainGetXMLDesc and virDomainGetInfo APIs for QEMU suffer from needing to run 'query-balloon' to update the balloon level. This has caused us performance problems and even worse caused us to lock up on a dead QEMU. The following two patches to QEMU add a BALLOON_EVENT and a query-events

[libvirt] [PATCH 1/2] Define public API for receiving guest memory balloon events

2012-07-12 Thread Guannan Ren
From: Daniel P. Berrange berra...@redhat.com When the guest changes its memory balloon applications may want to know what the new value is, without having to periodically poll on XML / domain info. Introduce a balloon change event to let apps see this * include/libvirt/libvirt.h.in: Define the

[libvirt] [PATCH 2/2] Wire up handling for QMP's BALLOON_EVENT

2012-07-12 Thread Guannan Ren
From: Daniel P. Berrange berra...@redhat.com If QEMU supports the BALLOON_EVENT QMP event, then we can avoid invoking 'query-balloon' when returning XML or the domain info. * src/qemu/qemu_capabilities.c, src/qemu/qemu_capabilities.h: Add QEMU_CAPS_BALLOON_EVENT * src/qemu/qemu_driver.c: Skip

[libvirt] [PATCH] ARMHF: CPU Support for armhf.

2012-07-12 Thread Chuck Short
Adding CPU encoder/decoder for armhf to avoid runtime error messages. Signed-off-by: Chuck Short chuck.sh...@canonical.com --- src/Makefile.am |1 + src/cpu/cpu.c |2 ++ src/cpu/cpu_arm.c | 76 + src/cpu/cpu_arm.h | 32

Re: [libvirt] [PATCH] ARMHF: CPU Support for armhf.

2012-07-12 Thread Daniel P. Berrange
On Thu, Jul 12, 2012 at 10:28:17AM -0500, Chuck Short wrote: Adding CPU encoder/decoder for armhf to avoid runtime error messages. Signed-off-by: Chuck Short chuck.sh...@canonical.com --- src/Makefile.am |1 + src/cpu/cpu.c |2 ++ src/cpu/cpu_arm.c | 76

Re: [libvirt] [PATCH 0/2] Avoid touching monitor when fetching guest XML or info

2012-07-12 Thread Daniel P. Berrange
On Thu, Jul 12, 2012 at 11:45:55PM +0800, Guannan Ren wrote: The virDomainGetXMLDesc and virDomainGetInfo APIs for QEMU suffer from needing to run 'query-balloon' to update the balloon level. This has caused us performance problems and even worse caused us to lock up on a dead QEMU. The

Re: [libvirt] [glib PATCH V4] Add bindings for virDomainSave*()

2012-07-12 Thread Zeeshan Ali (Khattak)
Only 3 issues, 2 very small ones. On Thu, Jul 12, 2012 at 7:39 AM, Jovanka Gulicoska jovanka.gulico...@gmail.com wrote: --- libvirt-gobject/libvirt-gobject-domain.c | 152 ++ libvirt-gobject/libvirt-gobject-domain.h | 18

[libvirt] [PATCH] ARMHF: CPU Support for armhf.

2012-07-12 Thread Chuck Short
Adding CPU encoder/decoder for armhf to avoid runtime error messages. Signed-off-by: Chuck Short chuck.sh...@canonical.com --- src/Makefile.am |1 + src/cpu/cpu.c |2 ++ src/cpu/cpu_arm.c | 75 + src/cpu/cpu_arm.h | 31

Re: [libvirt] [PATCH] Clarify direct migration

2012-07-12 Thread Eric Blake
On 07/12/2012 08:23 AM, Jiri Denemark wrote: When --direct is used when migrating a domain running on a hypervisor that does not support direct migration (such as QEMU), the caller would get the following error message: this function is not supported by the connection driver:

Re: [libvirt] [PATCH 1/2] Define public API for receiving guest memory balloon events

2012-07-12 Thread Eric Blake
On 07/12/2012 09:45 AM, Guannan Ren wrote: From: Daniel P. Berrange berra...@redhat.com When the guest changes its memory balloon applications may want to know what the new value is, without having to periodically poll on XML / domain info. Introduce a balloon change event to let apps see

Re: [libvirt] [PATCH 1/2] Define public API for receiving guest memory balloon events

2012-07-12 Thread Eric Blake
On 07/12/2012 09:45 AM, Guannan Ren wrote: From: Daniel P. Berrange berra...@redhat.com When the guest changes its memory balloon applications may want to know what the new value is, without having to periodically poll on XML / domain info. Introduce a balloon change event to let apps see

Re: [libvirt] [PATCH 2/2] Wire up handling for QMP's BALLOON_EVENT

2012-07-12 Thread Eric Blake
On 07/12/2012 09:45 AM, Guannan Ren wrote: From: Daniel P. Berrange berra...@redhat.com If QEMU supports the BALLOON_EVENT QMP event, then we can avoid invoking 'query-balloon' when returning XML or the domain info. ACK. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt

Re: [libvirt] Libvirt iSCSI APIs

2012-07-12 Thread Ata Bohra
Please see comments inline. Date: Thu, 12 Jul 2012 10:34:32 +0100 From: berra...@redhat.com To: ata.hus...@hotmail.com CC: libvirt-l...@redhat.com Subject: Re: [libvirt] Libvirt iSCSI APIs On Wed, Jul 11, 2012 at 05:28:07PM -0700, Ata Bohra wrote: Hi All, I am

[libvirt] [PATCH v3] esx: Extend esxVI_CURL_Download for partial downloads

2012-07-12 Thread Matthias Bolte
Also ensure that the virBuffer used to store the downloaded data does not overflow. --- v3: - Fix virBuffer limit checks. v2: - Ensure that the used virBuffer dos not overflow. src/esx/esx_driver.c |2 +- src/esx/esx_vi.c | 62 +++--

[libvirt] [glib PATCH V5] Add bindings for virDomainSave*()

2012-07-12 Thread Jovanka Gulicoska
--- libvirt-gobject/libvirt-gobject-domain.c | 153 ++ libvirt-gobject/libvirt-gobject-domain.h | 18 libvirt-gobject/libvirt-gobject.sym |3 + 3 files changed, 174 insertions(+) diff --git a/libvirt-gobject/libvirt-gobject-domain.c

Re: [libvirt] [glib PATCH V5] Add bindings for virDomainSave*()

2012-07-12 Thread Zeeshan Ali (Khattak)
I could only see one issue this time that I should have seen before: On Fri, Jul 13, 2012 at 3:13 AM, Jovanka Gulicoska jovanka.gulico...@gmail.com wrote: --- libvirt-gobject/libvirt-gobject-domain.c | 153 ++ libvirt-gobject/libvirt-gobject-domain.h | 18

[libvirt] [glib PATCH V6] Add bindings for virDomainSave*()

2012-07-12 Thread Jovanka Gulicoska
--- libvirt-gobject/libvirt-gobject-domain.c | 147 ++ libvirt-gobject/libvirt-gobject-domain.h | 18 libvirt-gobject/libvirt-gobject.sym |3 + 3 files changed, 168 insertions(+) diff --git a/libvirt-gobject/libvirt-gobject-domain.c

Re: [libvirt] Unable to make libvirt

2012-07-12 Thread B Veera-B37207
Hi, Platform : Power PC When I am doing make V=1 libtool: link: gcc -std=gnu99 -shared -fPIC -DPIC -Wl,--whole-archive ./.libs/libvirt_util.a ./.libs/libvirt_conf.a ./.libs/libvirt_cpu.a ./.libs/libvirt_v mx.a ./.libs/libvirt_driver.a ./.libs/libvirt_driver_test.a

[libvirt] [glib PATCH V6] Add bindings for virDomainRestore*()

2012-07-12 Thread Jovanka Gulicoska
--- libvirt-gobject/libvirt-gobject-connection.c | 137 ++ libvirt-gobject/libvirt-gobject-connection.h | 20 libvirt-gobject/libvirt-gobject-domain.c | 22 ++--- libvirt-gobject/libvirt-gobject-domain.h | 10 ++ libvirt-gobject/libvirt-gobject.sym