Re: [libvirt] [PATCH] pci: Save and restore each devices/functions behind the bus

2012-09-06 Thread Daniel Veillard
On Mon, Sep 03, 2012 at 04:57:01PM +0800, Osier Yang wrote: Previously it refuses to do the secondary bus reset as long as there is(are) devices/functions behind the same bus, regardless of whether the devices/functions are being used or not. And it only save and restore the device itself's

Re: [libvirt] [PATCH V4] implement offline migration

2012-09-06 Thread Kamezawa Hiroyuki
(2012/09/06 14:32), liguang wrote: Hello, Eric Daniel 在 2012-09-05三的 11:08 -0600,Eric Blake写道: On 09/05/2012 02:48 AM, Daniel P. Berrange wrote: I really don't like the general design of this patch, even ignoring all the code bugs. I think this entire patch is really just a solution in

Re: [libvirt] [PATCH v0] qemu: Add sandbox support.

2012-09-06 Thread Daniel Veillard
On Mon, Sep 03, 2012 at 02:03:39PM +0200, Ján Tomko wrote: QEMU (since 1.2-rc0) supports setting up a syscall whitelist through libseccomp on linux kernel from 3.5-rc1. This is enabled by specifying -sandbox on on qemu command line. This patch detects this capability by searching for

Re: [libvirt] [PATCH v0] qemu: Add sandbox support.

2012-09-06 Thread Daniel Veillard
On Thu, Sep 06, 2012 at 02:27:19PM +0800, Daniel Veillard wrote: On Mon, Sep 03, 2012 at 02:03:39PM +0200, Ján Tomko wrote: QEMU (since 1.2-rc0) supports setting up a syscall whitelist through libseccomp on linux kernel from 3.5-rc1. This is enabled by specifying -sandbox on on qemu command

[libvirt] Bug:libvirtd boot up blocked in NAT network setup

2012-09-06 Thread Wenchao Xia
Hello, guys I met a strange problem in libvirt+kvm massive deployment case. What shows is that libvirtd will not respond to any virsh calls, with debug I found that libvirtd was blocked at the step to setup default nat network, that is command iptables -table nat x. In terminal, I found

Re: [libvirt] Compile libvirt on Solaris

2012-09-06 Thread Daniel Veillard
On Tue, Sep 04, 2012 at 04:26:55AM +, Yang Zhou (yangzho) wrote: Hi Experts, I am compiling libvirt 0.9.9 on Solaris 9. But got following errors when run ./configure --with-esx --with-qemu

Re: [libvirt] [PATCH] Define DYNLIB_NAME on OpenBSD.

2012-09-06 Thread Daniel Veillard
On Tue, Sep 04, 2012 at 04:56:13PM +0200, Jasper Lievisse Adriaanse wrote: From 05dd99030d865127c874d1b489b9c17412bdbb3b Mon Sep 17 00:00:00 2001 From: Jasper Lievisse Adriaanse jas...@humppa.nl Date: Tue, 4 Sep 2012 16:48:51 +0200 Subject: [PATCH] Define DYNLIB_NAME on OpenBSD. ---

Re: [libvirt] [PATCH] build: improved handling of execinfo.h, BSD net/if.h

2012-09-06 Thread Daniel Veillard
On Wed, Sep 05, 2012 at 04:39:28PM -0600, Eric Blake wrote: FreeBSD and OpenBSD have a net/if.h that is not self-contained; and mingw lacks the header altogether. But gnulib has just taken care of that for us, so we might as well simplify our code. In the process, I got a syntax-check

Re: [libvirt] Libvir JNA report SIGSEGV

2012-09-06 Thread Daniel Veillard
On Wed, Sep 05, 2012 at 08:59:07AM +, Benjamin Wang (gendwang) wrote: Hi, I try to verify the JNA with concurrent situation but meet some problems. The following is my example code: public static void testcase1() throws LibvirtException { Connect conn=null;

Re: [libvirt] Libvir JNA report SIGSEGV

2012-09-06 Thread Benjamin Wang (gendwang)
Hi, The problem only occurs in JNA part. The pure c libvirt works well. Even If I only create a connection outside of the loop, the problem can still happen. The following is the easiest problem to reproduce this problem public static void testcase1() throws LibvirtException {

[libvirt] [libvirt-java] Upload 0.4.8 to central Maven repository

2012-09-06 Thread Wido den Hollander
Hi, At the CloudStack project we are switching to Maven for building and resolving external dependencies. In the central Maven repository [0] the latest version of libvirt-java is however 0.4.7 Could 0.4.8 be uploaded to this repository? Thank you, Wido [0]:

Re: [libvirt] [libvirt-java] Upload 0.4.8 to central Maven repository

2012-09-06 Thread Daniel Veillard
On Thu, Sep 06, 2012 at 10:18:22AM +0200, Wido den Hollander wrote: Hi, At the CloudStack project we are switching to Maven for building and resolving external dependencies. In the central Maven repository [0] the latest version of libvirt-java is however 0.4.7 Could 0.4.8 be uploaded

Re: [libvirt] Compile libvirt on Solaris

2012-09-06 Thread Daniel P. Berrange
On Thu, Sep 06, 2012 at 03:22:12PM +0800, Daniel Veillard wrote: On Tue, Sep 04, 2012 at 04:26:55AM +, Yang Zhou (yangzho) wrote: Hi Experts, I am compiling libvirt 0.9.9 on Solaris 9. But got following errors when run ./configure --with-esx --with-qemu

Re: [libvirt] Compile libvirt on Solaris

2012-09-06 Thread Yang Zhou (yangzho)
Thanks for your answer! I realized actually I don't need to compile QEMU driver because the libvirt client is using Remote driver to talk with libvirtd and then libvirtd will call QUME driver in KVM hypervisor. So I removed the --with-qume and trying compiling again only with --with-esx. This

Re: [libvirt] Libvir JNA report SIGSEGV

2012-09-06 Thread Daniel Veillard
On Thu, Sep 06, 2012 at 07:53:24AM +, Benjamin Wang (gendwang) wrote: Hi, The problem only occurs in JNA part. The pure c libvirt works well. Even If I only create a connection outside of the loop, the problem can still happen. The following is the easiest problem to reproduce this

Re: [libvirt] Libvir JNA report SIGSEGV

2012-09-06 Thread Benjamin Wang (gendwang)
Hi, Actually I also did another test as following. When I comment the new Connet, the program works well. So this is the problem related to Libvirt JNA. If I manually run the garbage collection for this program, it still works well. But if I run the garbage collection for the last problem, It

Re: [libvirt] [PATCHv6 0/2] Implementation of virConnectListAllDomains() for esx and hyperv

2012-09-06 Thread Peter Krempa
On 09/06/12 07:24, Daniel Veillard wrote: On Fri, Aug 31, 2012 at 05:36:51PM +0200, Peter Krempa wrote: Yet another respin updated and rebased to current head. Both drivers are compile tested but I don't have the infrastructure do a functional test. Peter Krempa (2): hyperv: Add

[libvirt] [PATCH v2 0/9] improve virBitmap

2012-09-06 Thread Hu Tao
In many places we store bitmap info in a chunk of data (pointed to by a char *), and have redundant codes to set/unset bits. This series extends virBitmap, and convert those codes to use virBitmap. changes: v2: - fix bug in qemuSetupCgroupForEmulator - new function virBitmapNextSetBit -

[libvirt] [PATCH v2 3/9] use virBitmap to store cpupin info

2012-09-06 Thread Hu Tao
--- src/conf/domain_conf.c | 148 +++--- src/conf/domain_conf.h |6 +- src/libvirt_private.syms |1 + src/qemu/qemu_cgroup.c |3 +- src/qemu/qemu_driver.c | 29 + src/qemu/qemu_process.c | 21 --- 6 files changed, 81

[libvirt] [PATCH v2 6/9] use virBitmap to store cpumask info.

2012-09-06 Thread Hu Tao
--- src/conf/domain_conf.c | 24 +--- src/conf/domain_conf.h |3 +-- src/lxc/lxc_controller.c | 14 ++ src/parallels/parallels_driver.c |3 +-- src/qemu/qemu_process.c | 12 +--- src/test/test_driver.c

[libvirt] [PATCH v2 1/9] fix bug in qemuSetupCgroupForEmulator

2012-09-06 Thread Hu Tao
Should not return 0 when failed to setup cgroup. --- src/qemu/qemu_cgroup.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index 5b42793..c95cc77 100644 --- a/src/qemu/qemu_cgroup.c +++ b/src/qemu/qemu_cgroup.c @@

[libvirt] [PATCH v2 2/9] New functions for virBitmap

2012-09-06 Thread Hu Tao
In many places we store bitmap info in a chunk of data (pointed to by a char *), and have redundant codes to set/unset bits. This patch extends virBitmap, and convert those codes to use virBitmap in subsequent patches. --- .gitignore |1 + src/libvirt_private.syms | 11 ++

[libvirt] [PATCH v2 4/9] use virBitmap to store cpu affinity info

2012-09-06 Thread Hu Tao
--- src/lxc/lxc_controller.c | 23 + src/qemu/qemu_driver.c | 62 - src/qemu/qemu_process.c | 86 -- src/util/processinfo.c | 36 ++- src/util/processinfo.h |9 ++--- 5 files

[libvirt] [PATCH v2 7/9] use virBitmap to store cells' cpumask info.

2012-09-06 Thread Hu Tao
--- src/conf/cpu_conf.c | 17 ++--- src/conf/cpu_conf.h |3 ++- src/qemu/qemu_command.c | 43 +++ 3 files changed, 15 insertions(+), 48 deletions(-) diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c index 87e9540..9fe93e6

Re: [libvirt] NFS over RDMA small block DIRECT_IO bug

2012-09-06 Thread Andrew Holway
On Sep 5, 2012, at 4:02 PM, Avi Kivity wrote: On 09/04/2012 03:04 PM, Myklebust, Trond wrote: On Tue, 2012-09-04 at 11:31 +0200, Andrew Holway wrote: Hello. # Avi Kivity avi(a)redhat recommended I copy kvm in on this. It would also seem relevent to libvirt. # I have a Centos 6.2

[libvirt] [PATCH v2 8/9] use virBitmap to store nodeinfo.

2012-09-06 Thread Hu Tao
--- src/nodeinfo.c | 26 +++--- src/nodeinfo.h |6 +++--- src/qemu/qemu_driver.c | 19 --- 3 files changed, 26 insertions(+), 25 deletions(-) diff --git a/src/nodeinfo.c b/src/nodeinfo.c index e3d4a24..e6b259d 100644 ---

[libvirt] [PATCH v2 5/9] use virBitmap to store numa nodemask info.

2012-09-06 Thread Hu Tao
--- src/conf/domain_conf.c | 24 +--- src/conf/domain_conf.h |2 +- src/lxc/lxc_controller.c | 25 src/parallels/parallels_driver.c |2 +- src/qemu/qemu_cgroup.c |7 ++--- src/qemu/qemu_cgroup.h |2 +-

[libvirt] [PATCH v2 9/9] remove virDomainCpuSetFormat and virDomainCpuSetParse

2012-09-06 Thread Hu Tao
virBitmap is recommanded to store cpuset info, and virBitmapFormat/virBitmapParse can do the format/parse jobs. --- src/conf/domain_conf.c | 196 -- src/conf/domain_conf.h |7 -- src/libvirt_private.syms |2 - 3 files changed, 205

Re: [libvirt] Libvir JNA report SIGSEGV

2012-09-06 Thread Daniel Veillard
On Thu, Sep 06, 2012 at 09:06:14AM +, Benjamin Wang (gendwang) wrote: Hi, Actually I also did another test as following. When I comment the new Connet, the program works well. So this is the problem related to Libvirt JNA. If I manually run the garbage collection for this program, it

[libvirt] An introduction to the libvirt-designer library

2012-09-06 Thread Daniel P. Berrange
People might have noticed Michal's patches[1] for the libvirt-designer and wondered wtf.com that is. This is an attempt to explain it... If you are familiar with the code in virt-install (also used by virt-manager) you'll know it has a bunch of internal classes / APIs for dealing with libvirt

[libvirt] [PATCH] events: Fix domain event race on client disconnect

2012-09-06 Thread Christophe Fergeau
GNOME Boxes sometimes stops getting domain events from libvirtd, even after restarting it. Further investigation in libvirtd shows that events are properly queued with virDomainEventStateQueue, but the timer virDomainEventTimer which flushes the events and sends them to the clients never gets

Re: [libvirt] [PATCH 1/1 V2] Migrate per-port data for Open vSwitch ports during Qemu Live Migration

2012-09-06 Thread Kyle Mestery (kmestery)
On Sep 6, 2012, at 12:35 AM, Daniel Veillard wrote: On Tue, Sep 04, 2012 at 04:35:24PM -0400, Kyle Mestery wrote: Add the ability to migrate per-port data on Open vSwitch ports during qemu live migration. A controller can use this to store data relating to each port, and have it migrated with

Re: [libvirt] Libvir JNA report SIGSEGV

2012-09-06 Thread Benjamin Wang (gendwang)
Hi, I have looked into the code for several days. But I didn't find the root cause. Because even if I only call new Connect, the problem will occur. So this should be related to Connect.java or ConnectAuthDefault.java. Would you take a quick at the issue and give some prompt? Then I can try

Re: [libvirt] RFC: take two on live update of network configuration

2012-09-06 Thread Daniel P. Berrange
On Tue, Aug 21, 2012 at 11:26:08PM -0400, Laine Stump wrote: We need a way to update the elements of a network without being required to restart the network before the changes take effect. I had previously thought I could just use a new virNetworkDefineXMLFlags with an optional flag set to

Re: [libvirt] NFS over RDMA small block DIRECT_IO bug

2012-09-06 Thread Myklebust, Trond
On Thu, 2012-09-06 at 12:14 +0200, Andrew Holway wrote: On Sep 5, 2012, at 4:02 PM, Avi Kivity wrote: On 09/04/2012 03:04 PM, Myklebust, Trond wrote: On Tue, 2012-09-04 at 11:31 +0200, Andrew Holway wrote: Hello. # Avi Kivity avi(a)redhat recommended I copy kvm in on this. It would

Re: [libvirt] [PATCH 09/10 v5] list: Use virConnectListAllStoragePools in virsh

2012-09-06 Thread Osier Yang
On 2012年09月06日 01:17, Laine Stump wrote: On 09/05/2012 12:52 PM, Eric Blake wrote: On 09/05/2012 12:36 AM, Osier Yang wrote: +++ b/tools/virsh-pool.c @@ -36,6 +36,7 @@ #include memory.h #include util.h #include xml.h +#include conf/storage_conf.h I'm not sure if virsh is supposed to be

Re: [libvirt] [PATCH V3] Add proxy FS support to libvirt

2012-09-06 Thread Daniel P. Berrange
On Thu, Aug 23, 2012 at 02:36:40PM +0530, M. Mohan Kumar wrote: From: M. Mohan Kumar mo...@in.ibm.com A new FS driver type 'proxy' is added to QEMU 9p server. This patch adds support for using proxy FS driver from libvirt. QEMU proxy FS driver uses socket for communicating between helper

[libvirt] [PATCHv3 0/4] Add range checking for scheduler tunables

2012-09-06 Thread Peter Krempa
This version improves virsh so that it doesn't update all tunables but only those that changed (and now correctly). This series contains a new patch that adds a helper to deal with typed parameters. Regarding typed parameters: Shouldn't we make the helpers to deal with them public? (Patches 1

[libvirt] [PATCHv3 2/4] qemu: Add range checking for scheduler tunables when changed by API

2012-09-06 Thread Peter Krempa
The quota and period tunables for cpu scheduler accept only a certain range of values. When changing the live configuration invalid values get rejected. This check is not performed when changing persistent config. This patch adds a separate range check, that improves error messages when changing

[libvirt] [PATCHv3 1/4] qemu: clean up qemuSetSchedulerParametersFlags()

2012-09-06 Thread Peter Krempa
This patch tries to clean the code up a little bit and shorten very long lines. The apparent semantic change from moving the condition before calling the setter function is a non-issue here as the setter function is a no-op when called with both arguments zero. --- src/qemu/qemu_driver.c | 69

[libvirt] [PATCHv3 3/4] util: Add helper to assign typed params from string

2012-09-06 Thread Peter Krempa
This patch adds a helper to deal with assigning values to virTypedParameter structures from strings. The helper parses the value from the string and assigns it to the corresponding union value. --- New in series. --- src/libvirt_private.syms | 1 + src/util/virtypedparam.c | 97

[libvirt] [PATCHv3 4/4] virsh: Update only changed scheduler tunables

2012-09-06 Thread Peter Krempa
When setting the cpu tunables in virsh you are able to update only a subset of them. Virsh while doing the update updated all of the tunables, changed ones with new values and unchanged with old ones. This is unfortunate as it: a) might overwrite some other change by a race condition (unprobable)

Re: [libvirt] [RFC] [PATCH v2 1/6] add configure option --with-fuse for libvirt

2012-09-06 Thread Glauber Costa
On 09/06/2012 05:53 AM, Gao feng wrote: 于 2012年09月05日 20:42, Daniel P. Berrange 写道: On Wed, Sep 05, 2012 at 05:41:40PM +0800, Gao feng wrote: Hi Daniel Glauber 于 2012年07月31日 17:27, Daniel P. Berrange 写道: Hi Gao, I'm wondering if you are planning to attend the Linux Plumbers Conference in

Re: [libvirt] [PATCH 1/6] list: Define new API virConnectListAllSecrets

2012-09-06 Thread Osier Yang
On 2012年09月05日 22:57, Eric Blake wrote: On 09/05/2012 12:28 AM, Osier Yang wrote: This is to list the secret objects. No flags are supported Any reason we aren't allowing a filter on ephemeral=yes/no and private=yes/no from the secret XML? Just because of I didn't notice those two

[libvirt] [PATCH] Fix location of SELinux mount during RPM builds

2012-09-06 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com When building RPMs the host kernel cannot be assumed to match the target OS kernel. Thus auto-detecting /selinux vs /sys/fs/selinux based on the host kernel can result in the wrong choice (eg F18 builds on a RHEL6 host kernel) --- libvirt.spec.in | 10

[libvirt] [PATCH] Don't assume use of /sys/fs/cgroup

2012-09-06 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The introduction of /sys/fs/cgroup came in fairly recent kernels. Prior to that time distros would pick a custom directory like /cgroup or /dev/cgroup. We need to auto-detect where this is, rather than hardcoding it --- src/lxc/lxc_container.c | 71

Re: [libvirt] [PATCH 2/5] list: Implement RPC calls for virConnectListAllNWFilters

2012-09-06 Thread Peter Krempa
On 09/05/12 08:02, Osier Yang wrote: The RPC generator doesn't support returning list of object yet, this patch do the work manually. * daemon/remote.c: Implemente the server side handler remoteDispatchConnectListAllNWFilters. * src/remote/remote_driver.c: Add remote driver

Re: [libvirt] [PATCH 06/10] list: Add helper to convert strings separated by ', ' to array

2012-09-06 Thread Osier Yang
On 2012年09月06日 00:24, Eric Blake wrote: On 09/04/2012 09:16 AM, Osier Yang wrote: tools/virsh.c: New helper function vshStringToArray. tools/virsh.h: Declare vshStringToArray. tools/virsh-domain.c: use the helper in cmdUndefine. --- tools/virsh-domain.c | 19 ++-

Re: [libvirt] [PATCH 0/5 v4] Atomic API to list network filters

2012-09-06 Thread Peter Krempa
On 09/05/12 08:02, Osier Yang wrote: v3 - v4: * Just rebase on the top, and split the patches from v3's large set. Osier Yang (5): list: Define new API virConnectListAllNWFilters list: Implement RPC calls for virConnectListAllNWFilters list: Implement listAllNWFilters list:

Re: [libvirt] [PATCH 08/10] list: Change MATCH for common use in virsh

2012-09-06 Thread Osier Yang
On 2012年09月06日 00:30, Eric Blake wrote: On 09/04/2012 09:16 AM, Osier Yang wrote: Move definition of MATCH from virsh-domain-monitor.c into virsh.h for further use. --- tools/virsh-domain-monitor.c |2 -- tools/virsh.h|2 ++ 2 files changed, 2 insertions(+), 2

Re: [libvirt] [PATCH 5/5] list: Use virConnectListAllNWFilters in virsh

2012-09-06 Thread Peter Krempa
On 09/05/12 08:02, Osier Yang wrote: tools/virsh-nwfilter.c: * vshNWFilterSorter to sort network filters by name * vshNWFilterListFree to free the network filter objects list. * vshNWFilterListCollect to collect the network filter objects, trying to use new API first, fall back

Re: [libvirt] [PATCH 09/10 v5] list: Use virConnectListAllStoragePools in virsh

2012-09-06 Thread Osier Yang
On 2012年09月06日 00:52, Eric Blake wrote: On 09/05/2012 12:36 AM, Osier Yang wrote: tools/virsh-pool.c: * vshStoragePoolSorter to sort the pool list by pool name. * struct vshStoragePoolList to present the pool list, pool info is collected by list-poolinfo if 'details' is specified by

Re: [libvirt] [libvirt-java] Upload 0.4.8 to central Maven repository

2012-09-06 Thread Wido den Hollander
On 09/06/2012 10:38 AM, Daniel Veillard wrote: On Thu, Sep 06, 2012 at 10:18:22AM +0200, Wido den Hollander wrote: Hi, At the CloudStack project we are switching to Maven for building and resolving external dependencies. In the central Maven repository [0] the latest version of libvirt-java

[libvirt] [PATCH] Remove duplicate symbols and add test case

2012-09-06 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com When the event symbols were added to the public API, not all of them were removed from the private exports list. Solaris gets unhappy when there are duplicated symbols. Extend the symfile check to test for this scenario --- src/check-symfile.pl |

Re: [libvirt] Compile libvirt on Solaris

2012-09-06 Thread Daniel P. Berrange
On Thu, Sep 06, 2012 at 08:46:33AM +, Yang Zhou (yangzho) wrote: Thanks for your answer! I realized actually I don't need to compile QEMU driver because the libvirt client is using Remote driver to talk with libvirtd and then libvirtd will call QUME driver in KVM hypervisor. So I

Re: [libvirt] [PATCH v4 00/10] Atomic API to list storage pools

2012-09-06 Thread Osier Yang
On 2012年09月04日 23:16, Osier Yang wrote: Think the subject tells enough after 3 rounds, so ommits words here. v3 - v4: * Just rebase on the top: - Version changes - rebase after virsh split cleanups 1/10 ~ 2/10 are ACK'ed in v3, but for easy viewing, they are still posted. Osier

Re: [libvirt] [PATCH] Remove duplicate symbols and add test case

2012-09-06 Thread Osier Yang
On 2012年09月06日 22:47, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com When the event symbols were added to the public API, not all of them were removed from the private exports list. Solaris gets unhappy when there are duplicated symbols. Extend the symfile check to test

Re: [libvirt] [PATCH] Remove duplicate symbols and add test case

2012-09-06 Thread Laine Stump
On 09/06/2012 10:47 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com When the event symbols were added to the public API, not all of them were removed from the private exports list. Solaris gets unhappy when there are duplicated symbols. Extend the symfile check to

[libvirt] [PATCH 1/4] Fix docs for PM event callbacks

2012-09-06 Thread Jiri Denemark
PM{Suspend,Wakeup} event callbacks were designed with a reason parameter which could be used in the future. However, we do not transfer the reason over RPC and thus we can never use it in the future. Make it explicit in the docs. --- include/libvirt/libvirt.h.in | 6 ++ 1 file changed, 2

Re: [libvirt] [libvirt-java] Upload 0.4.8 to central Maven repository

2012-09-06 Thread Wido den Hollander
On 09/06/2012 05:04 PM, Daniel Veillard wrote: On Thu, Sep 06, 2012 at 04:47:45PM +0200, Wido den Hollander wrote: On 09/06/2012 10:38 AM, Daniel Veillard wrote: I added libvirt.org as a manual repository and while fetching the dependencies I saw: [INFO] snapshot

[libvirt] [PATCH 3/4] Add PMSUSPENDED life cycle event

2012-09-06 Thread Jiri Denemark
While PMSUSPENDED state was added a long time ago, we didn't have corresponding life cycle event. --- examples/domain-events/events-c/event-test.c | 10 ++ examples/domain-events/events-python/event-test.py | 4 +++- include/libvirt/libvirt.h.in | 14

[libvirt] [PATCH 0/4] Fix PM events

2012-09-06 Thread Jiri Denemark
PM related events suffered from quite a lot of issues. The only thing that actually worked was STARTED life cycle event with WAKEUP detail. Jiri Denemark (4): Fix docs for PM event callbacks Fix PMSuspend and PMWakeup events Add PMSUSPENDED life cycle event examples: Fix event detail

Re: [libvirt] [libvirt-java] Upload 0.4.8 to central Maven repository

2012-09-06 Thread Daniel Veillard
On Thu, Sep 06, 2012 at 04:47:45PM +0200, Wido den Hollander wrote: On 09/06/2012 10:38 AM, Daniel Veillard wrote: I added libvirt.org as a manual repository and while fetching the dependencies I saw: [INFO] snapshot org.apache.cloudstack:xapi:5.6.100-1-SNAPSHOT: checking for updates from

[libvirt] [PATCH 4/4] examples: Fix event detail printing in python test

2012-09-06 Thread Jiri Denemark
If there is only one detail string for a particular event, we need to pu comma after the string otherwise the string itself will be taken as a list and only its first character will be printed out. For example, myDomainEventCallback1 EVENT: Domain fedora17(12) Shutdown F instead of the

[libvirt] [PATCH 2/4] Fix PMSuspend and PMWakeup events

2012-09-06 Thread Jiri Denemark
The unused reason parameter of PM{Suspend,Wakeup} event callbacks was completely ignored in lot of places and those events were not actually working at all. --- daemon/remote.c | 2 ++ examples/domain-events/events-c/event-test.c | 4 ++-- python/libvirt-override.c

Re: [libvirt] [PATCH] Define DYNLIB_NAME on OpenBSD.

2012-09-06 Thread Eric Blake
On 09/06/2012 01:39 AM, Daniel Veillard wrote: On Tue, Sep 04, 2012 at 04:56:13PM +0200, Jasper Lievisse Adriaanse wrote: From 05dd99030d865127c874d1b489b9c17412bdbb3b Mon Sep 17 00:00:00 2001 From: Jasper Lievisse Adriaanse jas...@humppa.nl Date: Tue, 4 Sep 2012 16:48:51 +0200 Subject:

Re: [libvirt] [RFC PATCH v1 1/2] Qemu/Gluster: Add Gluster protocol as supported network disk formats.

2012-09-06 Thread Bharata B Rao
On Wed, Sep 5, 2012 at 8:45 PM, Eric Blake ebl...@redhat.com wrote: On 09/05/2012 09:08 AM, Bharata B Rao wrote: On Wed, Sep 5, 2012 at 7:03 PM, Jiri Denemark jdene...@redhat.com wrote: @@ -1042,6 +1043,13 @@ attribute name=port ref

Re: [libvirt] [libvirt-java] Upload 0.4.8 to central Maven repository

2012-09-06 Thread Daniel Veillard
On Thu, Sep 06, 2012 at 05:08:21PM +0200, Wido den Hollander wrote: On 09/06/2012 05:04 PM, Daniel Veillard wrote: On Thu, Sep 06, 2012 at 04:47:45PM +0200, Wido den Hollander wrote: A tcpdump shows me it is looking for: * libvirt-0.4.8.pom.md5 * libvirt-0.4.8.pom.sha1 *

[libvirt] [PATCH] list: fix typo in virsh patch

2012-09-06 Thread Eric Blake
A last minute rename in an earlier patch to virsh.h was not properly reflected when rebasing virsh-pool.c. * tools/virsh-pool.c (vshStoragePoolListCollect): Use VSH_MATCH, not MATCH. --- Pushing under the build-breaker rule. tools/virsh-pool.c | 30 +++--- 1 file

Re: [libvirt] [PATCH] Remove duplicate symbols and add test case

2012-09-06 Thread Eric Blake
On 09/06/2012 08:47 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com When the event symbols were added to the public API, not all of them were removed from the private exports list. Solaris gets unhappy when there are duplicated symbols. Extend the symfile check to

Re: [libvirt] [PATCH v0] qemu: Add sandbox support.

2012-09-06 Thread Corey Bryant
On 09/06/2012 02:45 AM, Daniel Veillard wrote: On Thu, Sep 06, 2012 at 02:27:19PM +0800, Daniel Veillard wrote: On Mon, Sep 03, 2012 at 02:03:39PM +0200, Ján Tomko wrote: QEMU (since 1.2-rc0) supports setting up a syscall whitelist through libseccomp on linux kernel from 3.5-rc1. This is

Re: [libvirt] [PATCH 1/1 V2] Migrate per-port data for Open vSwitch ports during Qemu Live Migration

2012-09-06 Thread Laine Stump
On 09/04/2012 04:35 PM, Kyle Mestery wrote: Add the ability to migrate per-port data on Open vSwitch ports during qemu live migration. A controller can use this to store data relating to each port, and have it migrated with the virtual machine and populated on the destination host. Good job

Re: [libvirt] [PATCH v0] qemu: Add sandbox support.

2012-09-06 Thread Corey Bryant
On 09/06/2012 02:27 AM, Daniel Veillard wrote: On Mon, Sep 03, 2012 at 02:03:39PM +0200, Ján Tomko wrote: QEMU (since 1.2-rc0) supports setting up a syscall whitelist through libseccomp on linux kernel from 3.5-rc1. This is enabled by specifying -sandbox on on qemu command line. This patch

[libvirt] need help/clarification about git and patches.

2012-09-06 Thread Gene Czarcinski
Using git is more than a little different way of doing business for me. My usual way to create and apply a patch is to rebuild a src.rpm. This way I have a lot less changes of screwing something up because of ignorance. It it a little while but I finally cloned a copy of libvirt.git. I

[libvirt] [PATCH] remove dnsmasq command line parameter --filterwin2k

2012-09-06 Thread Gene Czarcinski
This patch removed the --filterwin2k dnsmasq command line parameter which was unnecessary for domain specification, possibly blocked some usage, and was command line clutter. Gene Czarcinski g...@czarc.net diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index

Re: [libvirt] need help/clarification about git and patches.

2012-09-06 Thread Eric Blake
On 09/06/2012 09:59 AM, Gene Czarcinski wrote: Using git is more than a little different way of doing business for me. My usual way to create and apply a patch is to rebuild a src.rpm. This way I have a lot less changes of screwing something up because of ignorance. It it a little while

Re: [libvirt] [PATCH] build: improved handling of execinfo.h, BSD net/if.h

2012-09-06 Thread Eric Blake
On 09/06/2012 01:41 AM, Daniel Veillard wrote: On Wed, Sep 05, 2012 at 04:39:28PM -0600, Eric Blake wrote: FreeBSD and OpenBSD have a net/if.h that is not self-contained; and mingw lacks the header altogether. But gnulib has just taken care of that for us, so we might as well simplify our

[libvirt] [libvirt-designer][PATCH 3/4] virtxml: Detect OS from given ISO

2012-09-06 Thread Michal Privoznik
In some cases telling OS version is redundant as ISO image with specified OS is passed some arguments later as disk. Don't require --os then. --- examples/virtxml.c | 76 --- 1 files changed, 71 insertions(+), 5 deletions(-) diff --git

[libvirt] [libvirt-designer][PATCH 0/4] Yet another functional extension

2012-09-06 Thread Michal Privoznik
This time aimed on virtxml tool to make it user friendlier a little bit. Michal Privoznik (4): Implement resources setting Cleanup double error setting and operating on empty list virtxml: Detect OS from given ISO virtxml: Detect platform from libvirt connection URI examples/virtxml.c

[libvirt] [libvirt-designer][PATCH 4/4] virtxml: Detect platform from libvirt connection URI

2012-09-06 Thread Michal Privoznik
as in nearly all cases users will install the guest on current libvirt we've just obtained capabilities from. --- examples/virtxml.c | 119 ++- 1 files changed, 88 insertions(+), 31 deletions(-) diff --git a/examples/virtxml.c b/examples/virtxml.c

[libvirt] [libvirt-designer][PATCH 1/4] Implement resources setting

2012-09-06 Thread Michal Privoznik
Users can choose between minimum and recommended values for VCPU count and amount of RAM. Moreover, recommended values should inherit defaults from the minimum. --- examples/virtxml.c | 27 +++- libvirt-designer/libvirt-designer-domain.c | 98

[libvirt] [libvirt-designer][PATCH 2/4] Cleanup double error setting and operating on empty list

2012-09-06 Thread Michal Privoznik
and virtio disks can be advertised as PCI bus devices. --- libvirt-designer/libvirt-designer-domain.c | 15 --- 1 files changed, 12 insertions(+), 3 deletions(-) diff --git a/libvirt-designer/libvirt-designer-domain.c b/libvirt-designer/libvirt-designer-domain.c index

Re: [libvirt] need help/clarification about git and patches.

2012-09-06 Thread Daniel P. Berrange
On Thu, Sep 06, 2012 at 11:59:10AM -0400, Gene Czarcinski wrote: Using git is more than a little different way of doing business for me. My usual way to create and apply a patch is to rebuild a src.rpm. This way I have a lot less changes of screwing something up because of ignorance. It

[libvirt] SCSI command passthrough

2012-09-06 Thread Geert Jansen
Hi, i'm trying to pass through SCSI commands from a guest to a host. Both guest and host are RHEL 6.3. The relevant section in my XML is: devices disk type='block' device='lun' driver name='qemu' type='raw' cache='none'/ source dev='/dev/sdb'/ target dev='sdb'

Re: [libvirt] [PATCH] remove dnsmasq command line parameter --filterwin2k

2012-09-06 Thread Eric Blake
On 09/06/2012 10:08 AM, Gene Czarcinski wrote: This patch removed the --filterwin2k dnsmasq command line parameter which was unnecessary for domain specification, possibly blocked some usage, and was command line clutter. Gene Czarcinski g...@czarc.net ACK and pushed. 'git am'

[libvirt] [PATCH] docs: point out git send-email location, be more stern about make check

2012-09-06 Thread Laine Stump
An email came to libvir-list wondering why the git send-email command was missing in spite of having git installed; this is due to the send-email command being in a sub-package of the main git package. While touching the hacking file, I thought it would be useful to 1) indicate the location of

Re: [libvirt] need help/clarification about git and patches.

2012-09-06 Thread Laine Stump
On 09/06/2012 11:59 AM, Gene Czarcinski wrote: Using git is more than a little different way of doing business for me. My usual way to create and apply a patch is to rebuild a src.rpm. This way I have a lot less changes of screwing something up because of ignorance. My experience is the

Re: [libvirt] [PATCH 1/1 V2] Migrate per-port data for Open vSwitch ports during Qemu Live Migration

2012-09-06 Thread Daniel P. Berrange
On Thu, Sep 06, 2012 at 11:58:52AM -0400, Laine Stump wrote: On 09/04/2012 04:35 PM, Kyle Mestery wrote: Add the ability to migrate per-port data on Open vSwitch ports during qemu live migration. A controller can use this to store data relating to each port, and have it migrated with the

Re: [libvirt] [PATCH] remove dnsmasq command line parameter --filterwin2k

2012-09-06 Thread Gene Czarcinski
On 09/06/2012 01:00 PM, Eric Blake wrote: On 09/06/2012 10:08 AM, Gene Czarcinski wrote: This patch removed the --filterwin2k dnsmasq command line parameter which was unnecessary for domain specification, possibly blocked some usage, and was command line clutter. Gene Czarcinski

Re: [libvirt] need help/clarification about git and patches.

2012-09-06 Thread Laine Stump
On 09/06/2012 12:53 PM, Daniel P. Berrange wrote: FYI in case you don't already know, you can also run libvirt builds directly from the source tree, rather than needing to run 'make intsall' or install an updated RPM every time. my usual way of working is to just stop the libvirtd process

Re: [libvirt] [PATCH] docs: point out git send-email location, be more stern about make check

2012-09-06 Thread Jiri Denemark
On Thu, Sep 06, 2012 at 13:24:24 -0400, Laine Stump wrote: An email came to libvir-list wondering why the git send-email command was missing in spite of having git installed; this is due to the send-email command being in a sub-package of the main git package. While touching the hacking

Re: [libvirt] need help/clarification about git and patches.

2012-09-06 Thread Gene Czarcinski
Rather than cluttering up the mailing list, I am going to combine the helpful replies into a single response. I am going to edit this to reduce clutter. On 09/06/2012 01:26 PM, Laine Stump wrote: On 09/06/2012 11:59 AM, Gene Czarcinski wrote: Using git is more than a little different way of

Re: [libvirt] [PATCH 1/7] list: Define new API virConnectListAllNodeDevices

2012-09-06 Thread Peter Krempa
On 09/05/12 07:34, Osier Yang wrote: This is to list the node device objects, supports to filter the results by capability types. include/libvirt/libvirt.h.in: Declare enum virConnectListAllNodeDeviceFlags and virConnectListAllNodeDevices. python/generator.py:

Re: [libvirt] [PATCH 2/7] list: Implemente RPC calls for virConnectListAllNodeDevices

2012-09-06 Thread Peter Krempa
s/Implemente/Implement/ in subject On 09/05/12 07:34, Osier Yang wrote: The RPC generator doesn't support returning list of object yet, this patch do the work manually. s/do/does/ * daemon/remote.c: Implemente the server side handler remoteDispatchConnectListAllNodeDevices. *

Re: [libvirt] [PATCH 3/7] list: Add helpers for listing node devices

2012-09-06 Thread Peter Krempa
On 09/05/12 07:34, Osier Yang wrote: src/conf/node_device_conf.h: * New macro VIR_CONNECT_LIST_NODE_DEVICES_FILTERS_CAP * Declare virNodeDeviceList src/conf/node_device_conf.c: * New helpers virNodeDeviceCapMatch, virNodeDeviceMatch. virNodeDeviceCapMatch looks up the list of all

Re: [libvirt] [PATCH 3/7] list: Add helpers for listing node devices

2012-09-06 Thread Peter Krempa
On 09/06/12 22:40, Peter Krempa wrote: index 7464c59..43928f1 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -852,6 +852,7 @@ virPortGroupFindByName; # node_device_conf.h +a; Is this related directly to this API adition? If not, split it out. (Do a separate patch

Re: [libvirt] RFC: take two on live update of network configuration

2012-09-06 Thread Eric Blake
On 09/06/2012 07:43 AM, Daniel P. Berrange wrote: === OPTION 3) Again, a single API, but with an added nodespec arg which would be used to describe the parent node you of the node you want added/updated to: 3) Can you think of a situation where this wouldn't work? In a libvirt

Re: [libvirt] [PATCH 4/7] list: Implement listAllNodeDevices

2012-09-06 Thread Peter Krempa
On 09/05/12 07:34, Osier Yang wrote: This simply implements listAllNodeDevices using helper virNodeDeviceList src/node_device/node_device_driver.h: * Declare nodeListAllNodeDevices. src/node_device/node_device_driver.c: * Implement nodeListAllNodeDevices.

Re: [libvirt] [PATCH 1/5] list: Define new API virConnectListAllNWFilters

2012-09-06 Thread Eric Blake
On 09/05/2012 12:02 AM, Osier Yang wrote: This is to list the network fitler objects. No flags are supported s/fitler/filter/ +/** + * virConnectListAllNWFilters: + * @conn: Pointer to the hypervisor connection. + * @filters: Pointer to a variable to store the array containing the

Re: [libvirt] [PATCH 5/7] list: Expose virConnectListAllNodeDevices to Python binding

2012-09-06 Thread Peter Krempa
On 09/05/12 07:34, Osier Yang wrote: The implementation is done manually as the generator does not support wrapping lists of C pointers into Python objects. python/libvirt-override-api.xml: Document python/libvirt-override-virConnect.py: * Implementation for listAllNodeDevices.

  1   2   >