Re: [libvirt] [PATCH] spec: Fix script warning when uninstalling libvirt-client

On 2012年12月18日 07:38, Cole Robinson wrote: https://bugzilla.redhat.com/show_bug.cgi?id=888071 --- libvirt.spec.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 7457a48..a5dce14 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@

Re: [libvirt] [PATCH 5/5] docs: aesthetical cleanups

On 2012年12月17日 23:17, Martin Kletzander wrote: Removing "exempli gratia" when there should be dots afterwards, also Uppercase letter should be present when starting a sentence. Sorry for the double line in the last hunk even though it's just adding a word, but it would require to have new senten

Re: [libvirt] [PATCH 4/5] conf: eliminate redundant use of VIR_ALLOC

On 2012年12月17日 23:17, Martin Kletzander wrote: We can use VIR_REALLOC_N with NULL pointer, which behaves the same way as VIR_ALLOC_N in that case, so no need for a condition that's checking if some data are allocated already. --- I tried to find other parts of the code similar to this, so I can

Re: [libvirt] [PATCH 3/5] conf: Don't format cputune element when not needed

On 2012年12月17日 23:17, Martin Kletzander wrote: Commit 60b176c3d0f0d5037acfa5e27c7753f657833a0b introduced a bug that when editing an XML with cputune similar to this: Thanks for fixing this. ... 2 ... results in formatted XML that looks like this: ... 2 ... Tha

Re: [libvirt] [PATCH 2/5] conf: minor indentation cleanups

On 2012年12月17日 23:17, Martin Kletzander wrote: On few places there are too many levels of indentation when some of them can be fixed with negating the option they are in or omitting useless condition altogether. --- src/conf/domain_conf.c | 65 +-

Re: [libvirt] [PATCH] Fix parsing of vendor_id

(2012/12/17 20:07), Peter Krempa wrote: On 12/17/12 09:05, Ken ICHIKAWA wrote: I have a problem about parsing vendor_id of domain XML. When define vendor_id attribute, why definition of fallback attribute is needed? I explain below for example. (I used virsh edit.) Current domain xml state is l

[libvirt] [PATCH] spec: Fix script warning when uninstalling libvirt-client

https://bugzilla.redhat.com/show_bug.cgi?id=888071 --- libvirt.spec.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 7457a48..a5dce14 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1605,8 +1605,9 @@ fi /sbin/chkconfig --add l

Re: [libvirt] [PATCH 5/5] qemu: Implement virDomainOpenChannel API

On Thu, Dec 13, 2012 at 11:24:20AM -0500, John Eckersberg wrote: > --- > src/qemu/qemu_driver.c | 73 > ++ > 1 file changed, 73 insertions(+) > > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c > index 441272d..bcd9c57 100644 > --- a/s

Re: [libvirt] [PATCH 4/5] conf: Add unix socket support to virChrdevOpen

On Thu, Dec 13, 2012 at 11:24:19AM -0500, John Eckersberg wrote: > This also changes the function signature to take a > virDomainChrSourceDefPtr instead of just a path, since it needs to > differentiate behavior based on source->type. > --- > src/conf/virchrdev.c | 38 +++

Re: [libvirt] [PATCH 3/5] conf: Rename console-specific identifiers to be more generic

On Thu, Dec 13, 2012 at 11:24:18AM -0500, John Eckersberg wrote: > The functionality provided in virchrdev.c (previously virconsole.c) is > applicable to other types of character devices besides consoles, such > as channels. This patch is just code motion, renaming things such as > "console" or "p

Re: [libvirt] [PATCH 2/5] conf: Rename virconsole.* to virchrdev.*

On Thu, Dec 13, 2012 at 11:24:17AM -0500, John Eckersberg wrote: > This is just code motion, in preparation to rename identifiers to be > less console-specific. > --- > po/POTFILES.in | 2 +- > src/Makefile.am | 2 +- > src/conf/virchrdev.c | 414 > +

Re: [libvirt] [PATCH 1/5] api: Add API to tunnel a guest channel via stream

On Thu, Dec 13, 2012 at 11:24:16AM -0500, John Eckersberg wrote: > This patch adds a new API, virDomainOpenChannel, that uses streams to > connect to a virtio channel on a guest. This creates a secure > communication channel between a guest and a libvirt client. > > This behaves the same as virDo

[libvirt] [Test] Add API to tunnel channels

Attached is a simple test program to exercise virDomainOpenChannel that echoes a toupper()'d string and exits. Edit the #defines as necessary to match your setup. You'll need a channel defined in the guest similar to: Run the test, and then inside of the VM, you should b

Re: [libvirt] [PATCH] hostusb: Move USB_DEVFS define to hostusb.h to fix the build

On Mon, Dec 17, 2012 at 02:42:54PM -0500, Cole Robinson wrote: > --- > > Pushed since it's a trivial build breaker > > src/util/hostusb.c | 1 - > src/util/hostusb.h | 2 ++ > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/util/hostusb.c b/src/util/hostusb.c > index 24f925

Re: [libvirt] [PATCH 00/28] Rename files in src/util to have a 'vir' prefix

On 17.12.2012 15:57, Daniel P. Berrange wrote: > Currently the files in src/util are 50/50 split between those > having a 'vir' prefix and those which don't. Finish the job > by remaining all remaining files to have a 'vir' prefix too, > guaranteeing that they can't clash with system headers[1]. >

Re: [libvirt] [PATCH 25/28] Rename uuid.{c,h} to viruuid.{c,h}

On 17.12.2012 15:57, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > --- > daemon/libvirtd.c| 4 +- > daemon/remote.c | 2 +- > src/Makefile.am | 2 +- > src/conf/capabilities.c | 2 +- > src/conf/devic

Re: [libvirt] libvirt-1.0.1 and F18 problem

On 12/17/2012 07:18 AM, Gene Czarcinski wrote: I am sure this not just a 1.0.1 problem and there appears to be a bugzilla report on it: https://bugzilla.redhat.com/show_bug.cgi?id=869625 Given a F17 host and a F18 host, there is significantly different behavior when running a guest (in my case

Re: [libvirt] [PATCH] network: don't require private addresses if dnsmasq uses SO_BINDTODEVICE

> This is yet another refinement to the fix for CVE-2012-3411: > >https://bugzilla.redhat.com/show_bug.cgi?id=833033 > > It turns out that it would be very intrusive to correctly backport > the > entire --bind-dynamic option to older dnsmasq versions > (e.g. dnsmasq-2.48 that is used on RHEL6

Re: [libvirt] [PATCH] build: Fix AUTHORS generation

On Fri, Dec 14, 2012 at 09:41:44 -0700, Eric Blake wrote: > On 12/14/2012 08:19 AM, Jiri Denemark wrote: > > Using s/#authorslist#/$$out/ makes perl eat @domain part of all email > > addresses from $out since it tries to interpret them as array variables. > > I'm not sure if we can escape those in

[libvirt] [PATCH] apparmor: Fix build

--- Pushed as a trivial build-breaker. src/security/virt-aa-helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index 888c416..86fd5c4 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-hel

[libvirt] [PATCH] hostusb: Move USB_DEVFS define to hostusb.h to fix the build

--- Pushed since it's a trivial build breaker src/util/hostusb.c | 1 - src/util/hostusb.h | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/util/hostusb.c b/src/util/hostusb.c index 24f925b..2eb80a0 100644 --- a/src/util/hostusb.c +++ b/src/util/hostusb.c @@ -38,7 +38,6

[libvirt] [PATCH] .gitignore: add tests/sysinfotest

--- Pushed since it's trivial .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 32ae8a7..0557d59 100644 --- a/.gitignore +++ b/.gitignore @@ -164,6 +164,7 @@ /tests/ssh /tests/statstest /tests/storagebackendsheepdogtest +/tests/sysinfotest /tests/ut

[libvirt] [PATCH] spec: Do not install *.py[co] in python examples

Unfortunately, rpm is stupid enough to bytycompile python scripts even though they are located in /usr/share/doc/libvirt-python-*/examples and it does so after %install phase is finished. Thus there's no way we could remove those files from BUILDROOT. As a workaround, we may safely remove the examp

Re: [libvirt] [PATCH] daemon: Preface polkit error output with 'polkit:'

On 12/16/2012 06:31 PM, Peter Krempa wrote: > On 12/17/12 00:15, Cole Robinson wrote: >> There's been a few bugs about an expected error from polkit: >> >> https://bugzilla.redhat.com/show_bug.cgi?id=873799 >> https://bugzilla.redhat.com/show_bug.cgi?id=872166 >> >> The error is: >> >> Authorizatio

[libvirt] [PATCH v2] FreeBSD: add nodeinfo support.

Uses sysctl(3) interface to obtain CPU and memory information. --- src/nodeinfo.c | 62 +- 1 file changed, 61 insertions(+), 1 deletion(-) diff --git a/src/nodeinfo.c b/src/nodeinfo.c index 096000b..d5fc73e 100644 --- a/src/nodeinfo.c +++ b/

[libvirt] [PATCH] network: don't require private addresses if dnsmasq uses SO_BINDTODEVICE

This is yet another refinement to the fix for CVE-2012-3411: https://bugzilla.redhat.com/show_bug.cgi?id=833033 It turns out that it would be very intrusive to correctly backport the entire --bind-dynamic option to older dnsmasq versions (e.g. dnsmasq-2.48 that is used on RHEL6.x and CentOS 6.

Re: [libvirt] [PATCHv3 2/3] S390: Fix virSysinfoRead memory corruption

On Fri, Dec 14, 2012 at 04:08:24PM +0100, Viktor Mihajlovski wrote: > There was a double free issue caused by virSysinfoRead on s390, > as the same manufacturer string instance was assigned to more > than one processor record. > Cleaned up other potential memory issues and restructured the sysinfo

Re: [libvirt] [PATCHv3 3/3] tests: Add tests for sysinfo

On Fri, Dec 14, 2012 at 04:08:25PM +0100, Viktor Mihajlovski wrote: > Test cases for virSysinfoRead. Initially, there are tests for > x86 (DMI based) and s390 (/proc/... based). > In lack of PPC data, I have stubbed out the test for it, but it > can be added with a minimal effort. Cool, top marks

Re: [libvirt] Network XML Description

Thank you Laine. That makes good sense for not including it in the XML. On Mon, Dec 17, 2012 at 9:52 PM, Laine Stump wrote: > On 12/17/2012 05:09 AM, Fawad Khaliq wrote: > > Hi all, > > > > The XML description of a network does not contain information of the > > Domains (VMs) plugged into a netw

Re: [libvirt] Network XML Description

On Mon, Dec 17, 2012 at 9:52 PM, Laine Stump wrote: > On 12/17/2012 05:09 AM, Fawad Khaliq wrote: > > Hi all, > > > > The XML description of a network does not contain information of the > > Domains (VMs) plugged into a network. For example, there is a network > > named 'default' and there are tw

Re: [libvirt] [PATCH 2/2] FreeBSD: stub out CPU affinity functions.

On Mon, Dec 17, 2012 at 09:09:52PM +0400, Roman Bogorodskiy wrote: > Daniel P. Berrange wrote: > > > On Sun, Dec 16, 2012 at 06:47:56PM +0400, Roman Bogorodskiy wrote: > > > --- > > > src/util/processinfo.c | 22 ++ > > > 1 file changed, 22 insertions(+) > > > > > > diff --

Re: [libvirt] [PATCH 20/23] Add support for hotplug/unplug of host storage devices in LXC

On Fri, Dec 14, 2012 at 07:44:33PM +0800, Gao feng wrote: > On 2012/12/01 04:26, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > > > Wire up the attach/detach device drivers in LXC to support the > > hotplug/unplug of host storage devices. > > > > Signed-off-by: Daniel P. Berrange

Re: [libvirt] [PATCH 18/23] Add support for hotplug/unplug of NIC devices in LXC

On Fri, Dec 14, 2012 at 08:06:49PM +0800, Gao feng wrote: > On 2012/12/01 04:26, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > +case VIR_DOMAIN_NET_TYPE_NETWORK: { > > +virNetworkPtr network; > > +char *brname = NULL; > > +bool fail = false; > > +

Re: [libvirt] [PATCH 14/23] Add support for attach/detach/update net devices in config for LXC

On Fri, Dec 14, 2012 at 04:56:50PM +0800, Gao feng wrote: > On 2012/12/01 04:26, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > > > Wire up the attach/detach/update device APIs to support changing > > of network interfaces in the persistent config file > > > > Signed-off-by: Daniel

Re: [libvirt] [PATCH 10/23] Add support for USB host device passthrough with LXC

On Fri, Dec 14, 2012 at 03:31:39PM +0800, Gao feng wrote: > On 2012/12/01 04:26, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > > > This adds support for host device passthrough with the > > LXC driver. Since there is only a single kernel image, > > it doesn't make sense to pass thr

Re: [libvirt] [PATCH 2/2] FreeBSD: stub out CPU affinity functions.

Daniel P. Berrange wrote: > On Sun, Dec 16, 2012 at 06:47:56PM +0400, Roman Bogorodskiy wrote: > > --- > > src/util/processinfo.c | 22 ++ > > 1 file changed, 22 insertions(+) > > > > diff --git a/src/util/processinfo.c b/src/util/processinfo.c > > index b1db049..4822bcc 10

Re: [libvirt] [PATCH 03/23 v2] Add support for

On Mon, Dec 17, 2012 at 11:58:05AM -0500, Eric Blake wrote: > > The device type has long had a redundant "mode" > > attribute, which has always been "subsys". This finally > > introduces a new mode "capabilities", which will be used > > by the LXC driver for device assignment. Since container > >

Re: [libvirt] [PATCH 0/6] Use enum for tracking valid architectures

On Tue, Dec 11, 2012 at 11:36:35PM +0800, Daniel Veillard wrote: > On Tue, Dec 11, 2012 at 02:53:35PM +, Daniel P. Berrange wrote: > > Different operating systems have different names for architectures. > > eg x86_64 x64, amd64. This can cause inconsistency in libvirt code > > dealing with arch

Re: [libvirt] [PATCH 03/23 v2] Add support for

> The device type has long had a redundant "mode" > attribute, which has always been "subsys". This finally > introduces a new mode "capabilities", which will be used > by the LXC driver for device assignment. Since container > based virtualization uses a single kernel, the idea of > assigning phy

Re: [libvirt] Network XML Description

On 12/17/2012 05:09 AM, Fawad Khaliq wrote: > Hi all, > > The XML description of a network does not contain information of the > Domains (VMs) plugged into a network. For example, there is a network > named 'default' and there are two domains named: domainA and domainB. > The Network XML descriptio

Re: [libvirt] [PATCH 21/28] Rename sysinfo.{c, h} to virsysinfo.{c, h}

On Mon, Dec 17, 2012 at 04:45:04PM +0100, Viktor Mihajlovski wrote: > On 12/17/2012 03:57 PM, Daniel P. Berrange wrote: > >From: "Daniel P. Berrange" > > > >--- > > po/POTFILES.in |2 +- > > src/Makefile.am|2 +- > > src/conf/domain_conf.h |2 +- > > src/qemu/qemu_driv

Re: [libvirt] [PATCH 00/28] Rename files in src/util to have a 'vir' prefix

On Mon, Dec 17, 2012 at 04:45:59PM +0100, Michal Privoznik wrote: > On 17.12.2012 15:57, Daniel P. Berrange wrote: > > Currently the files in src/util are 50/50 split between those > > having a 'vir' prefix and those which don't. Finish the job > > by remaining all remaining files to have a 'vir' p

Re: [libvirt] [PATCH 00/28] Rename files in src/util to have a 'vir' prefix

On 17.12.2012 15:57, Daniel P. Berrange wrote: > Currently the files in src/util are 50/50 split between those > having a 'vir' prefix and those which don't. Finish the job > by remaining all remaining files to have a 'vir' prefix too, > guaranteeing that they can't clash with system headers[1]. >

Re: [libvirt] [PATCH 21/28] Rename sysinfo.{c, h} to virsysinfo.{c, h}

On 12/17/2012 03:57 PM, Daniel P. Berrange wrote: From: "Daniel P. Berrange" --- po/POTFILES.in |2 +- src/Makefile.am|2 +- src/conf/domain_conf.h |2 +- src/qemu/qemu_driver.c |2 +- src/util/sysinfo.c | 1045 --

[libvirt] [PATCH] build: libvirt-guests files misplaced in specfile

In a non-systemd environment the post and preun scripts of libvirt-client fail, since the required files are in libvirt-daemon. Moved them to client. One curious thing: %{_unitdir}/libvirt-guests.service was contained in both libvirt-client and libvirt-daemon. I removed the extra copy from daemon.

Re: [libvirt] [PATCH v2 00/11] Rework storage migration

On 10.12.2012 20:27, Michal Privoznik wrote: > This patch set re-implements migration with storage for enough new qemu. > Currently, you can migrate a domain to a host without need for shared storage. > This is done by setting 'blk' or 'inc' attribute (representing > VIR_MIGRATE_NON_SHARED_DISK and

Re: [libvirt] [PATCH 1/5] fix typo in the word affinities

On 2012年12月17日 23:17, Martin Kletzander wrote: This patch fixes just the word Affinites to Affinities (it's really painful to search in TAGS without being able to find the right function). --- src/libxl/libxl_driver.c | 4 ++-- src/qemu/qemu_process.c | 8 2 files changed, 6 inserti

[libvirt] [PATCH 3/5] conf: Don't format cputune element when not needed

Commit 60b176c3d0f0d5037acfa5e27c7753f657833a0b introduced a bug that when editing an XML with cputune similar to this: ... 2 ... results in formatted XML that looks like this: ... 2 ... That is caused by a condition depending on def->cputune.vcpupin being set rather than c

[libvirt] [PATCH 4/5] conf: eliminate redundant use of VIR_ALLOC

We can use VIR_REALLOC_N with NULL pointer, which behaves the same way as VIR_ALLOC_N in that case, so no need for a condition that's checking if some data are allocated already. --- I tried to find other parts of the code similar to this, so I can do a full cleanup for the whole repository, so I

[libvirt] [PATCH 5/5] docs: aesthetical cleanups

Removing "exempli gratia" when there should be dots afterwards, also Uppercase letter should be present when starting a sentence. Sorry for the double line in the last hunk even though it's just adding a word, but it would require to have new sentence starting on a newline and that didn't seem ver

[libvirt] [PATCH 2/5] conf: minor indentation cleanups

On few places there are too many levels of indentation when some of them can be fixed with negating the option they are in or omitting useless condition altogether. --- src/conf/domain_conf.c | 65 +- 1 file changed, 32 insertions(+), 33 deletions(-)

[libvirt] [PATCH 1/5] fix typo in the word affinities

This patch fixes just the word Affinites to Affinities (it's really painful to search in TAGS without being able to find the right function). --- src/libxl/libxl_driver.c | 4 ++-- src/qemu/qemu_process.c | 8 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/libxl/libxl

[libvirt] [PATCH 0/5] Miscellaneous cleanups

My cleanup branch got up to 5 commits so in order to get rid of it, I'm sending it. Some of them could be most probably pushed as trivial, but since some are older (even though the commit date is new), I'm sending it in the pack together. Martin Kletzander (5): fix typo in the word affinities

[libvirt] [PATCH 19/28] Rename stats_linux.{c, h} to virstatslinux.{c, h}

From: "Daniel P. Berrange" --- po/POTFILES.in | 2 +- src/Makefile.am| 2 +- src/lxc/lxc_driver.c | 2 +- src/openvz/openvz_driver.c | 2 +- src/qemu/qemu_driver.c | 2 +- src/uml/uml_driver.c | 2 +- src/util/stats_linux.c | 122 --

Re: [libvirt] No VirtualBox Driver

On Mon, Dec 17, 2012 at 7:56 PM, Peter Krempa wrote: > On 12/17/12 15:53, Arslan Waqar wrote: > >> >> >> >> On Mon, Dec 17, 2012 at 6:14 PM, Peter Krempa > > wrote: >> >> On 12/17/12 13:30, Arslan Waqar wrote: >> >> [...] >> >> >> >> I tried to to fetch

[libvirt] [PATCH 28/28] Sort util files in Makefile.am alphabetically

From: "Daniel P. Berrange" --- src/Makefile.am | 53 +++-- 1 file changed, 27 insertions(+), 26 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 0c77062..19a5b09 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -60,41 +60,27

[libvirt] [PATCH 25/28] Rename uuid.{c,h} to viruuid.{c,h}

From: "Daniel P. Berrange" --- daemon/libvirtd.c| 4 +- daemon/remote.c | 2 +- src/Makefile.am | 2 +- src/conf/capabilities.c | 2 +- src/conf/device_conf.c | 2 +- src/conf/domain_audit.c

[libvirt] [PATCH 22/28] Rename threadpool.{c, h} to virthreadpool.{c, h}

From: "Daniel P. Berrange" --- src/Makefile.am | 2 +- src/nwfilter/nwfilter_dhcpsnoop.c | 2 +- src/qemu/qemu_conf.h | 2 +- src/qemu/qemu_driver.c| 2 +- src/rpc/virnetserver.c| 2 +- src/util/threadpool.c | 371 -

Re: [libvirt] [PATCH 3/4] conf: cpu: Refactor parsing of vendor_id and fallback attributes

On 12/17/2012 12:22 PM, Peter Krempa wrote: > This patch simplifies the code that parses the fallback and vendor_id > attributes from the domain xml cpu definition. > > Changes done: > - free temp variables in the cleanup section instead of local use > - remove checking for presence of the attribu

Re: [libvirt] [PATCH 4/4] conf: cpu: Break some long lines

On 12/17/2012 12:22 PM, Peter Krempa wrote: > --- > src/conf/cpu_conf.c | 22 -- > 1 file changed, 12 insertions(+), 10 deletions(-) > ACK, Martin -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 18/28] Rename sexpr.{c,h} to virsexpr.{c,h}

From: "Daniel P. Berrange" --- cfg.mk | 2 +- po/POTFILES.in | 2 +- src/Makefile.am | 2 +- src/util/sexpr.c| 625 src/util/sexpr.h| 58 - src/util/virsexpr.c | 625

[libvirt] [PATCH 11/28] Rename hostusb.{c,h} to virusb.{c,h}

From: "Daniel P. Berrange" --- po/POTFILES.in | 2 +- src/Makefile.am | 2 +- src/qemu/qemu_cgroup.h | 2 +- src/qemu/qemu_conf.h | 2 +- src/qemu/qemu_driver.c | 2 +- src/qemu/qemu_hostdev.c | 2 +- src/sec

[libvirt] [PATCH 17/28] Merge processinfo.{c, h} into virprocess.{c, h}

From: "Daniel P. Berrange" --- po/POTFILES.in | 1 - src/Makefile.am | 1 - src/libvirt_private.syms | 7 +- src/lxc/lxc_controller.c | 3 +- src/qemu/qemu_driver.c | 14 ++-- src/qemu/qemu_process.c | 9 +-- src/util/processinfo.c | 189 ---

[libvirt] [PATCH 10/28] Rename hooks.{c,h} to virhooks.{c,h}

From: "Daniel P. Berrange" --- daemon/libvirtd.c | 2 +- po/POTFILES.in| 2 +- src/Makefile.am | 2 +- src/lxc/lxc_driver.c | 2 +- src/lxc/lxc_process.c | 2 +- src/qemu/qemu_driver.c| 2 +- src/qemu/qemu_migration.c | 2 +- src/qemu/qemu

[libvirt] [PATCH 02/28] Rename bitmap.{c,h} to virbitmap.{c,h}

From: "Daniel P. Berrange" Signed-off-by: Daniel P. Berrange --- src/Makefile.am | 2 +- src/conf/cpu_conf.h | 2 +- src/conf/domain_conf.c | 3 +- src/conf/domain_conf.h | 2 +- src/conf/network_conf.h | 2 +- src/conf/snapshot_conf.c | 2

[libvirt] [PATCH 08/28] Rename event.{c,h} to virevent.{c,h}

From: "Daniel P. Berrange" Since the event APIs are now in the public header, no internal code should include virevent.h --- src/Makefile.am | 2 +- src/rpc/virnetclientstream.c | 1 - src/rpc/virnetserver.c | 1 - src/rpc/virnetservermdns.c | 1 - src/rpc/virnetsock

[libvirt] [PATCH 06/28] Rename dnsmasq.{c,h} to virdnsmasq.{c,h}

From: "Daniel P. Berrange" --- po/POTFILES.in | 2 +- src/Makefile.am | 2 +- src/network/bridge_driver.c | 2 +- src/network/bridge_driver.h | 2 +- src/util/dnsmasq.c | 872 src/util/dnsmasq.h | 117

[libvirt] [PATCH 07/28] Rename ebtables.{c, h} to virebtables.{c, h}

From: "Daniel P. Berrange" --- src/Makefile.am | 2 +- src/qemu/qemu_bridge_filter.c | 2 +- src/qemu/qemu_conf.h | 2 +- src/util/ebtables.c | 486 -- src/util/ebtables.h | 67 -- src/util/virebtables.

[libvirt] [PATCH 00/28] Rename files in src/util to have a 'vir' prefix

Currently the files in src/util are 50/50 split between those having a 'vir' prefix and those which don't. Finish the job by remaining all remaining files to have a 'vir' prefix too, guaranteeing that they can't clash with system headers[1]. The only case which was not a plain rename, was merging

Re: [libvirt] No VirtualBox Driver

On 12/17/12 15:53, Arslan Waqar wrote: On Mon, Dec 17, 2012 at 6:14 PM, Peter Krempa mailto:pkre...@redhat.com>> wrote: On 12/17/12 13:30, Arslan Waqar wrote: [...] I tried to to fetch the Virtual Box 4.2 drivers code branch by running this command in termi

Re: [libvirt] [PATCH 2/4] conf: cpu: Fix memory leak when specifying cpu vendor_id manually

On 12/17/2012 12:22 PM, Peter Krempa wrote: > The field was not freed from the cpu definition. > --- > src/conf/cpu_conf.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c > index 6157ed7..7528980 100644 > --- a/src/conf/cpu_conf.c > +++ b/src/con

Re: [libvirt] [PATCH 1/4] conf: cpu: Fix parsing of vendor_id

On 12/17/2012 12:22 PM, Peter Krempa wrote: > From: Ken ICHIKAWA > > This patch fixes a problem that vendor_id attribute can not be defined > when fallback attribute is not defined. > > If I define domain xml like below: > > > core2duo > > > > In dumpxml, vendor_id is not reflected:

Re: [libvirt] No VirtualBox Driver

On Mon, Dec 17, 2012 at 6:14 PM, Peter Krempa wrote: > On 12/17/12 13:30, Arslan Waqar wrote: > > [...] > > > >> I tried to to fetch the Virtual Box 4.2 drivers code branch by running >> this command in terminal: >> > > sorry I got the URI wrong :/ > > Try this: > > git fetch > git://git.pipo.sk

Re: [libvirt] No VirtualBox Driver

On 12/17/12 13:30, Arslan Waqar wrote: [...] I tried to to fetch the Virtual Box 4.2 drivers code branch by running this command in terminal: sorry I got the URI wrong :/ Try this: git fetch git://git.pipo.sk/pipo/libvirt.git virtualbox-4.2 I got the following error: fatal: remote error

[libvirt] [PATCH 03/23 v2] Add support for

From: "Daniel P. Berrange" The device type has long had a redundant "mode" attribute, which has always been "subsys". This finally introduces a new mode "capabilities", which will be used by the LXC driver for device assignment. Since container based virtualization uses a single kernel, the idea

Re: [libvirt] No VirtualBox Driver

On 12/17/12 13:30, Arslan Waqar wrote: On Mon, Dec 17, 2012 at 3:06 PM, Peter Krempa mailto:pkre...@redhat.com>> wrote: On 12/17/12 09:07, Arslan Waqar wrote: Hey Peter, On Mon, Dec 17, 2012 at 12:42 PM, Peter Krempa mailto:pkre...@redhat.com>

Re: [libvirt] [PATCH 03/23] Add support for

On Fri, Dec 14, 2012 at 06:37:41PM +0800, Osier Yang wrote: > On 2012年12月01日 04:26, Daniel P. Berrange wrote: > >diff --git a/src/conf/domain_audit.c b/src/conf/domain_audit.c > >index 939d213..e61eabe 100644 > >--- a/src/conf/domain_audit.c > >+++ b/src/conf/domain_audit.c > >@@ -260,42 +260,72 @@

Re: [libvirt] No VirtualBox Driver

On Mon, Dec 17, 2012 at 3:06 PM, Peter Krempa wrote: > On 12/17/12 09:07, Arslan Waqar wrote: > >> >> Hey Peter, >> >> On Mon, Dec 17, 2012 at 12:42 PM, Peter Krempa > > wrote: >> >> On 12/17/12 07:40, Arslan Waqar wrote: >> >> Hi all, >> >> >> Hi Arslan

[libvirt] libvirt-1.0.1 and F18 problem

I am sure this not just a 1.0.1 problem and there appears to be a bugzilla report on it: https://bugzilla.redhat.com/show_bug.cgi?id=869625 Given a F17 host and a F18 host, there is significantly different behavior when running a guest (in my case a F18 guest). On F18, I cannot ssh or scp to

[libvirt] ANNOUNCE: New libosinfo project mailing list

Historically the libosinfo project has used virt-tools-l...@redhat.com for all its discussions. Since the project has grown and matured, it is time for a dedicated mailing list. If you are interested/involved with libosinfo, please subscribe to the new list: https://www.redhat.com/mailman/listin

Re: [libvirt] [PATCH 2/2] FreeBSD: stub out CPU affinity functions.

On Sun, Dec 16, 2012 at 06:47:56PM +0400, Roman Bogorodskiy wrote: > --- > src/util/processinfo.c | 22 ++ > 1 file changed, 22 insertions(+) > > diff --git a/src/util/processinfo.c b/src/util/processinfo.c > index b1db049..4822bcc 100644 > --- a/src/util/processinfo.c > +++ b

Re: [libvirt] [PATCH] Socket identity support for FreeBSD.

On Fri, Dec 14, 2012 at 10:06:33PM +0400, Roman Bogorodskiy wrote: > This adds an implementation of virNetSocketGetUNIXIdentity() > using LOCAL_PEERCRED socket option and xucred struct, defined > in on systems that have it. > --- > configure.ac | 3 ++- > src/rpc/virnetsocket.c | 30 ++

Re: [libvirt] [PATCH 0/5] Add API to tunnel channels

On Fri, Dec 14, 2012 at 12:05:31PM +0100, Michal Privoznik wrote: > On 13.12.2012 17:24, John Eckersberg wrote: > > This series enables the qemu driver to tunnel a virtio channel. This > > is useful for a remote session to communicate with a guest channel via > > the streaming API. > > > > This w

[libvirt] [PATCH 4/4] conf: cpu: Break some long lines

--- src/conf/cpu_conf.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c index e5695f4..41c5535 100644 --- a/src/conf/cpu_conf.c +++ b/src/conf/cpu_conf.c @@ -264,8 +264,9 @@ virCPUDefParseXML(const xmlNodePtr no

[libvirt] [PATCH 2/4] conf: cpu: Fix memory leak when specifying cpu vendor_id manually

The field was not freed from the cpu definition. --- src/conf/cpu_conf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c index 6157ed7..7528980 100644 --- a/src/conf/cpu_conf.c +++ b/src/conf/cpu_conf.c @@ -87,6 +87,7 @@ virCPUDefFree(virCPUDefPtr def)

[libvirt] [PATCH 0/4] Cleanup and fix parsing of vendor_id in the XML cpu definition

This patchset contains Ken ICHIKAWA's patch to fix parsing of vendor_id (with tweaked commit message) and my cleanups to pre-existing problems in the code which I found while reviewing Ken's patch. Ken ICHIKAWA (1): conf: cpu: Fix parsing of vendor_id Peter Krempa (3): conf: cpu: Fix memory l

[libvirt] [PATCH 1/4] conf: cpu: Fix parsing of vendor_id

From: Ken ICHIKAWA This patch fixes a problem that vendor_id attribute can not be defined when fallback attribute is not defined. If I define domain xml like below: core2duo In dumpxml, vendor_id is not reflected: core2duo The expected output is: core2duo I

[libvirt] [PATCH 3/4] conf: cpu: Refactor parsing of vendor_id and fallback attributes

This patch simplifies the code that parses the fallback and vendor_id attributes from the domain xml cpu definition. Changes done: - free temp variables in the cleanup section instead of local use - remove checking for presence of the attribute to directly getting the value (saving call to virXPat

Re: [libvirt] [PATCH] Fix parsing of vendor_id

On 12/17/12 09:05, Ken ICHIKAWA wrote: I have a problem about parsing vendor_id of domain XML. When define vendor_id attribute, why definition of fallback attribute is needed? I explain below for example. (I used virsh edit.) Current domain xml state is like below, And I redefine doma

Re: [libvirt] libvirt git doesn't know to use -no-kvm on qemu-kvm 1.2

On Sat, Dec 15, 2012 at 05:08:27PM -0500, Cole Robinson wrote: > Libvirt git isn't correctly starting plain qemu guests when using qemu-kvm 1.2 > (on Fedora 18). The problem is that -no-kvm is not passed to the binary, so > the default mode is used, which is kvm=enabled. > > The issue comes from c

[libvirt] Network XML Description

Hi all, The XML description of a network does not contain information of the Domains (VMs) plugged into a network. For example, there is a network named 'default' and there are two domains named: domainA and domainB. The Network XML description of 'default' network cannot tell what domains are plu

Re: [libvirt] No VirtualBox Driver

On 12/17/12 09:07, Arslan Waqar wrote: Hey Peter, On Mon, Dec 17, 2012 at 12:42 PM, Peter Krempa mailto:pkre...@redhat.com>> wrote: On 12/17/12 07:40, Arslan Waqar wrote: Hi all, Hi Arslan, I am new to the group and hence there might be a chance I might be

[libvirt] [PATCH] docs: Replace with in docs/news.html.in

Pushing under the trivial rule. --- docs/news.html.in | 740 +++--- 1 file changed, 370 insertions(+), 370 deletions(-) diff --git a/docs/news.html.in b/docs/news.html.in index 7ba6408..5b8dca5 100644 --- a/docs/news.html.in +++ b/docs/news.html.in

[libvirt] can't remove cgroup files of the domain, thanks!

HI all: I am now working with libvirt 1.0.0 and come up a problem when I try to destroy a domain, The libvirtd just waiting rmdir command to return for hours, but it seem to never to return .. The stack is : 0x7fa752261287 in rmdir () from /lib/x86_64-linux-gnu/libc.so.6 (gdb) bt #0 0x000

Re: [libvirt] No VirtualBox Driver

Hey Peter, On Mon, Dec 17, 2012 at 12:42 PM, Peter Krempa wrote: > On 12/17/12 07:40, Arslan Waqar wrote: > >> Hi all, >> > > Hi Arslan, > > >> >> I am new to the group and hence there might be a chance I might be >> asking a simple question... >> >> The thing is I compiled and installed libvirt

[libvirt] [PATCH] Fix parsing of vendor_id

I have a problem about parsing vendor_id of domain XML. When define vendor_id attribute, why definition of fallback attribute is needed? I explain below for example. (I used virsh edit.) Current domain xml state is like below, And I redefine domain xml like below, core2duo Th