Hi all,
In libvirt/src/storage/storage_backend_sheepdog.c file, func
virStorageBackendSheepdogCreateVol calls func
virStorageBackendSheepdogRefreshVol to refresh Sheepdog volume infos.
But we do not check func virStorageBackendSheepdogRefreshVol's return
value. Following patch can fix this bug.
S
On 02/05/2013 04:34 AM, Peter Krempa wrote:
>
> The data in the "nodeinfo" structure (retrirevable by "virsh nodeinfo")
> have to add up to the total number of processors in the host if you
> multiply all the fields. This is due to historic reasons.
Hmm - we document under virNodeInfo the cases w
On 02/04/2013 04:31 PM, Stefan Berger wrote:
> On 02/04/2013 03:53 PM, Eric Blake wrote:
>> On 02/01/2013 09:41 PM, Stefan Berger wrote:
>>> On 02/01/2013 09:16 PM, Eric Blake wrote:
>>> I definitely prefer the ARRAY_CARDINALITY() instead of npos in my
>>> version of the test. Beyond that, it looks
Commit 2025356 missed uses of PCI functions in the older HAL-related
code, probably because hal-devel is no longer available in latest Fedora.
* src/node_device/node_device_hal.c (gather_pci_cap): Reflect
function rename.
---
Pushing under the build-breaker rule.
src/node_device/node_device_hal
On 01/30/2013 02:36 PM, John Ferlan wrote:
> I upgraded to a new version of Coverity last night (6.5.1) since I was
> informed it resolved the BAD_SIZEOF errors from the TRACE macros. A majority
> were resolved, except for 3 which just required a couple of changes to avoid.
>
> Since I was down t
On 02/05/2013 08:07 AM, Daniel P. Berrange wrote:
> On Mon, Feb 04, 2013 at 06:31:10PM +0100, Jiri Denemark wrote:
>> On Fri, Feb 01, 2013 at 11:18:30 +, Daniel P. Berrange wrote:
>>> From: "Daniel P. Berrange"
>>>
>>> Rename all the pciDeviceXXX and pciXXXDevice APIs to have a
>>> fixed virPC
On 02/04/2013 08:32 AM, Osier Yang wrote:
> This finds the parent for vHBA by iterating over all the HBA
> which supports vport_ops capability on the host, and return
> the first one which is online, not saturated (vports in use
> is less than max_vports).
> ---
> docs/formatstorage.html.in
On 02/04/2013 08:32 AM, Osier Yang wrote:
> The string written to "vport_create" or "vport_delete" should
> be "wwnn:wwpn", but not "wwpn:wwnn".
> ---
> src/util/virutil.c |4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/util/virutil.c b/src/util/virutil.c
> in
On 02/04/2013 08:32 AM, Osier Yang wrote:
> It's only used by iscsi backend.
> ---
> src/storage/storage_backend_iscsi.c | 39
> ++-
> src/storage/storage_backend_scsi.c | 39
> ---
> src/storage/storage_backend_scsi.h |3
On 02/04/2013 08:31 AM, Osier Yang wrote:
> node device driver names the HBA like "scsi_host5", but storage
> driver uses "host5", which could make the user confused. This
> make them consistent. However, for back-compact reason, adapter
> name like "host5" is still supported.
> ---
> docs/formats
On Tue, Feb 05, 2013 at 12:58:53 -0700, Eric Blake wrote:
> On 02/05/2013 12:33 PM, Jiri Denemark wrote:
> > When running sanitytest.py we should not rely on libvirt library
> > installed on the system. And since we generate a nice wrapper called
> > "run" that sets both PYTHON_PATH and LD_LIBRARY_
On 02/05/2013 12:33 PM, Jiri Denemark wrote:
> When running sanitytest.py we should not rely on libvirt library
> installed on the system. And since we generate a nice wrapper called
> "run" that sets both PYTHON_PATH and LD_LIBRARY_PATH, we should just use
> it rather than trying to duplicate it i
On 02/04/2013 08:31 AM, Osier Yang wrote:
> This introduces 4 new attributes for storage pool source adapter.
> E.g.
>
> wwpn='1000c9831b4b'/>
>
> Attribute 'type' can be either 'scsi_host' or 'fc_host', and defaults
> to 'scsi_host' if attribute 'name' is specified. I.e. It's optional
> for
When running sanitytest.py we should not rely on libvirt library
installed on the system. And since we generate a nice wrapper called
"run" that sets both PYTHON_PATH and LD_LIBRARY_PATH, we should just use
it rather than trying to duplicate it in the Makefile.
---
python/Makefile.am | 2 +-
1 fil
On 02/05/2013 09:46 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> The virt-dbus.m4 check for DBus was preserving $LIBS before
> modifying it. Except it wasn't. It was preserving another
> copy of $CFLAGS. The result was that after the check completed,
> $LIBS got polluted with $C
On Tue, Feb 05, 2013 at 16:46:20 +, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> The virt-dbus.m4 check for DBus was preserving $LIBS before
> modifying it. Except it wasn't. It was preserving another
> copy of $CFLAGS. The result was that after the check completed,
> $LIBS got
On 02/05/2013 09:46 AM, Laine Stump wrote:
> On 02/05/2013 11:17 AM, Eric Blake wrote:
>> Commit 39c77fe triggered random failures, depending on the platform
>> and what other fds leak into the testsuite (for me, it passed on
>> RHEL 6 but failed on Fedora 18). The reason was that we were
>> expec
On Tue, Feb 05, 2013 at 14:48:01 +, Daniel P. Berrange wrote:
> On Mon, Feb 04, 2013 at 04:58:25PM +0100, Jiri Denemark wrote:
> > On Fri, Feb 01, 2013 at 11:18:26 +, Daniel P. Berrange wrote:
> > > From: "Daniel P. Berrange"
> > >
> > > The duplicate VM checking should be done atomically
On 02/05/2013 11:17 AM, Eric Blake wrote:
> Commit 39c77fe triggered random failures, depending on the platform
> and what other fds leak into the testsuite (for me, it passed on
> RHEL 6 but failed on Fedora 18). The reason was that we were
> expecting an fd that fell outside of our reserved rang
On Tue, Feb 05, 2013 at 14:53:13 +, Daniel P. Berrange wrote:
> On Mon, Feb 04, 2013 at 05:22:59PM +0100, Jiri Denemark wrote:
> > On Fri, Feb 01, 2013 at 11:18:27 +, Daniel P. Berrange wrote:
> > > From: "Daniel P. Berrange"
> > >
> > > Switch virDomainObjList to inherit from virObjectLo
On Tue, Feb 05, 2013 at 12:56:12PM +0100, Ján Tomko wrote:
> Branch by imgformat first, since we only add new features if
> -o backing_fmt is supported.
>
> Switch to virBuffer for generating -o options to make adding
> new options easier.
>
> The only change in the generated command line is move
From: "Daniel P. Berrange"
The virt-dbus.m4 check for DBus was preserving $LIBS before
modifying it. Except it wasn't. It was preserving another
copy of $CFLAGS. The result was that after the check completed,
$LIBS got polluted with $CFLAGS
Signed-off-by: Daniel P. Berrange
---
m4/virt-dbus.m4
On Tue, Feb 05, 2013 at 12:56:16PM +0100, Ján Tomko wrote:
> diff --git a/src/storage/storage_backend.c b/src/storage/storage_backend.c
> index f9e604a..e4c586d 100644
> --- a/src/storage/storage_backend.c
> +++ b/src/storage/storage_backend.c
> @@ -654,6 +654,75 @@ cleanup:
> return ret;
> }
On Tue, Feb 05, 2013 at 05:53:30PM +0100, Ján Tomko wrote:
> On 01/30/13 03:30, liguang wrote:
> > @@ -4493,6 +4494,8 @@ virDomainControllerDefParseXML(xmlNodePtr node,
> > goto error;
> >
> > switch (def->type) {
> > +case VIR_DOMAIN_CONTROLLER_TYPE_PCIBRIDGE:
> > +brea
On 01/30/13 03:30, liguang wrote:
> @@ -974,8 +967,24 @@ static char
> *qemuPCIAddressAsString(virDomainDeviceInfoPtr dev)
> return addr;
> }
>
> +static int qemuPciBridgeSupport(virDomainDefPtr def)
> +{
> +int i, c = 0;
> +
> +for (i = 0; i < def->ncontrollers; i++) {
> +
On 01/30/13 03:30, liguang wrote:
> @@ -4493,6 +4494,8 @@ virDomainControllerDefParseXML(xmlNodePtr node,
> goto error;
>
> switch (def->type) {
> +case VIR_DOMAIN_CONTROLLER_TYPE_PCIBRIDGE:
> +break;
> case VIR_DOMAIN_CONTROLLER_TYPE_VIRTIO_SERIAL: {
> cha
On 05.02.2013 17:17, Eric Blake wrote:
> Commit 39c77fe triggered random failures, depending on the platform
> and what other fds leak into the testsuite (for me, it passed on
> RHEL 6 but failed on Fedora 18). The reason was that we were
> expecting an fd that fell outside of our reserved range.
On 02/05/2013 05:56 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> The previous change to the generator, changed too much - only
> the functions are in 'virerror.c', the constants remained in
> 'virerror.h' which could not be renamed for API compat reasons.
s/virerror.h/virterror
On 02/05/2013 08:54 AM, Michal Privoznik wrote:
>> I think you understate the benefits here. UUID based filenames are just
>> absolutely *ing horrific for an admin to see and work work and I am very
>> glad libvirt does not use such a naming scheme.
>>
>> Daniel
>>
>
> But we discourage users to
Commit 39c77fe triggered random failures, depending on the platform
and what other fds leak into the testsuite (for me, it passed on
RHEL 6 but failed on Fedora 18). The reason was that we were
expecting an fd that fell outside of our reserved range. By reserving
a larger range, the test once aga
On 02/05/2013 08:59 AM, Daniel P. Berrange wrote:
> On Tue, Feb 05, 2013 at 08:54:57AM -0700, Eric Blake wrote:
>> Otherwise, we get a lot of scary (but harmless) noise in the logs:
>>
>> 2013-02-05 15:35:48.555+: 8637: error : qemuMonitorJSONCheckError:353 :
>> internal error unable to execut
On Tue, Feb 05, 2013 at 08:54:57AM -0700, Eric Blake wrote:
> Otherwise, we get a lot of scary (but harmless) noise in the logs:
>
> 2013-02-05 15:35:48.555+: 8637: error : qemuMonitorJSONCheckError:353 :
> internal error unable to execute QEMU command 'add-fd': Parameter 'fdset-id'
> expect
Otherwise, we get a lot of scary (but harmless) noise in the logs:
2013-02-05 15:35:48.555+: 8637: error : qemuMonitorJSONCheckError:353 :
internal error unable to execute QEMU command 'add-fd': Parameter 'fdset-id'
expects an existing fdset-id
one for every qemu 1.2 binary that we probe.
On 05.02.2013 16:47, Daniel P. Berrange wrote:
> On Tue, Feb 05, 2013 at 04:45:18PM +0100, Michal Privoznik wrote:
>> On 05.02.2013 12:32, Christophe Fergeau wrote:
>>> Similarly to 790f912b4 which rejects snapshots names containing,
>>> this commit changes virDomainSaveXML to reject domains with a
On 05.02.2013 12:32, Christophe Fergeau wrote:
> Similarly to 790f912b4 which rejects snapshots names containing,
> this commit changes virDomainSaveXML to reject domains with a '/'
> in their name. The domain name is used as a filename, so this
> leads to unexpected results when used in combinatio
On Tue, Feb 05, 2013 at 04:45:18PM +0100, Michal Privoznik wrote:
> On 05.02.2013 12:32, Christophe Fergeau wrote:
> > Similarly to 790f912b4 which rejects snapshots names containing,
> > this commit changes virDomainSaveXML to reject domains with a '/'
> > in their name. The domain name is used as
On Mon, Feb 04, 2013 at 06:31:10PM +0100, Jiri Denemark wrote:
> On Fri, Feb 01, 2013 at 11:18:30 +, Daniel P. Berrange wrote:
> > From: "Daniel P. Berrange"
> >
> > Rename all the pciDeviceXXX and pciXXXDevice APIs to have a
> > fixed virPCIDevice name prefix
>
> Some functions gained just
On Mon, Feb 04, 2013 at 05:22:59PM +0100, Jiri Denemark wrote:
> On Fri, Feb 01, 2013 at 11:18:27 +, Daniel P. Berrange wrote:
> > From: "Daniel P. Berrange"
> >
> > Switch virDomainObjList to inherit from virObjectLockable and
> > make all the APIs acquire/release the mutex when running. Thi
On 04.02.2013 16:47, Peter Krempa wrote:
> On 02/04/13 15:56, Michal Privoznik wrote:
>> Currently, if we want to feed stdin, or catch stdout or stderr of a
>> virCommand we have to use virCommandRun(). When using
>> virCommandRunAsync()
>> we have to register FD handles by hand. This may lead to c
On Mon, Feb 04, 2013 at 04:58:25PM +0100, Jiri Denemark wrote:
> On Fri, Feb 01, 2013 at 11:18:26 +, Daniel P. Berrange wrote:
> > From: "Daniel P. Berrange"
> >
> > The duplicate VM checking should be done atomically with
> > virDomainObjListAdd, so shoud not be a separate function.
> > Inst
On 01/28/13 23:29, Eric Blake wrote:
On 01/11/2013 10:00 AM, Peter Krempa wrote:
With this change it's easy to spot a forgotten free if a new device
class is added.
---
src/conf/domain_conf.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
ACK; and this can go in pre-release.
On 02/05/2013 01:56 PM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> The previous change to the generator, changed too much - only
> the functions are in 'virerror.c', the constants remained in
> 'virerror.h' which could not be renamed for API compat reasons.
>
> Add a test case to
From: "Daniel P. Berrange"
The previous change to the generator, changed too much - only
the functions are in 'virerror.c', the constants remained in
'virerror.h' which could not be renamed for API compat reasons.
Add a test case to sanity check the generated python bindings
Signed-off-by: Dani
Rename/retype the little endian functions used for qed images and add
corresponding big endian ones.
---
src/util/virstoragefile.c | 152 --
1 file changed, 66 insertions(+), 86 deletions(-)
diff --git a/src/util/virstoragefile.c b/src/util/virstoragefi
Add new 'qcow3' format, and support for detecting the backing file
and qcow3 features in the header (just one so far).
---
docs/schemas/storagevol.rng | 1 +
src/storage/storage_backend_fs.c | 1 +
src/util/virstoragefile.c| 101 +++
src/util/vi
Translate the 'qcow3' format to 'qcow2' driver when dealing with qemu.
This allows running domains with qcow3 images and creating internal
snapshots.
---
docs/schemas/domaincommon.rng | 1 +
src/libvirt_private.syms | 1 +
src/qemu/qemu_command.c | 2 +-
src/qemu/qemu_driver.c|
On Tue, Feb 05, 2013 at 11:43:36 +, Daniel P. Berrange wrote:
...
> Here are the changes I propose - should adress every point you
> mention.
ACK to the original patch with these modifications squashed in.
Jirka
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailma
This adds the element to volume XML and allows
virStorageBackendCreateQemuImg to create qcow3 volumes.
For qcow3 images, it runs qemu-img with -f qcow2 -o compat=1.1,...
For qcow2 images, it specifies -o compat=0.10 if it's supported,
just in case the default of qemu-img changed to qcow3 in the fu
---
docs/formatsnapshot.html.in | 7 +
docs/schemas/domainsnapshot.rng | 4 +++
src/conf/snapshot_conf.c| 63 +
src/conf/snapshot_conf.h| 2 ++
src/qemu/qemu_driver.c | 21 +++---
5 files changed, 93 insertions(+),
Add support for creating qcow3 images with or without lazy_refcounts,
using them with qemu and creating snapshots (both internal and external).
Diff to V1:
https://www.redhat.com/archives/libvir-list/2013-January/msg00610.html
* only use one bitmap for all features (and one element)
* support sn
Branch by imgformat first, since we only add new features if
-o backing_fmt is supported.
Switch to virBuffer for generating -o options to make adding
new options easier.
The only change in the generated command line is movement of the
-o/-F options to the end when creating images with backing st
On Fri, Feb 01, 2013 at 09:20:25PM +0100, Jiri Denemark wrote:
> On Fri, Feb 01, 2013 at 11:18:23 +, Daniel P. Berrange wrote:
> > From: "Daniel P. Berrange"
> >
> > Currently the virQEMUDriverPtr struct contains an wide variety
> > of data with varying access needs. Move all the static confi
On 01/30/13 23:12, Doug Goldstein wrote:
On Wed, Jan 30, 2013 at 12:53 PM, Scott Sullivan
wrote:
On 01/29/2013 02:55 PM, Doug Goldstein wrote:
On Tue, Jan 29, 2013 at 9:52 AM, Scott Sullivan
wrote:
I have a machine with four AMD Opteron(TM) 6272 processors:
http://www.amd.com/us/products
Similarly to 790f912b4 which rejects snapshots names containing,
this commit changes virDomainSaveXML to reject domains with a '/'
in their name. The domain name is used as a filename, so this
leads to unexpected results when used in combination with '..'
---
If someone is using domains with '/' i
On 01/31/13 16:42, Gene Czarcinski wrote:
I seem to remember that, if you use net-define, the network will be
persistent and, if you use net-create, the network will not be persistent.
I am now running libvirt-1.0.2 on Fedora 18.
When I use net-define a network from a template and then do a net
On Mon, Feb 04, 2013 at 11:23:50 +, Daniel P. Berrange wrote:
> On Fri, Feb 01, 2013 at 01:45:19PM +0100, Jiri Denemark wrote:
> > libvirt.c calls curl_global_init() if WITH_CURL is defined and thus it
> > should be linked with libcurl. This fixes link failure in case neither
> > xenapi nor esx
On Fri, Feb 01, 2013 at 10:06:28 -0700, Eric Blake wrote:
> On 02/01/2013 05:53 AM, Jiri Denemark wrote:
> > When a changelog entry references an RPM macro, % needs to be escaped so
> > that it does not appear expanded in package changelog.
> >
> > Fri Mar 4 2009 is incorrect since Mar 4 was Wedn
On Mon, Feb 04, 2013 at 10:08:42PM -0600, Doug Goldstein wrote:
> On Mon, Feb 4, 2013 at 8:20 PM, Hu Tao wrote:
> > Don't check WITH_LIBVIRTD in C source files because we will build
> > the sources even without libvirtd.
> > ---
> > src/driver.h | 4
> > src/libvirt.c
On Tue, Feb 05, 2013 at 03:05:58AM +, Yin Olivia-R63875 wrote:
> Hi Daniel,
>
> Thanks for your comments.
> So far there's no device in QEMU to align with chardev on FSL PowerPC
> platforms like spapr-pty for IBM PSeries.
> Maybe it needs patches to QEMU. I'll take deeper investigation on it.
On Fri, Feb 01, 2013 at 11:18:34 +, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> Annotate the fields in virQEMUDriverPtr to indicate the locking
> rules for their use
>
> Signed-off-by: Daniel P. Berrange
> ---
> src/qemu/qemu_conf.h | 22 ++
> 1 file chan
On Fri, Feb 01, 2013 at 14:00:47 +0100, Jiri Denemark wrote:
> On Fri, Feb 01, 2013 at 11:18:35 +, Daniel P. Berrange wrote:
> > From: "Daniel P. Berrange"
> >
> > ---
> > src/qemu/qemu_domain.c | 11 +++
> > src/qemu/qemu_driver.c | 3 +++
> > 2 files changed, 6 insertions(+), 8 de
On Fri, Feb 01, 2013 at 11:18:33 +, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> Currently the activePciHostdevs, inactivePciHostdevsd and
> activeUsbHostdevs lists are all implicitly protected by the
> QEMU driver lock. Now that the lists all inherit from the
> virObjectLockabl
62 matches
Mail list logo
