Eduardo Habkost writes:
> On Thu, Feb 21, 2013 at 09:23:22PM +0100, Markus Armbruster wrote:
>> Eduardo Habkost writes:
>>
>> > This allows "," to be used a separator between each CPU range. Note
>> > that commas inside key=value command-line options have to be escaped
>> > using ",,", so the
On 02/25/2013 12:52 PM, Daniel Veillard wrote:
I have just tagged git and pushed the tarball. The rpms for F17
are following too at the usual place:
ftp://libvirt.org/libvirt/
I gave a try to the set of rpms and this seems to work fine for
relatively simple tests, but of course more t
Eduardo Habkost writes:
> This allows ":" to be used a separator between each CPU range, so the
> command-line may look like:
>
> -numa node,cpus=A-B:C-D
>
> Note that the following format, currently used by libvirt:
>
> -numa nodes,cpus=A-B,C-D
>
> will _not_ work, as "," is the option separ
Sorry, I only noticed your reply today.
On 02/19/13 17:36, John Ferlan wrote:
> On 02/15/2013 05:13 AM, Peter Krempa wrote:
>> On 02/15/13 11:00, Ján Tomko wrote:
>>> Use virURIParse in qemuMigrationPrepareDirect to allow parsing
>>> IPv6 addresses, which would cause an 'incorrect :port' error mes
Currently, qemuDomainShutdownFlags() chooses the agent method of
shutdown whenever the agent is configured. However, this
assumption is not enough as the guest agent may be unresponsive
at the moment. So unless guest agent method has been explicitly
requested, we should fall back to the ACPI method
On Mon, Feb 25, 2013 at 12:41:06 +, Daniel P. Berrange wrote:
...
> Then I think we'll duplicate all the APIs for setting resource tunables
> from virDomainPtr against the new object, so we get
>
>
> int virPartitionGetSchedulerParameters(virPartitionPtr partition,
>
VIR_ERR_NO_CONNECT already contains "no connection driver available".
This patch changes:
no connection driver available for No connection for URI hello
to:
no connection driver available for hello
Bug: https://bugzilla.redhat.com/show_bug.cgi?id=851413
---
src/libvirt.c | 2 +-
1 file changed,
Hello,
Am Montag 25 Februar 2013, 15:58:50 schrieb Michal Privoznik:
> On 22.02.2013 17:55, Philipp Hahn wrote:
> > uid_t and gid_t are opaque types, ranging from s32 to u32 to u64.
...
> This one breaks storagevolxml2xmltest:
> TEST: storagevolxml2xmltest
...
> ... OK 7) Storage Vol XML-2-XML
On 02/26/2013 01:28 AM, Doug Goldstein wrote:
> This fixes a potential NULL deref identified by John Ferlan
> if scandir() didn't return an expected value.
> ---
> src/interface/interface_backend_udev.c | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/src/interface/interface_backen
On 02/26/2013 05:05 AM, Ján Tomko wrote:
> VIR_ERR_NO_CONNECT already contains "no connection driver available".
>
> This patch changes:
> no connection driver available for No connection for URI hello
> to:
> no connection driver available for hello
>
> Bug: https://bugzilla.redhat.com/show_bug.
On Mon, Feb 25, 2013 at 17:38:32 +0100, Paolo Bonzini wrote:
> Currently we call virSetDeviceUnprivSGIO with val == 0 if a block device
> has an sgio attribute. But for sgio='filtered', we know that a
> kernel with no unpriv_sgio support will always behave as the user
> wanted. In this case, ther
Hi all,
In this function qemuMonitorJSONExtractCPUInfo(),
It assumes that cpu index is always contiguous.
if (cpu != i) {
virReportError(VIR_ERR_INTERNAL_ERROR,
_("unexpected cpu index %d expecting %d"),
i, cpu);
Hello,
some documentation updates for new storage pools and volumes.
Philipp Hahn (4):
doc: document new storage volume/pool types
doc: add storage format entries
doc: fix writing of QEMU
doc: white space changes
docs/storage.html.in | 40 +---
1 fi
Add format/@type entries to examples to show what the text is talking
about.
Signed-off-by: Philipp Hahn
---
docs/storage.html.in |4
1 file changed, 4 insertions(+)
diff --git a/docs/storage.html.in b/docs/storage.html.in
index 92d7842..930d603 100644
--- a/docs/storage.html.in
+++ b/
Add qed for dirfs pool.
Add ocfs2 for disk pool.
Add lvm2 for disk and logical pool.
Add cifs and glusterfs for netfs pool.
Note: POOL_DISK_LVM2 can not be created by "parted mklabel", but is only
returned from auto-detection on disk pools.
Signed-off-by: Philipp Hahn
---
docs/storage.html.in |
QEMU should be written all upper case.
Signed-off-by: Philipp Hahn
---
docs/storage.html.in | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/docs/storage.html.in b/docs/storage.html.in
index 930d603..8391f85 100644
--- a/docs/storage.html.in
+++ b/docs/storage.htm
On Mon, Feb 25, 2013 at 10:04:07PM +0100, Andreas Färber wrote:
> Am 21.02.2013 21:57, schrieb Eduardo Habkost:
> > On Thu, Feb 21, 2013 at 09:23:22PM +0100, Markus Armbruster wrote:
> >> Eduardo Habkost writes:
> >>
> >>> This allows "," to be used a separator between each CPU range. Note
> >>>
use two blank line before the next , which helps reading the source
file.
I find the html file still hard to read as there is no clear separation
between different storage pool types. Some CSS tweaks would be
appreciated.
Signed-off-by: Philipp Hahn
---
docs/storage.html.in |6 +-
1 fil
Right now, we allocate a port or a TLS port for SPICE if it's set to -1,
even if autoport is off. But we only free them if autoport is on.
With autoport on, we only allocate TLS port if cfg->spiceTLS is set, but
we free it even if it's not, leading to an error message.
This patch separates the au
On Tue, Feb 26, 2013 at 10:53:07AM +0100, Markus Armbruster wrote:
> Eduardo Habkost writes:
>
> > On Thu, Feb 21, 2013 at 09:23:22PM +0100, Markus Armbruster wrote:
> >> Eduardo Habkost writes:
> >>
> >> > This allows "," to be used a separator between each CPU range. Note
> >> > that commas
On 02/26/13 13:45, Eric Blake wrote:
> On 02/26/2013 05:05 AM, Ján Tomko wrote:
>> VIR_ERR_NO_CONNECT already contains "no connection driver available".
>>
>> This patch changes:
>> no connection driver available for No connection for URI hello
>> to:
>> no connection driver available for hello
>>
On Tue, Feb 26, 2013 at 11:50:08AM +0100, Markus Armbruster wrote:
> Eduardo Habkost writes:
>
> > This allows ":" to be used a separator between each CPU range, so the
> > command-line may look like:
> >
> > -numa node,cpus=A-B:C-D
> >
> > Note that the following format, currently used by libv
On Tue, Feb 26, 2013 at 02:58:19PM +0100, Ján Tomko wrote:
> Right now, we allocate a port or a TLS port for SPICE if it's set to -1,
> even if autoport is off. But we only free them if autoport is on.
>
> With autoport on, we only allocate TLS port if cfg->spiceTLS is set, but
> we free it even i
Update the function prototypes to include a message about the client needing
to free() returned name fields. Fix the all domains example flags values.
v3->v2 diff:
Separted this out to it's own patch.
---
src/libvirt.c | 21 ++---
1 file changed, 10 insertions(+), 11 deletions(-)
v3->v2 difference: Reduced the amount of change to a few comments and
adjusting the (NULL == xxx) and (-1 == xxx) checks
Since these are just documentation changes - once ACK'd is it OK to push
now or should I wait for after the freeze?
Tks,
John
---
examples/hellolibvi
Il 26/02/2013 15:04, Eduardo Habkost ha scritto:
>> > For me, the INI way to do multi-valued keys is still fine.
> Having multiple-valued keys (cpus=A,cpus=B,cpus=C) seems like the best
> intermediate solution while we don't have a decent generic syntax.
Even more so since:
1) we already support
On 02/25/13 23:31, Peter Krempa wrote:
qemu supports adding multiple RNG devices. This patch allows libvirt to
support this.
This patch isn't relevant anymore. Qemu supports adding multiple RNG
devices but it apparently shouldn't and the support will be limited in
the next release.
Peter
-
Hi,
Am 26.02.2013 um 13:06 schrieb Philipp Hahn :
> @Sebastian: Is (uid_t)-1 = (u32)-1 special for Sheepdog or was the file just
> created by a previous virsh-dump, which outputs UINT_MAX instead of -1?
The sheepdog backend doesn't care about uid/gid. I probably created the file
using virsh-du
On 02/25/2013 03:31 PM, Peter Krempa wrote:
> ---
> docs/formatdomain.html.in | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
ACK. You could push this one under the trivial rule.
>
> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> index 12c9468..2a60f61 100644
On 02/25/2013 03:31 PM, Peter Krempa wrote:
> Qemu's implementation of virtio RNG supports rate limiting of the
> entropy used. This patch exposes the option to tune this fucntionality.
s/fucntionality/functionality/
>
> This patch is based on qemu commit 904d6f588063fb5ad2b61998acdf1e73fb4
>
>
On 02/25/2013 03:31 PM, Peter Krempa wrote:
> Users may want to specify XML entities in paths to devices. Ensure they
> are parsed and used properly. Also test support for multiple RNG devices
> in one guest.
Given your comments on 1/4 about qemu not intending to support multiple
devices, you may
In order to keep security driver's private data for future
libvirtd restart, we must copy the behaviour of other drivers and
create and load state XML file. This requires that the security
driver is able to produce its internal state in XML form and
parse it back then. These routines are called wh
Just sending out early to make sure this time I am going in acceptable
direction before digging into selinux. Hopefully, apparmor won't be any deal as
I don't see anything that should be restored on domain shut off process.
Michal Privoznik (3):
security_dac: Remember owner prior chown() and res
Currently, if we label a file to match qemu process DAC label, we
do not store the original owner anywhere. So when relabeling
back, the only option we have is to relabel to root:root
which is obviously wrong.
However, bare remembering is not enough. We need to keep track of
how many times we labe
---
src/security/security_dac.c | 116 +++-
1 file changed, 115 insertions(+), 1 deletion(-)
diff --git a/src/security/security_dac.c b/src/security/security_dac.c
index 4b8f0a2..f2d8c67 100644
--- a/src/security/security_dac.c
+++ b/src/security/security_d
These two flags in fact are mutually exclusive. Requesting them both
doesn't make any sense regardless of hypervisor driver. Hence, we have
to make it within libvirt.c file instead of fixing it in each driver.
---
src/libvirt.c | 52
1 file chan
On RHEL 5, I noticed this test failure message:
TEST: qemumonitorjsontest
libvirt not compiled with yajl, skippingSKIP: qemumonitorjsontest
* tests/virstoragetest.c (testPrepImages): Use simpler fputs.
* tests/qemumonitorjsontest.c (mymain): Ensure trailing newline.
---
Pushing under the trivial
On RHEL 5, 'make check' included failures such as:
TEST: virstoragetest
unable to create directory /virstoragedata/sub
unable to return to correct directory, refusing to clean up /virstoragedata
It turns out that with automake 1.9.x, $(abs_builddir) is not
automatically provided. We have previou
On Tue, Feb 26, 2013 at 10:39:28AM -0700, Eric Blake wrote:
> A couple of patches that I noticed while testing the release
> candidate on a RHEL 5 VM.
>
> Eric Blake (2):
> tests: consistent skip messages
> tests: old automake lacks abs_builddir
>
> tests/Makefile.am | 25 ++---
A couple of patches that I noticed while testing the release
candidate on a RHEL 5 VM.
Eric Blake (2):
tests: consistent skip messages
tests: old automake lacks abs_builddir
tests/Makefile.am | 25 ++---
tests/qemumonitorjsontest.c | 2 +-
tests/virstoragetest.
On 02/26/2013 09:27 AM, Michal Privoznik wrote:
> These two flags in fact are mutually exclusive. Requesting them both
> doesn't make any sense regardless of hypervisor driver. Hence, we have
> to make it within libvirt.c file instead of fixing it in each driver.
> ---
> src/libvirt.c | 52 +++
uid_t and gid_t are opaque types, ranging from s32 to u32 to u64.
Unfortunately libvirt uses the value -1 to mean "current process", which
on Linux32 gets converted to UINT_MAX := +(2^32-1) = 4294967295.
Different libvirt versions used different formatting in the past, which
break one or the othe
virStrToLong(..., 8, ...) already requires the mode to be octal.
Change the relax-ng schema to check for octal as well.
Signed-off-by: Philipp Hahn
---
docs/schemas/basictypes.rng |6 ++
docs/schemas/storagepool.rng |2 +-
docs/schemas/storagevol.rng |2 +-
3 files changed, 8 i
I am pleased to announce that release 1.0.1 of Sys-Virt, the libvirt
Perl API binding is now available for download:
http://search.cpan.org/CPAN/authors/id/D/DA/DANBERR/Sys-Virt-1.0.1.tar.gz
Changed in this release:
- Add all new APIs and constants in libvirt 1.0.1
- Fix typo preventing list
My original response to the patch and to Michal's review is at the end
of this message for historical purposes. I had written it up, made some
small changes to the patch to address problems I found, and pushed it,
but somehow managed to never hit "Send" on the email :-(
In the meantime, I read Eri
From: "Daniel P. Berrange"
The parallels storage driver declared some loop variables
inside the for(;;). This is not allowed by libvirt coding
standards
Signed-off-by: Daniel P. Berrange
Pushed under build breaker rule - RHEL-5 gcc chokes on them
---
src/parallels/parallels_storage.c | 11 ++
[adding Pieter, in case he didn't see the reply.]
On 02/26/2013 11:05 AM, Laine Stump wrote:
> My original response to the patch and to Michal's review is at the end
> of this message for historical purposes. I had written it up, made some
> small changes to the patch to address problems I found,
On 02/26/2013 01:21 PM, Eric Blake wrote:
> [adding Pieter, in case he didn't see the reply.]
I'm starting to think there's a bug in Thunderbird - I pasted Pieter's
address into a line that had "Bcc:" on it, then changed the Bcc to Cc; I
specifically remember doing this after my recent experience
On Tue, Feb 26, 2013 at 6:10 AM, Laine Stump wrote:
> On 02/26/2013 01:28 AM, Doug Goldstein wrote:
>> This fixes a potential NULL deref identified by John Ferlan
>> if scandir() didn't return an expected value.
>> ---
>> src/interface/interface_backend_udev.c | 7 +++
>> 1 file changed, 7 i
Eduardo Habkost writes:
> On Tue, Feb 26, 2013 at 11:50:08AM +0100, Markus Armbruster wrote:
>> Eduardo Habkost writes:
>>
>> > This allows ":" to be used a separator between each CPU range, so the
>> > command-line may look like:
>> >
>> > -numa node,cpus=A-B:C-D
>> >
>> > Note that the foll
On Tue, Feb 26, 2013 at 01:35:14PM -0600, Anthony Liguori wrote:
> Eduardo Habkost writes:
>
> > On Tue, Feb 26, 2013 at 11:50:08AM +0100, Markus Armbruster wrote:
> >> Eduardo Habkost writes:
> >>
> >> > This allows ":" to be used a separator between each CPU range, so the
> >> > command-line
virstoragetest was failing on RHEL 5, but with no good error message:
TEST: virstoragetest
0 FAIL
It turns out that qemu-img was so old, that it lacked support for
-o backing_file. It didn't help that the test was also using
qemu-img from PATH, even afte
Il 26/02/2013 20:35, Anthony Liguori ha scritto:
>>> >>
>>> >> See also discussion on multi-valued keys in command line option
>>> >> arguments and config files in v1 thread. Hopefully we can reach a
>>> >> conclusion soon, and then we'll see whether this patch is what we want.
>> >
>> > Yeah, le
[Bcc problems] Ah, indeed, I never got some of those mails, just saw my
original patch merged last Sunday and already wondered why nobody
commented :)
For brevity, I'll summarize the points we've been discussing. Forgive me
if I oversee something important.
- We're thinking about importing D
Paolo Bonzini writes:
> Il 26/02/2013 20:35, Anthony Liguori ha scritto:
>>
>> See also discussion on multi-valued keys in command line option
>> arguments and config files in v1 thread. Hopefully we can reach a
>> conclusion soon, and then we'll see whether this patch is wh
On 02/26/2013 04:02 AM, Michal Privoznik wrote:
> Currently, qemuDomainShutdownFlags() chooses the agent method of
> shutdown whenever the agent is configured. However, this
> assumption is not enough as the guest agent may be unresponsive
> at the moment. So unless guest agent method has been expl
On 02/26/2013 01:14 AM, Philipp Hahn wrote:
s/ocal/octal/ in the subject
> virStrToLong(..., 8, ...) already requires the mode to be octal.
> Change the relax-ng schema to check for octal as well.
>
> Signed-off-by: Philipp Hahn
> ---
> docs/schemas/basictypes.rng |6 ++
> docs/schema
On 02/25/2013 10:22 PM, Li Zhang wrote:
> Hi all,
>
> In this function qemuMonitorJSONExtractCPUInfo(),
>
> It assumes that cpu index is always contiguous.
>
> If possible, can this assumption be removed?
Sure - patches welcome. It would be best if you can submit the patch,
since you are the
On 02/26/2013 03:16 AM, Viktor Mihajlovski wrote:
> Can we please revert the following commits before rc2;
>
> 24aa7f8d11054b7b2e643cf3cd5c80a199764af0 (S390: Documentation for CCW
> address type)
> 0bbbd42c30543d8251536c2fa11166834c886ada (S390: domain_conf support for
> CCW)
>
> this is for tw
On 02/25/2013 06:14 PM, Eugene Marcotte wrote:
> On Mon, 2013-02-25 at 17:42 -0700, Eric Blake wrote:
>> On 02/25/2013 05:38 PM, Eugene Marcotte wrote:
>>> Hi,
>>>
>>> I'm building libvirt for the first time and figuring out what libraries
>>> are required to get the simplest possible thing working
On Tue, 2013-02-26 at 16:42 -0700, Eric Blake wrote:
> Ah, I see now - the file in question is src/libvirt.c - the typo of
> libirt.c threw me off.
Sorry about that.
> I think we are guaranteed that gcrypt.h exists if gnutls is properly
> installed, even if it is a transitive dependency. Does t
I'm currently adding support for running a DHCP relay daemon instead of using
dnsmasq for DHCP.
Everything is looking good but I've stumbled on one issue.
I've added a new variable to 'configure.a' (DHCPRELAY) but found that
'autogen.sh' doesn't call
'autoheader' to remake 'config.h.in' so it c
On 27/02/13 01:01, TJ wrote:
> I've added a new variable to 'configure.a' (DHCPRELAY) but found that
> 'autogen.sh' doesn't call
> 'autoheader' to remake 'config.h.in' so it contains the definition of
> DHCPRELAY for the compiler.
False alarm - I made a typo in the most critical spot in 'configu
Hi all,
When i compiled libvirt like following
1. git clone git://libvirt.org/libvirt.git；cd libvirt
2. git reset --hard v1.0.1
3. wget
http://cloudxy.googlecode.com/svn/branches/hlfs/person/harry/hlfs/patches/hlfs_driver_for_libvirt_network_disk.patch
4. wget
http://cloudxy.googlecode.
On 2013年02月27日 07:28, Eric Blake wrote:
On 02/25/2013 10:22 PM, Li Zhang wrote:
Hi all,
In this function qemuMonitorJSONExtractCPUInfo(),
It assumes that cpu index is always contiguous.
If possible, can this assumption be removed?
Sure - patches welcome. It would be best if you can submit t
On 02/26/2013 09:08 AM, Michal Privoznik wrote:
> Currently, if we label a file to match qemu process DAC label, we
> do not store the original owner anywhere. So when relabeling
> back, the only option we have is to relabel to root:root
> which is obviously wrong.
>
> However, bare remembering is
On 02/26/2013 05:42 AM, Philipp Hahn wrote:
> Add format/@type entries to examples to show what the text is talking
> about.
>
> Signed-off-by: Philipp Hahn
> ---
> docs/storage.html.in |4
> 1 file changed, 4 insertions(+)
> +++ b/docs/storage.html.in
> @@ -185,6 +185,7 @@
>
On 02/26/2013 07:20 AM, John Ferlan wrote:
I would have put '---' here, since...
> v3->v2 difference: Reduced the amount of change to a few comments and
> adjusting the (NULL == xxx) and (-1 == xxx) checks
>
> Since these are just documentation changes - once ACK'd is it OK
On 02/26/2013 07:18 AM, John Ferlan wrote:
> Update the function prototypes to include a message about the client needing
> to free() returned name fields. Fix the all domains example flags values.
>
> v3->v2 diff:
> Separted this out to it's own patch.
s/Separted/Separated/
then again, the inf
On 02/26/2013 05:56 PM, Eric Blake wrote:
> On 02/26/2013 05:41 AM, Philipp Hahn wrote:
>> Add qed for dirfs pool.
>> Add ocfs2 for disk pool.
>> Add lvm2 for disk and logical pool.
>> Add cifs and glusterfs for netfs pool.
>>
>> Note: POOL_DISK_LVM2 can not be created by "parted mklabel", but is o
On 02/26/2013 05:41 AM, Philipp Hahn wrote:
> Add qed for dirfs pool.
> Add ocfs2 for disk pool.
> Add lvm2 for disk and logical pool.
> Add cifs and glusterfs for netfs pool.
>
> Note: POOL_DISK_LVM2 can not be created by "parted mklabel", but is only
> returned from auto-detection on disk pools.
On 02/26/2013 06:32 PM, harryxiyou wrote:
> Hi all,
>
> i got following errors.
>
> [...]
> cc1: error: AVA_HOME/include: No such file or directory [-Werror]
> cc1: error: AVA_HOME/include/linux: No such file or directory [-Werror]
> cc1: all warnings being treated as errors
> make[3]: *** [libv
On 02/26/2013 05:01 PM, Eugene Marcotte wrote:
> On Tue, 2013-02-26 at 16:42 -0700, Eric Blake wrote:
>> I think we are guaranteed that gcrypt.h exists if gnutls is properly
>> installed, even if it is a transitive dependency. Does this patch fix
>> it for you?
>
> Yup, at least when building wit
https://bugzilla.redhat.com/show_bug.cgi?id=896092 mentions that
qemu 1.4 and earlier only accept a simple start-stop range for
the cpu=... argument of -numa. Libvirt would attempt to use
-numa cpu=1,3 for a disjoint range, which did not work as intended.
Upstream qemu will be adding a new syntax
From: Li Zhang
When getting CPUs' information, it assumes that CPU indexes
are not contiguous. But for ppc64 platform, CPU indexes are not
contiguous because SMT is needed to be disabled, so CPU information
is not right on ppc64 and vpuinfo, vcpupin can't work corretly.
This patch is to remove t
Signed-off-by: Olivia Yin
---
src/conf/domain_conf.c |4
src/conf/domain_conf.h |1 +
src/qemu/qemu_command.c |6 ++
3 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 0c75838..07ad6b9 100644
--- a/src/conf/
On Tue, Feb 26, 2013 at 9:38 PM, Olivia Yin wrote:
> Signed-off-by: Olivia Yin
> ---
> src/conf/domain_conf.c |4
> src/conf/domain_conf.h |1 +
> src/qemu/qemu_command.c |6 ++
> 3 files changed, 11 insertions(+), 0 deletions(-)
>
> diff --git a/src/conf/domain_conf.c b/s
On Wed, Feb 27, 2013 at 11:04 AM, Eric Blake wrote:
[...]
> You trimmed too much of your make line to tell us what was happening.
> It might also help to run 'make V=1' to get the full command line being
> attempted. I have to wonder if you have an unexpanded '$JAVA_HOME'
> injected somewhere int
Hello Eric,
Am Mittwoch 27 Februar 2013, 02:00:07 schrieb Eric Blake:
> On 02/26/2013 05:42 AM, Philipp Hahn wrote:
> > Add format/@type entries to examples to show what the text is talking
> > about.
> >
> > Signed-off-by: Philipp Hahn
> > ---
> >
> > docs/storage.html.in |4
> > 1 f
79 matches
Mail list logo
