[libvirt] [PATCH v3] add a boot option to do strict boot

2013-03-19 Thread Amos Kong
Seabios already added a new device type to halt booting. Qemu can add HALT at the end of bootindex string, then seabios will halt booting after trying to boot from all selected devices. This patch added a new boot option to configure if boot from un-selected devices. This option only effects

Re: [libvirt] [PATCH 0/5]Add startupPolicy attribute support for hard disks

2013-03-19 Thread Guannan Ren
On 03/18/2013 10:42 PM, Daniel P. Berrange wrote: On Mon, Mar 18, 2013 at 05:10:17PM +0800, Guannan Ren wrote: The set of patches is trying to add 'startupPolicy' attribute support to the source element of hard disks. Policy levels are using the mandatory, requisite, optional levels as

[libvirt] [PATCH] qemu: Support setting the 'removable' flag for USB disks

2013-03-19 Thread anonym
This adds an attribute named 'removable' to the 'target' element of disks, which controls the removable flag. For instance, on a Linux guest it controls the value of /sys/block/$dev/removable. This option is only valid for USB disks (i.e. bus='usb'), and its default value is 'off', which is the

[libvirt] qmp monitor is broken

2013-03-19 Thread Gerd Hoffmann
Hi, $subject says it. Bisecting points to: commit 23673ca740e0eda66901ca801a5a901df378b063 Author: Anthony Liguori aligu...@us.ibm.com Date: Tue Mar 5 23:21:23 2013 +0530 qemu-char: add watch support This allows a front-end to request for a callback when the backend is

[libvirt] [libvirt-designer 1/2] Fix libvirt caps - libosinfo platform short id mapping

2013-03-19 Thread Christophe Fergeau
The code was building an id starting with kvm- while libosinfo qemu description uses qemu-kvm-. Also, starting from qemu 1.2.0, there is no separate qemu-kvm tarball. guess_platform_from_connect is starting to be a bit magic, it may be better to add a machine attribute to libosinfo platform

[libvirt] [libvirt-designer 2/2] Add gvir_designer_get_osinfo_db

2013-03-19 Thread Christophe Fergeau
virtxml was doing its own loading of the libosinfo database, and gvir_designer_init() was loading it a second time. By adding a gvir_designer_get_osinfo_db() method, virtxml can use the same libosinfo database as the rest of libvirt-designer. --- examples/virtxml.c | 51

Re: [libvirt] [PATCH v3 RESEND 3/4] NUMA: cleanup for numa related codes

2013-03-19 Thread Daniel P. Berrange
On Tue, Mar 19, 2013 at 09:59:37AM +0800, Gao feng wrote: Intend to reduce the redundant code,use virNumaSetupMemoryPolicy to replace virLXCControllerSetupNUMAPolicy and qemuProcessInitNumaMemoryPolicy. This patch also moves the numa related codes to the file virnuma.c and virnuma.h

Re: [libvirt] [libvirt-designer 2/2] Add gvir_designer_get_osinfo_db

2013-03-19 Thread Daniel P. Berrange
On Tue, Mar 19, 2013 at 10:46:36AM +0100, Christophe Fergeau wrote: virtxml was doing its own loading of the libosinfo database, and gvir_designer_init() was loading it a second time. By adding a gvir_designer_get_osinfo_db() method, virtxml can use the same libosinfo database as the rest of

Re: [libvirt] [PATCH v2 0/6] Identity management APIs for RBAC

2013-03-19 Thread Daniel P. Berrange
Ping, any more reviews welcome... Daniel On Wed, Mar 13, 2013 at 03:23:59PM +, Daniel P. Berrange wrote: An update of https://www.redhat.com/archives/libvir-list/2013-March/msg00186.html The first two patches are merged and fixes for the other patches applied. -- libvir-list

Re: [libvirt] [PATCH 0/7] Support NBD volumes with LXC containers

2013-03-19 Thread Daniel P. Berrange
Ping, any reviews welcome On Fri, Mar 15, 2013 at 04:32:37PM +, Daniel P. Berrange wrote: This series adds support for using non-raw disks with LXC containers by leverging NBD + qemu-nbd as an alternative to the loopback device. Daniel -- |: http://berrange.com -o-

Re: [libvirt] [PATCH v2 3/6] Add APIs for associating a virIdentityPtr with the current thread

2013-03-19 Thread Jiri Denemark
On Wed, Mar 13, 2013 at 15:24:02 +, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com To allow any internal API to get the current identity, add APIs to associate a virIdentityPtr with the current thread, via a thread local Signed-off-by: Daniel P. Berrange

Re: [libvirt] [PATCH v2 4/6] Add API to get the system identity

2013-03-19 Thread Jiri Denemark
On Wed, Mar 13, 2013 at 15:24:03 +, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com If no user identity is available, some operations may wish to use the system identity. ie the identity of the current process itself. Add an API to get such an identity.

Re: [libvirt] [PATCH v2 5/6] Add ability to get a virIdentity from a virNetServerClientPtr

2013-03-19 Thread Jiri Denemark
On Wed, Mar 13, 2013 at 15:24:04 +, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Add APIs which allow creation of a virIdentity from the info associated with a virNetServerClientPtr instance. This is done based on the results of client authentication processes

Re: [libvirt] [PATCH v2 2/6] Define internal APIs for managing identities

2013-03-19 Thread Jiri Denemark
On Wed, Mar 13, 2013 at 15:24:01 +, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Introduce a local object virIdentity for managing security attributes used to form a client application's identity. Instances of this object are intended to be used as if they were

Re: [libvirt] [PATCH v2 6/6] Set the current client identity during API call dispatch

2013-03-19 Thread Jiri Denemark
On Wed, Mar 13, 2013 at 15:24:05 +, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com When dispatching an RPC API call, setup the current identity to hold the identity of the network client associated with the RPC message being dispatched. The setting is

Re: [libvirt] [PATCH 1/7] Setup LXC cgroups in two phases

2013-03-19 Thread John Ferlan
On 03/15/2013 12:32 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Currently the LXC controller creates the cgroup, configures the resources and adds the task all in one go. This is not sufficiently flexible for the forthcoming NBD integration. We need to make

Re: [libvirt] [PATCH] qemu: Support setting the 'removable' flag for USB disks

2013-03-19 Thread Daniel P. Berrange
On Tue, Mar 19, 2013 at 09:40:54AM +0100, anonym wrote: Can you use a real name instead of an anonymous psuedonym for patches. This adds an attribute named 'removable' to the 'target' element of disks, which controls the removable flag. For instance, on a Linux guest it controls the value of

Re: [libvirt] [PATCH 0/5]Add startupPolicy attribute support for hard disks

2013-03-19 Thread Daniel P. Berrange
On Tue, Mar 19, 2013 at 03:56:40PM +0800, Guannan Ren wrote: On 03/18/2013 10:42 PM, Daniel P. Berrange wrote: On Mon, Mar 18, 2013 at 05:10:17PM +0800, Guannan Ren wrote: The set of patches is trying to add 'startupPolicy' attribute support to the source element of hard disks. Policy levels

Re: [libvirt] [PATCH v5 1/3] conf: support dtb tag in XML domain file

2013-03-19 Thread Daniel P. Berrange
On Thu, Mar 14, 2013 at 12:49:42PM +0800, Olivia Yin wrote: --- docs/formatdomain.html.in |5 + docs/schemas/domaincommon.rng |6 ++ src/conf/domain_conf.c|4 src/conf/domain_conf.h|1 + 4 files changed, 16 insertions(+), 0 deletions(-) ACK

[libvirt] about Application_Development_Guide.pdf

2013-03-19 Thread huyp1024
HI,buddy. I'm sheldon. I'm trying to develop virtual machine lifecycle management software using libvirt. I found the development guide is very useful,it helps a lot. But this book I download from offical website is a draft,there are a lot of funcitons which are not claimed. I appreciate very

Re: [libvirt] [PATCH v5 2/3] qemu: add dtb option supprt

2013-03-19 Thread Daniel P. Berrange
On Thu, Mar 14, 2013 at 12:49:43PM +0800, Olivia Yin wrote: The dtb option sets the filename for the device tree. If without this option support, -dtb file will be converted into qemu:commandline in domain XML file. For example, '-dtb /media/ram/test.dtb' will be converted into

Re: [libvirt] [PATCH v5 3/3] selinux: deal with dtb file

2013-03-19 Thread Daniel P. Berrange
On Thu, Mar 14, 2013 at 12:49:44PM +0800, Olivia Yin wrote: --- src/security/security_dac.c |8 src/security/security_selinux.c |8 src/security/virt-aa-helper.c |4 3 files changed, 20 insertions(+), 0 deletions(-) ACK Daniel -- |:

Re: [libvirt] about Application_Development_Guide.pdf

2013-03-19 Thread Daniel P. Berrange
On Tue, Mar 19, 2013 at 02:17:43PM +0800, huyp1024 wrote: HI,buddy. I'm sheldon. I'm trying to develop virtual machine lifecycle management software using libvirt. I found the development guide is very useful,it helps a lot. But this book I download from offical website is a draft,there are

Re: [libvirt] [PATCH] qemu: Support setting the 'removable' flag for USB disks

2013-03-19 Thread Peter Krempa
On 03/19/13 12:59, Daniel P. Berrange wrote: On Tue, Mar 19, 2013 at 09:40:54AM +0100, anonym wrote: Can you use a real name instead of an anonymous psuedonym for patches. This adds an attribute named 'removable' to the 'target' element of disks, which controls the removable flag. For

Re: [libvirt] [PATCH 0/5]Add startupPolicy attribute support for hard disks

2013-03-19 Thread Guannan Ren
On 03/19/2013 08:21 PM, Daniel P. Berrange wrote: On Tue, Mar 19, 2013 at 03:56:40PM +0800, Guannan Ren wrote: On 03/18/2013 10:42 PM, Daniel P. Berrange wrote: On Mon, Mar 18, 2013 at 05:10:17PM +0800, Guannan Ren wrote: The set of patches is trying to add 'startupPolicy' attribute support

Re: [libvirt] [PATCH v2 4/6] Add API to get the system identity

2013-03-19 Thread Daniel P. Berrange
On Tue, Mar 19, 2013 at 12:21:31PM +0100, Jiri Denemark wrote: On Wed, Mar 13, 2013 at 15:24:03 +, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com If no user identity is available, some operations may wish to use the system identity. ie the identity of the

Re: [libvirt] [PATCH v2 2/6] Define internal APIs for managing identities

2013-03-19 Thread Daniel P. Berrange
On Tue, Mar 19, 2013 at 12:20:51PM +0100, Jiri Denemark wrote: On Wed, Mar 13, 2013 at 15:24:01 +, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Introduce a local object virIdentity for managing security attributes used to form a client application's

Re: [libvirt] [PATCH 2/7] Add support for storage format in FS driver

2013-03-19 Thread John Ferlan
On 03/15/2013 12:32 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Extend the driver element in filesystem devices to allow a storage format to be set. The new attribute uses 'format' to reflect the storage format. This is different from the driver element in

Re: [libvirt] [PATCH 3/7] Re-arrange code setting up ifs/disk loop devices for LXC

2013-03-19 Thread John Ferlan
On 03/15/2013 12:32 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The current code for setting up loop devices to LXC disks first does a switch() based on the disk format, then looks at the disk driver name. Reverse this so it first looks at the driver name, and

Re: [libvirt] [PATCH 4/7] Add a helper API for setting up a NBD device with qemu-nbd

2013-03-19 Thread John Ferlan
On 03/15/2013 12:32 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Add a virFileNBDDeviceAssociate method, which given a filename will setup a NBD device, using qemu-nbd as the server. Signed-off-by: Daniel P. Berrange berra...@redhat.com ---

[libvirt] [PATCH v2 4/4] event: add hard disk dropping event reason enum

2013-03-19 Thread Guannan Ren
VIR_DOMAIN_EVENT_DISK_CHANGE_MISSING_ON_START --- include/libvirt/libvirt.h.in | 1 + src/qemu/qemu_domain.c | 18 +- 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in index f6a7aff..72df5a2 100644

[libvirt] [PATCH v2 1/4] conf: add startupPolicy attribute for harddisk

2013-03-19 Thread Guannan Ren
Add startupPolicy attribute policy for harddisk with type file, block and dir. The network type disk is still not supported. --- docs/formatdomain.html.in | 9 ++--- docs/schemas/domaincommon.rng | 6 ++ src/conf/domain_conf.c| 19 +-- 3 files changed, 25

[libvirt] [PATCH v2 2/4] util: add two functions to find last set or unset bit in bitmap

2013-03-19 Thread Guannan Ren
virBitmapNextLastSetBit: Search for the last set bit before certain position. virBitmapNextLastSetBit: Search for the last clear bit before certain position. --- src/libvirt_private.syms | 2 + src/util/virbitmap.c | 96 src/util/virbitmap.h

[libvirt] [PATCH v2 3/4] qemu: drop disk definition if missing and reorder per-device boot sequence

2013-03-19 Thread Guannan Ren
With 'optional' startupPolicy set, when one or more disk are missing, the qemu process drops their definitions and bootups the vm. When the vm is using per-device boot elements, then we need to reorder them in order to perform migrate successfully if necessary. During the reordering, it uses

[libvirt] [PATCH v2 0/4]Add startupPolicy attribute support for hard disks

2013-03-19 Thread Guannan Ren
v1 to v2: added relax schema for disk of block and dir type removed original patch 3/5. The set of patches is trying to add 'startupPolicy' attribute support to the source element of hard disks. Policy levels are using the mandatory, requisite, optional levels as originally documented.

Re: [libvirt] [PATCH 5/7] Add 'nbd' as a valid filesystem driver type

2013-03-19 Thread John Ferlan
On 03/15/2013 12:32 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The filesystem element can now accept a driver type='nbd'/ as an alternative to 'loop'. The benefit of NBD is support for non-raw disk image formats. Signed-off-by: Daniel P. Berrange

Re: [libvirt] [PATCH 7/7] Do not prematurely close loop devices in LXC controller

2013-03-19 Thread John Ferlan
On 03/15/2013 12:32 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The LXC controller is closing loop devices as soon as the container has started. This is fine if the loop device was setup as a mounted filesystem, but if we're just passing through the loop

Re: [libvirt] [PATCH 6/7] Support NBD backed disks/filesystems in LXC driver

2013-03-19 Thread John Ferlan
On 03/15/2013 12:32 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The LXC driver can already configure disk or filesystem devices to use the loop device. This extends it to also allow for use of the NBD device, to support non-raw formats. Signed-off-by: Daniel

[libvirt] [libvirt-glib] gconfig: Add calls to [gs]et_virt_type to domain tests

2013-03-19 Thread Christophe Fergeau
Setting GVirConfigDomain::virt_type is required for a working domain configuration, using it in the test programs will be helpful if people are using this as a base when starting to use libvirt-gconfig --- examples/config-demo.py| 1 +

[libvirt] [libvirt-glib 1/4] gconfig: Add GVirConfigStoragePool getters

2013-03-19 Thread Christophe Fergeau
--- libvirt-gconfig/libvirt-gconfig-storage-pool.c | 143 + libvirt-gconfig/libvirt-gconfig-storage-pool.h | 8 ++ libvirt-gconfig/libvirt-gconfig.sym| 12 +++ 3 files changed, 163 insertions(+) diff --git a/libvirt-gconfig/libvirt-gconfig-storage-pool.c

[libvirt] [libvirt-glib 2/4] gconfig: Add GVirConfigStoragePoolSource getters

2013-03-19 Thread Christophe Fergeau
--- .../libvirt-gconfig-storage-pool-source.c | 132 + .../libvirt-gconfig-storage-pool-source.h | 8 ++ libvirt-gconfig/libvirt-gconfig.sym| 9 ++ libvirt-gconfig/tests/test-domain-create.c | 3 + 4 files changed, 152

[libvirt] [libvirt-glib 3/4] gconfig: Add GvirConfigStoragePoolTarget getters

2013-03-19 Thread Christophe Fergeau
--- .../libvirt-gconfig-storage-pool-target.c | 39 ++ .../libvirt-gconfig-storage-pool-target.h | 2 ++ libvirt-gconfig/libvirt-gconfig.sym| 3 ++ libvirt-gconfig/tests/test-domain-create.c | 4 +++ 4 files changed, 48

[libvirt] [libvirt-glib 4/4] gconfig: Add GvirConfigStoragePermission getters

2013-03-19 Thread Christophe Fergeau
--- .../libvirt-gconfig-storage-permissions.c | 63 ++ .../libvirt-gconfig-storage-permissions.h | 4 ++ libvirt-gconfig/libvirt-gconfig.sym| 5 ++ libvirt-gconfig/tests/test-domain-create.c | 6 +++ 4 files changed, 78

Re: [libvirt] IPv6 migration

2013-03-19 Thread Jiri Denemark
On Mon, Mar 11, 2013 at 19:40:52 +0100, Ján Tomko wrote: Hello. We can only tell QEMU on the destination to listen either on IPv6 or on IPv4. If we're supplied with a numeric v6 address, that's the only thing we need to know to set the listen address to [::]. For hostnames, we can

Re: [libvirt] [PATCH 7/7] Do not prematurely close loop devices in LXC controller

2013-03-19 Thread Daniel P. Berrange
On Tue, Mar 19, 2013 at 10:17:59AM -0400, John Ferlan wrote: On 03/15/2013 12:32 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The LXC controller is closing loop devices as soon as the container has started. This is fine if the loop device was setup as a

[libvirt] [PATCH 1/2] Fix /pool/storage/directory@path documentation

2013-03-19 Thread Christophe Fergeau
Because of a wrong copy and paste, the documentation was saying that 'path' is the path to a block device node while it's a path to a directory. --- Pushed under the trivial rule docs/formatstorage.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[libvirt] [PATCH 2/2] Fix /pool/storage/name documentation

2013-03-19 Thread Christophe Fergeau
There was a 2 word sentence 'remote server' which is a left-over from copy and paste. --- Pushed under the trivial rule. docs/formatstorage.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatstorage.html.in b/docs/formatstorage.html.in index 49ae818..9b68738

Re: [libvirt] [libvirt-designer 1/2] Fix libvirt caps - libosinfo platform short id mapping

2013-03-19 Thread Daniel P. Berrange
On Tue, Mar 19, 2013 at 10:46:35AM +0100, Christophe Fergeau wrote: The code was building an id starting with kvm- while libosinfo qemu description uses qemu-kvm-. Also, starting from qemu 1.2.0, there is no separate qemu-kvm tarball. guess_platform_from_connect is starting to be a bit magic,

Re: [libvirt] [libvirt-designer 1/2] Fix libvirt caps - libosinfo platform short id mapping

2013-03-19 Thread Christophe Fergeau
On Tue, Mar 19, 2013 at 03:24:22PM +, Daniel P. Berrange wrote: On Tue, Mar 19, 2013 at 10:46:35AM +0100, Christophe Fergeau wrote: The code was building an id starting with kvm- while libosinfo qemu description uses qemu-kvm-. Also, starting from qemu 1.2.0, there is no separate

Re: [libvirt] [libvirt-designer 1/2] Fix libvirt caps - libosinfo platform short id mapping

2013-03-19 Thread Daniel P. Berrange
On Tue, Mar 19, 2013 at 04:54:46PM +0100, Christophe Fergeau wrote: On Tue, Mar 19, 2013 at 03:24:22PM +, Daniel P. Berrange wrote: On Tue, Mar 19, 2013 at 10:46:35AM +0100, Christophe Fergeau wrote: The code was building an id starting with kvm- while libosinfo qemu description uses

Re: [libvirt] [libvirt-designer 1/2] Fix libvirt caps - libosinfo platform short id mapping

2013-03-19 Thread Christophe Fergeau
On Tue, Mar 19, 2013 at 03:58:18PM +, Daniel P. Berrange wrote: Perhaps we should be following the approach we use for detecting ISOs, and match against actual product release strings. Libvirt doesn't expose such info, but we could add an API to expose the full product string and/or

Re: [libvirt] [PATCH] Fix --without-libvirtd builds

2013-03-19 Thread Doug Goldstein
On Sat, Mar 16, 2013 at 9:11 PM, Doug Goldstein car...@cardoe.com wrote: When building with --without-libvirtd and udev support is detected we will fail to build with the following error: node_device/node_device_udev.c:1608:37: error: unknown type name 'virStateInhibitCallback'

Re: [libvirt] [PATCH] Fix --without-libvirtd builds

2013-03-19 Thread Eric Blake
On 03/16/2013 08:11 PM, Doug Goldstein wrote: When building with --without-libvirtd and udev support is detected we will fail to build with the following error: node_device/node_device_udev.c:1608:37: error: unknown type name 'virStateInhibitCallback' --- src/Makefile.am | 2 ++

[libvirt] [PATCH] rename tests/conftest.c

2013-03-19 Thread Gene Czarcinski
To prevent confusion with configure's popular name for a file, rename conftest.c to test_conf.c which is consistent with the invoking test_conf.sh Signed-off-by: Gene Czarcinski g...@czarc.net --- tests/Makefile.am | 8 tests/conftest.c | 48

Re: [libvirt] conftest segfault

2013-03-19 Thread Gene Czarcinski
On 03/18/2013 01:42 PM, Eric Blake wrote: On 03/16/2013 11:08 PM, Eric Blake wrote: So, it appears the this version of gnulib fixes something important but also causes a segfault when ./configure is run with the new gnulib. What I do not know is if this segfault has any meaning. The segfault

Re: [libvirt] [PATCH v3] add a boot option to do strict boot

2013-03-19 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] rename tests/conftest.c

2013-03-19 Thread Eric Blake
On 03/19/2013 12:36 PM, Gene Czarcinski wrote: To prevent confusion with configure's popular name for a file, rename conftest.c to test_conf.c which is consistent with the invoking test_conf.sh Signed-off-by: Gene Czarcinski g...@czarc.net --- tests/Makefile.am | 8

Re: [libvirt] [PATCH] Fix --without-libvirtd builds

2013-03-19 Thread Doug Goldstein
On Tue, Mar 19, 2013 at 12:58 PM, Eric Blake ebl...@redhat.com wrote: On 03/16/2013 08:11 PM, Doug Goldstein wrote: When building with --without-libvirtd and udev support is detected we will fail to build with the following error: node_device/node_device_udev.c:1608:37: error: unknown type

Re: [libvirt] [PATCH v5 2/3] qemu: add dtb option supprt

2013-03-19 Thread Eric Blake
On 03/19/2013 06:24 AM, Daniel P. Berrange wrote: On Thu, Mar 14, 2013 at 12:49:43PM +0800, Olivia Yin wrote: s/supprt/support/ in the subject The dtb option sets the filename for the device tree. If without this option support, -dtb file will be converted into qemu:commandline in domain XML

Re: [libvirt] [PATCH v5 2/3] qemu: add dtb option supprt

2013-03-19 Thread Eric Blake
On 03/13/2013 10:49 PM, Olivia Yin wrote: The dtb option sets the filename for the device tree. If without this option support, -dtb file will be converted into qemu:commandline in domain XML file. For example, '-dtb /media/ram/test.dtb' will be converted into qemu:commandline qemu:arg

Re: [libvirt] [PATCH v3 1/4] rename qemuGetNumadAdvice to virNumaGetAutoPlacementAdvice

2013-03-19 Thread Eric Blake
On 03/18/2013 03:04 AM, Gao feng wrote: qemuGetNumadAdvice will be used by LXC driver,rename space after comma it to virNumaGetAutoPlacementAdvice and move it to virnuma.c Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- po/POTFILES.in | 1 + src/Makefile.am | 1 +

Re: [libvirt] libvirtd segfault

2013-03-19 Thread AL13N
Op maandag 18 maart 2013 18:19:51 schreef Jiri Denemark: On Thu, Mar 14, 2013 at 20:01:16 +0100, AL13N wrote: Op maandag 11 maart 2013 12:59:08 schreef Eric Blake: On 03/10/2013 09:25 AM, AL13N wrote: regarding

Re: [libvirt] [test-API][PATCH] The patch covers all nwfilter api provided by libvirt.py. It includes define/undefine/list nwfilters and check them via checking ebtables rule. The following new files

2013-03-19 Thread hongming
On 03/18/2013 05:53 PM, Osier Yang wrote: On 2013年03月18日 14:54, hongming wrote: Can you shorten the patch subject? And add the sentences in the commit log instead? Sorry , Please ignore the patch . I made a mistake when generate patch . I send another patch with subject - Add nwfilter test

Re: [libvirt] [PATCH v3 RESEND 3/4] NUMA: cleanup for numa related codes

2013-03-19 Thread Gao feng
于 2013/03/19/ 17:59, Daniel P. Berrange wrote: On Tue, Mar 19, 2013 at 09:59:37AM +0800, Gao feng wrote: Intend to reduce the redundant code,use virNumaSetupMemoryPolicy to replace virLXCControllerSetupNUMAPolicy and qemuProcessInitNumaMemoryPolicy. This patch also moves the numa related

Re: [libvirt] [PATCH v3 1/4] rename qemuGetNumadAdvice to virNumaGetAutoPlacementAdvice

2013-03-19 Thread Gao feng
于 2013/03/20 05:56, Eric Blake wrote: On 03/18/2013 03:04 AM, Gao feng wrote: qemuGetNumadAdvice will be used by LXC driver,rename space after comma it to virNumaGetAutoPlacementAdvice and move it to virnuma.c Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- po/POTFILES.in

Re: [libvirt] [PATCH v5 2/3] qemu: add dtb option supprt

2013-03-19 Thread Yin Olivia-R63875
Hi Eric, You're so kind to help squash. Thank you very much. Exactly there's one more thing need fix is that 'ppce500v2' should be changed as 'ppce500' to align with qemu-1.4.0. What should I do next step? Should I post a new revision of patchset? Best Regards, Olivia -Original

Re: [libvirt] [PATCH v5 2/3] qemu: add dtb option supprt

2013-03-19 Thread Eric Blake
On 03/19/2013 07:41 PM, Yin Olivia-R63875 wrote: Hi Eric, You're so kind to help squash. Thank you very much. No problem. You can return the favor by helping review other outstanding patches. Exactly there's one more thing need fix is that 'ppce500v2' should be changed as 'ppce500' to

Re: [libvirt] [PATCH v3 RESEND 3/4] NUMA: cleanup for numa related codes

2013-03-19 Thread Eric Blake
On 03/19/2013 07:26 PM, Gao feng wrote: Also you've ignore my request to use virNumaTune as the capatilization and VIR_NUMA_TUNE for enums Get it,if I use virNumatune as the capatilization,I need to change virnuma.[c|h] to virnumatune.[c|h]? No. We want 'virNuma' to be the set of

Re: [libvirt] [PATCH v3 2/4] LXC: allow uses advisory nodeset from querying numad

2013-03-19 Thread Eric Blake
On 03/18/2013 08:30 AM, Daniel P. Berrange wrote: On Mon, Mar 18, 2013 at 05:04:02PM +0800, Gao feng wrote: Allow lxc using the advisory nodeset from querying numad, this means if user doesn't specify the numa nodes that the lxc domain should assign to, libvirt will automatically bind the lxc

Re: [libvirt] [PATCH] qemu: add PCI-multibus support for ppc

2013-03-19 Thread Yin Olivia-R63875
Hi Daniel, PPC also supports PCI multibus. Could you please help review this patch? Best Regards, Olivia -Original Message- From: Yin Olivia-R63875 Sent: Wednesday, March 13, 2013 12:44 PM To: libvir-list@redhat.com Cc: Yin Olivia-R63875 Subject: [PATCH] qemu: add PCI-multibus

[libvirt] [PATCH] replace ppce500v2 with ppce500

2013-03-19 Thread Olivia Yin
--- docs/schemas/domaincommon.rng| 2 +- tests/qemuxml2argvdata/qemuxml2argv-ppc-dtb.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-ppc-dtb.xml | 2 +- tests/testutilsqemu.c| 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git

[libvirt] [PATCH] fix TLS error with virNetServerClientCreateIdentity

2013-03-19 Thread Olivia Yin
--- src/rpc/virnetserverclient.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/rpc/virnetserverclient.c b/src/rpc/virnetserverclient.c index d407f5e..58fb0b4 100644 --- a/src/rpc/virnetserverclient.c +++ b/src/rpc/virnetserverclient.c @@ -687,6 +687,7 @@

Re: [libvirt] [PATCH] fix TLS error with virNetServerClientCreateIdentity

2013-03-19 Thread Eric Blake
On 03/19/2013 08:13 PM, Olivia Yin wrote: --- src/rpc/virnetserverclient.c | 2 ++ 1 file changed, 2 insertions(+) ACK and pushed. I tweaked the commit message to call out the culprit commit that introduced the problem (d5e83ad). -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt

Re: [libvirt] [PATCH] replace ppce500v2 with ppce500

2013-03-19 Thread Eric Blake
On 03/19/2013 08:13 PM, Olivia Yin wrote: --- docs/schemas/domaincommon.rng| 2 +- Your commit message is sparse. This is a good place to explain WHY a maintainer should apply your patch. On my Fedora 18 box, I see: $ qemu-ppc64 -cpu help | grep e500 PowerPC e500_v10

Re: [libvirt] about Application_Development_Guide.pdf

2013-03-19 Thread huyp1024
Daniel,thanks for replying ! i want to be involved with libvirt program, if I delicate myself to writing more content for the docs,what could i do ? I'm familiar with java and python,by the way ,i'm chinese,so there may be some risks that the docs i write can not be understanded by others. Best

[libvirt] [PATCH RESEND 2/2] LXC: add cpuset cgroup support for lxc

2013-03-19 Thread Gao feng
This patch adds cpuset cgroup support for LXC. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/lxc/lxc_cgroup.c | 57 +++- src/lxc/lxc_cgroup.h | 4 +++- src/lxc/lxc_controller.c | 2 +- 3 files changed, 60 insertions(+), 3

[libvirt] [PATCH RESEND 1/2] NUMA: cleanup for numa related codes

2013-03-19 Thread Gao feng
Intend to reduce the redundant code,use virNumaSetupMemoryPolicy to replace virLXCControllerSetupNUMAPolicy and qemuProcessInitNumaMemoryPolicy. This patch also moves the numa related codes to the file virnuma.c and virnuma.h Signed-off-by: Gao feng gaof...@cn.fujitsu.com ---