[libvirt] images on NFS do not have MCS when selinux is on

2013-04-08 Thread yue
hi,all i now test selinux(enforcing). i assign a nfs-image to a VM, then start it. at the beginning i set virt_use_nfs on, its image does not has a MCS corresponding to qemu-kvm process's MCS then i remount nfs with -o context=system_u:object_r:virt_image_t:s0 , restart VM, its image does

Re: [libvirt] [PATCH 2/2] LXC: rework mounting cgroupfs in container

2013-04-08 Thread Gao feng
On 2013/04/05 19:29, Daniel P. Berrange wrote: On Fri, Apr 05, 2013 at 10:16:43AM +0800, Gao feng wrote: On 2013/03/27 13:26, Gao feng wrote: On 2013/03/20 16:14, Gao feng wrote: There are 3 reason we need to rework the cgroupfs mounting in container. 1, Yin Olivia reported a failed to

Re: [libvirt] 1.4.0 memballoon bug?

2013-04-08 Thread Michal Privoznik
On 05.04.2013 21:22, Serge Hallyn wrote: Hi, When I run virsh -c qemu:///system domxml-to-native qemu-argv /tmp/qatest.xml from 1.4.0 with the qatest.xml below (which has no memballoon device specified), I get an 'unspecified error'. Some printf debugging shows that

Re: [libvirt] [PATCH] fix compilation failure under tests/

2013-04-08 Thread Daniel P. Berrange
On Sat, Apr 06, 2013 at 07:17:30AM -0600, Eric Blake wrote: On 04/05/2013 08:44 PM, Serge Hallyn wrote: Without this, I get errors like /usr/bin/ld: virnettlscontexttest.o: undefined reference to symbol 'gnutls_x509_crt_set_activation_time@@GNUTLS_1_4' /usr/bin/ld: note:

[libvirt] [PATCH] sanlock: add missing test command in virt-sanlock-cleanup.in

2013-04-08 Thread Alex Jia
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=949483 Signed-off-by: Alex Jia a...@redhat.com --- In fact, the virt-sanlock-cleanup works well on RHEL6.4, but doesn't work on RHEL7.0, and got a error line 14: x: command not found, It may be different bash version issue.

Re: [libvirt] [PATCH 5/7] util: Add helper to get the scsi host name by iterating over sysfs

2013-04-08 Thread Osier Yang
On 06/04/13 03:11, John Ferlan wrote: On 03/25/2013 12:43 PM, Osier Yang wrote: The helper iterates over sysfs, to find out the matched scsi host name by comparing the wwnn,wwpn pair. It will be used by checkPool and refreshPool of storage scsi backend. New helper getAdapterName is introduced

Re: [libvirt] [PATCH 6/7] storage: Add startPool and stopPool for scsi backend

2013-04-08 Thread Osier Yang
On 06/04/13 03:29, John Ferlan wrote: On 03/25/2013 12:43 PM, Osier Yang wrote: startPool creates the vHBA if it's not existed yet, stopPool destroys s/it's not exists/it does not exist/ Okay. the vHBA. Also to support autostart, checkPool will creates the vHBA s/creates/create Okay.

Re: [libvirt] [PATCH 7/7] storage: Guess the parent if it's not specified for vHBA

2013-04-08 Thread Osier Yang
On 06/04/13 04:01, John Ferlan wrote: On 03/25/2013 12:43 PM, Osier Yang wrote: This finds the parent for vHBA by iterating over all the HBA which supports vport_ops capability on the host, and return the first one which is online, not saturated (vports in use is less than max_vports). ---

Re: [libvirt] [PATCH 3/8] qemu: Translate the pool disk source when building drive string

2013-04-08 Thread Osier Yang
On 06/04/13 07:24, John Ferlan wrote: On 04/04/2013 03:37 PM, Osier Yang wrote: This adds a new helper qemuTranslateDiskSourcePool which uses the storage pool/vol APIs to tranlsate the disk source before building s/tranlsate/translate/ the drive string. Network volume is not supported yet.

Re: [libvirt] [PATCH 4/8] Support startupPolicy for 'volume' disk

2013-04-08 Thread Osier Yang
On 06/04/13 07:41, John Ferlan wrote: On 04/04/2013 03:37 PM, Osier Yang wrote: startupPolicy is only valid for file type storage volume, otherwise it fails on starting the domain. --- docs/formatdomain.html.in| 7 --- docs/schemas/domaincommon.rng

Re: [libvirt] [PATCH 6/8] qemu: Translate the pool disk source earlier

2013-04-08 Thread Osier Yang
On 06/04/13 08:34, John Ferlan wrote: On 04/04/2013 03:38 PM, Osier Yang wrote: To support shareable for volume type disk, we have to translate the source before trying to add the shared disk entry. To archieve s/archeive/achieve/ the goal, this moves the helper qemuTranslateDiskSourcePool

Re: [libvirt] [PATCH 8/8] qemu: Support sgio setting for volume type disk

2013-04-08 Thread Osier Yang
On 06/04/13 08:44, John Ferlan wrote: On 04/04/2013 03:38 PM, Osier Yang wrote: --- src/qemu/qemu_process.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) Perhaps a MACRO would be better to describe: !(disk-type == VIR_DOMAIN_DISK_TYPE_VOLUME + disk-srcpool +

Re: [libvirt] [PATCH 0/8 v2] Glue domain and storage

2013-04-08 Thread Osier Yang
Pushed with the nits fixed, as these patches just do additions, it's unlikely to introduce regression. Future patches will resolve the places which prevent volume type disk out of the door. Thanks for the reviewing! Osier On 05/04/13 03:37, Osier Yang wrote: This is the 4th part to implement

Re: [libvirt] [PATCHv3 0/6] Fix memory corruption/crash in the connection close callback

2013-04-08 Thread Viktor Mihajlovski
On 03/31/2013 06:20 PM, Peter Krempa wrote: This series fixes the crash resulting from a race condition in the connection close callback. To observe the crash apply the first patch only. To verify that the patchset fixes the crash please apply all but 2/6 and verify using virsh. 2/6 fixes

Re: [libvirt] [PATCHv3 0/6] Fix memory corruption/crash in the connection close callback

2013-04-08 Thread Peter Krempa
On 04/08/13 13:55, Viktor Mihajlovski wrote: I fear we're yet not thru this. Today I had a segfault doing a migration using virsh migrate --verbose --live $guest qemu+ssh://$host/system. This is with Friday's git HEAD. The migration took very long (but succeeded except for the libvirt crash) so

Re: [libvirt] [PATCH] qemu: fix qemuCgroupControllerActive

2013-04-08 Thread Osier Yang
On 08/04/13 20:29, Ján Tomko wrote: Since 56f27b3 it always returned false. --- src/qemu/qemu_cgroup.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index 2cdc2b7..9e11a05 100644 --- a/src/qemu/qemu_cgroup.c +++ b/src/qemu/qemu_cgroup.c

Re: [libvirt] [PATCH] qemu: fix qemuCgroupControllerActive

2013-04-08 Thread Daniel P. Berrange
On Mon, Apr 08, 2013 at 02:29:05PM +0200, Ján Tomko wrote: Since 56f27b3 it always returned false. --- src/qemu/qemu_cgroup.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index 2cdc2b7..9e11a05 100644 --- a/src/qemu/qemu_cgroup.c

Re: [libvirt] [PATCH 06/18] Rename virCgroupMounted to virCgroupHasController make it more robust

2013-04-08 Thread Ján Tomko
On 04/04/2013 03:40 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The virCgroupMounted method is badly named, since a controller can be mounted, but disabled in the current object. Rename the method to be virCgroupHasController. Also make it tolerant to a NULL

[libvirt] [PATCH glib 2/2] Add framework for i18n of error message strings

2013-04-08 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Signed-off-by: Daniel P. Berrange berra...@redhat.com --- .gitignore | 7 + Makefile.am | 2 +- autogen.sh | 28 ++ configure.ac

[libvirt] [PATCH glib 1/2] Add printf/sentinel attribute annotations to helper functions

2013-04-08 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com To allow the compiler to check args add G_GNUC_PRINTF and G_GNUC_NULL_TERMINATED to libvirt-gconfig-helpers-private.h Signed-off-by: Daniel P. Berrange berra...@redhat.com --- libvirt-gconfig/libvirt-gconfig-helpers-private.h | 12 1

[libvirt] [PATCH v2] Link libxml2 and libdbus in tests which need it.

2013-04-08 Thread Serge Hallyn
Some tests fail to build without libxml2 or libdbus specified, add them where needed. Without this, I get errors like /usr/bin/ld: virnettlscontexttest.o: undefined reference to symbol 'gnutls_x509_crt_set_activation_time@@GNUTLS_1_4' /usr/bin/ld: note:

[libvirt] [PATCH 0/2] Add support for translations

2013-04-08 Thread Daniel P. Berrange
libvirt-glib contains a bunch of user visible error message strings which need translation. These patches wire up the glib/intltool/gettext i18n framework I have created a transifex project to go with it https://www.transifex.com/projects/p/libvirt-glib/ -- libvir-list mailing list

[libvirt] [PATCH] spec: Require pod2man when running autoreconf

2013-04-08 Thread Jiri Denemark
Since commit b8a32e0e94d75702714167539310f0df4d268e0f, all man pages depend on configure.ac so that they are properly regenerated whenever libvirt version changes. Thus libvirt.spec needs to have a build dependency on pod2man when %{enable_autotools} is set. --- libvirt.spec.in | 1 + 1 file

Re: [libvirt] [PATCH v2] Link libxml2 and libdbus in tests which need it.

2013-04-08 Thread Daniel P. Berrange
On Mon, Apr 08, 2013 at 07:54:55AM -0500, Serge Hallyn wrote: Some tests fail to build without libxml2 or libdbus specified, add them where needed. Without this, I get errors like /usr/bin/ld: virnettlscontexttest.o: undefined reference to symbol

Re: [libvirt] [libvirt-designer] build: No need to set PKG_CONFIG_PATH for g-ir-scanner

2013-04-08 Thread Christophe Fergeau
On Sat, Apr 06, 2013 at 03:28:04AM +0300, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org I don't see any need for this and it actually breaks the build here: ACK, this is probably there through CP. Christophe GEN LibvirtDesigner-1.0.gir Package

Re: [libvirt] [PATCHv3 0/6] Fix memory corruption/crash in the connection close callback

2013-04-08 Thread Peter Krempa
[Re-sending, there was probably a problem and the mail didn't reach the list apparently] On 04/08/13 14:06, Peter Krempa wrote: On 04/08/13 13:55, Viktor Mihajlovski wrote: I fear we're yet not thru this. Today I had a segfault doing a migration using virsh migrate --verbose --live $guest

Re: [libvirt] [PATCH 0/2] Add support for translations

2013-04-08 Thread Daniel Veillard
On Mon, Apr 08, 2013 at 01:54:19PM +0100, Daniel P. Berrange wrote: libvirt-glib contains a bunch of user visible error message strings which need translation. These patches wire up the glib/intltool/gettext i18n framework I have created a transifex project to go with it

Re: [libvirt] [PATCH] spec: Require pod2man when running autoreconf

2013-04-08 Thread Peter Krempa
On 04/08/13 15:00, Jiri Denemark wrote: Since commit b8a32e0e94d75702714167539310f0df4d268e0f, all man pages depend on configure.ac so that they are properly regenerated whenever libvirt version changes. Thus libvirt.spec needs to have a build dependency on pod2man when %{enable_autotools} is

Re: [libvirt] [PATCH 0/2] Add support for translations

2013-04-08 Thread Daniel P. Berrange
On Mon, Apr 08, 2013 at 09:09:51PM +0800, Daniel Veillard wrote: On Mon, Apr 08, 2013 at 01:54:19PM +0100, Daniel P. Berrange wrote: libvirt-glib contains a bunch of user visible error message strings which need translation. These patches wire up the glib/intltool/gettext i18n framework

[libvirt] [PATCH] Reusing the result of virArchFromHost instead of calling it multiple times

2013-04-08 Thread Tal Kain
Signed-off-by: Tal Kain tal.k...@ravellosystems.com --- src/qemu/qemu_capabilities.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 50712b0..b235059 100644 --- a/src/qemu/qemu_capabilities.c +++

Re: [libvirt] [PATCHv3 0/6] Fix memory corruption/crash in the connection close callback

2013-04-08 Thread Peter Krempa
On 04/08/13 14:06, Peter Krempa wrote: On 04/08/13 13:55, Viktor Mihajlovski wrote: I fear we're yet not thru this. Today I had a segfault doing a migration using virsh migrate --verbose --live $guest qemu+ssh://$host/system. This is with Friday's git HEAD. The migration took very long (but

Re: [libvirt] [PATCH 0/2] Add support for translations

2013-04-08 Thread Daniel Veillard
On Mon, Apr 08, 2013 at 09:09:51PM +0800, Daniel Veillard wrote: On Mon, Apr 08, 2013 at 01:54:19PM +0100, Daniel P. Berrange wrote: libvirt-glib contains a bunch of user visible error message strings which need translation. These patches wire up the glib/intltool/gettext i18n framework

Re: [libvirt] [PATCH] Reusing the result of virArchFromHost instead of calling it multiple times

2013-04-08 Thread Daniel P. Berrange
On Mon, Apr 08, 2013 at 03:33:07PM +0300, Tal Kain wrote: Signed-off-by: Tal Kain tal.k...@ravellosystems.com --- src/qemu/qemu_capabilities.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) What is the motivation for doing this ? it just looks like overkill to me,

Re: [libvirt] [PATCH] Add error handling to optional arguments in cmdCPUStats

2013-04-08 Thread Ján Tomko
On 04/05/2013 10:40 PM, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=907732 Also added informational message when count value is larger than number of CPUs present. Original code commit '31047e2b' quietly changes it and continues on. Prior to this patch, no errors were

Re: [libvirt] [PATCH v2] Link libxml2 and libdbus in tests which need it.

2013-04-08 Thread Serge Hallyn
Quoting Daniel P. Berrange (berra...@redhat.com): On Mon, Apr 08, 2013 at 07:54:55AM -0500, Serge Hallyn wrote: Some tests fail to build without libxml2 or libdbus specified, add them where needed. Without this, I get errors like /usr/bin/ld: virnettlscontexttest.o: undefined

Re: [libvirt] [PATCH v2] Link libxml2 and libdbus in tests which need it.

2013-04-08 Thread Daniel P. Berrange
On Mon, Apr 08, 2013 at 08:41:27AM -0500, Serge Hallyn wrote: Quoting Daniel P. Berrange (berra...@redhat.com): On Mon, Apr 08, 2013 at 07:54:55AM -0500, Serge Hallyn wrote: Some tests fail to build without libxml2 or libdbus specified, add them where needed. Without this, I get

Re: [libvirt] [PATCH 03/18] Introduce a virFileDeleteTree method

2013-04-08 Thread Daniel P. Berrange
On Thu, Apr 04, 2013 at 11:56:29AM -0600, Eric Blake wrote: On 04/04/2013 07:40 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Introduce a method virFileDeleteTree for recursively deleting an entire directory tree Signed-off-by: Daniel P. Berrange

Re: [libvirt] [PATCH] spec: Require pod2man when running autoreconf

2013-04-08 Thread Jiri Denemark
On Mon, Apr 08, 2013 at 15:11:01 +0200, Peter Krempa wrote: On 04/08/13 15:00, Jiri Denemark wrote: Since commit b8a32e0e94d75702714167539310f0df4d268e0f, all man pages depend on configure.ac so that they are properly regenerated whenever libvirt version changes. Thus libvirt.spec needs to

Re: [libvirt] 1.4.0 memballoon bug?

2013-04-08 Thread Serge Hallyn
Quoting Michal Privoznik (mpriv...@redhat.com): On 05.04.2013 21:22, Serge Hallyn wrote: Hi, When I run virsh -c qemu:///system domxml-to-native qemu-argv /tmp/qatest.xml from 1.4.0 with the qatest.xml below (which has no memballoon device specified), I get an 'unspecified

Re: [libvirt] [PATCH v2 01/10] conf: Introduce readonly to hostdev and change helper function

2013-04-08 Thread Laine Stump
On 04/05/2013 05:10 AM, Han Cheng wrote: On 04/02/2013 10:15 AM, Hu Tao wrote: On Mon, Apr 01, 2013 at 08:00:53PM +0800, Han Cheng wrote: diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index edddf25..f8e3973 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@

[libvirt] [PATCH] Unmount existing filesystems under user specified mounts in LXC

2013-04-08 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com If the user requests a mount for /run, this may hide any existing mounts that are lower down in /run. The result is that the container still sees the mounts in /proc/mounts, but cannot access them sh-4.2# df df: '/run/user/501/gvfs': No such file or

Re: [libvirt] [PATCH v2 01/10] conf: Introduce readonly to hostdev and change helper function

2013-04-08 Thread Daniel P. Berrange
On Mon, Apr 08, 2013 at 11:13:51AM -0400, Laine Stump wrote: On 04/05/2013 05:10 AM, Han Cheng wrote: On 04/02/2013 10:15 AM, Hu Tao wrote: On Mon, Apr 01, 2013 at 08:00:53PM +0800, Han Cheng wrote: diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index edddf25..f8e3973 100644

[libvirt] [libvirt-designer] Add myself to AUTHORS file

2013-04-08 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- Pushed under trivial rule. AUTHORS | 1 + 1 file changed, 1 insertion(+) diff --git a/AUTHORS b/AUTHORS index db9d798..79812d7 100644 --- a/AUTHORS +++ b/AUTHORS @@ -9,5 +9,6 @@ Patches have been received from: Christophe Fergeau

[libvirt] [PATCH v2 1/2] Remove extraneous comma in info_cpu_stats and opts_cpu_stats

2013-04-08 Thread John Ferlan
--- tools/virsh-domain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index c088468..e6e6877 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -6111,7 +6111,7 @@ static const vshCmdInfo info_cpu_stats[] = {

[libvirt] [PATCH v2 0/2] Add error handling to optional arguments in cmdCPUStats

2013-04-08 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=907732 Also added informational message when count value is larger than number of CPUs present. Original code commit '31047e2b' quietly changes it and continues on. Prior to patch 2/2, no errors were seen for following

[libvirt] [PATCH v2 2/2] Add error handling to optional arguments in cmdCPUStats

2013-04-08 Thread John Ferlan
--- tools/virsh-domain.c | 29 ++--- 1 file changed, 26 insertions(+), 3 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index e6e6877..6d760f2 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -6144,15 +6144,35 @@

[libvirt] [PATCH glib] Auto-generate AUTHORS file from GIT logs during make dist

2013-04-08 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Instead of manually keeping the AUTHORS file in sync with GIT, auto-generate it during make dist phase Signed-off-by: Daniel P. Berrange berra...@redhat.com --- AUTHORS = AUTHORS.in | 9 + ChangeLog | 0 Makefile.am |

Re: [libvirt] [PATCH 03/18] Introduce a virFileDeleteTree method

2013-04-08 Thread Eric Blake
On 04/08/2013 08:04 AM, Daniel P. Berrange wrote: We should use gnulib's LGPL unlinkat. On capable kernels, it avoids O(n^2) behavior that is inherent in computing filenames in a deep hierarchy. On less capable kernels, it still makes this code simpler to write (no virAsprintf needed here).

[libvirt] [PATCH designer] Auto-generate AUTHORS file from GIT logs

2013-04-08 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Rather than trying to manually keep track of authors, just auto-generate the list from GIT logs Signed-off-by: Daniel P. Berrange berra...@redhat.com --- .gitignore| 2 ++ AUTHORS = AUTHORS.in | 4 +--- ChangeLog | 0

[libvirt] VNC Server in libvirt

2013-04-08 Thread Jaime Loureiro Acuña
My name is Jaime Loureiro and I work in the Network Applications area in University of Vigo. I am writing to you hoping you can help me with some libvirt graphics issues. I was analysing the source code of the libvirt in order to find how to access the display of each virtual machine. We are

Re: [libvirt] [PATCH] Unmount existing filesystems under user specified mounts in LXC

2013-04-08 Thread Eric Blake
On 04/08/2013 09:12 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com If the user requests a mount for /run, this may hide any existing mounts that are lower down in /run. The result is that the container still sees the mounts in /proc/mounts, but cannot access them

[libvirt] [PATCH] Move lxcContainerUnmountSubtree further up in file

2013-04-08 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Ensure lxcContainerUnmountSubtree is at the top of the lxc_container.c file so it is easily referenced from any other method. No functional change Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/lxc/lxc_container.c | 214

Re: [libvirt] [PATCH] Unmount existing filesystems under user specified mounts in LXC

2013-04-08 Thread Eric Blake
On 04/08/2013 10:07 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com If the user requests a mount for /run, this may hide any existing mounts that are lower down in /run. The result is that the container still sees the mounts in /proc/mounts, but cannot access them

Re: [libvirt] [PATCH] Move lxcContainerUnmountSubtree further up in file

2013-04-08 Thread Eric Blake
On 04/08/2013 10:07 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Ensure lxcContainerUnmountSubtree is at the top of the lxc_container.c file so it is easily referenced from any other method. No functional change Signed-off-by: Daniel P. Berrange

Re: [libvirt] [libvirt-php PATCH 1/1] src/Makefile.am: use LDFLAGS for libvirt-php.so

2013-04-08 Thread Michal Novotny
On 01/31/2013 08:12 PM, stefan.k...@foss-group.ch wrote: --- src/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Makefile.am b/src/Makefile.am index 0d08448..18b868b 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -14,7 +14,7 @@ build:

Re: [libvirt] [libvirt-php PATCH 1/1] Fix: mutlithreading compilation: set_error needs 2 params

2013-04-08 Thread Michal Novotny
On 02/01/2013 03:25 PM, stefan.k...@foss-group.ch wrote: --- src/libvirt-php.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 7e7710c..0b8345a 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -1615,7

Re: [libvirt] [libvirt-php PATCH 1/1] $(LIBS) must be at the end in the linker line

2013-04-08 Thread Michal Novotny
On 02/04/2013 11:07 AM, stefan.k...@foss-group.ch wrote: --- src/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Makefile.am b/src/Makefile.am index 18b868b..3f2de38 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -14,7 +14,7 @@ build:

[libvirt] [PATCH] Generate RFC4122 compliant UUIDs

2013-04-08 Thread Milos Vyletel
Even though http://libvirt.org/formatdomain.html#elementsMetadata states that it requires RFC4122 compliance UUIDs that are generated by virUUIDGenerate() are not. Neither does virUUIDIsValid() check for RFC4122 compliance. Following patch modifies virUUIDGenerate() to generate valid UUIDs and

Re: [libvirt] new libvirt pci controller type and pcie/q35 (was Re: [PATCH 4/7] add pci-bridge controller type)

2013-04-08 Thread Laine Stump
On 04/05/2013 03:26 PM, Alex Williamson wrote: On Fri, 2013-04-05 at 14:42 -0400, Laine Stump wrote: On 04/05/2013 01:38 PM, Daniel P. Berrange wrote: On Fri, Apr 05, 2013 at 12:32:04PM -0400, Laine Stump wrote: On 04/03/2013 11:50 AM, Ján Tomko wrote: From: liguang lig.f...@cn.fujitsu.com

Re: [libvirt] [PATCH v2 1/2] Update structure XML definitions to support hostdev caps=net

2013-04-08 Thread Daniel P. Berrange
On Fri, Apr 05, 2013 at 08:26:39AM -0400, Bogdan Purcareata wrote: This updates the definitions and supporting structures in the XML schema and domain configuration files. Signed-off-by: Bogdan Purcareata bogdan.purcare...@freescale.com --- docs/formatdomain.html.in | 15

Re: [libvirt] new libvirt pci controller type and pcie/q35 (was Re: [PATCH 4/7] add pci-bridge controller type)

2013-04-08 Thread Daniel P. Berrange
On Mon, Apr 08, 2013 at 12:37:49PM -0400, Laine Stump wrote: On 04/05/2013 03:26 PM, Alex Williamson wrote: I think we're starting to get closer to the concrete problem that's bothering me. As I understand it (and again - what I understand has repeatedly been shown to be incorrect in this

Re: [libvirt] [PATCH v2 2/2] Implement support for hostdev caps=net

2013-04-08 Thread Daniel P. Berrange
On Fri, Apr 05, 2013 at 08:26:40AM -0400, Bogdan Purcareata wrote: This allows a container-type domain to have exclusive access to one of the host's NICs. Wire hostdev caps=net with the lxc_controller - when moving the newly created veth devices into a new namespace, also look for any

Re: [libvirt] [PATCH glib] Auto-generate AUTHORS file from GIT logs during make dist

2013-04-08 Thread Michal Privoznik
On 08.04.2013 17:40, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Instead of manually keeping the AUTHORS file in sync with GIT, auto-generate it during make dist phase Signed-off-by: Daniel P. Berrange berra...@redhat.com --- AUTHORS = AUTHORS.in | 9

Re: [libvirt] [PATCH designer] Auto-generate AUTHORS file from GIT logs

2013-04-08 Thread Michal Privoznik
On 08.04.2013 17:46, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Rather than trying to manually keep track of authors, just auto-generate the list from GIT logs Signed-off-by: Daniel P. Berrange berra...@redhat.com --- .gitignore| 2 ++ AUTHORS =

Re: [libvirt] [PATCH] Generate RFC4122 compliant UUIDs

2013-04-08 Thread Milos Vyletel
- Original Message - On Mon, Apr 08, 2013 at 12:35:40PM -0400, Milos Vyletel wrote: Even though http://libvirt.org/formatdomain.html#elementsMetadata states that it requires RFC4122 compliance UUIDs that are generated by virUUIDGenerate() are not. Neither does virUUIDIsValid()

Re: [libvirt] [PATCH] Generate RFC4122 compliant UUIDs

2013-04-08 Thread Eric Blake
On 04/08/2013 10:45 AM, Daniel P. Berrange wrote: On Mon, Apr 08, 2013 at 12:35:40PM -0400, Milos Vyletel wrote: Even though http://libvirt.org/formatdomain.html#elementsMetadata states that it requires RFC4122 compliance UUIDs that are generated by virUUIDGenerate() are not. Neither does

[libvirt] [PATCHv2] Generate RFC4122 compliant UUIDs

2013-04-08 Thread Milos Vyletel
Even though http://libvirt.org/formatdomain.html#elementsMetadata states that it requires RFC4122 compliance UUIDs that are generated by virUUIDGenerate() are not. Following patch modifies generated UUIDs to conform to rules described in RFC. Signed-off-by: Milos Vyletel milos.vyle...@sde.cz ---

Re: [libvirt] [PATCHv2] Generate RFC4122 compliant UUIDs

2013-04-08 Thread Eric Blake
On 04/08/2013 12:10 PM, Milos Vyletel wrote: Even though http://libvirt.org/formatdomain.html#elementsMetadata states that it requires RFC4122 compliance UUIDs that are generated by virUUIDGenerate() are not. Following patch modifies generated UUIDs to conform to rules described in RFC.

Re: [libvirt] new libvirt pci controller type and pcie/q35 (was Re: [PATCH 4/7] add pci-bridge controller type)

2013-04-08 Thread Laine Stump
On 04/08/2013 12:48 PM, Daniel P. Berrange wrote: On Mon, Apr 08, 2013 at 12:37:49PM -0400, Laine Stump wrote: I think we're starting to get closer to the concrete problem that's bothering me. As I understand it (and again - what I understand has repeatedly been shown to be incorrect in this

[libvirt] We've been accepted to Google Summer of Code 2013

2013-04-08 Thread Stefan Hajnoczi
Good news! QEMU.org has been accepted to Google Summer of Code 2013. This means students can begin considering our list of QEMU, kvm kernel module, and libvirt project ideas: http://qemu-project.org/Google_Summer_of_Code_2013 Student applications open April 22 at 19:00 UTC. You can already

Re: [libvirt] images on NFS do not have MCS when selinux is on

2013-04-08 Thread Eric Blake
On 04/08/2013 12:45 AM, yue wrote: hi,all i now test selinux(enforcing). i assign a nfs-image to a VM, then start it. at the beginning i set virt_use_nfs on, its image does not has a MCS corresponding to qemu-kvm process's MCS then i remount nfs with -o

Re: [libvirt] [PATCH] sanlock: add missing test command in virt-sanlock-cleanup.in

2013-04-08 Thread Eric Blake
On 04/08/2013 03:46 AM, Alex Jia wrote: RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=949483 Signed-off-by: Alex Jia a...@redhat.com --- In fact, the virt-sanlock-cleanup works well on RHEL6.4, but doesn't work on RHEL7.0, and got a error line 14: x: command not found, It may be

Re: [libvirt] new libvirt pci controller type and pcie/q35 (was Re: [PATCH 4/7] add pci-bridge controller type)

2013-04-08 Thread Michael S. Tsirkin
On Mon, Apr 08, 2013 at 03:32:07PM -0400, Laine Stump wrote: On 04/08/2013 12:48 PM, Daniel P. Berrange wrote: On Mon, Apr 08, 2013 at 12:37:49PM -0400, Laine Stump wrote: I think we're starting to get closer to the concrete problem that's bothering me. As I understand it (and again - what

Re: [libvirt] [PATCHv3 0/6] Fix memory corruption/crash in the connection close callback

2013-04-08 Thread Eric Blake
On 03/31/2013 10:20 AM, Peter Krempa wrote: This series fixes the crash resulting from a race condition in the connection close callback. To observe the crash apply the first patch only. To verify that the patchset fixes the crash please apply all but 2/6 and verify using virsh. 2/6 fixes

Re: [libvirt] new libvirt pci controller type and pcie/q35 (was Re: [PATCH 4/7] add pci-bridge controller type)

2013-04-08 Thread Laine Stump
On 04/08/2013 03:37 PM, Michael S. Tsirkin wrote: On Mon, Apr 08, 2013 at 03:32:07PM -0400, Laine Stump wrote: On 04/08/2013 12:48 PM, Daniel P. Berrange wrote: On Mon, Apr 08, 2013 at 12:37:49PM -0400, Laine Stump wrote: I think we're starting to get closer to the concrete problem that's

Re: [libvirt] [PATCHv3 0/6] Fix memory corruption/crash in the connection close callback

2013-04-08 Thread Eric Blake
On 04/08/2013 02:42 PM, Eric Blake wrote: On 03/31/2013 10:20 AM, Peter Krempa wrote: This series fixes the crash resulting from a race condition in the connection close callback. To observe the crash apply the first patch only. To verify that the patchset fixes the crash please apply all

Re: [libvirt] new libvirt pci controller type and pcie/q35 (was Re: [PATCH 4/7] add pci-bridge controller type)

2013-04-08 Thread Alex Williamson
On Mon, 2013-04-08 at 12:37 -0400, Laine Stump wrote: On 04/05/2013 03:26 PM, Alex Williamson wrote: On Fri, 2013-04-05 at 14:42 -0400, Laine Stump wrote: On 04/05/2013 01:38 PM, Daniel P. Berrange wrote: On Fri, Apr 05, 2013 at 12:32:04PM -0400, Laine Stump wrote: On 04/03/2013 11:50 AM,

Re: [libvirt] [PATCHv3 0/6] Fix memory corruption/crash in the connection close callback

2013-04-08 Thread Eric Blake
On 04/08/2013 07:04 AM, Peter Krempa wrote: Aiee, perhaps a race between a thread freeing a domain object (and the private data) and another thread that happened to acquire the domain object pointer before it was freed? Let me verify if that is possible. Ufff. The domain objects in the qemu

[libvirt] [PATCH v2.5 02/10] docs/schemas: Move PortNumber and sourceinfoadapter to basictypes.rng

2013-04-08 Thread Han Cheng
The definiton of scsi adapter in storagespool.rng (sourceinfoadapter) can be used by scsi hostdev. Move it to basictypes.rng. PortNumber is defined in both domaincommon.rng and storagespool.rng, simplify it by moving it to basictypes.rng. Signed-off-by: Han Cheng hanc.f...@cn.fujitsu.com ---

[libvirt] [PATCH v2.5 00/10] add support for scsi-generic for virtio-scsi

2013-04-08 Thread Han Cheng
This patch series tried to add support for scsi-generic for virtio-scsi. Changes from v2: - Lots of fixs on comments Thank you guys who reviewed these. Thank you for your help. There is some work left. As time comes up and I don't have much time to do this, I'd like to ask Osier to help me

[libvirt] [PATCH v2.5 01/10] conf: Change help function

2013-04-08 Thread Han Cheng
The helper function to look up disk controller model may be used by scsi hostdev. But it should be changed to use device info. Signed-off-by: Han Cheng hanc.f...@cn.fujitsu.com --- src/conf/domain_conf.c |8 src/conf/domain_conf.h |6 +++--- src/libvirt_private.syms |2

[libvirt] [PATCH v2.5 09/10] qemu: hotplug support for scsi hostdev

2013-04-08 Thread Han Cheng
This patch adds hotplug for scsi hostdev. And user should hotplug a virtio-scsi controller if doesn't exist. Usb hostdev related codes are in qemuDomainAttachHostDevice, push down to qemuDomainAttachHostUsbDevice. Signed-off-by: Han Cheng hanc.f...@cn.fujitsu.com --- src/qemu/qemu_hotplug.c |

[libvirt] [PATCH v2.5 03/10] conf: Introduce scsi hostdev

2013-04-08 Thread Han Cheng
Add scsi hostdev, it looks like: hostdev mode='subsystem' type='scsi' source adapter name='scsi_host0'/ address bus='0' target='0' unit='0'/ /source address type='drive' controller='0' bus='0' target='4' unit='8'/ /hostdev The only parameter in -drive

[libvirt] [PATCH v2.5 07/10] qemu: Basic management functions for scsi hostdev

2013-04-08 Thread Han Cheng
Although virtio-scsi support SCSI PR, the device in host may do not support this. To avoid losing data, we only allow one scsi hostdev be passthrough to one live guest. Signed-off-by: Han Cheng hanc.f...@cn.fujitsu.com --- src/qemu/qemu_conf.h|2 + src/qemu/qemu_driver.c |3 +

[libvirt] [PATCH v2.5 05/10] utils: util functions for scsi hostdev

2013-04-08 Thread Han Cheng
This patch adds util functions for scsi hostdev. Signed-off-by: Han Cheng hanc.f...@cn.fujitsu.com --- po/POTFILES.in |1 + src/Makefile.am |1 + src/libvirt_private.syms | 22 +++ src/util/virscsi.c | 392 ++

[libvirt] [PATCH v2.5 08/10] qemu: cgroup and selinux for scsi hostdev

2013-04-08 Thread Han Cheng
As libvirt gives guest minimal cgroup, we need to add sg into guest cgroup whitelist for scsi hostdev. And we should set and restore selinux label correctly for scsi hostdev. Signed-off-by: Han Cheng hanc.f...@cn.fujitsu.com --- src/qemu/qemu_cgroup.c | 71

Re: [libvirt] [PATCH] sanlock: add missing test command in virt-sanlock-cleanup.in

2013-04-08 Thread Alex Jia
On 04/09/2013 04:16 AM, Eric Blake wrote: On 04/08/2013 03:46 AM, Alex Jia wrote: RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=949483 Signed-off-by: Alex Jiaa...@redhat.com --- In fact, the virt-sanlock-cleanup works well on RHEL6.4, but doesn't work on RHEL7.0, and got a error line 14:

Re: [libvirt] [PATCHv3 0/6] Fix memory corruption/crash in the connection close callback

2013-04-08 Thread Eric Blake
On 04/08/2013 08:27 PM, Eric Blake wrote: On 04/08/2013 07:04 AM, Peter Krempa wrote: Aiee, perhaps a race between a thread freeing a domain object (and the private data) and another thread that happened to acquire the domain object pointer before it was freed? Let me verify if that is

Re: [libvirt] [PATCH v2.5 00/10] add support for scsi-generic for virtio-scsi

2013-04-08 Thread Osier Yang
On 09/04/13 10:32, Han Cheng wrote: This patch series tried to add support for scsi-generic for virtio-scsi. Changes from v2: - Lots of fixs on comments Thank you guys who reviewed these. Thank you for your help. There is some work left. As time comes up and I don't have much time to do

[libvirt] fail to convert qemu xml to args with libvirt-1.0.4: An error occurred, but the cause is unknown

2013-04-08 Thread Yin Olivia-R63875
Hi, I used to convert qemu XML to args with libvirt-1.0.3. But it failed to convert with libvirt-1.0.4. # virsh domxml-to-native qemu-argv test.xml test.sh error: An error occurred, but the cause is unknown Comparing the debug file as below: 1) lbvirt-1.0.3 cut 2013-04-09 03:23:47.296+: