Re: [libvirt] [PATCH] network: Don't remove transient network if creating of config file fails

2013-04-30 Thread Peter Krempa
On 04/29/13 18:07, Laine Stump wrote: On 04/22/2013 05:32 AM, Peter Krempa wrote: On the off-chance that creation of persistent configuration file would fail when defining a network that is already started as transient, the code would remove the transient data structure and thus the network.

Re: [libvirt] [PATCH] qemu: Error out if spice port autoallocation is requested, but disabled

2013-04-30 Thread Peter Krempa
On 04/29/13 18:25, Eric Blake wrote: On 04/29/2013 05:50 AM, Peter Krempa wrote: When a user requests auto-allocation of the spice TLS port but spice TLS is disabled in qemu.conf, we start the machine and let qemu fail instead of erroring out sooner. Add an error message so that this doesn't

Re: [libvirt] [PATCH v2] virsh: fix incorrect argument errors for long options

2013-04-30 Thread Ján Tomko
On 04/29/2013 10:48 PM, Eric Blake wrote: On 04/29/2013 11:27 AM, Ján Tomko wrote: For long options, print: * the option as specified by the user if it's unknown * the cannoncial long option if its argument is not s/cannonical/canonical/ ... a number (and should be) And for missing

Re: [libvirt] [PATCH v2 2/2] qemu: report an error if memballoon has wrong address type

2013-04-30 Thread Ján Tomko
On 04/30/2013 12:14 AM, Eric Blake wrote: On 04/29/2013 12:20 PM, Ján Tomko wrote: qemuBuildMemballoonDevStr returns NULL if memballoon doesn't have the right address type, but it doesn't report an error, leading to: error: An error occurred, but the cause is unknown Report a helpful error

Re: [libvirt] [PATCH 1/2] libxl: expose multiple emulators per guest in the capabilities XML

2013-04-30 Thread Daniel P. Berrange
On Mon, Apr 29, 2013 at 11:01:04PM -0600, Jim Fehlig wrote: Daniel P. Berrange wrote: On Mon, Apr 29, 2013 at 12:18:56PM -0600, Jim Fehlig wrote: David Scott wrote: libxl allows users to choose between two standard emulators: 1. (default in xen-4.2): qemu traditional (aka

Re: [libvirt] [PATCH 1/2] libxl: expose multiple emulators per guest in the capabilities XML

2013-04-30 Thread Daniel P. Berrange
On Mon, Apr 29, 2013 at 12:54:55PM -0600, Jim Fehlig wrote: Daniel P. Berrange wrote: NB, for any single (arch, domain, os_type) triple, we should only report one guest in the capabilities XML. IIUC, your code above report cause us to have two entries for the same triple. Right.

Re: [libvirt] LXC: user namespaces

2013-04-30 Thread Daniel P. Berrange
On Mon, Apr 29, 2013 at 11:16:12PM +0200, Richard RW. Weinberger wrote: Hi! We'd like to use libvirt for managing our lxc machines. Currently libvirt lacks of user namespace support. Is anyone working on that? Otherwise David and I will implement it and send patches very soon. There were

[libvirt] RFE: Ability to freeze/thaw guest using libvirt/virsh APIs

2013-04-30 Thread Deepak C Shetty
I am sending this mail based on the below IRC discussion. Apr 23 18:55:02 deepakcs Hi all, is there a way to just do a fsfreeze (and un-freeze) of VM usign virsh. I don't see any option today Apr 23 18:55:52 deepakcs there is option to take snapshot (which in turn would do

Re: [libvirt] LXC: user namespaces

2013-04-30 Thread Richard RW. Weinberger
- Ursprüngliche Mail - We'd like to use libvirt for managing our lxc machines. Currently libvirt lacks of user namespace support. Is anyone working on that? Otherwise David and I will implement it and send patches very soon. There were some people at Fujitsu who have done a

Re: [libvirt] LXC: user namespaces

2013-04-30 Thread Daniel P. Berrange
On Tue, Apr 30, 2013 at 12:07:33PM +0200, Richard RW. Weinberger wrote: - Ursprüngliche Mail - We'd like to use libvirt for managing our lxc machines. Currently libvirt lacks of user namespace support. Is anyone working on that? Otherwise David and I will implement it and send

Re: [libvirt] LXC: user namespaces

2013-04-30 Thread Richard RW. Weinberger
- Ursprüngliche Mail - On Tue, Apr 30, 2013 at 12:07:33PM +0200, Richard RW. Weinberger wrote: - Ursprüngliche Mail - We'd like to use libvirt for managing our lxc machines. Currently libvirt lacks of user namespace support. Is anyone working on that? Otherwise

Re: [libvirt] LXC: user namespaces

2013-04-30 Thread Daniel P. Berrange
On Tue, Apr 30, 2013 at 12:17:15PM +0200, Richard RW. Weinberger wrote: - Ursprüngliche Mail - On Tue, Apr 30, 2013 at 12:07:33PM +0200, Richard RW. Weinberger wrote: - Ursprüngliche Mail - We'd like to use libvirt for managing our lxc machines. Currently libvirt

Re: [libvirt] [PATCH 2/2] libxl: allow an emulator to be selected in the domain config XML

2013-04-30 Thread David Scott
Jim, Daniel, thanks for all the feedback! On 29/04/13 20:02, Jim Fehlig wrote: [ snip ] As mentioned in my other response [1], your original patch (with a check to verify the requested emulator exists) should be sufficient. OK, I'll send an emulator-only patch shortly. Cheers, Dave --

[libvirt] [PATCH] libxl: allow an emulator to be selected in the domain config XML

2013-04-30 Thread David Scott
The emulator path supplied can be any valid path on the system. Note that when setting a device_model, libxl needs us to set the device_model_version too. The device_model_version can be either ...QEMU_XEN: meaning upstream qemu, the default in xen-4.3 onwards ...QEMU_XEN_TRADITIONAL: the

Re: [libvirt] [PATCH v2 23/37] Adapt to VIR_STRDUP in src/storage/*

2013-04-30 Thread John Ferlan
On 04/29/2013 09:50 AM, Michal Privoznik wrote: --- src/storage/parthelper.c | 7 --- src/storage/storage_backend.c | 16 ++-- src/storage/storage_backend_disk.c| 14 +++--- src/storage/storage_backend_fs.c | 17 -

[libvirt] [PATCH] libvirt-guests: status: return non-zero when stopped

2013-04-30 Thread Ján Tomko
Return 3 when the service is stopped, whether there are saved guests or not. --- tools/libvirt-guests.sh.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/libvirt-guests.sh.in b/tools/libvirt-guests.sh.in index 4f2e203..261c488 100644 --- a/tools/libvirt-guests.sh.in

Re: [libvirt] [PATCH v2] qemu: Generate agent socket path if missing

2013-04-30 Thread Jiri Denemark
On Wed, Apr 24, 2013 at 11:21:48 +0200, Michal Privoznik wrote: It's not desired to force users imagine path for a socket they are not even supposed to connect to. On the other hand, we already have a release where the qemu agent socket path is exposed to XML, so we cannot silently drop it

[libvirt] [PATCH] virsh: clarify vol-{down,up}load description

2013-04-30 Thread Ján Tomko
Mention file/volume contents instead of just 'file'/'volume'. Also change Download-download in vol-download help, to be consistent with other volume commands. https://bugzilla.redhat.com/show_bug.cgi?id=955537 --- tools/virsh-volume.c | 8 1 file changed, 4 insertions(+), 4

Re: [libvirt] [PATCH] virsh: clarify vol-{down,up}load description

2013-04-30 Thread Peter Krempa
On 04/30/13 14:32, Ján Tomko wrote: Mention file/volume contents instead of just 'file'/'volume'. Also change Download-download in vol-download help, to be consistent with other volume commands. https://bugzilla.redhat.com/show_bug.cgi?id=955537 --- tools/virsh-volume.c | 8 1 file

Re: [libvirt] [PATCH] virsh: clarify vol-{down,up}load description

2013-04-30 Thread Ján Tomko
On 04/30/2013 02:35 PM, Peter Krempa wrote: On 04/30/13 14:32, Ján Tomko wrote: Mention file/volume contents instead of just 'file'/'volume'. Also change Download-download in vol-download help, to be consistent with other volume commands. https://bugzilla.redhat.com/show_bug.cgi?id=955537

Re: [libvirt] [PATCH v2 27/37] Adapt to VIR_STRDUP in src/vbox/*

2013-04-30 Thread John Ferlan
On 04/29/2013 09:50 AM, Michal Privoznik wrote: --- src/vbox/vbox_XPCOMCGlue.c | 4 +- src/vbox/vbox_tmpl.c | 190 +++-- 2 files changed, 98 insertions(+), 96 deletions(-) ... diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c

Re: [libvirt] [PATCH v2 32/37] Adapt to VIR_STRDUP in src/xenxs/*

2013-04-30 Thread John Ferlan
On 04/29/2013 09:50 AM, Michal Privoznik wrote: --- src/xenxs/xen_sxpr.c | 107 +-- src/xenxs/xen_xm.c | 43 ++--- 2 files changed, 65 insertions(+), 85 deletions(-) diff --git a/src/xenxs/xen_sxpr.c

Re: [libvirt] [PATCH v2 35/37] Introduce syntax-check rule to prefer VIR_STRDUP over strdup

2013-04-30 Thread John Ferlan
On 04/29/2013 09:50 AM, Michal Privoznik wrote: --- cfg.mk | 8 1 file changed, 8 insertions(+) diff --git a/cfg.mk b/cfg.mk index d499ded..4c6d85c 100644 --- a/cfg.mk +++ b/cfg.mk @@ -383,6 +383,11 @@ sc_prohibit_asprintf: halt='use virAsprintf, not as'printf

Re: [libvirt] [PATCH 2/4] QMP: add cpu-add command

2013-04-30 Thread Eduardo Habkost
(CCing libvir-list) On Tue, Apr 30, 2013 at 08:34:01AM +0200, Igor Mammedov wrote: Adds cpu-add id=xxx QMP command. cpu-add's id argument is a CPU number in a range [0..max-cpus) Example QMP command: - { execute: cpu-add, arguments: { id: 2 } } - { return: {} } Signed-off-by: Igor

Re: [libvirt] [PATCH 2/4] QMP: add cpu-add command

2013-04-30 Thread Peter Krempa
On 04/30/13 15:46, Eduardo Habkost wrote: (CCing libvir-list) On Tue, Apr 30, 2013 at 08:34:01AM +0200, Igor Mammedov wrote: Adds cpu-add id=xxx QMP command. cpu-add's id argument is a CPU number in a range [0..max-cpus) Example QMP command: - { execute: cpu-add, arguments: { id: 2 } } -

[libvirt] [PATCH] esx: Support virtualHW version 9

2013-04-30 Thread Martin Kletzander
We already support ESX 5.1, but virtualHW version used by such hypervisor [1] wasn't taken into account. [1] http://kb.vmware.com/selfservice/microsites/search.do?cmd=displayKCexternalId=1003746 Signed-off-by: Martin Kletzander mklet...@redhat.com --- src/vmx/vmx.c | 10 +- 1 file

Re: [libvirt] [Qemu-devel] [PATCH 2/4] QMP: add cpu-add command

2013-04-30 Thread Igor Mammedov
On Tue, 30 Apr 2013 10:46:20 -0300 Eduardo Habkost ehabk...@redhat.com wrote: (CCing libvir-list) On Tue, Apr 30, 2013 at 08:34:01AM +0200, Igor Mammedov wrote: Adds cpu-add id=xxx QMP command. cpu-add's id argument is a CPU number in a range [0..max-cpus) Example QMP command:

Re: [libvirt] [PATCH v2 37/37] viralloc.c: Do report OOM error in VIR_ALLOC and friends

2013-04-30 Thread John Ferlan
On 04/29/2013 09:50 AM, Michal Privoznik wrote: For cases where caller doesn't want to repor an OOM error, he should use s/repor/report s/he should// VIR_ALLOC_QUIET or variants. --- HACKING | 4 ++ docs/hacking.html.in| 6 +++ po/POTFILES.in

Re: [libvirt] [PATCH v2 00/37] Change OOM reporting

2013-04-30 Thread John Ferlan
On 04/29/2013 09:50 AM, Michal Privoznik wrote: Previously, the first version dropped virReportOOMError from almost everywhere. This series don't set such high goal yet. It just prepares ground for doing so. The worst case scenario is the OOM error is reported twice. Once in VIR_ALLOC,

[libvirt] [PATCH] build: mark conditionally unused variables

2013-04-30 Thread Eric Blake
These fixes solve a compilation failure on FreeBSD: util/virnetdevtap.c: In function 'virNetDevTapGetName': util/virnetdevtap.c:56: warning: unused parameter 'tapfd' [-Wunused-parameter] util/virnetdevtap.c:56: warning: unused parameter 'ifname' [-Wunused-parameter] * src/util/virnetdevtap.c

Re: [libvirt] [PATCH] libxl: Fix double-dispose of libxl domain config

2013-04-30 Thread Eric Blake
On 04/29/2013 05:20 PM, Jim Fehlig wrote: libxlBuildDomainConfig() was disposing the libxl_domain_config object on error, only to have it disposed again by libxlBuildDomainConfig()'s caller, which resulted in a segfault. Leave disposing of the config object to it's owner. ---

[libvirt] [PATCH v2 1/2] Add VNC WebSocket support

2013-04-30 Thread Martin Kletzander
Adding support for new attribute 'websocket' in the 'graphics' element, the attribute value is the port to listen on with '-1' meaning auto-allocation, '0' meaning no websockets. Signed-off-by: Martin Kletzander mklet...@redhat.com --- docs/formatdomain.html.in | 5 +

[libvirt] [PATCH v2 0/2] Support for VNC WebSocket

2013-04-30 Thread Martin Kletzander
This series, which is meant to be applied _after_ 1.0.5 release, is adding support for the VNC WebSocket to be configured for QEMU. Documentation from qemu_options.hx: qemu -vnc ...,websocket[=port] Opens an additional TCP listening port dedicated to VNC Websocket connections. By definition the

[libvirt] [PATCH v2 2/2] qemu: Add VNC WebSocket support

2013-04-30 Thread Martin Kletzander
Adding a VNC WebSocket support for QEMU driver. This funcitonality is in upstream qemu from commit described as v1.3.0-982-g7536ee4, so the capability is being recognized based on QEMU version for now. Signed-off-by: Martin Kletzander mklet...@redhat.com --- src/qemu/libvirtd_qemu.aug |

[libvirt] [PATCH] Fix typo in augeas comment

2013-04-30 Thread Martin Kletzander
Signed-off-by: Martin Kletzander mklet...@redhat.com --- Pushed as 'trivial' before 1.0.5 as suggested [1] by Michal [1] http://www.redhat.com/archives/libvir-list/2013-April/msg02059.html --- src/qemu/libvirtd_qemu.aug | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [libvirt] [PATCH 1/2] qemu: add vfio devices to cgroup ACL when appropriate

2013-04-30 Thread Eric Blake
On 04/29/2013 07:46 PM, Laine Stump wrote: +int qemuSetupHostdevCGroup(virDomainObjPtr vm, + virDomainHostdevDefPtr dev) ATTRIBUTE_RETURN_CHECK; +int qemuTeardownHostdevCgroup(virDomainObjPtr vm, + virDomainHostdevDefPtr dev); A bit odd

[libvirt] Location of 64 bit libvirt dlls (Windows)?

2013-04-30 Thread george john
I have written a Java client (64 bit JVM) that uses libvirt APIs on a remote KVM for KVM management. Since the JVM is 64 bit, the client needs 64 bit libvirt dlls and I could not find them (I found 32 bit libvirt dlls on http://libvirt.org/windows.html). Could someone point to where I could

Re: [libvirt] [PATCH] esx: Support virtualHW version 9

2013-04-30 Thread Richard W.M. Jones
On Tue, Apr 30, 2013 at 03:53:33PM +0200, Martin Kletzander wrote: We already support ESX 5.1, but virtualHW version used by such hypervisor [1] wasn't taken into account. [1] http://kb.vmware.com/selfservice/microsites/search.do?cmd=displayKCexternalId=1003746 Signed-off-by: Martin

[libvirt] Java client error on Windows 7 64 bit for Libvirt on KVM

2013-04-30 Thread george john
Hi, I need some help in building a Java client on Windows 7 64 bit plaftorm to manage a KVM using the libvirt APIs. Using the instructions at http://libvirt.org/java.html, i was able to build libvirt.jar. My understanding is that libvirt.jar uses JNA to call libvirt's native windows library. I

Re: [libvirt] [PATCH] libvirt-guests: status: return non-zero when stopped

2013-04-30 Thread Eric Blake
On 04/30/2013 05:55 AM, Ján Tomko wrote: Return 3 when the service is stopped, whether there are saved guests or not. Please mention http://refspecs.linuxbase.org/LSB_3.1.1/LSB-Core-generic/LSB-Core-generic/iniscrptact.html in the commit message as justification. ---

Re: [libvirt] [PATCH 1/2] libxl: expose multiple emulators per guest in the capabilities XML

2013-04-30 Thread Jim Fehlig
Daniel P. Berrange wrote: On Mon, Apr 29, 2013 at 11:01:04PM -0600, Jim Fehlig wrote: Daniel P. Berrange wrote: On Mon, Apr 29, 2013 at 12:18:56PM -0600, Jim Fehlig wrote: David Scott wrote: libxl allows users to choose between two standard emulators: 1.

[libvirt] [PATCH] security driver: eliminate memory leaks in failure paths

2013-04-30 Thread Laine Stump
If virPCIDeviceGetVFIOGroupDev() failed, virSecurity*(Set|Restore)HostdevLabel() would fail to free a virPCIDevice that had been allocated. These leaks were all introduced (by me) very recently, in commit f0bd70a. --- src/security/security_apparmor.c | 4 +++- src/security/security_dac.c |

Re: [libvirt] [PATCH] esx: Support virtualHW version 9

2013-04-30 Thread Martin Kletzander
On 04/30/2013 04:51 PM, Richard W.M. Jones wrote: On Tue, Apr 30, 2013 at 03:53:33PM +0200, Martin Kletzander wrote: We already support ESX 5.1, but virtualHW version used by such hypervisor [1] wasn't taken into account. [1]

Re: [libvirt] [PATCH] security driver: eliminate memory leaks in failure paths

2013-04-30 Thread Eric Blake
On 04/30/2013 09:02 AM, Laine Stump wrote: If virPCIDeviceGetVFIOGroupDev() failed, virSecurity*(Set|Restore)HostdevLabel() would fail to free a virPCIDevice that had been allocated. These leaks were all introduced (by me) very recently, in commit f0bd70a. ---

Re: [libvirt] [PATCH] esx: Support virtualHW version 9

2013-04-30 Thread Richard W.M. Jones
On Tue, Apr 30, 2013 at 05:05:36PM +0200, Martin Kletzander wrote: On 04/30/2013 04:51 PM, Richard W.M. Jones wrote: On Tue, Apr 30, 2013 at 03:53:33PM +0200, Martin Kletzander wrote: We already support ESX 5.1, but virtualHW version used by such hypervisor [1] wasn't taken into account.

Re: [libvirt] [PATCH v2 35/37] Introduce syntax-check rule to prefer VIR_STRDUP over strdup

2013-04-30 Thread Eric Blake
On 04/30/2013 07:03 AM, John Ferlan wrote: On 04/29/2013 09:50 AM, Michal Privoznik wrote: --- cfg.mk | 8 1 file changed, 8 insertions(+) diff --git a/cfg.mk b/cfg.mk index d499ded..4c6d85c 100644 --- a/cfg.mk +++ b/cfg.mk @@ -383,6 +383,11 @@ sc_prohibit_asprintf:

Re: [libvirt] [PATCH v2 1/2] Add VNC WebSocket support

2013-04-30 Thread John Ferlan
On 04/30/2013 10:42 AM, Martin Kletzander wrote: Adding support for new attribute 'websocket' in the 'graphics' element, the attribute value is the port to listen on with '-1' meaning auto-allocation, '0' meaning no websockets. Signed-off-by: Martin Kletzander mklet...@redhat.com ---

Re: [libvirt] Location of 64 bit libvirt dlls (Windows)?

2013-04-30 Thread Eric Blake
On 04/30/2013 08:49 AM, george john wrote: I have written a Java client (64 bit JVM) that uses libvirt APIs on a remote KVM for KVM management. Since the JVM is 64 bit, the client needs 64 bit libvirt dlls and I could not find them (I found 32 bit libvirt dlls on

Re: [libvirt] [PATCH] libxl: Fix double-dispose of libxl domain config

2013-04-30 Thread Jim Fehlig
Eric Blake wrote: On 04/29/2013 05:20 PM, Jim Fehlig wrote: libxlBuildDomainConfig() was disposing the libxl_domain_config object on error, only to have it disposed again by libxlBuildDomainConfig()'s caller, which resulted in a segfault. Leave disposing of the config object to it's

Re: [libvirt] Location of 64 bit libvirt dlls (Windows)?

2013-04-30 Thread Laine Stump
On 04/30/2013 11:14 AM, Eric Blake wrote: On 04/30/2013 08:49 AM, george john wrote: I have written a Java client (64 bit JVM) that uses libvirt APIs on a remote KVM for KVM management. Since the JVM is 64 bit, the client needs 64 bit libvirt dlls and I could not find them (I found 32 bit

Re: [libvirt] [PATCH] portability: handle ifreq differences in virnetdev

2013-04-30 Thread Eric Blake
On 04/29/2013 11:48 AM, Eric Blake wrote: On 04/27/2013 09:50 AM, Roman Bogorodskiy wrote: FreeBSD (and maybe other BSDs) have different member names in struct ifreq when compared to Linux, such as: - uses ifr_data instead of ifr_newname for setting interface names - uses ifr_index

Re: [libvirt] [PATCH] libxl: allow an emulator to be selected in the domain config XML

2013-04-30 Thread Jim Fehlig
David Scott wrote: The emulator path supplied can be any valid path on the system. Note that when setting a device_model, libxl needs us to set the device_model_version too. The device_model_version can be either ...QEMU_XEN: meaning upstream qemu, the default in xen-4.3 onwards

[libvirt] [PATCH] portability: handle ifreq differences in virnetdev

2013-04-30 Thread Eric Blake
From: Roman Bogorodskiy bogorods...@gmail.com FreeBSD (and maybe other BSDs) have different member names in struct ifreq when compared to Linux, such as: - uses ifr_data instead of ifr_newname for setting interface names - uses ifr_index instead of ifr_ifindex for interface index Also,

[libvirt] Location of 64 bit libvirt dlls (Windows)?

2013-04-30 Thread george john
Thank you for your email. I had tried compiling myself following the instructions at http://libvirt.org/windows.html (Matthias Bolte's msys_setup) but it failed on 2 different machines with an error. I get the below error when I try to run compile_libxml2.sh as per instructions

Re: [libvirt] [PATCH v2 1/2] Add VNC WebSocket support

2013-04-30 Thread Eric Blake
On 04/30/2013 09:18 AM, John Ferlan wrote: On 04/30/2013 10:42 AM, Martin Kletzander wrote: Adding support for new attribute 'websocket' in the 'graphics' element, the attribute value is the port to listen on with '-1' meaning auto-allocation, '0' meaning no websockets. Signed-off-by: Martin

Re: [libvirt] [PATCH v2 2/2] qemu: Add VNC WebSocket support

2013-04-30 Thread Eric Blake
On 04/30/2013 08:42 AM, Martin Kletzander wrote: Adding a VNC WebSocket support for QEMU driver. This funcitonality is s/funcitonality/functionality/ in upstream qemu from commit described as v1.3.0-982-g7536ee4, so the capability is being recognized based on QEMU version for now. I wish we

Re: [libvirt] [PATCH] libvirt-guests: status: return non-zero when stopped

2013-04-30 Thread Ján Tomko
On 04/30/2013 04:55 PM, Eric Blake wrote: On 04/30/2013 05:55 AM, Ján Tomko wrote: Return 3 when the service is stopped, whether there are saved guests or not. Please mention http://refspecs.linuxbase.org/LSB_3.1.1/LSB-Core-generic/LSB-Core-generic/iniscrptact.html in the commit message as

Re: [libvirt] [PATCH v2 2/2] qemu: Add VNC WebSocket support

2013-04-30 Thread John Ferlan
On 04/30/2013 10:42 AM, Martin Kletzander wrote: Adding a VNC WebSocket support for QEMU driver. This funcitonality is s/funcitonality/functionality in upstream qemu from commit described as v1.3.0-982-g7536ee4, so the capability is being recognized based on QEMU version for now.

[libvirt] [PATCH] Need to call virFreeError after virSaveLastError

2013-04-30 Thread John Ferlan
This is a followup to https://www.redhat.com/archives/libvir-list/2013-April/msg02004.html which noted that bridge_driver.c also had a missing virFreeError() call --- src/network/bridge_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/network/bridge_driver.c

[libvirt] [PATCHv3] Configure native vlan modes on Open vSwitch ports

2013-04-30 Thread james robson
This patch adds functionality to allow libvirt to configure the 'native-tagged' and 'native-untagged' modes on openvswitch networks. v2 changes: Fix problems reported by Eric Blake v3 changes: Re work patch to address review comments --- diff --git a/docs/formatdomain.html.in

[libvirt] [PATCH] qemu: fix failure to start with spice graphics and no tls

2013-04-30 Thread Laine Stump
Commit eca3fdf inadvertantly caused a failure to start for any domain with the following in its config: graphics type='spice' autoport='yes'/ The problem is that when tlsPort == 0 and defaultMode == any (which is the default for defaultMode), this would be flagged in the code as needTLSPort,

[libvirt] [PATCH 2/4] docs: Update description of SMBIOS fields

2013-04-30 Thread John Ferlan
--- docs/formatdomain.html.in | 48 +++ 1 file changed, 40 insertions(+), 8 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 017d2b9..2e16a64 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@

[libvirt] [PATCH 0/4] Extra validation for the sysinfo section

2013-04-30 Thread John Ferlan
Not necessary for 1.0.5, but figured I'd put it out there now. https://bugzilla.redhat.com/show_bug.cgi?id=890494 The sysinfo section needs an extra uuid validation check. The current check compares the numerical sysinfo/system_uuid with the domain uuid; however, it's possible that someone

[libvirt] [PATCH 4/4] Need better validation of sysinfo uuid

2013-04-30 Thread John Ferlan
If the sysinfo system table 'uuid' field is improperly formatted, then qemu will fail to start the guest with the error: virsh start dom error: Failed to start domain dom error: internal error process exited while connecting to monitor: Invalid SMBIOS UUID string In this case the system_uuid

[libvirt] [PATCH 3/4] Validate the bios_date format for sysinfo

2013-04-30 Thread John Ferlan
--- src/conf/domain_conf.c | 24 1 file changed, 24 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index a8b5dfd..43273f8 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -11591,6 +11591,30 @@ virDomainDefParseXML(xmlDocPtr

[libvirt] [PATCH 1/4] docs: Fix syntax in sysinfo description

2013-04-30 Thread John Ferlan
--- docs/formatdomain.html.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index f325c3c..017d2b9 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -305,7 +305,8 @@ lt;/biosgt;

Re: [libvirt] [PATCH] Need to call virFreeError after virSaveLastError

2013-04-30 Thread Eric Blake
On 04/30/2013 11:55 AM, John Ferlan wrote: This is a followup to https://www.redhat.com/archives/libvir-list/2013-April/msg02004.html which noted that bridge_driver.c also had a missing virFreeError() call --- src/network/bridge_driver.c | 1 + 1 file changed, 1 insertion(+) ACK,

Re: [libvirt] [PATCH] Need to call virFreeError after virSaveLastError

2013-04-30 Thread John Ferlan
On 04/30/2013 02:32 PM, Eric Blake wrote: On 04/30/2013 11:55 AM, John Ferlan wrote: This is a followup to https://www.redhat.com/archives/libvir-list/2013-April/msg02004.html which noted that bridge_driver.c also had a missing virFreeError() call --- src/network/bridge_driver.c | 1 +

[libvirt] [PATCH] build: fix cygwin build in virnetdev

2013-04-30 Thread Eric Blake
On cygwin, compilation failed because SIOCSIFHWADDR is undefined. * src/util/virnetdev.c (virNetDevSetMAC): Cygwin can query but not set mac address. Signed-off-by: Eric Blake ebl...@redhat.com --- Pushing under the build-breaker rule. src/util/virnetdev.c | 3 ++- 1 file changed, 2

Re: [libvirt] [PATCH] libxl: allow an emulator to be selected in the domain config XML

2013-04-30 Thread David Scott
Hi, [added xen-devel: FYI this is about how to properly set the libxl device_model_version when the user has provided a manual device_model override (aka a path to a qemu) in the libvirt domain XML.] On 30/04/13 16:10, Jim Fehlig wrote: David Scott wrote: The emulator path supplied can be

Re: [libvirt] [PATCH] qemu: fix failure to start with spice graphics and no tls

2013-04-30 Thread Eric Blake
On 04/30/2013 12:13 PM, Laine Stump wrote: Commit eca3fdf inadvertantly caused a failure to start for any domain s/inadvertantly/inadvertently/ with the following in its config: graphics type='spice' autoport='yes'/ The problem is that when tlsPort == 0 and defaultMode == any (which

[libvirt] [PATCH] build: fix cygwin build in virnetdev

2013-04-30 Thread Eric Blake
On cygwin, compilation failed because SIOCSIFHWADDR is undefined. * src/util/virnetdev.c (virNetDevSetMAC): Cygwin can query but not set mac address. Signed-off-by: Eric Blake ebl...@redhat.com --- Pushing under the build-breaker rule. I may have a few more cygwin-related patches as I continue

Re: [libvirt] [PATCH] qemu: fix failure to start with spice graphics and no tls

2013-04-30 Thread Laine Stump
On 04/30/2013 03:57 PM, Eric Blake wrote: On 04/30/2013 12:13 PM, Laine Stump wrote: Commit eca3fdf inadvertantly caused a failure to start for any domain s/inadvertantly/inadvertently/ with the following in its config: graphics type='spice' autoport='yes'/ The problem is that when

Re: [libvirt] [PATCH v2 1/5] Add support for storage format in FS driver

2013-04-30 Thread Eric Blake
On 04/22/2013 08:06 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Extend the driver element in filesystem devices to allow a storage format to be set. The new attribute uses 'format' to reflect the storage format. This is different from the driver element in

Re: [libvirt] [PATCHv2] rpc: message related sizes enlarged

2013-04-30 Thread Eric Blake
On 04/26/2013 05:59 AM, Viktor Mihajlovski wrote: From: Daniel Hansel daniel.han...@linux.vnet.ibm.com We have seen an issue on s390x platform where domain XMLs larger than 1MB were used. The define command was finished successfully. The dumpxml command was not successful (i.e. could not

Re: [libvirt] [PATCH v2 2/5] Re-arrange code setting up ifs/disk loop devices for LXC

2013-04-30 Thread Eric Blake
On 04/22/2013 08:06 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The current code for setting up loop devices to LXC disks first does a switch() based on the disk format, then looks at the disk driver name. Reverse this so it first looks at the driver name, and

Re: [libvirt] [PATCH v2 4/5] Add 'nbd' as a valid filesystem driver type

2013-04-30 Thread Eric Blake
On 04/22/2013 08:06 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The filesystem element can now accept a driver type='nbd'/ as an alternative to 'loop'. The benefit of NBD is support for non-raw disk image formats. Signed-off-by: Daniel P. Berrange

Re: [libvirt] [PATCH v2 5/5] Support NBD backed disks/filesystems in LXC driver

2013-04-30 Thread Eric Blake
On 04/22/2013 08:06 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The LXC driver can already configure disk or filesystem devices to use the loop device. This extends it to also allow for use of the NBD device, to support non-raw formats. Cool! But here we are

Re: [libvirt] [PATCH 0/2] Get rid of default USB controller on S390

2013-04-30 Thread Eric Blake
On 04/29/2013 10:11 AM, Viktor Mihajlovski wrote: QEMU for S390 has presently no USB controllers nor a PCI bus. Both are created by the default in the libvirt domain definition. Although this can be suppressed by explicitly specifying an USB controller with model='none', it's a real bad

Re: [libvirt] [PATCH v2 3/5] Add a helper API for setting up a NBD device with qemu-nbd

2013-04-30 Thread Eric Blake
On 04/22/2013 08:06 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Add a virFileNBDDeviceAssociate method, which given a filename will setup a NBD device, using qemu-nbd as the server. Signed-off-by: Daniel P. Berrange berra...@redhat.com ---

Re: [libvirt] [Xen-devel] [PATCH] libxl: allow an emulator to be selected in the domain config XML

2013-04-30 Thread Jim Fehlig
David Scott wrote: Hi, [added xen-devel: FYI this is about how to properly set the libxl device_model_version when the user has provided a manual device_model override (aka a path to a qemu) in the libvirt domain XML.] On 30/04/13 16:10, Jim Fehlig wrote: David Scott wrote: The emulator