[libvirt] Release candidate 2 of libvirt-1.1.1

2013-07-29 Thread Daniel Veillard
On Wed, Jul 24, 2013 at 12:11:52PM +0800, Daniel Veillard wrote: As planned I tagged the release candidate 1 for libvirt 1.1.1 in git, I also made tarball and rpms available on the ftp: ftp://libvirt.org/libvirt/ I just tagged rc2, it is available in git an at the above repository in

[libvirt] Linking fails on FreeBSD

2013-07-29 Thread Roman Bogorodskiy
Hi, Linking fails on FreeBSD: CCLD libvirt.la /usr/bin/ld: ./.libs/libvirt_util.a(libvirt_util_la-vircgroup.o): relocation R_X86_64_PC32 against `virCgroupPartitionEscape' can not be used when making a shared object; recompile with -fPIC /usr/bin/ld: final link failed: Bad value

Re: [libvirt] Linking fails on FreeBSD

2013-07-29 Thread Daniel Veillard
On Mon, Jul 29, 2013 at 10:30:15AM +0400, Roman Bogorodskiy wrote: Hi, Linking fails on FreeBSD: CCLD libvirt.la /usr/bin/ld: ./.libs/libvirt_util.a(libvirt_util_la-vircgroup.o): relocation R_X86_64_PC32 against `virCgroupPartitionEscape' can not be used when making a shared

Re: [libvirt] Linking fails on FreeBSD

2013-07-29 Thread Jason Helfman
On Sun, Jul 28, 2013 at 11:38 PM, Daniel Veillard veill...@redhat.comwrote: On Mon, Jul 29, 2013 at 10:30:15AM +0400, Roman Bogorodskiy wrote: Hi, Linking fails on FreeBSD: CCLD libvirt.la /usr/bin/ld: ./.libs/libvirt_util.a(libvirt_util_la-vircgroup.o): relocation

Re: [libvirt] Linking fails on FreeBSD

2013-07-29 Thread Daniel Veillard
On Mon, Jul 29, 2013 at 12:12:29AM -0700, Jason Helfman wrote: On Sun, Jul 28, 2013 at 11:38 PM, Daniel Veillard veill...@redhat.comwrote: On Mon, Jul 29, 2013 at 10:30:15AM +0400, Roman Bogorodskiy wrote: Hi, Linking fails on FreeBSD: CCLD libvirt.la /usr/bin/ld:

[libvirt] [PATCH 1/1] cpu: Fix one compile error for PPC.

2013-07-29 Thread Li Zhang
From: Li Zhang zhlci...@linux.vnet.ibm.com CPU data structure is refined, which causes one compile error for PPC. Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com --- src/cpu/cpu_powerpc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/cpu/cpu_powerpc.c

Re: [libvirt] [PATCH 1/1] cpu: Fix one compile error for PPC.

2013-07-29 Thread Daniel Veillard
On Mon, Jul 29, 2013 at 03:41:19PM +0800, Li Zhang wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com CPU data structure is refined, which causes one compile error for PPC. Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com --- src/cpu/cpu_powerpc.c | 8 1 file changed, 4

Re: [libvirt] [RFC] Image Fleecing for Libvirt (BZ 955734, 905125)

2013-07-29 Thread Wenchao Xia
于 2013-7-24 21:11, Wenchao Xia 写道: 于 2013-7-24 17:44, Paolo Bonzini 写道: Il 24/07/2013 07:38, Wenchao Xia ha scritto: Because libvirt would use a local (Unix) socket to communicate with QEMU and pass the file descriptor, there is no need to authenticate the NBD connection. There is no need

Re: [libvirt] [PATCH 1/1] cpu: Fix one compile error for PPC.

2013-07-29 Thread Li Zhang
On 2013Е╧╢07Ф°┬29Ф≈╔ 16:29, Daniel Veillard wrote: On Mon, Jul 29, 2013 at 03:41:19PM +0800, Li Zhang wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com CPU data structure is refined, which causes one compile error for PPC. Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com ---

Re: [libvirt] [Libvirt-announce] Release candidate 2 of libvirt-1.1.1

2013-07-29 Thread Justin Clift
On 29/07/2013, at 7:17 AM, Daniel Veillard wrote: On Wed, Jul 24, 2013 at 12:11:52PM +0800, Daniel Veillard wrote: As planned I tagged the release candidate 1 for libvirt 1.1.1 in git, I also made tarball and rpms available on the ftp: ftp://libvirt.org/libvirt/ I just tagged rc2, it is

Re: [libvirt] [PATCH v2 1/3] qemu: refactor qemuDomainCheckDiskPresence for only disk presence check

2013-07-29 Thread Martin Kletzander
On 07/26/2013 02:37 PM, Guannan Ren wrote: Refactor this function to make it focus on disk presence checking, including diskchain checking, and not only for CDROM and Floppy. This change is good for the following patches. --- src/qemu/qemu_domain.c | 98

Re: [libvirt] [PATCH v2] RPC: Don't accept client if it would overcommit max_clients

2013-07-29 Thread Daniel P. Berrange
On Fri, Jul 26, 2013 at 09:13:43AM +0200, Michal Privoznik wrote: Currently, even if max_client limit is hit, we accept() incoming connection request, but close it immediately. This has disadvantage of not using listen() queue. We should accept() only those clients we know we can serve and let

Re: [libvirt] [PATCH 0/3] qemu: libvirt RDMA live migration support

2013-07-29 Thread Daniel P. Berrange
On Fri, Jul 26, 2013 at 12:16:08PM -0600, Eric Blake wrote: On 07/26/2013 11:47 AM, mrhi...@linux.vnet.ibm.com wrote: From: Michael R. Hines mrhi...@us.ibm.com QEMU has in tree now planned for 1.6 support for RDMA-based live migration. Changes to libvirt: 1. QEMU has a new 'setup'

Re: [libvirt] [PATCH 0/3] qemu: libvirt RDMA live migration support

2013-07-29 Thread Michael R. Hines
On 07/29/2013 06:18 AM, Daniel P. Berrange wrote: On Fri, Jul 26, 2013 at 12:16:08PM -0600, Eric Blake wrote: On 07/26/2013 11:47 AM, mrhi...@linux.vnet.ibm.com wrote: From: Michael R. Hines mrhi...@us.ibm.com QEMU has in tree now planned for 1.6 support for RDMA-based live migration.

Re: [libvirt] [PATCHv2] build: avoid -lgcrypt with newer gnutls

2013-07-29 Thread Daniel P. Berrange
On Fri, Jul 26, 2013 at 08:22:29PM -0500, Doug Goldstein wrote: On Fri, Jul 26, 2013 at 5:04 PM, Eric Blake ebl...@redhat.com wrote: https://bugzilla.redhat.com/show_bug.cgi?id=951637 Newer gnutls uses nettle, rather than gcrypt, which is a lot nicer regarding initialization. Yet we were

Re: [libvirt] Linking fails on FreeBSD

2013-07-29 Thread Daniel P. Berrange
On Mon, Jul 29, 2013 at 10:30:15AM +0400, Roman Bogorodskiy wrote: Hi, Linking fails on FreeBSD: CCLD libvirt.la /usr/bin/ld: ./.libs/libvirt_util.a(libvirt_util_la-vircgroup.o): relocation R_X86_64_PC32 against `virCgroupPartitionEscape' can not be used when making a shared

Re: [libvirt] [PATCH 1/1] cpu: Fix one compile error for PPC.

2013-07-29 Thread Jiri Denemark
On Mon, Jul 29, 2013 at 15:41:19 +0800, Li Zhang wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com CPU data structure is refined, which causes one compile error for PPC. Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com --- src/cpu/cpu_powerpc.c | 8 1 file changed, 4

Re: [libvirt] [PATCH v2 2/3] qemu: add helper functions for diskchain checking

2013-07-29 Thread Martin Kletzander
On 07/26/2013 02:37 PM, Guannan Ren wrote: *src/util/virstoragefile.c: Add a helper function to get the first name of missing backing files, if the name is NULL, it means the diskchain is not broken. *src/qemu/qemu_domain.c: qemuDiskChainCheckBroken(disk) to check if its chain is broken ---

Re: [libvirt] Use flock() instead of fcntl()

2013-07-29 Thread Daniel P. Berrange
On Fri, Jul 26, 2013 at 11:35:32AM +0100, Daniel P. Berrange wrote: On Fri, Jul 26, 2013 at 12:31:35PM +0200, David Weber wrote: Am Freitag, 26. Juli 2013, 10:14:59 schrieb Daniel P. Berrange: On Fri, Jul 26, 2013 at 10:44:24AM +0200, David Weber wrote: Looking again at flock() I see it

[libvirt] [PATCH] python: Drop TODO

2013-07-29 Thread Cole Robinson
File hasn't been really touched for 7 years. And with recent rawhide changes it contributed to an RPM build failure. Let's drop it. This also removes installation of a libvirt-python doc dir, so drop handling of it from the RPM spec. --- libvirt.spec.in| 7 --- python/Makefile.am | 7

Re: [libvirt] [PATCH] python: Drop TODO

2013-07-29 Thread Cole Robinson
On 07/29/2013 07:59 AM, Daniel P. Berrange wrote: On Mon, Jul 29, 2013 at 07:55:24AM -0400, Cole Robinson wrote: File hasn't been really touched for 7 years. And with recent rawhide changes it contributed to an RPM build failure. Let's drop it. This also removes installation of a

Re: [libvirt] [PATCH] python: Drop TODO

2013-07-29 Thread Daniel P. Berrange
On Mon, Jul 29, 2013 at 07:55:24AM -0400, Cole Robinson wrote: File hasn't been really touched for 7 years. And with recent rawhide changes it contributed to an RPM build failure. Let's drop it. This also removes installation of a libvirt-python doc dir, so drop handling of it from the RPM

Re: [libvirt] [PATCH v2 2/3] qemu: add helper functions for diskchain checking

2013-07-29 Thread Guannan Ren
On 07/29/2013 07:27 PM, Martin Kletzander wrote: On 07/26/2013 02:37 PM, Guannan Ren wrote: *src/util/virstoragefile.c: Add a helper function to get the first name of missing backing files, if the name is NULL, it means the diskchain is not broken. *src/qemu/qemu_domain.c:

[libvirt] [PATCH v3 2/3] qemu: add helper functions for diskchain checking

2013-07-29 Thread Guannan Ren
*src/util/virstoragefile.c: Add a helper function to get the first name of missing backing files, if the name is NULL, it means the diskchain is not broken. *src/qemu/qemu_domain.c: qemuDiskChainCheckBroken(disk) to check if its chain is broken --- src/libvirt_private.syms | 1 +

Re: [libvirt] [PATCH v2 3/3] qemu: check presence of each disk and its backing file as well

2013-07-29 Thread Martin Kletzander
On 07/26/2013 02:37 PM, Guannan Ren wrote: For disk with startupPolicy support, such as cdrom and floppy when its chain is broken, the startup policy will apply, otherwise, report an error on chain issue. --- src/qemu/qemu_domain.c | 21 - src/qemu/qemu_process.c | 6

Re: [libvirt] [PATCH 1/1] cpu: Fix one compile error for PPC.

2013-07-29 Thread Jiri Denemark
On Mon, Jul 29, 2013 at 13:23:23 +0200, Jiri Denemark wrote: On Mon, Jul 29, 2013 at 15:41:19 +0800, Li Zhang wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com CPU data structure is refined, which causes one compile error for PPC. Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com

[libvirt] [PATCH] build: fix VPATH 'make check'

2013-07-29 Thread Eric Blake
A VPATH build 'make check' was failing with: GEN check-driverimpls Can't open ../../src/../../src/lxc/lxc_monitor_protocol.h: No such file or directory at ../../src/check-driverimpls.pl line 29, line 27153. Can't open ../../src/../../src/lxc/lxc_monitor_protocol.c: No such file or

Re: [libvirt] Linking fails on FreeBSD

2013-07-29 Thread Roman Bogorodskiy
Daniel P. Berrange wrote: On Mon, Jul 29, 2013 at 10:30:15AM +0400, Roman Bogorodskiy wrote: Hi, Linking fails on FreeBSD: CCLD libvirt.la /usr/bin/ld: ./.libs/libvirt_util.a(libvirt_util_la-vircgroup.o): relocation R_X86_64_PC32 against `virCgroupPartitionEscape' can

Re: [libvirt] Linking fails on FreeBSD

2013-07-29 Thread Daniel P. Berrange
On Mon, Jul 29, 2013 at 05:23:40PM +0400, Roman Bogorodskiy wrote: Daniel P. Berrange wrote: On Mon, Jul 29, 2013 at 10:30:15AM +0400, Roman Bogorodskiy wrote: Hi, Linking fails on FreeBSD: CCLD libvirt.la /usr/bin/ld:

Re: [libvirt] Use flock() instead of fcntl()

2013-07-29 Thread David Weber
Am Montag, 29. Juli 2013, 12:52:00 schrieb Daniel P. Berrange: On Fri, Jul 26, 2013 at 11:35:32AM +0100, Daniel P. Berrange wrote: On Fri, Jul 26, 2013 at 12:31:35PM +0200, David Weber wrote: Am Freitag, 26. Juli 2013, 10:14:59 schrieb Daniel P. Berrange: On Fri, Jul 26, 2013 at

Re: [libvirt] Linking fails on FreeBSD

2013-07-29 Thread Eric Blake
On 07/29/2013 04:32 AM, Daniel P. Berrange wrote: On Mon, Jul 29, 2013 at 10:30:15AM +0400, Roman Bogorodskiy wrote: Hi, Linking fails on FreeBSD: And on a cross-build to mingw as well. Try building with thsi patch Closer, but not there yet: CC libvirt_util_la-vircgroup.lo

[libvirt] [PATCH 4/4] build: fix virutil build on mingw

2013-07-29 Thread Eric Blake
On platforms without decent group support, the build failed: Cannot export virGetGroupList: symbol not defined ./.libs/libvirt_security_manager.a(libvirt_security_manager_la-security_dac.o): In function `virSecurityDACPreFork':

[libvirt] [PATCH 1/4] build: yet another cgroup conditional compilation fix

2013-07-29 Thread Eric Blake
From: Daniel P. Berrange berra...@redhat.com Linking fails on FreeBSD: CCLD libvirt.la /usr/bin/ld: ./.libs/libvirt_util.a(libvirt_util_la-vircgroup.o): relocation R_X86_64_PC32 against `virCgroupPartitionEscape' can not be used when making a shared object; recompile with -fPIC

[libvirt] [PATCH 3/4] build: fix virthread build on mingw

2013-07-29 Thread Eric Blake
Our recent conversion to make VIR_ALLOC report oom wasn't tested on mingw: In file included from ../../src/util/virthread.c:29:0: ../../src/util/virthreadwin32.c: In function 'virCondWait': ../../src/util/virthreadwin32.c:166:81: error: 'VIR_FROM_THIS' undeclared (first use in this function)

[libvirt] [PATCH 2/4] build: fix virdbus build on mingw

2013-07-29 Thread Eric Blake
Mingw headers pollute the namespace. CC libvirt_util_la-virdbus.lo ../../src/util/virdbus.c:1102:35: error: expected ';', ',' or ')' before 'struct' const char *interface, ^ * src/util/virdbus.c (virDBusCallMethod): Avoid

[libvirt] [PATCH 0/4] fix various build failures

2013-07-29 Thread Eric Blake
This fixes the FreeBSD link error and several mingw errors, although I'm still chasing down some more failures in the testsuite (for example, we try and fail to build systemdmock on mingw, even though it makes no sense since systemd is Linux-only; and there are some uses of fprintf that need to be

Re: [libvirt] [PATCH 1/4] build: yet another cgroup conditional compilation fix

2013-07-29 Thread Daniel P. Berrange
On Mon, Jul 29, 2013 at 08:53:35AM -0600, Eric Blake wrote: From: Daniel P. Berrange berra...@redhat.com Linking fails on FreeBSD: CCLD libvirt.la /usr/bin/ld: ./.libs/libvirt_util.a(libvirt_util_la-vircgroup.o): relocation R_X86_64_PC32 against `virCgroupPartitionEscape' can not

Re: [libvirt] [PATCH 0/4] fix various build failures

2013-07-29 Thread Daniel P. Berrange
On Mon, Jul 29, 2013 at 08:53:34AM -0600, Eric Blake wrote: This fixes the FreeBSD link error and several mingw errors, although I'm still chasing down some more failures in the testsuite (for example, we try and fail to build systemdmock on mingw, even though it makes no sense since systemd

Re: [libvirt] [PATCH 1/1] cpu: Fix one compile error for PPC.

2013-07-29 Thread Li Zhang
On 2013年07月29日 21:04, Jiri Denemark wrote: On Mon, Jul 29, 2013 at 13:23:23 +0200, Jiri Denemark wrote: On Mon, Jul 29, 2013 at 15:41:19 +0800, Li Zhang wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com CPU data structure is refined, which causes one compile error for PPC. Signed-off-by: Li

[libvirt] [PATCH] Configuring systemd to restart libvirt on abort

2013-07-29 Thread Mooli Tayer
From: Mooli Tayer mta...@redhat.com This will create a respawn behaviour in case libvirt process exits due to an uncaught signal not specified as a clean exit status. see http://www.freedesktop.org/software/systemd/man/systemd.service.html --- daemon/libvirtd.service.in | 1 + 1 file changed, 1

Re: [libvirt] [PATCH] Configuring systemd to restart libvirt on abort

2013-07-29 Thread Eric Blake
On 07/29/2013 08:36 AM, Mooli Tayer wrote: From: Mooli Tayer mta...@redhat.com This will create a respawn behaviour in case libvirt process exits due to an uncaught signal not specified as a clean exit status. see http://www.freedesktop.org/software/systemd/man/systemd.service.html ---

Re: [libvirt] [PATCH] Configuring systemd to restart libvirt on abort

2013-07-29 Thread Daniel P. Berrange
On Mon, Jul 29, 2013 at 05:36:21PM +0300, Mooli Tayer wrote: From: Mooli Tayer mta...@redhat.com This will create a respawn behaviour in case libvirt process exits due to an uncaught signal not specified as a clean exit status. see

Re: [libvirt] [PATCH 1/4] build: yet another cgroup conditional compilation fix

2013-07-29 Thread Eric Blake
On 07/29/2013 09:09 AM, Daniel P. Berrange wrote: On Mon, Jul 29, 2013 at 08:53:35AM -0600, Eric Blake wrote: From: Daniel P. Berrange berra...@redhat.com -static int virCgroupPartitionEscape(char **path); - bool virCgroupAvailable(void) { bool ret = false; @@ -95,6 +93,10 @@

Re: [libvirt] [PATCHv2] build: avoid -lgcrypt with newer gnutls

2013-07-29 Thread Eric Blake
On 07/29/2013 04:25 AM, Daniel P. Berrange wrote: On Fri, Jul 26, 2013 at 08:22:29PM -0500, Doug Goldstein wrote: On Fri, Jul 26, 2013 at 5:04 PM, Eric Blake ebl...@redhat.com wrote: https://bugzilla.redhat.com/show_bug.cgi?id=951637 Newer gnutls uses nettle, rather than gcrypt, which is a

[libvirt] [PATCH] spec: Cat test-suite.log if make check fails

2013-07-29 Thread Jiri Denemark
Current automake enables parallel test by default, which means test details are only logged in test-suite.log and not printed to stderr. This patch makes test failures directly visible in RPM build logs even when parallel tests are turned on. --- libvirt.spec.in | 6 +- 1 file changed, 5

Re: [libvirt] [PATCH] spec: Cat test-suite.log if make check fails

2013-07-29 Thread Eric Blake
On 07/29/2013 09:44 AM, Jiri Denemark wrote: Current automake enables parallel test by default, which means test details are only logged in test-suite.log and not printed to stderr. This patch makes test failures directly visible in RPM build logs even when parallel tests are turned on. ---

[libvirt] [PATCH 5/4] build: fix another virdbus issue on mingw

2013-07-29 Thread Eric Blake
Depending on the set of mingw packages installed, it is possible that other .c files hit the mingw header pollution from the virdbus.h file. In file included from ../../src/rpc/virnetserver.c:39:0: ../../src/util/virdbus.h:41:35: error: expected ';', ',' or ')' before 'struct'

Re: [libvirt] [PATCH] spec: Cat test-suite.log if make check fails

2013-07-29 Thread Jiri Denemark
On Mon, Jul 29, 2013 at 09:51:54 -0600, Eric Blake wrote: On 07/29/2013 09:44 AM, Jiri Denemark wrote: Current automake enables parallel test by default, which means test details are only logged in test-suite.log and not printed to stderr. This patch makes test failures directly visible in

[libvirt] [PATCH] Fix dbus message reading code on big endian hosts

2013-07-29 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The way we were casting small (32bit) integers was broken on big endian hosts, causing stack smashing. This was detected in the test suite either by test failures due to incorrect results, or by libc/gcc abort'ing with its stack canary triggered.

[libvirt] [PATCH v2] Fix dbus message reading code on big endian hosts

2013-07-29 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The way we were casting small (32bit) integers was broken on big endian hosts, causing stack smashing. This was detected in the test suite either by test failures due to incorrect results, or by libc/gcc abort'ing with its stack canary triggered. In

Re: [libvirt] [PATCH] Fix dbus message reading code on big endian hosts

2013-07-29 Thread Daniel P. Berrange
On Mon, Jul 29, 2013 at 05:30:48PM +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The way we were casting small (32bit) integers was broken on big endian hosts, causing stack smashing. This was detected in the test suite either by test failures due to incorrect

Re: [libvirt] [PATCH v2] Fix dbus message reading code on big endian hosts

2013-07-29 Thread Eric Blake
On 07/29/2013 10:40 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The way we were casting small (32bit) integers was broken on big endian hosts, causing stack smashing. This was detected in the test suite either by test failures due to incorrect results, or by

[libvirt] [PATCH] Remove VIR_DOMAIN_SHUTDOWN_CRASHED from public API

2013-07-29 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The VIR_DOMAIN_SHUTDOWN_CRASHED state constant does not appear to be used in the QEMU code anyway. It also doesn't make much (any) sense, since the 'shutdown' state is a transient state between 'running' and 'shutoff' which is only used by the Xen

[libvirt] [PATCH 6/4] build: skip systemd mock on non-Linux

2013-07-29 Thread Eric Blake
A cross-compile to mingw failed: CC virsystemdmock_la-virsystemdmock.lo ../../tests/virsystemdmock.c:29:6: error: 'dbus_connection_set_change_sigpipe' redeclared without dllimport attribute: previous dllimport ignored [-Werror=attributes] void

Re: [libvirt] [PATCH] Remove VIR_DOMAIN_SHUTDOWN_CRASHED from public API

2013-07-29 Thread Eric Blake
On 07/29/2013 10:48 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The VIR_DOMAIN_SHUTDOWN_CRASHED state constant does not appear to be used in the QEMU code anyway. It also doesn't make much (any) sense, since the 'shutdown' state is a transient state between

[libvirt] [PATCH] Rename VIR_DOMAIN_PAUSED_GUEST_PANICKED to VIR_DOMAIN_PAUSED_CRASHED

2013-07-29 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The VIR_DOMAIN_PAUSED_GUEST_PANICKED constant is badly named, leaking the QEMU event name. Elsewhere in the API we use 'CRASHED' rather than 'PANICKED', and the addition of 'GUEST' is redundant since all events are guest related. Thus rename it to

Re: [libvirt] [PATCH v2] Fix dbus message reading code on big endian hosts

2013-07-29 Thread Daniel P. Berrange
On Mon, Jul 29, 2013 at 10:46:25AM -0600, Eric Blake wrote: On 07/29/2013 10:40 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The way we were casting small (32bit) integers was broken on big endian hosts, causing stack smashing. This was detected in the

Re: [libvirt] [PATCH] Remove VIR_DOMAIN_SHUTDOWN_CRASHED from public API

2013-07-29 Thread Jiri Denemark
On Mon, Jul 29, 2013 at 17:48:15 +0100, Daniel Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The VIR_DOMAIN_SHUTDOWN_CRASHED state constant does not appear to be used in the QEMU code anyway. It also doesn't make much (any) sense, since the 'shutdown' state is a transient

Re: [libvirt] [PATCH] Rename VIR_DOMAIN_PAUSED_GUEST_PANICKED to VIR_DOMAIN_PAUSED_CRASHED

2013-07-29 Thread Eric Blake
On 07/29/2013 10:56 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The VIR_DOMAIN_PAUSED_GUEST_PANICKED constant is badly named, leaking the QEMU event name. Elsewhere in the API we use 'CRASHED' rather than 'PANICKED', and the addition of 'GUEST' is redundant

Re: [libvirt] [PATCH v2] Fix dbus message reading code on big endian hosts

2013-07-29 Thread Jiri Denemark
On Mon, Jul 29, 2013 at 17:57:55 +0100, Daniel Berrange wrote: On Mon, Jul 29, 2013 at 10:46:25AM -0600, Eric Blake wrote: On 07/29/2013 10:40 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The way we were casting small (32bit) integers was broken on big

Re: [libvirt] [PATCH v2] Fix dbus message reading code on big endian hosts

2013-07-29 Thread Eric Blake
On 07/29/2013 10:57 AM, Daniel P. Berrange wrote: case DBUS_TYPE_UINT16: -GET_NEXT_VAL(dbus_uint16_t, unsigned int, %d); +GET_NEXT_VAL(dbus_uint16_t, short unsigned, %d); Works, but 'unsigned short' is a bit more typical. Ok, will change it. ACK.

Re: [libvirt] Linking fails on FreeBSD

2013-07-29 Thread Jason Helfman
All good here http://meatwad.mouf.net/rubick/poudriere/logs/bulk/91amd64-default/latest/logs/libvirt-1.1.1.log -jgh -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v3 2/3] qemu: add helper functions for diskchain checking

2013-07-29 Thread Martin Kletzander
On Mon 29 Jul 2013 02:51:15 PM CEST, Guannan Ren wrote: *src/util/virstoragefile.c: Add a helper function to get the first name of missing backing files, if the name is NULL, it means the diskchain is not broken. *src/qemu/qemu_domain.c: qemuDiskChainCheckBroken(disk) to check if its chain is

[libvirt] [PATCH 7/4] tests: consistently use virFilePrintf

2013-07-29 Thread Eric Blake
Commit a2619962 introduced virFilePrintf to work around the fact that gnulib doesn't (yet) provide guarantees about fprintf() vs. %z, which in turn causes all sorts of mingw compilation errors: ../../tests/testutils.c: In function 'virtTestResult': ../../tests/testutils.c:101:9: error: unknown

[libvirt] ANNOUNCE: Perl binding Sys-Virt release 1.1.0

2013-07-29 Thread Daniel P. Berrange
I am pleased to announce that release 1.1.0 of Sys-Virt, the libvirt Perl API binding is now available for download: http://search.cpan.org/CPAN/authors/id/D/DA/DANBERR/Sys-Virt-1.1.0.tar.gz Changed in this release: - Add support for v3 of migration APIs - Add all new constants in libvirt

[libvirt] [PATCH 8/4] examples: fix mingw build vs. printf

2013-07-29 Thread Eric Blake
Mingw *printf is a moving target; newer mingw now provides a version of asprintf() that fails to understand %lld: CC event_test-event-test.o ../../../../examples/domain-events/events-c/event-test.c: In function 'myDomainEventRTCChangeCallback':

[libvirt] [PATCH 9/4] build: fix shunloadtest breakage

2013-07-29 Thread Eric Blake
Commit 93ec384 was tested on mingw, but broke the build on Linux: CCLD shunloadtest shunloadtest.o: In function `main': /home/eblake/libvirt/tests/shunloadtest.c:106: undefined reference to `virFilePrintf' ... ssh.o: In function `main': /home/eblake/libvirt/tests/ssh.c:43: undefined

[libvirt] [v1.0.5-maint PATCH] lxc: correctly backport /dev/tty fix

2013-07-29 Thread Eric Blake
https://bugzilla.redhat.com/show_bug.cgi?id=982317 maint-only patch; reported by Geert Jansen Commit 17cdc298 tried to backport upstream 90a0c6d, but in resolving conflicts, failed to account that upstream commit e1d32bb refactored code to leave off a leading /dev. * src/lxc/lxc_container.c

Re: [libvirt] [v1.0.5-maint PATCH] lxc: correctly backport /dev/tty fix

2013-07-29 Thread Cole Robinson
On 07/29/2013 05:50 PM, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=982317 maint-only patch; reported by Geert Jansen Commit 17cdc298 tried to backport upstream 90a0c6d, but in resolving conflicts, failed to account that upstream commit e1d32bb refactored code to leave

Re: [libvirt] [v1.0.5-maint PATCH] lxc: correctly backport /dev/tty fix

2013-07-29 Thread Eric Blake
On 07/29/2013 03:53 PM, Cole Robinson wrote: On 07/29/2013 05:50 PM, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=982317 maint-only patch; reported by Geert Jansen Commit 17cdc298 tried to backport upstream 90a0c6d, but in resolving conflicts, failed to account that

[libvirt] [PATCH] Add flag to BaselineCPU API to return detailed CPU features

2013-07-29 Thread Don Dugger
Currently the virConnectBaselineCPU API does not expose the CPU features that are part of the CPU's model. This patch adds a new flag, VIR_CONNECT_BASELINE_SHOW_MODEL, that causes the API to explictly list all features that are part of that model. Signed-off-by: Don Dugger