Re: [libvirt] [PATCH] virsh: Fix debugging

On 08/28/2013 03:39 AM, Eric Blake wrote: > On 08/27/2013 06:27 AM, Martin Kletzander wrote: >> diff --git a/tools/virsh.c b/tools/virsh.c >> index ac77156..34f5c4a 100644 >> --- a/tools/virsh.c >> +++ b/tools/virsh.c >> @@ -2321,10 +2321,9 @@ vshInitDebug(vshControl *ctl) >> debugEnv = ge

Re: [libvirt] [PATCH v3 2/2] Test network update XML parsing

On 08/27/2013 10:39 PM, Laine Stump wrote: > On 08/26/2013 11:43 AM, Ján Tomko wrote: >> Add checks for updating sections of network definition via >> virNetworkDefUpdateSection. >> > > ACK. This is a good start on testing this part of the code. (In order to > test higher level functionality, we p

Re: [libvirt] [PATCH 0/4] Plug some virsh leaks

On 08/28/2013 03:41 AM, Eric Blake wrote: > On 08/27/2013 07:06 AM, Ján Tomko wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1001536 >> >> Ján Tomko (4): >> virsh: free messages after logging them to a file >> virsh: free the list from ListAll APIs even for 0 items >> virsh: free the f

Re: [libvirt] [PATCH] qemu: Remove hostdev entry when freeing the depending network entry

On 08/27/2013 01:21 PM, Peter Krempa wrote: > When using a that points to a network with > hostdev forwarding mode a hostdev alias is created for the network. This > allias is inserted into the hostdev list, but is backed with a part of > the network object that it is connected to. > > When a VM i

[libvirt] [PATCH 1/3] qemu: only parse basename when determining emulator properties

'virsh domxml-from-native' and 'virsh qemu-attach' could misbehave for an emulator installed in (a somewhat unlikely) location such as /usr/local/qemu-1.6/qemu-system-x86_64 or (an even less likely) /opt/notxen/qemu-system-x86_64. Limit the strstr seach to just the basename of the file where we ar

[libvirt] [PATCH 3/3] qemu: recognize -machine accel=kvm when parsing native

In Fedora 19, 'qemu-kvm' is a simple wrapper that calls 'qemu-system-x86_64 -machine accel=kvm'. Attempting to use 'virsh qemu-attach $pid' to a machine started as: qemu-kvm -cdrom /var/lib/libvirt/images/foo.img \ -monitor unix:/tmp/demo,server,nowait -name foo \ --uuid cece4f9f-dff0-575d-0e8e

[libvirt] [PATCH 0/n] improvements to native-to-xml parsing

I tried to use 'virsh qemu-attach', and hit different failures with both libvirt.git on Fedora 19, and with an older version of libvirt on RHEL 6. I'm posting patches that I have so far to start reviews, but need to write still more patches as I still haven't succeeded at attaching. I also need t

[libvirt] [PATCH 2/3] qemu: simplify list cleanup

No need to open code now that we have a nice function. * src/qemu/qemu_command.c (qemuParseCommandLinePid): Simplify cleanup. Signed-off-by: Eric Blake --- src/qemu/qemu_command.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu

Re: [libvirt] [PATCH] qemu: Add missing VIR_DOMAIN_BLOCK_COMMIT_DELETE flags

On 08/27/2013 07:59 PM, Eric Blake wrote: On 08/27/2013 03:37 AM, Michal Privoznik wrote: Yes, the codes haven't any implementation for BLOCK_COMMIT_DELETE flag now, maybe, only need to raise a friendly error message in here instead of "unsupported flags (0x2) ". I agree that this error me

Re: [libvirt] How about realize domainSetBlockIoTune by cgroup?

On 08/28/2013 09:47 AM, hzguanqi...@corp.netease.com wrote: > On 2013-08-28 09:43 , Gao feng wrote: > > On 08/27/2013 12:10 PM, hzguanqi...@corp.netease.com wrote: > > Hello experts, > > > > It seems that blkiotune of kvm domain is set through qemu

Re: [libvirt] How about realize domainSetBlockIoTune by cgroup?

On 2013-08-28 09:43 , Gao feng wrote: On 08/27/2013 12:10 PM, hzguanqi...@corp.netease.com wrote: > Hello experts, > > It seems that blkiotune of kvm domain is set through qemu now, and We found > there are some throttle shaking problem when using this interface. > > As you can do the same thi

Re: [libvirt] How about realize domainSetBlockIoTune by cgroup?

On 2013-08-28 09:35 , Eric Blake wrote: On 08/26/2013 10:10 PM, hzguanqi...@corp.netease.com wrote: > Hello experts, [please configure your mailer to wrap long lines] > > It seems that blkiotune of kvm domain is set through qemu now, and We found > there are some throttle shaking problem when u

Re: [libvirt] How about realize domainSetBlockIoTune by cgroup?

On 08/27/2013 12:10 PM, hzguanqi...@corp.netease.com wrote: > Hello experts, > > It seems that blkiotune of kvm domain is set through qemu now, and We found > there are some throttle shaking problem when using this interface. > > As you can do the same thing through blkio cgroup, and this soun

Re: [libvirt] [PATCH 0/4] Plug some virsh leaks

On 08/27/2013 07:06 AM, Ján Tomko wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1001536 > > Ján Tomko (4): > virsh: free messages after logging them to a file > virsh: free the list from ListAll APIs even for 0 items > virsh: free the formatting string when listing pool details > vi

Re: [libvirt] [PATCH] virsh: Fix debugging

On 08/27/2013 06:27 AM, Martin Kletzander wrote: > On 08/27/2013 01:19 PM, Martin Kletzander wrote: >> Commit a0b6a36f "fixed" what abfff210 broke (URI precedence), but >> there was still one more thing missing to fix. When using virsh >> parameters to setup debugging, those weren't honored, becau

Re: [libvirt] How about realize domainSetBlockIoTune by cgroup?

Hmm, It seems everybody is in busy. I want to join the community and make contribution. As I'm a newer, I really appreciate experts' advice. I know in openstack community, there is a blueprint where you can put forward your idea and pepole can review. I don't know whether libvirt community has

Re: [libvirt] How about realize domainSetBlockIoTune by cgroup?

On 08/26/2013 10:10 PM, hzguanqi...@corp.netease.com wrote: > Hello experts, [please configure your mailer to wrap long lines] > > It seems that blkiotune of kvm domain is set through qemu now, and We found > there are some throttle shaking problem when using this interface. > > As you can do

Re: [libvirt] [PATCH v2] kvm: warn if num cpus is greater than num recommended

On 08/23/2013 07:24 AM, Andrew Jones wrote: > The comment in kvm_max_vcpus() states that it's using the recommended > procedure from the kernel API documentation to get the max number > of vcpus that kvm supports. It is, but by always returning the > maximum number supported. The maximum number sho

Re: [libvirt] [PATCH v3 2/2] Test network update XML parsing

On 08/26/2013 11:43 AM, Ján Tomko wrote: > Add checks for updating sections of network definition via > virNetworkDefUpdateSection. > ACK. This is a good start on testing this part of the code. (In order to test higher level functionality, we probably need to restructure bridge_driver.c so that it

Re: [libvirt] [PATCH v3 1/2] Remove the space before the slash in network XML

On 08/26/2013 11:43 AM, Ján Tomko wrote: > This matches the style we use elsewhere and allows > nat-network-dns-srv-record{,-minimal}.xml to be tested in > network XML -> XML test. Long, but mechanical and verifiable thanks to the tests. ACK. -- libvir-list mailing list libvir-list@redhat.com ht

Re: [libvirt] [Qemu-devel] pvpanic plans?

On 08/27/2013 11:06 AM, Richard W.M. Jones wrote: On Thu, Aug 22, 2013 at 03:09:06PM -0500, Anthony Liguori wrote: Paolo Bonzini writes: Also, a virtio watchdog device makes little sense, IMHO. PV makes sense if emulation has insufficient performance, excessive CPU usage, or excessive complex

[libvirt] [PATCH V2] Use loop-control to allocate loop device.

This patch changes virFileLoopDeviceOpen() to use the new loop-control device to allocate a new loop device. If this behavior is unsupported we fall back to the previous method of searching /dev for a free device. With this patch you can start as many image based LXC domains as you like (well alm

Re: [libvirt] [PATCH] Use loop-control to allocate loopback device.

On Tue, Aug 27, 2013 at 10:34:54AM -0700, Ian Main wrote: > On Tue, Aug 27, 2013 at 03:28:07PM +0100, Daniel P. Berrange wrote: > > On Mon, Aug 26, 2013 at 12:30:39PM -0700, Ian Main wrote: > > > This patch changes virFileLoopDeviceOpen() to use the new loop-control > > > device to allocate a new l

Re: [libvirt] [PATCH] qemu: Remove hostdev entry when freeing the depending network entry

- Original Message - > From: "Peter Krempa" > To: libvir-list@redhat.com > Cc: "Peter Krempa" > Sent: Tuesday, August 27, 2013 7:21:24 PM > Subject: [libvirt] [PATCH] qemu: Remove hostdev entry when freeing the > depending network entry > > When using a that points to a networ

Re: [libvirt] [PATCH] Use loop-control to allocate loopback device.

On Tue, Aug 27, 2013 at 03:28:07PM +0100, Daniel P. Berrange wrote: > On Mon, Aug 26, 2013 at 12:30:39PM -0700, Ian Main wrote: > > This patch changes virFileLoopDeviceOpen() to use the new loop-control > > device to allocate a new loop device. If this behavior is unsupported > > or an error occur

[libvirt] [PATCH] qemu: Remove hostdev entry when freeing the depending network entry

When using a that points to a network with hostdev forwarding mode a hostdev alias is created for the network. This allias is inserted into the hostdev list, but is backed with a part of the network object that it is connected to. When a VM is being stopped qemuProcessStop() calls networkReleaseA

Re: [libvirt] [PATCH v3 0/4] Add support for adjusting the 64-bit PCI hole size

On 08/15/2013 01:30 PM, Ján Tomko wrote: > v3: > use sub-element of the root PCI controller > with 'unit' attribute, defaulting to KiB > > v2: > https://www.redhat.com/archives/libvir-list/2013-August/msg00565.html > Use 'pcihole64' attribute of the root PCI controller > instead of element in do

Re: [libvirt] [PATCH v3 0/4] Add support for adjusting the 64-bit PCI hole size

On 23.08.2013 09:16, Ján Tomko wrote: > On 08/15/2013 01:30 PM, Ján Tomko wrote: >> v3: >> use sub-element of the root PCI controller >> with 'unit' attribute, defaulting to KiB >> >> v2: >> https://www.redhat.com/archives/libvir-list/2013-August/msg00565.html >> Use 'pcihole64' attribute of the r

Re: [libvirt] [PATCHv4 2/5] domifaddr: Implement the remote protocol

> s/ip/IP/, > > > + */ >> +const REMOTE_DOMAIN_IP_ADDR_MAX = 16; >> > > hm, are these 2 limits too small? I don't believe one host could only have > up to 32 interfaces. Any evidence for you to descrease them in new series? > > Osier > Since there is no theoretical limit on the number of interfa

Re: [libvirt] [PATCH] Use loop-control to allocate loopback device.

On Mon, Aug 26, 2013 at 12:30:39PM -0700, Ian Main wrote: > This patch changes virFileLoopDeviceOpen() to use the new loop-control > device to allocate a new loop device. If this behavior is unsupported > or an error occurs while trying to do this it falls back to the previous > method of searchin

Re: [libvirt] [PATCHv2 1/4] VMX: Add cdrom-raw dev type from VMWare Fusion

On Tue, Aug 27, 2013 at 8:56 AM, Paolo Bonzini wrote: > Il 27/08/2013 15:50, Daniel P. Berrange ha scritto: > > On Thu, Aug 22, 2013 at 08:53:06PM -0500, Doug Goldstein wrote: > >> According to VMWare's documentation 'cdrom-raw' is an acceptable value > >> for deviceType for a CD-ROM drive. The d

Re: [libvirt] [PATCHv4 4/5] domifaddr: Add virsh support

> > So, qemu-ga doesn't understand that there can't be more than one > > device with same MAC addr. So, I think we are left with the following > > options: > > Actually that's wrong. You *can* have 2 completely different physical > NICs with the same MAC address. > > > (i) Modify qemu-guest-agent t

Re: [libvirt] [PATCHv4 4/5] domifaddr: Add virsh support

On Tue, Aug 27, 2013 at 07:46:27PM +0530, Nehal J Wani wrote: > > > So, qemu-ga doesn't understand that there can't be more than one > > > device with same MAC addr. So, I think we are left with the following > > > options: > > > > Actually that's wrong. You *can* have 2 completely different physic

Re: [libvirt] [PATCHv4 4/5] domifaddr: Add virsh support

On Tue, Aug 27, 2013 at 07:28:23PM +0530, Nehal J Wani wrote: > On Tue, Aug 27, 2013 at 6:20 PM, Daniel P. Berrange > wrote: > > > > On Sun, Aug 25, 2013 at 04:45:44AM +0530, Nehal J Wani wrote: > > > Use virDomainInterfacesAddresses in virsh > > > > > > tools/virsh-domain-monitor.c > > >* Int

Re: [libvirt] [PATCHv4 4/5] domifaddr: Add virsh support

On Tue, Aug 27, 2013 at 6:20 PM, Daniel P. Berrange wrote: > > On Sun, Aug 25, 2013 at 04:45:44AM +0530, Nehal J Wani wrote: > > Use virDomainInterfacesAddresses in virsh > > > > tools/virsh-domain-monitor.c > >* Introduce new command : domifaddr > >virsh # domifaddr f18 > >Name

Re: [libvirt] [Qemu-devel] pvpanic plans?

On Tue, Aug 27, 2013 at 08:26:53AM -0500, Anthony Liguori wrote: > That's why I think having a virtio-ilo makes sense. This is not a > solved problem today. What's the scope of virtio-ilo? If it's anything like a real ILO it's going to do a lot of not-very-related things, such as: - pvpanic-ty

Re: [libvirt] [PATCHv2 1/4] VMX: Add cdrom-raw dev type from VMWare Fusion

Il 27/08/2013 15:50, Daniel P. Berrange ha scritto: > On Thu, Aug 22, 2013 at 08:53:06PM -0500, Doug Goldstein wrote: >> According to VMWare's documentation 'cdrom-raw' is an acceptable value >> for deviceType for a CD-ROM drive. The documentation states that the VMX >> configuration for a CD-ROM d

Re: [libvirt] [PATCHv2 1/4] VMX: Add cdrom-raw dev type from VMWare Fusion

On Thu, Aug 22, 2013 at 08:53:06PM -0500, Doug Goldstein wrote: > According to VMWare's documentation 'cdrom-raw' is an acceptable value > for deviceType for a CD-ROM drive. The documentation states that the VMX > configuration for a CD-ROM deviceType is as follows: > > ide|scsi(n):(n).deviceType

Re: [libvirt] [PATCH v3 4/4] Build QEMU command line for pcihole64

On Tue, Aug 27, 2013 at 03:44:44PM +0200, Ján Tomko wrote: > On 08/27/2013 03:39 PM, Daniel P. Berrange wrote: > > On Thu, Aug 15, 2013 at 01:30:21PM +0200, Ján Tomko wrote: > >> QEMU commit 3984890 introduced the "pci-hole64-size" property, > >> to i440FX-pcihost and q35-pcihost with a default set

Re: [libvirt] [PATCH v3 4/4] Build QEMU command line for pcihole64

On 08/27/2013 03:39 PM, Daniel P. Berrange wrote: > On Thu, Aug 15, 2013 at 01:30:21PM +0200, Ján Tomko wrote: >> QEMU commit 3984890 introduced the "pci-hole64-size" property, >> to i440FX-pcihost and q35-pcihost with a default setting of 2 GB. >> >> Translate x to: >> -global q35-pcihost.pci-hole

Re: [libvirt] [PATCH v3 4/4] Build QEMU command line for pcihole64

On Thu, Aug 15, 2013 at 01:30:21PM +0200, Ján Tomko wrote: > QEMU commit 3984890 introduced the "pci-hole64-size" property, > to i440FX-pcihost and q35-pcihost with a default setting of 2 GB. > > Translate x to: > -global q35-pcihost.pci-hole64-size=x for q35 machines and > -global i440FX-pcihost.

Re: [libvirt] [PATCH v3 3/4] Add pcihole64 element to root PCI controllers

On Thu, Aug 15, 2013 at 01:30:20PM +0200, Ján Tomko wrote: > > 1048576 > > > It can be used to adjust (or disable) the size of the 64-bit > PCI hole. The size attribute is in kilobytes (different unit > can be specified on input), but it gets rounded up to > the nearest GB by QEMU. > > Disabl

Re: [libvirt] [PATCH v3 2/4] Allow controller XML parsing to use XPath context

On Thu, Aug 15, 2013 at 01:30:19PM +0200, Ján Tomko wrote: > virDomainParseScaledValue requires it. > --- > src/conf/domain_conf.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) ACK Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http

Re: [libvirt] Information needed regarding libvirt error

Hi Martin, Thanks for your reply. We have tried applying the patch as mentioned in link https://www.redhat.com/archives/libvir-list/2013-August/msg01246.html but we could still observe this issue. Thanks Abhinay On Tue, Aug 27, 2013 at 10:04 AM, Martin Kletzander wrote: > On Tue 27 Aug 2013 09

Re: [libvirt] [PATCH v3 1/4] Move virDomainParseScaledValue earlier

On Thu, Aug 15, 2013 at 01:30:18PM +0200, Ján Tomko wrote: > Let virDomainControllerDefParseXML use it without > a forward declaration. > --- > src/conf/domain_conf.c | 105 > + > 1 file changed, 53 insertions(+), 52 deletions(-) ACK Daniel -- |

Re: [libvirt] [Qemu-devel] pvpanic plans?

On Tue, Aug 27, 2013 at 8:20 AM, Richard W.M. Jones wrote: > On Tue, Aug 27, 2013 at 04:08:12PM +0300, Ronen Hod wrote: >> So the right solution is to send a heart-beat to a management >> application (using qemu-ga or whatever), and let it decide how to >> handle it. This is host-centric solution

Re: [libvirt] [Qemu-devel] pvpanic plans?

On Tue, Aug 27, 2013 at 02:13:34PM +0100, Daniel P. Berrange wrote: > On Thu, Aug 22, 2013 at 09:16:57PM +0200, Paolo Bonzini wrote: > > Il 22/08/2013 19:53, Laszlo Ersek ha scritto: > > >> > We should just introduce a simple watchdog device based on virtio and > > >> > call it a day. Then it's cr

Re: [libvirt] [Qemu-devel] pvpanic plans?

On Tue, Aug 27, 2013 at 04:08:12PM +0300, Ronen Hod wrote: > So the right solution is to send a heart-beat to a management > application (using qemu-ga or whatever), and let it decide how to > handle it. Agreed. The qemu watchdog lets you do this already. You can (using the qemu monitor, or libv

Re: [libvirt] [PATCHv4 1/5] domifaddr: Implement the public API

On Tue, Aug 27, 2013 at 06:43:06PM +0530, Nehal J Wani wrote: > On Tue, Aug 27, 2013 at 6:06 PM, Daniel P. Berrange > wrote: > > > > On Sun, Aug 25, 2013 at 04:45:41AM +0530, Nehal J Wani wrote: > > > diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in > > > index a47e33c..deb

Re: [libvirt] pvpanic plans?

On Tue, Aug 27, 2013 at 8:13 AM, Daniel P. Berrange wrote: > On Thu, Aug 22, 2013 at 09:16:57PM +0200, Paolo Bonzini wrote: >> Il 22/08/2013 19:53, Laszlo Ersek ha scritto: >> >> > We should just introduce a simple watchdog device based on virtio and >> >> > call it a day. Then it's cross platfor

Re: [libvirt] pvpanic plans?

On Thu, Aug 22, 2013 at 09:16:57PM +0200, Paolo Bonzini wrote: > Il 22/08/2013 19:53, Laszlo Ersek ha scritto: > >> > We should just introduce a simple watchdog device based on virtio and > >> > call it a day. Then it's cross platform, solves the guest enumeration > >> > problem, and libvirt can d

Re: [libvirt] [PATCHv4 1/5] domifaddr: Implement the public API

On Tue, Aug 27, 2013 at 6:06 PM, Daniel P. Berrange wrote: > > On Sun, Aug 25, 2013 at 04:45:41AM +0530, Nehal J Wani wrote: > > diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in > > index a47e33c..deb1e1f 100644 > > --- a/include/libvirt/libvirt.h.in > > +++ b/include/libvi

Re: [libvirt] [PATCHv2 0/2] Support setting the 'removable' flag for USB disks

On 08/23/13 12:38, Fred A. Kemp wrote: > From: "Fred A. Kemp" > > The commit message of patch #2 explains the purpose of this patch set. > A review would be greatly appreciated! > > Note that I've only added the new capability for usb-storage.removable > to the qemu help tests of qemu(-kvm) vers

Re: [libvirt] [PATCHv4 2/5] domifaddr: Implement the remote protocol

On Sun, Aug 25, 2013 at 04:45:42AM +0530, Nehal J Wani wrote: > diff --git a/daemon/remote.c b/daemon/remote.c > index 03d5557..44d7ff2 100644 > --- a/daemon/remote.c > +++ b/daemon/remote.c > @@ -5025,7 +5025,134 @@ cleanup: > return rv; > } > > +static int > +remoteSerializeDomainInterfac

[libvirt] [PATCH 3/4] virsh: free the formatting string when listing pool details

==23== 41 bytes in 1 blocks are definitely lost in loss record 626 of 727 ==23==by 0x4F0099F: virAsprintfInternal (virstring.c:358) ==23==by 0x15D2C9: cmdPoolList (virsh-pool.c:1268) https://bugzilla.redhat.com/show_bug.cgi?id=1001536 --- tools/virsh-pool.c | 3 ++- 1 file changed, 2 inse

Re: [libvirt] [PATCH 2/5] cpu_models: implement the remote protocol

"Daniel P. Berrange" writes: >> +struct remote_connect_get_cpu_model_names_args { >> +remote_nonnull_string arch; >> +unsigned int flags; >> +}; >> + >> +struct remote_connect_get_cpu_model_names_ret { >> +remote_nonnull_string models<>; > > Use of <> is forbidden - please define a co

[libvirt] [PATCH 0/4] Plug some virsh leaks

https://bugzilla.redhat.com/show_bug.cgi?id=1001536 Ján Tomko (4): virsh: free messages after logging them to a file virsh: free the list from ListAll APIs even for 0 items virsh: free the formatting string when listing pool details virsh: free the caps list properly if one of them is inva

[libvirt] [PATCH 2/4] virsh: free the list from ListAll APIs even for 0 items

virsh secret-list leak when no secrets are defined: ==27== 8 bytes in 1 blocks are definitely lost in loss record 6 of 726 ==27==by 0x4E941DD: virAllocN (viralloc.c:183) ==27==by 0x5037F1A: remoteConnectListAllSecrets (remote_driver.c:3076) ==27==by 0x5004EC6: virConnectListAllSecrets

[libvirt] [PATCH 1/4] virsh: free messages after logging them to a file

The messages were only freed on error. ==12== 1,100 bytes in 1 blocks are definitely lost in loss record 698 of 729 ==12==by 0x4E98C22: virBufferAsprintf (virbuffer.c:294) ==12==by 0x12C950: vshOutputLogFile (virsh.c:2440) ==12==by 0x12880B: vshError (virsh.c:2254) ==12==by 0x13195

[libvirt] [PATCH 4/4] virsh: free the caps list properly if one of them is invalid

VIR_FREE(caps) is not enough to free an array allocated by vshStringToArray. ==17== 4 bytes in 1 blocks are definitely lost in loss record 4 of 728 ==17==by 0x4EFFC44: virStrdup (virstring.c:554) ==17==by 0x128B10: _vshStrdup (virsh.c:125) ==17==by 0x129164: vshStringToArray (virsh.c:2

Re: [libvirt] [PATCH 0/2] Add http and ftp support for cdrom disk

On 08/22/13 21:03, Aline Manera wrote: > From: Aline Manera > > Aline Manera (2): > Add http protocol support for cdrom disk > Add ftp protocol support for cdrom disk > This patchset is now pushed. Peter signature.asc Description: OpenPGP digital signature -- libvir-list mailing list l

Re: [libvirt] [PATCHv4 3/5] domifaddr: Implement the API for qemu

On Sun, Aug 25, 2013 at 04:45:43AM +0530, Nehal J Wani wrote: > By querying the qemu guest agent with the QMP command > "guest-network-get-interfaces" and converting the received > JSON output to structured objects. > > src/qemu/qemu_agent.h: > * Define qemuAgentGetInterfaces > > src/qemu/qemu_

Re: [libvirt] [PATCHv4 4/5] domifaddr: Add virsh support

On Sun, Aug 25, 2013 at 04:45:44AM +0530, Nehal J Wani wrote: > Use virDomainInterfacesAddresses in virsh > > tools/virsh-domain-monitor.c >* Introduce new command : domifaddr >virsh # domifaddr f18 >Name MAC address IPv4 addressIPv6 address > > -

Re: [libvirt] [PATCHv4 1/5] domifaddr: Implement the public API

On Sun, Aug 25, 2013 at 04:45:41AM +0530, Nehal J Wani wrote: > diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in > index a47e33c..deb1e1f 100644 > --- a/include/libvirt/libvirt.h.in > +++ b/include/libvirt/libvirt.h.in > @@ -2044,6 +2044,39 @@ int > virD

Re: [libvirt] [PATCH 2/2] Add ftp protocol support for cdrom disk

On Thu, Aug 22, 2013 at 04:03:08PM -0300, Aline Manera wrote: > From: Aline Manera > > The ftp protocol is already recognized by qemu/KVM so add this support to > libvirt as well. > The xml should be as following: > > > > > > > > Signed-off-by: Aline Manera

Re: [libvirt] [PATCH 1/2] Add http protocol support for cdrom disk

On Thu, Aug 22, 2013 at 04:03:07PM -0300, Aline Manera wrote: > From: Aline Manera > > QEMU/KVM already allows a HTTP URL for the cdrom ISO image so add this support > to libvirt as well. > The xml should be as following: > > > > > > > > Signed-off-by: Aline Man

Re: [libvirt] [PATCH] virsh: Fix debugging

On 08/27/2013 01:19 PM, Martin Kletzander wrote: > Commit a0b6a36f "fixed" what abfff210 broke (URI precedence), but > there was still one more thing missing to fix. When using virsh > parameters to setup debugging, those weren't honored, because at the > time debugging was initializing, arguments

Re: [libvirt] [PATCH] Don't free NULL network in cmdNetworkUpdate

On 08/27/2013 06:11 AM, Michal Privoznik wrote: >> All _internal_ vir*Free functions should be NOPs. All public vir*Free >> APIs (including virNetworkFree) are documented to explicitly fail on >> NULL arguments (more precisely, on any argument not created by an >> earlier API call), and we cannot

Re: [libvirt] [PATCH] Don't free NULL network in cmdNetworkUpdate

On 08/27/2013 08:07 AM, Eric Blake wrote: > On 08/27/2013 06:03 AM, Laine Stump wrote: >> On 08/26/2013 09:39 AM, Ján Tomko wrote: >>> If the network has not been found, virNetworkFree(NULL) >>> was called, resulting in an extra error: >>> error: invalid network pointer in virNetworkFree >> >> The

Re: [libvirt] Information needed regarding libvirt error

Hi Martin, Sorry for spamming. Forgot to ask in my eralier mail. >>There's also a patch >>fixing cpu-stats command, check it that helps. Is the below patch which you were refering to. https://www.redhat.com/archives/libvir-list/2013-June/msg00214.html If not can you provide the link for the pat

Re: [libvirt] Information needed regarding libvirt error

Hi Martin, Thanks for your reply. I have already posted this query to libvirt list. https://www.redhat.com/archives/libvirt-users/2013-August/msg00114.html >>Wanting to post the link here, I've found >>that even the machine name is the same, so it shouldn't be a problem for >>you to find it. Wer

Re: [libvirt] [PATCH] Don't free NULL network in cmdNetworkUpdate

On 27.08.2013 14:07, Eric Blake wrote: > On 08/27/2013 06:03 AM, Laine Stump wrote: >> On 08/26/2013 09:39 AM, Ján Tomko wrote: >>> If the network has not been found, virNetworkFree(NULL) >>> was called, resulting in an extra error: >>> error: invalid network pointer in virNetworkFree >> >> >> The

Re: [libvirt] [PATCH] Don't free NULL network in cmdNetworkUpdate

On 08/27/2013 06:03 AM, Laine Stump wrote: > On 08/26/2013 09:39 AM, Ján Tomko wrote: >> If the network has not been found, virNetworkFree(NULL) >> was called, resulting in an extra error: >> error: invalid network pointer in virNetworkFree > > > The patch is okay, but all vir*Free() functions sh

Re: [libvirt] [PATCH] Don't free NULL network in cmdNetworkUpdate

On 27.08.2013 14:03, Laine Stump wrote: > On 08/26/2013 09:39 AM, Ján Tomko wrote: >> If the network has not been found, virNetworkFree(NULL) >> was called, resulting in an extra error: >> error: invalid network pointer in virNetworkFree > > > The patch is okay, but all vir*Free() functions shoul

Re: [libvirt] [PATCH] Don't free NULL network in cmdNetworkUpdate

On 08/26/2013 09:39 AM, Ján Tomko wrote: > If the network has not been found, virNetworkFree(NULL) > was called, resulting in an extra error: > error: invalid network pointer in virNetworkFree The patch is okay, but all vir*Free() functions should be NOPs when the argument is NULL. -- libvir-li

Re: [libvirt] [PATCH] qemu: Add missing VIR_DOMAIN_BLOCK_COMMIT_DELETE flags

On 08/27/2013 03:37 AM, Michal Privoznik wrote: >> Yes, the codes haven't any implementation for BLOCK_COMMIT_DELETE flag >> now, maybe, only need to raise a friendly error message in here instead >> of "unsupported flags (0x2) ". > > I agree that this error message is not user-friendly. Bare

Re: [libvirt] [PATCH] qemu: Add missing VIR_DOMAIN_BLOCK_COMMIT_DELETE flags

On 08/27/2013 01:53 AM, Alex Jia wrote: > The flag "VIR_DOMAIN_BLOCK_COMMIT_DELETE" is missed by > qemuDomainBlockCommit(), > and then will hit error "unsupported flags (0x2) in function > qemuDomainBlockCommit" if users run 'virsh blockcommit' with '--delete' > option. > > RHBZ: https://bugzill

Re: [libvirt] [PATCHv4 5/5] domifaddr: Expose python binding

On 25/08/13 14:02, Guido Günther wrote: On Sun, Aug 25, 2013 at 04:45:45AM +0530, Nehal J Wani wrote: Expose virDomainInterfacesAddresses to python binding examples/python/Makefile.am: * Add new file domipaddrs.py examples/python/README: * Add documentation for the python example python

Re: [libvirt] [PATCHv4 4/5] domifaddr: Add virsh support

On 25/08/13 07:15, Nehal J Wani wrote: Use virDomainInterfacesAddresses in virsh tools/virsh-domain-monitor.c * Introduce new command : domifaddr virsh # domifaddr f18 Name MAC address IPv4 addressIPv6 address --

[libvirt] [PATCH] virsh: Fix debugging

Commit a0b6a36f "fixed" what abfff210 broke (URI precedence), but there was still one more thing missing to fix. When using virsh parameters to setup debugging, those weren't honored, because at the time debugging was initializing, arguments weren't parsed yet. To make ewerything work as expected

Re: [libvirt] [PATCH] Always specify qcow2 compat level on qemu-img command line

On 08/27/2013 11:56 AM, Daniel P. Berrange wrote: > On Fri, Aug 23, 2013 at 01:31:41PM +0200, Ján Tomko wrote: >> qemu-img is going to switch the default for QCOW2 >> to QCOW2v3 (compat=1.1) [0] >> >> Extend the probing for qemu-img command line options to check >> if -o compat is supported. If the

Re: [libvirt] [PATCH 03/17] qemu: Move qemuDomainAttachDeviceDiskLive to qemu_hotplug.c

On 08/01/2013 03:28 PM, Jiri Denemark wrote: > --- > src/qemu/qemu_driver.c | 114 -- > src/qemu/qemu_hotplug.c | 142 > > src/qemu/qemu_hotplug.h | 16 ++ > 3 files changed, 134 insertions(+), 138 deletion

Re: [libvirt] [PATCH 0/3] caps: expose the user and group owner of the HV

On Tue, Aug 27, 2013 at 02:00:03AM +0200, Giuseppe Scrivano wrote: > virt-manager has no way to known the user/group that run the HV > process without requiring the user to manually set it trough setup.py > or assuming "root" as default value. > > This series extends the Guest capabilities with "h

Re: [libvirt] [PATCH] qemu: Add missing VIR_DOMAIN_BLOCK_COMMIT_DELETE flags

On 08/27/2013 05:54 PM, Peter Krempa wrote: On 08/27/13 11:37, Michal Privoznik wrote: On 27.08.2013 10:58, Alex Jia wrote: On 08/27/2013 04:47 PM, Peter Krempa wrote: On 08/27/13 09:53, Alex Jia wrote: The flag "VIR_DOMAIN_BLOCK_COMMIT_DELETE" is missed by qemuDomainBlockCommit(), and then w

Re: [libvirt] [PATCH] Always specify qcow2 compat level on qemu-img command line

On Fri, Aug 23, 2013 at 01:31:41PM +0200, Ján Tomko wrote: > qemu-img is going to switch the default for QCOW2 > to QCOW2v3 (compat=1.1) [0] > > Extend the probing for qemu-img command line options to check > if -o compat is supported. If the volume definition specifies > the qcow2 format but no c

Re: [libvirt] [PATCH] qemu: Add missing VIR_DOMAIN_BLOCK_COMMIT_DELETE flags

On 08/27/13 11:37, Michal Privoznik wrote: > On 27.08.2013 10:58, Alex Jia wrote: >> On 08/27/2013 04:47 PM, Peter Krempa wrote: >>> On 08/27/13 09:53, Alex Jia wrote: The flag "VIR_DOMAIN_BLOCK_COMMIT_DELETE" is missed by qemuDomainBlockCommit(), and then will hit error "unsupported

Re: [libvirt] [PATCHv2 1/2] qemu: Add capability flag for usb-storage

On Fri, Aug 23, 2013 at 12:38:10PM +0200, Fred A. Kemp wrote: > From: "Fred A. Kemp" > > Allow use of the usb-storage device only if the new capability flag > QEMU_CAPS_DEVICE_USB_STORAGE is set, which it is for qemu(-kvm) > versions >= 0.12.1.2-rhel62-beta. > --- > src/qemu/qemu_capabilities.c

Re: [libvirt] [PATCHv2 2/2] qemu: Support setting the 'removable' flag for USB disks

On Fri, Aug 23, 2013 at 12:38:11PM +0200, Fred A. Kemp wrote: > From: "Fred A. Kemp" > > Add an attribute named 'removable' to the 'target' element of disks, > which controls the removable flag. For instance, on a Linux guest it > controls the value of /sys/block/$dev/removable. This option is on

Re: [libvirt] [PATCH 2/5] cpu_models: implement the remote protocol

On Thu, Aug 22, 2013 at 09:19:14PM +0200, Giuseppe Scrivano wrote: > 4 files changed, 115 insertions(+), 1 deletion(-) > diff --git a/src/remote/remote_protocol.x b/src/remote/remote_protocol.x > index 7cfebdf..924d629 100644 > --- a/src/remote/remote_protocol.x > +++ b/src/remote/remote_protocol.

Re: [libvirt] [PATCH] qemu: Add missing VIR_DOMAIN_BLOCK_COMMIT_DELETE flags

On 27.08.2013 10:58, Alex Jia wrote: > On 08/27/2013 04:47 PM, Peter Krempa wrote: >> On 08/27/13 09:53, Alex Jia wrote: >>> The flag "VIR_DOMAIN_BLOCK_COMMIT_DELETE" is missed by >>> qemuDomainBlockCommit(), >>> and then will hit error "unsupported flags (0x2) in function >>> qemuDomainBlockCommit

Re: [libvirt] [PATCHv4 3/5] domifaddr: Implement the API for qemu

On 25/08/13 07:15, Nehal J Wani wrote: By querying the qemu guest agent with the QMP command "guest-network-get-interfaces" and converting the received JSON output to structured objects. src/qemu/qemu_agent.h: * Define qemuAgentGetInterfaces src/qemu/qemu_agent.c: * Implement qemuAgentGet

Re: [libvirt] [PATCHv4 1/5] domifaddr: Implement the public API

On 25/08/13 07:15, Nehal J Wani wrote: s/API/APIs/, in the subject. Define a new API virDomainInterfacesAddresses, which returns the address information of a running domain's interfaces(s). If no interface name is specified, it returns the information of all interfaces, otherwise it only retu

Re: [libvirt] [PATCHv4 2/5] domifaddr: Implement the remote protocol

On 25/08/13 07:15, Nehal J Wani wrote: Implement RPC calls for virDomainInterfacesAddresses daemon/remote.c * Define remoteSerializeDomainInterfacePtr, remoteDispatchDomainInterfacesAddresses src/remote/remote_driver.c * Define remoteDomainInterfacesAddresses src/remote/remote_protoco

Re: [libvirt] [PATCH] qemu: Add missing VIR_DOMAIN_BLOCK_COMMIT_DELETE flags

On 08/27/2013 04:47 PM, Peter Krempa wrote: On 08/27/13 09:53, Alex Jia wrote: The flag "VIR_DOMAIN_BLOCK_COMMIT_DELETE" is missed by qemuDomainBlockCommit(), and then will hit error "unsupported flags (0x2) in function qemuDomainBlockCommit" if users run 'virsh blockcommit' with '--delete' opti

Re: [libvirt] [PATCH] qemu: Add missing VIR_DOMAIN_BLOCK_COMMIT_DELETE flags

On 08/27/13 09:53, Alex Jia wrote: > The flag "VIR_DOMAIN_BLOCK_COMMIT_DELETE" is missed by > qemuDomainBlockCommit(), > and then will hit error "unsupported flags (0x2) in function > qemuDomainBlockCommit" if users run 'virsh blockcommit' with '--delete' > option. > > RHBZ: https://bugzilla.red

Re: [libvirt] [Qemu-devel] pvpanic plans?

On Thu, Aug 22, 2013 at 01:25:32PM -0500, Anthony Liguori wrote: > I believe that the watchdogs we emulate today are not supported by a > majority of guests. BTW this is not true. The two watchdog devices are supported by all Linux guests. Windows guests do not support them, but Windows lacks[1]

Re: [libvirt] [Qemu-devel] pvpanic plans?

On Thu, Aug 22, 2013 at 03:09:06PM -0500, Anthony Liguori wrote: > Paolo Bonzini writes: > > Also, a virtio watchdog device makes little sense, IMHO. PV makes sense > > if emulation has insufficient performance, excessive CPU usage, or > > excessive complexity. We already have both an ISA and a

Re: [libvirt] Information needed regarding libvirt error

On Tue 27 Aug 2013 09:21:44 AM CEST, arun abhinay wrote: > Hi Martin, > > Sorry for spamming. Forgot to ask in my eralier mail. > >>> There's also a patch >>> fixing cpu-stats command, check it that helps. > > Is the below patch which you were refering to. > https://www.redhat.com/archives/libvir-l

[libvirt] [PATCH] qemu: Add missing VIR_DOMAIN_BLOCK_COMMIT_DELETE flags

The flag "VIR_DOMAIN_BLOCK_COMMIT_DELETE" is missed by qemuDomainBlockCommit(), and then will hit error "unsupported flags (0x2) in function qemuDomainBlockCommit" if users run 'virsh blockcommit' with '--delete' option. RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1001475 Signed-off-by: Ale

[libvirt] memory pinning problem

Hi, we try to use vcpu pinning on a 2 socket server with Intel Xeon E5620 cpus, HT enabled and 2*6*16GiB Ram but experience problems if we try to start a guest on the second socket: error: Failed to start domain test error: internal error: process exited while connecting to monitor: kvm_init_vc

  1   2   >