The @profile_name variable can be used uninitialized.
Signed-off-by: Michal Privoznik
---
Pushing under trivial and build breaker rules.
src/security/security_apparmor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/security/security_apparmor.c b/src/security/security
The @qemunbd variable can be used uninitialized.
Signed-off-by: Michal Privoznik
---
Pushing under trivial and build breaker rules.
src/util/virfile.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/virfile.c b/src/util/virfile.c
index 2b07ac9..7af0843 100644
--- a
Hi,
In reference to comment28 in below link
https://bugzilla.redhat.com/show_bug.cgi?id=911609#c28
The issue was fixed in libvirt-0.10.2-19.el6 version. I am facing similar
crash and want to check with libvirt-0.10.2-19.el6 version. But i couldnt
find this version from opensource. We could onl
diff --git a/docs/apps.html.in b/docs/apps.html.in
index 46e5dca..9f22df8 100644
--- a/docs/apps.html.in
+++ b/docs/apps.html.in
@@ -244,6 +244,15 @@
integrates libvirt for VM monitoring, live migration, and life-cycle
management.
+
+ http://www.openstack.org";>OpenSt
On 04.09.2013 09:24, arun abhinay wrote:
> Hi,
>
> In reference to comment28 in below link
> https://bugzilla.redhat.com/show_bug.cgi?id=911609#c28
>
> The issue was fixed in libvirt-0.10.2-19.el6 version. I am facing
> similar crash and want to check with libvirt-0.10.2-19.el6 version. But
On 09/03/13 19:14, Eric Blake wrote:
> On 09/03/2013 09:29 AM, Peter Krempa wrote:
>> Commit 50348e6edfa reused the code to remove the hostdev portion of a
>> network definition on multiple places but forgot to take into account
>> that sometimes the "actual" network is passed and in some cases the
On Wed, Sep 04, 2013 at 09:24:43 +0200, arun abhinay wrote:
> Hi,
>
> In reference to comment28 in below link
> https://bugzilla.redhat.com/show_bug.cgi?id=911609#c28
>
> The issue was fixed in libvirt-0.10.2-19.el6 version. I am facing similar
> crash and want to check with libvirt-0.10.2-19.el
On Tue, Sep 03, 2013 at 09:09:54 -0600, Eric Blake wrote:
> On 09/03/2013 07:46 AM, Jiri Denemark wrote:
> > https://bugzilla.redhat.com/show_bug.cgi?id=999352
> >
> > Since commit v1.0.5-56-g449e6b1 (Pull parsing of migration xml up into
> > QEMU driver APIs) any attempt to rename a domain during
Hi Michal,
Thanks for your reply. Is it possible to get the patch between the two
versions.
Thanks in advance.
BR
Abhinay
On Wed, Sep 4, 2013 at 9:34 AM, Michal Privoznik wrote:
> On 04.09.2013 09:24, arun abhinay wrote:
> > Hi,
> >
> > In reference to comment28 in below link
> > https://bugzil
On 04.09.2013 08:37, Jim Fehlig wrote:
> Change libxlGetAutoballoonConf() function to return an int
> for success/failure, and fail if regcomp fails.
>
> Signed-off-by: Jim Fehlig
> ---
> src/libxl/libxl_conf.c | 30 +++---
> 1 file changed, 19 insertions(+), 11 deletions
On 04.09.2013 10:29, Michal Privoznik wrote:
> On 04.09.2013 08:37, Jim Fehlig wrote:
>> Change libxlGetAutoballoonConf() function to return an int
>> for success/failure, and fail if regcomp fails.
>>
>> Signed-off-by: Jim Fehlig
>> ---
>> src/libxl/libxl_conf.c | 30 +++-
On 04.09.2013 04:41, Eric Blake wrote:
> Automake has builtin support to prevent botched conditional nesting,
> but only if you use:
> if FOO
> else !FOO
> endif !FOO
>
> An example error message when using the wrong name:
>
> daemon/Makefile.am:378: error: else reminder
> (LIBVIRT_INIT_SCRIPT_S
Hi Jirka,
Thanks for your detailed information. As part of fixing this issue we have
upgraded to libvirt-1.0.5 version and these crashes were resolved.
But after this upgrade we observed many other issues like "cpu-stats"
command is not working and vcpu pinning was failing with errors. Since we
On Tue, Sep 03, 2013 at 05:07:25PM -0600, Jim Fehlig wrote:
> Daniel P. Berrange wrote:
> > On Fri, Aug 30, 2013 at 03:46:49PM -0600, Jim Fehlig wrote:
> >
> >> Detect early on in libxl driver initialization if the driver
> >> should be loaded at all, avoiding needless initialization steps
> >>
On 04/09/13 04:36, Nehal J Wani wrote:
s/$subject/Fix coding style issues in daemon/remote.c/,
Fix for argument layouts of various functions in daemon/remote.c. Refer:
https://www.redhat.com/archives/libvir-list/2013-September/msg00057.html
No need for the reference, it's obvious.
ACK and pu
On Wed, Sep 04, 2013 at 08:59:42AM +0200, Michal Privoznik wrote:
> The @qemunbd variable can be used uninitialized.
>
> Signed-off-by: Michal Privoznik
> ---
>
> Pushing under trivial and build breaker rules.
FYI this bug is considered a security issue if the polkit ACL driver is
active and th
On 09/03/2013 07:57 PM, Jim Fehlig wrote:
> Jim Fehlig wrote:
<...snip...>
>
> I addressed the review comments from the various patches and pushed the
> series. Thanks for the reviews!
>
> Regards,
> Jim
>
The changes have resulted in one Coverity found issue that seems to
have been there "for
On 09/04/2013 05:06 AM, arun abhinay wrote:
>
> Thanks for your detailed information. As part of fixing this issue we
> have upgraded to libvirt-1.0.5 version and these crashes were
> resolved. But after this upgrade we observed many other issues like
> "cpu-stats" command is not working and vcp
Hi Laine,
Thanks a lot for your inputs. We will try to download the code from
libvirt-0.10.2-main t and build libvirt with the patch for crash issue.
We are using WR kenerl of below version
2.6.34.13-WR4
Thanks
Abhinay
On Wed, Sep 4, 2013 at 1:36 PM, Laine Stump wrote:
> On 09/04/2013 05:06 A
On 28.08.2013 22:56, Eric Blake wrote:
> Failure to attach to a domain during 'virsh qemu-attach' left
> the list of domains in an odd state:
>
> $ virsh qemu-attach 4176
> error: An error occurred, but the cause is unknown
>
> $ virsh list --all
> IdName State
> --
On 28.08.2013 06:00, Eric Blake wrote:
> In Fedora 19, 'qemu-kvm' is a simple wrapper that calls
> 'qemu-system-x86_64 -machine accel=kvm'. Attempting
> to use 'virsh qemu-attach $pid' to a machine started as:
>
> qemu-kvm -cdrom /var/lib/libvirt/images/foo.img \
> -monitor unix:/tmp/demo,server
On 29.08.2013 00:38, Eric Blake wrote:
> While debugging a failure of 'virsh qemu-attach', I noticed that
> we were leaking the count of active domains on failure. This
> means that a libvirtd session that is supposed to quit after
> active domains disappear will hang around forever.
>
> * src/qe
On 28.08.2013 23:01, Eric Blake wrote:
> No need to open code now that we have a nice function.
>
> Interestingly, our virStringFreeList function is typed correctly
> (a malloc'd list of malloc'd strings is NOT const, whether at the
> point where it is created, or at the point where it is cleand u
On 28.08.2013 06:00, Eric Blake wrote:
> 'virsh domxml-from-native' and 'virsh qemu-attach' could misbehave
> for an emulator installed in (a somewhat unlikely) location
> such as /usr/local/qemu-1.6/qemu-system-x86_64 or (an even less
> likely) /opt/notxen/qemu-system-x86_64. Limit the strstr sea
On 04.09.2013 00:48, Eric Blake wrote:
> An rpm build with client_only set to 1 (for example, RHEL 5 on
> s390, or by modifying libvirt.spec.in) failed with
>
> TEST: fdstreamtest
> 1) Stream read blocking ... OK
> 2) Stream read non-blocking
On 03.09.2013 23:27, Eric Blake wrote:
> 'make rpm' failed if ~/.rpmmacros contains '%_without_lxc 1',
> which simulates the case of not having lxc available.
>
> RPM build errors:
> File not found:
> /home/eblake/rpmbuild/BUILDROOT/libvirt-1.1.1-1.fc19.x86_64/etc/libvirt/virt-login-shell.con
On 09/04/2013 05:59 AM, arun abhinay wrote:
> Hi Laine,
[Please don't top-post on technical lists]
>
> Thanks a lot for your inputs. We will try to download the code from
> libvirt-0.10.2-main t and build libvirt with the patch for crash issue.
>
> We are using WR kenerl of below version
> 2.6.
On 09/04/2013 01:26 AM, Martin Kletzander wrote:
> diff --git a/docs/apps.html.in b/docs/apps.html.in
> index 46e5dca..9f22df8 100644
> --- a/docs/apps.html.in
> +++ b/docs/apps.html.in
> @@ -244,6 +244,15 @@
> integrates libvirt for VM monitoring, live migration, and life-cycle
>
On 04.09.2013 04:56, Eric Blake wrote:
> Commit ba5f3c7 moved virtualBox support into libvirtd, but the spec
> file was still unconditionally requesting it even when not building
> the server side. This leads to the weird result of building
> libvirt-client and libvirt-daemon-lxc rpms when client_
On 04.09.2013 05:07, Eric Blake wrote:
> Untested for now (it's late for me), but seems right...
>
> daemon/Makefile.am installs a .policy file if WITH_POLKIT is set
> (which is supposedly the union between WITH_POLKIT0 and WITH_POLKIT1).
> src/Makefile.am, on the other hand, installs a .policy fi
On 04.09.2013 04:52, Eric Blake wrote:
> 'make rpm' with client_local set to 1 (by manual modification,
> or with RHEL 5 on s390) warns:
>
> RPM build errors:
> Installed (but unpackaged) file(s) found:
>/etc/libvirt/nwfilter/allow-arp.xml
>/etc/libvirt/nwfilter/allow-dhcp-server.xml
>
On 04/09/13 03:07, Eric Blake wrote:
On 09/01/2013 07:43 AM, Nehal J Wani wrote:
Define a new API virDomainInterfaceAddresses, which returns
the address information of a running domain's interfaces(s).
If no interface name is specified, it returns the information
of all interfaces, otherwise it
Helps save space on the Fedora livecd, as requested here:
https://bugzilla.redhat.com/show_bug.cgi?id=977099
---
libvirt.spec.in | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index e94901a..a327eab 100644
--- a/libvirt.spec.in
+++ b/libvir
On 04/09/13 20:50, Eric Blake wrote:
On 09/04/2013 01:26 AM, Martin Kletzander wrote:
diff --git a/docs/apps.html.in b/docs/apps.html.in
index 46e5dca..9f22df8 100644
--- a/docs/apps.html.in
+++ b/docs/apps.html.in
@@ -244,6 +244,15 @@
integrates libvirt for VM monitoring, live migrati
- Forwarded message from Sebastian Ottlik -
>
> This patchset disabels all use of SO_REUSEADDR on Windows. On Windows systems
> the default behavior is equivalent to SO_REUSEADDR on other operating
> systems. SO_REUSEADDR can still be set but results in undesired bahvior
> instead. It may
On 09/04/2013 08:53 AM, Daniel P. Berrange wrote:
> On Wed, Sep 04, 2013 at 10:24:06AM -0400, Cole Robinson wrote:
>> Helps save space on the Fedora livecd, as requested here:
>>
>> https://bugzilla.redhat.com/show_bug.cgi?id=977099
>> ---
>> libvirt.spec.in | 3 +--
>> 1 file changed, 1 insertion
On 09/03/2013 11:29 AM, Peter Krempa wrote:
> Commit 50348e6edfa reused the code to remove the hostdev portion of a
> network definition on multiple places but forgot to take into account
> that sometimes the "actual" network is passed and in some cases the
> parent of that.
>
> This patch uses th
On 09/04/2013 09:11 AM, Daniel P. Berrange wrote:
>> client: COPYING COPYING.LESSER
>> daemon: none
>> other[*]: AUTHORS ChangeLog.gz NEWS README TODO
>>
>> where I have yet another question: should the other package be
>> libvirt-docs or libvirt-devel? Your patch put them in devel, but I
>> thin
On 04/09/13 03:13, Eric Blake wrote:
On 09/03/2013 01:07 PM, Eric Blake wrote:
On 09/01/2013 07:43 AM, Nehal J Wani wrote:
Define a new API virDomainInterfaceAddresses, which returns
the address information of a running domain's interfaces(s).
If no interface name is specified, it returns the i
On Wed, Sep 04, 2013 at 10:24:06AM -0400, Cole Robinson wrote:
> Helps save space on the Fedora livecd, as requested here:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=977099
> ---
> libvirt.spec.in | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/libvirt.spec.in b/l
On 09/04/13 17:17, Cole Robinson wrote:
> On 09/03/2013 11:29 AM, Peter Krempa wrote:
>> Commit 50348e6edfa reused the code to remove the hostdev portion of a
>> network definition on multiple places but forgot to take into account
>> that sometimes the "actual" network is passed and in some cases
On Wed, Sep 04, 2013 at 09:02:58AM -0600, Eric Blake wrote:
> On 09/04/2013 08:53 AM, Daniel P. Berrange wrote:
> > On Wed, Sep 04, 2013 at 10:24:06AM -0400, Cole Robinson wrote:
> >> Helps save space on the Fedora livecd, as requested here:
> >>
> >> https://bugzilla.redhat.com/show_bug.cgi?id=977
In commit 991270db99690 I've used virDomainNetGetActualHostdev() to get
the actual hostdev from a network when removing the network from the
list to avoid leaving the hostdev in the list. I didn't notice that this
function doesn't check if the actual network is allocated and
dereferences it. This c
On Wed, Aug 28, 2013 at 03:01:23PM -0600, Eric Blake wrote:
> No need to open code now that we have a nice function.
>
> Interestingly, our virStringFreeList function is typed correctly
> (a malloc'd list of malloc'd strings is NOT const, whether at the
> point where it is created, or at the point
On 09/04/2013 08:24 AM, Cole Robinson wrote:
> Helps save space on the Fedora livecd, as requested here:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=977099
> ---
> libvirt.spec.in | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
ACK - makes more sense to have the files in only on
On 09/04/2013 02:41 AM, Michal Privoznik wrote:
> On 04.09.2013 04:41, Eric Blake wrote:
>> Automake has builtin support to prevent botched conditional nesting,
>> but only if you use:
>> if FOO
>> else !FOO
>> endif !FOO
>>
>> An example error message when using the wrong name:
>>
>> daemon/Makefi
On 09/04/2013 09:37 AM, Peter Krempa wrote:
> In commit 991270db99690 I've used virDomainNetGetActualHostdev() to get
> the actual hostdev from a network when removing the network from the
> list to avoid leaving the hostdev in the list. I didn't notice that this
> function doesn't check if the act
From: "Daniel P. Berrange"
The s390, ppc and arm CPU drivers never set the 'arch' field
in their impl of cpuArchNodeData. This leads to error messages
being reported from cpuDataFree later, due to trying to use
VIR_ARCH_NONE.
#0 virRaiseErrorFull (filename=filename@entry=0x76f94434 "cpu/cpu.c"
When virGetUserEnt() and virGetGroupEnt() fail due to the uid or gid not
existing on the machine they'll print a message like:
$ virsh -c vbox:///session list
error: failed to connect to the hypervisor
error: Failed to find user record for uid '32655': Success
The success at the end is a bit conf
Michal Privoznik wrote:
> On 04.09.2013 10:29, Michal Privoznik wrote:
>
>> On 04.09.2013 08:37, Jim Fehlig wrote:
>>
>>> Change libxlGetAutoballoonConf() function to return an int
>>> for success/failure, and fail if regcomp fails.
>>>
>>> Signed-off-by: Jim Fehlig
>>> ---
>>> src/libxl/
On 09/04/2013 10:48 AM, Doug Goldstein wrote:
> When virGetUserEnt() and virGetGroupEnt() fail due to the uid or gid not
> existing on the machine they'll print a message like:
>
> $ virsh -c vbox:///session list
> error: failed to connect to the hypervisor
> error: Failed to find user record for
On 09/04/2013 10:44 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> The s390, ppc and arm CPU drivers never set the 'arch' field
> in their impl of cpuArchNodeData. This leads to error messages
> being reported from cpuDataFree later, due to trying to use
> VIR_ARCH_NONE.
>
> ++
On 09/04/2013 06:38 AM, Michal Privoznik wrote:
> On 03.09.2013 23:27, Eric Blake wrote:
>> 'make rpm' failed if ~/.rpmmacros contains '%_without_lxc 1',
>> which simulates the case of not having lxc available.
>>
>> RPM build errors:
>> File not found:
>> /home/eblake/rpmbuild/BUILDROOT/libvi
I'm tired of seeing screenfuls of messages like these when using
automake 1.13 (Fedora 19):
configure.ac:2121: warning: The 'AM_PROG_MKDIR_P' macro is deprecated, and its
use is discouraged.
configure.ac:2121: You should use the Autoconf-provided 'AC_PROG_MKDIR_P' macro
instead,
configure.ac:212
Hi,
I am using libvirt on ESX hypervisor. Iam trying to create "vmknic" using
virsh but all my attempts are failing. Can anyone help me in achieving this?
Where can I find the xml template for this? or is there any wiki link which
I can follow to achieve this?
Regards,
Varun
--
libvir-list mailin
On 09/04/2013 06:38 AM, Michal Privoznik wrote:
> On 04.09.2013 00:48, Eric Blake wrote:
>> An rpm build with client_only set to 1 (for example, RHEL 5 on
>> s390, or by modifying libvirt.spec.in) failed with
>>
>> * tests/Makefile.am (test_programs): Make fdstreamtest conditional.
>>
>> Signed-of
On 09/04/2013 07:22 AM, Michal Privoznik wrote:
> On 04.09.2013 04:52, Eric Blake wrote:
>> 'make rpm' with client_local set to 1 (by manual modification,
>> or with RHEL 5 on s390) warns:
>>
>>
>> The bulk of these are fixed with this patch.
>>
>> * examples/xml/nwfilter/Makefile.am (install-data
On 09/04/2013 02:03 PM, Jim Fehlig wrote:
>>
>> Yeah, good question. I found a few occurrences of regcomp() and friends
>> throughout the sources and most seem to do regfree() even when regcomp()
>> fails. The man page is not very clear, but the notes on regfree()
>> suggest it is not necessary
>
John Ferlan wrote:
> On 09/03/2013 07:57 PM, Jim Fehlig wrote:
>
>> Jim Fehlig wrote:
>>
> <...snip...>
>
>> I addressed the review comments from the various patches and pushed the
>> series. Thanks for the reviews!
>>
>> Regards,
>> Jim
>>
>>
>
> The changes have resulted in one C
Commits 9298bfb and f6c2951 both tried to make it possible to
select the correct libnl (1 vs. 3) according to what netcf
used, when both libraries are installed. This works to avoid
libnl-3 when netcf used libnl-1. But on the converse side, if
only libnl-1 development code is installed, while net
On 09/04/2013 03:09 PM, Jim Fehlig wrote:
>> >
> Thanks for pointing that out. What do you think of the attached patch?
>
> Regards,
> Jim
>
>
> libxl-coverity-fix.patch
>
>
>>From fe87e804478689b7cdf0ab417b459cb0d2f6118e Mon Sep 17 00:00:00 2001
> From: Jim Fehlig
> Date: Wed, 4 Sep 201
Eric Blake wrote:
> On 09/04/2013 03:09 PM, Jim Fehlig wrote:
>
>
>> Thanks for pointing that out. What do you think of the attached patch?
>>
>> Regards,
>> Jim
>>
>>
>> libxl-coverity-fix.patch
>>
>>
>> >From fe87e804478689b7cdf0ab417b459cb0d2f6118e Mon Sep 17 00:00:00 2
On 08/29/2013 10:36 AM, Peter Krempa wrote:
> Move the function to virsh.c to the rest of the TTY managing functions
> and change the code so that it mirrors the rest.
> ---
> tools/virsh-console.c | 50 +-
> tools/virsh-console.h | 7 +++
> too
On 09/04/2013 07:22 AM, Michal Privoznik wrote:
> On 04.09.2013 05:07, Eric Blake wrote:
>> Untested for now (it's late for me), but seems right...
>>
>> daemon/Makefile.am installs a .policy file if WITH_POLKIT is set
>> (which is supposedly the union between WITH_POLKIT0 and WITH_POLKIT1).
>> src
Jim Fehlig wrote:
> Michal Privoznik wrote:
>
>> On 04.09.2013 10:29, Michal Privoznik wrote:
>>
>>
>>> On 04.09.2013 08:37, Jim Fehlig wrote:
>>>
>>>
Change libxlGetAutoballoonConf() function to return an int
for success/failure, and fail if regcomp fails.
>>>
Several recent patches cleaned up 'make rpm' for the situation
when client_only is true; these were done by manual spec file
editing (since it's relatively hard to come by a RHEL 5 s390
box). Make it easier to do in the future via a simpler command
line override.
* libvirt.spec.in (client_only):
On 09/04/2013 07:22 AM, Michal Privoznik wrote:
> On 04.09.2013 04:56, Eric Blake wrote:
>> Commit ba5f3c7 moved virtualBox support into libvirtd, but the spec
>> file was still unconditionally requesting it even when not building
>> the server side. This leads to the weird result of building
>> l
During a recent discussion about calling regfree() when regcomp() fails,
we decided it was best to not call regfree() when compilation fails.
https://www.redhat.com/archives/libvir-list/2013-September/msg00262.html
The first patch fixes existing infractions throughout the code. I split
the secon
The regular expression used to determine guest capabilities
was compiled in libxlCapsInitHost() but used in libxlCapsInitGuests().
Move compilation to libxlCapsInitGuests() where it is used, and free
the compiled regex after use. Ensure not to free the regex if
compilation fails.
Signed-off-by: J
POSIX states that the preg parameter to regcomp() is undefined on
failure, so no need to call regfree() in these cases.
http://pubs.opengroup.org/onlinepubs/009695399/functions/regcomp.html
Signed-off-by: Jim Fehlig
---
src/storage/storage_backend.c | 2 +-
src/storage/storage_backend_l
Jim Fehlig wrote:
> The regular expression used to determine guest capabilities
> was compiled in libxlCapsInitHost() but used in libxlCapsInitGuests().
> Move compilation to libxlCapsInitGuests() where it is used, and free
> the compiled regex after use. Ensure not to free the regex if
> compilat
Eric Blake wrote:
> On 09/04/2013 02:03 PM, Jim Fehlig wrote:
>
>>> Yeah, good question. I found a few occurrences of regcomp() and friends
>>> throughout the sources and most seem to do regfree() even when regcomp()
>>> fails. The man page is not very clear, but the notes on regfree()
>>> sug
Recent patches to fix handling of Ctrl-C when interacting with
ssh are not portable to mingw, which lacks termios handling.
The simplest solution is to just compile that code out, and
if someone ever appears that has a serious interest in getting
virsh fully functional even with ssh connections, th
No need to check if priviledged when reading hostsysinfo, since
that check was already done in libxlDriverShouldLoad(). The
libxl driver fails to load if not priviledged.
Signed-off-by: Jim Fehlig
---
src/libxl/libxl_driver.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a
On 09/04/2013 05:07 PM, Jim Fehlig wrote:
> No need to check if priviledged when reading hostsysinfo, since
> that check was already done in libxlDriverShouldLoad(). The
> libxl driver fails to load if not priviledged.
s/priviledged/privileged/ (twice)
>
> Signed-off-by: Jim Fehlig
> ---
> sr
When using "virsh attach-device" to attach a device, the
virDomainDefCompatibleDevice function will check the compatibility.
If the device is a USB device, but the VM don't have any USB controller, the
execution of "virsh attach-device" will fails.
It considers the USB controller as a USB device
On Wed 04 Sep 2013 06:48:46 PM CEST, Eric Blake wrote:
> I'm tired of seeing screenfuls of messages like these when using
> automake 1.13 (Fedora 19):
>
> configure.ac:2121: warning: The 'AM_PROG_MKDIR_P' macro is deprecated, and
> its use is discouraged.
> configure.ac:2121: You should use the Au
On 09/04/2013 03:56 PM, Osier Yang wrote:
> On 04/09/13 20:50, Eric Blake wrote:
>> On 09/04/2013 01:26 AM, Martin Kletzander wrote:
>>> diff --git a/docs/apps.html.in b/docs/apps.html.in
>>> index 46e5dca..9f22df8 100644
>>> --- a/docs/apps.html.in
>>> +++ b/docs/apps.html.in
>>> @@ -244,6 +244,15
Eric Blake wrote:
> On 09/04/2013 05:07 PM, Jim Fehlig wrote:
>
>> No need to check if priviledged when reading hostsysinfo, since
>> that check was already done in libxlDriverShouldLoad(). The
>> libxl driver fails to load if not priviledged.
>>
>
> s/priviledged/privileged/ (twice)
>
>
79 matches
Mail list logo
