[libvirt] [bug] State of in shutdown.

2013-09-17 Thread Dongsheng Yang
Hi experts: I got the following description by man virsh: ``` STATES shutdown The domain is in the process of shutting down, i.e. the guest operating system has been notified and should be in the process of stopping its operations gracefully. ```

[libvirt] [PATCH] tools: Fix a wrong check in cmdEcho()

2013-09-17 Thread Hongwei Bi
What should be checked here is xmlbuf rather then buf. --- tools/virsh.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index bf2fbf8..ac354ac 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -921,7 +921,7 @@ cmdEcho(vshControl *ctl, const

Re: [libvirt] [bug] State of in shutdown.

2013-09-17 Thread Dongsheng Yang
Well, I write a script to catch the state of VM from running to shut off. Ok, there is a short time before shutoff, VM is in shutdown. So, please ignore my report. :) On 09/17/2013 02:02 PM, Dongsheng Yang wrote: Hi experts: I got the following description by man virsh: ``` STATES

Re: [libvirt] Can I request a new release of libvirt-java?

2013-09-17 Thread Wido den Hollander
On 09/16/2013 07:58 AM, Daniel Veillard wrote: Raising this due to maven On Fri, Sep 13, 2013 at 05:26:24PM +0800, Daniel Veillard wrote: On Fri, Sep 13, 2013 at 11:13:53AM +0200, Wido den Hollander wrote: [...] Indeed that was the problem, I just commited the fix, thanks !

Re: [libvirt] [PATCH] tools: Fix a wrong check in cmdEcho()

2013-09-17 Thread Ján Tomko
On 09/17/2013 08:21 AM, Hongwei Bi wrote: What should be checked here is xmlbuf rather then buf. --- tools/virsh.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) ACK I've changed 'tools' to 'virsh' in the title and pushed it. Jan -- libvir-list mailing list

Re: [libvirt] Release of libvirt-java-0.5.0

2013-09-17 Thread Claudio Bley
Hi. At Tue, 17 Sep 2013 10:18:52 +0800, Daniel Veillard wrote: Any ideas with this build issue for FreeBSD update of libvirt-java? I do have jna (jna-3.2.7_1) installed. Your JNA version is too old. Before version 3.3.0 JNA lacked a function to free malloc'd memory. build:

Re: [libvirt] Can I request a new release of libvirt-java?

2013-09-17 Thread Daniel Veillard
On Tue, Sep 17, 2013 at 09:04:46AM +0200, Wido den Hollander wrote: On 09/16/2013 07:58 AM, Daniel Veillard wrote: Raising this due to maven On Fri, Sep 13, 2013 at 05:26:24PM +0800, Daniel Veillard wrote: On Fri, Sep 13, 2013 at 11:13:53AM +0200, Wido den Hollander wrote: [...]

Re: [libvirt] Release of libvirt-java-0.5.0

2013-09-17 Thread Daniel Veillard
On Tue, Sep 17, 2013 at 09:18:02AM +0200, Claudio Bley wrote: Hi. At Tue, 17 Sep 2013 10:18:52 +0800, Daniel Veillard wrote: Any ideas with this build issue for FreeBSD update of libvirt-java? I do have jna (jna-3.2.7_1) installed. Your JNA version is too old. Before version 3.3.0

Re: [libvirt] Release of libvirt-java-0.5.0

2013-09-17 Thread Jason Helfman
On Tue, Sep 17, 2013 at 12:24 AM, Daniel Veillard veill...@redhat.comwrote: On Tue, Sep 17, 2013 at 09:18:02AM +0200, Claudio Bley wrote: Hi. At Tue, 17 Sep 2013 10:18:52 +0800, Daniel Veillard wrote: Any ideas with this build issue for FreeBSD update of libvirt-java? I do

Re: [libvirt] [PATCH] tools: Fix a wrong check in cmdEcho()

2013-09-17 Thread hw bi
Ok. Thanks. 2013/9/17 Ján Tomko jto...@redhat.com On 09/17/2013 08:21 AM, Hongwei Bi wrote: What should be checked here is xmlbuf rather then buf. --- tools/virsh.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) ACK I've changed 'tools' to 'virsh' in the title and

Re: [libvirt] Release of libvirt-java-0.5.0

2013-09-17 Thread Daniel Veillard
On Tue, Sep 17, 2013 at 12:28:13AM -0700, Jason Helfman wrote: On Tue, Sep 17, 2013 at 12:24 AM, Daniel Veillard veill...@redhat.comwrote: On Tue, Sep 17, 2013 at 09:18:02AM +0200, Claudio Bley wrote: Hi. At Tue, 17 Sep 2013 10:18:52 +0800, Daniel Veillard wrote: Any

Re: [libvirt] [PATCH 1/2] qemu: Fix checking of ABI stability when restoring external checkpoints

2013-09-17 Thread Peter Krempa
On 09/16/13 18:57, Eric Blake wrote: On 09/16/2013 06:36 AM, Peter Krempa wrote: External checkpoints have a bug in the implementation where they use the normal definition instead of the migratable one. This causes errors when the snapshot is being reverted using the workaround method via

[libvirt] [RFC] Add iommu group commands

2013-09-17 Thread Li Zhang
Hi, Currently, we need to assign the iommu group to guests manually. It needs to know the groups information. I think we can add some iommu group commands to provide users groups information. I can think of these commands as the following: #virsh group-list --active * list all the groups in

Re: [libvirt] [PATCH 2/2] qemu: Use migratable XML definition when doing external checkpoints

2013-09-17 Thread Peter Krempa
On 09/16/13 18:58, Eric Blake wrote: On 09/16/2013 06:36 AM, Peter Krempa wrote: In the original implementation of external checkpoints I've mistakenly used the live definition to be stored in the save image. The normal approach is to use the migratable definition. This was discovered when

Re: [libvirt] [PATCH 06/14] util: Add helper to convert libxml2 nodes to a string

2013-09-17 Thread Peter Krempa
On 09/16/13 23:42, Eric Blake wrote: On 09/10/2013 04:15 AM, Peter Krempa wrote: --- src/libvirt_private.syms | 1 + src/util/virxml.c| 33 + src/util/virxml.h| 2 ++ 3 files changed, 36 insertions(+) diff --git a/src/libvirt_private.syms

Re: [libvirt] [PATCH v2 0/6]qemu: add usb-bot scsi controller support

2013-09-17 Thread Guannan Ren
On 09/10/2013 05:26 PM, Guannan Ren wrote: BZ:https://bugzilla.redhat.com/show_bug.cgi?id=917702 v2: After discussion in BZ, qemu guys hope the usb-bot(+usb-uas) can be supported although the absence of its hot-plug feature. In this patch, libvirt gives an unsupported error in this

Re: [libvirt] [PATCH 14/14] tests: Add metadata tests

2013-09-17 Thread Peter Krempa
On 09/17/13 05:01, Eric Blake wrote: On 09/10/2013 04:15 AM, Peter Krempa wrote: This test excercises the virDomain[Get|Set]Metadata API and tests it for s/excercises/exercises/ regressions --- tests/Makefile.am| 7 ++ tests/metadatatest.c | 245

[libvirt] [PATCH libvirt-java] Set source and target version to Java 1.6

2013-09-17 Thread Wido den Hollander
On platforms with Java 1.7 it will still produce compatible code with Java 1.6 platforms Java 1.6 is still out there and widely used. Signed-off-by: Wido den Hollander w...@widodh.nl --- build.properties |2 ++ build.xml|4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-)

Re: [libvirt] Can I request a new release of libvirt-java?

2013-09-17 Thread Wido den Hollander
On 09/17/2013 09:23 AM, Daniel Veillard wrote: On Tue, Sep 17, 2013 at 09:04:46AM +0200, Wido den Hollander wrote: On 09/16/2013 07:58 AM, Daniel Veillard wrote: Raising this due to maven On Fri, Sep 13, 2013 at 05:26:24PM +0800, Daniel Veillard wrote: On Fri, Sep 13, 2013 at 11:13:53AM

Re: [libvirt] [PATCH libvirt-java] Set source and target version to Java 1.6

2013-09-17 Thread Daniel Veillard
On Tue, Sep 17, 2013 at 10:04:59AM +0200, Wido den Hollander wrote: On platforms with Java 1.7 it will still produce compatible code with Java 1.6 platforms Java 1.6 is still out there and widely used. ACK, please push, Daniel Signed-off-by: Wido den Hollander w...@widodh.nl ---

Re: [libvirt] [PATCH 1/2] qemu: Fix checking of ABI stability when restoring external checkpoints

2013-09-17 Thread Ján Tomko
On 09/16/2013 02:36 PM, Peter Krempa wrote: External checkpoints have a bug in the implementation where they use the normal definition instead of the migratable one. This causes errors when the snapshot is being reverted using the workaround method via qemuDomainRestoreFlags() with a custom

[libvirt] [PATCH] qemu: Fix memleak after commit 59898a88ce8431bd3ea249b8789edc2ef9985827

2013-09-17 Thread Peter Krempa
If the ABI compatibility check with the migratable user XML is successful, we would leak the originaly parsed XML from the user that would not be used in this case. Reported by Ján Tomko. --- src/qemu/qemu_driver.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/qemu/qemu_driver.c

Re: [libvirt] Can I request a new release of libvirt-java?

2013-09-17 Thread Daniel Veillard
On Tue, Sep 17, 2013 at 10:09:36AM +0200, Wido den Hollander wrote: On 09/17/2013 09:23 AM, Daniel Veillard wrote: On Tue, Sep 17, 2013 at 09:04:46AM +0200, Wido den Hollander wrote: On 09/16/2013 07:58 AM, Daniel Veillard wrote: Raising this due to maven On Fri, Sep 13, 2013 at

Re: [libvirt] openvswitch vlan support when not a forwarded network

2013-09-17 Thread Laine Stump
On 09/16/2013 07:34 PM, Ajith Antony wrote: Thank you Laine, for your prompt reply. Adding the dev list to broaden the audience. On Mon, Sep 16, 2013 at 9:21 AM, Laine Stump la...@laine.org wrote: On 09/16/2013 07:32 AM, Ajith Antony wrote: Hi, I'm not sure what the best way to pursue this

[libvirt] [PATCH] conf: Don't corrupt metadata on OOM

2013-09-17 Thread Peter Krempa
Eric Blake suggested that we could do a little better in case copying of the metadata to be set fails. With this patch, the old metadata is discarded after the new string is copied successfuly. --- src/conf/domain_conf.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff

[libvirt] [PATCH] virsh-domain: Remove unnecessary check and tune code in cmdDesc()

2013-09-17 Thread Hongwei Bi
Since there is a check on buf through virBufferError(), it is not necessary to check desc again. --- tools/virsh-domain.c | 62 + 1 files changed, 27 insertions(+), 35 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index

Re: [libvirt] [PATCH] qemu: Fix memleak after commit 59898a88ce8431bd3ea249b8789edc2ef9985827

2013-09-17 Thread Ján Tomko
On 09/17/2013 11:12 AM, Peter Krempa wrote: If the ABI compatibility check with the migratable user XML is successful, we would leak the originaly parsed XML from the user that *originally would not be used in this case. Reported by Ján Tomko. --- src/qemu/qemu_driver.c | 2 ++ 1 file

Re: [libvirt] [PATCH] conf: Don't corrupt metadata on OOM

2013-09-17 Thread Ján Tomko
On 09/17/2013 11:19 AM, Peter Krempa wrote: Eric Blake suggested that we could do a little better in case copying of the metadata to be set fails. With this patch, the old metadata is discarded after the new string is copied successfuly. --- src/conf/domain_conf.c | 13 + 1 file

Re: [libvirt] Can I request a new release of libvirt-java?

2013-09-17 Thread Wido den Hollander
On 09/17/2013 11:13 AM, Daniel Veillard wrote: On Tue, Sep 17, 2013 at 10:09:36AM +0200, Wido den Hollander wrote: On 09/17/2013 09:23 AM, Daniel Veillard wrote: On Tue, Sep 17, 2013 at 09:04:46AM +0200, Wido den Hollander wrote: On 09/16/2013 07:58 AM, Daniel Veillard wrote: Raising this

Re: [libvirt] [PATCH] qemu: Fix memleak after commit 59898a88ce8431bd3ea249b8789edc2ef9985827

2013-09-17 Thread Peter Krempa
On 09/17/13 11:50, Ján Tomko wrote: On 09/17/2013 11:12 AM, Peter Krempa wrote: If the ABI compatibility check with the migratable user XML is successful, we would leak the originaly parsed XML from the user that *originally would not be used in this case. Reported by Ján Tomko. ---

Re: [libvirt] [PATCH] conf: Don't corrupt metadata on OOM

2013-09-17 Thread Peter Krempa
On 09/17/13 11:56, Ján Tomko wrote: On 09/17/2013 11:19 AM, Peter Krempa wrote: Eric Blake suggested that we could do a little better in case copying of the metadata to be set fails. With this patch, the old metadata is discarded after the new string is copied successfuly. ---

Re: [libvirt] [PATCH] virsh-domain: Remove unnecessary check and tune code in cmdDesc()

2013-09-17 Thread Ján Tomko
On 09/17/2013 11:16 AM, Hongwei Bi wrote: Since there is a check on buf through virBufferError(), it is not necessary to check desc again. The buffer is used for the description provided on the virsh command line: $ virsh desc domain Description If you don't provide the description: $ virsh

[libvirt] want help about python APIs doc

2013-09-17 Thread Tony Gong
hi friends, I need some help for finding python APIs of libvirt. I have already find the Java APIs doc at here:http://libvirt.org/sources/java/javadoc/, is there any doc just like this to make me to find APIs more easy. many thanks!! tony gong-- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH libvirt-java] Set source and target version to Java 1.6

2013-09-17 Thread Claudio Bley
At Tue, 17 Sep 2013 10:04:59 +0200, Wido den Hollander wrote: On platforms with Java 1.7 it will still produce compatible code with Java 1.6 platforms Java 1.6 is still out there and widely used. AFAIK, the code is 1.5 compliant which would be least common denominator. So, there's no need

[libvirt] make check error

2013-09-17 Thread hzguanqi...@corp.netease.com
Hi guys, I made a automated test for the libvirt code in git source repository right now, It reported a check error. The operation steps and error info are as following: ubuntu@ubuntu:~/github/libvirt.git$ ./autogen.sh ubuntu@ubuntu:~/github/libvirt.git$ ./configure --enable-werror

Re: [libvirt] make check error

2013-09-17 Thread Peter Krempa
On 09/17/13 13:31, hzguanqi...@corp.netease.com wrote: Hi guys, I made a automated test for the libvirt code in git source repository right now, It reported a check error. The operation steps and error info are as following: ubuntu@ubuntu:~/github/libvirt.git$ ./autogen.sh

Re: [libvirt] [PATCH libvirt-java] Set source and target version to Java 1.6

2013-09-17 Thread Wido den Hollander
On 09/17/2013 01:14 PM, Claudio Bley wrote: At Tue, 17 Sep 2013 10:04:59 +0200, Wido den Hollander wrote: On platforms with Java 1.7 it will still produce compatible code with Java 1.6 platforms Java 1.6 is still out there and widely used. AFAIK, the code is 1.5 compliant which would be

[libvirt] [PATCH] build: fix VPATH build of remote driver

2013-09-17 Thread Eric Blake
Commit 073e1575 tried to set things up so that 1) generated files to be shipped in the tarball always live in srcdir, and 2) we have no files in SOURCES that depend on any other files with a literal $(srcdir) in the name, because that situation can cause confusing results for the make expansion of

[libvirt] [PATCH 1/2] conf: Avoid false positive of uninitialized variable use

2013-09-17 Thread Peter Krempa
GCC 4.8.0+ whines about variable new being uninitialized since commit 73bfac0e7182a3abd. This is a false positive as the xmlFreeNode(new) statement can be only reached if new was actually allocated successfully. CC conf/libvirt_conf_la-domain_conf.lo conf/domain_conf.c: In function

[libvirt] [PATCH 2/2] virsh: Don't shadow global variable remove in cmdMetadata

2013-09-17 Thread Peter Krempa
Some systems apparently have a global variable/function called remove and thus break compilation of virsh-domain.c. Rename the variable to avoid this. Reported by GuanQiang. --- tools/virsh-domain.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/virsh-domain.c

[libvirt] [PATCH 0/2] Build fixes after metadata series

2013-09-17 Thread Peter Krempa
Some people reported a few issues on different systems/compilers. Series pushed under the build-breaker rule. Peter Krempa (2): conf: Avoid false positive of uninitialized variable use virsh: Don't shadow global variable remove in cmdMetadata src/conf/domain_conf.c | 9 +++--

Re: [libvirt] make check error

2013-09-17 Thread Eric Blake
On 09/17/2013 05:43 AM, Peter Krempa wrote: On 09/17/13 13:31, hzguanqi...@corp.netease.com wrote: Hi guys, I made a automated test for the libvirt code in git source repository right now, It reported a check error. The operation steps and error info are as following: CC

Re: [libvirt] make check error

2013-09-17 Thread Peter Krempa
On 09/17/13 13:43, Peter Krempa wrote: On 09/17/13 13:31, hzguanqi...@corp.netease.com wrote: Hi guys, I made a automated test for the libvirt code in git source repository right now, It reported a check error. The operation steps and error info are as following:

Re: [libvirt] make check error

2013-09-17 Thread hzguanqi...@corp.netease.com
HI Peter, It's ok now. Thanks. On 2013-09-17 20:03 , Peter Krempa wrote: On 09/17/13 13:43, Peter Krempa wrote: On 09/17/13 13:31, hzguanqi...@corp.netease.com wrote: Hi guys, I made a automated test for the libvirt code in git source repository right now, It reported a check error. The

Re: [libvirt] [PATCH 14/14] tests: Add metadata tests

2013-09-17 Thread Eric Blake
On 09/10/2013 04:15 AM, Peter Krempa wrote: This test excercises the virDomain[Get|Set]Metadata API and tests it for regressions --- tests/Makefile.am| 7 ++ tests/metadatatest.c | 245 +++ 2 files changed, 252 insertions(+) create

Re: [libvirt] [PATCH libvirt-java] Set source and target version to Java 1.6

2013-09-17 Thread Claudio Bley
At Tue, 17 Sep 2013 13:48:11 +0200, Wido den Hollander wrote: On 09/17/2013 01:14 PM, Claudio Bley wrote: At Tue, 17 Sep 2013 10:04:59 +0200, Wido den Hollander wrote: On platforms with Java 1.7 it will still produce compatible code with Java 1.6 platforms Java 1.6 is still out

Re: [libvirt] [RFC] Add iommu group commands

2013-09-17 Thread Daniel P. Berrange
On Tue, Sep 17, 2013 at 03:56:46PM +0800, Li Zhang wrote: Hi, Currently, we need to assign the iommu group to guests manually. It needs to know the groups information. I think we can add some iommu group commands to provide users groups information. I can think of these commands as the

[libvirt] [PATCH 1/2] test: Refactor setting of dummy error handlers

2013-09-17 Thread Peter Krempa
Multiple tests need to register a function to quiesce errors from libvirt when using a connection and doing negative tests. Each of those tests had a static function to do so. This can be replaced by a utility function that enables the errors when debug is enabledd. This patch adds

[libvirt] [PATCH 0/2] Shut metadatatest up

2013-09-17 Thread Peter Krempa
Peter Krempa (2): test: Refactor setting of dummy error handlers tests: metadatatest: Quiesce errors on expected paths tests/esxutilstest.c | 12 +--- tests/metadatatest.c | 2 ++ tests/reconnect.c| 6 +- tests/sockettest.c | 9 + tests/statstest.c| 9

[libvirt] [PATCH 2/2] tests: metadatatest: Quiesce errors on expected paths

2013-09-17 Thread Peter Krempa
Use the helper added in previous patch to quiesce errors from this test that was spamming logs on normal test runs. --- tests/metadatatest.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/metadatatest.c b/tests/metadatatest.c index 6bcf335..30c43ba 100644 --- a/tests/metadatatest.c

Re: [libvirt] want help about python APIs doc

2013-09-17 Thread Daniel P. Berrange
On Tue, Sep 17, 2013 at 04:25:14PM +0800, Tony Gong wrote: hi friends, I need some help for finding python APIs of libvirt. I have already find the Java APIs doc at here: http://libvirt.org/sources/java/javadoc/, is there any doc just like this to make me to find APIs more easy. many

[libvirt] [PATCHv5 0/3] VMX: CD-ROM handling improvements

2013-09-17 Thread Doug Goldstein
A user came into #virt the other day and was trying to get libvirtd to work with VMware Fusion 5, which is basically the Mac OS X version of VMware Workstation. In helping him out I noticed a few limitations of our VMX parser so I've added support through this patchset. I don't personally have

[libvirt] [PATCHv5 2/3] VMX: Add support for 'auto detect' fileNames

2013-09-17 Thread Doug Goldstein
VMWare Fusion 5 can set the CD-ROM's device name to be 'auto detect' when using the physical drive via 'cdrom-raw' device type. VMWare will then connect to first available host CD-ROM to the virtual machine upon start up according to VMWare documentation. If no device is available, it appears that

[libvirt] [PATCHv5 1/3] Allow source for type=block to have no dev

2013-09-17 Thread Doug Goldstein
Currently the XML parser already allows the following syntax: disk type='block' device='cdrom' source startupPolicy='optional'/ target dev='hda' bus='ide'/ address type='drive' controller='0' bus='0' target='0' unit='0'/ /disk But it if the dev value then it would not have the

Re: [libvirt] [PATCH libvirt-java] Set source and target version to Java 1.6

2013-09-17 Thread Wido den Hollander
On 09/17/2013 02:58 PM, Claudio Bley wrote: At Tue, 17 Sep 2013 13:48:11 +0200, Wido den Hollander wrote: On 09/17/2013 01:14 PM, Claudio Bley wrote: At Tue, 17 Sep 2013 10:04:59 +0200, Wido den Hollander wrote: On platforms with Java 1.7 it will still produce compatible code with Java 1.6

[libvirt] [PATCHv5 3/3] VMX: Add a VMWare Fusion 5 configuration for tests

2013-09-17 Thread Doug Goldstein
A user was having an issue with this specific VMWare Fusion config and he gave me permission to add it as part of our test suite to further expand our VMX test coverage. Unfortunately our VMX parser and generator does not support many features contained within and just silently ignores fields it

Re: [libvirt] Can I request a new release of libvirt-java?

2013-09-17 Thread Daniel Veillard
On Tue, Sep 17, 2013 at 11:58:36AM +0200, Wido den Hollander wrote: On 09/17/2013 11:13 AM, Daniel Veillard wrote: On Tue, Sep 17, 2013 at 10:09:36AM +0200, Wido den Hollander wrote: On 09/17/2013 09:23 AM, Daniel Veillard wrote: [...] I just compiled with the java available in my system

Re: [libvirt] [PATCH 1/5] Add https protocol support for cdrom disk

2013-09-17 Thread hzguanqi...@corp.netease.com
Well, Eric, I've created a workbranch, maybe I need to do the rebase operation. I thought that's just ok to follow the steps where http://libvirt.org/hacking.html says: git checkout master git pull git checkout -t origin -b workbranch ...modify on workbranch... git pull --rebase

Re: [libvirt] [PATCH 0/3] Support https, ftps and tftp for cdrom URL

2013-09-17 Thread Daniel P. Berrange
On Mon, Sep 16, 2013 at 02:12:50PM -0300, Aline Manera wrote: From: Aline Manera alin...@br.ibm.com qemu/KVM also supports https, ftps and tftp URL for cdrom definition. With this patchset we will support all the protocols supported by qemu/KVM. Aline Manera (3): Add https protocol

[libvirt] [PATCH 5/5] blkiotune: add virsh support for blkiotune.throttle.iops/bps

2013-09-17 Thread hzguanqiang
From: Guan Qiang hzguanqi...@corp.netease.com This adds four parameters --device-read-bps, --device-write-bps, --device-read-iops and --device-write-iops to virsh command blkiotune for setting/getting blkiotune.throttle.{read/write}_{iops/bps}_device. --- tools/virsh-domain.c | 64

[libvirt] [PATCH 0/5] Add support for device blkio iops and bps throttle

2013-09-17 Thread hzguanqiang
From: Guan Qiang hzguanqi...@corp.netease.com The patches add support for setting/getting blkio read/write bps/iops throttle per-device with blkio cgroup. Aline Manera (3): Add https protocol support for cdrom disk Add ftps protocol support for cdrom disk Add tftp protocol support for

[libvirt] [PATCH 2/8] Introduce new virDomainNormalizeXML API

2013-09-17 Thread Michal Privoznik
Signed-off-by: Michal Privoznik mpriv...@redhat.com --- include/libvirt/libvirt.h.in| 5 python/generator.py | 1 + python/libvirt-override-api.xml | 7 ++ python/libvirt-override.c | 30 src/driver.h| 7 ++

[libvirt] [PATCH 7/8] virDomainDeviceDefParse: Make PostParse callback call optional

2013-09-17 Thread Michal Privoznik
Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/conf/domain_conf.c | 6 -- src/conf/domain_conf.h | 1 + src/libxl/libxl_driver.c | 12 ++-- src/lxc/lxc_driver.c | 6 +++--- src/openvz/openvz_driver.c | 2 +- src/phyp/phyp_driver.c | 2 +-

[libvirt] [PATCH 1/8] domain_conf: Introduce virDomainDeviceDefFormat

2013-09-17 Thread Michal Privoznik
While we already have virDomainDeviceDefParse() we are still missing the format counterpart. It's not the end the world for now, but the function is going to be handy in next patches. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/conf/domain_conf.c | 141

[libvirt] [PATCH 6/8] domain_conf: Move MAC generation to post parse callback

2013-09-17 Thread Michal Privoznik
Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/conf/domain_conf.c | 33 - src/conf/domain_conf.h | 4 +++- src/openvz/openvz_conf.c | 1 + src/openvz/openvz_driver.c | 10 +++--- src/qemu/qemu_command.c| 7 +++

Re: [libvirt] [PATCH 1/5] Add https protocol support for cdrom disk

2013-09-17 Thread Daniel P. Berrange
On Tue, Sep 17, 2013 at 11:15:55PM +0800, hzguanqi...@corp.netease.com wrote: Well, Eric, I've created a workbranch, maybe I need to do the rebase operation. I thought that's just ok to follow the steps where http://libvirt.org/hacking.html says: git checkout master git pull git

[libvirt] [PATCH 1/5] Add https protocol support for cdrom disk

2013-09-17 Thread hzguanqiang
From: Aline Manera alin...@br.ibm.com The https protocol is also accepted by qemu/KVM when specifying the cdrom ISO image. The xml should be as following: disk type='network' device='cdrom' source protocol='https' name='/url/path' host name='host.name' port='443'/

Re: [libvirt] [PATCH 0/2] Add support for device blkio iops and bps throttle

2013-09-17 Thread hzguanqi...@corp.netease.com
ACK. On 2013-09-17 23:51 , Eric Blake wrote: Please fix your workflow to NOT answer 'no' when git asks you about in-reply-to. Just hit enter while leaving that line blank. 'n' is equally as invalid as 'y'. On 09/17/2013 09:47 AM, hzguanqi...@gmail.com wrote: From: Guan Qiang

Re: [libvirt] [PATCH 0/2] Add support for device blkio iops and bps throttle

2013-09-17 Thread Eric Blake
On 09/17/2013 09:56 AM, hzguanqi...@gmail.com wrote: From: Guan Qiang hzguanqi...@corp.netease.com The patches add support for setting/getting blkio read/write bps/iops throttle per-device with blkio cgroup. Closer. This time, your cover letter lists: Message-id:

[libvirt] [PATCH] maint: ignore recently-added test

2013-09-17 Thread Eric Blake
* .gitignore: Ignore metadatatest. Signed-off-by: Eric Blake ebl...@redhat.com --- Pushing under the trivial rule. .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 2b8652f..d70d0dd 100644 --- a/.gitignore +++ b/.gitignore @@ -166,6 +166,7 @@

[libvirt] [PATCH] build: skip ld_preload tests on non-Linux systems

2013-09-17 Thread Eric Blake
A cross build to mingw fails with: CC virsystemdtest-virsystemdtest.o ../../tests/virsystemdtest.c: In function 'testCreateNoSystemd': ../../tests/virsystemdtest.c:97:9: error: implicit declaration of function 'unsetenv' [-Werror=implicit-function-declaration]

Re: [libvirt] [PATCH 1/5] Add https protocol support for cdrom disk

2013-09-17 Thread hzguanqi...@corp.netease.com
Please ignore the patchs [1-3]. I followed the contributer guidelines, before I push the patches I did a git pull --rebase operation, Then the newest three patches are included into my patches. Are there anything I missed? On 2013-09-17 22:50 , hzguanqiang wrote: From: Aline Manera

Re: [libvirt] [PATCH 2/2] tests: metadatatest: Quiesce errors on expected paths

2013-09-17 Thread Peter Krempa
On 09/17/13 16:42, Eric Blake wrote: On 09/17/2013 07:40 AM, Peter Krempa wrote: Use the helper added in previous patch to quiesce errors from this test that was spamming logs on normal test runs. --- tests/metadatatest.c | 2 ++ 1 file changed, 2 insertions(+) ACK Series pushed.

Re: [libvirt] [virt-tools-list] [Spice-devel] More on virt-viewer for windows

2013-09-17 Thread Eric Blake
[adding libvir-list, for some cross-compiling development hints] On 09/17/2013 11:57 AM, Fernando Lozano wrote: Yes, the libvirt comes grom 0.10.2. I'm running the latest windows binaries provided by spice-space.org: C:\Program Files\VirtViewer\binvirsh -V Virsh command line tool of

Re: [libvirt] Mass rebuild report for August 29 2013

2013-09-17 Thread Erik van Pienbroek
Eric Blake schreef op di 17-09-2013 om 15:34 [-0600]: I've played with these in my rawhide VM (and fixed several other libvirt bugs in the meantime, so the time was not wasted :). I was unable to reproduce this particular failure, which may mean that the latest winpthreads has indeed fixed

Re: [libvirt] Mass rebuild report for August 29 2013

2013-09-17 Thread Eric Blake
On 08/29/2013 02:37 PM, Erik van Pienbroek wrote: Eric Blake schreef op do 29-08-2013 om 14:07 [-0600]: On 08/29/2013 11:38 AM, Erik van Pienbroek wrote: This mass rebuild was done using winpthreads instead of the old pthreads-w32 implementation. In Fedora itself winpthreads isn't used by

Re: [libvirt] [Spice-devel] [virt-tools-list] More on virt-viewer for windows

2013-09-17 Thread Marc-André Lureau
- Original Message - [adding libvir-list, for some cross-compiling development hints] On 09/17/2013 11:57 AM, Fernando Lozano wrote: Yes, the libvirt comes grom 0.10.2. I'm running the latest windows binaries provided by spice-space.org: C:\Program

[libvirt] [PATCH] build: hoist system-specific checks before library checks

2013-09-17 Thread Eric Blake
Commit f92c7e3 fixed a regression for native builds, but introduced a regression for cross-compilation builds; in particular, ./autobuild.sh on a Fedora system with mingw cross-compiler fails with: checking for qemu-kvm... /usr/bin/qemu-kvm checking for yajl_parse_complete in -lyajl... no

Re: [libvirt] openvswitch vlan support when not a forwarded network

2013-09-17 Thread Ajith Antony
Thank you for your comprehensive reply! On Tue, Sep 17, 2013 at 4:15 AM, Laine Stump la...@laine.org wrote: On 09/16/2013 07:34 PM, Ajith Antony wrote: The resulting ephemeral bridge(virbr1) looks like the following when my network(w/o vlans) and two domains are started. I don't know if the

Re: [libvirt] [PATCH] build: hoist system-specific checks before library checks

2013-09-17 Thread Eric Blake
On 09/17/2013 10:29 AM, Eric Blake wrote: Commit f92c7e3 fixed a regression for native builds, but introduced a regression for cross-compilation builds; in particular, ./autobuild.sh on a Fedora system with mingw cross-compiler fails with: checking for qemu-kvm... /usr/bin/qemu-kvm

Re: [libvirt] [PATCH 1/5] Add https protocol support for cdrom disk

2013-09-17 Thread hzguanqi...@corp.netease.com
Ok, I got it. Thanks for Daniel and Eric's help. On 2013-09-17 23:22 , Daniel P. Berrange wrote: On Tue, Sep 17, 2013 at 11:15:55PM +0800, hzguanqi...@corp.netease.com wrote: Well, Eric, I've created a workbranch, maybe I need to do the rebase operation. I thought that's just ok to follow

Re: [libvirt] [PATCH 0/2] Add support for device blkio iops and bps throttle

2013-09-17 Thread Eric Blake
Please fix your workflow to NOT answer 'no' when git asks you about in-reply-to. Just hit enter while leaving that line blank. 'n' is equally as invalid as 'y'. On 09/17/2013 09:47 AM, hzguanqi...@gmail.com wrote: From: Guan Qiang hzguanqi...@corp.netease.com The patches add support for

Re: [libvirt] [PATCH 1/2] test: Refactor setting of dummy error handlers

2013-09-17 Thread Eric Blake
On 09/17/2013 07:40 AM, Peter Krempa wrote: Multiple tests need to register a function to quiesce errors from libvirt when using a connection and doing negative tests. Each of those tests had a static function to do so. This can be replaced by a utility function that enables the errors when

Re: [libvirt] [PATCH 1/5] Add https protocol support for cdrom disk

2013-09-17 Thread Eric Blake
On 09/17/2013 08:57 AM, hzguanqi...@corp.netease.com wrote: Please ignore the patchs [1-3]. I followed the contributer guidelines, before I push the patches I did a git pull --rebase operation, Then the newest three patches are included into my patches. Are there anything I missed? That

[libvirt] [PATCH 0/8] Normalization API

2013-09-17 Thread Michal Privoznik
A while ago I've invented this vshCompleteXMLFromDomain() function to increase device-detach intelligence. Basically, it took user's XML and tried to find matching device in domain's XML. However, it was kind of buggy - finding the matching device uses string comparison. This works on text values.

[libvirt] [PATCH 2/2] blkiotune: add virsh support for blkiotune.throttle.iops/bps

2013-09-17 Thread hzguanqiang
From: Guan Qiang hzguanqi...@corp.netease.com This adds four parameters --device-read-bps, --device-write-bps, --device-read-iops and --device-write-iops to virsh command blkiotune for setting/getting blkiotune.throttle.{read/write}_{iops/bps}_device. --- tools/virsh-domain.c | 64

Re: [libvirt] [PATCH 2/2] tests: metadatatest: Quiesce errors on expected paths

2013-09-17 Thread Eric Blake
On 09/17/2013 07:40 AM, Peter Krempa wrote: Use the helper added in previous patch to quiesce errors from this test that was spamming logs on normal test runs. --- tests/metadatatest.c | 2 ++ 1 file changed, 2 insertions(+) ACK diff --git a/tests/metadatatest.c b/tests/metadatatest.c

[libvirt] [PATCH 0/2] Add support for device blkio iops and bps throttle

2013-09-17 Thread hzguanqiang
From: Guan Qiang hzguanqi...@corp.netease.com The patches add support for setting/getting blkio read/write bps/iops throttle per-device with blkio cgroup. Guan Qiang (2): blkiotune: add support for device iops and bps throttle blkiotune: add virsh support for blkiotune.throttle.iops/bps

Re: [libvirt] [PATCHv5 1/3] Allow source for type=block to have no dev

2013-09-17 Thread Eric Blake
On 09/17/2013 07:44 AM, Doug Goldstein wrote: Currently the XML parser already allows the following syntax: disk type='block' device='cdrom' source startupPolicy='optional'/ target dev='hda' bus='ide'/ address type='drive' controller='0' bus='0' target='0' unit='0'/ /disk

Re: [libvirt] [PATCHv5 0/3] VMX: CD-ROM handling improvements

2013-09-17 Thread Eric Blake
On 09/17/2013 07:44 AM, Doug Goldstein wrote: A user came into #virt the other day and was trying to get libvirtd to work with VMware Fusion 5, which is basically the Mac OS X version of VMware Workstation. In helping him out I noticed a few limitations of our VMX parser so I've added support

Re: [libvirt] [PATCH 0/5] Add support for device blkio iops and bps throttle

2013-09-17 Thread Eric Blake
Please fix your workflow to NOT answer 'y' to git's question about what message your patch series is in-reply-to. It incorrectly threads your message. For that matter, if you upgrade to a newer version of git, git will automatically reject attempts to answer 'y', as it is not a valid in-reply-to

[libvirt] [PATCH 5/8] qemu: Implement vimDomainNormalizeXML

2013-09-17 Thread Michal Privoznik
Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/qemu/qemu_driver.c | 45 + 1 file changed, 45 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 0763f9b..1f35c06 100644 --- a/src/qemu/qemu_driver.c +++

[libvirt] [PATCH 2/2] blkiotune: add virsh support for blkiotune.throttle.iops/bps

2013-09-17 Thread hzguanqiang
From: Guan Qiang hzguanqi...@corp.netease.com This adds four parameters --device-read-bps, --device-write-bps, --device-read-iops and --device-write-iops to virsh command blkiotune for setting/getting blkiotune.throttle.{read/write}_{iops/bps}_device. --- tools/virsh-domain.c | 64

[libvirt] [PATCH 0/2] Add support for device blkio iops and bps throttle

2013-09-17 Thread hzguanqiang
From: Guan Qiang hzguanqi...@corp.netease.com The patches add support for setting/getting blkio read/write bps/iops throttle per-device with blkio cgroup. Guan Qiang (2): blkiotune: add support for device iops and bps throttle blkiotune: add virsh support for blkiotune.throttle.iops/bps

[libvirt] [PATCH 3/5] Add tftp protocol support for cdrom disk

2013-09-17 Thread hzguanqiang
From: Aline Manera alin...@br.ibm.com qemu/KVM also supports a tftp URL while specifying the cdrom ISO image. The xml should be as following: disk type='network' device='cdrom' source protocol='tftp' name='/url/path' host name='host.name' port='69'/ /source /disk

[libvirt] [PATCH 3/8] remote_driver: Implement virDomainNormalizeXML

2013-09-17 Thread Michal Privoznik
Signed-off-by: Michal Privoznik mpriv...@redhat.com --- daemon/remote.c | 50 src/remote/remote_driver.c | 40 +++ src/remote/remote_protocol.x | 20 +- 3 files changed, 109 insertions(+),

[libvirt] [PATCH 2/5] Add ftps protocol support for cdrom disk

2013-09-17 Thread hzguanqiang
From: Aline Manera alin...@br.ibm.com The ftps protocol is another protocol supported by qemu/KVM while specifying the cdrom ISO image. The xml should be as following: disk type='network' device='cdrom' source protocol='ftps' name='/url/path' host name='host.name' port='990'/

[libvirt] [PATCH 4/8] virsh: Expose virDomainNormalizeXML

2013-09-17 Thread Michal Privoznik
Signed-off-by: Michal Privoznik mpriv...@redhat.com --- tools/virsh-domain.c | 94 tools/virsh.pod | 8 + 2 files changed, 102 insertions(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 49cd154..5075d0b 100644 ---

[libvirt] [PATCH 8/8] virsh: Resurrect vshCompleteXMLFromDomain

2013-09-17 Thread Michal Privoznik
Signed-off-by: Michal Privoznik mpriv...@redhat.com --- tools/virsh-domain.c | 155 +-- 1 file changed, 151 insertions(+), 4 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 5075d0b..6a60a40 100644 ---

Re: [libvirt] [PATCH] virsh-domain: Remove unnecessary check and tune code in cmdDesc()

2013-09-17 Thread Hongwei Bi
I understand. Thanks for your reminding. 2013/9/17 Ján Tomko jto...@redhat.com On 09/17/2013 11:16 AM, Hongwei Bi wrote: Since there is a check on buf through virBufferError(), it is not necessary to check desc again. The buffer is used for the description provided on the virsh command

  1   2   >