[libvirt] [PATCH v4 3/6] conf: Remove PS2 mouse device for non-X86 platforms

2013-12-11 Thread Li Zhang
From: Li Zhang PS2 device only works for X86 platform, other platforms may need USB mouse. Athough it doesn't influence the QEMU command line, but It's not right to add one PS2 mouse for non-X86 platform. This patch is to remove PS2 device definition from other platforms. Add one default USB mou

[libvirt] [PATCH v4 6/6] Add a default USB keyboard and USB mouse for PPC64

2013-12-11 Thread Li Zhang
From: Li Zhang There is no keyboard working on PPC64 and PS2 mouse is only for PPC64 when graphics are enabled. It needs to add a USB keyboard and USB mouse for it. This patch is to add a USB keyboard and USB mouse when graphics are enabled. Signed-off-by: Li Zhang --- src/qemu/qemu_domain.c

[libvirt] [PATCH v4 4/6] qemu_cap: Add USB keyboard capability

2013-12-11 Thread Li Zhang
From: Li Zhang QEMU can support USB keyboard but libvirt haven't supportted it yet. This patch is to add USB keyboard capabilities and test cases. Signed-off-by: Li Zhang --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + tests/qemuca

[libvirt] [PATCH v4 2/6] conf: Add one interface to add default input devices.

2013-12-11 Thread Li Zhang
From: Li Zhang This patch is to add one new interface to add input devices. Signed-off-by: Li Zhang --- src/conf/domain_conf.c | 29 + src/conf/domain_conf.h | 4 src/libvirt_private.syms | 1 + 3 files changed, 34 insertions(+) diff --git a/src/conf/dom

[libvirt] [PATCH v4 0/6] Support keyboard device

2013-12-11 Thread Li Zhang
From: Li Zhang This patchset is to add keyboard input device. For PPC64, it doesn't support a default keyboard device when the graphic is enabled. Libvirt supports QEMU command line as "-device VGA" which won't create any keyboard device for it. So it requires libvirt to add a default USB keyboa

[libvirt] [PATCH v4 1/6] conf: Add a keyboard input device type

2013-12-11 Thread Li Zhang
From: Li Zhang There is no keyboard for non-x86 platforms when graphics are enabled. It's preferred to add one USB keyboard. This patch is to add keyboard input device type. Signed-off-by: Li Zhang --- docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c| 3 ++- src/conf/domain

[libvirt] [PATCH v4 5/6] qemu: parse qemu command line for USB keyboard

2013-12-11 Thread Li Zhang
From: Li Zhang This patch is to format qemu command line and xen driver for USB keyboard and add test cases for it. Signed-off-by: Li Zhang --- src/qemu/qemu_command.c| 41 -- src/xenxs/xen_sxpr.c | 27 +-

Re: [libvirt] [test-API][PATCH] Add new case for listAllVolumes and update releated conf

2013-12-11 Thread Cong Dong
- Original Message - > From: "Guannan Ren" > To: "codong" > Cc: libvir-list@redhat.com > Sent: Thursday, December 12, 2013 11:57:31 AM > Subject: Re: [libvirt][test-API][PATCH] Add new case for listAllVolumes and > update releated conf > > On 2013年12月12日 10:13, codong wrote: > > listAl

Re: [libvirt] [PATCH] storage: show compile options in virsh --version=long

2013-12-11 Thread Eric Blake
On 12/11/2013 08:38 PM, Doug Goldstein wrote: > On Wed, Dec 11, 2013 at 9:10 PM, Eric Blake wrote: >> Adding output to 'virsh --version=long' makes it easier to >> tell if a distro built with particular libraries (it doesn't >> tell you what a remote libvirtd is built with, but is still >> better

Re: [libvirt] [test-API][PATCH] Add new case for listAllVolumes and update releated conf

2013-12-11 Thread Guannan Ren
On 2013年12月12日 10:13, codong wrote: listAllVolumes is a new API in RHEL7, so add a new case for it. And add the case to releated conf to check the volumes list. modified: cases/storage_dir.conf modified: cases/storage_dir_vol_resize_delta.conf modified: cases/storag

[libvirt] [RFC/PATCH python] expose the bindings version to Python

2013-12-11 Thread Doug Goldstein
The method getVersion() retrieves the version of the libvirt library that the binaries are linked against but there is no way to retrieve the version of the bindings you are using. In the future if we support new APIs in Python that don't rely on features in the library there needs to be a way for

Re: [libvirt] [PATCH] storage: show compile options in virsh --version=long

2013-12-11 Thread Doug Goldstein
On Wed, Dec 11, 2013 at 9:10 PM, Eric Blake wrote: > Adding output to 'virsh --version=long' makes it easier to > tell if a distro built with particular libraries (it doesn't > tell you what a remote libvirtd is built with, but is still > better than nothing). > > * tools/virsh.c (vshShowVersion):

[libvirt] [PATCH] storage: show compile options in virsh --version=long

2013-12-11 Thread Eric Blake
Adding output to 'virsh --version=long' makes it easier to tell if a distro built with particular libraries (it doesn't tell you what a remote libvirtd is built with, but is still better than nothing). * tools/virsh.c (vshShowVersion): Add gluster witness. Signed-off-by: Eric Blake --- tools/vi

[libvirt] [test-API][PATCH] Add new case for listAllVolumes and update releated conf

2013-12-11 Thread codong
listAllVolumes is a new API in RHEL7, so add a new case for it. And add the case to releated conf to check the volumes list. modified: cases/storage_dir.conf modified: cases/storage_dir_vol_resize_delta.conf modified: cases/storage_logical.conf modified: cas

Re: [libvirt] RFC: Changing version number at start of dev cycle instead of end

2013-12-11 Thread Daniel Veillard
On Wed, Dec 11, 2013 at 11:59:55AM -0700, Eric Blake wrote: > On 12/11/2013 09:44 AM, Daniel P. Berrange wrote: > > Currently throughout the dev cycle we stick on the current release > > number. The release number in configure.ac is only changed by DV > > when he is actually cutting the release. >

Re: [libvirt] Glusterfs Libvirt issue

2013-12-11 Thread Umar Draz
Hi Eric Thanks Br. Umar On Thu, Dec 12, 2013 at 1:23 AM, Eric Blake wrote: > On 12/11/2013 01:18 PM, Umar Draz wrote: > > Hi Eric > > [please don't top-post on technical lists] > > > > > Here is the output of rpm > > > > [root@centos ~]# rpm -qa | grep libvirt > > libvirt-python-0.10.2-29.el

[libvirt] [PATCH] qemu: add support for error messages greater than 1024 characters

2013-12-11 Thread Michele Paolino
In libvirt, the default error message length is 1024 bytes. This is not enough for qemu to print long error messages such as the list of supported ARM machine models (more than 1700 chars). This is raised when the machine entry in the XML file is wrong, but there may be now or in future other verbo

Re: [libvirt] Glusterfs Libvirt issue

2013-12-11 Thread Eric Blake
On 12/11/2013 01:18 PM, Umar Draz wrote: > Hi Eric [please don't top-post on technical lists] > > Here is the output of rpm > > [root@centos ~]# rpm -qa | grep libvirt > libvirt-python-0.10.2-29.el6.1.x86_64 > libvirt-0.10.2-29.el6.1.x86_64 There's your problem - gluster pools did not exist in

Re: [libvirt] Glusterfs Libvirt issue

2013-12-11 Thread Umar Draz
Hi Eric Here is the output of rpm [root@centos ~]# rpm -qa | grep libvirt libvirt-python-0.10.2-29.el6.1.x86_64 libvirt-0.10.2-29.el6.1.x86_64 libvirt-client-0.10.2-29.el6.1.x86_64 libvirt-devel-0.10.2-29.el6.1.x86_64 and here is output of php code Array ( [libvirt.release] => 2 [libvir

Re: [libvirt] [PATCH python] Add python3 to the automated build and RPM

2013-12-11 Thread Eric Blake
On 12/11/2013 09:31 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > This updates autobuild.sh to test the python3 build process. > The RPM specfile is changed to build a libvirt-python3 RPM > on Fedora > 18 > > Signed-off-by: Daniel P. Berrange > --- > autobuild.sh |

Re: [libvirt] Glusterfs Libvirt issue

2013-12-11 Thread Eric Blake
On 12/10/2013 10:34 PM, Umar Draz wrote: > Hi, > > I am trying to create glusterfs pool with libvirt but its working, and > following is the error > > *libvirt_storagepool_define_xml(): internal error unknown storage pool type > gluster* What version of libvirt? If older than 1.2.0, upgrade (gl

Re: [libvirt] [PATCH 00/34] network events feature v2

2013-12-11 Thread Eric Blake
On 12/11/2013 12:15 PM, Eric Blake wrote: > struct _virObjectEvent { > virObject parent; > int eventID; > virObjectMeta meta; > }; > > Only has alignment specified by virObject (which in turn is unsigned > int, int, void*), struct _virObject { unsigned int magic; int refs;

Re: [libvirt] [PATCH 00/34] network events feature v2

2013-12-11 Thread Eric Blake
On 12/11/2013 06:18 AM, Michal Privoznik wrote: > > I'm getting some compile errors on ARM: > > CC conf/libvirt_conf_la-domain_event.lo > conf/domain_event.c: In function 'virDomainEventDispatchDefaultFunc': > conf/domain_event.c:1148:30: error: cast increases required alignment of > tar

Re: [libvirt] [PATCH 1/2] interface: Introduce netcfInterfaceObjIsActive

2013-12-11 Thread Eric Blake
On 12/11/2013 05:41 AM, Michal Privoznik wrote: >>> +static int >>> +netcfInterfaceObjIsActive(struct netcf_if *iface, >>> + bool *active) >>> +{ >>> +int ret = -1; >>> +unsigned int flags = 0; >>> + >>> +virObjectRef(driverState); >> >> What's the ref / unref

Re: [libvirt] RFC: Changing version number at start of dev cycle instead of end

2013-12-11 Thread Eric Blake
On 12/11/2013 09:44 AM, Daniel P. Berrange wrote: > Currently throughout the dev cycle we stick on the current release > number. The release number in configure.ac is only changed by DV > when he is actually cutting the release. > > The solution here is fairly simple. We should increase the versi

[libvirt] ?????? about libvirt install

2013-12-11 Thread ????-????
Hello Daniel Very thank you for your reply.And i use libvirt-1.2.0 .The problem solved. Thank you again. Wang -- -- ??: "Daniel P. Berrange";; : 2013??12??10??(??) 11:19 ??: "-"<89931...@qq.com>; : "libvir-list";

[libvirt] RFC: Changing version number at start of dev cycle instead of end

2013-12-11 Thread Daniel P. Berrange
Currently throughout the dev cycle we stick on the current release number. The release number in configure.ac is only changed by DV when he is actually cutting the release. With the python bindings now being split out, this is causing us problems. The python code aims to build against any libvirt

[libvirt] [PATCH python] Add python3 to the automated build and RPM

2013-12-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" This updates autobuild.sh to test the python3 build process. The RPM specfile is changed to build a libvirt-python3 RPM on Fedora > 18 Signed-off-by: Daniel P. Berrange --- autobuild.sh | 6 ++ libvirt-python.spec.in | 57 ++

Re: [libvirt] [PATCH python 00/14] Finished port to Python3

2013-12-11 Thread Daniel P. Berrange
On Mon, Dec 09, 2013 at 03:15:35PM +, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > This series finishes the initial port to Python3. The code > generator works, the C code compiles without warnings, and > the sanitytest passes. > > The APIs using strings have all switched to Py

Re: [libvirt] [PATCH python 06/14] override: Replace PyString_AsString with libvirt_charPtrUnwrap

2013-12-11 Thread Daniel P. Berrange
On Mon, Dec 09, 2013 at 10:33:25AM -0600, Doug Goldstein wrote: > On Mon, Dec 9, 2013 at 9:15 AM, Daniel P. Berrange > wrote: > > From: "Daniel P. Berrange" > > > > Replace calls to PyString_AsString with the helper method > > libvirt_charPtrUnwrap. This isolates the code that will > > change in

Re: [libvirt] [python PATCH v2] Added python binding for the new network events API

2013-12-11 Thread Daniel P. Berrange
On Wed, Dec 11, 2013 at 01:37:18PM +0100, Cédric Bosdonnat wrote: > --- > Changes to previous patch: >* Fixed Eric's comments >* Updated code to latest libvirt patches submitted > > generator.py | 2 + > libvirt-override-virConnect.py | 34 + > libvirt-overri

[libvirt] [PATCH 5/6] Remove the event namespace concept

2013-12-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The event namespace concept is redundant since the same information is available by looking at the class hierarchy of the events. Signed-off-by: Daniel P. Berrange --- src/conf/domain_event.c | 18 -- src/conf/domain_event.h | 2 ++ s

[libvirt] [PATCH 6/6] Add debug output when registering event handlers

2013-12-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Signed-off-by: Daniel P. Berrange --- src/conf/object_event.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/conf/object_event.c b/src/conf/object_event.c index 964dccf..518fa1e 100644 --- a/src/conf/object_event.c +++ b/src/conf/object_event.c @@ -252,6

[libvirt] [PATCH 3/6] Add 'detail' arg to network lifecycle event internals

2013-12-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" While the public API & wire protocol included the 'detail' arg for network lifecycle events, the internal event handling code did not process it. This meant that if a future libvirtd server starts sending non-0 'detail' args, the current libvirt client will not process

[libvirt] [PATCH 1/6] Move examples/domain-events/event-c to examples/object-events

2013-12-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The domain events demo program isn't really tied to domain events anymore, so rename it to object events. Signed-off-by: Daniel P. Berrange --- Makefile.am | 2 +- configure.ac | 2 +- examples/doma

[libvirt] [PATCH 0/6] Misc improvements to events code

2013-12-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" This is a followup to the recent network events patches to improve a few things I noticed when testing this out for real. Daniel P. Berrange (6): Move examples/domain-events/event-c to examples/object-events Update event demo program to support network events too

[libvirt] [PATCH 4/6] Introduce abstract virNetworkEvent class

2013-12-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Inject a virNetworkEvent class between virObjectEvent and virNetworkEventLifecycle to mirror virDomainEvent. Signed-off-by: Daniel P. Berrange --- src/conf/network_event.c | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --gi

[libvirt] [PATCH 2/6] Update event demo program to support network events too

2013-12-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" --- examples/object-events/event-test.c | 45 +++-- 1 file changed, 43 insertions(+), 2 deletions(-) diff --git a/examples/object-events/event-test.c b/examples/object-events/event-test.c index 52aa3d0..6a279cf 100644 --- a/examples/ob

[libvirt] [PATCH] rbd: Use rbd_create3 to create RBD format 2 images by default

2013-12-11 Thread Wido den Hollander
This new RBD format supports snapshotting and cloning. By having libvirt create images in format 2 end-users of the created images can benefit of the new RBD format. Older versions of libvirt can work with this new RBD format as long as librbd supports format 2, something that all recent versions

Re: [libvirt] [PATCH] Read PCI class from sysfs class file instead of config space.

2013-12-11 Thread Thadeu Lima de Souza Cascardo
On Wed, Dec 11, 2013 at 04:30:48PM +0200, Laine Stump wrote: > On 12/10/2013 11:57 AM, Thadeu Lima de Souza Cascardo wrote: > > When determining if a device is behind a PCI bridge, the PCI device > > class is checked by reading the config space. However, there are some > > devices which have the wr

Re: [libvirt] [PATCH] Read PCI class from sysfs class file instead of config space.

2013-12-11 Thread Laine Stump
On 12/10/2013 11:57 AM, Thadeu Lima de Souza Cascardo wrote: > When determining if a device is behind a PCI bridge, the PCI device > class is checked by reading the config space. However, there are some > devices which have the wrong class on the config space, but the class is > initialized by Linu

Re: [libvirt] [PATCH] Read PCI class from sysfs class file instead of config space.

2013-12-11 Thread Laine Stump
On 12/11/2013 02:23 PM, Daniel P. Berrange wrote: > On Tue, Dec 10, 2013 at 07:57:01AM -0200, Thadeu Lima de Souza Cascardo wrote: >> When determining if a device is behind a PCI bridge, the PCI device >> class is checked by reading the config space. However, there are some >> devices which have th

Re: [libvirt] [PATCH] Read PCI class from sysfs class file instead of config space.

2013-12-11 Thread Thadeu Lima de Souza Cascardo
On Wed, Dec 11, 2013 at 12:23:59PM +, Daniel P. Berrange wrote: > On Tue, Dec 10, 2013 at 07:57:01AM -0200, Thadeu Lima de Souza Cascardo wrote: > > When determining if a device is behind a PCI bridge, the PCI device > > class is checked by reading the config space. However, there are some > >

Re: [libvirt] ANNOUNCE: ruby-libvirt 0.5.0

2013-12-11 Thread Chris Lalancette
On Wed, Dec 11, 2013 at 3:28 AM, Dominic Cleal wrote: > Thanks for the fix Chris. A new release would be much appreciated as > we're hitting this issue on gems, not RPMs. Our CI for Foreman > (http://theforeman.org/) runs under a few Ruby versions and picked up > this new version of the gem, so

Re: [libvirt] [PATCH v4 6/7] Fixed indentation in src/conf/*_event*

2013-12-11 Thread Daniel P. Berrange
On Wed, Dec 11, 2013 at 11:38:03AM +0100, Cédric Bosdonnat wrote: > --- > src/conf/domain_event.c | 286 > +++- > src/conf/domain_event.h | 271 + > src/conf/object_event.c | 47 --- > src/conf/ob

Re: [libvirt] [PATCH v4 7/7] Added default case with error for object event dispatching

2013-12-11 Thread Daniel P. Berrange
On Wed, Dec 11, 2013 at 11:38:04AM +0100, Cédric Bosdonnat wrote: > Hitting this should be pretty rare, but at least developers will know > that they are providing a weird event ID. Otherwise for namespace that > are added in the normal way, gcc will raise a warning about unhandled > case in the sw

Re: [libvirt] [PATCH v4 5/7] Added network events to the bridged network driver

2013-12-11 Thread Daniel P. Berrange
On Wed, Dec 11, 2013 at 11:38:02AM +0100, Cédric Bosdonnat wrote: > --- > src/network/bridge_driver.c | 90 > > src/network/bridge_driver_platform.h | 3 ++ > 2 files changed, 93 insertions(+) ACK > +static int > +networkConnectNetworkEventRegister

Re: [libvirt] [PATCH v4 4/7] Add network events to the remote driver

2013-12-11 Thread Daniel P. Berrange
On Wed, Dec 11, 2013 at 11:38:01AM +0100, Cédric Bosdonnat wrote: > --- > daemon/libvirtd.h| 1 + > daemon/remote.c | 139 > +++ > src/remote/remote_driver.c | 127 +++ > src/remote/remote_pro

Re: [libvirt] [PATCH v4 4/7] Add network events to the remote driver

2013-12-11 Thread Daniel P. Berrange
On Wed, Dec 11, 2013 at 11:38:01AM +0100, Cédric Bosdonnat wrote: > --- > daemon/libvirtd.h| 1 + > daemon/remote.c | 139 > +++ > src/remote/remote_driver.c | 127 +++ > src/remote/remote_pro

Re: [libvirt] [PATCH 00/34] network events feature v2

2013-12-11 Thread Michal Privoznik
On 29.11.2013 16:18, Cédric Bosdonnat wrote: > This patch serie is replacing the previous one I sent. The improvements that > were made in between are: > * splitting the 2 huge commits into smaller reviewable ones. > * Get rid of the huge union in virDomainEvent and use virObjects instead. >

Re: [libvirt] [PATCH v4 3/7] Add network events unit tests

2013-12-11 Thread Daniel P. Berrange
On Wed, Dec 11, 2013 at 11:38:00AM +0100, Cédric Bosdonnat wrote: > --- > tests/objecteventtest.c | 167 > > 1 file changed, 167 insertions(+) ACK Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://

Re: [libvirt] [PATCH v4 2/7] test driver: implemented network events

2013-12-11 Thread Daniel P. Berrange
On Wed, Dec 11, 2013 at 11:37:59AM +0100, Cédric Bosdonnat wrote: > --- > src/test/test_driver.c | 62 > ++ > 1 file changed, 62 insertions(+) > > @@ -6027,6 +6056,37 @@ testConnectDomainEventDeregisterAny(virConnectPtr conn, > } > > > +stati

Re: [libvirt] [PATCH v4 1/7] Added Network events API and virNetworkEventLifecycle.

2013-12-11 Thread Daniel P. Berrange
On Wed, Dec 11, 2013 at 11:37:58AM +0100, Cédric Bosdonnat wrote: > diff --git a/src/conf/network_event.c b/src/conf/network_event.c > new file mode 100644 > index 000..74e9d3d > --- /dev/null > +++ b/src/conf/network_event.c > +int > +virNetworkEventStateRegisterID(virConnectPtr conn, > +

Re: [libvirt] [PATCH 1/2] interface: Introduce netcfInterfaceObjIsActive

2013-12-11 Thread Michal Privoznik
On 11.12.2013 13:19, Daniel P. Berrange wrote: > On Wed, Dec 11, 2013 at 10:16:37AM +0100, Michal Privoznik wrote: >> This function barely wraps ncf_if_status() and error handling code. >> >> Signed-off-by: Michal Privoznik >> --- >> src/interface/interface_backend_netcf.c | 57 >> ++

[libvirt] [python PATCH v2] Added python binding for the new network events API

2013-12-11 Thread Cédric Bosdonnat
--- Changes to previous patch: * Fixed Eric's comments * Updated code to latest libvirt patches submitted generator.py | 2 + libvirt-override-virConnect.py | 34 + libvirt-override.c | 152 + 3 files changed,

Re: [libvirt] [PATCH] Read PCI class from sysfs class file instead of config space.

2013-12-11 Thread Michal Privoznik
On 10.12.2013 10:57, Thadeu Lima de Souza Cascardo wrote: > When determining if a device is behind a PCI bridge, the PCI device > class is checked by reading the config space. However, there are some > devices which have the wrong class on the config space, but the class is > initialized by Linux c

Re: [libvirt] [PATCH] docs: fix a typo in libvirt.h

2013-12-11 Thread Martin Kletzander
On Wed, Dec 11, 2013 at 08:30:53PM +0800, Chen Hanxiao wrote: > From: Chen Hanxiao > > s/pausde/paused > > Signed-off-by: Chen Hanxiao > --- > include/libvirt/libvirt.h.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libv

[libvirt] [PATCH] docs: fix a typo in libvirt.h

2013-12-11 Thread Chen Hanxiao
From: Chen Hanxiao s/pausde/paused Signed-off-by: Chen Hanxiao --- include/libvirt/libvirt.h.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in index 29d4dce..51a02f5 100644 --- a/include/libvirt/libvirt.h.in +++ b

Re: [libvirt] [PATCH] Read PCI class from sysfs class file instead of config space.

2013-12-11 Thread Daniel P. Berrange
On Tue, Dec 10, 2013 at 07:57:01AM -0200, Thadeu Lima de Souza Cascardo wrote: > When determining if a device is behind a PCI bridge, the PCI device > class is checked by reading the config space. However, there are some > devices which have the wrong class on the config space, but the class is > i

Re: [libvirt] [Qemu-devel] [PATCH V17 02/11] NUMA: check if the total numa memory size is equal to ram_size

2013-12-11 Thread Daniel P. Berrange
On Tue, Dec 10, 2013 at 05:01:02PM -0200, Eduardo Habkost wrote: > On Tue, Dec 10, 2013 at 07:03:50PM +0100, Paolo Bonzini wrote: > > Il 10/12/2013 14:15, Eduardo Habkost ha scritto: > > >> > If the total number of the assigned numa nodes memory is not > > >> > equal to the assigned ram size, it wi

Re: [libvirt] [PATCH 1/2] interface: Introduce netcfInterfaceObjIsActive

2013-12-11 Thread Daniel P. Berrange
On Wed, Dec 11, 2013 at 10:16:37AM +0100, Michal Privoznik wrote: > This function barely wraps ncf_if_status() and error handling code. > > Signed-off-by: Michal Privoznik > --- > src/interface/interface_backend_netcf.c | 57 > +++-- > 1 file changed, 33 insertions(+

[libvirt] [PATCH v4 5/7] Added network events to the bridged network driver

2013-12-11 Thread Cédric Bosdonnat
--- src/network/bridge_driver.c | 90 src/network/bridge_driver_platform.h | 3 ++ 2 files changed, 93 insertions(+) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 80c5acb..4c0c352 100644 --- a/src/network/bridge_driver.

[libvirt] [PATCH v4 1/7] Added Network events API and virNetworkEventLifecycle.

2013-12-11 Thread Cédric Bosdonnat
Put all network-events related code in src/conf/network_event.[ch] --- include/libvirt/libvirt.h.in | 80 ++ src/Makefile.am | 5 ++ src/conf/network_event.c | 154 +++ src/conf/network_event.h | 51 ++

[libvirt] [PATCH v4 7/7] Added default case with error for object event dispatching

2013-12-11 Thread Cédric Bosdonnat
Hitting this should be pretty rare, but at least developers will know that they are providing a weird event ID. Otherwise for namespace that are added in the normal way, gcc will raise a warning about unhandled case in the switch. --- src/conf/object_event.c | 2 ++ 1 file changed, 2 insertions(+)

[libvirt] [PATCH v4 3/7] Add network events unit tests

2013-12-11 Thread Cédric Bosdonnat
--- tests/objecteventtest.c | 167 1 file changed, 167 insertions(+) diff --git a/tests/objecteventtest.c b/tests/objecteventtest.c index 33e2551..ae29792 100644 --- a/tests/objecteventtest.c +++ b/tests/objecteventtest.c @@ -40,6 +40,18 @@ static

[libvirt] [PATCH v4 6/7] Fixed indentation in src/conf/*_event*

2013-12-11 Thread Cédric Bosdonnat
--- src/conf/domain_event.c | 286 +++- src/conf/domain_event.h | 271 + src/conf/object_event.c | 47 --- src/conf/object_event_private.h | 20 +-- 4 files changed, 364 insertions(+), 260 deletio

[libvirt] [PATCH v4 0/7] Network events API

2013-12-11 Thread Cédric Bosdonnat
This patch serie include changes to respond to Eric and Daniel's comments. The event namespace part of the ID is only handled at the object event's level, though we need to strip it out of virObjectEventStateEventID to get the remote driver properly deregister. Cédric Bosdonnat (7): Added Networ

[libvirt] [PATCH v4 2/7] test driver: implemented network events

2013-12-11 Thread Cédric Bosdonnat
--- src/test/test_driver.c | 62 ++ 1 file changed, 62 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 4972e3d..66afdf7 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -45,6 +45,7 @@ #include "in

[libvirt] [PATCH v4 4/7] Add network events to the remote driver

2013-12-11 Thread Cédric Bosdonnat
--- daemon/libvirtd.h| 1 + daemon/remote.c | 139 +++ src/remote/remote_driver.c | 127 +++ src/remote/remote_protocol.x | 46 +- 4 files changed, 312 insertions(+), 1 deletion(-)

Re: [libvirt] [PATCH] storage_backend_rbd: rename "stat" variable

2013-12-11 Thread Michal Privoznik
On 11.12.2013 09:14, Michael Chapman wrote: > This variable shadows the stat(2) function, which only became visible in > this scope as of commit 9cac8639. Rename the variable so it doesn't > conflict. > > Signed-off-by: Michael Chapman > --- > src/storage/storage_backend_rbd.c | 12 ++--

[libvirt] [PATCH 2/2] interface: Take interface status into account when starting and destroying

2013-12-11 Thread Michal Privoznik
https://bugzilla.redhat.com/show_bug.cgi?id=956994 Currently, it is possible to start an interface that is already running: # virsh iface-start eth2 Interface eth2 started # echo $? 0 # virsh iface-start eth2 Interface eth2 started # echo $? 0 # virsh iface-start eth2 Interface eth2

[libvirt] [PATCH 1/2] interface: Introduce netcfInterfaceObjIsActive

2013-12-11 Thread Michal Privoznik
This function barely wraps ncf_if_status() and error handling code. Signed-off-by: Michal Privoznik --- src/interface/interface_backend_netcf.c | 57 +++-- 1 file changed, 33 insertions(+), 24 deletions(-) diff --git a/src/interface/interface_backend_netcf.c b/src/i

[libvirt] [PATCH 0/2] Fix interface state transitions logic

2013-12-11 Thread Michal Privoznik
Right now it's possible to start an interface that is already running, or destroy an interface multiple times. Such state transitions are not allowed and we check for such cases explicitly in other areas like qemu driver. Michal Privoznik (2): interface: Introduce netcfInterfaceObjIsActive int

[libvirt] [PATCH 5/8] blkio: Setting throttle blkio cgroup for domain

2013-12-11 Thread Gao feng
This patch introduces virCgroupSetBlkioDeviceReadIops, virCgroupSetBlkioDeviceWriteIops, virCgroupSetBlkioDeviceReadBps and virCgroupSetBlkioDeviceWriteBps, we can use these interfaces to set up throttle blkio cgroup for domain. This patch also adds the new throttle blkio cgroup elements to the t

[libvirt] [PATCH 7/8] qemu: allow to setup throttle blkio cgroup through virsh

2013-12-11 Thread Gao feng
With this patch, user can setup throttle blkio cgroup through virsh for qemu domain. Signed-off-by: Guan Qiang Signed-off-by: Gao feng --- src/qemu/qemu_driver.c | 425 - 1 file changed, 386 insertions(+), 39 deletions(-) diff --git a/src/qemu/qe

[libvirt] [PATCH 6/8] virsh: add setting throttle blkio cgroup option to blkiotune

2013-12-11 Thread Gao feng
With this patch, user can setup the throttle blkio cgorup for domain through the virsh cmd, such as: virsh blkiotune domain1 --device-read-bytes-sec /dev/sda1,100,/dev/sda2,200 --device-write-bytes-sec /dev/sda1,100 --device-read-iops-sec /dev/sda1,1 --device-write-iops-sec /dev/

[libvirt] [PATCH 8/8] lxc: allow to setup throttle blkio cgroup through virsh

2013-12-11 Thread Gao feng
With this patch,user can set throttle blkio cgroup for lxc domain through virsh tool. The functions are copied from qemu_driver. Signed-off-by: Guan Qiang Signed-off-by: Gao feng --- src/lxc/lxc_driver.c | 649 +-- 1 file changed, 624 insertions(

[libvirt] [PATCH 4/8] domain: introduce xml elements for throttle blkio cgroup

2013-12-11 Thread Gao feng
This patch introduces new xml elements under , we use these new elements to setup the throttle blkio cgroup for domain. The new blkiotune node looks like this: /path/to/block 1000 1 1 100 100 Signed-off-by: Guan Qiang Signed-off-by: Gao feng ---

Re: [libvirt] ANNOUNCE: ruby-libvirt 0.5.0

2013-12-11 Thread Dominic Cleal
On 11/12/13 01:31, Chris Lalancette wrote: > On Tue, Dec 10, 2013 at 8:35 AM, Chris Lalancette > wrote: >>> gcc -I. -I. >>> -I/usr/local/rvm/rubies/ruby-1.8.7-p371/lib/ruby/1.8/x86_64-linux -I. >>> -DRUBY_EXTCONF_H=\"extconf.h\"-fPIC -g -O2 -fPIC -c common.c >>> common.c: In function ‘ru

[libvirt] [PATCH 1/8] rename virDomainBlkioDeviceWeightParseXML to virDomainBlkioDeviceParseXML

2013-12-11 Thread Gao feng
virDomainBlkioDeviceWeightParseXML will be used to parse the xml element read_bps, write_bps, read_iops, write_iops. Signed-off-by: Gao feng --- src/conf/domain_conf.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c i

[libvirt] [PATCH 3/8] rename virBlkioDeviceWeightPtr to virBlkioDevicePtr

2013-12-11 Thread Gao feng
The throttle blkio cgroup will reuse this struct. Signed-off-by: Gao feng --- src/conf/domain_conf.c | 18 +- src/conf/domain_conf.h | 10 +- src/lxc/lxc_cgroup.c | 6 +++--- src/qemu/qemu_cgroup.c | 8 src/qemu/qemu_driver.c | 18 +- 5 files

[libvirt] [PATCH 2/8] rename virBlkioDeviceWeightArrayClear to virBlkioDeviceArrayClear

2013-12-11 Thread Gao feng
Signed-off-by: Gao feng --- src/conf/domain_conf.c | 8 src/conf/domain_conf.h | 4 ++-- src/libvirt_private.syms | 2 +- src/qemu/qemu_driver.c | 6 +++--- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index e2219f

[libvirt] [PATCH v2 0/8] Add throttle blkio cgroup support for libvirt

2013-12-11 Thread Gao feng
Right now, libvirt only supports the cfq based blkio cgorup, this means if the block devices doesn't use cfq scheduler, the blkio cgroup will loss effect. This patchset adds the throttle blkio cgroup support for libvirt, introduces four elements for domain configuration and extend the virsh comman

[libvirt] [PATCH] storage_backend_rbd: rename "stat" variable

2013-12-11 Thread Michael Chapman
This variable shadows the stat(2) function, which only became visible in this scope as of commit 9cac8639. Rename the variable so it doesn't conflict. Signed-off-by: Michael Chapman --- src/storage/storage_backend_rbd.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --g

[libvirt] [PATCH v2] virtlockd: make re-exec more robust

2013-12-11 Thread Michael Chapman
- Use $XDG_RUNTIME_DIR for re-exec state file when running unprivileged. - argv[0] may not contain a full path to the binary, however it should contain something that can be looked up in the PATH. Use execvp() to do path lookup on re-exec. - As per list discussion [1], ignore --daemon on re-e

Re: [libvirt] [PATCH 5/6] virtlockd: make re-exec more robust

2013-12-11 Thread Michael Chapman
On Tue, 10 Dec 2013, Daniel P. Berrange wrote: It would seem to be simpler to instead change the main() method so that --daemon is ignored when re-exec'ing. Yes, that does sound saner. I also noticed that virtlockd attempts to write out a re-exec state file under /var/ even when running unpri