On 03/29/2014 12:13 AM, Jincheng Miao wrote:
> virNodeDeviceListCaps will always return empty for a pci nodedevice,
> actually it should return 'pci'.
>
> It is because the loop variable ncaps isn't increased.
>
Introduced by commit be2636f.
> https://bugzilla.redhat.com/show_bug.cgi?id=1081932
Hi Daniel,
On Fri, Mar 28, 2014 at 02:48:41PM +, Daniel P. Berrange wrote:
> On Fri, Mar 28, 2014 at 03:16:37PM +0100, Guido Günther wrote:
> > On Fri, Mar 28, 2014 at 12:26:26PM +, Daniel P. Berrange wrote:
> > > A bunch of tests currently attempt to kickstart a full Fedora
> > > OS image
virNodeDeviceListCaps will always return empty for a pci nodedevice,
actually it should return 'pci'.
It is because the loop variable ncaps isn't increased.
https://bugzilla.redhat.com/show_bug.cgi?id=1081932
Signed-off-by: Jincheng Miao
---
src/node_device/node_device_driver.c | 2 +-
1 file
On 03/28/2014 11:01 PM, Peter Krempa wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1072714
>
> Use the "gluster" command line tool to retrieve information about remote
> volumes on a gluster server to allow storage pool source lookup.
>
> Unfortunately gluster doesn't provide a management
On 03/28/2014 04:01 PM, Peter Krempa wrote:
> Use the previously implemented function to lookup glusterfs source pools
> for the netfs pool to lookup native gluster pools too.
> ---
> src/storage/storage_backend_gluster.c | 50
> +++
> 1 file changed, 50 insertions
On 03/28/2014 04:01 PM, Peter Krempa wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1072714
>
> Use the "gluster" command line tool to retrieve information about remote
> volumes on a gluster server to allow storage pool source lookup.
>
> Unfortunately gluster doesn't provide a management
On 03/28/2014 04:01 PM, Peter Krempa wrote:
> Extract the NFS related stuff into a separate function and tidy up the
> rest of the code so we can reuse it to add gluster backend detection.
>
> Additionally avoid reporting of errors from "showmount" and return an
> empty source list instead. This w
With this patch, all information related to a host resource in
a storage file backing chain now lives in util/virstoragefile.h.
The next step will be to consolidate various places that have
been tracking backing chain details to all use a common struct.
The changes to tools/Makefile.am were made n
On 03/28/2014 04:01 PM, Peter Krempa wrote:
> When virStorageFileGetMetadata is called with NULL path argument, the
> invalid pointer boils down through the recursive worker and is caught by
> virHashAddEntry which is thankfully resistant to NULL arguments. As it
> doesn't make sense to pursue back
On 03/28/2014 04:01 PM, Peter Krempa wrote:
> The libgfapi function glfs_fini doesn't tolerate NULL pointers. Add a
> check on the error paths as it's possible to crash libvirtd if the
> gluster volume can't be initialized.
> ---
> src/storage/storage_backend_gluster.c | 6 --
> 1 file changed
On 03/28/2014 04:01 PM, Peter Krempa wrote:
> The elements need to be indented from elements.
> ---
> src/conf/storage_conf.c | 2 ++
> 1 file changed, 2 insertions(+)
ACK; safe for 1.2.3
>
> diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
> index a300476..65504b4 100644
> ---
The libgfapi function glfs_fini doesn't tolerate NULL pointers. Add a
check on the error paths as it's possible to crash libvirtd if the
gluster volume can't be initialized.
---
src/storage/storage_backend_gluster.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/stor
Extract the NFS related stuff into a separate function and tidy up the
rest of the code so we can reuse it to add gluster backend detection.
Additionally avoid reporting of errors from "showmount" and return an
empty source list instead. This will help when adding other detection
backends.
---
sr
Use the previously implemented function to lookup glusterfs source pools
for the netfs pool to lookup native gluster pools too.
---
src/storage/storage_backend_gluster.c | 50 +++
1 file changed, 50 insertions(+)
diff --git a/src/storage/storage_backend_gluster.c
Peter Krempa (6):
storage: pool: Fix XML indentation in pool source lookup
storage: netfs: Split up and tidy up NFS storage pool source function
storage: netfs: Support lookup of glusterfs pool sources
storage: gluster: Implement storage pool lookup
storage: gluster: Fix crash when initia
The elements need to be indented from elements.
---
src/conf/storage_conf.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
index a300476..65504b4 100644
--- a/src/conf/storage_conf.c
+++ b/src/conf/storage_conf.c
@@ -2006,11 +2006,13 @@
v
When virStorageFileGetMetadata is called with NULL path argument, the
invalid pointer boils down through the recursive worker and is caught by
virHashAddEntry which is thankfully resistant to NULL arguments. As it
doesn't make sense to pursue backing chains of NULL volumes, exit
earlier.
This was
https://bugzilla.redhat.com/show_bug.cgi?id=1072714
Use the "gluster" command line tool to retrieve information about remote
volumes on a gluster server to allow storage pool source lookup.
Unfortunately gluster doesn't provide a management library so that we
could use that directly, instead the
On Fri, Mar 28, 2014 at 11:44:43AM -0600, Mike Latimer wrote:
> On Friday, March 28, 2014 05:34:19 PM Richard W.M. Jones wrote:
> > On Fri, Mar 28, 2014 at 11:06:56AM -0600, Mike Latimer wrote:
> > > ACK to all of this. For some reason, Fedora 20 didn't want to install for
> > > me (it failed when
On 03/28/2014 10:32 AM, Cédric Bosdonnat wrote:
> From: Cédric Bosdonnat
>
> pm-is-supported is the only thing needed in pm-utils, better get rid of
> it since systemd is heavily used for libvirt.
> ---
> src/util/virnodesuspend.c | 34 --
> 1 file changed, 20 ins
On 03/28/2014 01:49 PM, Doug Goldstein wrote:
>
> On Mar 28, 2014, at 11:32 AM, Cédric Bosdonnat wrote:
>>
>> From: Cédric Bosdonnat
>>
>> pm-is-supported is the only thing needed in pm-utils, better get rid of
>> it since systemd is heavily used for libvirt.
>> ---
>> src/util/virnodesuspend.c
On Mar 28, 2014, at 11:32 AM, Cédric Bosdonnat wrote:
>
> From: Cédric Bosdonnat
>
> pm-is-supported is the only thing needed in pm-utils, better get rid of
> it since systemd is heavily used for libvirt.
> ---
> src/util/virnodesuspend.c | 34 --
> 1 file change
Amos Kong writes:
> Signed-off-by: Amos Kong
> ---
> vl.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/vl.c b/vl.c
> index 2355227..596ecfa 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -449,6 +449,7 @@ static QemuOptsList qemu_object_opts = {
> },
> };
>
> +#ifdef CONFIG_TPM
>
On Fri, Mar 28, 2014 at 08:55:05AM -0600, Mike Latimer wrote:
> On Friday, March 28, 2014 03:16:37 PM Guido Günther wrote:
> > On Fri, Mar 28, 2014 at 12:26:26PM +, Daniel P. Berrange wrote:
> > > A bunch of tests currently attempt to kickstart a full Fedora
> > > OS image install. Everytime I
On Fri, Mar 28, 2014 at 12:26:26PM +, Daniel P. Berrange wrote:
> A bunch of tests currently attempt to kickstart a full Fedora
> OS image install. Everytime I try to update this kickstart to
> a new version of Fedora it causes no end of pain. Switch the
> tests over to use Richard Jones' virt-
On 3/27/14 20:32 , "Eric Blake" wrote:
>On 03/27/2014 05:54 PM, Tomoki Sekiyama wrote:
>> This sounds reasonable for me to add disks parameters.
>> I will try adding them in next version. Then the api will look like:
>>
>> int virDomainFSFreeze(virDomainPtr dom, char** disks, int ndisks,
>>unsign
This one is a relatively easy move. We don't ever convert the
enum to or from strings (it is inferred from other elements in
the xml, rather than directly represented).
* src/conf/domain_conf.h (virDomainDiskSecretType): Move...
* src/util/virstoragefile.h (virStorageSecreteType): ...and
rename.
On Friday, March 28, 2014 12:28:43 PM Daniel P. Berrange wrote:
> On Thu, Mar 27, 2014 at 04:12:16PM -0600, Mike Latimer wrote:
> > Move the test for /usr/sbin/lldptool up so libvirt-tck will report the
> > skip
> > and reason, rather than passing the test as 'ok'.
>
> So we're talking about the d
On Fri, Mar 28, 2014 at 03:16:37PM +0100, Guido Günther wrote:
> On Fri, Mar 28, 2014 at 12:26:26PM +, Daniel P. Berrange wrote:
> > A bunch of tests currently attempt to kickstart a full Fedora
> > OS image install. Everytime I try to update this kickstart to
> > a new version of Fedora it cau
On 03/28/2014 01:30 PM, xiexiangyou wrote:
> Thanks for your reply.
>
> On 2014/3/27 22:14, Jiri Denemark wrote:
>
>> On Thu, Mar 27, 2014 at 20:51:24 +0800, x00221466 wrote:
>>> Hi,
>>>
>>> When live detaching the virtual net device, such as virtio nic、
>>> RTL8139、E1000, there are some problems:
Eric Blake writes:
> On 03/28/2014 06:04 AM, Markus Armbruster wrote:
>> Amos Kong writes:
>>
>
>> Taking a step back: quite a few command line options make sense only in
>> certain build configurations. We deal with that in several different
>> ways:
>>
>> 1. Target-specific options: qemu-op
On Friday, March 28, 2014 02:32:28 PM Daniel P. Berrange wrote:
> I already made it configurable - just change the OS name in the config
> file to any that virt-builder supports.
Even better. I'm very much liking what I'm seeing in the patches -
specifically patch 4/6. I'll try to test it today
On Friday, March 28, 2014 05:34:19 PM Richard W.M. Jones wrote:
> On Fri, Mar 28, 2014 at 11:06:56AM -0600, Mike Latimer wrote:
> > ACK to all of this. For some reason, Fedora 20 didn't want to install for
> > me (it failed when resizing the disk, and I don't have time to chase it
> > today), but F
Eric Blake writes:
> On 03/28/2014 08:55 AM, Markus Armbruster wrote:
>> Amos Kong writes:
>>
>>> All the options are defined in qemu-options.hx. If we can't find a
>>> matched option definition by group name of option table, then the
>>> group name doesn't match with defined option name, it's
On Friday, March 28, 2014 12:26:26 PM Daniel P. Berrange wrote:
> A bunch of tests currently attempt to kickstart a full Fedora
> OS image install. Everytime I try to update this kickstart to
> a new version of Fedora it causes no end of pain. Switch the
> tests over to use Richard Jones' virt-buil
On Fri, Mar 28, 2014 at 11:06:56AM -0600, Mike Latimer wrote:
> ACK to all of this. For some reason, Fedora 20 didn't want to install for me
> (it failed when resizing the disk, and I don't have time to chase it today),
> but Fedora 19 did. Looks like there are no SUSE images in virt-builder, so
Using a statically defined vnet0 may fail if multiple VMs are running on the
test machine. Switch to mac address, but replace '00' with '0' to match the
output of ebtables.
---
scripts/nwfilter/100-ping-still-working.t | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/script
On Friday, March 28, 2014 05:31:13 PM Richard W.M. Jones wrote:
> libguestfs exists on SUSE. Olaf Hering is packaging it. Not sure
> about SLES, but I was under the impression it was packaged for at
> least some version of SLES.
Right. I thought he was working on some virt-builder images as well
Sorry, just read your follow-up email ...
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine. Supports Linux and Windows.
http://people.redhat.com/~rjones/v
On 21.03.2014 12:31, Daniel P. Berrange wrote:
This short series introduces some helpers for mocking tests,
provides a generic DBus mock helper using them and switches
the systemd test to use these helpers. This will remove much
code duplication in a later firewall test.
Daniel P. Berrange (3):
From: Cédric Bosdonnat
pm-is-supported is the only thing needed in pm-utils, better get rid of
it since systemd is heavily used for libvirt.
---
src/util/virnodesuspend.c | 34 --
1 file changed, 20 insertions(+), 14 deletions(-)
diff --git a/src/util/virnodesusp
---
Makefile.am | 2 +-
configure.ac | 1 +
examples/lxcconvert/Makefile.am | 18 ++
examples/lxcconvert/virt-lxc-convert | 108 +++
4 files changed, 128 insertions(+), 1 deletion(-)
create mode 100644
If ebtables binary is not found in /sbin, use /usr/sbin.
---
scripts/nwfilter/100-ping-still-working.t | 3 ++-
scripts/nwfilter/210-no-mac-spoofing.t| 3 ++-
scripts/nwfilter/220-no-ip-spoofing.t | 3 ++-
scripts/nwfilter/230-no-mac-broadcast.t | 3 ++-
scripts/nwfilter/240-no-arp-spoo
On 03/28/2014 08:55 AM, Markus Armbruster wrote:
> Amos Kong writes:
>
>> All the options are defined in qemu-options.hx. If we can't find a
>> matched option definition by group name of option table, then the
>> group name doesn't match with defined option name, it's not allowed
>> from 2.0
>>
On Friday, March 28, 2014 03:16:37 PM Guido Günther wrote:
> On Fri, Mar 28, 2014 at 12:26:26PM +, Daniel P. Berrange wrote:
> > A bunch of tests currently attempt to kickstart a full Fedora
> > OS image install. Everytime I try to update this kickstart to
> > a new version of Fedora it causes
Amos Kong writes:
> All the options are defined in qemu-options.hx. If we can't find a
> matched option definition by group name of option table, then the
> group name doesn't match with defined option name, it's not allowed
> from 2.0
>
> Signed-off-by: Amos Kong
> ---
> qemu-options.h | 1
On 03/28/2014 06:04 AM, Markus Armbruster wrote:
> Amos Kong writes:
>
> Taking a step back: quite a few command line options make sense only in
> certain build configurations. We deal with that in several different
> ways:
>
> 1. Target-specific options: qemu-options.hx declares a target mask
On Friday, March 28, 2014 12:26:26 PM Daniel P. Berrange wrote:
> A bunch of tests currently attempt to kickstart a full Fedora
> OS image install. Everytime I try to update this kickstart to
> a new version of Fedora it causes no end of pain. Switch the
> tests over to use Richard Jones' virt-buil
On Thu, Mar 27, 2014 at 10:26:42PM +, Richard W.M. Jones wrote:
> I'm pleased to announce libguestfs 1.26, a library and set of tools
> for accessing and modifying virtual machine disk images. This release
> took more than 6 months of work by a considerable number of people,
> and has many new
On Fri, Mar 28, 2014 at 08:27:45AM -0600, Mike Latimer wrote:
> On Friday, March 28, 2014 12:26:26 PM Daniel P. Berrange wrote:
> > A bunch of tests currently attempt to kickstart a full Fedora
> > OS image install. Everytime I try to update this kickstart to
> > a new version of Fedora it causes n
On Fri, Mar 28, 2014 at 08:11:20AM -0600, Mike Latimer wrote:
> On Friday, March 28, 2014 12:28:43 PM Daniel P. Berrange wrote:
> > On Thu, Mar 27, 2014 at 04:12:16PM -0600, Mike Latimer wrote:
> > > Move the test for /usr/sbin/lldptool up so libvirt-tck will report the
> > > skip
> > > and reason,
On 03/28/2014 11:17 AM, Richard W.M. Jones wrote:
> On Fri, Mar 28, 2014 at 10:20:29AM +0100, Ján Tomko wrote:
>> Reported by Richard W.M. Jones:
>> https://www.redhat.com/archives/libvir-list/2014-March/msg01780.html
>>
>> Ján Tomko (2):
>> Remove double free in virHostdevManagerDispose
>> Cre
Hi Amos,
On Thu, Mar 27, 2014 at 09:04:31PM +0800, Amos Kong wrote:
> All the options are defined in qemu-options.hx. If we can't find a
> matched option definition by group name of option table, then the
> group name doesn't match with defined option name, it's not allowed
> from 2.0
>
> Signed-
On Fri, Mar 28, 2014 at 02:17:50PM +0200, Laine Stump wrote:
> On 03/28/2014 01:03 PM, Richard W.M. Jones wrote:
> > On Fri, Mar 28, 2014 at 12:16:43PM +0200, Laine Stump wrote:
> >> On 03/28/2014 10:47 AM, Richard W.M. Jones wrote:
> >>> On Fri, Mar 28, 2014 at 10:33:39AM +0200, Laine Stump wrote:
Change tests which need a full OS image over to use the new
virtbuilder images instead of provisioning from a kickstart
file. This should make them much more reliable to run.
Signed-off-by: Daniel P. Berrange
---
scripts/domain/110-memory-balloon.t | 10 ++--
scripts/nwfilter/090-install-i
The tests run with the libvirt managed dnsmasq instance,
not the global dnsmasq instance.
Signed-off-by: Daniel P. Berrange
---
lib/Sys/Virt/TCK/NetworkHelpers.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/Sys/Virt/TCK/NetworkHelpers.pm
b/lib/Sys/Virt/TCK/NetworkHel
A bunch of tests currently attempt to kickstart a full Fedora
OS image install. Everytime I try to update this kickstart to
a new version of Fedora it causes no end of pain. Switch the
tests over to use Richard Jones' virt-builder command which
is part of libguestfs. This makes it trivial to deploy
Remove the Sys::Virt::TCK::NetworkHelpers::prepare_test_disk_and_vm
method and its helpers. All tests now use the virtbuilder based
images.
Signed-off-by: Daniel P. Berrange
---
Build.PL | 1 -
conf/ks.cfg| 30 -
lib/Sys/Virt/TCK/Netwo
On Thu, Mar 27, 2014 at 04:12:16PM -0600, Mike Latimer wrote:
> Move the test for /usr/sbin/lldptool up so libvirt-tck will report the skip
> and reason, rather than passing the test as 'ok'.
So we're talking about the difference between the test
indicating "OK 3 out of 3 tests skipped" vs "SKIPPE
Enhance the 'generic_domain' method to allow it to setup
guest NICs, defaulting to the default network, but also
allowing use of vepa to a host NIC.
Signed-off-by: Daniel P. Berrange
---
conf/default.cfg | 6 ++
lib/Sys/Virt/TCK.pm | 39 +++
Some of the tests require a full operating system, not
merely a living dead zombie. Add the ability to bootstrap
a full OS image using the 'virt-builder' tool, defaulting
to 'fedora-20' OS image for x86_64.
Signed-off-by: Daniel P. Berrange
---
conf/default.cfg | 19 +++
lib/Sy
Change shutdown_vm_gracefully method so that it invokes
'destroy' if 'shutdown' has not completed after 30 seconds.
Signed-off-by: Daniel P. Berrange
---
lib/Sys/Virt/TCK/NetworkHelpers.pm | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/Sys/Virt/TCK/NetworkHelpers.p
On 03/28/2014 01:03 PM, Richard W.M. Jones wrote:
> On Fri, Mar 28, 2014 at 12:16:43PM +0200, Laine Stump wrote:
>> On 03/28/2014 10:47 AM, Richard W.M. Jones wrote:
>>> On Fri, Mar 28, 2014 at 10:33:39AM +0200, Laine Stump wrote:
Beyond that, a question not with your patch, but with qemu's
>>
* Paolo Bonzini (pbonz...@redhat.com) wrote:
> Il 28/03/2014 10:18, Gonglei (Arei) ha scritto:
> >>> > Can you please give more details at how you are triggering the problem
> >>> > with libvirt? I think Paolo is probably right - the bug is more likely
> >>> > to be in libvirt not expecting the ra
Il 28/03/2014 12:30, Dr. David Alan Gilbert ha scritto:
> Another reason for doing it in libvirt is that the serialization
> between cancellation and completion of migration ultimately is
> controlled by libvirt's lock. Doing this in QEMU makes it harder to
> reason about concurrency.
I think y
On 03/28/2014 12:26 PM, Richard W.M. Jones wrote:
> On Fri, Mar 28, 2014 at 08:47:48AM +, Richard W.M. Jones wrote:
>> On Fri, Mar 28, 2014 at 10:33:39AM +0200, Laine Stump wrote:
>>> Beyond that, a question not with your patch, but with qemu's
>>> implemenation - does it always assume that the
On 03/28/2014 12:34 PM, Michal Privoznik wrote:
> On 28.03.2014 09:33, Laine Stump wrote:
>> On 03/27/2014 07:17 PM, Michal Privoznik wrote:
>>> We allow users to use SLIRP stack. However, there are some knobs
>>> which are not exposed to users, such as host network address, DNS
>>> server, smb, an
On Thu, Mar 27, 2014 at 05:55:06PM -0600, Mike Latimer wrote:
> Due to iptables commit 945353a2 (in iptables v1.4.20 and higher), ip6tables
> no longer prints out /128. This patch removes /128 from output files, and
> replaces '/128' in command output with '' to remain compatible with
> older v
Fix bug https://bugzilla.redhat.com/show_bug.cgi?id=1080859 about
snapshot type in man page. Snapshot type should be no, internal, or
external
---
tools/virsh.pod | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod
index 20352cb..ba2da20 100644
---
On Thu, Mar 27, 2014 at 02:52:31PM -0600, Mike Latimer wrote:
> On Thursday, March 27, 2014 02:49:25 PM Daniel P. Berrange wrote:
> > The network tests invoke various ifconfig and route commands
> > to test network setup, and also grep for dnsmasq/radvd args.
> > Switch to use 'ip' since ifconfig a
Thanks for your reply.
On 2014/3/27 22:14, Jiri Denemark wrote:
> On Thu, Mar 27, 2014 at 20:51:24 +0800, x00221466 wrote:
>> Hi,
>>
>> When live detaching the virtual net device, such as virtio nic、
>> RTL8139、E1000, there are some problems:
>>
>> (1)If the Guest OS don't support the hot pluggin
On Thu, Mar 27, 2014 at 11:55:45AM -0600, Eric Blake wrote:
> On 03/27/2014 11:17 AM, Michal Privoznik wrote:
> > We allow users to use SLIRP stack. However, there are some knobs
> > which are not exposed to users, such as host network address, DNS
> > server, smb, and others.
> >
> > Signed-off-b
On Fri, Mar 28, 2014 at 12:16:43PM +0200, Laine Stump wrote:
> On 03/28/2014 10:47 AM, Richard W.M. Jones wrote:
> > On Fri, Mar 28, 2014 at 10:33:39AM +0200, Laine Stump wrote:
> >> Beyond that, a question not with your patch, but with qemu's
> >> implemenation - does it always assume that the gat
Hi
thanks for your reply
Since I am working on my master thesis and seriously I am running out of
time I decided to downgrade my libvirt from 1.1.1 to 1.0.2 to be able to
continue working on my thesis. Now it works !
But for your information , I already checked the XML file and the interface was
On 28.03.2014 09:33, Laine Stump wrote:
On 03/27/2014 07:17 PM, Michal Privoznik wrote:
We allow users to use SLIRP stack. However, there are some knobs
which are not exposed to users, such as host network address, DNS
server, smb, and others.
Signed-off-by: Michal Privoznik
---
docs/formatd
On Fri, Mar 28, 2014 at 08:47:48AM +, Richard W.M. Jones wrote:
> On Fri, Mar 28, 2014 at 10:33:39AM +0200, Laine Stump wrote:
> > Beyond that, a question not with your patch, but with qemu's
> > implemenation - does it always assume that the gateway address is
> > $network.1 ?
>
> Actually ne
On Thu, Mar 27, 2014 at 06:48:24PM +, Richard W.M. Jones wrote:
> On Thu, Mar 27, 2014 at 06:17:46PM +0100, Michal Privoznik wrote:
> > We allow users to use SLIRP stack. However, there are some knobs
> > which are not exposed to users, such as host network address, DNS
> > server, smb, and oth
On Fri, Mar 28, 2014 at 10:20:29AM +0100, Ján Tomko wrote:
> Reported by Richard W.M. Jones:
> https://www.redhat.com/archives/libvir-list/2014-March/msg01780.html
>
> Ján Tomko (2):
> Remove double free in virHostdevManagerDispose
> Create hostdevmgr in UserRuntimeDirectory for session libvir
On 03/28/2014 10:47 AM, Richard W.M. Jones wrote:
> On Fri, Mar 28, 2014 at 10:33:39AM +0200, Laine Stump wrote:
>> Beyond that, a question not with your patch, but with qemu's
>> implemenation - does it always assume that the gateway address is
>> $network.1 ?
> Actually network.2. The default ad
On Fri, Mar 28, 2014 at 10:34:59 +0100, Michal Privoznik wrote:
> On 27.03.2014 13:53, Mohsen Ghaemi wrote:
> > Hi all
> >
> > I just encountered a problem in libvirt while was trying to attach and
> > detach a sr-iov vf to my VM
> >
> >
> > The version of my libvirt is 1.1.1-0ubuntu8.5
> >
> >
> >
On 27.03.2014 13:53, Mohsen Ghaemi wrote:
Hi all
I just encountered a problem in libvirt while was trying to attach and
detach a sr-iov vf to my VM
The version of my libvirt is 1.1.1-0ubuntu8.5
I tried to attach the device using following xml
When i attache
Il 28/03/2014 10:18, Gonglei (Arei) ha scritto:
> > Can you please give more details at how you are triggering the problem
> > with libvirt? I think Paolo is probably right - the bug is more likely
> > to be in libvirt not expecting the race and not recovering correctly
> > when the race occurs,
Without this, session libvirt won't start if it fails to create
the directory.
---
So far the directory is only used by SRIOV, which I believe does not work
for unprivileged libvirt, but I found always creating the state dir nicer
than possibly crashing on NULL derefernce.
src/util/virhostdev.c
The object itself is freed by virObjectUnref.
---
src/util/virhostdev.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/util/virhostdev.c b/src/util/virhostdev.c
index 54023bd..d80dbf7 100644
--- a/src/util/virhostdev.c
+++ b/src/util/virhostdev.c
@@ -83,8 +83,6 @@ virHostdevManagerDispos
Reported by Richard W.M. Jones:
https://www.redhat.com/archives/libvir-list/2014-March/msg01780.html
Ján Tomko (2):
Remove double free in virHostdevManagerDispose
Create hostdevmgr in UserRuntimeDirectory for session libvirt
src/util/virhostdev.c | 42 +---
> > >> Return error for migrate cancel, when migration status is not
> > >> MIG_STATE_SETUP or MIG_STATE_ACTIVE. Thus, libvirt can can
> > >> perceive the operation fails.
> > >>
> > >> Signed-off-by: zengjunliang
> > >> Signed-off-by: Gonglei
> > >
> > > I think this is done on purpose, because
On Fri, Mar 28, 2014 at 10:33:39AM +0200, Laine Stump wrote:
> Beyond that, a question not with your patch, but with qemu's
> implemenation - does it always assume that the gateway address is
> $network.1 ?
Actually network.2. The default addresses are:
network: 10.0.2
On 03/27/2014 07:17 PM, Michal Privoznik wrote:
> We allow users to use SLIRP stack. However, there are some knobs
> which are not exposed to users, such as host network address, DNS
> server, smb, and others.
>
> Signed-off-by: Michal Privoznik
> ---
> docs/formatdomain.html.in
88 matches
Mail list logo
