Re: [libvirt] [PATCH] Expose SLIRP attributes

2014-03-28 Thread Laine Stump
On 03/27/2014 07:17 PM, Michal Privoznik wrote: We allow users to use SLIRP stack. However, there are some knobs which are not exposed to users, such as host network address, DNS server, smb, and others. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- docs/formatdomain.html.in

Re: [libvirt] [PATCH] Expose SLIRP attributes

2014-03-28 Thread Richard W.M. Jones
On Fri, Mar 28, 2014 at 10:33:39AM +0200, Laine Stump wrote: Beyond that, a question not with your patch, but with qemu's implemenation - does it always assume that the gateway address is $network.1 ? Actually network.2. The default addresses are: network:

Re: [libvirt] [PATCH] migration: Fix possible bug for migrate cancel

2014-03-28 Thread Gonglei (Arei)
Return error for migrate cancel, when migration status is not MIG_STATE_SETUP or MIG_STATE_ACTIVE. Thus, libvirt can can perceive the operation fails. Signed-off-by: zengjunliang zengjunli...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com I think this is done on

[libvirt] [PATCH 0/2] Fix virHostdev with session libvirt

2014-03-28 Thread Ján Tomko
Reported by Richard W.M. Jones: https://www.redhat.com/archives/libvir-list/2014-March/msg01780.html Ján Tomko (2): Remove double free in virHostdevManagerDispose Create hostdevmgr in UserRuntimeDirectory for session libvirt src/util/virhostdev.c | 42

[libvirt] [PATCH 1/2] Remove double free in virHostdevManagerDispose

2014-03-28 Thread Ján Tomko
The object itself is freed by virObjectUnref. --- src/util/virhostdev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/util/virhostdev.c b/src/util/virhostdev.c index 54023bd..d80dbf7 100644 --- a/src/util/virhostdev.c +++ b/src/util/virhostdev.c @@ -83,8 +83,6 @@

[libvirt] [PATCH 2/2] Create hostdevmgr in UserRuntimeDirectory for session libvirt

2014-03-28 Thread Ján Tomko
Without this, session libvirt won't start if it fails to create the directory. --- So far the directory is only used by SRIOV, which I believe does not work for unprivileged libvirt, but I found always creating the state dir nicer than possibly crashing on NULL derefernce. src/util/virhostdev.c

Re: [libvirt] [PATCH] migration: Fix possible bug for migrate cancel

2014-03-28 Thread Paolo Bonzini
Il 28/03/2014 10:18, Gonglei (Arei) ha scritto: Can you please give more details at how you are triggering the problem with libvirt? I think Paolo is probably right - the bug is more likely to be in libvirt not expecting the race and not recovering correctly when the race occurs, than

Re: [libvirt] Device attach / detach problem for passthrough/SR-IOV in libvirt

2014-03-28 Thread Michal Privoznik
On 27.03.2014 13:53, Mohsen Ghaemi wrote: Hi all I just encountered a problem in libvirt while was trying to attach and detach a sr-iov vf to my VM The version of my libvirt is 1.1.1-0ubuntu8.5 I tried to attach the device using following xml interface type='hostdev' managed='yes'

Re: [libvirt] Device attach / detach problem for passthrough/SR-IOV in libvirt

2014-03-28 Thread Jiri Denemark
On Fri, Mar 28, 2014 at 10:34:59 +0100, Michal Privoznik wrote: On 27.03.2014 13:53, Mohsen Ghaemi wrote: Hi all I just encountered a problem in libvirt while was trying to attach and detach a sr-iov vf to my VM The version of my libvirt is 1.1.1-0ubuntu8.5 I tried to attach

Re: [libvirt] [PATCH] Expose SLIRP attributes

2014-03-28 Thread Laine Stump
On 03/28/2014 10:47 AM, Richard W.M. Jones wrote: On Fri, Mar 28, 2014 at 10:33:39AM +0200, Laine Stump wrote: Beyond that, a question not with your patch, but with qemu's implemenation - does it always assume that the gateway address is $network.1 ? Actually network.2. The default addresses

Re: [libvirt] [PATCH 0/2] Fix virHostdev with session libvirt

2014-03-28 Thread Richard W.M. Jones
On Fri, Mar 28, 2014 at 10:20:29AM +0100, Ján Tomko wrote: Reported by Richard W.M. Jones: https://www.redhat.com/archives/libvir-list/2014-March/msg01780.html Ján Tomko (2): Remove double free in virHostdevManagerDispose Create hostdevmgr in UserRuntimeDirectory for session libvirt

Re: [libvirt] [PATCH] Expose SLIRP attributes

2014-03-28 Thread Richard W.M. Jones
On Thu, Mar 27, 2014 at 06:48:24PM +, Richard W.M. Jones wrote: On Thu, Mar 27, 2014 at 06:17:46PM +0100, Michal Privoznik wrote: We allow users to use SLIRP stack. However, there are some knobs which are not exposed to users, such as host network address, DNS server, smb, and others.

Re: [libvirt] [PATCH] Expose SLIRP attributes

2014-03-28 Thread Richard W.M. Jones
On Fri, Mar 28, 2014 at 08:47:48AM +, Richard W.M. Jones wrote: On Fri, Mar 28, 2014 at 10:33:39AM +0200, Laine Stump wrote: Beyond that, a question not with your patch, but with qemu's implemenation - does it always assume that the gateway address is $network.1 ? Actually network.2.

Re: [libvirt] [PATCH] Expose SLIRP attributes

2014-03-28 Thread Michal Privoznik
On 28.03.2014 09:33, Laine Stump wrote: On 03/27/2014 07:17 PM, Michal Privoznik wrote: We allow users to use SLIRP stack. However, there are some knobs which are not exposed to users, such as host network address, DNS server, smb, and others. Signed-off-by: Michal Privoznik

Re: [libvirt] Device attach / detach problem for passthrough/SR-IOV in libvirt

2014-03-28 Thread Mohsen Ghaemi
Hi thanks for your reply Since I am working on my master thesis and seriously I am running out of time I decided to downgrade my libvirt from 1.1.1 to 1.0.2 to be able to continue working on my thesis. Now it works ! But for your information , I already checked the XML file and the interface

Re: [libvirt] [PATCH] Expose SLIRP attributes

2014-03-28 Thread Richard W.M. Jones
On Fri, Mar 28, 2014 at 12:16:43PM +0200, Laine Stump wrote: On 03/28/2014 10:47 AM, Richard W.M. Jones wrote: On Fri, Mar 28, 2014 at 10:33:39AM +0200, Laine Stump wrote: Beyond that, a question not with your patch, but with qemu's implemenation - does it always assume that the gateway

Re: [libvirt] [PATCH] Expose SLIRP attributes

2014-03-28 Thread Daniel P. Berrange
On Thu, Mar 27, 2014 at 11:55:45AM -0600, Eric Blake wrote: On 03/27/2014 11:17 AM, Michal Privoznik wrote: We allow users to use SLIRP stack. However, there are some knobs which are not exposed to users, such as host network address, DNS server, smb, and others. Signed-off-by: Michal

Re: [libvirt] [PATCH]execute netdev_del after receive DEVICE_DELETED event

2014-03-28 Thread xiexiangyou
Thanks for your reply. On 2014/3/27 22:14, Jiri Denemark wrote: On Thu, Mar 27, 2014 at 20:51:24 +0800, x00221466 wrote: Hi, When live detaching the virtual net device, such as virtio nic、 RTL8139、E1000, there are some problems: (1)If the Guest OS don't support the hot plugging pci

Re: [libvirt] [PATCH tck] Adapt network tests to changed cli tool formats

2014-03-28 Thread Daniel P. Berrange
On Thu, Mar 27, 2014 at 02:52:31PM -0600, Mike Latimer wrote: On Thursday, March 27, 2014 02:49:25 PM Daniel P. Berrange wrote: The network tests invoke various ifconfig and route commands to test network setup, and also grep for dnsmasq/radvd args. Switch to use 'ip' since ifconfig and

[libvirt] [PATCH] Fix snapshot-create-as in man page

2014-03-28 Thread shyu
Fix bug https://bugzilla.redhat.com/show_bug.cgi?id=1080859 about snapshot type in man page. Snapshot type should be no, internal, or external --- tools/virsh.pod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 20352cb..ba2da20 100644

Re: [libvirt] [PATCH tck] Remove /128 from ip6tables output

2014-03-28 Thread Daniel P. Berrange
On Thu, Mar 27, 2014 at 05:55:06PM -0600, Mike Latimer wrote: Due to iptables commit 945353a2 (in iptables v1.4.20 and higher), ip6tables no longer prints out /128. This patch removes /128 from output files, and replaces '/128' in command output with '' to remain compatible with older

Re: [libvirt] [PATCH] Expose SLIRP attributes

2014-03-28 Thread Laine Stump
On 03/28/2014 12:34 PM, Michal Privoznik wrote: On 28.03.2014 09:33, Laine Stump wrote: On 03/27/2014 07:17 PM, Michal Privoznik wrote: We allow users to use SLIRP stack. However, there are some knobs which are not exposed to users, such as host network address, DNS server, smb, and others.

Re: [libvirt] [PATCH] Expose SLIRP attributes

2014-03-28 Thread Laine Stump
On 03/28/2014 12:26 PM, Richard W.M. Jones wrote: On Fri, Mar 28, 2014 at 08:47:48AM +, Richard W.M. Jones wrote: On Fri, Mar 28, 2014 at 10:33:39AM +0200, Laine Stump wrote: Beyond that, a question not with your patch, but with qemu's implemenation - does it always assume that the gateway

Re: [libvirt] [Qemu-devel] [PATCH] migration: Fix possible bug for migrate cancel

2014-03-28 Thread Paolo Bonzini
Il 28/03/2014 12:30, Dr. David Alan Gilbert ha scritto: Another reason for doing it in libvirt is that the serialization between cancellation and completion of migration ultimately is controlled by libvirt's lock. Doing this in QEMU makes it harder to reason about concurrency. I think you

Re: [libvirt] [Qemu-devel] [PATCH] migration: Fix possible bug for migrate cancel

2014-03-28 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: Il 28/03/2014 10:18, Gonglei (Arei) ha scritto: Can you please give more details at how you are triggering the problem with libvirt? I think Paolo is probably right - the bug is more likely to be in libvirt not expecting the race and not

Re: [libvirt] [PATCH] Expose SLIRP attributes

2014-03-28 Thread Laine Stump
On 03/28/2014 01:03 PM, Richard W.M. Jones wrote: On Fri, Mar 28, 2014 at 12:16:43PM +0200, Laine Stump wrote: On 03/28/2014 10:47 AM, Richard W.M. Jones wrote: On Fri, Mar 28, 2014 at 10:33:39AM +0200, Laine Stump wrote: Beyond that, a question not with your patch, but with qemu's

[libvirt] [PATCH tck 4/6] Force destroy guests if graceful shutdown fails

2014-03-28 Thread Daniel P. Berrange
Change shutdown_vm_gracefully method so that it invokes 'destroy' if 'shutdown' has not completed after 30 seconds. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- lib/Sys/Virt/TCK/NetworkHelpers.pm | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[libvirt] [PATCH tck 1/6] Add ability to provision full OS using virt-builder

2014-03-28 Thread Daniel P. Berrange
Some of the tests require a full operating system, not merely a living dead zombie. Add the ability to bootstrap a full OS image using the 'virt-builder' tool, defaulting to 'fedora-20' OS image for x86_64. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- conf/default.cfg

[libvirt] [PATCH tck 3/6] Add ability to setup NIC when creating guest XML

2014-03-28 Thread Daniel P. Berrange
Enhance the 'generic_domain' method to allow it to setup guest NICs, defaulting to the default network, but also allowing use of vepa to a host NIC. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- conf/default.cfg | 6 ++ lib/Sys/Virt/TCK.pm | 39

Re: [libvirt] [PATCH tck] 300-vsitype.t: skip earlier if lldptool is not available

2014-03-28 Thread Daniel P. Berrange
On Thu, Mar 27, 2014 at 04:12:16PM -0600, Mike Latimer wrote: Move the test for /usr/sbin/lldptool up so libvirt-tck will report the skip and reason, rather than passing the test as 'ok'. So we're talking about the difference between the test indicating OK 3 out of 3 tests skipped vs SKIPPED ?

[libvirt] [PATCH tck 6/6] Remove obsolete kickstart provisioning helper methods

2014-03-28 Thread Daniel P. Berrange
Remove the Sys::Virt::TCK::NetworkHelpers::prepare_test_disk_and_vm method and its helpers. All tests now use the virtbuilder based images. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- Build.PL | 1 - conf/ks.cfg| 30 -

[libvirt] [PATCH tck 0/6] Fix tests which need a full OS image

2014-03-28 Thread Daniel P. Berrange
A bunch of tests currently attempt to kickstart a full Fedora OS image install. Everytime I try to update this kickstart to a new version of Fedora it causes no end of pain. Switch the tests over to use Richard Jones' virt-builder command which is part of libguestfs. This makes it trivial to

[libvirt] [PATCH tck 2/6] Fix path to dnsmasq leases file

2014-03-28 Thread Daniel P. Berrange
The tests run with the libvirt managed dnsmasq instance, not the global dnsmasq instance. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- lib/Sys/Virt/TCK/NetworkHelpers.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Sys/Virt/TCK/NetworkHelpers.pm

[libvirt] [PATCH tck 5/6] Convert nwfilter and domain balloon tests to virtbuilder images

2014-03-28 Thread Daniel P. Berrange
Change tests which need a full OS image over to use the new virtbuilder images instead of provisioning from a kickstart file. This should make them much more reliable to run. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- scripts/domain/110-memory-balloon.t | 10 ++--

Re: [libvirt] [PATCH] Expose SLIRP attributes

2014-03-28 Thread Richard W.M. Jones
On Fri, Mar 28, 2014 at 02:17:50PM +0200, Laine Stump wrote: On 03/28/2014 01:03 PM, Richard W.M. Jones wrote: On Fri, Mar 28, 2014 at 12:16:43PM +0200, Laine Stump wrote: On 03/28/2014 10:47 AM, Richard W.M. Jones wrote: On Fri, Mar 28, 2014 at 10:33:39AM +0200, Laine Stump wrote: *

Re: [libvirt] [Qemu-devel] [PATCH v5 for 2.0 3/3] abort QEMU if group name in option table doesn't match with defined option name

2014-03-28 Thread Leandro Dorileo
Hi Amos, On Thu, Mar 27, 2014 at 09:04:31PM +0800, Amos Kong wrote: All the options are defined in qemu-options.hx. If we can't find a matched option definition by group name of option table, then the group name doesn't match with defined option name, it's not allowed from 2.0

Re: [libvirt] [PATCH 0/2] Fix virHostdev with session libvirt

2014-03-28 Thread Ján Tomko
On 03/28/2014 11:17 AM, Richard W.M. Jones wrote: On Fri, Mar 28, 2014 at 10:20:29AM +0100, Ján Tomko wrote: Reported by Richard W.M. Jones: https://www.redhat.com/archives/libvir-list/2014-March/msg01780.html Ján Tomko (2): Remove double free in virHostdevManagerDispose Create

Re: [libvirt] [PATCH tck] 300-vsitype.t: skip earlier if lldptool is not available

2014-03-28 Thread Daniel P. Berrange
On Fri, Mar 28, 2014 at 08:11:20AM -0600, Mike Latimer wrote: On Friday, March 28, 2014 12:28:43 PM Daniel P. Berrange wrote: On Thu, Mar 27, 2014 at 04:12:16PM -0600, Mike Latimer wrote: Move the test for /usr/sbin/lldptool up so libvirt-tck will report the skip and reason, rather

Re: [libvirt] [PATCH tck 0/6] Fix tests which need a full OS image

2014-03-28 Thread Daniel P. Berrange
On Fri, Mar 28, 2014 at 08:27:45AM -0600, Mike Latimer wrote: On Friday, March 28, 2014 12:26:26 PM Daniel P. Berrange wrote: A bunch of tests currently attempt to kickstart a full Fedora OS image install. Everytime I try to update this kickstart to a new version of Fedora it causes no end

Re: [libvirt] [Libguestfs] ANNOUNCE: libguestfs 1.26 released

2014-03-28 Thread Richard W.M. Jones
On Thu, Mar 27, 2014 at 10:26:42PM +, Richard W.M. Jones wrote: I'm pleased to announce libguestfs 1.26, a library and set of tools for accessing and modifying virtual machine disk images. This release took more than 6 months of work by a considerable number of people, and has many new

Re: [libvirt] [PATCH tck 0/6] Fix tests which need a full OS image

2014-03-28 Thread Mike Latimer
On Friday, March 28, 2014 12:26:26 PM Daniel P. Berrange wrote: A bunch of tests currently attempt to kickstart a full Fedora OS image install. Everytime I try to update this kickstart to a new version of Fedora it causes no end of pain. Switch the tests over to use Richard Jones' virt-builder

Re: [libvirt] [Qemu-devel] [PATCH v5 for 2.0 1/3] only add qemu_tpmdev_opts when CONFIG_TPM is defined

2014-03-28 Thread Eric Blake
On 03/28/2014 06:04 AM, Markus Armbruster wrote: Amos Kong ak...@redhat.com writes: Taking a step back: quite a few command line options make sense only in certain build configurations. We deal with that in several different ways: 1. Target-specific options: qemu-options.hx declares a

Re: [libvirt] [Qemu-devel] [PATCH v5 for 2.0 3/3] abort QEMU if group name in option table doesn't match with defined option name

2014-03-28 Thread Markus Armbruster
Amos Kong ak...@redhat.com writes: All the options are defined in qemu-options.hx. If we can't find a matched option definition by group name of option table, then the group name doesn't match with defined option name, it's not allowed from 2.0 Signed-off-by: Amos Kong ak...@redhat.com ---

Re: [libvirt] [PATCH tck 0/6] Fix tests which need a full OS image

2014-03-28 Thread Mike Latimer
On Friday, March 28, 2014 03:16:37 PM Guido Günther wrote: On Fri, Mar 28, 2014 at 12:26:26PM +, Daniel P. Berrange wrote: A bunch of tests currently attempt to kickstart a full Fedora OS image install. Everytime I try to update this kickstart to a new version of Fedora it causes no end

Re: [libvirt] [Qemu-devel] [PATCH v5 for 2.0 3/3] abort QEMU if group name in option table doesn't match with defined option name

2014-03-28 Thread Eric Blake
On 03/28/2014 08:55 AM, Markus Armbruster wrote: Amos Kong ak...@redhat.com writes: All the options are defined in qemu-options.hx. If we can't find a matched option definition by group name of option table, then the group name doesn't match with defined option name, it's not allowed from

[libvirt] [PATCH tck] Find ebtables in /sbin or /usr/sbin

2014-03-28 Thread Mike Latimer
If ebtables binary is not found in /sbin, use /usr/sbin. --- scripts/nwfilter/100-ping-still-working.t | 3 ++- scripts/nwfilter/210-no-mac-spoofing.t| 3 ++- scripts/nwfilter/220-no-ip-spoofing.t | 3 ++- scripts/nwfilter/230-no-mac-broadcast.t | 3 ++-

[libvirt] [PATCH v2] Added example script on how to convert LXC container config

2014-03-28 Thread Cédric Bosdonnat
--- Makefile.am | 2 +- configure.ac | 1 + examples/lxcconvert/Makefile.am | 18 ++ examples/lxcconvert/virt-lxc-convert | 108 +++ 4 files changed, 128 insertions(+), 1 deletion(-) create mode 100644

[libvirt] [PATCH] Drop dependency on pm-is-supported

2014-03-28 Thread Cédric Bosdonnat
From: Cédric Bosdonnat cedric.bosdon...@free.fr pm-is-supported is the only thing needed in pm-utils, better get rid of it since systemd is heavily used for libvirt. --- src/util/virnodesuspend.c | 34 -- 1 file changed, 20 insertions(+), 14 deletions(-) diff

Re: [libvirt] [PATCH 0/3] Improve support for mocking APIs in tests

2014-03-28 Thread Michal Privoznik
On 21.03.2014 12:31, Daniel P. Berrange wrote: This short series introduces some helpers for mocking tests, provides a generic DBus mock helper using them and switches the systemd test to use these helpers. This will remove much code duplication in a later firewall test. Daniel P. Berrange (3):

Re: [libvirt] [PATCH tck 0/6] Fix tests which need a full OS image

2014-03-28 Thread Mike Latimer
On Friday, March 28, 2014 05:31:13 PM Richard W.M. Jones wrote: libguestfs exists on SUSE. Olaf Hering is packaging it. Not sure about SLES, but I was under the impression it was packaged for at least some version of SLES. Right. I thought he was working on some virt-builder images as well,

[libvirt] [PATCH tck] 100-ping-still-working.t: Replace vnet0 with mac address

2014-03-28 Thread Mike Latimer
Using a statically defined vnet0 may fail if multiple VMs are running on the test machine. Switch to mac address, but replace '00' with '0' to match the output of ebtables. --- scripts/nwfilter/100-ping-still-working.t | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [libvirt] [PATCH tck 0/6] Fix tests which need a full OS image

2014-03-28 Thread Richard W.M. Jones
On Fri, Mar 28, 2014 at 11:06:56AM -0600, Mike Latimer wrote: ACK to all of this. For some reason, Fedora 20 didn't want to install for me (it failed when resizing the disk, and I don't have time to chase it today), but Fedora 19 did. Looks like there are no SUSE images in virt-builder, so

Re: [libvirt] [Qemu-devel] [PATCH v5 for 2.0 3/3] abort QEMU if group name in option table doesn't match with defined option name

2014-03-28 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 03/28/2014 08:55 AM, Markus Armbruster wrote: Amos Kong ak...@redhat.com writes: All the options are defined in qemu-options.hx. If we can't find a matched option definition by group name of option table, then the group name doesn't match with

Re: [libvirt] [PATCH tck 0/6] Fix tests which need a full OS image

2014-03-28 Thread Mike Latimer
On Friday, March 28, 2014 05:34:19 PM Richard W.M. Jones wrote: On Fri, Mar 28, 2014 at 11:06:56AM -0600, Mike Latimer wrote: ACK to all of this. For some reason, Fedora 20 didn't want to install for me (it failed when resizing the disk, and I don't have time to chase it today), but Fedora

Re: [libvirt] [PATCH tck 0/6] Fix tests which need a full OS image

2014-03-28 Thread Mike Latimer
On Friday, March 28, 2014 02:32:28 PM Daniel P. Berrange wrote: I already made it configurable - just change the OS name in the config file to any that virt-builder supports. Even better. I'm very much liking what I'm seeing in the patches - specifically patch 4/6. I'll try to test it today

Re: [libvirt] [Qemu-devel] [PATCH v5 for 2.0 1/3] only add qemu_tpmdev_opts when CONFIG_TPM is defined

2014-03-28 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 03/28/2014 06:04 AM, Markus Armbruster wrote: Amos Kong ak...@redhat.com writes: Taking a step back: quite a few command line options make sense only in certain build configurations. We deal with that in several different ways: 1.

Re: [libvirt] [PATCH]execute netdev_del after receive DEVICE_DELETED event

2014-03-28 Thread Laine Stump
On 03/28/2014 01:30 PM, xiexiangyou wrote: Thanks for your reply. On 2014/3/27 22:14, Jiri Denemark wrote: On Thu, Mar 27, 2014 at 20:51:24 +0800, x00221466 wrote: Hi, When live detaching the virtual net device, such as virtio nic、 RTL8139、E1000, there are some problems: (1)If the Guest

Re: [libvirt] [PATCH tck 0/6] Fix tests which need a full OS image

2014-03-28 Thread Mike Latimer
On Friday, March 28, 2014 12:26:26 PM Daniel P. Berrange wrote: A bunch of tests currently attempt to kickstart a full Fedora OS image install. Everytime I try to update this kickstart to a new version of Fedora it causes no end of pain. Switch the tests over to use Richard Jones' virt-builder

Re: [libvirt] [PATCH tck 0/6] Fix tests which need a full OS image

2014-03-28 Thread Guido Günther
On Fri, Mar 28, 2014 at 12:26:26PM +, Daniel P. Berrange wrote: A bunch of tests currently attempt to kickstart a full Fedora OS image install. Everytime I try to update this kickstart to a new version of Fedora it causes no end of pain. Switch the tests over to use Richard Jones'

[libvirt] [PATCH 7/n] conf: move storage secret type to util/

2014-03-28 Thread Eric Blake
This one is a relatively easy move. We don't ever convert the enum to or from strings (it is inferred from other elements in the xml, rather than directly represented). * src/conf/domain_conf.h (virDomainDiskSecretType): Move... * src/util/virstoragefile.h (virStorageSecreteType): ...and rename.

Re: [libvirt] [PATCH v4 0/5] Expose FSFreeze/FSThaw within the guest as API

2014-03-28 Thread Tomoki Sekiyama
On 3/27/14 20:32 , Eric Blake ebl...@redhat.com wrote: On 03/27/2014 05:54 PM, Tomoki Sekiyama wrote: This sounds reasonable for me to add disks parameters. I will try adding them in next version. Then the api will look like: int virDomainFSFreeze(virDomainPtr dom, char** disks, int ndisks,

Re: [libvirt] [PATCH tck 0/6] Fix tests which need a full OS image

2014-03-28 Thread Daniel P. Berrange
On Fri, Mar 28, 2014 at 03:16:37PM +0100, Guido Günther wrote: On Fri, Mar 28, 2014 at 12:26:26PM +, Daniel P. Berrange wrote: A bunch of tests currently attempt to kickstart a full Fedora OS image install. Everytime I try to update this kickstart to a new version of Fedora it causes no

Re: [libvirt] [PATCH tck 0/6] Fix tests which need a full OS image

2014-03-28 Thread Richard W.M. Jones
On Fri, Mar 28, 2014 at 08:55:05AM -0600, Mike Latimer wrote: On Friday, March 28, 2014 03:16:37 PM Guido Günther wrote: On Fri, Mar 28, 2014 at 12:26:26PM +, Daniel P. Berrange wrote: A bunch of tests currently attempt to kickstart a full Fedora OS image install. Everytime I try to

Re: [libvirt] [PATCH tck] 300-vsitype.t: skip earlier if lldptool is not available

2014-03-28 Thread Mike Latimer
On Friday, March 28, 2014 12:28:43 PM Daniel P. Berrange wrote: On Thu, Mar 27, 2014 at 04:12:16PM -0600, Mike Latimer wrote: Move the test for /usr/sbin/lldptool up so libvirt-tck will report the skip and reason, rather than passing the test as 'ok'. So we're talking about the

Re: [libvirt] [Qemu-devel] [PATCH v5 for 2.0 1/3] only add qemu_tpmdev_opts when CONFIG_TPM is defined

2014-03-28 Thread Markus Armbruster
Amos Kong ak...@redhat.com writes: Signed-off-by: Amos Kong ak...@redhat.com --- vl.c | 4 1 file changed, 4 insertions(+) diff --git a/vl.c b/vl.c index 2355227..596ecfa 100644 --- a/vl.c +++ b/vl.c @@ -449,6 +449,7 @@ static QemuOptsList qemu_object_opts = { }, };

Re: [libvirt] [PATCH] Drop dependency on pm-is-supported

2014-03-28 Thread Doug Goldstein
On Mar 28, 2014, at 11:32 AM, Cédric Bosdonnat cbosdon...@suse.com wrote: From: Cédric Bosdonnat cedric.bosdon...@free.fr pm-is-supported is the only thing needed in pm-utils, better get rid of it since systemd is heavily used for libvirt. --- src/util/virnodesuspend.c | 34

Re: [libvirt] [PATCH] Drop dependency on pm-is-supported

2014-03-28 Thread Eric Blake
On 03/28/2014 01:49 PM, Doug Goldstein wrote: On Mar 28, 2014, at 11:32 AM, Cédric Bosdonnat cbosdon...@suse.com wrote: From: Cédric Bosdonnat cedric.bosdon...@free.fr pm-is-supported is the only thing needed in pm-utils, better get rid of it since systemd is heavily used for libvirt. ---

Re: [libvirt] [PATCH] Drop dependency on pm-is-supported

2014-03-28 Thread Eric Blake
On 03/28/2014 10:32 AM, Cédric Bosdonnat wrote: From: Cédric Bosdonnat cedric.bosdon...@free.fr pm-is-supported is the only thing needed in pm-utils, better get rid of it since systemd is heavily used for libvirt. --- src/util/virnodesuspend.c | 34 -- 1

Re: [libvirt] [PATCH tck 0/6] Fix tests which need a full OS image

2014-03-28 Thread Richard W.M. Jones
On Fri, Mar 28, 2014 at 11:44:43AM -0600, Mike Latimer wrote: On Friday, March 28, 2014 05:34:19 PM Richard W.M. Jones wrote: On Fri, Mar 28, 2014 at 11:06:56AM -0600, Mike Latimer wrote: ACK to all of this. For some reason, Fedora 20 didn't want to install for me (it failed when resizing

[libvirt] [PATCH 1/6] storage: pool: Fix XML indentation in pool source lookup

2014-03-28 Thread Peter Krempa
The source elements need to be indented from sources elements. --- src/conf/storage_conf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index a300476..65504b4 100644 --- a/src/conf/storage_conf.c +++ b/src/conf/storage_conf.c @@ -2006,11

[libvirt] [PATCH 6/6] util: storagefile: Don't pursue backing chain of NULL image

2014-03-28 Thread Peter Krempa
When virStorageFileGetMetadata is called with NULL path argument, the invalid pointer boils down through the recursive worker and is caught by virHashAddEntry which is thankfully resistant to NULL arguments. As it doesn't make sense to pursue backing chains of NULL volumes, exit earlier. This was

[libvirt] [PATCH 0/6] Gluster pool lookup and few gluster related fixes

2014-03-28 Thread Peter Krempa
Peter Krempa (6): storage: pool: Fix XML indentation in pool source lookup storage: netfs: Split up and tidy up NFS storage pool source function storage: netfs: Support lookup of glusterfs pool sources storage: gluster: Implement storage pool lookup storage: gluster: Fix crash when

[libvirt] [PATCH 3/6] storage: netfs: Support lookup of glusterfs pool sources

2014-03-28 Thread Peter Krempa
https://bugzilla.redhat.com/show_bug.cgi?id=1072714 Use the gluster command line tool to retrieve information about remote volumes on a gluster server to allow storage pool source lookup. Unfortunately gluster doesn't provide a management library so that we could use that directly, instead the

[libvirt] [PATCH 4/6] storage: gluster: Implement storage pool lookup

2014-03-28 Thread Peter Krempa
Use the previously implemented function to lookup glusterfs source pools for the netfs pool to lookup native gluster pools too. --- src/storage/storage_backend_gluster.c | 50 +++ 1 file changed, 50 insertions(+) diff --git a/src/storage/storage_backend_gluster.c

[libvirt] [PATCH 2/6] storage: netfs: Split up and tidy up NFS storage pool source function

2014-03-28 Thread Peter Krempa
Extract the NFS related stuff into a separate function and tidy up the rest of the code so we can reuse it to add gluster backend detection. Additionally avoid reporting of errors from showmount and return an empty source list instead. This will help when adding other detection backends. ---

[libvirt] [PATCH 5/6] storage: gluster: Fix crash when initialization of storage backend fails

2014-03-28 Thread Peter Krempa
The libgfapi function glfs_fini doesn't tolerate NULL pointers. Add a check on the error paths as it's possible to crash libvirtd if the gluster volume can't be initialized. --- src/storage/storage_backend_gluster.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [libvirt] [PATCH 1/6] storage: pool: Fix XML indentation in pool source lookup

2014-03-28 Thread Eric Blake
On 03/28/2014 04:01 PM, Peter Krempa wrote: The source elements need to be indented from sources elements. --- src/conf/storage_conf.c | 2 ++ 1 file changed, 2 insertions(+) ACK; safe for 1.2.3 diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index a300476..65504b4 100644

Re: [libvirt] [PATCH 5/6] storage: gluster: Fix crash when initialization of storage backend fails

2014-03-28 Thread Eric Blake
On 03/28/2014 04:01 PM, Peter Krempa wrote: The libgfapi function glfs_fini doesn't tolerate NULL pointers. Add a check on the error paths as it's possible to crash libvirtd if the gluster volume can't be initialized. --- src/storage/storage_backend_gluster.c | 6 -- 1 file changed, 4

Re: [libvirt] [PATCH 6/6] util: storagefile: Don't pursue backing chain of NULL image

2014-03-28 Thread Eric Blake
On 03/28/2014 04:01 PM, Peter Krempa wrote: When virStorageFileGetMetadata is called with NULL path argument, the invalid pointer boils down through the recursive worker and is caught by virHashAddEntry which is thankfully resistant to NULL arguments. As it doesn't make sense to pursue backing

[libvirt] [PATCH 8/n] conf: move storage source type to util/

2014-03-28 Thread Eric Blake
With this patch, all information related to a host resource in a storage file backing chain now lives in util/virstoragefile.h. The next step will be to consolidate various places that have been tracking backing chain details to all use a common struct. The changes to tools/Makefile.am were made

Re: [libvirt] [PATCH 2/6] storage: netfs: Split up and tidy up NFS storage pool source function

2014-03-28 Thread Eric Blake
On 03/28/2014 04:01 PM, Peter Krempa wrote: Extract the NFS related stuff into a separate function and tidy up the rest of the code so we can reuse it to add gluster backend detection. Additionally avoid reporting of errors from showmount and return an empty source list instead. This will

Re: [libvirt] [PATCH 3/6] storage: netfs: Support lookup of glusterfs pool sources

2014-03-28 Thread Eric Blake
On 03/28/2014 04:01 PM, Peter Krempa wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1072714 Use the gluster command line tool to retrieve information about remote volumes on a gluster server to allow storage pool source lookup. Unfortunately gluster doesn't provide a management library

Re: [libvirt] [PATCH 4/6] storage: gluster: Implement storage pool lookup

2014-03-28 Thread Eric Blake
On 03/28/2014 04:01 PM, Peter Krempa wrote: Use the previously implemented function to lookup glusterfs source pools for the netfs pool to lookup native gluster pools too. --- src/storage/storage_backend_gluster.c | 50 +++ 1 file changed, 50 insertions(+)

Re: [libvirt] [PATCH 3/6] storage: netfs: Support lookup of glusterfs pool sources

2014-03-28 Thread Ján Tomko
On 03/28/2014 11:01 PM, Peter Krempa wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1072714 Use the gluster command line tool to retrieve information about remote volumes on a gluster server to allow storage pool source lookup. Unfortunately gluster doesn't provide a management library

[libvirt] [PATCH] Fix virNodeDeviceListCaps always returns empty

2014-03-28 Thread Jincheng Miao
virNodeDeviceListCaps will always return empty for a pci nodedevice, actually it should return 'pci'. It is because the loop variable ncaps isn't increased. https://bugzilla.redhat.com/show_bug.cgi?id=1081932 Signed-off-by: Jincheng Miao jm...@redhat.com ---

Re: [libvirt] [PATCH tck 0/6] Fix tests which need a full OS image

2014-03-28 Thread Guido Günther
Hi Daniel, On Fri, Mar 28, 2014 at 02:48:41PM +, Daniel P. Berrange wrote: On Fri, Mar 28, 2014 at 03:16:37PM +0100, Guido Günther wrote: On Fri, Mar 28, 2014 at 12:26:26PM +, Daniel P. Berrange wrote: A bunch of tests currently attempt to kickstart a full Fedora OS image install.

Re: [libvirt] [PATCH] Fix virNodeDeviceListCaps always returns empty

2014-03-28 Thread Ján Tomko
On 03/29/2014 12:13 AM, Jincheng Miao wrote: virNodeDeviceListCaps will always return empty for a pci nodedevice, actually it should return 'pci'. It is because the loop variable ncaps isn't increased. Introduced by commit be2636f. https://bugzilla.redhat.com/show_bug.cgi?id=1081932