From: Li Yang liyang.f...@cn.fujitsu.com
For now the help informatin of net-event and event like this:
[root@localhost qemu]# virsh help net-event
NAME
net-event - (null)
...
[root@localhost qemu]# virsh help event
NAME
event - (null)
...
Now fixed them, make them show correct
On 04/03/2014 08:43 AM, Olivia Yin wrote:
Save/restore the state of domain and migrate need read state XML file.
8192B is not the exactly maximum file length of state file.
restore command could work successfully in virsh shell.
virsh # list --all
IdName State
On 02/03/2014 11:19 PM, Jiri Denemark wrote:
USAGE: $ virsh migrate --live --migrateuri x-rdma:hostname domain
qemu+ssh://hostname/system
s/x-rdma/rdma/ and I believe we should use rdma://hostname as the URI
Acknowledged.
Signed-off-by: Michael R. Hines mrhi...@us.ibm.com
---
On 04/04/2014 03:21 AM, Olivia Yin wrote:
For example, the file /proc/cpuinfo for 24 cores PowerPC platform is larger
than
the previous maximum size 2KB.
It will fail to start libvirtd with the error message as below:
virFileReadAll: Failed to read file '/proc/cpuinfo': Value too large for
On 04/03/2014 08:13 PM, Nehal J Wani wrote:
Fixes leak introduced by e562e82f
==4937== 64 bytes in 1 blocks are definitely lost in loss record 270 of 405
==4937==at 0x4A06BE0: realloc (vg_replace_malloc.c:662)
==4937==by 0x6FA41C4: __vasprintf_chk (vasprintf_chk.c:90)
==4937==by
On 04/04/2014 07:58 AM, liyang wrote:
From: Li Yang liyang.f...@cn.fujitsu.com
For now the help informatin of net-event and event like this:
[root@localhost qemu]# virsh help net-event
NAME
net-event - (null)
...
[root@localhost qemu]# virsh help event
NAME
event -
On 02/03/2014 11:44 PM, Eric Blake wrote:
On 02/03/2014 08:19 AM, Jiri Denemark wrote:
On Mon, Jan 13, 2014 at 14:28:11 +0800, mrhi...@linux.vnet.ibm.com wrote:
From: Michael R. Hines mrhi...@us.ibm.com
The switch from x-rdma = rdma has not yet happened,
but at least we can review the patch
On 02/04/2014 10:56 PM, Jiri Denemark wrote:
On Mon, Jan 13, 2014 at 14:28:12 +0800, mrhi...@linux.vnet.ibm.com wrote:
From: Michael R. Hines mrhi...@us.ibm.com
RDMA Live migration requires registering memory with the hardware,
Hmm, I forgot to ask when I was reviewing the previous patch but
From: Li Yang liyang.f...@cn.fujitsu.com
The original comment of vshCmdInfo:
name - command name
Actually it's 'help' and the short description
of command, not the command name.
Signed-off-by: Li Yang liyang.f...@cn.fujitsu.com
---
tools/virsh.h |2 +-
1 files changed, 1 insertions(+), 1
This patch only defines a macro STATE_FILE_LEN.
It doesn't aim to fix the issue.
VSH_MAX_XML_FILE is 10MB, but I got a saved XML file about 180MB.
Best Regards,
Olivia
-Original Message-
From: Ján Tomko [mailto:jto...@redhat.com]
Sent: Friday, April 04, 2014 2:06 PM
To: Yin
On 04/04/14 06:32, Eric Blake wrote:
Writing this test with C99 initializers will make it easier to test
additions and deletions to struct members as I refactor the code.
* tests/virstoragetest.c (mymain): Rewrite initializers.
Signed-off-by: Eric Blake ebl...@redhat.com
---
This series removes qemuDomainGetPercpuStats in favor of
virCgroupGetPercpuStats, fixes incorrect startcpu
boundaries check and cleans the code up.
Ján Tomko (6):
Don't require domain obj in qemuDomainGetPercpuStats
Fix return value of virCgroupGetPercpuStats
Extend virCgroupGetPercpuStats
We need to return the number of successfully populated stats,
not the nparams supplied by the user.
---
src/util/vircgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c
index b881c8c..1ff3dad 100644
--- a/src/util/vircgroup.c
+++
The iterator is checked for being less than or equal to need_cpus.
The 'n' variable is incremented need_cpus + 1 times.
Simplify the computation of need_cpus and make its value one larger,
to let it be used instead of 'n' and compared without the equal sign
in loop conditions.
Just index the
Currently, virCgroupGetPercpuStats is only used by the LXC driver,
filling out the CPUTIME stats. qemuDomainGetPercpuStats does this
and also filles out VCPUTIME stats.
Extend virCgroupGetPercpuStats to also report VCPUTIME stats if
nvcpupids is non-zero. In the LXC driver, we don't have cpupids.
All we need is the virCgroupPtr and number of vcpupids.
This will allow the function to be moved to util/vircgroup.c.
---
src/qemu/qemu_driver.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index
total_cpus is the total number of CPUs on the host
need_cpus is the number of CPUs we need to look at
(need_cpus can be larger than ncpus, because we need to look
at CPUs before the startcpu too, even if we aren't reporting
their stats)
---
src/util/vircgroup.c | 24
1
The cpus are indexed from 0, so a startcpu value equal
to the number of CPUs is invalid.
https://bugzilla.redhat.com/show_bug.cgi?id=1070680
---
src/util/vircgroup.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c
index
On Wed, Apr 02, 2014 at 03:40:14PM -0400, Brian Rak wrote:
@@ -163,6 +164,28 @@
virNWFilterVarHashmapAddStdValues(virNWFilterHashTablePtr table,
%s, _(Could not add variable 'MAC' to
hashmap));
return -1;
}
+
+virMacAddr
On Thu, Apr 03, 2014 at 01:51:20AM -0400, Brian Rak wrote:
Currently, adding any sort of IPv6 nwfilter rules is rather difficult.
There are no standard rules, and you end up doing a lot of things by
hand. This patch makes the $V6LOCAL variable available within nwfilter
nules. This is the
On Thu, Apr 03, 2014 at 11:39:29AM -0400, Tomoki Sekiyama wrote:
These will freeze and thaw filesystems within guest. The APIs take @disks
and @ndisks parameters to specify disks to be frozen or thawed.
The parameters can be NULL and 0, then the all mounted filesystes are
frozen or thawed. If
On 04/04/14 06:32, Eric Blake wrote:
I'm about to add fields to virStorageFileMetadata, which means
also adding fields to the testFileData struct in virstoragetest.
Alas, adding even one pointer on an x86_64 machine gave me a
dreaded compiler error:
virstoragetest.c:712:1: error: the frame
On Thu, Apr 03, 2014 at 05:28:35PM -0400, Brian Rak wrote:
I'm looking into adding IPv6 support to the nwfilter clean-traffic
rules, but I'm unsure of the best approach to this. I'm planning on
sending patches once I get this correct, so I'm trying to figure out
what way fits in best.
On 04/04/14 06:32, Eric Blake wrote:
Right now, virStorageFileMetadata tracks bool backingStoreIsFile
for whether the backing string specified in metadata can be
resolved as a file (covering both block and regular file
resources) or is treated as a network protocol. But when
merging this
On 04/02/2014 02:43 PM, Michal Privoznik wrote:
Currently, the virsh code is plenty of the following pattern:
if (vshCommandOptUInt(..) 0) {
vshError(...);
goto cleanup;
}
It doesn't make much sense to repeat the code everywhere.
Moreover, some functions from the family
On 04/02/2014 02:43 PM, Michal Privoznik wrote:
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
tests/vcpupin| 1 -
tools/virsh-domain.c | 75
+---
2 files changed, 24 insertions(+), 52 deletions(-)
diff --git
Ok, I think indentation should be ok like that and I added error
handling for VIR_STRDUP. I think just returning -1 like the other
places should be ok as the only caller looks to handle the disposal
of the config structure.
-Stefan
---
From dfe579003e91137ecd824d2a08bcdc8f18725857 Mon Sep 17
On 04/04/14 06:32, Eric Blake wrote:
The current use of virStorageFileMetadata is awkward; to learn
some of the information about a child node, you have to read
fields in the parent node. This does not lend itself well to
modifying backing chains (whether inserting a new node in the
chain,
On Fri, 2014-04-04 at 11:36 +0200, Stefan Bader wrote:
+/*
+ * Take the first defined video device (graphics card) to display
+ * on the first graphics device (display).
+ * Right now only type and vram info is used and anything beside
+ * type xen and vga is mapped to
On 04/04/14 06:32, Eric Blake wrote:
The testsuite is absolutely essential to feeling comfortable
about swapping the backing chain structure over to a new format.
This patch tests the path settings, and demonstrates that right
now the code is passing only the canonical name to the child
On Fri, 2014-04-04 at 12:31 +0200, Stefan Bader wrote:
On 04.04.2014 11:48, Ian Campbell wrote:
On Fri, 2014-04-04 at 11:36 +0200, Stefan Bader wrote:
+/*
+ * Take the first defined video device (graphics card) to display
+ * on the first graphics device (display).
+ *
On 04.04.2014 12:31, Stefan Bader wrote:
On 04.04.2014 11:48, Ian Campbell wrote:
On Fri, 2014-04-04 at 11:36 +0200, Stefan Bader wrote:
+/*
+ * Take the first defined video device (graphics card) to display
+ * on the first graphics device (display).
+ * Right now only type
On 04.04.2014 12:34, Ian Campbell wrote:
On Fri, 2014-04-04 at 12:31 +0200, Stefan Bader wrote:
On 04.04.2014 11:48, Ian Campbell wrote:
On Fri, 2014-04-04 at 11:36 +0200, Stefan Bader wrote:
+/*
+ * Take the first defined video device (graphics card) to display
+ * on the first
On 04/04/2014 02:51 AM, Daniel P. Berrange wrote:
On Thu, Apr 03, 2014 at 11:39:29AM -0400, Tomoki Sekiyama wrote:
These will freeze and thaw filesystems within guest. The APIs take @disks
and @ndisks parameters to specify disks to be frozen or thawed.
The parameters can be NULL and 0, then
Version two, this time split into two patches.
Michal Privoznik (2):
security_dac: Rework to make it more readable
security_dac: Honor norelabel attribute
src/security/security_dac.c | 355 ++--
1 file changed, 213 insertions(+), 142 deletions(-)
--
While going through the security DAC code, I realized
it's a ragbag with plenty of thing we try to avoid.
For instance, callback data are passed as:
void params[2];
params[0] = mgr;
params[1] = def;
Moreover, there's no need to pass the whole
virDomainDef in the callback as the only
On 04/04/2014 02:54 AM, Peter Krempa wrote:
On 04/04/14 06:32, Eric Blake wrote:
I'm about to add fields to virStorageFileMetadata, which means
also adding fields to the testFileData struct in virstoragetest.
Alas, adding even one pointer on an x86_64 machine gave me a
dreaded compiler error:
The inspiration for this patch comes from a question on the list
asking if there's a way to not label some disks. Well, in DAC driver
there's not. Even if user have requested norelabel:
disk type='file' device='disk'
driver name='qemu' type='raw'/
source
On Fri, Apr 04, 2014 at 11:34:17AM +0100, Ian Campbell wrote:
On Fri, 2014-04-04 at 12:31 +0200, Stefan Bader wrote:
On 04.04.2014 11:48, Ian Campbell wrote:
On Fri, 2014-04-04 at 11:36 +0200, Stefan Bader wrote:
+/*
+ * Take the first defined video device (graphics card) to
On 04/04/2014 03:31 AM, Peter Krempa wrote:
struct _virStorageFileMetadata {
-char *backingStore; /* Canonical name (absolute file, or protocol) */
-char *backingStoreRaw; /* If file, original name, possibly relative */
-char *directory; /* The directory containing basename of
On Fri, 2014-04-04 at 14:51 +0200, Daniel P. Berrange wrote:
On Fri, Apr 04, 2014 at 11:34:17AM +0100, Ian Campbell wrote:
On Fri, 2014-04-04 at 12:31 +0200, Stefan Bader wrote:
On 04.04.2014 11:48, Ian Campbell wrote:
On Fri, 2014-04-04 at 11:36 +0200, Stefan Bader wrote:
+/*
On Fri, Apr 04, 2014 at 01:56:09PM +0100, Ian Campbell wrote:
On Fri, 2014-04-04 at 14:51 +0200, Daniel P. Berrange wrote:
On Fri, Apr 04, 2014 at 11:34:17AM +0100, Ian Campbell wrote:
On Fri, 2014-04-04 at 12:31 +0200, Stefan Bader wrote:
On 04.04.2014 11:48, Ian Campbell wrote:
On
On 04.04.2014 11:12, Ján Tomko wrote:
On 04/02/2014 02:43 PM, Michal Privoznik wrote:
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
tests/vcpupin| 1 -
tools/virsh-domain.c | 75 +---
2 files changed, 24 insertions(+), 52
On 04.04.2014 14:56, Ian Campbell wrote:
On Fri, 2014-04-04 at 14:51 +0200, Daniel P. Berrange wrote:
On Fri, Apr 04, 2014 at 11:34:17AM +0100, Ian Campbell wrote:
On Fri, 2014-04-04 at 12:31 +0200, Stefan Bader wrote:
On 04.04.2014 11:48, Ian Campbell wrote:
On Fri, 2014-04-04 at 11:36
Commit d7c4e0036 assumed all SELinux tests depended upon
securityselinuxhelper need xattr support, but forgot to
move viridentitytest under WITH_ATTR.
Reported-by: Nehal J Wani nehaljw.k...@gmail.com
Signed-off-by: Jincheng Miao jm...@redhat.com
---
tests/Makefile.am | 4 ++--
1 file changed, 2
On 4/4/2014 4:55 AM, Daniel P. Berrange wrote:
On Thu, Apr 03, 2014 at 05:28:35PM -0400, Brian Rak wrote:
I'm looking into adding IPv6 support to the nwfilter clean-traffic
rules, but I'm unsure of the best approach to this. I'm planning on
sending patches once I get this correct, so I'm
On 04.04.2014 15:17, Daniel P. Berrange wrote:
On Fri, Apr 04, 2014 at 11:36:39AM +0200, Stefan Bader wrote:
+static int
+libxlSetBuildGraphics(virDomainDefPtr def, libxl_domain_config *d_config)
+{
+libxl_domain_build_info *b_info = d_config-b_info;
+
+/*
+ * Take the first
Up until now the traffic control filters for the vNIC QoS were
matching only ip traffic. For egress traffic that was unnoticed
because the unmatched traffic would just go to the default htb class
and be shaped anyway. For ingress, though, since the policing of the
rate is done by the filter
Currently, the virsh code is plenty of the following pattern:
if (vshCommandOptUInt(..) 0) {
vshError(...);
goto cleanup;
}
It doesn't make much sense to repeat the code everywhere.
Moreover, some functions from the family already report
error some of them don't.
Signed-off-by:
On Fri, Apr 04, 2014 at 03:36:38PM +0200, Stefan Bader wrote:
On 04.04.2014 15:17, Daniel P. Berrange wrote:
On Fri, Apr 04, 2014 at 11:36:39AM +0200, Stefan Bader wrote:
+static int
+libxlSetBuildGraphics(virDomainDefPtr def, libxl_domain_config *d_config)
+{
+
On 03/26/14 16:14, Jiri Denemark wrote:
Most of the APIs in CPU driver do not expect to get NULL for input
parameters. Let's mark them with ATTRIBUTE_NONNULL and also check for
some members of virCPUDef when the APIs expect them have some specific
values.
Signed-off-by: Jiri Denemark
On Fri, Apr 04, 2014 at 09:35:26AM -0400, Brian Rak wrote:
On 4/4/2014 4:55 AM, Daniel P. Berrange wrote:
On Thu, Apr 03, 2014 at 05:28:35PM -0400, Brian Rak wrote:
I'm looking into adding IPv6 support to the nwfilter clean-traffic
rules, but I'm unsure of the best approach to this. I'm
On 4/4/2014 4:48 AM, Daniel P. Berrange wrote:
On Wed, Apr 02, 2014 at 03:40:14PM -0400, Brian Rak wrote:
@@ -163,6 +164,28 @@ virNWFilterVarHashmapAddStdValues(virNWFilterHashTablePtr
table,
%s, _(Could not add variable 'MAC' to
hashmap));
return
On Fri, Apr 04, 2014 at 10:08:26AM -0400, Brian Rak wrote:
On 4/4/2014 4:48 AM, Daniel P. Berrange wrote:
On Wed, Apr 02, 2014 at 03:40:14PM -0400, Brian Rak wrote:
@@ -163,6 +164,28 @@
virNWFilterVarHashmapAddStdValues(virNWFilterHashTablePtr table,
%s, _(Could
Commit id '18642d10' refactored the call to virCommandRunRegex()
inside a new function virStorageBackendFileSystemNetFindNFSPoolSources(),
but the cut-n-paste didn't remove the state. Now that state is passed
by reference, it results in a libvirtd core with a messages entry:
...internal error:
On 04/04/14 14:54, Eric Blake wrote:
On 04/04/2014 03:31 AM, Peter Krempa wrote:
struct _virStorageFileMetadata {
-char *backingStore; /* Canonical name (absolute file, or protocol) */
-char *backingStoreRaw; /* If file, original name, possibly relative */
-char *directory; /*
[adding libvir-list]
On 04/04/2014 05:23 AM, Markus Armbruster wrote:
Paolo Bonzini pbonz...@redhat.com writes:
Il 04/04/2014 12:58, Markus Armbruster ha scritto:
Have you considered extending QEMUMachineInitArgs instead of adding this
function?
Did not think of this option earlier. You
On 04/04/2014 12:19 AM, Michael R. Hines wrote:
@@ -2561,6 +2570,10 @@ virQEMUCapsInitQMPMonitor(virQEMUCapsPtr
qemuCaps,
if (qemuCaps-version = 1006000)
virQEMUCapsSet(qemuCaps, QEMU_CAPS_DEVICE_VIDEO_PRIMARY);
+if (qemuCaps-version = 200)
+
On 04/04/2014 08:36 AM, John Ferlan wrote:
Commit id '18642d10' refactored the call to virCommandRunRegex()
inside a new function virStorageBackendFileSystemNetFindNFSPoolSources(),
but the cut-n-paste didn't remove the state. Now that state is passed
by reference, it results in a libvirtd
The driver_override field allows us to specify the driver for a device
rather than relying on the driver to provide a positive match of the
device. This shortcuts the existing process of looking up the vendor
and device ID, adding them to the driver new_id, binding the device,
then removing the
On 04/04/2014 12:29 AM, Michael R. Hines wrote:
Yes, it's present, but it still does not guarantee that QEMU supports
it if RDMA was compiled out - only the version number is a
(minimal) guarantee, and even then the hardware can still throw
an error if RDMA itself is not supported.
Which
I almost wrote a hash value free function that just called
VIR_FREE, then realized I couldn't be the first person to
do that. Sure enough, it was worth factoring into a common
helper routine.
Furthermore, in a few places we were passing raw free() as
the cleanup function; whereas going through
On Fri, Apr 4, 2014 at 6:57 PM, Jincheng Miao jm...@redhat.com wrote:
Commit d7c4e0036 assumed all SELinux tests depended upon
securityselinuxhelper need xattr support, but forgot to
move viridentitytest under WITH_ATTR.
Reported-by: Nehal J Wani nehaljw.k...@gmail.com
Signed-off-by:
63 matches
Mail list logo
