[libvirt] [PATCH] Valid pool format type for logical volume pool should be auto and lvm2

2014-06-18 Thread Shanzhi Yu
The logical volume pool supports formats auto and lvm2 Signed-off-by: Shanzhi Yu s...@redhat.com --- src/conf/storage_conf.c | 2 +- src/conf/storage_conf.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index

Re: [libvirt] [PATCH v2 4/4] libxl: Add a test suite for libxl option generator

2014-06-18 Thread Ian Campbell
On Tue, 2014-06-17 at 12:40 -0600, Jim Fehlig wrote: Ian Campbell wrote: On Mon, 2014-06-16 at 17:11 -0600, Jim Fehlig wrote: This function exists in Xen 4.2 as well, in libxl.h. Any ideas on how to handle this? I'm not aware of an existing macro to check for func

Re: [libvirt] [PATCH libvirt] xen: handle root= in xen-xm configuration files.

2014-06-18 Thread Ian Campbell
On Tue, 2014-06-17 at 16:24 +0100, Ian Campbell wrote: +if (xenXMConfigGetString(conf, extra, extra, NULL) 0) This was subtly broken. The default needs to be . -8-- From 539412a6deac8b928c82945d692ef20a49535d65 Mon Sep 17 00:00:00 2001 From: Ian Campbell

Re: [libvirt] [PATCH v2 4/4] libxl: Add a test suite for libxl option generator

2014-06-18 Thread Daniel P. Berrange
On Tue, Jun 17, 2014 at 12:40:30PM -0600, Jim Fehlig wrote: Ian Campbell wrote: On Mon, 2014-06-16 at 17:11 -0600, Jim Fehlig wrote: This function exists in Xen 4.2 as well, in libxl.h. Any ideas on how to handle this? I'm not aware of an existing macro to check for

Re: [libvirt] [PATCH v4] Only set SELinux seclabel if supported by the host.

2014-06-18 Thread Christophe Fergeau
Hi, On Tue, Jun 17, 2014 at 04:01:53PM +0200, Cédric Bosdonnat wrote: This code depends on new API in libvirt-gconfig to extract the secmodels handled by the host. --- Diff to v3: * Added yet another missing g_object_unref. * Fixed the logic for supportsSelinux

[libvirt] [PATCH 1/2] virsh: man: Fix examples and docs for virsh version

2014-06-18 Thread Peter Krempa
The version command now takes the --daemon parameter for a while and the output example was pretty outdated. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1110673 --- tools/virsh.pod | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git

[libvirt] [PATCH 0/2] virsh: man: Tweak some old docs problems

2014-06-18 Thread Peter Krempa
Peter Krempa (2): virsh: man: Fix examples and docs for virsh version virsh: man: Correctly spell QEMU tools/virsh.pod | 29 + 1 file changed, 17 insertions(+), 12 deletions(-) -- 1.9.3 -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH 2/2] virsh: man: Correctly spell QEMU

2014-06-18 Thread Peter Krempa
s/QEemu/QEMU/g --- tools/virsh.pod | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index b522798..ceec1a0 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -19,7 +19,7 @@ under the GNU Lesser General Public License. Virtualization

Re: [libvirt] [Xen-devel] [PATCH libvirt] xen: handle root= in xen-xm configuration files.

2014-06-18 Thread Ian Campbell
On Tue, 2014-06-17 at 15:36 -0600, Jim Fehlig wrote: Eric Blake wrote: On 06/17/2014 09:24 AM, Ian Campbell wrote: In addition to extra= xm supported a root= option which was supposed to be incorporated into the final command line. Handle that for virsh domxml-from-native xen-xm.

Re: [libvirt] [PATCH 11/12] Expose IOMMU and VFIO capabilities from virCaps

2014-06-18 Thread Michal Privoznik
On 30.05.2014 11:11, Daniel P. Berrange wrote: On Thu, May 29, 2014 at 10:32:45AM +0200, Michal Privoznik wrote: This piece of information may be useful for management application to decide if a domain with a device passthrough can be started on given host or not. Signed-off-by: Michal

Re: [libvirt] [PATCH 0/2] virsh: man: Tweak some old docs problems

2014-06-18 Thread Ján Tomko
On 06/18/2014 11:28 AM, Peter Krempa wrote: Peter Krempa (2): virsh: man: Fix examples and docs for virsh version virsh: man: Correctly spell QEMU tools/virsh.pod | 29 + 1 file changed, 17 insertions(+), 12 deletions(-) ACK signature.asc Description:

Re: [libvirt] [PATCH 11/12] Expose IOMMU and VFIO capabilities from virCaps

2014-06-18 Thread Daniel P. Berrange
On Wed, Jun 18, 2014 at 11:51:51AM +0200, Michal Privoznik wrote: On 30.05.2014 11:11, Daniel P. Berrange wrote: diff --git a/src/conf/capabilities.c b/src/conf/capabilities.c index 9561ba3..a91f37b 100644 --- a/src/conf/capabilities.c +++ b/src/conf/capabilities.c @@ -901,6 +901,10 @@

Re: [libvirt] [PATCH 0/2] virsh: man: Tweak some old docs problems

2014-06-18 Thread Peter Krempa
On 06/18/14 12:06, Ján Tomko wrote: On 06/18/2014 11:28 AM, Peter Krempa wrote: Peter Krempa (2): virsh: man: Fix examples and docs for virsh version virsh: man: Correctly spell QEMU tools/virsh.pod | 29 + 1 file changed, 17 insertions(+), 12 deletions(-)

Re: [libvirt] [PATCH v4] Only set SELinux seclabel if supported by the host.

2014-06-18 Thread Cedric Bosdonnat
On Wed, 2014-06-18 at 11:11 +0200, Christophe Fergeau wrote: Hi, On Tue, Jun 17, 2014 at 04:01:53PM +0200, Cédric Bosdonnat wrote: This code depends on new API in libvirt-gconfig to extract the secmodels handled by the host. --- Diff to v3: * Added yet another missing

Re: [libvirt] NL_RECV RETURNED WITH ERROR: NO BUFFER SPACE AVAILABLE ERROR FOR IXGBE LOAD

2014-06-18 Thread Laine Stump
On 06/17/2014 06:16 AM, vaughan wrote: Hi experts, Release: OL7 Kernel: 3.10.0-121.el7.x86_64 Noticed below error on OL7 server, while loading Intel 10gigabit nic driver module , ixgbe in syslog journal: nl_recv

[libvirt] [PATCH 0/2] fix issues in vbox found by make check on RHEL6

2014-06-18 Thread Pavel Hrdina
Pavel Hrdina (2): tests: fix vbox snapshot xmls vbox_snapshot_conf: fix wrong use of 'xmlSaveFormatFileEnc' src/vbox/vbox_snapshot_conf.c | 2 +- tests/vboxsnapshotxmldata/2disks-1snap.vbox| 292 +++ tests/vboxsnapshotxmldata/2disks-2snap.vbox| 584

[libvirt] [PATCH 2/2] vbox_snapshot_conf: fix wrong use of 'xmlSaveFormatFileEnc'

2014-06-18 Thread Pavel Hrdina
The function 'xmlSaveFormatFileEnc' has a last option to set if you want to format dumped xml with whitespaces or not. Older libxml2, the one used in RHEL6, take this option as it is but newer libxml2 check this option if it's true or not. This small difference somehow makes things messy on RHEL6

Re: [libvirt] [PATCH v7 RFC 0/2] libxl USB prototype and design discussion

2014-06-18 Thread Ian Campbell
On Mon, 2014-06-02 at 14:44 +0100, George Dunlap wrote: == Open questions == Those are things I think I know; there are a couple of pertinent factual questions which I'm not sure of: * Is it possible to specify PVUSB controllers and attach USB devices to them before the guest is up and

Re: [libvirt] [PATCH 1/2] tests: fix vbox snapshot xmls

2014-06-18 Thread Peter Krempa
On 06/18/14 14:29, Pavel Hrdina wrote: On RHEL6 the vboxsnapshotxmltest fails because of wrong xml that is generated by libvirt. However the core issue is in the xml data itself with the wrong indentation. Signed-off-by: Pavel Hrdina phrd...@redhat.com ---

Re: [libvirt] [PATCH 2/2] vbox_snapshot_conf: fix wrong use of 'xmlSaveFormatFileEnc'

2014-06-18 Thread Peter Krempa
On 06/18/14 14:29, Pavel Hrdina wrote: The function 'xmlSaveFormatFileEnc' has a last option to set if you want to format dumped xml with whitespaces or not. Older libxml2, the one used in RHEL6, take this option as it is but newer libxml2 check this option if it's true or not. This small

Re: [libvirt] [PATCH v7 RFC 0/2] libxl USB prototype and design discussion

2014-06-18 Thread George Dunlap
On 06/18/2014 01:57 PM, Ian Campbell wrote: * Is it possible for the toolstack to tell if domU has a working and connected PVUSB front-end? It can observe the state variable being 4 I suppose. Why do you need to know? It might be nice to be able to create both a pv and an emulated controller

Re: [libvirt] [PATCH 2/2] vbox_snapshot_conf: fix wrong use of 'xmlSaveFormatFileEnc'

2014-06-18 Thread Pavel Hrdina
On 18.6.2014 15:11, Peter Krempa wrote: On 06/18/14 14:29, Pavel Hrdina wrote: The function 'xmlSaveFormatFileEnc' has a last option to set if you want to format dumped xml with whitespaces or not. Older libxml2, the one used in RHEL6, take this option as it is but newer libxml2 check this

Re: [libvirt] [PATCH v7 RFC 0/2] libxl USB prototype and design discussion

2014-06-18 Thread George Dunlap
On 06/18/2014 01:57 PM, Ian Campbell wrote: * Is it possible to connect a USB 1.1 device to a PVUSB controller which has been specified 2.0, or would there have to be a separate virtual controller for each? I'm a bit surprised that PVUSB exposes the concept of a version to the FE at all. I

Re: [libvirt] RFC: network interface tags vs. portgroups

2014-06-18 Thread Laine Stump
Ping - any opinions on this? On 06/10/2014 01:01 PM, Laine Stump wrote: A couple releases ago (commit 7d5bf484, first appeared in 1.2.2) I modified the domain interface status xml to show what resources are actually in use for an interface, superseding the interface config in the cases where

[libvirt] [php PATCH] Use long variable type for zend_parse_parameters.

2014-06-18 Thread Dawid Zamirski
This patch fixes a bug where zend_parse_parameters would segfault on certain PHP version (spotted on PHP 5.3.2 64bit) where type specifier is long l and variable reference is int or unsigned int. Changing the variable type from int or unsigned int to long fixes the problem for me and is a known

Re: [libvirt] [PATCH libvirt] xen: handle root= in xen-xm configuration files.

2014-06-18 Thread Jim Fehlig
Ian Campbell wrote: On Tue, 2014-06-17 at 16:24 +0100, Ian Campbell wrote: +if (xenXMConfigGetString(conf, extra, extra, NULL) 0) This was subtly broken. The default needs to be . -8-- From 539412a6deac8b928c82945d692ef20a49535d65 Mon Sep 17 00:00:00 2001 From:

Re: [libvirt] [PATCH python] Correct virDomainMigrateToURI3 definition

2014-06-18 Thread Jason Andryuk
Ping? (Adding Daniel Veillard, listed as owner for libvirt-python.git, as this was previously just sent to the list.) On 6/5/2014 11:43 AM, Jason Andryuk wrote: dconnuri is a string, so update the definition to match. Without this, the generated python would fail when passed a string. ---

Re: [libvirt] [PATCH] Valid pool format type for logical volume pool should be auto and lvm2

2014-06-18 Thread John Ferlan
On 06/18/2014 03:25 AM, Shanzhi Yu wrote: The logical volume pool supports formats auto and lvm2 Signed-off-by: Shanzhi Yu s...@redhat.com --- src/conf/storage_conf.c | 2 +- src/conf/storage_conf.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [libvirt] [php PATCH] Use long variable type for zend_parse_parameters.

2014-06-18 Thread Michal Novotny
Hi Dawid, I've applied it to the libvirt-php git repository. See: http://libvirt.org/git/?p=libvirt-php.git;a=commit;h=d3b3afa7d37541984d1e80e4ab46cd3e582ea60d Thanks, Michal 2014-06-18 19:11 GMT+02:00 Dawid Zamirski dzamir...@dattobackup.com: 2014-06-18 19:11 GMT+02:00 Dawid Zamirski

[libvirt] [php PATCH] Fix compiler warnings after int to long conversion

2014-06-18 Thread Dawid Zamirski
The previous patch [1] caused compiler warnings after variable types were changed from int to long and this patch fixes this. [1] https://www.redhat.com/archives/libvir-list/2014-June/msg00835.html --- src/libvirt-php.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[libvirt] [python PATCH] build: provide wrapper makefile

2014-06-18 Thread Eric Blake
After years of finger training, I'm so used to 'make check' just working, that I lose quite a bit of time re-learning that in this project, it is spelled 'python setup.py build check'. A shim makefile bridges the gap. * Makefile: New file. Signed-off-by: Eric Blake ebl...@redhat.com --- I'd

Re: [libvirt] [python PATCH] build: provide wrapper makefile

2014-06-18 Thread Nehal J Wani
On Thu, Jun 19, 2014 at 12:51 AM, Eric Blake ebl...@redhat.com wrote: After years of finger training, I'm so used to 'make check' just working, that I lose quite a bit of time re-learning that in this project, it is spelled 'python setup.py build check'. A shim makefile bridges the gap. *

Re: [libvirt] [php PATCH] Fix compiler warnings after int to long conversion

2014-06-18 Thread Michal Novotny
Hi Dawid, thanks for the information. Well, please rebase to the latest commit of my master branch and resend, thanks a lot! Michal 2014-06-18 22:05 GMT+02:00 Dawid Zamirski dzamir...@dattobackup.com: Ugh, now I know what happened - my local master branch has commits I have not sent pull

Re: [libvirt] [PATCH V2 0/2] libxl: support interface type=network

2014-06-18 Thread Jim Fehlig
Jim Fehlig wrote: Patch 1 is a V2 of http://www.redhat.com/archives/libvir-list/2014-June/msg00382.html Patch 2 is a result of Laine's comments to V1. It ensures script is only allowed with interface types ethernet and bridge. Jim Fehlig (2): libxl: support interface type=network

[libvirt] [PATCH] Initial implementation of new job control api

2014-06-18 Thread Tucker DiNapoli
This is my initial definition of a new internal job control api. I am working on this as a part of the google summer of code. These patches contain the core job control api and deal only with managing individual jobs. I am currently working on writing code using this api to manage jobs in domains,

Re: [libvirt] [php PATCH] Fix compiler warnings after int to long conversion

2014-06-18 Thread Dawid Zamirski
On Wed, 2014-06-18 at 22:50 +0200, Michal Novotny wrote: Hi Dawid, thanks for the information. Well, please rebase to the latest commit of my master branch and resend, thanks a lot! Michal Ok, now I'm puzzled. I've rebased the patch from clean master and the diff ended up identical to

[libvirt] [PATCH v3] blockjob: use stable disk string in job event

2014-06-18 Thread Eric Blake
When the block job event was first added, it was for block pull, where the active layer of the disk remains the same name. It was also in a day where we only cared about local files, and so we always had a canonical absolute file name. But two things have changed since then: we now have network

[libvirt] [python PATCH 1/2] blockjob: support new BLOCK_JOB_2 event

2014-06-18 Thread Eric Blake
Libvirt 1.2.6 is introducing a new block job event that passes disk information by target device rather than host file name. At the python level, we are just a passthrough, so we can reuse all the existing code and just wire up the new enum value. * libvirt-override-virConnect.py

[libvirt] [python PATCH 2/2] event-test: add missing events

2014-06-18 Thread Eric Blake
Update the example to be able to trace all events. * examples/event-test.py (main): Match full list of domain events. (myDomainEventIOErrorReasonCallback) (myDomainEventControlErrorCallback) (myDomainEventBlockJobCallback, myDomainEventBlockJob2Callback) (blockJobTypeToString,

Re: [libvirt] [PATCH libvirt] xen: handle root= in xen-xm configuration files.

2014-06-18 Thread Eric Blake
On 06/18/2014 11:46 AM, Jim Fehlig wrote: In addition to extra= xm supported a root= option which was supposed to be incorporated into the final command line. Handle that for virsh domxml-from-native xen-xm. Tested with the libxl backend. Signed-off-by: Ian Campbell ian.campb...@citrix.com

[libvirt] [PATCH v3 2/5] blockjob: turn on qemu capability bit for active commit

2014-06-18 Thread Eric Blake
Use the probing functionality added in the last patch to turn on a capability bit when active commit is present, and gate active commit on that capability. While at it, leave a few more bread-crumbs about what blockjob sync/async means, and enforce that sync cancel is only ever encountered with

[libvirt] [PATCH v3 1/5] blockjob: allow omitted arguments to QMP block-commit

2014-06-18 Thread Eric Blake
We are about to turn on support for active block commit. Although qemu 2.0 was the first version to mostly support it, that version mis-handles 0-length files, and doesn't have anything available for easy probing. But qemu 2.1 fixed bugs, and made life simpler by letting the 'top' argument be

[libvirt] [PATCH v3 4/5] blockcommit: track job type in xml

2014-06-18 Thread Eric Blake
A future patch is going to wire up qemu active block commit jobs; but as they have similar events and are canceled/pivoted in the same way as block copy jobs, it is easiest to track all bookkeeping for the commit job by reusing the mirror element. This patch adds domain XML to track which job was

[libvirt] [PATCH v3 0/5] Next round of active commit support

2014-06-18 Thread Eric Blake
Browseable at: http://repo.or.cz/w/libvirt/ericb.git/shortlog/refs/heads/gluster or git checkout git://repo.or.cz/libvirt/ericb.git gluster Resolves some of the review comments, and in particular FINALLY turns on capability probing. However, I can't push this to libvirt until Jeff's patch

[libvirt] [PATCH v3 3/5] virsh: expose new active commit controls

2014-06-18 Thread Eric Blake
Add knobs to virsh to manage a 2-phase active commit of the top layer, similar to knobs already present on blockcopy. While this code will fail until later patches actually implement the new knobs in the qemu driver, doing it now proves that the API is usable and also makes it easier for testing

[libvirt] [PATCH v3 5/5] blockcommit: turn on active commit

2014-06-18 Thread Eric Blake
With this in place, I can (finally!) now do: virsh blockcommit $dom vda --shallow --verbose --pivot and watch qemu shorten the backing chain by one, followed by libvirt automatically updating the dumpxml output, effectively undoing the work of virsh snapshot-commit --no-metadata --disk-only.