Plan is to get the new release on Friday Aug 1st, so
I think this mean entering freeze at some point on the
preceeding week-end, I will be travelling then, but I
should be able to do that at some point saturday 26.
We already have 180 commits in since 1.2.6 so deinitely
makes sense to push
On Thu, Jul 17, 2014 at 13:29:52 +1000, Sam Bobroff wrote:
On 17/07/14 12:50, Eric Blake wrote:
On 07/16/2014 07:52 PM, Sam Bobroff wrote:
Hello everyone,
[Can you configure your mailer to wrap long lines?]
[No problem, done.]
After performing a migration, the syslog often
On 07/16/2014 04:42 PM, Martin Kletzander wrote:
v3 of https://www.redhat.com/archives/libvir-list/2014-July/msg00372.html
v3:
- Michal's suggestions worked in
- rebased on current master
Martin Kletzander (16):
qemu: purely a code movement
qemu: remove useless error check
On 07/17/2014 08:51 AM, Jiri Denemark wrote:
On Thu, Jul 17, 2014 at 13:29:52 +1000, Sam Bobroff wrote:
On 17/07/14 12:50, Eric Blake wrote:
On 07/16/2014 07:52 PM, Sam Bobroff wrote:
Hello everyone,
[Can you configure your mailer to wrap long lines?]
[No problem, done.]
After performing
On 07/16/14 18:54, John Ferlan wrote:
On 07/11/2014 08:20 AM, Peter Krempa wrote:
Version 2 now splits the stuff into separate driver backend funcs.
Peter Krempa (2):
storage: wipe: Move helper code into storage backend
storage: Split out volume wiping as separate backend function
On Thu, 2014-07-17 at 14:51 +0800, Daniel Veillard wrote:
Plan is to get the new release on Friday Aug 1st, so
I think this mean entering freeze at some point on the
preceeding week-end, I will be travelling then, but I
should be able to do that at some point saturday 26.
We already have
On Wed, Jul 16, 2014 at 08:29:58PM +0200, Martin Kletzander wrote:
First FD is the RW unix socket to listen on, second one (if
applicable) is the RO unix socket.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
daemon/libvirtd.c | 45 +++--
On Wed, Jul 16, 2014 at 01:00:30PM -0600, Eric Blake wrote:
Furthermore, I'm trying to figure out how to advertise whether a given
domain will support active commit (and similarly, Peter's patches for
relative backing name preservation). Advertising the feature just
through 'virsh
On 16.07.2014 21:00, Eric Blake wrote:
We have some inconsistencies in the node capabilities (which shows guest
capabilities for some default binaries) and domcapabilities (which shows
guest capabilities for a specified binary). It might be nicer for
client applications if the two XML
On Thu, Jul 17, 2014 at 09:40:12AM +0100, Daniel P. Berrange wrote:
On Wed, Jul 16, 2014 at 08:29:58PM +0200, Martin Kletzander wrote:
First FD is the RW unix socket to listen on, second one (if
applicable) is the RO unix socket.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
On Thu, Jul 17, 2014 at 11:05:08AM +0200, Michal Privoznik wrote:
# tools/virsh domcapabilities --virttype kvm
error: failed to get emulator capabilities
error: invalid argument: at least one of emulatorbin or architecture
fields must be present
Would it be nicer to behave the same as
Up to now, users have to pass two arguments at least: domain virt type
('qemu' vs 'kvm') and one of emulatorbin or architecture. This is not
much user friendly. Nowadays users mostly use KVM and share the host
architecture with the guest. So now, the API (and subsequently virsh
command) can be
On 17.07.2014 11:11, Daniel P. Berrange wrote:
On Thu, Jul 17, 2014 at 11:05:08AM +0200, Michal Privoznik wrote:
# tools/virsh domcapabilities --virttype kvm
error: failed to get emulator capabilities
error: invalid argument: at least one of emulatorbin or architecture
fields must be present
On Thu, Jul 17, 2014 at 11:12:05AM +0200, Michal Privoznik wrote:
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 33541d3..7d99435 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -16849,17 +16849,17 @@ qemuConnectGetDomainCapabilities(virConnectPtr conn,
Before:
virsh # dominfo chx3
State: shut off
Max memory: 92160 KiB
Used memory:92160 KiB
After:
virsh # dominfo container1
State: shut off
Max memory: 92160 KiB
Used memory:0 KiB
Similar to qemu cases.
Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com
---
On 16.07.2014 23:05, Jim Fehlig wrote:
Stefan Bader wrote:
being as bad with timely responses. Ok, so how about the following?
One note: it could be the STRDUP's are not strictly needed. But
to me it felt wrong to have two places refer to the same strings
(as MakeVFB copies the struct
On Tue, May 20, 2014 at 11:17:32AM +0200, Martin Kletzander wrote:
On Wed, May 14, 2014 at 08:23:21AM +, Wangrui (K) wrote:
Hi,
Libvirt does not support ivshmem(Inter-VM Shared Memory) device recently,
thus, I would like to know if there's any plan to support it in the future?
If not, I
Coverity complains about the return value of ioctl not being checked.
Even though we carry on when this fails (just like qemu-img does),
we can log an error.
---
src/storage/storage_backend.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git
Coverity flagged this commit see below...
On 07/15/2014 04:49 AM, Chunyan Liu wrote:
Add 'nocow' to storage volume xml so that user can have an option
to set NOCOW flag to the newly created volume. It's useful on btrfs
file system to enhance performance.
Btrfs has low performance
On 07/17/2014 06:22 AM, Ján Tomko wrote:
Coverity complains about the return value of ioctl not being checked.
Even though we carry on when this fails (just like qemu-img does),
we can log an error.
---
src/storage/storage_backend.c | 9 +++--
1 file changed, 7 insertions(+), 2
On 07/16/2014 03:53 PM, Michal Privoznik wrote:
There's this question on the list that is asked over and over again.
How do I get {cpu, memory, ...} usage in percentage? Or its modified
version: How do I plot nice graphs like virt-manager does?
It would be nice if we have an example to
On 07/17/2014 01:54 PM, John Ferlan wrote:
On 07/17/2014 06:22 AM, Ján Tomko wrote:
Coverity complains about the return value of ioctl not being checked.
Even though we carry on when this fails (just like qemu-img does),
we can log an error.
---
src/storage/storage_backend.c | 9
Decisions whether qemu driver and libvirt-daemon-{qemu,kvm} packages
should be built on various OS/arch combinations were scattered around
the spec file. Let's make it easier to see where qemu driver is going to
be built.
Signed-off-by: Jiri Denemark jdene...@redhat.com
---
libvirt.spec.in | 52
On 07/17/2014 03:05 AM, Michal Privoznik wrote:
Furthermore, I'm trying to figure out how to advertise whether a given
domain will support active commit (and similarly, Peter's patches for
relative backing name preservation). Advertising the feature just
through 'virsh capabilities' is
Test also the TITLE and DESCRIPTION metadata types.
---
tests/metadatatest.c | 64
1 file changed, 64 insertions(+)
diff --git a/tests/metadatatest.c b/tests/metadatatest.c
index 91fc944..a8d8f10 100644
--- a/tests/metadatatest.c
+++
On 07/17/2014 08:32 AM, Peter Krempa wrote:
s/coverate/coverage/ in the title
Test also the TITLE and DESCRIPTION metadata types.
---
tests/metadatatest.c | 64
1 file changed, 64 insertions(+)
ACK - more testing is always good
--
On 07/17/2014 08:22 AM, Jiri Denemark wrote:
Decisions whether qemu driver and libvirt-daemon-{qemu,kvm} packages
should be built on various OS/arch combinations were scattered around
the spec file. Let's make it easier to see where qemu driver is going to
be built.
Signed-off-by: Jiri
On 07/17/14 17:03, Eric Blake wrote:
On 07/17/2014 08:32 AM, Peter Krempa wrote:
s/coverate/coverage/ in the title
Test also the TITLE and DESCRIPTION metadata types.
---
tests/metadatatest.c | 64
1 file changed, 64 insertions(+)
On 07/16/14 17:31, Nehal J Wani wrote:
cmd = virCommandNew(dnsmasqCapsGetBinaryPath(caps));
virCommandAddArgFormat(cmd, --conf-file=%s, configfile);
-virCommandAddArgFormat(cmd, --dhcp-script=%s, leaseshelper_path);
+virCommandAddArgFormat(cmd, --dhcp-script=%s,
On 07/17/14 01:35, John Ferlan wrote:
Commit id '0e2d7305' modified the code to allow a negative value to be
supplied for the bandwidth argument of the various block virsh commands
Technically that commit didn't allow it. It was allowed before that
commit kept it in that same state.
and the
On 07/17/14 01:35, John Ferlan wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1087104
Commit id 'c6212539' explicitly allowed a negative value to be used for
offset and length as a shorthand for the largest value after commit id
'f18c02ec' modified virStrToLong_ui() to essentially
My concerns are whether this will work in the case you already used the
leases helper as the patch is adding a few fields to the stored format.
In this patch, I am only adding server-duid as an extra JSON object. I
am not adding more fields to an existing JSON object. The old leases
file will
Up to now, domains are either backed by an arbitrary huge page but without any
NUMA awareness. This is suboptimal and I'm trying to fix it.
Michal Privoznik (7):
configure: Check for statfs
Introduce virFileFindHugeTLBFS
qemu: Utilize virFileFindHugeTLBFS
virbitmap: Introduce
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
.../qemuxml2argv-hugepages-pages2.args | 10 ++
.../qemuxml2argv-hugepages-pages2.xml | 38 ++
.../qemuxml2argv-hugepages-pages3.args | 9 +
This should iterate over mount tab and search for hugetlbfs among with
looking for the default value of huge pages.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/libvirt_private.syms | 1 +
src/util/virfile.c | 155 +++
This internal API just checks if two bitmaps intersect or not.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/libvirt_private.syms | 1 +
src/util/virbitmap.c | 20
src/util/virbitmap.h | 3 +++
tests/virbitmaptest.c| 26 ++
The statfs(2) gets filesystem statistics. Currently, we use it only on
linux, and leave stub to implement on other platforms. But hey, other
platforms (like FreeBSD) have statfs() too. If we check it in
configure we can wider platforms supported. Speaking of FreeBSD, the
headers to include are of
memoryBacking
hugepages
page size=1 unit=G nodeset=0-3,5/
page size=2 unit=M nodeset=4/
/hugepages
/memoryBacking
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
docs/formatdomain.html.in | 18 +-
docs/schemas/domaincommon.rng
Use better detection of hugetlbfs mount points. Yes, there can be
multiple mount points each serving different huge page size.
Since we already have ability to override the mount point in the
qemu.conf file, this crazy backward compatibility code is brought in.
Now we allow multiple mount points,
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/qemu/qemu_capabilities.c | 2 +
src/qemu/qemu_capabilities.h | 1 +
src/qemu/qemu_command.c| 91 +++---
.../qemuxml2argv-hugepages-pages.args
On 07/17/2014 09:25 AM, Peter Krempa wrote:
On 07/17/14 01:35, John Ferlan wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1087104
Commit id 'c6212539' explicitly allowed a negative value to be used for
offset and length as a shorthand for the largest value after commit id
'f18c02ec'
On 07/17/2014 09:18 AM, Peter Krempa wrote:
A second issue that comes into my mind is compatibility with already
existing files. Does this work when you already have a lease file? (I
didn't try it, I'm just asking).
If we use the --leasefile-ro option, then although this method will
work,
Martin Kletzander wrote:
There were numerous places where numatune configuration (and thus
domain config as well) was changed in different ways. On some
places this even resulted in persistent domain definition not to be
stable (it would change with daemon's restart).
In order to
Roman Bogorodskiy wrote:
Martin Kletzander wrote:
There were numerous places where numatune configuration (and thus
domain config as well) was changed in different ways. On some
places this even resulted in persistent domain definition not to be
stable (it would change with
On 07/17/2014 10:57 AM, Roman Bogorodskiy wrote:
Roman Bogorodskiy wrote:
Looks like this breaks build with clang:
gmake[3]: Entering directory `/usr/home/novel/code/libvirt/src'
CC util/libvirt_util_la-virclosecallbacks.lo
In file included from util/virclosecallbacks.c:28:
In
On 07/17/2014 01:37 AM, Ján Tomko wrote:
On 07/16/2014 04:42 PM, Martin Kletzander wrote:
v3 of https://www.redhat.com/archives/libvir-list/2014-July/msg00372.html
This series broke the build for me (clang 3.4.1):
In file included from util/virclosecallbacks.c:28:
In file included from
On 07/16/2014 07:35 PM, John Ferlan wrote:
Following up to the recently restarted discussion:
http://www.redhat.com/archives/libvir-list/2014-July/msg00686.html
regarding negative values for certain virsh commands - these patches
will document the feature of using a negative value to
Eric Blake wrote:
On 07/17/2014 10:57 AM, Roman Bogorodskiy wrote:
Roman Bogorodskiy wrote:
Looks like this breaks build with clang:
gmake[3]: Entering directory `/usr/home/novel/code/libvirt/src'
CC util/libvirt_util_la-virclosecallbacks.lo
In file included from
https://bugzilla.redhat.com/show_bug.cgi?id=1091866
Add a new boolean 'sparse'. This will be used by the logical backend
storage driver to determine whether the target volume is sparse or not
(also known by a snapshot or thin logical volume). Although setting sparse
to true at creation could be
Rather than a unsigned int, use a 'bool' since that's how it was used.
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/conf/storage_conf.h | 2 +-
src/storage/storage_driver.c | 8
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/conf/storage_conf.h
The first patch just changes 'building' into a bool as that's how I
found it used when going to add a new bool for patch 2
Patch 2 addresses the following bz:
https://bugzilla.redhat.com/show_bug.cgi?id=1091866
Essentially, wiping the lv caused it to disappear after a vol-refresh.
This was
On 07/17/2014 12:10 PM, John Ferlan wrote:
Rather than a unsigned int, use a 'bool' since that's how it was used.
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/conf/storage_conf.h | 2 +-
src/storage/storage_driver.c | 8
2 files changed, 5 insertions(+), 5
On 07/17/2014 12:10 PM, John Ferlan wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1091866
Add a new boolean 'sparse'. This will be used by the logical backend
storage driver to determine whether the target volume is sparse or not
(also known by a snapshot or thin logical volume).
2014-07-17 0:25 GMT+02:00 Geoff Hickey ghic...@datagravity.com:
Update the VSphere version comment in esx_vi.c for ESX 5.1 and 5.5.
---
src/esx/esx_vi.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
ACK and pushed!
--
Matthias Bolte
http://photron.blogspot.com
--
On 07/16/2014 08:27 AM, Eric Blake wrote:
On 07/16/2014 07:53 AM, Michal Privoznik wrote:
There's this question on the list that is asked over and over again.
How do I get {cpu, memory, ...} usage in percentage? Or its modified
version: How do I plot nice graphs like virt-manager does?
It
On 07/16/2014 04:34 AM, Ján Tomko wrote:
Replace all three-state (default/yes/no) enums with it:
virDomainBootMenu
virDomainPMState
virDomainGraphicsSpiceClipboardCopypaste
virDomainGraphicsSpiceAgentFileTransfer
virNetworkDNSForwardPlainNames
virDomainBIOSUseserial
Too.
---
On 07/17/2014 02:10 PM, John Ferlan wrote:
John Ferlan (2):
storage: Convert 'building' into a bool
storage: Disallow vol_wipe for sparse logical volumes
src/conf/storage_conf.h | 2 +-
src/storage/storage_backend_logical.c | 39
++-
Stefan Bader wrote:
On 16.07.2014 23:05, Jim Fehlig wrote:
While testing this, I noticed that libvirt will set vram to 9216 if not
specified. E.g.
# cat test.xml
...
video
model type='vga'/
/video
...
# virsh define test.xml
# virsh dumpxml test
...
video
On Tue, Jul 15, 2014 at 11:42 PM, Zeeshan Ali (Khattak)
zeesha...@gnome.org wrote:
v3: Two classes for CPU model:
* CapabilitiesCpuModel
* DomainCpuModel that derives from CapabilitiesCpuModel.
Ping! I need these patches to fix the broken case of non-kvm in Boxes
in a nice way:
Implement virMutexInitInternal, virRWLockInitInternal and virCondInitInternal
which include error message reporting.
int virMutexInitInternal(virMutexPtr mutex, bool recursive, bool quite,
const char *filename, const char *funcname,
size_t linenr)
Implement InitInternal functions for Mutex, RWLock and Cond, these functions
contain error report using virReportSystemErrorFull, it is controlled by
an argument 'quite'.
The related macros are Init and InitQuite, they call InitInternal function
by passing 'false' or 'true' to quite argument.
Signed-off-by: Jincheng Miao jm...@redhat.com
---
daemon/remote.c | 1 -
src/conf/interface_conf.c | 2 --
src/conf/network_conf.c | 2 --
src/conf/node_device_conf.c | 2 --
src/conf/nwfilter_conf.c| 2 --
src/conf/object_event.c
62 matches
Mail list logo
