Re: [libvirt] [PATCH] Clear bandwidth settings for a shutoff domain using domiftune

2014-08-12 Thread jiahu
On 08/11/2014 06:05 PM, Michal Privoznik wrote: On 11.08.2014 08:41, Jianwei Hu wrote: qemu: To clear bandwidth settings for a shutoff domain by using domiftune. After applying this patch, we can use virsh domiftune command to clear inbound or/and outbound setting for a shutoff domain.

Re: [libvirt] [PATCH v2 libvirt 1/8] conf: add model child element to filesystem

2014-08-12 Thread Wang Rui
On 2014/8/11 22:47, Giuseppe Scrivano wrote: @@ -6458,6 +6463,7 @@ virDomainFSDefParseXML(xmlNodePtr node, virDomainFSDefPtr def; xmlNodePtr cur, save_node = ctxt-node; char *type = NULL; +char *model = NULL; char *fsdriver = NULL; char *source = NULL;

Re: [libvirt] [PATCH 1/1] qemu: min_guarantee: Parameter 'min_guarantee' not supported

2014-08-12 Thread Wang Rui
On 2014/8/11 18:07, Erik Skultety wrote: The 'min_guarantee' is used by esx and vmx drivers, with qemu however, libvirt should report error when starting a domain, because this element is not used. Resolves https://bugzilla.redhat.com/show_bug.cgi?id=1122455 --- The idea seems good. I

Re: [libvirt] [RFC][scale] new API for querying domains stats

2014-08-12 Thread Richard W.M. Jones
On Tue, Aug 05, 2014 at 01:36:02PM +0800, Li Wei wrote: Hi Richard, Thanks for your comment! On 08/04/2014 04:39 PM, Richard W.M. Jones wrote: On Mon, Aug 04, 2014 at 11:38:41AM +0800, Li Wei wrote: Hi, On 07/22/2014 03:25 PM, Richard W.M. Jones wrote: Did anything come of this

Re: [libvirt] [PATCH RFC] LXC: add HOME environment variable

2014-08-12 Thread Richard Weinberger
On Mon, Aug 11, 2014 at 11:13 AM, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Aug 05, 2014 at 02:40:53AM +, chenhanx...@cn.fujitsu.com wrote: ping -Original Message- From: libvir-list-boun...@redhat.com [mailto:libvir-list-boun...@redhat.com] On Behalf Of Chen

Re: [libvirt] Verifying libvirt release tarballs

2014-08-12 Thread Daniel P. Berrange
On Mon, Aug 11, 2014 at 11:40:11PM +0200, Richard Weinberger wrote: Hi! How can I cryptographically verify libvirt releases? There are no signature/hash files in http://libvirt.org/sources/. All I see is that your git release tags are PGP signed. So, anyone who cares has to ignore

Re: [libvirt] [PATCH RFC] LXC: add HOME environment variable

2014-08-12 Thread Daniel P. Berrange
On Tue, Aug 12, 2014 at 11:21:41AM +0200, Richard Weinberger wrote: On Mon, Aug 11, 2014 at 11:13 AM, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Aug 05, 2014 at 02:40:53AM +, chenhanx...@cn.fujitsu.com wrote: ping -Original Message- From:

Re: [libvirt] [libvirt-glib] [PATCH 3/4] GVirDomainSnapshot: Add _set_config

2014-08-12 Thread Zeeshan Ali (Khattak)
On Thu, Aug 7, 2014 at 12:03 PM, Himanshu Sharma himanshu.sha...@nectechnologies.in wrote: You have any idea how I can clone VM of ESXi from libvirt? Can you please ask in a separate thread (an new email with an appropriate subject line) you exact questions on this list? There are good chances

[libvirt] [PATCH 0/3] Fix libvirtd crash when starting two managedsave operations on a single domain

2014-08-12 Thread Peter Krempa
We had an unfortunate code path where when you'd start two managedsave operations simultaneously libvirtd would crash. Fix it by adding a VM liveness check. Peter Krempa (3): qemu: managedsave: Check that VM is alive after entering async job security: selinux: Set saved state label only if

[libvirt] [PATCH 1/3] qemu: managedsave: Check that VM is alive after entering async job

2014-08-12 Thread Peter Krempa
Saving a shutoff VM doesn't make sense (and has suboptimal effects on stability of the libvirt daemon). Check that the domain is alive after entering the save async job. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1129207 --- src/qemu/qemu_driver.c | 6 ++ 1 file changed, 6

[libvirt] [PATCH 2/3] security: selinux: Set saved state label only if it is available

2014-08-12 Thread Peter Krempa
Check that secdef-imagelabel exists before blindly applying it. --- src/security/security_selinux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c index c078cab..cf59d6c 100644 ---

[libvirt] [PATCH 3/3] qemu: migration: Check domain live state after exitting the monitor

2014-08-12 Thread Peter Krempa
In qemuMigrationToFile we enter the monitor multiple times and don't check if the VM is still alive after returning form the monitor. Add the checks to skip pieces of code in case the VM crashes while saving it's state. --- src/qemu/qemu_migration.c | 19 +-- 1 file changed, 17

[libvirt] [PATCH 1/2] libvirtd: conf: Mention support for logging into journald

2014-08-12 Thread Peter Krempa
Our docs didn't mention the explicit option to log into journald. --- daemon/libvirtd.conf | 2 ++ 1 file changed, 2 insertions(+) diff --git a/daemon/libvirtd.conf b/daemon/libvirtd.conf index e5856d4..c73423f 100644 --- a/daemon/libvirtd.conf +++ b/daemon/libvirtd.conf @@ -342,6 +342,8 @@ #

[libvirt] [PATCH 2/2] daemon: Limit default log level to journald to VIR_LOG_INFO

2014-08-12 Thread Peter Krempa
Libvirt is really chatty when the DEBUG log level is enabled. When a host uses journald we'd enable debug logging to journald when only specifying the debug log level. As journald may employ rate throttling this would lock up the daemon until it's able to flush all debug messages. This patch

[libvirt] [PATCH 0/2] journald logging rate limit fix

2014-08-12 Thread Peter Krempa
Peter Krempa (2): libvirtd: conf: Mention support for logging into journald daemon: Limit default log level to journald to VIR_LOG_INFO daemon/libvirtd.c| 10 +- daemon/libvirtd.conf | 6 ++ 2 files changed, 15 insertions(+), 1 deletion(-) -- 2.0.2 -- libvir-list mailing

Re: [libvirt] [PATCH 0/2] journald logging rate limit fix

2014-08-12 Thread Ján Tomko
On 08/12/2014 04:34 PM, Peter Krempa wrote: Peter Krempa (2): libvirtd: conf: Mention support for logging into journald daemon: Limit default log level to journald to VIR_LOG_INFO daemon/libvirtd.c| 10 +- daemon/libvirtd.conf | 6 ++ 2 files changed, 15

Re: [libvirt] [PATCHv3] numatune: Fix parsing of empty nodeset (0, ^0)

2014-08-12 Thread Ján Tomko
On 08/11/2014 04:06 PM, Erik Skultety wrote: Resolves https://bugzilla.redhat.com/show_bug.cgi?id=1121837 --- src/util/virbitmap.c | 3 +++ ...emuxml2argv-numatune-memory-invalid-nodeset.xml | 31 ++ tests/qemuxml2argvtest.c

Re: [libvirt] [RFC][scale] new API for querying domains stats

2014-08-12 Thread Francesco Romani
- Original Message - From: Richard W.M. Jones rjo...@redhat.com To: Li Wei l...@cn.fujitsu.com Cc: Francesco Romani from...@redhat.com, libvir-list@redhat.com Sent: Tuesday, August 12, 2014 11:04:05 AM Subject: Re: [libvirt] [RFC][scale] new API for querying domains stats [...]

Re: [libvirt] [PATCH 3/3] qemu: migration: Check domain live state after exitting the monitor

2014-08-12 Thread Ján Tomko
On 08/12/2014 03:44 PM, Peter Krempa wrote: In qemuMigrationToFile we enter the monitor multiple times and don't check if the VM is still alive after returning form the monitor. Add the checks to skip pieces of code in case the VM crashes while saving it's state. ---

Re: [libvirt] [PATCH 2/3] security: selinux: Set saved state label only if it is available

2014-08-12 Thread Ján Tomko
On 08/12/2014 03:44 PM, Peter Krempa wrote: Check that secdef-imagelabel exists before blindly applying it. --- src/security/security_selinux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c index

Re: [libvirt] [PATCH 1/3] qemu: managedsave: Check that VM is alive after entering async job

2014-08-12 Thread Ján Tomko
On 08/12/2014 03:44 PM, Peter Krempa wrote: Saving a shutoff VM doesn't make sense (and has suboptimal effects on stability of the libvirt daemon). Check that the domain is alive after Saying it 'crashes' is more readable IMHO. entering the save async job. Resolves:

Re: [libvirt] [PATCH 1/1] qemu: min_guarantee: Parameter 'min_guarantee' not supported

2014-08-12 Thread Ján Tomko
On 08/11/2014 12:07 PM, Erik Skultety wrote: The 'min_guarantee' is used by esx and vmx drivers, with qemu however, libvirt should report error when starting a domain, because this element is not used. Resolves https://bugzilla.redhat.com/show_bug.cgi?id=1122455 --- src/qemu/qemu_process.c

[libvirt] [PATCH] qemu: process: Fix header format of qemuProcessSetVcpuAffinities

2014-08-12 Thread Peter Krempa
Fix header alignment and remove the unused conn parameter. --- Notes: Pushed as trivial. src/qemu/qemu_process.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 407da5e..9e6a9ae 100644 ---

Re: [libvirt] [PATCH 10/66] vbox: Rewrite vboxConnectGetCapabilities

2014-08-12 Thread Michal Privoznik
On 11.08.2014 12:06, Taowei wrote: --- src/vbox/vbox_common.c| 11 +++ src/vbox/vbox_tmpl.c | 16 ++-- src/vbox/vbox_uniformed_api.h |1 + 3 files changed, 18 insertions(+), 10 deletions(-) diff --git a/src/vbox/vbox_common.c

Re: [libvirt] [PATCH 14/66] vbox: Rewrite vboxDomainLookupByUUID

2014-08-12 Thread Michal Privoznik
On 11.08.2014 12:06, Taowei wrote: --- src/vbox/vbox_common.c| 73 + src/vbox/vbox_tmpl.c | 73 - src/vbox/vbox_uniformed_api.h |2 ++ 3 files changed, 75 insertions(+), 73 deletions(-)

Re: [libvirt] [PATCH 45/66] vbox: Rewrite vboxDomainAttachDeviceFlags

2014-08-12 Thread Michal Privoznik
On 11.08.2014 12:06, Taowei wrote: --- src/vbox/vbox_common.c| 14 ++ src/vbox/vbox_tmpl.c | 15 --- src/vbox/vbox_uniformed_api.h |2 ++ 3 files changed, 16 insertions(+), 15 deletions(-) diff --git a/src/vbox/vbox_common.c

Re: [libvirt] [PATCH 00/66] vbox: Rewrite vbox domain driver

2014-08-12 Thread Michal Privoznik
On 11.08.2014 12:06, Taowei wrote: This series of patches rewrite the vbox's domain driver. The driver is separated into two parts: the version specified and the common part. The common driver use vboxUniformedAPI to build a general driver for all vbox versions. The vboxUniformedAPI take the

Re: [libvirt] [PATCH 2/3] security: selinux: Set saved state label only if it is available

2014-08-12 Thread Peter Krempa
On 08/12/14 17:17, Ján Tomko wrote: On 08/12/2014 03:44 PM, Peter Krempa wrote: Check that secdef-imagelabel exists before blindly applying it. --- src/security/security_selinux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/security/security_selinux.c

Re: [libvirt] [PATCH 3/3] qemu: migration: Check domain live state after exitting the monitor

2014-08-12 Thread Peter Krempa
On 08/12/14 17:17, Ján Tomko wrote: On 08/12/2014 03:44 PM, Peter Krempa wrote: In qemuMigrationToFile we enter the monitor multiple times and don't check if the VM is still alive after returning form the monitor. Add the checks to skip pieces of code in case the VM crashes while saving it's

Re: [libvirt] [PATCH v2] storage: ZFS support

2014-08-12 Thread Roman Bogorodskiy
Ján Tomko wrote: On 07/26/2014 06:13 PM, Roman Bogorodskiy wrote: Implement ZFS storage backend driver. Currently supported only on FreeBSD because of ZFS limitations on Linux. --- configure.ac | 43 + docs/schemas/storagepool.rng | 20 +++

[libvirt] [PATCH] bhyve: fix error message in bhyveStateInitialize

2014-08-12 Thread Dmitry Guryanov
If we failed to create BHYVE_STATE_DIR, we should show this path, not BHYVE_LOG_DIR. --- src/bhyve/bhyve_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c index 135cb24..eb8f9af 100644 --- a/src/bhyve/bhyve_driver.c

[libvirt] [PATCH] qemu_conf: Undefine the correct symbol

2014-08-12 Thread Michal Privoznik
At the beginning of the qemu config file parsing function there are 3 helper macros defined: GET_VALUE_BOOL, GET_VALUE_LONG and GET_VALUE_STR. Later, when they are no longer needed they are undefined in order to keep the namespace clean. However, the GET_VALUE_STRING is undefined instead of

Re: [libvirt] [PATCH] bhyve: fix error message in bhyveStateInitialize

2014-08-12 Thread Roman Bogorodskiy
Dmitry Guryanov wrote: If we failed to create BHYVE_STATE_DIR, we should show this path, not BHYVE_LOG_DIR. --- src/bhyve/bhyve_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c index 135cb24..eb8f9af 100644

Re: [libvirt] [PATCH V5 01/12] src/xenxs: Export code for reuse

2014-08-12 Thread Eric Blake
On 08/11/2014 11:20 PM, Jim Fehlig wrote: Kiarie Kahurani wrote: wrap code tagged for resuse into one function and export it Signed-off-by: Kiarie Kahurani davidkiar...@gmail.com --- src/xenxs/xen_xm.c | 73 +++--- src/xenxs/xen_xm.h | 2

Re: [libvirt] [PATCH 2/2] daemon: Limit default log level to journald to VIR_LOG_INFO

2014-08-12 Thread Eric Blake
On 08/12/2014 08:34 AM, Peter Krempa wrote: Libvirt is really chatty when the DEBUG log level is enabled. When a host uses journald we'd enable debug logging to journald when only specifying the debug log level. As journald may employ rate throttling this would lock up the daemon until it's

Re: [libvirt] [PATCH 3/3] qemu: migration: Check domain live state after exitting the monitor

2014-08-12 Thread Eric Blake
On 08/12/2014 07:44 AM, Peter Krempa wrote: s/exitting/exiting/ in the title In qemuMigrationToFile we enter the monitor multiple times and don't check if the VM is still alive after returning form the monitor. Add the checks to skip pieces of code in case the VM crashes while saving it's

Re: [libvirt] [PATCH] maint: improve syntax check for space around =

2014-08-12 Thread Laine Stump
On 08/11/2014 07:05 PM, Eric Blake wrote: Laine Stump noted on IRC that syntax check wasn't flagging his typo of 'i= 0'. This fixes it. Yes, it does. ACK and thanks! -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: improve syntax check for space around =

2014-08-12 Thread Eric Blake
On 08/12/2014 10:54 AM, Laine Stump wrote: On 08/11/2014 07:05 PM, Eric Blake wrote: Laine Stump noted on IRC that syntax check wasn't flagging his typo of 'i= 0'. This fixes it. Yes, it does. ACK and thanks! Pushed. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt

Re: [libvirt] [PATCH 2/2] daemon: Limit default log level to journald to VIR_LOG_INFO

2014-08-12 Thread Daniel P. Berrange
On Tue, Aug 12, 2014 at 04:34:37PM +0200, Peter Krempa wrote: Libvirt is really chatty when the DEBUG log level is enabled. When a host uses journald we'd enable debug logging to journald when only specifying the debug log level. As journald may employ rate throttling this would lock up the

Re: [libvirt] [PATCH v2 1/2] LXC: add support for persistent config in lxcDomainSetMemoryFlags

2014-08-12 Thread John Ferlan
On 07/30/2014 11:41 PM, Chen Hanxiao wrote: Currently, setmaxmem return success on an active domain, but nothing happened. Not quite true... Prior to these changes... # virsh -c lxc:/// start vm1 # virsh -c lxc:/// dominfo vm1 | grep memory Max memory: 50 KiB Used memory:776 KiB

[libvirt] Pass additional environmental variables

2014-08-12 Thread Sean Noonan
We're using sasl+gssapi+kerberos to do authentication for libvirt, including from hypervisor to hypervisor. However, the environmental variable filtering implemented in libvirt prevents this from working, so we're forced to run a locally patched version. Thoughts on the following patch to pass

[libvirt] Initializing qemu driver

2014-08-12 Thread David kiarie
Hi there, I get this errors trying to intialialize libvirtd $libvirtd -vvv 2014-08-12 21:57:47.887+: 6449: info : libvirt version: 1.2.8 2014-08-12 21:57:47.887+: 6449: warning : virGetHostname:665 : getaddrinfo failed for 'linux-xzc4': Name or service not known 2014-08-12

Re: [libvirt] Initializing qemu driver

2014-08-12 Thread David kiarie
Ooh got something on the list, I build without qemu as I only care about Xen. On Wed, Aug 13, 2014 at 1:00 AM, David kiarie davidkiar...@gmail.com wrote: Hi there, I get this errors trying to intialialize libvirtd $libvirtd -vvv 2014-08-12 21:57:47.887+: 6449: info : libvirt version:

[libvirt] Fwd: [PATCH] selinux: Avoid label reservations for type = none during restart

2014-08-12 Thread Shivaprasad bhat
Hi, Could someone please help me with review for this patch? Thanks and Regards, Shiva -- Forwarded message -- From: Shivaprasad G Bhat shivaprasadb...@gmail.com Date: Tue, Jun 10, 2014 at 5:12 PM Subject: [libvirt] [PATCH] selinux: Avoid label reservations for type = none