On 2014/8/28 5:20, Maxime Leroy wrote:
On Tue, Aug 26, 2014 at 11:58 AM, Wang Rui moon.wang...@huawei.com wrote:
On 2014/8/22 18:47, Maxime Leroy wrote:
+# util/virivshmemserver.h
+virStartIvshmemServer;
+virStopIvshmemServer;
I think function name virIvshmemStartServer is better.
So is
Thank you for review. Sure, you're right, I'll definitely follow your
advice next time.
Erik
On 08/27/2014 05:03 PM, Eric Blake wrote:
On 08/27/2014 08:20 AM, Erik Skultety wrote:
resolves https://bugzilla.redhat.com/show_bug.cgi?id=1132305
Please include a short summary of the BZ in the
On Wed, Aug 27, 2014 at 08:45:29PM +0200, Richard Weinberger wrote:
On Wed, Aug 27, 2014 at 9:18 AM, Daniel Veillard veill...@redhat.com wrote:
So I tagged 1.2.8-rc1 in git and made tarball and signed rpms
Can you please sign the tarball too?
Well, the source rpm is signed, you can
Am 28.08.2014 09:14, schrieb Daniel Veillard:
On Wed, Aug 27, 2014 at 08:45:29PM +0200, Richard Weinberger wrote:
On Wed, Aug 27, 2014 at 9:18 AM, Daniel Veillard veill...@redhat.com wrote:
So I tagged 1.2.8-rc1 in git and made tarball and signed rpms
Can you please sign the tarball too?
On Do, 2014-08-14 at 20:43 +0800, Wang Rui wrote:
From: Zeng Junliang zengjunli...@huawei.com
http://www.redhat.com/archives/libvir-list/2014-July/msg00644.html
diff to v2:
- hide vram attribute silently instead of reporting an error.
- introduce three new capabilities for vga.vgamem_mb,
On Thu, Aug 28, 2014 at 09:25:22AM +0200, Richard Weinberger wrote:
Am 28.08.2014 09:14, schrieb Daniel Veillard:
On Wed, Aug 27, 2014 at 08:45:29PM +0200, Richard Weinberger wrote:
On Wed, Aug 27, 2014 at 9:18 AM, Daniel Veillard veill...@redhat.com
wrote:
So I tagged 1.2.8-rc1 in git
Hello Martin,
On 08/26/2014 11:33 AM, Martin Kletzander wrote:
[Cc'ing David due to some questions/ideas about the ivshmem server]
@@ -5120,6 +5121,12 @@ qemuBuildIvshmemCommandLine(virCommandPtr cmd,
return -1;
virCommandAddArg(cmd, devstr);
On 2014/8/28 16:05, Gerd Hoffmann wrote:
On Do, 2014-08-14 at 20:43 +0800, Wang Rui wrote:
From: Zeng Junliang zengjunli...@huawei.com
http://www.redhat.com/archives/libvir-list/2014-July/msg00644.html
diff to v2:
- hide vram attribute silently instead of reporting an error.
- introduce
On 08/27/2014 10:54 PM, John Ferlan wrote:
Resolve a few RESOURCE_LEAK's identified by Coverity
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/conf/domain_conf.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/src/conf/domain_conf.c
On 08/28/2014 04:40 AM, Wang Rui wrote:
On 2014/8/28 4:54, John Ferlan wrote:
Coverity found that on error paths, the 'arg' value wasn't be cleaned
up. Followed the example in qemuAgentSetVCPUs() where upon successful call
to qemuAgentCommand() the 'cpus' is set to NULL; otherwise, when
On Wed, Aug 27, 2014 at 05:21:39PM +0100, Stefan Hajnoczi wrote:
On Tue, Aug 26, 2014 at 1:38 AM, John Ferlan jfer...@redhat.com wrote:
+value. Each device must use a unique IOThread and threads will
+be numbered from 1 to the domain iothreads value.
It is reasonable
On 08/27/2014 10:54 PM, John Ferlan wrote:
I almost didn't want to do this due to the sheer volume, but figured
at the very least the bulk of these are resource leaks found by the
much pickier new coverity scanner.
After this there are only 70 issues found...
John Ferlan (19):
On Wed, Aug 27, 2014 at 11:02:36PM +0200, Maxime Leroy wrote:
On Tue, Aug 26, 2014 at 11:02 AM, Martin Kletzander mklet...@redhat.com wrote:
On Fri, Aug 22, 2014 at 12:47:04PM +0200, Maxime Leroy wrote:
[...]
+shmem name='shmem0' model='ivshmem'
+ server path='/tmp/socket-shmem0'/
On 08/27/14 22:50, Eric Blake wrote:
On 08/27/2014 12:25 PM, Peter Krempa wrote:
Add domain list filtering functions and a flag to enforce checking
whether the remote daemon supports the requested stats groups.
---
include/libvirt/libvirt.h.in | 15 +++
src/libvirt.c
On 08/27/14 23:02, Eric Blake wrote:
On 08/27/2014 12:25 PM, Peter Krempa wrote:
Implement the remote driver support for shuffling the domain stats
around.
---
+static int
+remoteDispatchConnectGetAllDomainStats(virNetServerPtr server
ATTRIBUTE_UNUSED,
+
On Wed, Aug 27, 2014 at 10:52:02PM +0200, Maxime Leroy wrote:
On Tue, Aug 26, 2014 at 10:42 AM, Martin Kletzander mklet...@redhat.com wrote:
On Fri, Aug 22, 2014 at 12:47:01PM +0200, Maxime Leroy wrote:
This patch adds configuration support for the shmem device
as described in the schema in
On Thu, Aug 28, 2014 at 02:35:10PM +0800, Wang Rui wrote:
On 2014/8/28 5:20, Maxime Leroy wrote:
On Tue, Aug 26, 2014 at 11:58 AM, Wang Rui moon.wang...@huawei.com wrote:
On 2014/8/22 18:47, Maxime Leroy wrote:
+# util/virivshmemserver.h
+virStartIvshmemServer;
+virStopIvshmemServer;
I
In function virQEMUCapsParseMachineTypesStr, VIR_STRNDUP allocates
memory for 'name' in {do,while} loop. If 'name' isn't freed before
'continue', its memory will be allocated again in the next loop.
In this case the memory allocated for 'name' in privious loop is
useless and not freed. Free it
The 'lib' handle will be leaked if 'dlsym' condition fails.
So close the handle before return.
Signed-off-by: Wang Rui moon.wang...@huawei.com
---
tests/shunloadtest.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/shunloadtest.c b/tests/shunloadtest.c
index 499b1be..80f5351 100644
I did coverity scan for libvirt-1.2.8 as John Ferlan did.
He has sent many patches about RESOURCE_LEAK. I picked
the other errors left to fix. There are also many errors
to analyze and fix in the future.
Wang Rui (3):
util: Resolve Coverity RESOURCE_LEAK
tests: Resolve Coverity RESOURCE_LEAK
Coverity determined that 'conflict' would be leaked.
Signed-off-by: Wang Rui moon.wang...@huawei.com
---
src/util/virpci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/util/virpci.c b/src/util/virpci.c
index 0098d6c..f1d4499 100644
--- a/src/util/virpci.c
+++ b/src/util/virpci.c
@@
On 2014/8/28 17:03, Ján Tomko wrote:
On 08/28/2014 04:40 AM, Wang Rui wrote:
On 2014/8/28 4:54, John Ferlan wrote:
Coverity found that on error paths, the 'arg' value wasn't be cleaned
up. Followed the example in qemuAgentSetVCPUs() where upon successful call
to qemuAgentCommand() the 'cpus'
On Thu, Aug 28, 2014 at 10:34:11AM +0200, David Marchand wrote:
Hello Martin,
On 08/26/2014 11:33 AM, Martin Kletzander wrote:
[Cc'ing David due to some questions/ideas about the ivshmem server]
@@ -5120,6 +5121,12 @@ qemuBuildIvshmemCommandLine(virCommandPtr cmd,
return -1;
On 08/28/2014 12:20 PM, Wang Rui wrote:
I did coverity scan for libvirt-1.2.8 as John Ferlan did.
Technically, libvirt-1.2.8 is not yet released, just -rc1 :)
He has sent many patches about RESOURCE_LEAK. I picked
the other errors left to fix. There are also many errors
to analyze and fix
Currently it lacks synchronization to modify domain's snapshot object list,
that race condition causes unsafe access to some freed snapshot objects.
Therefore, this patch wraps all access of snapshot object list in vm job lock.
Only the qemuDomainSnapshotCreateXML is not synchronized, it is
On 08/28/14 00:15, Eric Blake wrote:
On 08/27/2014 12:25 PM, Peter Krempa wrote:
Add domstats command that excercises both of the new APIs depending if
s/excercises/exercises/
Hmmm, now that I've pushed this patch I noticed this typo :/ ... Oh
well. Everybody knows that my English spelling
On 08/27/2014 05:29 PM, Jim Fehlig wrote:
John Ferlan wrote:
Coverity noted that all callers to libxlDomainEventQueue() could ensure
the second parameter (event) was true before calling except this case.
As I look at the code and how events are used - it seems that prior to
generating an
Implement the API function for virDomainListGetStats and
virConnectGetAllDomainStats in a modular way and implement the
VIR_DOMAIN_STATS_STATE group of statistics.
Although it may look like the function looks universal I'd rather not
expose it to other drivers as the coming stats groups are
Hey,
I just noticed that clicking on FAQ in the left sidebar on libvirt.org
main page highlights the Wiki cell instead of highlighting FAQ.
I have no idea how the website works, so I'm just reporting it here.
Cheers,
Christophe
pgpLbXH1JyIl6.pgp
Description: PGP signature
--
libvir-list
On 08/27/2014 09:38 PM, Wang Rui wrote:
On 2014/8/28 4:54, John Ferlan wrote:
I almost didn't want to do this due to the sheer volume, but figured
at the very least the bulk of these are resource leaks found by the
much pickier new coverity scanner.
After this there are only 70 issues
On 08/28/2014 12:34 PM, Martin Kletzander wrote:
Great! Really, and it's even easier than what I thought of. We just
need to kill the server if we fail to start QEMU after starting the
server.
There is one caveat, though. There is a race between libvirt checking
whether the socket exists
On 08/27/2014 04:54 PM, John Ferlan wrote:
I almost didn't want to do this due to the sheer volume, but figured
at the very least the bulk of these are resource leaks found by the
much pickier new coverity scanner.
After this there are only 70 issues found...
John Ferlan (19):
On Wed, Aug 27, 2014 at 10:34:13AM -0400, Matthew Rosato wrote:
Currently, there is one flag passed in during macvtap creation
(withTap) -- Let's convert this field to an unsigned int flag
field for future expansion.
Signed-off-by: Matthew Rosato mjros...@linux.vnet.ibm.com
---
On 08/28/2014 06:18 AM, Peter Krempa wrote:
Implement the API function for virDomainListGetStats and
virConnectGetAllDomainStats in a modular way and implement the
VIR_DOMAIN_STATS_STATE group of statistics.
Although it may look like the function looks universal I'd rather not
expose it to
Hi! Does it possible(featured, planned) to run some qemu-agent-command
via libvirt binding (i'm interesting on ruby and php).?
I'm understand that i can connect via socket and run it, but it very
usable to get this ability inside binding.
--
Vasiliy Tolstov,
e-mail: v.tols...@selfip.ru
jabber:
On 08/28/2014 07:12 AM, Vasiliy Tolstov wrote:
Hi! Does it possible(featured, planned) to run some qemu-agent-command
via libvirt binding (i'm interesting on ruby and php).?
I'm not sure the time-schedule of the ruby and php bindings maintainers,
but ideally, ALL libvirt API should eventually
On 08/28/14 14:48, Eric Blake wrote:
On 08/28/2014 06:18 AM, Peter Krempa wrote:
Implement the API function for virDomainListGetStats and
virConnectGetAllDomainStats in a modular way and implement the
VIR_DOMAIN_STATS_STATE group of statistics.
Although it may look like the function looks
2014-08-28 17:34 GMT+04:00 Eric Blake ebl...@redhat.com:
On 08/28/2014 07:12 AM, Vasiliy Tolstov wrote:
Hi! Does it possible(featured, planned) to run some qemu-agent-command
via libvirt binding (i'm interesting on ruby and php).?
I'm not sure the time-schedule of the ruby and php bindings
On 08/28/2014 08:45 AM, Martin Kletzander wrote:
On Wed, Aug 27, 2014 at 10:34:13AM -0400, Matthew Rosato wrote:
Currently, there is one flag passed in during macvtap creation
(withTap) -- Let's convert this field to an unsigned int flag
field for future expansion.
Signed-off-by: Matthew
On Thu, Aug 28, 2014 at 9:34 AM, Eric Blake ebl...@redhat.com wrote:
On 08/28/2014 07:12 AM, Vasiliy Tolstov wrote:
Hi! Does it possible(featured, planned) to run some qemu-agent-command
via libvirt binding (i'm interesting on ruby and php).?
I'm not sure the time-schedule of the ruby and php
On 08/28/2014 02:26 PM, David Marchand wrote:
I'm not sure, though, what to do with the first point (race between
libvirt creating the socket to see that it exists and ivshmem
disconnecting). Maybe libvirt could do this (if QEMU would support
it):
1: try to create the socket (if it exists,
On Wed, Aug 27, 2014 at 10:34:14AM -0400, Matthew Rosato wrote:
Currently, MAC registration occurs during device creation, which is
early enough that, during live migration, you end up with duplicate
MAC addresses on still-running source and target devices, even though
the target device isn't
2014-08-28 17:50 GMT+04:00 Chris Lalancette clalance...@gmail.com:
The ruby bindings support virDomainQemuAgentCommand() since 0.5.2. I
haven't really tested it, though, so your mileage may vary. I
definitely accept bug reports and patches.
Thanks! Very nice. Does it possible to request
On Thu, Aug 28, 2014 at 03:46:47PM +0200, David Marchand wrote:
On 08/28/2014 02:26 PM, David Marchand wrote:
I'm not sure, though, what to do with the first point (race between
libvirt creating the socket to see that it exists and ivshmem
disconnecting). Maybe libvirt could do this (if
On Thu, Aug 28, 2014 at 12:38:17PM +, Adrien Kantcheff wrote:
Dear libvirt developers,
During my final student training in the French company Bull, with a
previous student (Simon RASTELLO), we developed new features for
Hyper-V driver. For a project called OpenCloudware, our work was
John Ferlan wrote:
On 08/27/2014 05:29 PM, Jim Fehlig wrote:
John Ferlan wrote:
Coverity noted that all callers to libxlDomainEventQueue() could ensure
the second parameter (event) was true before calling except this case.
As I look at the code and how events are used - it seems
Implement the function by returning a list of tuples instead the array
of virDomainStatsRecords and store the typed parameters as dict.
---
generator.py | 1 +
libvirt-override-virConnect.py | 47 +++
libvirt-override.c | 50
Setting OCDs aside, sorting enums breaks if the definition contains
links to other enums defined in the libvirt header before. Let the
generator generate it in the natural order.
---
generator.py | 2 --
1 file changed, 2 deletions(-)
diff --git a/generator.py b/generator.py
index
The new API function doesn't make sense to be exported in python. The
bindings will return native types instead of the struct array.
---
generator.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/generator.py b/generator.py
index 9c497be..cfc016e 100755
--- a/generator.py
+++ b/generator.py
Implement the function by returning a list of tuples instead the array
of virDomainStatsRecords and store the typed parameters as dict.
---
generator.py | 1 +
libvirt-override-virConnect.py | 53
libvirt-override.c | 94
The last patch is to ease review to be able to build the series.
Peter Krempa (5):
generator: enum: Don't sort enums by names
API: Skip 'virDomainStatsRecordListFree'
API: Implement bindings for virConnectGetAllDomainStats
API: Implement bindings for virDomainListGetStats
DO NOT APPLY:
---
generator.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/generator.py b/generator.py
index 3642838..a88c146 100755
--- a/generator.py
+++ b/generator.py
@@ -551,6 +551,7 @@ skip_function = (
virStorageVolGetConnect,
virDomainSnapshotGetConnect,
On 08/28/2014 10:32 AM, Peter Krempa wrote:
Setting OCDs aside, sorting enums breaks if the definition contains
links to other enums defined in the libvirt header before. Let the
generator generate it in the natural order.
---
generator.py | 2 --
1 file changed, 2 deletions(-)
ACK. But I
On 08/28/2014 10:32 AM, Peter Krempa wrote:
The new API function doesn't make sense to be exported in python. The
bindings will return native types instead of the struct array.
---
generator.py | 1 +
1 file changed, 1 insertion(+)
ACK.
diff --git a/generator.py b/generator.py
index
Hi sorry for the delay in responding.
Regarding the intel email footer, I understand that It might deter people from
responding.
it is automatically added if I email an external address by our exchange server.
I have asked for my account to be added to the exception whitelist
so this should be
This patch series introduces new cputune event to inform
management applications about every change of cputune values
for running domains.
Pavel Hrdina (4):
domain_conf: separate cputune struct from virDomainDef
event: introduce new event for cputune
add an example how to use cputune event
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
src/conf/domain_conf.h | 27 ---
1 file changed, 16 insertions(+), 11 deletions(-)
diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index a05254a..d9b0cfa 100644
--- a/src/conf/domain_conf.h
+++
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
src/qemu/qemu_cgroup.c | 6 ++
src/qemu/qemu_driver.c | 27 +++
2 files changed, 33 insertions(+)
diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c
index 43d14d4..95cc4d4 100644
---
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
daemon/remote.c | 87 +++
include/libvirt/libvirt.h.in | 62 ++
src/conf/domain_event.c | 120 +++
src/conf/domain_event.h | 7 +++
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
examples/object-events/event-test.c | 39 -
1 file changed, 38 insertions(+), 1 deletion(-)
diff --git a/examples/object-events/event-test.c
b/examples/object-events/event-test.c
index d6cfe46..afdc7f1 100644
On 08/27/2014 05:02 AM, Roman Bogorodskiy wrote:
Currently, after calling commands to create a new volumes,
virStorageBackendZFSCreateVol calls virStorageBackendZFSFindVols that
calls virStorageBackendZFSParseVol.
virStorageBackendZFSParseVol checks if a volume already exists by
trying to
On 08/28/2014 11:20 AM, Jim Fehlig wrote:
John Ferlan wrote:
I am going to remove this one from my series and let you handle it.
After looking at the code again, I think it is safest to go with your patch.
I would seem perhaps that the code was there to ensure that if either
Coverity complained about the following:
(3) Event ptr_arith:
Performing pointer arithmetic on cur_fd in expression cur_fd++.
130 return virNetServerServiceNewFD(*cur_fd++,
It seems the belief is their is pointer arithmetic taking place. By using
(*cur_fd)++ we avoid this
After perusing the pile of 70 or so warnings - these two stuck out as
ones that were low hanging fruit and not false positives.
Many of the remaining issues are false positives or perhaps even
bugs in Coverity, but I understand why they're being flagged. Freeing
memory from counted lists where
In qemuDomainSnapshotCreateDiskActive() if we jumped to cleanup from a
failed actions = virJSONValueNewArray(), then 'cfg' would be NULL.
So just return -1, which in turn removes the need for cleanup:
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/qemu/qemu_driver.c | 3 +--
1 file
On 08/28/2014 09:56 AM, Martin Kletzander wrote:
On Wed, Aug 27, 2014 at 10:34:14AM -0400, Matthew Rosato wrote:
Currently, MAC registration occurs during device creation, which is
early enough that, during live migration, you end up with duplicate
MAC addresses on still-running source and
On 08/28/2014 01:28 PM, John Ferlan wrote:
Coverity complained about the following:
(3) Event ptr_arith:
Performing pointer arithmetic on cur_fd in expression cur_fd++.
130 return virNetServerServiceNewFD(*cur_fd++,
It seems the belief is their is pointer arithmetic taking
On 08/28/2014 01:28 PM, John Ferlan wrote:
In qemuDomainSnapshotCreateDiskActive() if we jumped to cleanup from a
failed actions = virJSONValueNewArray(), then 'cfg' would be NULL.
So just return -1, which in turn removes the need for cleanup:
Signed-off-by: John Ferlan jfer...@redhat.com
On 08/27/2014 05:35 PM, John Ferlan wrote:
On 08/26/2014 06:15 PM, John Ferlan wrote:
v1:
http://www.redhat.com/archives/libvir-list/2014-August/msg01155.html
Changes since v1
Patches 1-3 - purely from code review
Patch 4 - rework the checking of the to be added disk that has the
On 08/28/2014 04:57 PM, Eric Blake wrote:
On 08/28/2014 01:28 PM, John Ferlan wrote:
Coverity complained about the following:
(3) Event ptr_arith:
Performing pointer arithmetic on cur_fd in expression cur_fd++.
130 return virNetServerServiceNewFD(*cur_fd++,
It seems the
On 08/28/2014 04:04 PM, John Ferlan wrote:
ACK.
For the benefit of others ;-) as Eric and I have been IRC'g over this...
This was introduced in this release cycle (commit id '9805256d')... So
not in the wild yet (fairly recent commit of 8/22)
Although I know you ACK'd what I have...
On 08/28/2014 03:28 PM, John Ferlan wrote:
After perusing the pile of 70 or so warnings - these two stuck out as
ones that were low hanging fruit and not false positives.
Many of the remaining issues are false positives or perhaps even
bugs in Coverity, but I understand why they're being
72 matches
Mail list logo
