On 09/10/14 23:56, John Ferlan wrote:
>
>
> Would it be easier if I made batches of 5 patches? or perhaps just
> batches of patches of the same error?
It might help to overcome the psychological barrier of taking
responsibility to review everything in the given series :)
Anyhow, I'll have a loo
After a4431931 the TAP FDs ale labeled with image label instead
of the process label. On the other hand, the commit was
incomplete as a few lines above, there's still old check for the
process label presence while it should be check for the image
label instead.
Signed-off-by: Michal Privoznik
---
On 09/05/14 00:26, John Ferlan wrote:
> In qemuDomainSetBlkioParameters(), Coverity points out that the calls
> to qemuDomainParseBlkioDeviceStr() are slightly different and points
> out there may be a cut-n-paste error.
>
> In the first call (AFFECT_LIVE), the second parameter is "param->field";
On 09/05/14 00:26, John Ferlan wrote:
> Since 98b9acf5aa02551dd37d0209339aba2e22e4004a
>
> This ends up being a false positive for two reasons...
>
> expected to be already allocated and thus is passed by value; whereas,
> the call into remoteDomainGetJobStats() 'params' is passed by reference.
>
On 09/05/14 00:26, John Ferlan wrote:
> Since cd4d547576a4f0371d1d4d4e0ca6db124c5ba257
>
> Coverity notes that setting 'ret = -3' prior to the unconditional
> setting of 'ret = 0' will cause the value to be UNUSED.
>
> Since the comment indicates that it is expect to allow the code
> to continue,
On 09/05/14 00:26, John Ferlan wrote:
> Coverity complains that checking for !domlist after setting doms = domlist
> and making a deref of doms just above
>
> It seems the call in question was intended to me made in the case that
> 'doms' was passed in and not when the virDomainObjListExport() cal
On 09/05/14 00:26, John Ferlan wrote:
> Handle a few places where Coverity complains about the value being
> unused. For two of them (Close cases) - the comments above the close
> indicate there is no harm to ignore the error - so added an ignore_value.
> For the other condition, added an rc check
On 09/05/14 00:26, John Ferlan wrote:
> Coverity complains that when multiplying to 32 bit values that eventually
> will be stored in a 64 bit value that it's possible the math could
> overflow unless one of the values being multiplied is type cast to
> the proper size.
>
> Signed-off-by: John Fer
On 09/05/14 00:26, John Ferlan wrote:
> If we jump to cleanup before allocating 'result', then the call to
> virBlkioDeviceArrayClear() could dereference result
>
> Signed-off-by: John Ferlan
> ---
> src/lxc/lxc_driver.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
ACK
s
On 09/05/14 00:26, John Ferlan wrote:
> If we jump to cleanup before allocating the 'result', then the call
> to virBlkioDeviceArrayClear will deref result causing a problem.
>
> Signed-off-by: John Ferlan
> ---
> src/qemu/qemu_driver.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(
On 09/05/14 00:26, John Ferlan wrote:
> If the VIR_STRDUP(exptime,...) fails, then we will jump to cleanup,
> no need to check if exptime is set which causes Coverity to issue
> a complaint in the virStrToLong_ll call because there wasn't a check
> for a NULL value while there was one for the refer
On 09/05/14 00:26, John Ferlan wrote:
> Perhaps a false positive, but since Coverity doesn't understand the
> relationship between the 'count' and the 'strings', rather than leave
> the chance the on input 'strings' is NULL and causes a deref - just
> check for it and return
>
> Signed-off-by: Joh
On 09/05/14 00:26, John Ferlan wrote:
> If the qemuMigrationEatCookie() fails to set mig, we jump to cleanup:
> which will call qemuMigrationCancelDriveMirror() without first checking
> if mig == NULL
>
> Signed-off-by: John Ferlan
> ---
> src/qemu/qemu_migration.c | 3 ++-
> 1 file changed, 2 i
On 09/05/14 00:26, John Ferlan wrote:
> The code compares def->forwarders when deciding to return 0 at a
> couple of points, then uses "def->nfwds" as a way to index into
> the def->forwarders array. That reference results in Coverity
> complaining that def->forwarders being NULL was checked as pa
On 09/05/14 00:26, John Ferlan wrote:
> In qemuProcessInitPCIAddresses() if qemuMonitorGetAllPCIAddresses()
> returns a negative (or zero) value, then no need to call the
> qemuProcessDetectPCIAddresses().
>
> Signed-off-by: John Ferlan
> ---
> src/qemu/qemu_process.c | 5 +++--
> 1 file changed
On 09/05/14 00:26, John Ferlan wrote:
> If the virNumaGetNodeCPUs() call fails with -1, then jumping to cleanup
> with 'cpus == NULL' and calling virCapabilitiesClearHostNUMACellCPUTopology
> will cause issues.
>
> Signed-off-by: John Ferlan
> ---
> src/nodeinfo.c | 2 +-
> 1 file changed, 1 ins
On 09/05/14 00:26, John Ferlan wrote:
> Coverity notes that if virDomainGetCPUStats returns a negative value
> into 'nparams' then when we end up at cleanup, the call to virTypedParams
> will have issues
>
> Signed-off-by: John Ferlan
> ---
> tools/virsh-domain.c | 1 +
> 1 file changed, 1 inser
On 09/05/14 00:26, John Ferlan wrote:
> Coverity notes that if the call to virBitmapParse() returns a negative
> value, then when we jump to the error label, the call to
> virCapabilitiesClearHostNUMACellCPUTopology() will have issues
> with the negative nb_cpus
>
> Signed-off-by: John Ferlan
> -
On 09/05/14 00:26, John Ferlan wrote:
> Coverity notes that if qemuMonitorGetMachines() returns a negative
> nmachines value, then the code at the cleanup label will have issues.
>
> Signed-off-by: John Ferlan
> ---
> src/qemu/qemu_capabilities.c | 2 +-
> 1 file changed, 1 insertion(+), 1 delet
On 09/05/14 00:26, John Ferlan wrote:
> Coverity notes that if the virConnectListAllDomains returns a negative
> value then the loop at the cleanup label that ends on numDomains will
> have issues.
>
> Signed-off-by: John Ferlan
> ---
> src/qemu/qemu_driver.c | 8 +---
> 1 file changed, 5 in
On 09/05/14 00:26, John Ferlan wrote:
> With all the changes in my previous foray into this code, I forgot to
> remove the libxlDomainEventQueue(driver, event); call inside the
> dom == NULL condition.
>
> Signed-off-by: John Ferlan
> ---
> src/libxl/libxl_migration.c | 1 -
> 1 file changed, 1
On 09/05/14 00:26, John Ferlan wrote:
> If the virJSONValueNewObject() fails, then rather than going to error
> and getting a Coverity false positive since it doesn't seem to understand
> the relationship between nkeywords, keywords, and values and seems to
> believe calling qemuFreeKeywords will c
On 09/05/14 00:26, John Ferlan wrote:
> Coverity points out that if 'dom' isn't returned from virDomainQemuAttach,
> then the code already jumps to cleanup, so there was no need for the
> subsequent if (dom != NULL) check.
>
> I moved the error message about failure into the goto cleanup on failur
On 09/05/14 00:26, John Ferlan wrote:
> Coverity complains that the various checks for autoincrement and changed
> variables are DEADCODE - seems to me to be a false positive - so mark it.
They are not false positive. Currently the code doesn't allow that to
happen. The tests are designed to catch
On 09/05/14 00:26, John Ferlan wrote:
> Add another 'dead_code_begin' - victims of our own coding practices
>
> Signed-off-by: John Ferlan
> ---
> src/qemu/qemu_command.c | 1 +
> 1 file changed, 1 insertion(+)
>
ACK
signature.asc
Description: OpenPGP digital signature
--
libvir-list maili
On 09/05/14 00:26, John Ferlan wrote:
> Coverity points out that by using EMPTYSTR(type) we are guarding against
> the possibility that it could be NULL; however, based on how 'type' was
> initialized to NULL, then either "ipv4", "ipv6", or "" - there is no way
> it could be NULL. Since "-" is sup
Well, the bug here is a bit more serious than mere DEADCODE ...
On 09/05/14 00:26, John Ferlan wrote:
> Adjust the parentheses in/for the waitpid loops; otherwise, Coverity
> points out:
>
> (1) Event assignment: Assigning: "waitret" = "waitpid(pid, &status, 0) ==
> -1"
> (2) Event between:
On Wed, Sep 03, 2014 at 09:07:35PM -0600, Jim Fehlig wrote:
> From: "Daniel P. Berrange"
>
> Comparing JSON docs using strcmp is simple, but is not flexible
> as it is sensitive to whitespace used in the doc generation.
> When comparing objects it may also be desirable to treat the
> existance of
On Wed, Sep 03, 2014 at 09:07:37PM -0600, Jim Fehlig wrote:
> From: "Daniel P. Berrange"
>
> Rename the VIR_MOCK_IMPL* macros to VIR_MOCK_WRAP*
> and add new VIR_MOCK_IMPL macros which let you directly
> implement overrides in the preloaded source.
>
> Signed-off-by: Daniel P. Berrange
> Signed
On Wed, Sep 03, 2014 at 09:07:36PM -0600, Jim Fehlig wrote:
> From: "Daniel P. Berrange"
>
> Test suites using the port allocator don't want to have different
> behaviour depending on whether a port is in use on the host. Add
> a VIR_PORT_ALLOCATOR_SKIP_BIND_CHECK which test suites can use
> to s
On Wed, Sep 03, 2014 at 09:07:38PM -0600, Jim Fehlig wrote:
> The libxl driver was blindly assigning libvirt's
> virDomainLifecycleAction to libxl's libxl_action_on_shutdown, when
> in fact the various actions take on different values in these enums.
>
> Introduce helpers to properly map the enum
On Wed, Sep 03, 2014 at 09:07:39PM -0600, Jim Fehlig wrote:
> From: "Daniel P. Berrange"
>
> The libxl library allows a libxl_domain_config object to be
> serialized to a JSON string. Use this to allow testing of
> the XML -> libxl_domain_config conversion process
>
> Signed-off-by: Daniel P. Be
On Sat, Sep 06, 2014 at 08:28:09PM +0400, Dmitry Guryanov wrote:
> Executing prlctl command is not an optimal way to interact with
> Parallels Cloud Server (PCS), it's better to use parallels SDK,
> which is a remote API to paralles dispatcher service.
>
> We prepared opensource version of this SD
On Sat, Sep 06, 2014 at 08:28:10PM +0400, Dmitry Guryanov wrote:
> Add files parallels_sdk.c and parallels_sdk.h for code
> which works with SDK, so libvirt's code will not mix with
> dealing with parallels SDK.
>
> To use Parallels SDK you must first call PrlApi_InitEx function,
> and then you wi
On Wed, Sep 10, 2014 at 03:26:06PM +0200, Michal Privoznik wrote:
> I know I've sent several versions like ages ago, so this should
> not start with v1, but hey, this is completely new approach, so
> I'm gonna start from 1.
>
> Here, the virtlockd is misused to hold the original seclabels
> (altho
On 11.09.2014 13:13, Daniel P. Berrange wrote:
On Wed, Sep 10, 2014 at 03:26:06PM +0200, Michal Privoznik wrote:
I know I've sent several versions like ages ago, so this should
not start with v1, but hey, this is completely new approach, so
I'm gonna start from 1.
Here, the virtlockd is misused
Use just one int variable for all the FromString calls.
---
src/conf/domain_conf.c | 27 +++
1 file changed, 11 insertions(+), 16 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index fcf7fb6..0fdfa6f 100644
--- a/src/conf/domain_conf.c
+++ b/src/
Just to make this series work until Martin pushes his more complete
cleanup:
https://www.redhat.com/archives/libvir-list/2014-September/msg00391.html
---
docs/schemas/basictypes.rng | 6 ++
1 file changed, 6 insertions(+)
diff --git a/docs/schemas/basictypes.rng b/docs/schemas/basictypes.rng
---
src/qemu/qemu_command.c | 20
.../qemuxml2argv-net-virtio-disable-offloads.args| 8
tests/qemuxml2argvtest.c | 2 ++
3 files changed, 30 insertions(+)
create mode 100644
tests/qemuxml2argvdata/qemuxm
Add the following attributes:
csum, gso, guest_tso4, guest_tso6, guest_ecn
to the element of network interface
which control the virtio-net device properties
of the same names.
---
docs/formatdomain.html.in | 27
docs/schemas/domaincommon.rng
Instead of checking upfront if the element will be needed
in a big condition, just format all the attributes into a string
and output the element if the string is not empty.
---
src/conf/domain_conf.c | 68 --
1 file changed, 44 insertions(+), 24 d
Ján Tomko (5):
conf: split out virtio net driver formatting
Add virSwitch to data types
conf: remove redundant local variable
conf: add options for disabling segment offloading
qemu: wire up virtio-net segment offloading options
docs/formatdomain.html.in | 27 +
On 09/05/14 00:26, John Ferlan wrote:
> Since 0766783abbe8bbc9ea686c2c3149f4c0ac139e19
>
> Coverity complains that the EDIT_FREE definition results in DEADCODE.
>
> As it turns out with the change to use the EDIT_FREE macro the call to
> vir*Free() wouldn't be necessary nor would it happen...
>
*** BLURB HERE ***
Michal Privoznik (2):
nvram: Fix permissions
virDomainUndefineFlags: Allow NVRAM unlinking
include/libvirt/libvirt.h.in| 2 ++
libvirt.spec.in | 2 +-
src/qemu/qemu_driver.c | 19 ++-
src/security/security_selinux.c | 5 -
I've noticed two problem with the automatically created NVRAM varstore
file. The first, even though I run qemu as root:root for some reason I
get Permission denied when trying to open the _VARS.fd file. The
problem is, the upper directory misses execute permissions, which in
combination with us dro
When a domain is undefined, there are options to remove it's
managed save state or snapshots. However, there's another file
that libvirt creates per domain: the NVRAM variable store file.
Make sure that the file is not left behind if the domain is
undefined.
Signed-off-by: Michal Privoznik
---
i
On 09/04/2014 06:26 PM, John Ferlan wrote:
> Sorry for the large dump, but before I got too involved in other things
> I figured I'd go through the list of the remaining 68 Coverity issues
> from the new version in order to reduce the pile. Many are benign, some
> seemingly false positives, and I
Signed-off-by: Pavel Hrdina
---
src/util/virprocess.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/src/util/virprocess.c b/src/util/virprocess.c
index 15d8309..3dae1bd 100644
--- a/src/util/virprocess.c
+++ b/src/util/virprocess.c
@@ -28,7 +28,6 @@
#include
Subject doesn't describe what caused the build to fail.
On 09/11/14 14:57, Pavel Hrdina wrote:
Neither the rest of the commit message.
> Signed-off-by: Pavel Hrdina
> ---
> src/util/virprocess.c | 12 +++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/src/util/vir
On 09/11/2014 03:03 PM, Peter Krempa wrote:
Subject doesn't describe what caused the build to fail.
On 09/11/14 14:57, Pavel Hrdina wrote:
Neither the rest of the commit message.
The build failed because of missing "sys/syscall.h".
Will update the commit message, thanks.
Signed-off-by: P
On 09/11/14 15:12, Pavel Hrdina wrote:
> On 09/11/2014 03:03 PM, Peter Krempa wrote:
>> Subject doesn't describe what caused the build to fail.
>>
>> On 09/11/14 14:57, Pavel Hrdina wrote:
>>
>> Neither the rest of the commit message.
>
> The build failed because of missing "sys/syscall.h".
>
> W
On 09/11/2014 03:13 PM, Peter Krempa wrote:
On 09/11/14 15:12, Pavel Hrdina wrote:
On 09/11/2014 03:03 PM, Peter Krempa wrote:
Subject doesn't describe what caused the build to fail.
On 09/11/14 14:57, Pavel Hrdina wrote:
Neither the rest of the commit message.
The build failed because of m
On 09/08/2014 07:40 AM, Martin Kletzander wrote:
> Signed-off-by: Martin Kletzander
> ---
> docs/schemas/basictypes.rng | 19 --
> docs/schemas/capability.rng | 10 +--
> docs/schemas/domaincaps.rng | 5 +-
> docs/schemas/domaincommon.rng | 155
> +--
On 09/11/14 14:09, Michal Privoznik wrote:
> I've noticed two problem with the automatically created NVRAM varstore
> file. The first, even though I run qemu as root:root for some reason I
> get Permission denied when trying to open the _VARS.fd file. The
> problem is, the upper directory misses ex
On 11.09.2014 16:07, Laszlo Ersek wrote:
On 09/11/14 14:09, Michal Privoznik wrote:
I've noticed two problem with the automatically created NVRAM varstore
file. The first, even though I run qemu as root:root for some reason I
get Permission denied when trying to open the _VARS.fd file. The
probl
On Thursday 11 September 2014 12:09:20 Daniel P. Berrange wrote:
> On Sat, Sep 06, 2014 at 08:28:10PM +0400, Dmitry Guryanov wrote:
> > Add files parallels_sdk.c and parallels_sdk.h for code
> > which works with SDK, so libvirt's code will not mix with
> > dealing with parallels SDK.
> >
> > To us
On 09/11/2014 04:25 PM, Michal Privoznik wrote:
> On 11.09.2014 16:07, Laszlo Ersek wrote:
>> On 09/11/14 14:09, Michal Privoznik wrote:
>>> I've noticed two problem with the automatically created NVRAM varstore
>>> file. The first, even though I run qemu as root:root for some reason I
>>> get Perm
some comments below
On 09/11/14 14:09, Michal Privoznik wrote:
> When a domain is undefined, there are options to remove it's
> managed save state or snapshots. However, there's another file
> that libvirt creates per domain: the NVRAM variable store file.
> Make sure that the file is not left beh
On 08/04/14 09:59, Nehal J Wani wrote:
> This patch enables the helper program to detect event(s) triggered when there
> is a change in lease length or expiry and client-id. This transfers complete
> control of leases database to libvirt and obsoletes use of the lease database
> file (.leases). Tha
This allows usage of alternative tun/tap/vhost backends implemented
in userspace via cuse.
Ján Tomko (2):
conf: add backend element to interfaces
Wire up the interface backend options
docs/formatdomain.html.in | 20 +
docs/schemas/domaincommon.rng
For tuning the network, alternative devices
for creating tap and vhost devices can be specified via:
---
docs/formatdomain.html.in | 20 +
docs/schemas/domaincommon.rng | 10 +
src/conf/domain_conf.c| 11 +
sr
Pass the user-specified tun path down when creating tap device
when called from the qemu driver.
Also honor the vhost device path specified by user.
---
src/bhyve/bhyve_command.c | 2 +-
src/bhyve/bhyve_process.c | 2 +-
src/network/bridge_driver.c | 6 +++---
src/qemu/qemu_command.c |
If a floppy drive isn't selected for snapshot explicitly and is empty
don't try to snapshot it. For external snapshots this would fail as we
can't generate a name for the snapshot from an empty drive.
Reported-by: Pavel Hrdina
---
src/conf/snapshot_conf.c | 9 -
1 file changed, 8 inserti
On 09/11/2014 02:38 AM, Peter Krempa wrote:
> On 09/05/14 00:26, John Ferlan wrote:
>> Since 98b9acf5aa02551dd37d0209339aba2e22e4004a
>>
>> This ends up being a false positive for two reasons...
>>
>> expected to be already allocated and thus is passed by value; whereas,
>> the call into remoteDoma
- Original Message -
> From: "Peter Krempa"
> To: "Francesco Romani" , libvir-list@redhat.com
> Sent: Tuesday, September 9, 2014 1:56:09 PM
> Subject: Re: [libvirt] [PATCHv3 4/8] qemu: bulk stats: implement VCPU group
> > + * VIR_DOMAIN_STATS_VCPU: Return virtual CPU statistics.
> > + * D
On 09/11/2014 04:38 AM, Peter Krempa wrote:
> On 09/05/14 00:26, John Ferlan wrote:
>> Since 98b9acf5aa02551dd37d0209339aba2e22e4004a
>>
>> This ends up being a false positive for two reasons...
>>
>> expected to be already allocated and thus is passed by value; whereas,
>> the call into remoteDo
On 09/11/14 17:54, Francesco Romani wrote:
> - Original Message -
>> From: "Peter Krempa"
>> To: "Francesco Romani" , libvir-list@redhat.com
>> Sent: Tuesday, September 9, 2014 1:56:09 PM
>> Subject: Re: [libvirt] [PATCHv3 4/8] qemu: bulk stats: implement VCPU group
>
>>> + * VIR_DOMAIN_S
On 09/11/2014 09:47 AM, Peter Krempa wrote:
> If a floppy drive isn't selected for snapshot explicitly and is empty
> don't try to snapshot it. For external snapshots this would fail as we
> can't generate a name for the snapshot from an empty drive.
Do we need the same for cdrom drives?
>
> Rep
On Thu, Sep 11, 2014 at 8:38 PM, Peter Krempa wrote:
> On 08/04/14 09:59, Nehal J Wani wrote:
>> This patch enables the helper program to detect event(s) triggered when there
>> is a change in lease length or expiry and client-id. This transfers complete
>> control of leases database to libvirt an
This patchset begins reworking of parallels driver. We have
published Opensource version of parallels SDK (under LGPL license),
so libvirt can link with it.
Changes in v4:
* Remove reference counting for PrlApi_InitEx and PrlApi_Deinit
* remove Parallels SDK prefix in log messages
Executing prlctl command is not an optimal way to interact with
Parallels Cloud Server (PCS), it's better to use parallels SDK,
which is a remote API to paralles dispatcher service.
We prepared opensource version of this SDK and published it on
github, it's distributed under LGPL license. Here is
Add files parallels_sdk.c and parallels_sdk.h for code
which works with SDK, so libvirt's code will not mix with
dealing with parallels SDK.
To use Parallels SDK you must first call PrlApi_InitEx function,
and then you will be able to connect to a server with
PrlSrv_LoginLocalEx function. When you
On 09/11/2014 11:55 AM, Eric Blake wrote:
> On 09/11/2014 02:38 AM, Peter Krempa wrote:
>> On 09/05/14 00:26, John Ferlan wrote:
>>> Since 98b9acf5aa02551dd37d0209339aba2e22e4004a
>>>
>>> This ends up being a false positive for two reasons...
>>>
>>> expected to be already allocated and thus is p
On 09/11/14 18:16, Eric Blake wrote:
> On 09/11/2014 09:47 AM, Peter Krempa wrote:
>> If a floppy drive isn't selected for snapshot explicitly and is empty
>> don't try to snapshot it. For external snapshots this would fail as we
>> can't generate a name for the snapshot from an empty drive.
>
> D
On 09/11/14 18:25, Peter Krempa wrote:
> On 09/11/14 18:16, Eric Blake wrote:
>> On 09/11/2014 09:47 AM, Peter Krempa wrote:
>>> If a floppy drive isn't selected for snapshot explicitly and is empty
>>> don't try to snapshot it. For external snapshots this would fail as we
>>> can't generate a name
- Original Message -
> From: "Peter Krempa"
> To: "Francesco Romani" , libvir-list@redhat.com
> Sent: Thursday, September 11, 2014 6:07:48 PM
> Subject: Re: [libvirt] [PATCHv3 4/8] qemu: bulk stats: implement VCPU group
> > I like this, but I'd also need to do a cross-check on my our code
- Original Message -
> From: "Peter Krempa"
> To: "Francesco Romani" , libvir-list@redhat.com
> Sent: Tuesday, September 9, 2014 1:42:15 PM
> Subject: Re: [libvirt] [PATCHv3 5/8] qemu: bulk stats: implement interface
> group
> > + * VIR_DOMAIN_STATS_INTERFACE: Return network interface st
On 09/11/14 19:11, Francesco Romani wrote:
> - Original Message -
>> From: "Peter Krempa"
>> To: "Francesco Romani" , libvir-list@redhat.com
>> Sent: Tuesday, September 9, 2014 1:42:15 PM
>> Subject: Re: [libvirt] [PATCHv3 5/8] qemu: bulk stats: implement interface
>> group
>
>>> + * VIR
Add a new parameter to virStorageFileGetMetadata that will break the
backing chain detection process and report useful error message rather
than having to use virStorageFileChainGetBroken.
This patch just introduces the option, usage will be provided
separately.
---
src/qemu/qemu_domain.c
Now that we have a simple function to check locality of storage, reuse
it in qemuDomainCheckDiskPresence().
Also reuse check for empty storage source.
---
src/qemu/qemu_domain.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_doma
Peter Krempa (6):
util: Add function to check if a virStorageSource is "empty"
qemu: Drop unused formatting of uuid
util: storage: Allow metadata crawler to report useful errors
qemu: Report better errors from broken backing chains
storage: Improve error message when traversing backing c
The formatted UUID isn't used anywhere else in
qemuDomainCheckDiskStartupPolicy. Drop it.
---
src/qemu/qemu_domain.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index c0306d7..bd7d511 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_
Request erroring out from the backing chain traveller and drop qemu's
internal backing chain integrity tester.
The backin chain traveller reports errors by itself with possibly more
detail than qemuDiskChainCheckBroken ever could.
We also need to make sure that we reconnect to existing qemu insta
To express empty drive we historically use storage source with empty
path. Unfortunately NBD disks may be declared without a path.
Add a helper to wrap this logic.
---
src/libvirt_private.syms | 1 +
src/util/virstoragefile.c | 20
src/util/virstoragefile.h | 1 +
3 files
Report also the name of the parent file and uid/gid used to access it to
help debugging broken storage configurations.
---
src/storage/storage_driver.c | 20 +++-
1 file changed, 15 insertions(+), 5 deletions(-)
diff --git a/src/storage/storage_driver.c b/src/storage/storage_drive
Series contains a duplicate submission of patch 1/2 with my ohter series.
Peter Krempa (2):
util: Add function to check if a virStorageSource is "empty"
conf: snapshot: Don't default-snapshot empty drives
src/conf/snapshot_conf.c | 8 +++-
src/libvirt_private.syms | 1 +
src/util/v
To express empty drive we historically use storage source with empty
path. Unfortunately NBD disks may be declared without a path.
Add a helper to wrap this logic.
---
src/libvirt_private.syms | 1 +
src/util/virstoragefile.c | 20
src/util/virstoragefile.h | 1 +
3 files
If a (floppy) drive isn't selected for snapshot explicitly and is empty
don't try to snapshot it. For external snapshots this would fail as we
can't generate a name for the snapshot from an empty drive.
Reported-by: Pavel Hrdina
---
Version 2 now doesn't discriminate according to drive type
sr
On 09/11/2014 10:28 AM, Peter Krempa wrote:
> On 09/11/14 18:25, Peter Krempa wrote:
>> On 09/11/14 18:16, Eric Blake wrote:
>>> On 09/11/2014 09:47 AM, Peter Krempa wrote:
If a floppy drive isn't selected for snapshot explicitly and is empty
don't try to snapshot it. For external snapsho
On Thu, Sep 04, 2014 at 10:27:12PM -0400, Hongbin Lu wrote:
> Thanks Guido,
>
> Your comment is addressed:
> https://www.redhat.com/archives/libvir-list/2014-September/msg00284.html.
Great. The migration code looks good to me from a OpenVZ view but I
don't feel qualified enough to ACK this from a
On 09/11/2014 11:16 AM, Peter Krempa wrote:
>> struct _virDomainInterfaceStats {
>> long long rx_bytes;
>> long long rx_packets;
>> long long rx_errs;
>> long long rx_drop;
>> long long tx_bytes;
>> long long tx_packets;
>> long long tx_errs;
>> long long tx_drop;
>
On 09/11/2014 11:54 AM, Peter Krempa wrote:
> To express empty drive we historically use storage source with empty
> path. Unfortunately NBD disks may be declared without a path.
>
> Add a helper to wrap this logic.
> ---
> src/libvirt_private.syms | 1 +
> src/util/virstoragefile.c | 20 ++
On 09/11/2014 11:54 AM, Peter Krempa wrote:
> If a (floppy) drive isn't selected for snapshot explicitly and is empty
> don't try to snapshot it. For external snapshots this would fail as we
> can't generate a name for the snapshot from an empty drive.
>
> Reported-by: Pavel Hrdina
> ---
ACK.
-
On Thu, Sep 11, 2014 at 07:47:46PM +0200, Peter Krempa wrote:
> Peter Krempa (6):
> util: Add function to check if a virStorageSource is "empty"
> qemu: Drop unused formatting of uuid
> util: storage: Allow metadata crawler to report useful errors
> qemu: Report better errors from broken b
On 09/10/2014 01:54 PM, Laine Stump wrote:
> Sometimes libvirt is installed on a host that is already using the
> network 192.168.122.0/24. If the libvirt-daemon-config-network package
> is installed, this creates a conflict, since that package has been
> hard-coded to create a virtual network that
On 09/10/2014 11:54 AM, Laine Stump wrote:
> Sometimes libvirt is installed on a host that is already using the
> network 192.168.122.0/24. If the libvirt-daemon-config-network package
> is installed, this creates a conflict, since that package has been
> hard-coded to create a virtual network that
Daniel P. Berrange wrote:
> On Wed, Sep 03, 2014 at 09:07:38PM -0600, Jim Fehlig wrote:
>
>> The libxl driver was blindly assigning libvirt's
>> virDomainLifecycleAction to libxl's libxl_action_on_shutdown, when
>> in fact the various actions take on different values in these enums.
>>
>> Introd
Daniel P. Berrange wrote:
> On Wed, Sep 03, 2014 at 09:07:35PM -0600, Jim Fehlig wrote:
>
>> From: "Daniel P. Berrange"
>>
>> Comparing JSON docs using strcmp is simple, but is not flexible
>> as it is sensitive to whitespace used in the doc generation.
>> When comparing objects it may also be
Jim Fehlig wrote:
> The libxl driver was blindly assigning libvirt's
> virDomainLifecycleAction to libxl's libxl_action_on_shutdown, when
> in fact the various actions take on different values in these enums.
>
> Introduce helpers to properly map the enum values.
>
BTW, forgot to mention that t
Daniel P. Berrange wrote:
> On Wed, Sep 03, 2014 at 09:07:39PM -0600, Jim Fehlig wrote:
>
>> From: "Daniel P. Berrange"
>>
>> The libxl library allows a libxl_domain_config object to be
>> serialized to a JSON string. Use this to allow testing of
>> the XML -> libxl_domain_config conversion pro
1 - 100 of 139 matches
Mail list logo
