Hi Michal,
'have a kernel+qemu+libvirt setup with all recent upstream bits on a given host
was trying to configure a VM with backing 1G huge pages...spanning 2 NUMA
nodes.
The host had 3 1G huge pages on each of the 2 NUMA nodes :
# cat
Hello,
I've observed memory leak in long-running python program and
suspects a bug in libvirt-python.
libvirt-python contains auto-generated code like this:
libvirt_virDomainGetXMLDesc(...) {
...
LIBVIRT_BEGIN_ALLOW_THREADS;
c_retval = virDomainGetXMLDesc(domain, flags);
On Tue, Sep 09, 2014 at 11:54:09 +0200, Jiri Denemark wrote:
New --completed flag for virsh domjobinfo command.
Signed-off-by: Jiri Denemark jdene...@redhat.com
---
Notes:
Version 2:
- enhanced virsh man page
tools/virsh-domain.c | 27 ---
Hi Jun'ichi,
Which are libvirt version and OS you're using? I also found a leak of XMLDesc()
via valgrind,
I think the generator should fix this, but you may wait for developers reply,
thanks for
reporting this.
valgrind
==14265== 2,407 bytes in 1 blocks are definitely lost in loss record
On 12.09.2014 00:20, Laszlo Ersek wrote:
On 09/11/14 16:25, Michal Privoznik wrote:
On 11.09.2014 16:07, Laszlo Ersek wrote:
On 09/11/14 14:09, Michal Privoznik wrote:
I've noticed two problem with the automatically created NVRAM varstore
file. The first, even though I run qemu as root:root
[CCing Martin Kletzander]
On 12.09.2014 08:25, Vinod, Chegu wrote:
Hi Michal,
‘have a kernel+qemu+libvirt setup with all recent upstream bits on a
given host was trying to configure a VM with backing 1G huge
pages…spanning 2 NUMA nodes.
The host had 3 1G huge pages on each of the 2 NUMA
Hi,
the program was running on Fedora 20 (libvirt 1.1.3.5-2.fc20)
and Ubuntu 14.04 (libvirt 1.2.2-0ubunt).
So far the leak was observed only on the latter.
On 09/12/14 16:22, Alex Jia wrote:
Hi Jun'ichi,
Which are libvirt version and OS you're using? I also found a leak of
XMLDesc() via
On 09/11/14 20:06, Eric Blake wrote:
On 09/11/2014 11:54 AM, Peter Krempa wrote:
To express empty drive we historically use storage source with empty
path. Unfortunately NBD disks may be declared without a path.
Add a helper to wrap this logic.
---
src/libvirt_private.syms | 1 +
On 12.09.2014 08:56, Junichi Nomura wrote:
Hello,
I've observed memory leak in long-running python program and
suspects a bug in libvirt-python.
libvirt-python contains auto-generated code like this:
libvirt_virDomainGetXMLDesc(...) {
...
LIBVIRT_BEGIN_ALLOW_THREADS;
On 09/11/14 20:07, Eric Blake wrote:
On 09/11/2014 11:54 AM, Peter Krempa wrote:
If a (floppy) drive isn't selected for snapshot explicitly and is empty
don't try to snapshot it. For external snapshots this would fail as we
can't generate a name for the snapshot from an empty drive.
On 09/11/14 21:03, Richard W.M. Jones wrote:
On Thu, Sep 11, 2014 at 07:47:46PM +0200, Peter Krempa wrote:
Peter Krempa (6):
util: Add function to check if a virStorageSource is empty
qemu: Drop unused formatting of uuid
util: storage: Allow metadata crawler to report useful errors
- Original Message -
From: Peter Krempa pkre...@redhat.com
To: Francesco Romani from...@redhat.com, libvir-list@redhat.com
Sent: Tuesday, September 9, 2014 3:19:28 PM
Subject: Re: [libvirt] [PATCHv3 7/8] qemu: bulk stats: add block allocation
information
On 09/08/14 15:05,
On Thu, Sep 11, 2014 at 06:14:12PM -0600, Jim Fehlig wrote:
Kiarie Kahurani wrote:
Introduce a xen xl parser
[...]
diff --git a/configure.ac b/configure.ac
index f93c6c2..0daf411 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2177,6 +2177,13 @@ if test -z $PERL; then
Because of similar contexts, git rebase I did just before pushing the
series which added --completed option patched the wrong command.
Signed-off-by: Jiri Denemark jdene...@redhat.com
---
Pushed as trivial.
tools/virsh-domain.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
On 09/12/14 02:05, John Ferlan wrote:
Since 98b9acf5aa02551dd37d0209339aba2e22e4004a
This ends up being a false positive for two reasons...
expected to be already allocated and thus is passed by value; whereas,
the call into remoteDomainGetJobStats() 'params' is passed by reference.
Thus
On 09/12/14 02:06, John Ferlan wrote:
Coverity complains that because of how 'offset' is initialized to
0 (zero), the resulting math and comparison on rem is pointless.
For the while (rem 0), the value of 'rem' must be between
0 and 86399 (SECS_PER_DAY = 86400ULL). Thus, the addition of
Up till bb3301ba the wrapper was freeing the passed strings for us.
However that changed after the commit. So now we don't free any
strings which results in memory leaks as reported upstream [1]:
==14265== 2,407 bytes in 1 blocks are definitely lost in loss record 1,457 of
1,550
==14265==at
On Thu, Sep 11, 2014 at 06:19:23PM +0400, Dmitry Guryanov wrote:
On Thursday 11 September 2014 12:09:20 Daniel P. Berrange wrote:
On Sat, Sep 06, 2014 at 08:28:10PM +0400, Dmitry Guryanov wrote:
Add files parallels_sdk.c and parallels_sdk.h for code
which works with SDK, so libvirt's code
On Fri, Sep 12, 2014 at 10:57:26AM +0200, Michal Privoznik wrote:
Up till bb3301ba the wrapper was freeing the passed strings for us.
However that changed after the commit. So now we don't free any
strings which results in memory leaks as reported upstream [1]:
==14265== 2,407 bytes in 1
On Friday 12 September 2014 10:11:52 Daniel P. Berrange wrote:
On Thu, Sep 11, 2014 at 06:19:23PM +0400, Dmitry Guryanov wrote:
On Thursday 11 September 2014 12:09:20 Daniel P. Berrange wrote:
On Sat, Sep 06, 2014 at 08:28:10PM +0400, Dmitry Guryanov wrote:
Add files parallels_sdk.c and
On 09/11/2014 08:05 PM, John Ferlan wrote:
There are two repeats from the last series (1 2).
For patch 1, I went with my suggestion - I'm open to others
For patch 2, Coverity was complaining more about the way nparams
would be overwritten - fix that by adding a new variable
New
On 09/08/2014 09:05 PM, Stefan Berger wrote:
From: Stefan Berger stef...@linux.vnet.ibm.com
Pass the TPM file descriptor to QEMU via command line.
Instead of passing /dev/tpm0 we now pass /dev/fdset/10 and the additional
parameters -add-fd set=10,fd=20.
This addresses the use case when QEMU is
When a domain is undefined, there are options to remove it's
managed save state or snapshots. However, there's another file
that libvirt creates per domain: the NVRAM variable store file.
Make sure that the file is not left behind if the domain is
undefined.
Signed-off-by: Michal Privoznik
At the beginning when I was inventing loader/ attributes and
nvram/ I've introduced this @readonly attribute to the loader
element. It accepted values 'on' and 'off'. However, later, during the
review process, that has changed to 'yes' and 'no', but the example
XML snippet wasn't updated, so while
diff to v1:
-patch 1/2 (2/2 in previous version) updated according to Laszlo's review
Michal Privoznik (2):
virDomainUndefineFlags: Allow NVRAM unlinking
formatdomain: Update loader/ example to match the rest
docs/formatdomain.html.in| 2 +-
include/libvirt/libvirt.h.in | 2 ++
On 09/12/14 05:55, Eric Blake wrote:
In order to implement the new virDomainBlockCopy, the existing
block copy internal implementation needs to be adjusted. The
new function will parse XML into a storage source, and parse
typed parameters into integers, then call into the same common
On 09/12/14 05:55, Eric Blake wrote:
The hard part of managing the disk copy is already coded; all
this had to do was convert the XML and virTypedParameters into
the internal representation.
With this patch, all blockcopy operations that used the old
API should also work via the new API.
On 09/12/14 05:55, Eric Blake wrote:
Upstream qemu 1.4 added some drive-mirror tunables not present
when it was first introduced in 1.3. Management apps may want
to set these in some cases (for example, without tuning
granularity down to sector size, a copy may end up occupying
more bytes
This patch implements the VIR_DOMAIN_STATS_INTERFACE
group of statistics.
Signed-off-by: Francesco Romani from...@redhat.com
---
include/libvirt/libvirt.h.in | 1 +
src/libvirt.c| 14 +++
src/qemu/qemu_driver.c | 87
3 files
This patch implements the VIR_DOMAIN_STATS_BALLOON
group of statistics.
Signed-off-by: Francesco Romani from...@redhat.com
---
include/libvirt/libvirt.h.in | 1 +
src/libvirt.c| 6
src/qemu/qemu_driver.c | 73
3 files
This patch implements the VIR_DOMAIN_STATS_BLOCK
group of statistics.
To do so, an helper function to get the block stats
of all the disks of a domain is added.
Signed-off-by: Francesco Romani from...@redhat.com
---
include/libvirt/libvirt.h.in | 1 +
src/libvirt.c| 20
Future patches which will implement more
bulk stats groups for QEMU will need to access
the connection object.
To accomodate that, a few changes are needed:
* enrich internal prototype to pass qemu driver object.
* add per-group flag to mark if one collector needs
monitor access or not.
* if
Exports to the domstats commands the new bulk stats groups.
Signed-off-by: Francesco Romani from...@redhat.com
---
tools/virsh-domain-monitor.c | 35 +++
tools/virsh.pod | 4 +++-
2 files changed, 38 insertions(+), 1 deletion(-)
diff --git
This patchset enhances the QEMU support
for the new bulk stats API to include
equivalents of these APIs:
virDomainBlockInfo
virDomainGetInfo - for balloon stats
virDomainGetCPUStats
virDomainBlockStatsFlags
virDomainInterfaceStats
virDomainGetVcpusFlags
virDomainGetVcpus
This subset of API is
Management software wants to be able to allocate disk space on demand.
To support this they need keep track of the space occupation
of the block device.
This information is reported by qemu as part of block stats.
This patch extend the block information in the bulk stats with
the allocation
This patch implements the VIR_DOMAIN_STATS_CPU_TOTAL
group of statistics.
Signed-off-by: Francesco Romani from...@redhat.com
---
include/libvirt/libvirt.h.in | 1 +
src/libvirt.c| 7 +++
src/qemu/qemu_driver.c | 41 +
3 files
This patch implements the VIR_DOMAIN_STATS_VCPU
group of statistics.
To do so, this patch also extracts a helper to gather the
VCpu information.
Signed-off-by: Francesco Romani from...@redhat.com
---
include/libvirt/libvirt.h.in | 1 +
src/libvirt.c| 12 +++
On 09/12/14 05:55, Eric Blake wrote:
We stupidly modeled block job bandwidth after migration
bandwidth, which in turn was an 'unsigned long' and therefore
subject to 32-bit vs. 64-bit interpretations. To work around
the fact that 10-gigabit interfaces are possible but don't fit
within 32
On 09/12/14 05:55, Eric Blake wrote:
Treating -1 as the maximum bandwidth of block jobs is not very
practical, given the restrictions on overflow between 32-bit
vs. 64-bit long, as well as conversions between MiB/s and bytes/s.
We already document that 0 means unlimited, so the only reason to
On 09/12/14 13:33, Michal Privoznik wrote:
At the beginning when I was inventing loader/ attributes and
nvram/ I've introduced this @readonly attribute to the loader
element. It accepted values 'on' and 'off'. However, later, during the
review process, that has changed to 'yes' and 'no', but
On 10.09.2014 16:21, Daniel P. Berrange wrote:
Spawning the pkcheck program every time a permission check is
required is hugely expensive on CPU. The pkcheck program is just
a dumb wrapper for the DBus API, so rewrite the code to use the
DBus API directly. This also simplifies error handling a
On 10.09.2014 16:20, Daniel P. Berrange wrote:
This series improves the performance of the polkit driver by
switching from use of the pk-check command, to the DBus APIs.
As a convenient side effect, this means we are no longer
vulnerable to CVE-2013-4311, on any polkit version, since we
no
On 09/12/14 13:33, Michal Privoznik wrote:
When a domain is undefined, there are options to remove it's
managed save state or snapshots. However, there's another file
that libvirt creates per domain: the NVRAM variable store file.
Make sure that the file is not left behind if the domain is
On 09/12/14 05:55, Eric Blake wrote:
Trickier than I had hoped; but now that we can parse numbers with
arbitrary scale, it's time to use those numbers to call into the
new API if the old API would have rounded the input, while still
gracefully falling back to the old API if the new one fails.
On 09/12/14 05:55, Eric Blake wrote:
Take the previous patch one step further. In addition to
automatically selecting byte mode with fallback if the
user's result would be rounded, we also want to give the
user a way to guarantee byte mode even if rounding is not
required, with no fallback
On 12.09.2014 13:33, Michal Privoznik wrote:
diff to v1:
-patch 1/2 (2/2 in previous version) updated according to Laszlo's review
Michal Privoznik (2):
virDomainUndefineFlags: Allow NVRAM unlinking
formatdomain: Update loader/ example to match the rest
docs/formatdomain.html.in|
On 09/12/14 13:48, Francesco Romani wrote:
Future patches which will implement more
bulk stats groups for QEMU will need to access
the connection object.
To accomodate that, a few changes are needed:
* enrich internal prototype to pass qemu driver object.
* add per-group flag to mark if
On 09/12/14 13:48, Francesco Romani wrote:
This patch implements the VIR_DOMAIN_STATS_CPU_TOTAL
group of statistics.
Signed-off-by: Francesco Romani from...@redhat.com
---
include/libvirt/libvirt.h.in | 1 +
src/libvirt.c| 7 +++
src/qemu/qemu_driver.c | 41
On 09/12/14 13:48, Francesco Romani wrote:
This patch implements the VIR_DOMAIN_STATS_BALLOON
group of statistics.
Signed-off-by: Francesco Romani from...@redhat.com
---
include/libvirt/libvirt.h.in | 1 +
src/libvirt.c| 6
src/qemu/qemu_driver.c | 73
On 09/12/2014 01:43 AM, Peter Krempa wrote:
+ * Returns true if @src points to an empty storage source.
+ */
+bool
+virStorageSourceIsEmpty(virStorageSourcePtr src)
Maybe the comment is better as:
Returns true if the guest disk has no associated host storage source
(such as an empty
On 09/12/14 13:48, Francesco Romani wrote:
This patch implements the VIR_DOMAIN_STATS_VCPU
group of statistics.
To do so, this patch also extracts a helper to gather the
VCpu information.
Signed-off-by: Francesco Romani from...@redhat.com
---
include/libvirt/libvirt.h.in | 1 +
On 09/11/2014 06:14 PM, Jim Fehlig wrote:
But also as mentioned before, I can't figure out how to convince
automake to tell flex to generate the header file as well as the .c file.
Eric, do you have any experience with automake and flex? The following
thread makes it sound as though
On 09/12/14 13:48, Francesco Romani wrote:
This patch implements the VIR_DOMAIN_STATS_INTERFACE
group of statistics.
Signed-off-by: Francesco Romani from...@redhat.com
---
include/libvirt/libvirt.h.in | 1 +
src/libvirt.c| 14 +++
src/qemu/qemu_driver.c | 87
On 09/12/14 13:48, Francesco Romani wrote:
Exports to the domstats commands the new bulk stats groups.
Signed-off-by: Francesco Romani from...@redhat.com
---
tools/virsh-domain-monitor.c | 35 +++
tools/virsh.pod | 4 +++-
2 files changed, 38
On 09/12/14 13:48, Francesco Romani wrote:
This patch implements the VIR_DOMAIN_STATS_BLOCK
group of statistics.
To do so, an helper function to get the block stats
of all the disks of a domain is added.
Signed-off-by: Francesco Romani from...@redhat.com
---
On 09/12/2014 05:41 AM, Peter Krempa wrote:
On 09/12/14 05:55, Eric Blake wrote:
The hard part of managing the disk copy is already coded; all
this had to do was convert the XML and virTypedParameters into
the internal representation.
With this patch, all blockcopy operations that used the
On 09/12/14 13:48, Francesco Romani wrote:
Management software wants to be able to allocate disk space on demand.
To support this they need keep track of the space occupation
of the block device.
This information is reported by qemu as part of block stats.
This patch extend the block
On 09/12/2014 07:05 AM, Peter Krempa wrote:
On 09/12/14 13:48, Francesco Romani wrote:
This patch implements the VIR_DOMAIN_STATS_BALLOON
group of statistics.
Signed-off-by: Francesco Romani from...@redhat.com
---
include/libvirt/libvirt.h.in | 1 +
src/libvirt.c| 6
- Original Message -
From: Peter Krempa pkre...@redhat.com
To: Francesco Romani from...@redhat.com, libvir-list@redhat.com
Sent: Friday, September 12, 2014 3:56:06 PM
Subject: Re: [libvirt] [PATCHv4 6/8] qemu: bulk stats: implement block group
On 09/12/14 13:48, Francesco Romani
On 09/12/2014 06:32 AM, Peter Krempa wrote:
On 09/12/14 05:55, Eric Blake wrote:
Take the previous patch one step further. In addition to
automatically selecting byte mode with fallback if the
user's result would be rounded, we also want to give the
user a way to guarantee byte mode even if
There was a bug that if libvirtd binary has been updated than the
capability file wasn't reloaded therefore new capabilities introduced
in libvirt cannot be used because the cached version was loaded.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1135431
Signed-off-by: Pavel Hrdina
On Fri, Sep 12, 2014 at 06:10:44PM +0200, Pavel Hrdina wrote:
There was a bug that if libvirtd binary has been updated than the
capability file wasn't reloaded therefore new capabilities introduced
in libvirt cannot be used because the cached version was loaded.
Resolves:
On 09/11/2014 05:15 PM, Eric Blake wrote:
On 09/10/2014 11:54 AM, Laine Stump wrote:
Sometimes libvirt is installed on a host that is already using the
network 192.168.122.0/24. If the libvirt-daemon-config-network package
is installed, this creates a conflict, since that package has been
On 09/12/2014 06:25 PM, Daniel P. Berrange wrote:
On Fri, Sep 12, 2014 at 06:10:44PM +0200, Pavel Hrdina wrote:
There was a bug that if libvirtd binary has been updated than the
capability file wasn't reloaded therefore new capabilities introduced
in libvirt cannot be used because the cached
Sometimes libvirt is installed on a host that is already using the
network 192.168.122.0/24. If the libvirt-daemon-config-network package
is installed, this creates a conflict, since that package has been
hard-coded to create a virtual network that also uses
192.168.122.0/24. In the past libvirt
On 09/10/2014 08:08 AM, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
src/conf/domain_conf.h | 94
++
1 file changed, 57 insertions(+), 37 deletions(-)
Little light on the description.
There are those that would
On 09/10/2014 08:08 AM, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
src/libvirt_private.syms | 1 +
src/util/virstring.c | 25 +
src/util/virstring.h | 20
3 files changed, 46 insertions(+)
Not sure why
Authors: Simon Rastello (Bull), Adrien Kantcheff (Bull), Yves Vinter (Bull)
Summary of new added features by modules:
hyperv_driver.c
- hypervDomainDefineXML
- hypervDomainCreateXML
- hypervDomainUndefine
- hypervDomainUndefineFlags
- hypervDomainShutdown
- hypervDomainShutdownFlags
-
On 09/12/2014 10:36 AM, Yves Vinter wrote:
Authors: Simon Rastello (Bull), Adrien Kantcheff (Bull), Yves Vinter (Bull)
Summary of new added features by modules:
hyperv_driver.c
- hypervDomainDefineXML
- hypervDomainCreateXML
- hypervDomainUndefine
- hypervDomainUndefineFlags
-
On 09/12/2014 12:47 PM, John Ferlan wrote:
On 09/10/2014 08:08 AM, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
src/libvirt_private.syms | 1 +
src/util/virstring.c | 25 +
src/util/virstring.h | 20
3
Hello all,
I was recently trying out NUMA placement for my guests on both x86_64
and ppc64 machines. When booting a guest on the x86_64 machine, the
following specs were valid (obviously, just notable excepts from the xml):
memory unit='KiB'8388608/memory
currentMemory
Just realized that this is probably more suited for the users mailing
list. Please disregard, I'll move it there.
On Fri 12 Sep 2014 03:00:06 PM EDT, Michael Turek wrote:
Hello all,
I was recently trying out NUMA placement for my guests on both x86_64
and ppc64 machines. When booting a guest
On 09/12/2014 12:55 PM, Eric Blake wrote:
On 09/12/2014 10:36 AM, Yves Vinter wrote:
Authors: Simon Rastello (Bull), Adrien Kantcheff (Bull), Yves Vinter (Bull)
@@ -58,12 +64,97 @@ hypervFreePrivate(hypervPrivate **priv)
wsmc_release((*priv)-client);
}
+/* Bull */
+
On 09/12/2014 11:37 AM, Laine Stump wrote:
Sometimes libvirt is installed on a host that is already using the
network 192.168.122.0/24. If the libvirt-daemon-config-network package
is installed, this creates a conflict, since that package has been
hard-coded to create a virtual network that
On 09/10/2014 08:08 AM, Pavel Hrdina wrote:
This new event will use typedParameters to expose what has been actually
updated and the reason is that we can in the future extend the cputune.
With typedParameters we don't have to worry about creating some sort of
v2 of cputune event if there
On 09/10/2014 08:08 AM, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
examples/object-events/event-test.c | 52
-
1 file changed, 51 insertions(+), 1 deletion(-)
ACK
John
--
libvir-list mailing list
libvir-list@redhat.com
s//something to describe what's being done!
Might be nice to see what the event would look like when it's triggered.
May help in that documentation effort in the future.
On 09/10/2014 08:08 AM, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
src/qemu/qemu_cgroup.c |
[revisiting something that finally surfaced to the top of my todo list]
On 08/07/2014 03:57 AM, Peter Krempa wrote:
On 08/06/14 18:36, Eric Blake wrote:
Adam Litke has been asking if I can expose watermark information from\
bikeshedding
I'd be glad if we stopped calling this watermark. The
On 09/10/2014 06:08 AM, Pavel Hrdina wrote:
This new event will use typedParameters to expose what has been actually
updated and the reason is that we can in the future extend the cputune.
With typedParameters we don't have to worry about creating some sort of
v2 of cputune event if there will
On 09/10/2014 06:08 AM, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
src/qemu/qemu_cgroup.c | 18 -
src/qemu/qemu_driver.c | 73
++
2 files changed, 90 insertions(+), 1 deletion(-)
@@ -676,6 +677,10
On 09/10/2014 06:08 AM, Pavel Hrdina wrote:
This new event will use typedParameters to expose what has been actually
updated and the reason is that we can in the future extend the cputune.
With typedParameters we don't have to worry about creating some sort of
v2 of cputune event if there will
Thanks Michal... It seems to work ok now.
(My bad that I forgot about Martin's patch for memnode related binding)
Thanks!
Vinod
-Original Message-
From: Michal Privoznik [mailto:mpriv...@redhat.com]
Sent: Friday, September 12, 2014 12:40 AM
To: Vinod, Chegu
Cc:
82 matches
Mail list logo
