Re: [libvirt] [PATCH v2 3/4] conf: add virSocketAddrIsLocalhost to Check migration_host

2014-10-06 Thread Chen, Fan
On Fri, 2014-10-03 at 15:58 +0200, Ján Tomko wrote: > On 09/23/2014 06:04 AM, Chen Fan wrote: > > Signed-off-by: Chen Fan > > --- > > src/libvirt_private.syms | 1 + > > src/qemu/qemu_conf.c | 8 > > src/util/virsocketaddr.c | 35 +++ > > src/util/v

[libvirt] [PATCH v3 0/3] Check migration configuration

2014-10-06 Thread Chen Fan
add some check in migration configuration. Chen Fan (3): migration: add migration_host support for Ipv6 address without brackets conf: add check if migration_host is a localhost address conf: Check migration_address whether is localhost src/libvirt_private.syms | 3 +- src/q

[libvirt] [PATCH v3 3/3] conf: Check migration_address whether is localhost

2014-10-06 Thread Chen Fan
When enabling the migration_address option, by default it is set to "127.0.0.1", but it's not a valid address for migration. so we should add verification and set the default migration_address to "0.0.0.0". Signed-off-by: Chen Fan --- src/qemu/qemu.conf | 2 +- src/qemu/qemu_conf

[libvirt] [PATCH v3 1/3] migration: add migration_host support for Ipv6 address without brackets

2014-10-06 Thread Chen Fan
if specifying migration_host to an Ipv6 address without brackets, it was resolved to an incorrect address, such as: tcp:2001:0DB8::1428:, but the correct address should be: tcp:[2001:0DB8::1428]: so we should add brackets when parsing it. Signed-off-by: Chen Fan --- src/libvirt_p

[libvirt] [PATCH v3 2/3] conf: add check if migration_host is a localhost address

2014-10-06 Thread Chen Fan
Signed-off-by: Chen Fan --- src/libvirt_private.syms | 1 + src/qemu/qemu_conf.c | 50 src/qemu/qemu_conf.h | 2 ++ src/util/virsocketaddr.c | 24 +++ src/util/virsocketaddr.h | 2 ++ 5 files changed, 79 insertions(+

[libvirt] [PATCH v2 3/3] storage_conf: Resolve libvirtd crash matching scsi_host

2014-10-06 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1146837 Resolve a crash in libvirtd resulting from commit id 'a4bd62ad' (1.0.6) which added parentaddr and unique_id to allow unique identification of a scsi_host, but assumed that all the pool entries and the incoming definition would be similarly defin

[libvirt] [PATCH v2 2/3] virutil: Introduce virGetSCSIHostNameByParentaddr

2014-10-06 Thread John Ferlan
Create the function from the code in getAdapterName() in order to return the "host#" name for the provided parentaddr values. Signed-off-by: John Ferlan --- src/libvirt_private.syms | 1 + src/storage/storage_backend_scsi.c | 19 +-- src/util/virutil.c | 50

[libvirt] [PATCH v2 0/3] Resolve libvirtd crash matching scsi_host

2014-10-06 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1146837 Rewrite the v1 patch to take a different method to attack the problem. Expose the getHostNumber from scsi check/startup/refresh in the form of virGetSCSIHostNumber. Additionally, expose part of the getAdapterName code in the form of virGetSCSIHo

[libvirt] [PATCH v2 1/3] virutil: Introduce virGetSCSIHostNumber

2014-10-06 Thread John Ferlan
Create/use virGetSCSIHostNumber to replace the static getHostNumber Removed the "if (result &&" since result is now required to be non NULL on input. Signed-off-by: John Ferlan --- src/libvirt_private.syms | 1 + src/storage/storage_backend_scsi.c | 40 +++ sr

[libvirt] [PATCH 2/2] qemu: change macvtap multicast list in response to NIC_RX_FILTER_CHANGED

2014-10-06 Thread akrowiak
From: Tony Krowiak This patch adds functionality to processNicRxFilterChangedEvent(). The old and new multicast lists are compared and the filters in the macvtap are programmed to match the guest's filters. Signed-off-by: Tony Krowiak --- src/qemu/qemu_driver.c | 138 +

[libvirt] [PATCH 1/2] util: Functions to update host network device's multicast filter

2014-10-06 Thread akrowiak
From: Tony Krowiak This patch provides the utility functions to needed to synchronize the changes made to a guest domain network device's multicast filter with the corresponding macvtap device's filter on the host: * Get/add/remove multicast MAC addresses * Get the macvtap device's RX filter lis

[libvirt] [PATCH 0/2] Extend NIC_RX_FILTER_CHANGED event handler to process multicast list

2014-10-06 Thread akrowiak
From: Tony Krowiak This patch set extends the handler for qemu's NIC_RX_FILTER_CHANGED event. It adds code to compare the old and new multicast MAC address lists and programs the macvtap filters to match the guest. Tony Krowiak (2): util: Functions to update host network device's multicast

Re: [libvirt] [PATCH 4/4] storage_conf: Resolve libvirtd crash matching scsi_host

2014-10-06 Thread John Ferlan
On 10/06/2014 08:44 AM, Ján Tomko wrote: > On 10/06/2014 01:23 PM, John Ferlan wrote: <...snip...> >> >> If you mean we don't check that the name starts with 'scsi' or >> 'scsi_host', then sure I agree, but that would be a different bug or >> issue. I can certainly add a check if that's desire

Re: [libvirt] [PATCH 3/4] storage_conf: Fix the scsi_host.name comparison

2014-10-06 Thread John Ferlan
On 10/06/2014 08:45 AM, Ján Tomko wrote: > On 10/06/2014 01:03 PM, John Ferlan wrote: <...snip...> static bool +matchSCSIAdapterName(const char *pool_name, + const char *def_name) +{ +/* Names can be either "scsi_host#" or just "host#", w

Re: [libvirt] [PATCH v2] network: Add network bandwidth support for ethernet interfaces

2014-10-06 Thread Anirban Chakraborty
On 10/6/14, 11:16 AM, "Laine Stump" wrote: >On 10/06/2014 02:07 AM, Martin Kletzander wrote: >> On Fri, Sep 26, 2014 at 10:52:57AM -0700, Anirban Chakraborty wrote: >>> V2: >>> Addressed comments raised in review of V1. >>> Consolidate calls to virNetDevBandwidthSet. >>> Clear bandwidth setting

[libvirt] access for wiki editing

2014-10-06 Thread libvir . for . anomalyst
username anomalyst found a typo in Fedora/RHEL Bridging s/briding/bridging/ -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [RFC PATCH] include: make it easier to probe enum growth

2014-10-06 Thread Eric Blake
https://bugzilla.redhat.com/show_bug.cgi?id=1147639 is an example of a downstream distro's dilemma - when backporting a feature that is implemented in an ABI-compatible manner (no .so bump was required) but where the feature involves new bits to be defined in a flags variable, how does one write co

[libvirt] Features - virDomainOpenConsole

2014-10-06 Thread Andre Smith
Hi, We urgently need proper virDomainOpenConsole support for both VMware and Virtualbox. Since this is for our own commercial usage, my employer has authorized me to find a developer that can do the work quickly and properly and to pay them for their efforts. Please contact me directly at this e

Re: [libvirt] [PATCH/RFC] Add missing delta from Ubuntu to apparmor profiles

2014-10-06 Thread intrigeri
Hi, Daniel P. Berrange wrote (01 Oct 2014 09:04:09 GMT) : > I think it would be pretty reasonable to rename the files in have '.in' > suffixes, and then have a build script that expands 'if APPARMOR_VERSION' > conditionals to generate the final file. I agree it's the way to go, to avoid that each

Re: [libvirt] [PATCHv2 0/7] handle NIC_RX_FILTER_CHANGED events from qemu

2014-10-06 Thread Laine Stump
On 10/06/2014 10:32 AM, John Ferlan wrote: > > On 10/02/2014 12:39 PM, Laine Stump wrote: >> These patches set up an event handler for qemu's NIC_RX_FILTER_CHANGED >> event, which is sent whenever a guest makes a change to a network >> device's unicast/multicast filter, vlan table, or MAC address (

Re: [libvirt] [PATCH v2] network: Add network bandwidth support for ethernet interfaces

2014-10-06 Thread Laine Stump
On 10/06/2014 02:07 AM, Martin Kletzander wrote: > On Fri, Sep 26, 2014 at 10:52:57AM -0700, Anirban Chakraborty wrote: >> V2: >> Addressed comments raised in review of V1. >> Consolidate calls to virNetDevBandwidthSet. >> Clear bandwidth settings when the interface is detached or domain >> destroy

Re: [libvirt] [PATCH v2] network: Add network bandwidth support for ethernet interfaces

2014-10-06 Thread Anirban Chakraborty
On 10/5/14, 11:07 PM, "Martin Kletzander" wrote: >On Fri, Sep 26, 2014 at 10:52:57AM -0700, Anirban Chakraborty wrote: >>V2: >>Addressed comments raised in review of V1. >>Consolidate calls to virNetDevBandwidthSet. >>Clear bandwidth settings when the interface is detached or domain >>destroyed

Re: [libvirt] [libvirt-python PATCH] sanitytest: check for exported enums

2014-10-06 Thread Martin Kletzander
On Mon, Oct 06, 2014 at 08:41:45AM -0600, Eric Blake wrote: On 10/06/2014 04:32 AM, Martin Kletzander wrote: We are already collecting list of enums exported and list of enums we want to have available. Event hough there was an issue with one enum s/hough/though/ fixed with 014d9bbaf368b33a

[libvirt] [PATCHv2 2/3] qemu: call qemuDomainObjBeginJob/qemuDomainObjEndJob in qemuDomainSetInterfaceParameters

2014-10-06 Thread Shanzhi Yu
add call qemuDomainObjBeginJob/qemuDomainObjEndJob in qemuDomainSetInterfaceParameters Signed-off-by: Shanzhi Yu --- src/qemu/qemu_driver.c | 30 +++--- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 3

[libvirt] [PATCHv2 0/3] Save domain satus after change some parameters

2014-10-06 Thread Shanzhi Yu
Related bug: https://bugzilla.redhat.com/show_bug.cgi?id=1146511 Also add BeginJob/EndJob in qemuDomainSetBlkioParameters, qemuDomainSetInterfaceParameters,qemuDomainSetNumaParameters Shanzhi Yu (3): qemu: save domain status after set the blkio parameters qemu: call qemuDomainObjBeginJob/qem

[libvirt] [PATCHv2 1/3] qemu: save domain status after set the blkio parameters

2014-10-06 Thread Shanzhi Yu
After set the blkio parameters for running domain, save the change into live xml is needed to survive restarting the libvirtd, same story with bug 1146511, meanwhile add call qemuDomainObjBeginJob/qemuDomainObjEndJob in qemuDomainSetBlkioParameters Signed-off-by: Shanzhi Yu --- src/qemu/qemu_dri

[libvirt] [PATCHv2 3/3] qemu: save domain status after set domain's numa parameters

2014-10-06 Thread Shanzhi Yu
After set domain's numa parameters for running domain, save the change, save the change into live xml is needed to survive restarting the libvirtd, same story with bug 1146511; meanwihle add call qemuDomainObjBeginJob/qemuDomainObjEndJob in qemuDomainSetNumaParameters Signed-off-by: Shanzhi Yu --

Re: [libvirt] [PATCH 0/3] Fix hot unplug of scsi_host hostdev

2014-10-06 Thread John Ferlan
On 09/24/2014 09:11 AM, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1141732 > > Attempting to hot unplug a scsi_host device fails. The first patch > resolves the issue (and has some details in the commit message). The > second patch removes the now unnecessary virConnectPtr

Re: [libvirt] [libvirt-python PATCH] sanitytest: check for exported enums

2014-10-06 Thread Eric Blake
On 10/06/2014 04:32 AM, Martin Kletzander wrote: > We are already collecting list of enums exported and list of enums we > want to have available. Event hough there was an issue with one enum s/hough/though/ > fixed with 014d9bbaf368b33a881f1d6b2fd8a5dd285a4f71, there was no test > for it and th

Re: [libvirt] [PATCHv2 0/7] handle NIC_RX_FILTER_CHANGED events from qemu

2014-10-06 Thread John Ferlan
On 10/02/2014 12:39 PM, Laine Stump wrote: > These patches set up an event handler for qemu's NIC_RX_FILTER_CHANGED > event, which is sent whenever a guest makes a change to a network > device's unicast/multicast filter, vlan table, or MAC address (as long > as there has been no previous event of

Re: [libvirt] [PATCHv2 7/7] qemu: add short document on qemu event handlers

2014-10-06 Thread John Ferlan
On 10/02/2014 12:39 PM, Laine Stump wrote: > This text was in the commit log for the patch that added the event > handler for NIC_RX_FILTER_CHANGED, and John Ferlan expressed a desire > that the information not be "lost", so I've put it into a file in the > qemu directory, hoping that it might ca

Re: [libvirt] [PATCH 2/3] qemu: save domain status after set network interface's bandwidth parameters

2014-10-06 Thread Shanzhi Yu
- Original Message - | From: "Martin Kletzander" | To: "Shanzhi Yu" | Cc: libvir-list@redhat.com | Sent: Monday, October 6, 2014 5:43:13 PM | Subject: Re: [libvirt] [PATCH 2/3] qemu: save domain status after set network interface's bandwidth parameters | | On Mon, Sep 29, 2014 at 06:4

Re: [libvirt] [PATCH 1/3] qemu: Fix hot unplug of SCSI_HOST device

2014-10-06 Thread Laine Stump
On 10/06/2014 09:36 AM, John Ferlan wrote: > > On 10/03/2014 12:06 PM, Laine Stump wrote: >> On 09/24/2014 09:11 AM, John Ferlan wrote: >>> https://bugzilla.redhat.com/show_bug.cgi?id=1141732 >>> >>> Introduced by commit id '8f76ad99' the logic to detach a scsi_host >>> device (SCSI or iSCSI) fails

Re: [libvirt] [PATCH v3 00/14] vbox: rewrite network driver

2014-10-06 Thread Eric Blake
On 10/01/2014 09:30 PM, Taowei wrote: > This seriers of patches rewrite the vbox network driver. > > Diff from v2: > *Seperate the network driver from the domain driver. > *Prevent vbox code from being compiled too many times > when building network driver. > > Taowei (14): Usually, it's a

Re: [libvirt] [PATCH 1/3] qemu: Fix hot unplug of SCSI_HOST device

2014-10-06 Thread John Ferlan
On 10/03/2014 12:06 PM, Laine Stump wrote: > On 09/24/2014 09:11 AM, John Ferlan wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1141732 >> >> Introduced by commit id '8f76ad99' the logic to detach a scsi_host >> device (SCSI or iSCSI) fails when attempting to remove the 'drive' >> because

Re: [libvirt] [PATCH] Include .libs in libdir in source tree pkg-config files

2014-10-06 Thread Ján Tomko
On 10/06/2014 01:29 PM, Michal Privoznik wrote: > On 01.10.2014 15:11, Ján Tomko wrote: >> This lets me build against an uninstalled source tree without >> libtool. >> --- >> src/libvirt-lxc.pc.in | 2 +- >> src/libvirt-qemu.pc.in | 2 +- >> src/libvirt.pc.in | 2 +- >> 3 files changed,

Re: [libvirt] [PATCH 3/4] storage_conf: Fix the scsi_host.name comparison

2014-10-06 Thread Ján Tomko
On 10/06/2014 01:03 PM, John Ferlan wrote: > > > On 10/03/2014 09:20 AM, Ján Tomko wrote: >> On 09/30/2014 11:35 PM, John Ferlan wrote: >>> Since the 'scsi_host#' concept was introduced in commit id '9f781da6' it >>> is possible to provide either "name='host#'" or "name='scsi_host#'" to >>> defin

Re: [libvirt] [PATCH 4/4] storage_conf: Resolve libvirtd crash matching scsi_host

2014-10-06 Thread Ján Tomko
On 10/06/2014 01:23 PM, John Ferlan wrote: > > > On 10/03/2014 09:20 AM, Ján Tomko wrote: >> On 09/30/2014 11:35 PM, John Ferlan wrote: >>> https://bugzilla.redhat.com/show_bug.cgi?id=1146837 >>> >>> Resolve a crash in libvirtd resulting from commit id 'a4bd62ad' (1.0.6) >>> which added parentadd

Re: [libvirt] [PATCH] Include .libs in libdir in source tree pkg-config files

2014-10-06 Thread Michal Privoznik
On 01.10.2014 15:11, Ján Tomko wrote: This lets me build against an uninstalled source tree without libtool. --- src/libvirt-lxc.pc.in | 2 +- src/libvirt-qemu.pc.in | 2 +- src/libvirt.pc.in | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/libvirt-lxc.pc.in b

Re: [libvirt] [PATCH 4/4] storage_conf: Resolve libvirtd crash matching scsi_host

2014-10-06 Thread John Ferlan
On 10/03/2014 09:20 AM, Ján Tomko wrote: > On 09/30/2014 11:35 PM, John Ferlan wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1146837 >> >> Resolve a crash in libvirtd resulting from commit id 'a4bd62ad' (1.0.6) >> which added parentaddr and unique_id to allow unique identification of >> a

Re: [libvirt] [PATCH] docs: fix a typo in drvlxc

2014-10-06 Thread Michal Privoznik
On 06.10.2014 11:28, Chen Hanxiao wrote: s/the/The Signed-off-by: Chen Hanxiao --- docs/drvlxc.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/drvlxc.html.in b/docs/drvlxc.html.in index 31da37c..a094bd9 100644 --- a/docs/drvlxc.html.in +++ b/docs/drvlxc.html.

Re: [libvirt] [PATCH 3/4] storage_conf: Fix the scsi_host.name comparison

2014-10-06 Thread John Ferlan
On 10/03/2014 09:20 AM, Ján Tomko wrote: > On 09/30/2014 11:35 PM, John Ferlan wrote: >> Since the 'scsi_host#' concept was introduced in commit id '9f781da6' it >> is possible to provide either "name='host#'" or "name='scsi_host#'" to >> define/name the scsi_host adapter source address. The con

Re: [libvirt] [PATCH-RFC-V2] qemu: Add network bandwidth setting for ethernet interfaces

2014-10-06 Thread Michal Privoznik
On 18.09.2014 01:33, Anirban Chakraborty wrote: V2: Consolidate calls to virNetDevBandwidthSet Clear bandwidth settings when the interface is detached or domain destroyed V1: Ethernet interfaces in libvirt currently do not support bandwidth setting. For example, following xml file for an interfa

[libvirt] [libvirt-python PATCH] sanitytest: check for exported enums

2014-10-06 Thread Martin Kletzander
We are already collecting list of enums exported and list of enums we want to have available. Event hough there was an issue with one enum fixed with 014d9bbaf368b33a881f1d6b2fd8a5dd285a4f71, there was no test for it and this commit tries to fix that. Signed-off-by: Martin Kletzander --- sanity

Re: [libvirt] [PATCH 2/3] qemu: save domain status after set network interface's bandwidth parameters

2014-10-06 Thread Martin Kletzander
On Mon, Sep 29, 2014 at 06:49:34PM +0800, Shanzhi Yu wrote: After set network interface's bandwidth for running domain, save the change into live xml is needed to survive restarting the libvirtd, same story with bug 1146511, meanwhile add call qemuDomainObjBeginJob/qemuDomainObjEndJob in qemuDoma

[libvirt] [PATCH] docs: fix a typo in drvlxc

2014-10-06 Thread Chen Hanxiao
s/the/The Signed-off-by: Chen Hanxiao --- docs/drvlxc.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/drvlxc.html.in b/docs/drvlxc.html.in index 31da37c..a094bd9 100644 --- a/docs/drvlxc.html.in +++ b/docs/drvlxc.html.in @@ -167,7 +167,7 @@ numbered incrementally

Re: [libvirt] [PATCH 3/5] libxl: Add function to determine device model type

2014-10-06 Thread Michal Privoznik
On 19.09.2014 21:23, Jim Fehlig wrote: This patch introduces a function to detect whether the specified emulator is QEMU_XEN or QEMU_XEN_TRADITIONAL. Detection is based on the string "Options specific to the Xen version:" in '$qemu -help' output. AFAIK, the only qemu containing that string in he

Re: [libvirt] [PATCH 2/5] Xen: Defer setting default vram value to Xen drivers

2014-10-06 Thread Michal Privoznik
On 19.09.2014 21:23, Jim Fehlig wrote: Allow the Xen drivers to determine default vram values. Sane default vaules depend on the device model being used, so the drivers are in the best position to determine the defaults. For the legacy xen driver, it is best to maintain the existing logic for s

Re: [libvirt] [PATCH 0/5] libxl: user-specified domain config improvements

2014-10-06 Thread Michal Privoznik
On 19.09.2014 21:23, Jim Fehlig wrote: This is essentially a V2 of Stefan's patch to add support for user-specified video device in the libxl driver. https://www.redhat.com/archives/libvir-list/2014-September/msg01157.html It goes a bit further and adds support for user-specfied , which was tri

Re: [libvirt] [PATCH 5/5] libxl: Support user-specified

2014-10-06 Thread Michal Privoznik
On 19.09.2014 21:23, Jim Fehlig wrote: With the introduction of the libxlDomainGetEmulatorType function, it is trivial to support a user-specfied in the libxl driver. This patch is based loosely on David Scott's old patch to do the same https://www.redhat.com/archives/libvir-list/2013-April/ms