Re: [libvirt] [PATCH 5/9] util: json: Split out code to create json value objects

2014-10-15 Thread Peter Krempa
On 10/14/14 12:46, John Ferlan wrote: On 10/14/2014 03:29 AM, Peter Krempa wrote: Our qemu monitor code has a converter from key-value pairs to a json value object. I want to re-use the code later and having it part of the monitor command generator is inflexible. Split it out into a

[libvirt] [PATCH] conf: fix a wrong comment in virSocketAddrNumericFamily()

2014-10-15 Thread Chen Fan
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com --- src/util/virsocketaddr.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/util/virsocketaddr.c b/src/util/virsocketaddr.c index a19e3af..8c9f05f 100644 --- a/src/util/virsocketaddr.c +++ b/src/util/virsocketaddr.c

[libvirt] [PATCH] conf: fix a wrong comment in virSocketAddrNumericFamily()

2014-10-15 Thread Chen Fan
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com --- src/util/virsocketaddr.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/util/virsocketaddr.c b/src/util/virsocketaddr.c index a19e3af..8c9f05f 100644 --- a/src/util/virsocketaddr.c +++ b/src/util/virsocketaddr.c

[libvirt] [PATCH] Cleanup maintainers list

2014-10-15 Thread Jiri Denemark
These Signed-off-by: Jiri Denemark jdene...@redhat.com Signed-off-by: Jiri Denemark jdene...@redhat.com --- AUTHORS.in | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/AUTHORS.in b/AUTHORS.in index 0e0e613..3c783f7 100644 --- a/AUTHORS.in +++ b/AUTHORS.in @@

Re: [libvirt] [PATCH] Cleanup maintainers list

2014-10-15 Thread Peter Krempa
On 10/15/14 10:04, Jiri Denemark wrote: These Signed-off-by: Jiri Denemark jdene...@redhat.com Signed-off-by: Jiri Denemark jdene...@redhat.com Your commit message is terribly broken. --- AUTHORS.in | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

Re: [libvirt] [PATCH] Cleanup maintainers list

2014-10-15 Thread Daniel P. Berrange
On Wed, Oct 15, 2014 at 10:04:10AM +0200, Jiri Denemark wrote: These Signed-off-by: Jiri Denemark jdene...@redhat.com Signed-off-by: Jiri Denemark jdene...@redhat.com ACK with fixed commit message :-) --- AUTHORS.in | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-)

Re: [libvirt] [PATCH] conf: fix a wrong comment in virSocketAddrNumericFamily()

2014-10-15 Thread Ján Tomko
On 10/15/2014 09:50 AM, Chen Fan wrote: Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com --- src/util/virsocketaddr.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) ACK and pushed, thanks for catching that. Jan signature.asc Description: OpenPGP digital signature --

Re: [libvirt] [PATCH] Cleanup maintainers list

2014-10-15 Thread Jiri Denemark
On Wed, Oct 15, 2014 at 09:13:21 +0100, Daniel Berrange wrote: On Wed, Oct 15, 2014 at 10:04:10AM +0200, Jiri Denemark wrote: These Signed-off-by: Jiri Denemark jdene...@redhat.com Signed-off-by: Jiri Denemark jdene...@redhat.com ACK with fixed commit message :-) Yeah, no idea what

Re: [libvirt] [PATCH] libvirt: Document UNDEFINE_NVRAM in UndefineFlags doc

2014-10-15 Thread Cole Robinson
On 10/14/2014 12:46 PM, Martin Kletzander wrote: On Tue, Oct 14, 2014 at 12:03:59PM +0200, Cole Robinson wrote: --- src/libvirt.c | 4 1 file changed, 4 insertions(+) diff --git a/src/libvirt.c b/src/libvirt.c index caacc2e..dfca4f6 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@

Re: [libvirt] [PATCH 9/9] conf: Move definition of virDomainParseMemory

2014-10-15 Thread Peter Krempa
On 10/14/14 12:59, John Ferlan wrote: On 10/14/2014 03:29 AM, Peter Krempa wrote: Shove it to the top of the file so that it can be reused earlier. --- src/conf/domain_conf.c | 60 +- 1 file changed, 30 insertions(+), 30 deletions(-)

Re: [libvirt] [PATCH v3 2/3] conf: add check if migration_host is a localhost address

2014-10-15 Thread John Ferlan
This patch has triggered a Coverity RESOURCE_LEAK (3 actually) On 10/08/2014 09:54 PM, Chen, Fan wrote: On Wed, 2014-10-08 at 12:33 +0200, Ján Tomko wrote: On 10/07/2014 06:07 AM, Chen Fan wrote: Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com diff --git a/src/util/virsocketaddr.c

Re: [libvirt] [PATCH v3 2/3] conf: add check if migration_host is a localhost address

2014-10-15 Thread Chen, Fan
On Wed, 2014-10-15 at 04:46 -0400, John Ferlan wrote: This patch has triggered a Coverity RESOURCE_LEAK (3 actually) Right, I will make a patch to fix it. Thank you for catching that. On 10/08/2014 09:54 PM, Chen, Fan wrote: On Wed, 2014-10-08 at 12:33 +0200, Ján Tomko wrote: On

[libvirt] [PATCH] conf: fix an memory leak in virSocketAddrIsNumericLocalhost()

2014-10-15 Thread Chen Fan
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com --- src/util/virsocketaddr.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/util/virsocketaddr.c b/src/util/virsocketaddr.c index 8c9f05f..5f54e68 100644 --- a/src/util/virsocketaddr.c +++

Re: [libvirt] [PATCH] conf: fix an memory leak in virSocketAddrIsNumericLocalhost()

2014-10-15 Thread Ján Tomko
On 10/15/2014 11:36 AM, Chen Fan wrote: Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com --- src/util/virsocketaddr.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) ACK and pushed. Jan signature.asc Description: OpenPGP digital signature -- libvir-list mailing

[libvirt] [PATCH 5/5] qemu: Convert qemuDomainUpdateDeviceConfig to typecasted enum

2014-10-15 Thread Peter Krempa
--- src/qemu/qemu_driver.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 92fd42e..7377320 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -7314,8 +7314,7 @@

[libvirt] [PATCH 2/5] qemu: Convert qemuDomainUpdateDeviceLive to typecasted enum

2014-10-15 Thread Peter Krempa
--- src/qemu/qemu_driver.c | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index b981e05..31d48b2 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -7025,7 +7025,7 @@

[libvirt] [PATCH 3/5] qemu: Convert qemuDomainAttachDeviceConfig to typecasted enum

2014-10-15 Thread Peter Krempa
--- src/qemu/qemu_driver.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 31d48b2..66fbcf2 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -7074,7 +7074,7 @@

[libvirt] [PATCH 0/5] qemu: Fix rest of hot/cold-add/remove device functions to use typecasted switch

2014-10-15 Thread Peter Krempa
Tweak the rest of the stuff to get notified at compile time when adding a new device type to implement it's backend functions. Peter Krempa (5): qemu: Convert qemuDomainDetachDeviceLive to typecasted enum qemu: Convert qemuDomainUpdateDeviceLive to typecasted enum qemu: Convert

[libvirt] [PATCH 1/5] qemu: Convert qemuDomainDetachDeviceLive to typecasted enum

2014-10-15 Thread Peter Krempa
--- src/qemu/qemu_driver.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index e0fd4c0..b981e05 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -6910,7 +6910,7 @@

[libvirt] [PATCH 4/5] qemu: Convert qemuDomainDetachDeviceConfig to typecasted enum

2014-10-15 Thread Peter Krempa
--- src/qemu/qemu_driver.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 66fbcf2..92fd42e 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -7205,7 +7205,7 @@

Re: [libvirt] [PATCH 0/5] qemu: Fix rest of hot/cold-add/remove device functions to use typecasted switch

2014-10-15 Thread John Ferlan
On 10/15/2014 06:44 AM, Peter Krempa wrote: Tweak the rest of the stuff to get notified at compile time when adding a new device type to implement it's backend functions. Peter Krempa (5): qemu: Convert qemuDomainDetachDeviceLive to typecasted enum qemu: Convert

Re: [libvirt] [PATCH 0/5] qemu: Fix rest of hot/cold-add/remove device functions to use typecasted switch

2014-10-15 Thread Peter Krempa
On 10/15/14 12:57, John Ferlan wrote: On 10/15/2014 06:44 AM, Peter Krempa wrote: Tweak the rest of the stuff to get notified at compile time when adding a new device type to implement it's backend functions. Peter Krempa (5): qemu: Convert qemuDomainDetachDeviceLive to typecasted enum

[libvirt] [libvirt-python PATCH 1/1] Change the comment in getPyNodeCPUCount method reflecting correct called methods

2014-10-15 Thread Pradipta Kr. Banerjee
Comment mentions virGetNodeCPUMap whereas the actual method is virNodeGetCPUMap. Similarly comment mentions virGetNodeInfo whereas the actual method is virNodeGetInfo Signed-off-by: Pradipta Kr. Banerjee bpra...@in.ibm.com --- libvirt-override.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [libvirt] [PATCH] qemu: command: Allow UEFI for non-x86

2014-10-15 Thread Michal Privoznik
On 14.10.2014 09:42, Cole Robinson wrote: It's supported on aarch64 and armv7l as well, so just drop the restriction entirely since it doesn't add much. --- src/qemu/qemu_command.c | 8 1 file changed, 8 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c

Re: [libvirt] [PATCH v4] network: Add bandwidth support to ethernet interfaces

2014-10-15 Thread Anirban Chakraborty
On 10/10/14, 3:23 PM, Anirban Chakraborty abc...@juniper.net wrote: v4: Changed function virNetDevSupportBandwidth to use switch statement. Fixed syntax issues Fold the two patches into one as the second patch was a one liner v3: Addressed issues pointed out in V2 Split into two patches v2:

Re: [libvirt] [PATCH 0/5] Guest filesystem information API

2014-10-15 Thread Tomoki Sekiyama
Could someone review this patchset please? Any comment is appreciated! Regards, Tomoki Sekiyama On 9/30/14, 20:19 , Tomoki Sekiyama tomoki.sekiy...@hds.com wrote: Hi, This series implements a new virDomainGetFSInfo API, that returns a list of mounted filesystems information in the guest,

[libvirt] [PATCH] tools: compatible with old wireshark

2014-10-15 Thread Jincheng Miao
Old version wireshark doesn't have ws_symbol_export.h, which is added from wireshark-v1.10.0. But some distros, like RHEL6u5, only have wireshark-v1.8, so libvirt should be compatible with these wiresharks. Signed-off-by: Jincheng Miao jm...@redhat.com --- configure.ac