virStorageFileBackendGlusterInit did not check nhosts.
https://bugzilla.redhat.com/show_bug.cgi?id=1162974
---
src/storage/storage_backend_gluster.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/src/storage/storage_backend_gluster.c
On 11/12/14 09:37, Ján Tomko wrote:
virStorageFileBackendGlusterInit did not check nhosts.
https://bugzilla.redhat.com/show_bug.cgi?id=1162974
---
src/storage/storage_backend_gluster.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
ACK,
Peter
signature.asc
https://bugzilla.redhat.com/show_bug.cgi?id=1162974
When do external snapshot for a gluster disk with no host name(ip) in
snapshot xml, libvirtd will crash. Because when node do not have a children
in virDomainStorageHostParse, libvirt will return 0, but donnot get hosts for
On 11/12/14 09:47, Luyao Huang wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1162974
When do external snapshot for a gluster disk with no host name(ip) in
snapshot xml, libvirtd will crash. Because when node do not have a children
in virDomainStorageHostParse, libvirt will return 0, but
On 11/12/2014 04:50 PM, Peter Krempa wrote:
On 11/12/14 09:47, Luyao Huang wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1162974
When do external snapshot for a gluster disk with no host name(ip) in
snapshot xml, libvirtd will crash. Because when node do not have a children
in
On 11.11.2014 15:52, Michal Privoznik wrote:
On 08.11.2014 17:48, Conrad Meyer wrote:
Looking good. Basically ACK to the patches. BUT, please post a follow-up
patches to 1/7 and 5/7 (as reply to individual patches or cover letter
ideally). I don't want to make you to send another version.
On 11.11.2014 17:12, Conrad Meyer wrote:
On Tue, Nov 11, 2014 at 10:40 AM, Michal Privoznik mpriv...@redhat.com wrote:
On 11.11.2014 16:17, Conrad Meyer wrote:
On Tue, Nov 11, 2014 at 9:52 AM, Michal Privoznik mpriv...@redhat.com
wrote:
One of the things I'm worried about is, if the boot
On 11.11.2014 16:35, Conrad Meyer wrote:
---
src/bhyve/bhyve_capabilities.c | 37 +
src/bhyve/bhyve_capabilities.h | 6 ++
2 files changed, 43 insertions(+)
diff --git a/src/bhyve/bhyve_capabilities.c b/src/bhyve/bhyve_capabilities.c
index
On 11/11/2014 06:40 PM, John Ferlan wrote:
On 11/11/2014 11:34 AM, Pavel Hrdina wrote:
On 11/11/2014 04:13 PM, John Ferlan wrote:
On 11/05/2014 09:02 AM, Pavel Hrdina wrote:
Commit 6e5c79a1 tried to fix deadlock between nwfilter{Define,Undefine}
and starting of guest, but this same
On 11/11/2014 04:20 PM, Daniel P. Berrange wrote:
On Wed, Nov 05, 2014 at 03:02:03PM +0100, Pavel Hrdina wrote:
Commit 6e5c79a1 tried to fix deadlock between nwfilter{Define,Undefine}
and starting of guest, but this same deadlock is also for
updating/attaching network device to domain.
The
Commit 6e5c79a1 tried to fix deadlock between nwfilter{Define,Undefine}
and starting of guest, but this same deadlock is also for
updating/attaching network device to domain.
The deadlock was introduced by removing global QEMU driver lock because
nwfilter was counting on this lock and ensure that
On 11/11/14 15:54, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_capabilities.c | 3 +++
src/qemu/qemu_capabilities.h | 1 +
2 files changed, 4 insertions(+)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index
s/imput/input/
Jan
signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On 11/11/14 15:54, Martin Kletzander wrote:
This function returns true if the value supplied is a modifier (Ctrl,
Shift, Alt or Meta).
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/libvirt_private.syms | 1 +
src/util/virkeycode.c| 21 +
On Tue, Nov 11, 2014 at 1:20 PM, John Ferlan jfer...@redhat.com wrote:
On 10/29/2014 08:16 AM, Matthias Gatto wrote:
Check the arability of the options with the current qemu binary,
add them in the varable opt if yes, print a message if not.
Signed-off-by: Matthias Gatto
On 11/11/14 15:54, Martin Kletzander wrote:
When using modifiers with send-key, then we cannot know with what keys
those modifiers should be pressed down. QEMU changed the order of the
release events few times and that caused few send-key command to work
differently than expected.
We
On 11.11.2014 23:45, Anirban Chakraborty wrote:
On 11/10/14, 3:13 PM, Eric Blake ebl...@redhat.com wrote:
On 11/10/2014 03:41 PM, Anirban Chakraborty wrote:
BTW: it would be nice if you can version you patches. I mean, this is
what, 4th or 5th version? Say that in subject explicitly
Fix for this:
http://www.redhat.com/archives/libvir-list/2014-November/msg00324.html
Signed-off-by: Matthias Gatto matthias.ga...@outscale.com
---
src/qemu/qemu_command.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index
reported here:
http://www.redhat.com/archives/libvir-list/2014-November/msg00327.html
I could have just remove bool supportMaxOptions variable, but
if I had do this, we could not check anymore if the nparams variable is
superior to QEMU_NB_BLOCK_IO_TUNE_PARAM_MAX.
Signed-off-by: Matthias Gatto
Fix the errors reported by John Ferlan about therse patchs:
http://www.redhat.com/archives/libvir-list/2014-November/msg00327.html
http://www.redhat.com/archives/libvir-list/2014-November/msg00324.html
Matthias Gatto (2):
qemu: Fix copy_paste_error in qemuBuildDriveStr.
qemu: Fix DEATHCODE
On 11/12/2014 08:04 AM, Matthias Gatto wrote:
Fix for this:
http://www.redhat.com/archives/libvir-list/2014-November/msg00324.html
Signed-off-by: Matthias Gatto matthias.ga...@outscale.com
---
src/qemu/qemu_command.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
ACK
John
On 11/12/2014 02:04 PM, Matthias Gatto wrote:
Fix for this:
http://www.redhat.com/archives/libvir-list/2014-November/msg00324.html
Signed-off-by: Matthias Gatto matthias.ga...@outscale.com
---
src/qemu/qemu_command.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Need to fix the commit message to something like Resolve Coverity DEADCODE
(something I just realized for 1/2 which could read Resolve Coverity
COPY_PASTE_ERROR
Something I can take care of when pushing.
On 11/12/2014 08:04 AM, Matthias Gatto wrote:
reported here:
As I was reviewing bhyve commits, I've noticed qemuxml2argvtest
failing for some test cases. This is not bug in qemu driver code
rather than being unable to load qemuxml2argvmock on non-Linux
platforms. For instance:
318) QEMU XML-2-ARGV numatune-memnode
... libvirt: error : internal error: NUMA
On Wed, Nov 12, 2014 at 01:28:38PM +0100, Michal Privoznik wrote:
As I was reviewing bhyve commits, I've noticed qemuxml2argvtest
failing for some test cases. This is not bug in qemu driver code
rather than being unable to load qemuxml2argvmock on non-Linux
platforms. For instance:
318)
On Wed, Nov 12, 2014 at 4:07 AM, Michal Privoznik mpriv...@redhat.com wrote:
On 11.11.2014 16:35, Conrad Meyer wrote:
+/* These are bit flags: */
+enum {
+BHYVE_GRUB_CAP_CONSDEV = 0x0001,
+};
I think this should be rather typedef enum {...} virBhyveGrubCapsFlags;
Ok.
+int
On 11/12/2014 07:18 AM, Ján Tomko wrote:
On 11/12/2014 02:04 PM, Matthias Gatto wrote:
Fix for this:
http://www.redhat.com/archives/libvir-list/2014-November/msg00324.html
Signed-off-by: Matthias Gatto matthias.ga...@outscale.com
---
src/qemu/qemu_command.c | 2 +-
1 file changed, 1
On Wed, Nov 12, 2014 at 1:27 PM, John Ferlan jfer...@redhat.com wrote:
Need to fix the commit message to something like Resolve Coverity DEADCODE
(something I just realized for 1/2 which could read Resolve Coverity
COPY_PASTE_ERROR
Something I can take care of when pushing.
On
As we now have a deep copy function for struct virStorageSource add a
notice that extensions of the structure require also appropriate changes
to the virStorageSourceCopy func.
---
src/util/virstoragefile.h | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git
After recent refactors, starting a VM whose disk is backed by RBD storage would
fail as the parser for the backing file specification string was not
implemented in the metadata crawler.
Reuse qemu's parser to do this and fix a few things around.
Peter Krempa (12):
docs: domain: Move docs for
Instead of spliting out various fields, pass the complete structure and
let the function pick various things of it.
As one of the callers isn't using virStorageSourcePtr to store the data,
this patch adds glue code that fills the data into a dummy
virStorageSourcePtr before calling the func.
Split out the code so that the function looks homogenous after adding
more protocol specific parsers.
---
src/util/virstoragefile.c | 141 --
1 file changed, 86 insertions(+), 55 deletions(-)
diff --git a/src/util/virstoragefile.c
The escaping is applied only to the string, not the formating argument.
State this fact in the docs.
---
src/util/virbuffer.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/util/virbuffer.c b/src/util/virbuffer.c
index 52ffa08..30a4183 100644
---
To be able to fully test parsing of networked storage strings we need to
add a few fields for: hostname, protocol and auth string.
---
tests/virstoragetest.c | 22 +++---
1 file changed, 19 insertions(+), 3 deletions(-)
diff --git a/tests/virstoragetest.c b/tests/virstoragetest.c
As we now have a common function to parse backing store string for RBD
backing store we can reuse it in the backing store walker so that we
don't fail on files backed by RBD storage.
This patch also adds a few tests to verify that the parsing works as
expected.
---
src/util/virstoragefile.c | 6
The docs describing the host element that are under the source
element in the XML document were incorrectly placed under the disk
element. Move them to the correct place.
---
docs/formatdomain.html.in | 104 --
1 file changed, 54 insertions(+), 50
To be able to express some use cases of the RBD backing with libvirt, we
need to be able to specify a config file for the RBD client to qemu as
that is one of the commonly used options.
---
docs/formatdomain.html.in | 8
docs/schemas/domaincommon.rng
Some storage systems have internal support for snapshots. Libvirt should
be able to select a correct snapshot when starting a VM.
This patch adds a XML element to select a storage source snapshot for
the RBD protocol which supports this feature.
---
docs/formatdomain.html.in
To allow reuse this non-trivial parser code in the backing store parser
this part of the command line parser needs to be split out into a
separate funciton.
---
src/libvirt_private.syms | 1 +
src/qemu/qemu_command.c | 133 +++---
src/util/virstoragefile.c
Addition of tested cases to the test will be more obvious.
---
.../qemuxml2argvdata/qemuxml2argv-disk-drive-network-rbd.args | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-rbd.args
If there are no hosts for a storage source virStorageSourceCopy would
try to copy them anyways. As the success of virStorageNetHostDefCopy is
determined by returning a pointer and malloc of 0 elements might return
NULL according to the implementation, the result of the copy function
may vary.
Fix
reported here:
http://www.redhat.com/archives/libvir-list/2014-November/msg00327.html
I could have just remove bool supportMaxOptions variable, but
if I had do this, we could not check anymore if the nparams variable is
superior to QEMU_NB_BLOCK_IO_TUNE_PARAM_MAX.
v2: change following this
On 11.11.2014 16:21, John Ferlan wrote:
On 11/11/2014 10:05 AM, Michal Privoznik wrote:
On 11.11.2014 13:38, John Ferlan wrote:
On 11/11/2014 07:21 AM, Michal Privoznik wrote:
On 10.11.2014 23:45, John Ferlan wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1160565
If a 'parent'
On 10.11.2014 23:45, John Ferlan wrote:
This series will replace:
http://www.redhat.com/archives/libvir-list/2014-November/msg00197.html
There are two bugs being fixed here and having them reviewed together
makes things easier in the long run as the last 3 patches depended upon
the first 2
On 11/12/2014 10:53 AM, Matthias Gatto wrote:
reported here:
http://www.redhat.com/archives/libvir-list/2014-November/msg00327.html
I could have just remove bool supportMaxOptions variable, but
if I had do this, we could not check anymore if the nparams variable is
superior to
The API docs generators were broken by the header file
re-organization. Specifically
* html/libvirt-libvirt.html was empty (and should be deleted)
* Makefile.am didn't install html/libvirt-libvirt-*.html
* hvsupport.html was mostly empty
* sitemap.html.in didn't list the new html/*.html files
Found missing 'size_iops_sec' check in qemu_command.c.
Add a test for the new blkdeviotune parameters.
John Ferlan (2):
qemu: Add checks for blkdeviotune 'size_iops_sec' and adjust error
qemu: Add tests for new blkdeviotune arguments
src/qemu/qemu_command.c| 10
The recent commit to add support for block_set_io_throttle parameters
from version 1.7 of qemu did not add any tests - this adds the tests
Signed-off-by: John Ferlan jfer...@redhat.com
---
.../qemuxml2argv-blkdeviotune-max.args | 12 +
.../qemuxml2argv-blkdeviotune-max.xml
Seems the 'size_iops_sec' was a late add and the checks for whether
the field was defined, but unsupported and the maximum size of the
field were not being made.
Also, adjust blkdeviotune support error message for grammar, spelling
(paramater), and remove the (need QEMU 1.7 or superior). None of
On 11/12/2014 09:31 AM, Michal Privoznik wrote:
On 10.11.2014 23:45, John Ferlan wrote:
John Ferlan (5):
storage: Check for valid fc_host parent at startup
storage: Ensure fc_host parent matches wwnn/wwpn
storage: Don't use a stack copy of the adapter
storage: Introduce
Since QEMU 1.2.0, we switched to QMP probing instead of parsing -help
(and other commands, such as -cpu ?) output. However, if QMP probing
failed, we still tried starting QEMU with various options and parsing
the output, which was guaranteed to fail because the output changed.
Let's just refuse
On 11/12/2014 04:51 AM, Pavel Hrdina wrote:
Commit 6e5c79a1 tried to fix deadlock between nwfilter{Define,Undefine}
and starting of guest, but this same deadlock is also for
s/is also/exists/
updating/attaching network device to domain.
The deadlock was introduced by removing global QEMU
On Wed, Nov 12, 2014 at 11:50:18AM +0100, Peter Krempa wrote:
On 11/11/14 15:54, Martin Kletzander wrote:
When using modifiers with send-key, then we cannot know with what keys
those modifiers should be pressed down. QEMU changed the order of the
release events few times and that caused few
Literally couple.
Michal Privoznik (2):
qemu: Delete nvram store for transient domains too
qemuPrepareNVRAM: Save domain conf only if domain's persistent
src/conf/domain_conf.c | 10 --
src/conf/domain_conf.h | 1 +
src/qemu/qemu_driver.c | 3 ++-
src/qemu/qemu_process.c | 25
There are two ways how to use nvram variable store file in
libvirt:
1) create it by hand and pass the path in domain XML
2) let libvirt generate path and create the file
Now, we allow users to remove the file from case 2) by passing a
flag into the virDomainUndefineFlags(). But when
In one of my previous patches (3a3c3780b) I've tried to fix the
problem of nvram path disappearing on a domain that's been
started and shut down again. I fixed this by explicitly saving
domain's config file. However, I did a bit of clumsy without
realizing we have a transient domains for which we
On 11/12/14 17:09, Jiri Denemark wrote:
Since QEMU 1.2.0, we switched to QMP probing instead of parsing -help
(and other commands, such as -cpu ?) output. However, if QMP probing
failed, we still tried starting QEMU with various options and parsing
the output, which was guaranteed to fail
On 06.11.2014 15:31, Eric Blake wrote:
On 11/06/2014 02:01 PM, Michal Privoznik wrote:
This flag can be used to sync the domain's time right after
domain CPUs are started. It's basically backing call of two
subsequent APIs into one:
1) virDomainResume(dom)
2) virDomainSetTime(dom, 0, 0,
On 11/12/14 18:26, Michal Privoznik wrote:
In one of my previous patches (3a3c3780b) I've tried to fix the
problem of nvram path disappearing on a domain that's been
started and shut down again. I fixed this by explicitly saving
domain's config file. However, I did a bit of clumsy without
On Wed, Nov 12, 2014 at 18:37:15 +0100, Peter Krempa wrote:
On 11/12/14 17:09, Jiri Denemark wrote:
Since QEMU 1.2.0, we switched to QMP probing instead of parsing -help
(and other commands, such as -cpu ?) output. However, if QMP probing
failed, we still tried starting QEMU with various
On 12.11.2014 16:00, Daniel P. Berrange wrote:
The API docs generators were broken by the header file
re-organization. Specifically
* html/libvirt-libvirt.html was empty (and should be deleted)
* Makefile.am didn't install html/libvirt-libvirt-*.html
* hvsupport.html was mostly empty
*
On 11/12/14 18:26, Michal Privoznik wrote:
There are two ways how to use nvram variable store file in
libvirt:
1) create it by hand and pass the path in domain XML
2) let libvirt generate path and create the file
Now, we allow users to remove the file from case 2) by passing a
flag
On 11/12/14, 2:53 AM, Michal Privoznik mpriv...@redhat.com wrote:
On 11.11.2014 23:45, Anirban Chakraborty wrote:
On 11/10/14, 3:13 PM, Eric Blake ebl...@redhat.com wrote:
On 11/10/2014 03:41 PM, Anirban Chakraborty wrote:
BTW: it would be nice if you can version you patches. I mean,
---
src/bhyve/bhyve_device.c | 2 +-
src/bhyve/bhyve_driver.c | 10 +-
src/bhyve/bhyve_process.c | 2 +-
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/bhyve/bhyve_device.c b/src/bhyve/bhyve_device.c
index fa266de..b458275 100644
--- a/src/bhyve/bhyve_device.c
+++
Rather than just picking the first CD (or failing that, HDD) we come
across, if the user has picked a boot device ordering with boot
order='', respect that (and just try to boot the lowest-index device).
Adds two sets of tests to bhyve2xmlargv; 'grub-bootorder' shows that we
pick a user-specified
From 7db513698bfcc30d2d0b020c3fcf9e0337c66ff4 Mon Sep 17 00:00:00 2001
From: Anirban Chakraborty abc...@juniper.net
Date: Wed, 12 Nov 2014 14:24:43 -0800
Subject: [PATCH] network: Add network bandwidth support to ethernet interfaces
Ethernet interfaces in libvirt currently do not support
This series of patches fixes problems discovered in libxl migration.
The first patch fixes an issue that went undetected while testing the
initial implementation of migration. Receiving migration data occurs
in the context of an event loop callback, effectively blocking the
event loop during the
The 'cleanup' label was missplaced in libxlDomainMigrationFinish,
causing a migrated domain to remain if the migration was cancelled
or encountered an error during perform phase.
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
src/libxl/libxl_migration.c | 8
1 file changed, 4
During the perform phase of migration, the domain is started on
the dst host in a running state if VIR_MIGRATE_PAUSED flag is not
specified. In the finish phase, the domain is also unpaused if
VIR_MIGRATE_PAUSED flag is unset. I've noticed this second unpause
fails if the domain was already
The libxl driver receives migration data within an IO callback invoked
by the event loop, effectively disabling the event loop while migration
occurs.
This patch moves receving of the migration data to a thread. The
incoming connection is still accepted in the IO callback, but control
is
70 matches
Mail list logo
