Re: [libvirt] [PATCHv2 2/5] qemu: process: Refresh virtio channel guest state when connecting to mon

2014-11-24 Thread Peter Krempa
On 11/21/14 17:09, Jiri Denemark wrote: On Fri, Nov 21, 2014 at 16:29:52 +0100, Peter Krempa wrote: Use data provided by query-chardev to refresh the guest frontend state of virtio channels. --- Notes: Version 2: - tweak style of catching errors - adapt to changes in previous

Re: [libvirt] Plan for next releases

2014-11-24 Thread Michal Privoznik
On 20.11.2014 17:12, Daniel Veillard wrote: We are getting close to the end of the month and in theory we should enter freeze around next week if we want to release 1.2.11 early Dec. However: - we have 'only' 150 commits since 1.2.10 - December is usually heavilly truncated due to

Re: [libvirt] lxcContainerResolveSymlinks failing on cascading FS

2014-11-24 Thread Michal Privoznik
On 21.11.2014 11:24, Cedric Bosdonnat wrote: Hi all, As an example, the following command virt-sandbox-service create --network dhcp,source=default --unitfile sshd.service mysshd -i 512 generates a container definition containing these filesystems (in the same order): filesystem

Re: [libvirt] [PATCH] spec: Automatically apply all patches with git

2014-11-24 Thread Jiri Denemark
On Fri, Nov 21, 2014 at 17:21:07 -0700, Eric Blake wrote: On 11/21/2014 01:41 PM, Laine Stump wrote: On 11/21/2014 12:20 PM, Jiri Denemark wrote: With this change, any patch declared in libvirt.spec with Patch[0-9]* is automatically applied in %prep. Unlike with the standard %patch[0-9]*,

Re: [libvirt] [PATCH 1/2] virdbus: don't force users to pass int for bool values

2014-11-24 Thread Ian Campbell
On Fri, 2014-11-21 at 17:16 -0700, Eric Blake wrote: On 11/20/2014 04:17 PM, Eric Blake wrote: On 11/20/2014 08:12 AM, Conrad Meyer wrote: Hi Eric, I think this change breaks build on FreeBSD: CC util/libvirt_util_la-virdbus.lo util/virdbus.c:956:13: error: cast from 'bool

Re: [libvirt] [PATCH v3 1/6] internal: add macro to round value to the next closest power of 2

2014-11-24 Thread Peter Krempa
On 11/20/14 20:21, Pavel Hrdina wrote: There are two special cases, if the input number is 0 or the number is larger then 2^31 (for 32bit unsigned int). For the special cases the return value is 0 because they cannot be rounded. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1076098

Re: [libvirt] [PATCHv2 3/5] event: Add guest agent lifecycle event

2014-11-24 Thread Jiri Denemark
On Fri, Nov 21, 2014 at 16:29:53 +0100, Peter Krempa wrote: As qemu is now able to notify us about change of the channel state used for communication with the guest agent we now can more precisely track the state of the guest agent. To allow notifying management apps this patch implements a

Re: [libvirt] [PATCH v3 2/6] video: cleanup usage of vram attribute and update documentation

2014-11-24 Thread Peter Krempa
On 11/20/14 20:21, Pavel Hrdina wrote: The vram attribute was introduced to set the video memory but it is usable only for few hypervisors excluding QEMU/KVM and the old XEN driver. Only in case of QEMU the vram was used for QXL. This patch updates the documentation to reflect current code

[libvirt] [PATCH v3 2/6] video: cleanup usage of vram attribute and update documentation

2014-11-24 Thread Pavel Hrdina
The vram attribute was introduced to set the video memory but it is usable only for few hypervisors excluding QEMU/KVM and the old XEN driver. Only in case of QEMU the vram was used for QXL. This patch updates the documentation to reflect current code in libvirt and also changes the cases when we

[libvirt] Error starting domain: internal error: missing IFLA_VF_INFO in netlink response

2014-11-24 Thread hong-hua....@freescale.com
Hi, We try PCI Passthrough of host network devices on PPC platform. http://wiki.libvirt.org/page/Networking#Assignment_with_.3Cinterface_type.3D.27hostdev.27.3E_.28SRIOV_devices_only.29 But we got a similar issue as below that reported on RedHat before:

[libvirt] strange behavior when using iotune

2014-11-24 Thread Vasiliy Tolstov
Hi. I'm try to shape disk via total_iops_sec in libvirt libvirt 1.2.10 qemu 2.0.0 Firstly when i'm run vm with predefined total_iops_sec5000/total_iops_sec i have around 11000 iops (dd if=/dev/sda bs=512K of=/dev/null) After that i'm try to set via virsh --total_iops_sec 10 to want to minimize

Re: [libvirt] [PATCHv2 4/5] examples: Add support for the guest agent lifecycle event

2014-11-24 Thread Jiri Denemark
On Fri, Nov 21, 2014 at 16:29:54 +0100, Peter Krempa wrote: Add code to support the event in the object-event example. Please, provide a separate patch for event example in libvirt-python. ACK Jirka -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCHv2 3/5] event: Add guest agent lifecycle event

2014-11-24 Thread Jiri Denemark
On Mon, Nov 24, 2014 at 11:33:56 +0100, Jiri Denemark wrote: On Fri, Nov 21, 2014 at 16:29:53 +0100, Peter Krempa wrote: As qemu is now able to notify us about change of the channel state used for communication with the guest agent we now can more precisely track the state of the guest

Re: [libvirt] [PATCHv2 5/5] qemu: Emit the guest agent lifecycle event

2014-11-24 Thread Jiri Denemark
On Fri, Nov 21, 2014 at 16:29:55 +0100, Peter Krempa wrote: Add code to emit the event on change of the channel state and reconnect to the qemu process. --- Notes: Version 2: - emit more reasons src/qemu/qemu_driver.c | 6 ++ src/qemu/qemu_process.c | 22

Re: [libvirt] Plan for next releases

2014-11-24 Thread Daniel Veillard
On Mon, Nov 24, 2014 at 09:37:04AM +0100, Michal Privoznik wrote: On 20.11.2014 17:12, Daniel Veillard wrote: We are getting close to the end of the month and in theory we should enter freeze around next week if we want to release 1.2.11 early Dec. However: - we have 'only' 150 commits

Re: [libvirt] [PATCH v3 2/6] video: cleanup usage of vram attribute and update documentation

2014-11-24 Thread Peter Krempa
On 11/24/14 12:07, Pavel Hrdina wrote: The vram attribute was introduced to set the video memory but it is usable only for few hypervisors excluding QEMU/KVM and the old XEN driver. Only in case of QEMU the vram was used for QXL. This patch updates the documentation to reflect current code

Re: [libvirt] [PATCH v3 3/6] QXL: fix setting ram and vram values for QEMU QXL device

2014-11-24 Thread Peter Krempa
On 11/20/14 20:21, Pavel Hrdina wrote: QEMU has two different type of QXL display device. The first qxl-vga is for primary video device and second qxl is for secondary video device. There are also two different ways how to specify those devices on qemu command line, the first one and

Re: [libvirt] [PATCH v3 4/6] caps: introduce new QEMU capability for vgamem_mb device property

2014-11-24 Thread Peter Krempa
On 11/20/14 20:21, Pavel Hrdina wrote: Allow setting vgamem size for video devices. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1076098 Signed-off-by: Pavel Hrdina phrd...@redhat.com --- src/qemu/qemu_capabilities.c | 33 src/qemu/qemu_capabilities.h

Re: [libvirt] [PATCH v3 5/6] qemu-command: use vram attribute for all video devices

2014-11-24 Thread Peter Krempa
On 11/20/14 20:21, Pavel Hrdina wrote: So far we hadn't any option to set video memory size for qemu video hadn't had or didn't have devices. There were only vram (ram for QXL) attribute but it was valid There was only the only for QXL video device. for the To provide this feature to

Re: [libvirt] [Qemu-devel] strange behavior when using iotune

2014-11-24 Thread Andrey Korolyov
On Mon, Nov 24, 2014 at 3:02 PM, Vasiliy Tolstov v.tols...@selfip.ru wrote: Hi. I'm try to shape disk via total_iops_sec in libvirt libvirt 1.2.10 qemu 2.0.0 Firstly when i'm run vm with predefined total_iops_sec5000/total_iops_sec i have around 11000 iops (dd if=/dev/sda bs=512K

Re: [libvirt] [PATCH v3 6/6] qemu-command: introduce new vgamem attribute for QXL video device

2014-11-24 Thread Peter Krempa
On 11/20/14 20:21, Pavel Hrdina wrote: Add attribute to set vgamem_mb parameter of QXL device for QEMU. This value sets the size of VGA framebuffer for QXL device. Default value in QEMU is 8MB so reuse it also in libvirt to not break things. Resolves:

Re: [libvirt] [Qemu-devel] strange behavior when using iotune

2014-11-24 Thread Vasiliy Tolstov
2014-11-24 16:57 GMT+03:00 Andrey Korolyov and...@xdel.ru: Hello Vasiliy, can you please check actual values via qemu-monitor-command domid '{ execute: query-block}', just to be sure to pin the potential problem to the emulator itself? virsh qemu-monitor-command 11151 '{ execute:

Re: [libvirt] [Qemu-devel] strange behavior when using iotune

2014-11-24 Thread Andrey Korolyov
On Mon, Nov 24, 2014 at 5:09 PM, Vasiliy Tolstov v.tols...@selfip.ru wrote: 2014-11-24 16:57 GMT+03:00 Andrey Korolyov and...@xdel.ru: Hello Vasiliy, can you please check actual values via qemu-monitor-command domid '{ execute: query-block}', just to be sure to pin the potential problem to

Re: [libvirt] ideas on virDomainListBlockStats for allocation numbers

2014-11-24 Thread Peter Krempa
On 11/22/14 07:03, Eric Blake wrote: Based on Dan's recommendation [1], I'm looking at enhancing virDomainListBlockStats to report the allocation numbers of a backing file during a virDomainBlockCommit operation. Getting the information from qemu is not difficult, but the question is how

[libvirt] [PATCH v4 3/6] QXL: fix setting ram and vram values for QEMU QXL device

2014-11-24 Thread Pavel Hrdina
QEMU has two different type of QXL display device. The first qxl-vga is for primary video device and second qxl is for secondary video device. There are also two different ways how to specify those devices on qemu command line, the first one and obsolete is using -vga option and the current new

Re: [libvirt] [PATCH 0/2] Add more duplicate scsi_host/fc_host adapter checks

2014-11-24 Thread John Ferlan
ping... Tks John On 11/18/2014 04:26 PM, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1159180 Currently libvirt only detects duplicate fc_host scsi_host adapter sources when the incoming source type definition is the same as the pool type. This misses the even more

Re: [libvirt] [PATCH v3 6/6] qemu-command: introduce new vgamem attribute for QXL video device

2014-11-24 Thread Pavel Hrdina
On 11/24/2014 03:03 PM, Peter Krempa wrote: On 11/20/14 20:21, Pavel Hrdina wrote: Add attribute to set vgamem_mb parameter of QXL device for QEMU. This value sets the size of VGA framebuffer for QXL device. Default value in QEMU is 8MB so reuse it also in libvirt to not break things.

Re: [libvirt] ideas on virDomainListBlockStats for allocation numbers

2014-11-24 Thread Adam Litke
On 21/11/14 23:03 -0700, Eric Blake wrote: Based on Dan's recommendation [1], I'm looking at enhancing virDomainListBlockStats to report the allocation numbers of a backing file during a virDomainBlockCommit operation. Getting the information from qemu is not difficult, but the question is how

[libvirt] [PATCH v4 6/6] qemu-command: introduce new vgamem attribute for QXL video device

2014-11-24 Thread Pavel Hrdina
Add attribute to set vgamem_mb parameter of QXL device for QEMU. This value sets the size of VGA framebuffer for QXL device. Default value in QEMU is 8MB so reuse it also in libvirt to not break things. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1076098 Signed-off-by: Pavel Hrdina

Re: [libvirt] [PATCHv2 5/5] qemu: Emit the guest agent lifecycle event

2014-11-24 Thread Peter Krempa
On 11/24/14 13:35, Jiri Denemark wrote: On Fri, Nov 21, 2014 at 16:29:55 +0100, Peter Krempa wrote: Add code to emit the event on change of the channel state and reconnect to the qemu process. --- Notes: Version 2: - emit more reasons src/qemu/qemu_driver.c | 6 ++

Re: [libvirt] [PATCH v3 0/5] Guest filesystem information API

2014-11-24 Thread John Ferlan
On 11/21/2014 08:27 PM, Tomoki Sekiyama wrote: Hi, This is v3 of patchset to add virDomainGetFSInfo API. * changes in v2-v3: -[all] squashed fixup patches by John Ferlan (thanks!) -[all] added 'ndevAlias' filed instead of NULL-termination of devAlias -[all] renamed 'type' field to

[libvirt] [python PATCH] event: Add bindings for agent lifecycle event

2014-11-24 Thread Peter Krempa
Also add the example. --- examples/event-test.py | 13 +++ libvirt-override.c | 60 ++ 2 files changed, 73 insertions(+) mode change 100644 = 100755 examples/event-test.py diff --git a/examples/event-test.py b/examples/event-test.py

Re: [libvirt] [PATCH v6] network: Add network bandwidth support to ethernet interfaces

2014-11-24 Thread Vasiliy Tolstov
2014-11-21 11:13 GMT+03:00 Vasiliy Tolstov v.tols...@selfip.ru: No, in this case qemu creates device for me and all works fine. If i create patch for libvirt to create tap device if user not specify script, does it acceptable by upstream? Benefits of this patch - that we can create tap device

Re: [libvirt] [Qemu-devel] strange behavior when using iotune

2014-11-24 Thread Vasiliy Tolstov
2014-11-24 17:18 GMT+03:00 Andrey Korolyov and...@xdel.ru: I am not sure for friendliness of possible dd interpretations for new leaky bucket mechanism, as its results can be a little confusing even for fio (all operations which are above the limit for long-running test will have 250ms

[libvirt] [python PATCHv2] event: Add bindings for agent lifecycle event

2014-11-24 Thread Peter Krempa
Also add the example. --- Version 2: - version 2 actually works ... examples/event-test.py | 11 libvirt-override-virConnect.py | 10 +++ libvirt-override.c | 60 ++ 3 files changed, 81 insertions(+) mode change 100644 =

Re: [libvirt] ideas on virDomainListBlockStats for allocation numbers

2014-11-24 Thread Peter Krempa
On 11/24/14 15:58, Adam Litke wrote: On 21/11/14 23:03 -0700, Eric Blake wrote: ... The problem is that once we have a domain with more than one disk, and where one or all disks have more than one backingStore, then how should virDomainListBlockStats represent that? One idea I have is to

Re: [libvirt] [PATCH 1/2] virdbus: don't force users to pass int for bool values

2014-11-24 Thread Eric Blake
On 11/24/2014 02:43 AM, Ian Campbell wrote: I think this change breaks build on FreeBSD: CC util/libvirt_util_la-virdbus.lo util/virdbus.c:956:13: error: cast from 'bool *' to 'dbus_bool_t *' (aka 'unsigned int *') increases required alignment from 1 to 4 [-Werror,-Wcast-align]

Re: [libvirt] [PATCH RFC] storage: perform btrfs clone if possible

2014-11-24 Thread Eric Blake
On 11/24/2014 12:09 AM, Martin Kletzander wrote: On Mon, Nov 24, 2014 at 02:11:47PM +0800, Chen Hanxiao wrote: We already had nocow flags in virStorageSource. But when creating RAW file, we don't take advantage of clone of btrfs. This file introduce btrfs_clone_file function, and try to use

Re: [libvirt] [PATCH v6] network: Add network bandwidth support to ethernet interfaces

2014-11-24 Thread Eric Blake
On 11/24/2014 08:39 AM, Vasiliy Tolstov wrote: 2014-11-21 11:13 GMT+03:00 Vasiliy Tolstov v.tols...@selfip.ru: No, in this case qemu creates device for me and all works fine. If i create patch for libvirt to create tap device if user not specify script, does it acceptable by upstream?

Re: [libvirt] [libvirt-python PATCH v2] override: Implement bindings for virDomainGetFSInfo as domain.fsInfo

2014-11-24 Thread Pavel Hrdina
On 11/22/2014 02:28 AM, Tomoki Sekiyama wrote: Implement the function which returns a list of tuples, that contains members of virDomainFSInfo struct. Signed-off-by: Tomoki Sekiyama tomoki.sekiy...@hds.com --- generator.py |5 +++ libvirt-override-api.xml |6

[libvirt] [PATCH] util: Avoid calling closedir(NULL)

2014-11-24 Thread Jiri Denemark
Signed-off-by: Jiri Denemark jdene...@redhat.com --- src/util/virutil.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virutil.c b/src/util/virutil.c index 9c40317..3037293 100644 --- a/src/util/virutil.c +++ b/src/util/virutil.c @@ -1780,7 +1780,7 @@

Re: [libvirt] [PATCH 7/8] Given virDomainDef parser formatter their own flags

2014-11-24 Thread Martin Kletzander
On Tue, Nov 18, 2014 at 05:59:54PM +, Daniel P. Berrange wrote: The virDomainDefParse* and virDomainDefFormat* methods both accept the VIR_DOMAIN_XML_* flags defined in the public API, along with a set of other VIR_DOMAIN_XML_INTERNAL_* flags defined in domain_conf.c. This is seriously

Re: [libvirt] [PATCH 0/8] Add XML validation to the APIs

2014-11-24 Thread Martin Kletzander
On Thu, Nov 20, 2014 at 01:43:29PM +, Daniel P. Berrange wrote: On Thu, Nov 20, 2014 at 12:02:12PM +0100, Martin Kletzander wrote: On Wed, Nov 19, 2014 at 12:51:22PM +, Daniel P. Berrange wrote: On Wed, Nov 19, 2014 at 09:45:39AM +, Daniel P. Berrange wrote: On Wed, Nov 19, 2014 at

Re: [libvirt] [python PATCHv2] event: Add bindings for agent lifecycle event

2014-11-24 Thread Pavel Hrdina
On 11/24/2014 05:09 PM, Peter Krempa wrote: Also add the example. --- Version 2: - version 2 actually works ... examples/event-test.py | 11 libvirt-override-virConnect.py | 10 +++ libvirt-override.c | 60 ++ 3

Re: [libvirt] [python PATCHv2] event: Add bindings for agent lifecycle event

2014-11-24 Thread Peter Krempa
On 11/24/14 17:49, Pavel Hrdina wrote: On 11/24/2014 05:09 PM, Peter Krempa wrote: Also add the example. --- Version 2: - version 2 actually works ... examples/event-test.py | 11 libvirt-override-virConnect.py | 10 +++ libvirt-override.c | 60

Re: [libvirt] [PATCH] util: Avoid calling closedir(NULL)

2014-11-24 Thread Pavel Hrdina
On 11/24/2014 05:42 PM, Jiri Denemark wrote: Signed-off-by: Jiri Denemark jdene...@redhat.com --- src/util/virutil.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virutil.c b/src/util/virutil.c index 9c40317..3037293 100644 --- a/src/util/virutil.c +++

Re: [libvirt] [PATCH v4 3/6] QXL: fix setting ram and vram values for QEMU QXL device

2014-11-24 Thread Peter Krempa
On 11/24/14 15:58, Pavel Hrdina wrote: QEMU has two different type of QXL display device. The first qxl-vga is for primary video device and second qxl is for secondary video device. There are also two different ways how to specify those devices on qemu command line, the first one and

Re: [libvirt] [PATCH v4 6/6] qemu-command: introduce new vgamem attribute for QXL video device

2014-11-24 Thread Peter Krempa
On 11/24/14 16:04, Pavel Hrdina wrote: Add attribute to set vgamem_mb parameter of QXL device for QEMU. This value sets the size of VGA framebuffer for QXL device. Default value in QEMU is 8MB so reuse it also in libvirt to not break things. Resolves:

[libvirt] [PATCH 1/9] util: new functions for setting bridge and bridge port attributes

2014-11-24 Thread Laine Stump
These functions all set/get items in the sysfs for a bridge device. --- src/libvirt_private.syms | 6 ++ src/util/virnetdevbridge.c | 236 - src/util/virnetdevbridge.h | 28 +- 3 files changed, 268 insertions(+), 2 deletions(-) diff --git

[libvirt] [PATCH 5/9] network: store network promiscLinks setting in NetDef actual object

2014-11-24 Thread Laine Stump
At the time that the network driver allocates a connection to a network, the tap device that will be used hasn't yet been created - that will be done later by qemu (or lxc or whoever) - but if the network has promiscLinks='no', then when we do get around to creating the tap device, we will need to

[libvirt] [PATCH 4/9] network: save bridge name in ActualNetDef when actualType==network too

2014-11-24 Thread Laine Stump
When the actualType of a virDomainNetDef is network, it means that we are connecting to a libvirt-managed network (routed, natted, or isolated) which does use a bridge device (created by libvirt). In the past we have required drivers such as qemu to call the public API to retrieve the bridge name

[libvirt] [PATCH 0/9] Let libvirt manage a bridge's FDB

2014-11-24 Thread Laine Stump
The idea behind these patches is the following: 1) most virtual machines only have a single MAC address behind each interface, and that MAC address is known by libvirt. 2) If we (i.e. libvirt) manually add an entry to the bridge's forwarding database (fdb) for the MAC address associated with a

[libvirt] [PATCH 8/9] qemu: always use virDomainNetGetActualBridgeName to get interface's bridge

2014-11-24 Thread Laine Stump
INFORMATIONAL ONLY - NO NEED TO REVIEW, WILL NOT BE PUSHED qemuNetworkIfaceConnect() used to have a special case for actualType='network' (a network with forward mode of route, nat, or isolated) to call the libvirt public API to retrieve the bridge being used by a network. That is no longer

[libvirt] [PATCH 7/9] qemu: setup tap devices for promiscLinks='no'

2014-11-24 Thread Laine Stump
In order for the kernel to be able to promiscuous mode on as many ports of a bridge as possible, at most one attached device can have learning and unicast_flood enabled (in practice, this one device is always the physical device that connects the bridge to the real world). If more than one device

[libvirt] [PATCH 6/9] network: setup bridge devices for promiscLinks='no'

2014-11-24 Thread Laine Stump
When the bridge device for a network has promiscLinks='no', the intent is to setup the bridge to opportunistically turn off promiscuous mode and/or flood mode for as many ports/links on the bridge as possible, thus improving performance and security. The setup for the bridge itself is: 1) set the

[libvirt] [PATCH 9/9] lxc: always use virDomainNetGetActualBridgeName to get interface's bridge

2014-11-24 Thread Laine Stump
INFORMATIONAL ONLY - NO NEED TO REVIEW, WILL NOT BE PUSHED qemuNetworkIfaceConnect() used to have a special case for actualType='network' (a network with forward mode of route, nat, or isolated) to call the libvirt public API to retrieve the bridge being used by a network. That is no longer

[libvirt] [PATCH 3/9] conf: new network bridge device attribute promiscLinks

2014-11-24 Thread Laine Stump
The promiscLinks attribute of a network's bridge subelement is used as a single switch to simultaneously turn on/off several options related to a bridge and its attached devices. When this is done, as many of the links to the bridge as possible have promiscuous mode turned off and/or flooding

[libvirt] [PATCH 2/9] util: functions to manage bridge fdb (forwarding database)

2014-11-24 Thread Laine Stump
These two functions use netlink RTM_NEWNEIGH and RTM_DELNEIGH messages to add and delete entries from a bridge's fdb. The bridge itself is not referenced in the arguments to the functions, only the name of the device that is attached to the bridge (since a device can only be attached to one bridge

Re: [libvirt] [libvirt-glib PATCHv2] Add gvir_domain_open_graphics_fd()

2014-11-24 Thread Zeeshan Ali (Khattak)
Ping? On Fri, Nov 21, 2014 at 3:11 PM, Zeeshan Ali (Khattak) zeesha...@gnome.org wrote: Add binding for virDomainOpenGraphicsFD. If virDomainOpenGraphicsFD is not available, it means we are dealing with older libvirt so we create the socket pair ourselves if that is the case. ---

Re: [libvirt] [PATCH] storage_driver: fix a comment typo

2014-11-24 Thread Eric Blake
On 11/23/2014 11:13 PM, Chen Hanxiao wrote: s/rereshed/refreshed Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com --- src/storage/storage_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index

Re: [libvirt] [libvirt-python PATCH v2] override: Implement bindings for virDomainGetFSInfo as domain.fsInfo

2014-11-24 Thread Tomoki Sekiyama
On 11/24/14, 11:30 , Pavel Hrdina phrd...@redhat.com wrote: On 11/22/2014 02:28 AM, Tomoki Sekiyama wrote: Implement the function which returns a list of tuples, that contains members of virDomainFSInfo struct. Signed-off-by: Tomoki Sekiyama tomoki.sekiy...@hds.com --- generator.py

Re: [libvirt] [PATCH 1/9] util: new functions for setting bridge and bridge port attributes

2014-11-24 Thread John Ferlan
On 11/24/2014 12:48 PM, Laine Stump wrote: These functions all set/get items in the sysfs for a bridge device. Probably could have split up the virNetDevBridgePort* from the virNetDevBridgeSetVlanFiltering - if only to make it a bit clearer in the commit message that you're adding functions to

Re: [libvirt] [PATCH 1/9] util: new functions for setting bridge and bridge port attributes

2014-11-24 Thread Eric Blake
On 11/24/2014 01:36 PM, John Ferlan wrote: On 11/24/2014 12:48 PM, Laine Stump wrote: These functions all set/get items in the sysfs for a bridge device. Probably could have split up the virNetDevBridgePort* from the virNetDevBridgeSetVlanFiltering - if only to make it a bit clearer in

[libvirt] [PATCH 0/5] Getting virt-sandbox-service to work

2014-11-24 Thread Cédric Bosdonnat
Hi all, this patch series fixes a few problems I encountered when getting virt-sandbox-service containers with images to work. The very first patch fixes a crasher in virt-aa-helper tests... but we were pretty lucky it didn't explode before: virErrors weren't initialized. Cédric Bosdonnat

[libvirt] [PATCH 4/5] lxc: be more patient while resolving symlinks

2014-11-24 Thread Cédric Bosdonnat
Resolving symlinks can fail before mounting any file system if one file system depends on another being mounted. Symlinks are now resolved in two passes: * Before any file system is mounted, but then we are more gentle if the source path can't be accessed * Right before mounting a file

[libvirt] [PATCH 5/5] lxc: don't unmount subtree if it contains the source of the mount

2014-11-24 Thread Cédric Bosdonnat
The typical case where we had a problem is with such a filesystem definition as created by virt-sandbox-service: filesystem type='bind' accessmode='passthrough' source dir='/var/lib/libvirt/filesystems/mysshd/var'/ target dir='/var'/ /filesystem In this case, we don't want to

[libvirt] [PATCH 3/5] ip link needs 'name' in 3.16 to create the veth pair

2014-11-24 Thread Cédric Bosdonnat
Due to a change (or bug?) in ip link implementation, the command 'ip link add vnet0...' is forced into 'ip link add name vnet0...' The changed command also works on older versions of iproute2, just the 'name' parameter has been made mandatory. --- src/util/virnetdevveth.c | 4 ++-- 1 file

[libvirt] [PATCH 1/5] virt-aa-helper wasn't running virErrorInitialize

2014-11-24 Thread Cédric Bosdonnat
This turns out to be working by magic but needs to be fixed. --- src/security/virt-aa-helper.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index e4d9a76..81f9f40 100644 --- a/src/security/virt-aa-helper.c +++

[libvirt] [PATCH] automatic create tap device with network type ethernet

2014-11-24 Thread Vasiliy Tolstov
If use not specify script in network type ethernet, assume that user needs simple tap device created with libvirt. This patch does not need to run external script to create tap device. Signed-off-by: Vasiliy Tolstov v.tols...@selfip.ru --- src/qemu/qemu_command.c | 88

[libvirt] [PATCH 2/5] virt-aa-helper: /etc/libvirt-sandbox/services isn't restricted

2014-11-24 Thread Cédric Bosdonnat
To get virt-sandbox-service working with AppArmor, virt-aa-helper needs not to choke on path in /etc/libvirt-sandbox/services. --- src/security/virt-aa-helper.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/security/virt-aa-helper.c

Re: [libvirt] [PATCH 2/9] util: functions to manage bridge fdb (forwarding database)

2014-11-24 Thread John Ferlan
On 11/24/2014 12:48 PM, Laine Stump wrote: These two functions use netlink RTM_NEWNEIGH and RTM_DELNEIGH messages to add and delete entries from a bridge's fdb. The bridge itself is not referenced in the arguments to the functions, only the name of the device that is attached to the bridge

Re: [libvirt] [PATCH v4 6/6] qemu-command: introduce new vgamem attribute for QXL video device

2014-11-24 Thread Pavel Hrdina
On 11/24/2014 06:04 PM, Peter Krempa wrote: On 11/24/14 16:04, Pavel Hrdina wrote: Add attribute to set vgamem_mb parameter of QXL device for QEMU. This value sets the size of VGA framebuffer for QXL device. Default value in QEMU is 8MB so reuse it also in libvirt to not break things.

Re: [libvirt] [PATCH 3/9] conf: new network bridge device attribute promiscLinks

2014-11-24 Thread John Ferlan
On 11/24/2014 12:48 PM, Laine Stump wrote: The promiscLinks attribute of a network's bridge subelement is used as a single switch to simultaneously turn on/off several options related to a bridge and its attached devices. When this is done, as many of the links to the bridge as possible have

Re: [libvirt] [PATCH 4/9] network: save bridge name in ActualNetDef when actualType==network too

2014-11-24 Thread John Ferlan
On 11/24/2014 12:48 PM, Laine Stump wrote: When the actualType of a virDomainNetDef is network, it means that we are connecting to a libvirt-managed network (routed, natted, or isolated) which does use a bridge device (created by libvirt). In the past we have required drivers such as qemu to

Re: [libvirt] [PATCH 5/9] network: store network promiscLinks setting in NetDef actual object

2014-11-24 Thread John Ferlan
On 11/24/2014 12:48 PM, Laine Stump wrote: At the time that the network driver allocates a connection to a network, the tap device that will be used hasn't yet been created - that will be done later by qemu (or lxc or whoever) - but if the network has promiscLinks='no', then when we do get

Re: [libvirt] [PATCH 6/9] network: setup bridge devices for promiscLinks='no'

2014-11-24 Thread John Ferlan
On 11/24/2014 12:48 PM, Laine Stump wrote: When the bridge device for a network has promiscLinks='no', the intent is to setup the bridge to opportunistically turn off promiscuous mode and/or flood mode for as many ports/links on the bridge as possible, thus improving performance and

Re: [libvirt] [PATCH 7/9] qemu: setup tap devices for promiscLinks='no'

2014-11-24 Thread John Ferlan
On 11/24/2014 12:48 PM, Laine Stump wrote: In order for the kernel to be able to promiscuous mode on as many ports of a bridge as possible, at most one attached device can have learning and unicast_flood enabled (in practice, this one device is always the physical device that connects the

[libvirt] [PATCH 0/2] prep for backing chain stat reporting

2014-11-24 Thread Eric Blake
I'm still working on more patches to expose the allocation watermark of backing images during a block commit, but want to get these preliminary patches posted now. Eric Blake (2): virsh: document block.n.allocation stat getstats: add block.n.source stat src/libvirt-domain.c | 16

[libvirt] [PATCH 1/2] virsh: document block.n.allocation stat

2014-11-24 Thread Eric Blake
Commit 7557ddf added some additional block.* stats to virDomainListGetStats, but failed to document them in 'man virsh'. Also, I noticed some inconsistent use of commas. * tools/virsh.pod (domstats): Tweak commas, add missing stats. Signed-off-by: Eric Blake ebl...@redhat.com ---

[libvirt] [PATCH 2/2] getstats: add block.n.source stat

2014-11-24 Thread Eric Blake
I noticed that for an offline domain, 'virsh domstats --block $dom' was producing just the domain name, with no stats. But the older 'virsh domblkinfo' works just fine on offline domains. Furthermore, I'm about to make block stats optionally more complex to cover backing chains, where

Re: [libvirt] [PATCH 2/5] virt-aa-helper: /etc/libvirt-sandbox/services isn't restricted

2014-11-24 Thread Martin Kletzander
On Mon, Nov 24, 2014 at 09:54:43PM +0100, Cédric Bosdonnat wrote: To get virt-sandbox-service working with AppArmor, virt-aa-helper needs not to choke on path in /etc/libvirt-sandbox/services. --- src/security/virt-aa-helper.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff

Re: [libvirt] [PATCH 1/5] virt-aa-helper wasn't running virErrorInitialize

2014-11-24 Thread Martin Kletzander
On Mon, Nov 24, 2014 at 09:54:42PM +0100, Cédric Bosdonnat wrote: This turns out to be working by magic but needs to be fixed. --- src/security/virt-aa-helper.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index

Re: [libvirt] [PATCH 4/5] lxc: be more patient while resolving symlinks

2014-11-24 Thread Martin Kletzander
On Mon, Nov 24, 2014 at 09:54:45PM +0100, Cédric Bosdonnat wrote: Resolving symlinks can fail before mounting any file system if one file system depends on another being mounted. Symlinks are now resolved in two passes: * Before any file system is mounted, but then we are more gentle if the

Re: [libvirt] [PATCH 3/5] ip link needs 'name' in 3.16 to create the veth pair

2014-11-24 Thread Martin Kletzander
On Mon, Nov 24, 2014 at 09:54:44PM +0100, Cédric Bosdonnat wrote: Due to a change (or bug?) in ip link implementation, the command 'ip link add vnet0...' is forced into 'ip link add name vnet0...' The changed command also works on older versions of iproute2, just the 'name' parameter has

Re: [libvirt] [PATCH 5/5] lxc: don't unmount subtree if it contains the source of the mount

2014-11-24 Thread Martin Kletzander
On Mon, Nov 24, 2014 at 09:54:46PM +0100, Cédric Bosdonnat wrote: The typical case where we had a problem is with such a filesystem definition as created by virt-sandbox-service: filesystem type='bind' accessmode='passthrough' source dir='/var/lib/libvirt/filesystems/mysshd/var'/