Re: [libvirt] [PATCH 0/2] qemu: update jobinfo type if the job is not completed in qemuMigrationRun

2014-11-30 Thread Martin Kletzander
On Mon, Dec 01, 2014 at 03:05:31PM +0800, Wang Rui wrote: In qemuMigrationRun the jobinfo type won't be updated until qemuMigrationWaitForCompletion. If migration is failed or cancelled before that(such as in qemuMigrationDriveMirror), we can't get the right jobinfo type. The following patches fi

Re: [libvirt] [PATCH 1/2] qemu: set jobinfo type to CANCELLED if migration is cancelled in all conditions

2014-11-30 Thread Martin Kletzander
On Mon, Dec 01, 2014 at 03:02:53PM +0800, Wang Rui wrote: On 2014/12/1 4:29, Martin Kletzander wrote: Yes, you're right, that basically what I wanted to know, but was too busy searching for. ACK to this patch then. Would you be OK with me rewording the commit message as follows? The migrat

Re: [libvirt] python migrateSetMaxSpeed not taking effect

2014-11-30 Thread Martin Kletzander
On Mon, Dec 01, 2014 at 10:12:36AM +0400, Krutskikh Ivan wrote: Hi, I am writing a simple python script for migrating vm's based on zfs zvol's. Either I am doing something wrong or python migrateSetMaxSpeed not taking effect: no mater what value I specify (except for 0), I end up with 10 Mib/s m

[libvirt] [PATCH 1/2] qemu: set jobinfo type to CANCELLED if migration is cancelled in all conditions

2014-11-30 Thread Wang Rui
The migration job status is traced in qemuMigrationUpdateJobStatus which is called in qemuMigrationRun. But if migration is cancelled before the trace such as in qemuMigrationDriveMirror, the jobinfo type won't be updated to CANCELLED. After this patch, we can get jobinfo type CANCELLED if migratio

[libvirt] [PATCH 0/2] qemu: update jobinfo type if the job is not completed in qemuMigrationRun

2014-11-30 Thread Wang Rui
In qemuMigrationRun the jobinfo type won't be updated until qemuMigrationWaitForCompletion. If migration is failed or cancelled before that(such as in qemuMigrationDriveMirror), we can't get the right jobinfo type. The following patches fix it. diff to v1: Reword commit message to clarify why we c

[libvirt] [PATCH 2/2] qemu: set jobinfo type to FAILED if job is failed in qemuMigrationRun

2014-11-30 Thread Wang Rui
If job is failed in qemuMigrationRun, we expect the jobinfo type as FAILED. But jobinfo type won't be updated until entering qemuMigrationWaitForCompletion. We should make it updated in all conditions. Moreover, we can't use qemuMigrationUpdateJobStatus here because job may fail in libvirt, so we c

Re: [libvirt] [PATCH 1/2] qemu: set jobinfo type to CANCELLED if migration is cancelled in all conditions

2014-11-30 Thread Wang Rui
On 2014/12/1 4:29, Martin Kletzander wrote: > Yes, you're right, that basically what I wanted to know, but was too > busy searching for. ACK to this patch then. Would you be OK with me > rewording the commit message as follows? > >The migration job status is traced in qemuMigrationUpdateJobS

[libvirt] python migrateSetMaxSpeed not taking effect

2014-11-30 Thread Krutskikh Ivan
Hi, I am writing a simple python script for migrating vm's based on zfs zvol's. Either I am doing something wrong or python migrateSetMaxSpeed not taking effect: no mater what value I specify (except for 0), I end up with 10 Mib/s migration speed. The code is: def virt_migrate(domain): conn =

Re: [libvirt] [systemd-devel] systemd-cgroups-agent not working in containers

2014-11-30 Thread Lennart Poettering
On Fri, 28.11.14 15:52, Richard Weinberger (rich...@nod.at) wrote: > Am 28.11.2014 um 06:33 schrieb Martin Pitt: > > Hello all, > > > > Cameron Norman [2014-11-27 12:26 -0800]: > >> On Wed, Nov 26, 2014 at 1:29 PM, Richard Weinberger wrote: > >>> Hi! > >>> > >>> I run a Linux container setup wit

Re: [libvirt] [systemd-devel] systemd-cgroups-agent not working in containers

2014-11-30 Thread Lennart Poettering
On Wed, 26.11.14 22:29, Richard Weinberger (rich...@nod.at) wrote: > Hi! > > I run a Linux container setup with openSUSE 13.1/2 as guest distro. > After some time containers slow down. > An investigation showed that the containers slow down because a lot of stale > user sessions slow down almost

Re: [libvirt] [PATCH] network: Let domains be restricted to local DNS

2014-11-30 Thread Martin Kletzander
On Thu, Nov 20, 2014 at 06:46:41PM -0800, Josh Stone wrote: This adds a new "localOnly" attribute on the domain element of the network xml. With this set to "yes", DNS requests under that domain will only be resolved by libvirt's dnsmasq, never forwarded upstream. This was how it worked before

Re: [libvirt] [PATCH] conf: replace call to virNetworkFree() with virOjectUnref()

2014-11-30 Thread Martin Kletzander
s/virOjectUnref/virObjectUnref/ in $SUBJ if you haven't pushed already. On Tue, Nov 25, 2014 at 05:15:23AM -0500, Laine Stump wrote: The function virNetworkObjListExport() in network_conf.c had a call to the public API virNetworkFree() which was causing a link error: CCLD libvirt_driver_vbo

Re: [libvirt] [PATCH] Doc: some small issue in the document

2014-11-30 Thread Martin Kletzander
On Fri, Nov 28, 2014 at 02:44:24PM +0800, Luyao Huang wrote: When i pasted some xml from libvirt.org, i found some small mistake. Signed-off-by: Luyao Huang --- docs/formatdomain.html.in | 8 1 file changed, 4 insertions(+), 4 deletions(-) ACK, I reworded your commit message and push

Re: [libvirt] [PATCH 1/2] qemu: set jobinfo type to CANCELLED if migration is cancelled in all conditions

2014-11-30 Thread Martin Kletzander
On Fri, Nov 28, 2014 at 02:24:56PM +0800, Wang Rui wrote: On 2014/11/27 18:48, Martin Kletzander wrote: On Thu, Nov 27, 2014 at 04:26:24PM +0800, Wang Rui wrote: The migration job status is traced in qemuMigrationUpdateJobStatus which is called in qemuMigrationRun. But if migration is cancelled

[libvirt] [PATCH 2/2] conf: Add device-related code for panic devices

2014-11-30 Thread Martin Kletzander
Signed-off-by: Martin Kletzander --- src/conf/domain_conf.c | 76 - src/conf/domain_conf.h | 2 ++ src/qemu/qemu_driver.c | 6 src/qemu/qemu_hotplug.c | 1 + 4 files changed, 66 insertions(+), 19 deletions(-) diff --git a/src/conf/domain

[libvirt] [PATCH 0/2] Add device-related code for TPM and panic devices

2014-11-30 Thread Martin Kletzander
TPM and panic devices were added without the foundation code for things like hot/cold-(un)plugging, ABI stability checking, etc. This series adds that device-related code in order to properly handle those devices, even though in some cases it just means outputting a better error message. Martin K

[libvirt] [PATCH 1/2] conf: Add device-related code for TPM devices

2014-11-30 Thread Martin Kletzander
Signed-off-by: Martin Kletzander --- src/conf/domain_conf.c | 52 - src/conf/domain_conf.h | 5 + src/qemu/qemu_driver.c | 6 ++ src/qemu/qemu_hotplug.c | 1 + 4 files changed, 63 insertions(+), 1 deletion(-) diff --git a/src/conf/dom

[libvirt] [PATCH 0/2] Exit from virsh when disconnected due to keepalive

2014-11-30 Thread Martin Kletzander
When the connection in virsh got disconnected due to keepalive, virsh was trying to reconnect. Adding the REASON_KEEPALIVE to the list of disconnect reasons after virsh should not reconnect (patch 1/1) was not enough because our rpc code was rewriting those and that needs to be fixed too (patch 2/

[libvirt] [PATCH 2/2] virsh: Really disconnect on keepalive timeout

2014-11-30 Thread Martin Kletzander
Commit 676cb4f4e762b8682a06c6dab1f690fbcd939550 added client keepalive support for virsh. But because whenever the connection is closed, virsh tries to reconnect, unless the disconnection happened with the reason VIR_CONNECT_CLOSE_REASON_CLIENT. Because of that, virsh kept trying to reconnect eve

[libvirt] [PATCH 1/2] rpc: Report proper close reason

2014-11-30 Thread Martin Kletzander
Whenever client socket was marked as closed for some reason, it could've been changed when really closing the connection. With this patch the proper reason is kept since the first time it's marked as closed. Signed-off-by: Martin Kletzander --- src/rpc/virnetclient.c | 7 +-- 1 file changed