[libvirt] [PATCH 1/2] CVE-2015-0236: qemu: Check ACLs when dumping security info from save image

2015-01-22 Thread Peter Krempa
The ACL check didn't check the VIR_DOMAIN_XML_SECURE flag and the appropriate permission for it. --- src/qemu/qemu_driver.c | 2 +- src/remote/remote_protocol.x | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index

[libvirt] [PATCH] Fix virCgroupGetPercpuStats with non-continuous present CPUs

2015-01-22 Thread Ján Tomko
Per-cpu stats are only shown for present CPUs in the cgroups, but we were only parsing the largest CPU number from /sys/devices/system/cpu/present and looking for stats even for non-present CPUs. This resulted in: internal error: cpuacct parse error --- cfg.mk| 2 +-

Re: [libvirt] [PATCH v3 1/2] qemu: output error when try to hotplug unsupport console

2015-01-22 Thread Luyao Huang
On 01/22/2015 06:19 PM, Peter Krempa wrote: On Thu, Jan 22, 2015 at 10:28:18 +0800, Luyao Huang wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1164627 When using 'virsh attach-device' to hotplug an unsupported console type into a qemu guest, the attachment will erroneously allows the

[libvirt] [PATCH 0/2] CVE-2015-0236: Check ACLs for the VIR_DOMAIN_XML_SECURE flag for snapshots and save images

2015-01-22 Thread Peter Krempa
Patches are pushed according to Eric's ACK on the security list. Peter Krempa (2): CVE-2015-0236: qemu: Check ACLs when dumping security info from save image CVE-2015-0236: qemu: Check ACLs when dumping security info from snapshots src/qemu/qemu_driver.c | 4 ++--

[libvirt] [PATCH 2/2] CVE-2015-0236: qemu: Check ACLs when dumping security info from snapshots

2015-01-22 Thread Peter Krempa
The ACL check didn't check the VIR_DOMAIN_XML_SECURE flag and the appropriate permission for it. Found via code inspection while fixing permissions for save images. --- src/qemu/qemu_driver.c | 2 +- src/remote/remote_protocol.x | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff

[libvirt] nodeinfo test cases for x86_64 AMD CPUs

2015-01-22 Thread Steffen Persvold
Hi, Lately we’ve been puzzled by the nodeinfo returned for AMD 63xx based platforms so I checked out libvirt from Git and checked out the testcases in test/nodeinfodata. Currently you have 3 AMD test cases there : linux-x86_64-test3 : AMD 6172 2.1 GHz (MCM, 12 cores per

[libvirt] [PATCH] conf: Disallow emulatorpin when numatune's in effect

2015-01-22 Thread Michal Privoznik
https://bugzilla.redhat.com/show_bug.cgi?id=1170492 In one of our previous commits (dc8b7ce7) we've obsoleted cputune/ in favor of numatune/ and others. If old element was passed it was basically ignored and interesting settings were copied from the new one. Well with one exception we'd forgotten

Re: [libvirt] [RFC PATCH 00/12] qemu: add support to hot-plug/unplug cpu device

2015-01-22 Thread Daniel P. Berrange
On Thu, Jan 22, 2015 at 07:02:27PM +0800, Zhu Guihua wrote: On Thu, 2015-01-22 at 10:06 +, Daniel P. Berrange wrote: On Thu, Jan 22, 2015 at 04:55:02PM +0800, Zhu Guihua wrote: On Wed, 2015-01-21 at 09:42 +, Daniel P. Berrange wrote: On Wed, Jan 21, 2015 at 04:00:52PM +0800, Zhu

Re: [libvirt] [PATCH v3 1/2] qemu: output error when try to hotplug unsupport console

2015-01-22 Thread Peter Krempa
On Thu, Jan 22, 2015 at 21:20:46 +0800, Luyao Huang wrote: On 01/22/2015 06:19 PM, Peter Krempa wrote: On Thu, Jan 22, 2015 at 10:28:18 +0800, Luyao Huang wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1164627 ... ACK, although the rest of the chardev command and hotplug code is a

Re: [libvirt] [libvirt-test-API][PATCH] Add connection_cpu_models test case

2015-01-22 Thread hongming
On 01/09/2015 03:58 PM, jiahu wrote: The connection_cpu_models.py uses getCPUModelNames() to validate new API virConnectGetCPUModelNames of libvirt. --- cases/test_connection.conf | 12 + repos/virconn/connection_cpu_models.py | 82 ++ 2 files

Re: [libvirt] [RFC PATCH 03/12] domain_conf: introduce cpu def helpers

2015-01-22 Thread Zhu Guihua
On Wed, 2015-01-21 at 10:16 +0100, Peter Krempa wrote: On Wed, Jan 21, 2015 at 16:00:55 +0800, Zhu Guihua wrote: virDomainCPUDefFree - free memory allocated virDomainCPUDefParseXML - parse job type virDomainCPUDefFormat - output job type This patch lacks addition to the RNG schemas that

Re: [libvirt] [PATCH 2/3] Grant access to helpers

2015-01-22 Thread Cedric Bosdonnat
On Wed, 2015-01-21 at 22:32 -0700, Mike Latimer wrote: On Tuesday, January 20, 2015 09:08:04 AM Cedric Bosdonnat wrote: On Mon, 2015-01-19 at 18:25 -0700, Mike Latimer wrote: Apparmor must not prevent access to required helper programs. The following helpers should be allowed to

Re: [libvirt] [RFC PATCH 00/11] qemu: add support to hotplug memory device

2015-01-22 Thread Zhu Guihua
On Wed, 2015-01-21 at 10:50 +0100, Peter Krempa wrote: On Wed, Jan 21, 2015 at 16:20:16 +0800, Zhu Guihua wrote: Now qemu has already supported memory hotplug, so this patchset will make libvirt support hotplug memory device for qemu driver. As I'm already working on this I can see a few

Re: [libvirt] [RFC PATCH 01/12] domain_conf: allocate cpu's apic id dynamically

2015-01-22 Thread Zhu Guihua
On Wed, 2015-01-21 at 09:56 +0100, Peter Krempa wrote: On Wed, Jan 21, 2015 at 16:00:53 +0800, Zhu Guihua wrote: Add a bitmap apic_idmap to store status of APIC IDs. If you want to use an APIC ID, you can find a minimum value which has not been used in the bitmap. Signed-off-by: Zhu

Re: [libvirt] [PATCH] network: verify proper address family in updates to host and range

2015-01-22 Thread Ján Tomko
On 01/19/2015 11:04 PM, Laine Stump wrote: By specifying parentIndex in a call to virNetworkUpdate(), it was possible to direct libvirt to add a dhcp range or static host of a non-matching address family to the dhcp element of an ip. For example, given: ip address='192.168.122.1'

Re: [libvirt] [PATCH v3 2/2] qemu: add a target type check when hot/cold-plug a Chr device

2015-01-22 Thread lhuang
On 01/22/2015 03:37 PM, Peter Krempa wrote: On Thu, Jan 22, 2015 at 10:28:19 +0800, Luyao Huang wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1164627 Add a func just check the base target type which qemu support. And this check will help to avoid add a qemu unsupport target type chr

Re: [libvirt] [RFC PATCH 00/12] qemu: add support to hot-plug/unplug cpu device

2015-01-22 Thread Zhu Guihua
On Wed, 2015-01-21 at 09:49 +0100, Peter Krempa wrote: On Wed, Jan 21, 2015 at 16:00:52 +0800, Zhu Guihua wrote: If you apply the folowing patchset [PATCH v3 0/7] cpu: add device_add foo-x86_64-cpu support https://lists.nongnu.org/archive/html/qemu-devel/2015-01/msg01552.html, and [PATCH

Re: [libvirt] [RFC PATCH 08/12] qemu: introduce qemuBuildCPUDeviceStr

2015-01-22 Thread Zhu Guihua
On Wed, 2015-01-21 at 10:24 +0100, Peter Krempa wrote: On Wed, Jan 21, 2015 at 16:01:00 +0800, Zhu Guihua wrote: qemuBuildCPUDeviceStr being introduced is responsible for creating command line argument for '-device' for given cpu device. Signed-off-by: Zhu Guihua

Re: [libvirt] [RFC PATCH 00/12] qemu: add support to hot-plug/unplug cpu device

2015-01-22 Thread Daniel P. Berrange
On Thu, Jan 22, 2015 at 04:57:39PM +0800, Zhu Guihua wrote: On Wed, 2015-01-21 at 09:57 +, Daniel P. Berrange wrote: On Wed, Jan 21, 2015 at 04:00:52PM +0800, Zhu Guihua wrote: If you apply the folowing patchset [PATCH v3 0/7] cpu: add device_add foo-x86_64-cpu support

Re: [libvirt] [RFC PATCH 00/12] qemu: add support to hot-plug/unplug cpu device

2015-01-22 Thread Daniel P. Berrange
On Thu, Jan 22, 2015 at 04:55:02PM +0800, Zhu Guihua wrote: On Wed, 2015-01-21 at 09:42 +, Daniel P. Berrange wrote: On Wed, Jan 21, 2015 at 04:00:52PM +0800, Zhu Guihua wrote: If you apply the folowing patchset [PATCH v3 0/7] cpu: add device_add foo-x86_64-cpu support

Re: [libvirt] [PATCH v3 1/2] qemu: output error when try to hotplug unsupport console

2015-01-22 Thread Peter Krempa
On Thu, Jan 22, 2015 at 10:28:18 +0800, Luyao Huang wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1164627 When using 'virsh attach-device' to hotplug an unsupported console type into a qemu guest, the attachment will erroneously allows the attachment. This patch will check to ensure

Re: [libvirt] [RFC PATCH 09/12] qemu: implement cpu device hotplug on live level

2015-01-22 Thread Zhu Guihua
On Wed, 2015-01-21 at 10:27 +0100, Peter Krempa wrote: On Wed, Jan 21, 2015 at 16:01:01 +0800, Zhu Guihua wrote: This patch implements live hotplug of a cpu device. Signed-off-by: Zhu Guihua zhugh.f...@cn.fujitsu.com --- src/qemu/qemu_driver.c | 6 ++ src/qemu/qemu_hotplug.c |

Re: [libvirt] [RFC PATCH 00/12] qemu: add support to hot-plug/unplug cpu device

2015-01-22 Thread Zhu Guihua
On Wed, 2015-01-21 at 09:57 +, Daniel P. Berrange wrote: On Wed, Jan 21, 2015 at 04:00:52PM +0800, Zhu Guihua wrote: If you apply the folowing patchset [PATCH v3 0/7] cpu: add device_add foo-x86_64-cpu support https://lists.nongnu.org/archive/html/qemu-devel/2015-01/msg01552.html, and

[libvirt] [PATCH 0/7] qemu: Job handling fixes

2015-01-22 Thread Peter Krempa
While reviewing Martin's reference counting series I've noticed a few qemu API impls that don't properly handle jobs. Peter Krempa (7): qemu: Fix job handling in qemuDomainPinVcpuFlags qemu: Fix job handling in qemuDomainPinEmulator qemu: Fix job handling in qemuDomainSetAutostart qemu:

[libvirt] [PATCH 5/7] qemu: Fix job handling in qemuDomainSetSchedulerParametersFlags

2015-01-22 Thread Peter Krempa
The code modifies the domain configuration but doesn't take a MODIFY type job to do so. --- src/qemu/qemu_driver.c | 32 +++- 1 file changed, 19 insertions(+), 13 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index f6b2967..c52821a 100644

[libvirt] [PATCH 4/7] qemu: Fix job handling in qemuDomainSetMemoryParameters

2015-01-22 Thread Peter Krempa
The code modifies the domain configuration but doesn't take a MODIFY type job to do so. --- src/qemu/qemu_driver.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index ecb3693..f6b2967 100644 ---

[libvirt] [PATCH 3/7] qemu: Fix job handling in qemuDomainSetAutostart

2015-01-22 Thread Peter Krempa
The code modifies the domain configuration but doesn't take a MODIFY type job to do so. This patch also fixes a few very long lines of code around the touched parts. --- src/qemu/qemu_driver.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git

Re: [libvirt] [RFC PATCH 11/12] qemu_monitor_json: sort JSON array of cpu info

2015-01-22 Thread Zhu Guihua
On Wed, 2015-01-21 at 10:34 +0100, Peter Krempa wrote: On Wed, Jan 21, 2015 at 16:01:03 +0800, Zhu Guihua wrote: JSON array of cpu info is sorted in order to find thread id of cpu smoothly. Signed-off-by: Zhu Guihua zhugh.f...@cn.fujitsu.com --- src/libvirt_private.syms | 1 +

Re: [libvirt] [RFC PATCH 00/12] qemu: add support to hot-plug/unplug cpu device

2015-01-22 Thread Zhu Guihua
On Wed, 2015-01-21 at 09:42 +, Daniel P. Berrange wrote: On Wed, Jan 21, 2015 at 04:00:52PM +0800, Zhu Guihua wrote: If you apply the folowing patchset [PATCH v3 0/7] cpu: add device_add foo-x86_64-cpu support https://lists.nongnu.org/archive/html/qemu-devel/2015-01/msg01552.html, and

Re: [libvirt] RFC: Building a virtlogd daemon

2015-01-22 Thread Guido Günther
On Wed, Jan 21, 2015 at 12:12:14PM +, Daniel P. Berrange wrote: [..snip..] So I'm intending to create a standalone virtlogd daemon to address this problem. Similarly to virtlockd, it will be able to re-exec itelf so that upgrades can be done with no interruption to logging, and libvirtd

[libvirt] [PATCH 6/7] qemu: Fix job type in qemuDomainGetBlockIoTune

2015-01-22 Thread Peter Krempa
The function just queries status so there's no need for a MODIFY type job. --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index c52821a..2c3c3e0 100644 --- a/src/qemu/qemu_driver.c +++

[libvirt] [PATCH 2/7] qemu: Fix job handling in qemuDomainPinEmulator

2015-01-22 Thread Peter Krempa
The code modifies the domain configuration but doesn't take a MODIFY type job to do so. --- src/qemu/qemu_driver.c | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 4882cab..fa2259a 100644 ---

[libvirt] [PATCH 7/7] qemu: Fix job handling in qemuDomainSetMetadata

2015-01-22 Thread Peter Krempa
The code modifies the domain configuration but doesn't take a MODIFY type job to do so. --- src/qemu/qemu_driver.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 2c3c3e0..ab65e9b 100644 --- a/src/qemu/qemu_driver.c +++

[libvirt] [PATCH 1/7] qemu: Fix job handling in qemuDomainPinVcpuFlags

2015-01-22 Thread Peter Krempa
The domain modifies the domain configuration but doesn't take a MODIFY type job to do it. --- src/qemu/qemu_driver.c | 32 +++- 1 file changed, 19 insertions(+), 13 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 5994558..4882cab 100644

Re: [libvirt] [RFC PATCH 00/11] qemu: add support to hotplug memory device

2015-01-22 Thread Peter Krempa
On Thu, Jan 22, 2015 at 16:24:12 +0800, Zhu Guihua wrote: On Wed, 2015-01-21 at 10:50 +0100, Peter Krempa wrote: On Wed, Jan 21, 2015 at 16:20:16 +0800, Zhu Guihua wrote: Thank you for pointing out the problems, and we hope the feature could be supported in libvirt as soon as possible.

Re: [libvirt] [PATCH v3 1/2] qemu: output error when try to hotplug unsupport console

2015-01-22 Thread Luyao Huang
On 01/22/2015 09:25 PM, Peter Krempa wrote: On Thu, Jan 22, 2015 at 21:20:46 +0800, Luyao Huang wrote: On 01/22/2015 06:19 PM, Peter Krempa wrote: On Thu, Jan 22, 2015 at 10:28:18 +0800, Luyao Huang wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1164627 ... ACK, although the rest of

[libvirt] [PATCH 0/5] Const correctnes/random fixes

2015-01-22 Thread Peter Krempa
Few fixes/tweaks that have accumulated in my memory hotplug branch. They should be trivial enough and semantically inert. Peter Krempa (5): conf: Fix comment mentioning actual type of @multi member of virDevicePCIAddress qemu: command: Honor const-correctnes in qemuBuildNumaArgStr util:

[libvirt] [PATCH 1/5] conf: Fix comment mentioning actual type of @multi member of virDevicePCIAddress

2015-01-22 Thread Peter Krempa
After refactor to use the virTristateSwitch enum the comment in the struct was not adjusted. --- src/conf/device_conf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/device_conf.h b/src/conf/device_conf.h index f067a35..7256cdc 100644 --- a/src/conf/device_conf.h

[libvirt] [PATCH 3/5] util: json: Make argument of virJSONValueArraySize const

2015-01-22 Thread Peter Krempa
The function doesn't allow to modify the array in any way, thus the argument can be const. --- src/util/virjson.c | 2 +- src/util/virjson.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/virjson.c b/src/util/virjson.c index 3ffa19f..9f2e1cf 100644 ---

Re: [libvirt] [RFC PATCH 00/12] qemu: add support to hot-plug/unplug cpu device

2015-01-22 Thread Zhu Guihua
On Thu, 2015-01-22 at 10:04 +, Daniel P. Berrange wrote: On Thu, Jan 22, 2015 at 04:57:39PM +0800, Zhu Guihua wrote: On Wed, 2015-01-21 at 09:57 +, Daniel P. Berrange wrote: On Wed, Jan 21, 2015 at 04:00:52PM +0800, Zhu Guihua wrote: If you apply the folowing patchset [PATCH

[libvirt] [PATCH 4/5] schemas: Move definition of 'hexuint' to basictypes

2015-01-22 Thread Peter Krempa
Allow reuse of the type. --- docs/schemas/basictypes.rng | 6 ++ docs/schemas/nodedev.rng| 6 -- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/docs/schemas/basictypes.rng b/docs/schemas/basictypes.rng index efc9da4..2bc9c1b 100644 --- a/docs/schemas/basictypes.rng +++

[libvirt] [PATCH 2/5] qemu: command: Honor const-correctnes in qemuBuildNumaArgStr

2015-01-22 Thread Peter Krempa
@def is modified in the function indirectly although it's marked as const. --- src/qemu/qemu_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 1ebfdd1..b4ac3d9 100644 --- a/src/qemu/qemu_command.c +++

[libvirt] [PATCH 5/5] util: bitmap: Tolerate NULL bitmaps in virBitmapEqual

2015-01-22 Thread Peter Krempa
--- src/util/virbitmap.c | 6 ++ src/util/virbitmap.h | 3 +-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/util/virbitmap.c b/src/util/virbitmap.c index 05c50e4..d5b0035 100644 --- a/src/util/virbitmap.c +++ b/src/util/virbitmap.c @@ -504,6 +504,12 @@ bool

Re: [libvirt] [PATCH 1/2] xenapi_driver: fix copy-paste typo

2015-01-22 Thread Pavel Hrdina
On 01/21/2015 06:29 PM, Peter Krempa wrote: On Wed, Jan 21, 2015 at 18:09:27 +0100, Pavel Hrdina wrote: Clang found that we are passing variable with wrong enum type to 'xenapiCrashExitEnum2virDomainLifecycle' function. This is probably copy-paste typo as the correct variable exists in the

Re: [libvirt] [PATCH 2/2] esx_vi: fix possible segfault

2015-01-22 Thread Pavel Hrdina
On 01/21/2015 06:47 PM, Peter Krempa wrote: On Wed, Jan 21, 2015 at 18:09:28 +0100, Pavel Hrdina wrote: Clang found possible dereference of NULL pointer which is right. Function 'esxVI_LookupTaskInfoByTask' should find a task info. The issue is that we could return 0 and leave 'taksInfo'

Re: [libvirt] [RFC PATCH 00/12] qemu: add support to hot-plug/unplug cpu device

2015-01-22 Thread Zhu Guihua
On Thu, 2015-01-22 at 10:06 +, Daniel P. Berrange wrote: On Thu, Jan 22, 2015 at 04:55:02PM +0800, Zhu Guihua wrote: On Wed, 2015-01-21 at 09:42 +, Daniel P. Berrange wrote: On Wed, Jan 21, 2015 at 04:00:52PM +0800, Zhu Guihua wrote: If you apply the folowing patchset [PATCH

Re: [libvirt] [PATCH 5/5] util: bitmap: Tolerate NULL bitmaps in virBitmapEqual

2015-01-22 Thread Michal Privoznik
On 22.01.2015 11:53, Peter Krempa wrote: --- src/util/virbitmap.c | 6 ++ src/util/virbitmap.h | 3 +-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/util/virbitmap.c b/src/util/virbitmap.c index 05c50e4..d5b0035 100644 --- a/src/util/virbitmap.c +++

Re: [libvirt] [PATCH 3/5] qemu: Fix auto-adding PCI bridge when all slots are reserved

2015-01-22 Thread Ján Tomko
On 01/21/2015 05:50 PM, Erik Skultety wrote: Commit 93c8ca tried to fix the issue with auto-adding of a PCI bridge controller, it worked well when the slots were reserved by devices with user defined addresses without any other devices with unspecified PCI addresses present in the XML.

Re: [libvirt] [PATCH 7/7] qemu: Fix job handling in qemuDomainSetMetadata

2015-01-22 Thread Ján Tomko
On 01/22/2015 10:20 AM, Peter Krempa wrote: The code modifies the domain configuration but doesn't take a MODIFY type job to do so. --- src/qemu/qemu_driver.c | 5 + 1 file changed, 5 insertions(+) ACK After getting the job, the virDomainLiveConfigHelperMethod is called inside

Re: [libvirt] [PATCH 4/5] qemu: move PCI slot assignment for PIIX3, Q35 into a separate function

2015-01-22 Thread Ján Tomko
On 01/21/2015 05:50 PM, Erik Skultety wrote: In order to be able to test for fully reserved PCI buses, assignment of PCI slots for integrated devices needs to be moved to a separate function. This also might be a good preparation if we decide to add support for other chipsets as well. ---

Re: [libvirt] [PATCH 0/5] Const correctnes/random fixes

2015-01-22 Thread Michal Privoznik
On 22.01.2015 11:53, Peter Krempa wrote: Few fixes/tweaks that have accumulated in my memory hotplug branch. They should be trivial enough and semantically inert. Peter Krempa (5): conf: Fix comment mentioning actual type of @multi member of virDevicePCIAddress qemu: command:

Re: [libvirt] [PATCH 2/3] Grant access to helpers

2015-01-22 Thread Mike Latimer
On Thursday, January 22, 2015 08:55:07 AM Cedric Bosdonnat wrote: Seems like the apparmor profile for libvirtd is pretty wide open, so I'm not sure if there will be much of a difference between those two settings. I'm also not sure how best to test the functionality of those helpers to

[libvirt] LSN-2015-0001: CVE-2015-0236 snapshots and save images leak VNC passwords

2015-01-22 Thread Eric Blake
Libvirt Security Notice: LSN-2015-0001 == Summary: snapshots and save images leak VNC passwords Reported on: 20150120 Published on: 20150122 Fixed on: 20150122 Reported by: Luyao Huang lhu...@redhat.com Patched by: Peter

Re: [libvirt] [PATCH 3/7] qemu: Fix job handling in qemuDomainSetAutostart

2015-01-22 Thread Ján Tomko
On 01/22/2015 10:20 AM, Peter Krempa wrote: The code modifies the domain configuration but doesn't take a MODIFY type job to do so. This patch also fixes a few very long lines of code around the touched parts. --- src/qemu/qemu_driver.c | 24 +--- 1 file changed, 17

Re: [libvirt] [PATCH 0/7] qemu: Job handling fixes

2015-01-22 Thread Ján Tomko
On 01/22/2015 10:20 AM, Peter Krempa wrote: While reviewing Martin's reference counting series I've noticed a few qemu API impls that don't properly handle jobs. Peter Krempa (7): qemu: Fix job handling in qemuDomainPinVcpuFlags qemu: Fix job handling in qemuDomainPinEmulator qemu:

Re: [libvirt] [PATCH 6/7] qemu: Fix job type in qemuDomainGetBlockIoTune

2015-01-22 Thread Ján Tomko
On 01/22/2015 10:20 AM, Peter Krempa wrote: The function just queries status so there's no need for a MODIFY type job. --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ACK Jan signature.asc Description: OpenPGP digital signature -- libvir-list mailing

Re: [libvirt] [PATCH] Fix virCgroupGetPercpuStats with non-continuous present CPUs

2015-01-22 Thread Michal Privoznik
On 22.01.2015 12:26, Ján Tomko wrote: Per-cpu stats are only shown for present CPUs in the cgroups, but we were only parsing the largest CPU number from /sys/devices/system/cpu/present and looking for stats even for non-present CPUs. This resulted in: internal error: cpuacct parse error ---

Re: [libvirt] [PATCH] Fix virCgroupGetPercpuStats with non-continuous present CPUs

2015-01-22 Thread Ján Tomko
On 01/22/2015 03:21 PM, Michal Privoznik wrote: On 22.01.2015 12:26, Ján Tomko wrote: Per-cpu stats are only shown for present CPUs in the cgroups, but we were only parsing the largest CPU number from /sys/devices/system/cpu/present and looking for stats even for non-present CPUs. This

Re: [libvirt] [PATCH 2/8] systemd: don't report an error if the guest is already terminated

2015-01-22 Thread Daniel P. Berrange
On Thu, Jan 22, 2015 at 04:22:36PM +0100, Michal Privoznik wrote: On 16.01.2015 18:36, Daniel P. Berrange wrote: In many cases where we invoke virSystemdTerminateMachine the process(es) will have already gone away on their own accord. In these cases we log an error message that the machine

Re: [libvirt] [PATCH] network: verify proper address family in updates to host and range

2015-01-22 Thread Laine Stump
On 01/22/2015 03:47 AM, Ján Tomko wrote: On 01/19/2015 11:04 PM, Laine Stump wrote: By specifying parentIndex in a call to virNetworkUpdate(), it was possible to direct libvirt to add a dhcp range or static host of a non-matching address family to the dhcp element of an ip. For example,

Re: [libvirt] [PATCH 0/8] Enable NIC reporting to systemd

2015-01-22 Thread Michal Privoznik
On 16.01.2015 18:36, Daniel P. Berrange wrote: This series enables the QEMU and LXC drivers to report the network interface backends they use to systemd. This gets then shown to the user in # machinectl status lxc-shell lxc-shell(95449419f969d649d9962566ec42af7d) Since: Fri

Re: [libvirt] [PATCH 2/8] systemd: don't report an error if the guest is already terminated

2015-01-22 Thread Michal Privoznik
On 16.01.2015 18:36, Daniel P. Berrange wrote: In many cases where we invoke virSystemdTerminateMachine the process(es) will have already gone away on their own accord. In these cases we log an error message that the machine does not exist. We should catch this particular error and simply

Re: [libvirt] [PATCH] Fix virCgroupGetPercpuStats with non-continuous present CPUs

2015-01-22 Thread Michal Privoznik
On 22.01.2015 15:52, Ján Tomko wrote: On 01/22/2015 03:21 PM, Michal Privoznik wrote: On 22.01.2015 12:26, Ján Tomko wrote: Per-cpu stats are only shown for present CPUs in the cgroups, but we were only parsing the largest CPU number from /sys/devices/system/cpu/present and looking for stats

[libvirt] [PATCH] cpu: add Freescale ppc64 CPU models

2015-01-22 Thread Olivia Yin
When running Openstack on Freescale ppc64 board, got libvirtError as before: nova.openstack.common.threadgroup libvirtError: XML error: Missing CPU model name. This patch is to add Freescale ppc64 CPU models. Signed-off-by: Olivia Yin hong-hua@freescale.com --- src/cpu/cpu_map.xml | 36

[libvirt] [PATCH] cpu: add Freescale ppc64 CPU models

2015-01-22 Thread Olivia Yin
Signed-off-by: Olivia Yin hong-hua@freescale.com --- src/cpu/cpu_map.xml | 38 +- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/src/cpu/cpu_map.xml b/src/cpu/cpu_map.xml index bd9b056..c34874e 100644 --- a/src/cpu/cpu_map.xml +++

Re: [libvirt] [RFC PATCH 00/12] qemu: add support to hot-plug/unplug cpu device

2015-01-22 Thread Zhu Guihua
[...] The choice of Nehalem, Opteron, etc as CPU models is already supported in QEMU and influences guest CPU performance. You're not explaining why we need to introduce multiple CPU cpu driver='qemu64-x86_64-cpu' values. It makes no sense to have two different CPU models listed for the same

[libvirt] [PATCH 6/6] storage: Check the partition name against provided name

2015-01-22 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1138516 If the provided volume name doesn't match what parted generated as the partition name, then return a failure. Update virsh.pod and formatstorage.html.in to describe the 'name' restriction for disk pools as well as the usage of the target's

[libvirt] [PATCH 5/6] storage: When delete extended partition, need to refresh pool

2015-01-22 Thread John Ferlan
When removing a volume that is the extended partition, all the logical volume partitions that exist within the extended partition will also be removed, so we need to refresh the pool to have the updated list Signed-off-by: John Ferlan jfer...@redhat.com --- src/storage/storage_backend_disk.c |

[libvirt] [PATCH 2/6] storage: Attempt error recovery in virStorageBackendDiskCreateVol

2015-01-22 Thread John Ferlan
During virStorageBackendDiskCreateVol if virStorageBackendDiskReadPartitions fails, then we were leaving with an error and a partition on the disk for which there was no corresponding volume and used space on the disk which could be reclaimable through direct parted activity. On a subsequent

[libvirt] [PATCH 4/6] storage: Adjust how to refresh extended partition disk data

2015-01-22 Thread John Ferlan
During virStorageBackendDiskMakeDataVol processing, if we find an extended partition, then handle it specially when updating the capacity/allocation rather than calling virStorageBackendUpdateVolInfo. As it turns out, once a logical partition exists, any attempt to refresh the pool or after

[libvirt] [PATCH 3/6] storage: Fix check for partition type for disk backing volumes

2015-01-22 Thread John Ferlan
While checking the existing partitions in virStorageBackendDiskPartFormat, the code would erroneously compare the volume target format type (eg, the virStoragePartedFsType) rather than the source partition type (eg, the virStorageVolTypeDisk) which is set during

[libvirt] [PATCH v2 1/2] util: Functions for getting/setting device options

2015-01-22 Thread akrowiak
From: Tony Krowiak akrow...@linux.vnet.ibm.com This patch provides the utility functions needed to synchronize the rxfilter changes made to a guest domain with the corresponding macvtap devices on the host: * Get/set PROMISC flag * Get/set ALLMULTI, MULTICAST Signed-off-by: Tony Krowiak

[libvirt] [PATCH 2/2] qemu: change macvtap device options in response to NIC_RX_FILTER_CHANGED

2015-01-22 Thread akrowiak
From: Tony Krowiak akrow...@linux.vnet.ibm.com This patch enables synchronization of the host macvtap device options with the guest device's in response to the NIC_RX_FILTER_CHANGED event. The following device options will be synchronized: * PROMISC * MULTICAST * ALLMULTI ---

[libvirt] (no subject)

2015-01-22 Thread akrowiak
From: Tony Krowiak akrow...@linux.vnet.ibm.com This patch set provides the code to synchonize some macvtap device modes when the values are changed on the guest's network device. The following modes will by synchronized: * PROMISC * MULTICAST * ALLMULTI I noticed something while testing this

[libvirt] [PATCHv2 0/6] Resolve issues in disk pool backend

2015-01-22 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1138516 v1: http://www.redhat.com/archives/libvir-list/2015-January/msg00465.html In my previous attempt to resolve the issue, I created a stateDir and saved the volume XML for each pool in order to attempt to preserve the volume name and target format

[libvirt] [PATCH 1/6] storage: Move virStorageBackendDiskDeleteVol

2015-01-22 Thread John Ferlan
Move the API to before virStorageBackendDiskCreateVol in order to be able to call the DeleteVol API when virStorageBackendDiskReadPartitions fails so that we don't by chance leave a partition on the disk. Signed-off-by: John Ferlan jfer...@redhat.com --- src/storage/storage_backend_disk.c | 137

[libvirt] [PATCH 1/2] util: Functions for getting/setting device options

2015-01-22 Thread akrowiak
From: Tony Krowiak akrow...@linux.vnet.ibm.com This patch provides the utility functions needed to synchronize the rxfilter changes made to a guest domain with the corresponding macvtap devices on the host: * Get/set PROMISC flag * Get/set ALLMULTI, MULTICAST --- src/libvirt_private.syms |8

[libvirt] [PATCH v3 1/2] util: Functions for getting/setting device options

2015-01-22 Thread akrowiak
From: Tony Krowiak akrow...@linux.vnet.ibm.com This patch provides the utility functions needed to synchronize the rxfilter changes made to a guest domain with the corresponding macvtap devices on the host: * Get/set PROMISC flag * Get/set ALLMULTI, MULTICAST Signed-off-by: Tony Krowiak

[libvirt] [PATCH v3 2/2] qemu: change macvtap device options in response to NIC_RX_FILTER_CHANGED

2015-01-22 Thread akrowiak
From: Tony Krowiak akrow...@linux.vnet.ibm.com This patch enables synchronization of the host macvtap device options with the guest device's in response to the NIC_RX_FILTER_CHANGED event. The following device options will be synchronized: * PROMISC * MULTICAST * ALLMULTI Signed-off-by: Tony

[libvirt] [PATCH v3 0/2] Sync macvtap device modes when guest rxfilter changes

2015-01-22 Thread akrowiak
From: Tony Krowiak akrow...@linux.vnet.ibm.com This patch set provides the code to synchonize some macvtap device modes when the values are changed on the guest's network device. The following modes will by synchronized: * PROMISC * MULTICAST * ALLMULTI I noticed something while testing this

[libvirt] [PATCH v2 2/2] qemu: change macvtap device options in response to NIC_RX_FILTER_CHANGED

2015-01-22 Thread akrowiak
From: Tony Krowiak akrow...@linux.vnet.ibm.com This patch enables synchronization of the host macvtap device options with the guest device's in response to the NIC_RX_FILTER_CHANGED event. The following device options will be synchronized: * PROMISC * MULTICAST * ALLMULTI Signed-off-by: Tony

[libvirt] [PATCH v3 1/2] systemd: fix build without dbus

2015-01-22 Thread Daniel P. Berrange
The virDBusMethodCall method has a DBusError as one of its parameters. If the caller wants to pass a non-NULL value for this, it immediately makes the calling code require DBus at build time. This has led to breakage of non-DBus builds several times. It is desirable that only the virdbus.c file

[libvirt] Assert with libvirt + xen hvm

2015-01-22 Thread CloudPatch Staff
We're hitting an assert whenever we try to create an HVM instance under Xen via libvirtd. System is running on Gentoo, package information as follows: app-emulation/xen-4.5.0 USE=api debug flask hvm pam pygrub python qemu screen app-emulation/xen-tools-4.5.0 USE=api debug flask hvm pam pygrub

[libvirt] [PATCH v3 2/2] systemd: avoid string comparisons on dbus error messages

2015-01-22 Thread Daniel P. Berrange
Add a virDBusErrorIsUnknownMethod helper so that callers don't need todo string comparisons themselves to detect standard error names. --- src/libvirt_private.syms | 1 + src/util/virdbus.c | 9 + src/util/virdbus.h | 2 ++ src/util/virsystemd.c| 3 +-- 4 files changed, 13

Re: [libvirt] nodeinfo test cases for x86_64 AMD CPUs

2015-01-22 Thread Steffen Persvold
On 22 Jan 2015, at 13:06, Steffen Persvold s...@numascale.com wrote: Hi, Lately we’ve been puzzled by the nodeinfo returned for AMD 63xx based platforms so I checked out libvirt from Git and checked out the testcases in test/nodeinfodata. Currently you have 3 AMD test cases there :

Re: [libvirt] Live Migration with Pass-through Devices proposal

2015-01-22 Thread Izumi, Taku
Hi Chen-san, Hi all, backgrond: Live migration is one of the most important features of virtualization technology. With regard to recent virtualization techniques, performance of network I/O is critical. Current network I/O virtualization (e.g. Para-virtualized I/O, VMDq) has a