On Wed, May 13, 2015 at 06:39:12AM -0400, John Ferlan wrote:
On 05/05/2015 12:39 PM, Eric Blake wrote:
On 05/05/2015 10:26 AM, Ján Tomko wrote:
On Tue, May 05, 2015 at 10:14:18AM -0600, Eric Blake wrote:
On 05/05/2015 10:05 AM, Ján Tomko wrote:
For some reason, we allow a bridge name
* Peter Krempa (pkre...@redhat.com) wrote:
On Wed, May 13, 2015 at 09:08:39 +0100, Dr. David Alan Gilbert wrote:
* Peter Krempa (pkre...@redhat.com) wrote:
On Wed, May 13, 2015 at 11:36:26 +0800, Chen Fan wrote:
my main goal is to add support migration with host NIC
passthrough
On Wed, May 13, 2015 at 09:40:23AM +0100, Dr. David Alan Gilbert wrote:
* Peter Krempa (pkre...@redhat.com) wrote:
On Wed, May 13, 2015 at 09:08:39 +0100, Dr. David Alan Gilbert wrote:
* Peter Krempa (pkre...@redhat.com) wrote:
On Wed, May 13, 2015 at 11:36:26 +0800, Chen Fan wrote:
* Peter Krempa (pkre...@redhat.com) wrote:
On Wed, May 13, 2015 at 09:40:23 +0100, Dr. David Alan Gilbert wrote:
* Peter Krempa (pkre...@redhat.com) wrote:
On Wed, May 13, 2015 at 09:08:39 +0100, Dr. David Alan Gilbert wrote:
* Peter Krempa (pkre...@redhat.com) wrote:
On Wed, May
On Wed, May 13, 2015 at 11:36:30AM +0800, Chen Fan wrote:
add migration support for ephemeral host devices, introduce
two 'detach' and 'restore' functions to unplug/plug host devices
during migration.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/qemu/qemu_migration.c | 171
On Sun, 2015-05-10 at 17:28 -0400, Cole Robinson wrote:
Instead of adding more bits to the .gitignore that aren't specific to the
project, I'd recommend you set up a global .gitignore to ignore editor bits:
https://stackoverflow.com/questions/7335420/global-git-ignore
Done, thanks for the
On Wed, May 13, 2015 at 09:08:39 +0100, Dr. David Alan Gilbert wrote:
* Peter Krempa (pkre...@redhat.com) wrote:
On Wed, May 13, 2015 at 11:36:26 +0800, Chen Fan wrote:
my main goal is to add support migration with host NIC
passthrough devices and keep the network connectivity.
On Wed, May 13, 2015 at 10:00:42AM +0100, Dr. David Alan Gilbert wrote:
* Peter Krempa (pkre...@redhat.com) wrote:
On Wed, May 13, 2015 at 09:40:23 +0100, Dr. David Alan Gilbert wrote:
* Peter Krempa (pkre...@redhat.com) wrote:
On Wed, May 13, 2015 at 09:08:39 +0100, Dr. David Alan
On Wed, May 13, 2015 at 10:36:34AM +0200, Peter Krempa wrote:
On Wed, May 13, 2015 at 11:36:30 +0800, Chen Fan wrote:
add migration support for ephemeral host devices, introduce
two 'detach' and 'restore' functions to unplug/plug host devices
during migration.
Signed-off-by: Chen Fan
* Daniel P. Berrange (berra...@redhat.com) wrote:
On Wed, May 13, 2015 at 10:00:42AM +0100, Dr. David Alan Gilbert wrote:
* Peter Krempa (pkre...@redhat.com) wrote:
On Wed, May 13, 2015 at 09:40:23 +0100, Dr. David Alan Gilbert wrote:
* Peter Krempa (pkre...@redhat.com) wrote:
On
On 05/05/2015 12:39 PM, Eric Blake wrote:
On 05/05/2015 10:26 AM, Ján Tomko wrote:
On Tue, May 05, 2015 at 10:14:18AM -0600, Eric Blake wrote:
On 05/05/2015 10:05 AM, Ján Tomko wrote:
For some reason, we allow a bridge name with %d in it, which we replace
with an unsigned integer to form a
On Wed, May 13, 2015 at 11:36:30 +0800, Chen Fan wrote:
add migration support for ephemeral host devices, introduce
two 'detach' and 'restore' functions to unplug/plug host devices
during migration.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/qemu/qemu_migration.c | 171
On Wed, May 13, 2015 at 09:40:23 +0100, Dr. David Alan Gilbert wrote:
* Peter Krempa (pkre...@redhat.com) wrote:
On Wed, May 13, 2015 at 09:08:39 +0100, Dr. David Alan Gilbert wrote:
* Peter Krempa (pkre...@redhat.com) wrote:
On Wed, May 13, 2015 at 11:36:26 +0800, Chen Fan wrote:
On Wed, May 13, 2015 at 01:55:43PM +0200, Michal Privoznik wrote:
Due to a kernel commit (b4b8f770e), cpuinfo format has changed on
ARMs. Firstly, 'Processor: ...' may not be reported, it's
replaced by 'model name: ...'. Secondly, the Processor string
may occur in CPU name, e.g. 'ARMv7
Signed-off-by: Jiri Denemark jdene...@redhat.com
---
Notes:
Version 2:
- new patch
src/conf/domain_conf.c| 6 -
src/conf/domain_conf.h| 10
src/libvirt_private.syms | 1 -
src/qemu/qemu_blockjob.c | 48 +
On 05/07/2015 03:20 PM, Nikolay Shirokovskiy wrote:
We have a lot of passing arguments code just to pass connection
object cause it holds jobTimeout. Taking into account that
right now this value is defined at compile time let's just
get rid of it and make arguments list more clear in many
Again, a clean-up for which we don't have proper syntax-check.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/lxc/lxc_controller.c | 16
tests/jsontest.c | 12 ++--
2 files changed, 14 insertions(+), 14 deletions(-)
diff --git
We don't allow it in normal code, why would it need to be in the
generated one. IT also splits the line in perl code so it's readable.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/rpc/gendispatch.pl | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git
Since we don't have syntax-check for this, it has to be checked
manually. Let's hope this is the only place it happened.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/rpc/virnetserver.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/rpc/virnetserver.c
Instead of redoing the same filtering over and over everytime we need to
walk through all disks which are being migrated.
Signed-off-by: Jiri Denemark jdene...@redhat.com
---
Notes:
Version 2:
- make use of per-disk private data
src/qemu/qemu_domain.h| 2 ++
This only affected the servers that re-exec themselves, which is only
virtlockd and it didn't do any mess, so this is mostly a clenaup.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/rpc/virnetserver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On 27.04.2015 15:49, Martin Kletzander wrote:
In order not to bring in any link dependencies, bridge driver doesn't
use the usual stubs as other conditionally-built code does. However,
having the function as a macro imposes a problem with possibly unused
variables if just defined as 0. This
On 05/13/2015 03:37 AM, Peter Krempa wrote:
On Tue, May 12, 2015 at 16:03:33 -0400, John Ferlan wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=976387
For a domain configured using the host cdrom, we should taint the domain
due to problems encountered when the host and guest try to
Due to a kernel commit (b4b8f770e), cpuinfo format has changed on
ARMs. Firstly, 'Processor: ...' may not be reported, it's
replaced by 'model name: ...'. Secondly, the Processor string
may occur in CPU name, e.g. 'ARMv7 Processor rev 5 (v7l)'.
Therefore, we must firstly look for 'model name' and
Just a couple of them this time.
Martin Kletzander (4):
rpc: Don't mix max_clients and max_workers in PostExecRestart
virnetserver: Remove unnecessary double space
gendispatch: Don't generate long lines
Some alignment fixes in lxc_controller and jsontest
src/lxc/lxc_controller.c | 16
Signed-off-by: Jiri Denemark jdene...@redhat.com
---
Notes:
Version 2:
- new patch
src/conf/domain_conf.c| 14 +-
src/conf/domain_conf.h| 6 +-
src/parallels/parallels_sdk.c | 4 ++--
src/qemu/qemu_command.c | 4 ++--
src/vbox/vbox_common.c
Version 2:
- move QEMU-only data from virDomainDiskDef to a private data object
Jiri Denemark (5):
Add privateData to virDomainDiskDef
Rename virDomainHasBlockjob as qemuDomainHasBlockjob
Move QEMU-only fields from virDomainDiskDef into privateData
qemu: Keep track of what disks are being
And move it to qemu_domain.[ch] because this API is QEMU-only.
Signed-off-by: Jiri Denemark jdene...@redhat.com
---
Notes:
Version 2:
- new patch
src/conf/domain_conf.c| 27 ---
src/conf/domain_conf.h| 3 ---
src/qemu/qemu_domain.c| 28
When cancelling drive mirror, always try to do that for all disks even
if it fails for some of them. Report the first error we saw.
Signed-off-by: Jiri Denemark jdene...@redhat.com
---
Notes:
Version 2:
- rebased (context changed)
src/qemu/qemu_migration.c | 15 ---
1 file
On 05/13/2015 10:42 AM, Dr. David Alan Gilbert wrote:
* Laine Stump (la...@redhat.com) wrote:
On 05/13/2015 04:28 AM, Peter Krempa wrote:
On Wed, May 13, 2015 at 09:08:39 +0100, Dr. David Alan Gilbert wrote:
* Peter Krempa (pkre...@redhat.com) wrote:
On Wed, May 13, 2015 at 11:36:26 +0800,
We have a lot of passing arguments code just to pass connection
object cause it holds jobTimeout. Taking into account that
right now this value is defined at compile time let's just
get rid of it and make arguments list more clear in many
places.
In case we later need some runtime configurable
On 05/10/2015 03:28 PM, Cole Robinson wrote:
On 05/05/2015 07:34 AM, Andrea Bolognani wrote:
This removes some noise when you're working on the repository
and also have a bunch of source files open in Vim in another
terminal.
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff
On 05/13/2015 04:36 AM, Peter Krempa wrote:
On Wed, May 13, 2015 at 11:36:30 +0800, Chen Fan wrote:
add migration support for ephemeral host devices, introduce
two 'detach' and 'restore' functions to unplug/plug host devices
during migration.
Signed-off-by: Chen Fan
On 05/13/2015 04:55 AM, Ján Tomko wrote:
Okay, I see your counterargument. Still, strstr() is pretty expensive
compared to just:
if (def-bridge
(p = strchr(def-bridge, '%')) == strrchr(def-bridge, '%')
p[1] == 'd')
Coverity complains :
Event returned_null: strchr
* Laine Stump (la...@redhat.com) wrote:
On 05/13/2015 04:28 AM, Peter Krempa wrote:
On Wed, May 13, 2015 at 09:08:39 +0100, Dr. David Alan Gilbert wrote:
* Peter Krempa (pkre...@redhat.com) wrote:
On Wed, May 13, 2015 at 11:36:26 +0800, Chen Fan wrote:
my main goal is to add support
On 13.05.2015 07:56, zhang bo wrote:
The variable 'now' is useless in qemuMigrationPrepareAny(), so I clear it.
Signed-off-by: Wang Yufei james.wangyu...@huawei.com
Signed-off-by: Zhang Bo oscar.zhan...@huawei.com
---
src/qemu/qemu_migration.c | 4
1 file changed, 4 deletions(-)
On 05/05/2015 05:34 AM, Andrea Bolognani wrote:
This removes some noise when you're working on the repository
and also have a bunch of source files open in Vim in another
terminal.
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index
On 05/13/2015 10:58 AM, Eric Blake wrote:
On 05/13/2015 04:55 AM, Ján Tomko wrote:
Okay, I see your counterargument. Still, strstr() is pretty expensive
compared to just:
if (def-bridge
(p = strchr(def-bridge, '%')) == strrchr(def-bridge, '%')
p[1] == 'd')
Coverity complains
On 05/13/2015 04:28 AM, Peter Krempa wrote:
On Wed, May 13, 2015 at 09:08:39 +0100, Dr. David Alan Gilbert wrote:
* Peter Krempa (pkre...@redhat.com) wrote:
On Wed, May 13, 2015 at 11:36:26 +0800, Chen Fan wrote:
my main goal is to add support migration with host NIC
passthrough devices and
On 05/13/2015 05:57 AM, Daniel P. Berrange wrote:
On Wed, May 13, 2015 at 11:36:30AM +0800, Chen Fan wrote:
add migration support for ephemeral host devices, introduce
two 'detach' and 'restore' functions to unplug/plug host devices
during migration.
Signed-off-by: Chen Fan
On Wed, May 13, 2015 at 12:32:20 -0400, John Ferlan wrote:
Coverity points out it's possible for one of the virCommand{Output|Error}*
API's to have not allocated 'output' and/or 'error' in which case the
strstr comparison will cause a NULL deref
Signed-off-by: John Ferlan jfer...@redhat.com
* Laine Stump (la...@redhat.com) wrote:
On 05/13/2015 10:42 AM, Dr. David Alan Gilbert wrote:
* Laine Stump (la...@redhat.com) wrote:
On 05/13/2015 04:28 AM, Peter Krempa wrote:
On Wed, May 13, 2015 at 09:08:39 +0100, Dr. David Alan Gilbert wrote:
* Peter Krempa (pkre...@redhat.com)
The first one is one I forgot the last time I sent Coverity patches a
few weeks ago. The next two are from changes made recently.
John Ferlan (3):
storage: Resolve Coverity FORWARD_NULL
conf: Resolve Coverity FORWARD_NULL
network: Resolve Coverity FORWARD_NULL
src/conf/domain_conf.c
Coverity points out it's possible for one of the virCommand{Output|Error}*
API's to have not allocated 'output' and/or 'error' in which case the
strstr comparison will cause a NULL deref
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/storage/storage_backend_disk.c | 2 +-
1 file changed,
On 05/13/2015 10:30 PM, Laine Stump wrote:
On 05/13/2015 05:57 AM, Daniel P. Berrange wrote:
On Wed, May 13, 2015 at 11:36:30AM +0800, Chen Fan wrote:
add migration support for ephemeral host devices, introduce
two 'detach' and 'restore' functions to unplug/plug host devices
during migration.
On 05/13/2015 04:17 PM, Peter Krempa wrote:
On Wed, May 13, 2015 at 11:36:29 +0800, Chen Fan wrote:
currently, we only support PCI host devices with ephemeral flag.
and USB already supports migration. so maybe in the near future we
can support SCSI.
Signed-off-by: Chen Fan
Quoting Guido Günther (a...@sigxcpu.org):
On Tue, May 12, 2015 at 11:14:09AM +0200, Martin Kletzander wrote:
On Tue, May 12, 2015 at 05:27:34PM +1000, Tony Breeds wrote:
On Mon, May 11, 2015 at 01:14:58PM +0200, Martin Kletzander wrote:
Determining this by version might not be reliable,
Even though it's been pointed out they are false positives:
http://www.redhat.com/archives/libvir-list/2015-May/msg00301.html
and
http://www.redhat.com/archives/libvir-list/2015-May/msg00302.html
these still show up as Coverity issues. In order to silence Coverity
add an 'sa_assert' prior to
On 05/13/2015 05:23 PM, Nikolay Shirokovskiy wrote:
We have a lot of passing arguments code just to pass connection
object cause it holds jobTimeout. Taking into account that
right now this value is defined at compile time let's just
get rid of it and make arguments list more clear in many
To silence Coverity just add a 'p ' in front of the check in
networkFindUnusedBridgeName after the strchr() call. Even though
we know it's not possible to have strchr return NULL since the only
way into the function is if there is a '%' in def-bridge or it's NULL.
Signed-off-by: John Ferlan
On Mon, May 11, 2015 at 05:26:09PM +0200, Michal Privoznik wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=998813
Implementation is pretty straight-forward. Of course, not all qemus
out there supports the device, so new capability is introduced and
checked prior each use of the device.
On 05/13/2015 04:36 PM, Peter Krempa wrote:
On Wed, May 13, 2015 at 11:36:30 +0800, Chen Fan wrote:
add migration support for ephemeral host devices, introduce
two 'detach' and 'restore' functions to unplug/plug host devices
during migration.
Signed-off-by: Chen Fan
The variable 'now' is useless in qemuMigrationPrepareAny(), so I clear it.
Signed-off-by: Wang Yufei james.wangyu...@huawei.com
Signed-off-by: Zhang Bo oscar.zhan...@huawei.com
---
src/qemu/qemu_migration.c | 4
1 file changed, 4 deletions(-)
diff --git a/src/qemu/qemu_migration.c
On Tue, May 12, 2015 at 16:03:33 -0400, John Ferlan wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=976387
For a domain configured using the host cdrom, we should taint the domain
due to problems encountered when the host and guest try to control the tray.
Signed-off-by: John Ferlan
On Wed, 2015-05-06 at 11:59 -0600, Jim Fehlig wrote:
Dario Faggioli wrote:
On Fri, 2015-05-01 at 15:32 -0600, Jim Fehlig wrote:
E.g. if a domain is configured to use memory allocated from certain numa
nodes, we'd want to make sure the dest has sufficient memory amongst
those nodes.
On Tue, May 12, 2015 at 07:00:07PM +0200, Pavel Hrdina wrote:
In the XML we have the vnc port number, but QEMU takes on command line
a vnc screen number, it's port-5900. We should fail with error message
that only ports in range [5900,65535] are valid.
Resolves:
On Tue, May 12, 2015 at 11:44:49AM -0600, Eric Blake wrote:
On 05/12/2015 10:23 AM, Michal Privoznik wrote:
Due to a commit in kernel (155597223) it's 'processor' rather than
'Processor'. Fix our parser too.
Shouldn't we be parsing this string case-insensitively, to work with
kernels that
On Wed, May 13, 2015 at 11:36:26 +0800, Chen Fan wrote:
my main goal is to add support migration with host NIC
passthrough devices and keep the network connectivity.
this series patch base on Shradha's patches on
https://www.redhat.com/archives/libvir-list/2012-November/msg01324.html
which
* Peter Krempa (pkre...@redhat.com) wrote:
On Wed, May 13, 2015 at 11:36:26 +0800, Chen Fan wrote:
my main goal is to add support migration with host NIC
passthrough devices and keep the network connectivity.
this series patch base on Shradha's patches on
On Wed, May 13, 2015 at 10:05:24AM +0200, Peter Krempa wrote:
On Wed, May 13, 2015 at 11:36:26 +0800, Chen Fan wrote:
my main goal is to add support migration with host NIC
passthrough devices and keep the network connectivity.
this series patch base on Shradha's patches on
On Wed, May 13, 2015 at 11:36:29 +0800, Chen Fan wrote:
currently, we only support PCI host devices with ephemeral flag.
and USB already supports migration. so maybe in the near future we
can support SCSI.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/qemu/qemu_command.c
On Wed, May 13, 2015 at 08:54:49AM +0800, zhang bo wrote:
On 2015/5/12 16:56, Daniel P. Berrange wrote:
On Tue, May 12, 2015 at 04:14:37PM +0800, zhang bo wrote:
So, Is there any other better solution? thanks in advance.
Simply don't change the system time by massive deltas. Libvirt
On Wed, May 13, 2015 at 09:51:08AM +0200, Martin Kletzander wrote:
On Tue, May 12, 2015 at 07:00:07PM +0200, Pavel Hrdina wrote:
In the XML we have the vnc port number, but QEMU takes on command line
a vnc screen number, it's port-5900. We should fail with error message
that only ports in
63 matches
Mail list logo
