Re: [libvirt] [PATCH 1/2] qemuBuildMemoryBackendStr: Fix hugepages lookup process

2015-06-26 Thread Peter Krempa
On Thu, Jun 25, 2015 at 18:13:02 +0200, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1196644 So this function is called to construct the guest NUMA part of the qemu command line. At the beginning, the configured hugepages This function constructs the backend (host

Re: [libvirt] [PATCH 2/2] qemuBuildMemoryBackendStr: Honour passed @pagesize

2015-06-26 Thread Peter Krempa
On Thu, Jun 25, 2015 at 18:13:03 +0200, Michal Privoznik wrote: So far the argument has not much meaning and was practically ignored. This is not good since when doing memory hotplug, the size of desired hugepage backing is passed in that argument. Taking closer look at the tests I'm fixing

Re: [libvirt] [PATCH 1/5] internal: Introduce virCheckNonEmptyStringArgGoto and reuse it

2015-06-26 Thread Peter Krempa
On Thu, Jun 25, 2015 at 12:23:43 -0400, John Ferlan wrote: On 06/23/2015 01:15 PM, Peter Krempa wrote: The helper makes sure that strings passed to APIs are non-NULL and non-empty. This allows to drop some inlined checks where it does not make sense. --- src/internal.h | 11

Re: [libvirt] [PATCH v2 1/3] vz: add net dev statistiscs

2015-06-26 Thread Nikolay Shirokovskiy
On 25.06.2015 17:51, Dmitry Guryanov wrote: On 06/18/2015 12:28 PM, Nikolay Shirokovskiy wrote: From: Nikolay Shirokovskiy nshirokovs...@parallels.com Populate counters SDK currenly supports: rx_bytes rx_packets tx_bytes tx_packets Comments. 1. Use

Re: [libvirt] [PATCH v2] docs: Properly mark acl.html dependencies

2015-06-26 Thread Martin Kletzander
On Fri, Jun 26, 2015 at 09:51:26AM +0200, Michal Privoznik wrote: On 25.06.2015 23:09, Martin Kletzander wrote: On Wed, Jun 24, 2015 at 12:44:37PM +0200, Martin Kletzander wrote: On Wed, Jun 24, 2015 at 08:53:21AM +0200, Peter Krempa wrote: On Tue, Jun 23, 2015 at 14:46:36 +0200, Martin

Re: [libvirt] [PATCH v2] docs: Properly mark acl.html dependencies

2015-06-26 Thread Michal Privoznik
On 25.06.2015 23:09, Martin Kletzander wrote: On Wed, Jun 24, 2015 at 12:44:37PM +0200, Martin Kletzander wrote: On Wed, Jun 24, 2015 at 08:53:21AM +0200, Peter Krempa wrote: On Tue, Jun 23, 2015 at 14:46:36 +0200, Martin Kletzander wrote: On Tue, Jun 23, 2015 at 01:56:00PM +0200, Michal

Re: [libvirt] [libvirt-php][PATCH v1] fix installation prefix

2015-06-26 Thread Michal Privoznik
On 24.06.2015 08:27, Vasiliy Tolstov wrote: when prefix present all stuff installed to /usr/usr/ Signed-off-by: Vasiliy Tolstov v.tols...@selfip.ru --- src/Makefile.am | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am

Re: [libvirt] [libvirt-php][PATCH v1] add libvirt_domain_qemu_agent_command

2015-06-26 Thread Michal Privoznik
On 24.06.2015 08:27, Vasiliy Tolstov wrote: add another missing libvirt command Signed-off-by: Vasiliy Tolstov v.tols...@selfip.ru --- configure.ac | 3 +++ src/Makefile.am | 5 +++-- src/libvirt-php.c | 28 src/libvirt-php.h | 2 ++ 4 files

Re: [libvirt] [PATCH v2 3/3] vz: add memory statistics

2015-06-26 Thread Nikolay Shirokovskiy
On 25.06.2015 20:36, Dmitry Guryanov wrote: On 06/18/2015 12:28 PM, Nikolay Shirokovskiy wrote: From: Nikolay Shirokovskiy nshirokovs...@parallels.com Implemented counters: VIR_DOMAIN_MEMORY_STAT_SWAP_IN VIR_DOMAIN_MEMORY_STAT_SWAP_OUT VIR_DOMAIN_MEMORY_STAT_MINOR_FAULT

Re: [libvirt] Plans for next release

2015-06-26 Thread Daniel P. Berrange
On Thu, Jun 25, 2015 at 09:50:42PM +0200, Martin Kletzander wrote: [adding Dan to Cc as he asked me about this right before I had to leave for an appointment] On Thu, Jun 25, 2015 at 10:08:10PM +0800, Daniel Veillard wrote: Sorry I nearly forgot, but we should enter freeze soon to try to

Re: [libvirt] [sandbox PATCH 04/10] Add disk support to the container builder

2015-06-26 Thread Daniel P. Berrange
On Fri, Jun 26, 2015 at 03:27:39PM +0200, Eren Yagdiran wrote: Use the new disk configuration in the container builder to provide disks in lxc containers sandboxes. --- .../libvirt-sandbox-builder-container.c| 33 +- 1 file changed, 32 insertions(+), 1

Re: [libvirt] [sandbox 06/10] init-qemu: extract the mounts.cfg entry mounting code

2015-06-26 Thread Daniel P. Berrange
On Thu, Jun 25, 2015 at 06:49:43PM +0200, Cédric Bosdonnat wrote: Create a mount_entry function from the code mounting the entries defined in mounts.cfg in order to be able to reuse that code. This will later be useful to mount a / from mounts.cfg. ---

Re: [libvirt] [sandbox 09/10] Don't add sandbox:root device if we have a mount targetting /

2015-06-26 Thread Daniel P. Berrange
On Thu, Jun 25, 2015 at 06:49:46PM +0200, Cédric Bosdonnat wrote: There is no need to expose the host file system if the user defined a mount targetting / --- libvirt-sandbox/libvirt-sandbox-builder-machine.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) ACK

Re: [libvirt] [sandbox 08/10] Add function to check if there is a mount with / target

2015-06-26 Thread Daniel P. Berrange
On Thu, Jun 25, 2015 at 06:49:45PM +0200, Cédric Bosdonnat wrote: gvir_sandbox_config_has_root_mount is a convenience function to check if there is a mount with target '/' --- libvirt-sandbox/libvirt-sandbox-config.c | 21 + libvirt-sandbox/libvirt-sandbox-config.h | 1 +

Re: [libvirt] [PATCH v3 0/4] vz: add statistics

2015-06-26 Thread Dmitry Guryanov
On 06/26/2015 02:24 PM, Nikolay Shirokovskiy wrote: Add vz statistics for network, cpu and memory. CHANGES from v1. subject prefix changed from 'parallels' to 'vz' CHANGES from v2. 1. Concering all patches - most of implementation details are moved to vz_sdk.c. Reason is that first this makes

Re: [libvirt] [PATCH v3 0/4] vz: add statistics

2015-06-26 Thread Peter Krempa
On Fri, Jun 26, 2015 at 16:51:59 +0300, Dmitry Guryanov wrote: On 06/26/2015 02:24 PM, Nikolay Shirokovskiy wrote: Add vz statistics for network, cpu and memory. CHANGES from v1. subject prefix changed from 'parallels' to 'vz' CHANGES from v2. 1. Concering all patches - most of

Re: [libvirt] [PATCH v2 0/3] Defer Admin API enablement post-release

2015-06-26 Thread Daniel Veillard
On Fri, Jun 26, 2015 at 05:26:27PM +0200, Martin Kletzander wrote: Even when rushing, you sometimes don't finish what you want. And I'd rather chosen safe road and avoid risks. And we have no usable API function in the admin API or a client binary just yet. Hence the temporary disablement

[libvirt] [PATCH v3 2/2] Storage : Fix cloning of raw, sparse volumes

2015-06-26 Thread Prerna Saxena
When virsh vol-clone is attempted on a raw file where capacity allocation, the resulting cloned volume has a size that matches the virtual-size of the parent; in place of matching its actual, disk size. This patch fixes the cloned disk to have same _allocated_size_ as the parent file from which

[libvirt] [libvirt-python PATCH] Revert Change livbirt version to 1.3.0 for the next release

2015-06-26 Thread Martin Kletzander
This reverts commit 751e016f09a6a0dd372667bdd2b322731718e359. Since Admin API was deferred for a release and the minor version bump didn't happen, it must not happen in libvirt-python either, for compatibility reasons. --- This must be applied before release if and only if the same happens in

Re: [libvirt] [sandbox PATCH 05/10] Add disk support to machine builder

2015-06-26 Thread Daniel P. Berrange
On Fri, Jun 26, 2015 at 03:27:40PM +0200, Eren Yagdiran wrote: Use the new disk configuration in the container builder to provide disks in qemu sandboxes. The disks are virtio devices, but those shouldn't be known by the user. --- libvirt-sandbox/libvirt-sandbox-builder-machine.c | 38

Re: [libvirt] [sandbox PATCH 09/10] Common-init: Building symlink from disks.cfg

2015-06-26 Thread Daniel P. Berrange
On Fri, Jun 26, 2015 at 03:27:44PM +0200, Eren Yagdiran wrote: Similar to the existing mounts.cfg, the mapping between the device and the tag is passed by a new disks.cfg file. Common-init reads disks.cfg and maps the tags to corresponding devices ---

Re: [libvirt] [libvirt-python PATCH] Revert Change livbirt version to 1.3.0 for the next release

2015-06-26 Thread Daniel Veillard
On Fri, Jun 26, 2015 at 05:42:48PM +0200, Martin Kletzander wrote: This reverts commit 751e016f09a6a0dd372667bdd2b322731718e359. Since Admin API was deferred for a release and the minor version bump didn't happen, it must not happen in libvirt-python either, for compatibility reasons. ---

Re: [libvirt] [sandbox PATCH 08/10] Init-util : Common directory functions for init-common and init-qemu

2015-06-26 Thread Daniel P. Berrange
On Fri, Jun 26, 2015 at 03:27:43PM +0200, Eren Yagdiran wrote: Init-util provides common functions for creating directories for both Init-common and Init-qemu. Error handling needs to be done in calling function. --- libvirt-sandbox/Makefile.am | 4 +-

Re: [libvirt] [sandbox PATCH 10/10] Common-builder: /dev/disk/by-tag/thetag to /dev/vdN

2015-06-26 Thread Daniel P. Berrange
On Fri, Jun 26, 2015 at 03:27:45PM +0200, Eren Yagdiran wrote: Common builder counts the disks devices and populates disks.cfg according to that.Disk devices are always come first than host-based images.In builder-machine, mounts of the host-based images will be mounted later. ---

Re: [libvirt] [PATCH v2 0/3] Defer Admin API enablement post-release

2015-06-26 Thread Daniel P. Berrange
On Fri, Jun 26, 2015 at 05:26:27PM +0200, Martin Kletzander wrote: Even when rushing, you sometimes don't finish what you want. And I'd rather chosen safe road and avoid risks. And we have no usable API function in the admin API or a client binary just yet. Hence the temporary disablement

Re: [libvirt] [PATCH 00/13] PCIe fixes + new PCI controllers w/RFC

2015-06-26 Thread Laine Stump
On 06/25/2015 02:44 AM, Martin Kletzander wrote: On Wed, Jun 24, 2015 at 12:04:33PM -0400, Laine Stump wrote: I think the only votes were for option 1 and 4 (interesting how the only ones that were chosen were those that I *didn't* pick personally :-). See comments below. In the meantime the

Re: [libvirt] [libvirt-python PATCH] Revert Change livbirt version to 1.3.0 for the next release

2015-06-26 Thread Daniel P. Berrange
On Fri, Jun 26, 2015 at 05:42:48PM +0200, Martin Kletzander wrote: This reverts commit 751e016f09a6a0dd372667bdd2b322731718e359. Since Admin API was deferred for a release and the minor version bump didn't happen, it must not happen in libvirt-python either, for compatibility reasons. ---

Re: [libvirt] [sandbox PATCH 00/10] Patches for Libvirt-sandbox

2015-06-26 Thread Daniel P. Berrange
On Fri, Jun 26, 2015 at 03:27:35PM +0200, Eren Yagdiran wrote: Hello, These patches provide disk support for libvirt-sandbox. Implemented '--disk' parameter will be useful when integrating Docker image support for libvirt-sandbox. --Main diffs compared to previous patches. Since many

Re: [libvirt] [sandbox 07/10] qemu: use mounts targeting / as root

2015-06-26 Thread Daniel P. Berrange
On Thu, Jun 25, 2015 at 06:49:44PM +0200, Cédric Bosdonnat wrote: So far a mount with / as target doesn't change anything: the host / is still the one mounted as /. libvirt-sandbox-init-qemu now detects the presence of a / target in mounts.cfg and mounts it instead of sandbox:root. ---

Re: [libvirt] [sandbox 04/10] Copy init-common and all its deps to config subdir

2015-06-26 Thread Daniel P. Berrange
On Thu, Jun 25, 2015 at 06:49:41PM +0200, Cédric Bosdonnat wrote: In order to be able to mount a custom host-image as / we need to be able to access libvirt-sandbox-init-common and all its needed dependencies. They are now copied into SANDBOXCONFIGDIR /.libs. Hard linking is not possible

Re: [libvirt] [sandbox PATCH 02/10] Add configuration object for disk support

2015-06-26 Thread Daniel P. Berrange
On Fri, Jun 26, 2015 at 03:27:37PM +0200, Eren Yagdiran wrote: Add the config gobject, functions to store and load the new configuration fragments and test. This will allow creating sandboxes with attached disk with a parameter formatted like file:tag=/source/file.qcow2,format=qcow2 ---

Re: [libvirt] [sandbox PATCH 03/10] Add disk parameter to virt-sandbox

2015-06-26 Thread Daniel P. Berrange
On Fri, Jun 26, 2015 at 03:27:38PM +0200, Eren Yagdiran wrote: Allow users to add disk images to their sandbox. Only disk images are supported so far, but the parameter is intentionally designed for future changes. --- bin/virt-sandbox.c | 37 + 1 file

Re: [libvirt] [sandbox PATCH 06/10] Add gvir_sandbox_config_has_disks function

2015-06-26 Thread Daniel P. Berrange
On Fri, Jun 26, 2015 at 03:27:41PM +0200, Eren Yagdiran wrote: From: Cédric Bosdonnat cbosdon...@suse.com Add helper function to check if a config contains disk devices. --- libvirt-sandbox/libvirt-sandbox-config.c | 7 +++ libvirt-sandbox/libvirt-sandbox-config.h | 1 +

Re: [libvirt] [sandbox PATCH 07/10] qemu: use devtmpfs rather than tmpfs to auto-populate /dev

2015-06-26 Thread Daniel P. Berrange
On Fri, Jun 26, 2015 at 03:27:42PM +0200, Eren Yagdiran wrote: From: Cédric Bosdonnat cbosdon...@suse.com When using devtmpfs we don't need to care about the device nodes creation: it's less risk to forget some. It also eases the creation of the devices in the init-qemu. ---

Re: [libvirt] [sandbox 10/10] container builder: don't expose host rootfs if unneeded

2015-06-26 Thread Daniel P. Berrange
On Thu, Jun 25, 2015 at 06:49:47PM +0200, Cédric Bosdonnat wrote: If the user defined a mount targeting / don't add the host / as mount to /. --- .../libvirt-sandbox-builder-container.c| 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) ACK Regards,

Re: [libvirt] [PATCH v3 0/4] vz: add statistics

2015-06-26 Thread Dmitry Guryanov
On 06/26/2015 04:59 PM, Peter Krempa wrote: On Fri, Jun 26, 2015 at 16:51:59 +0300, Dmitry Guryanov wrote: On 06/26/2015 02:24 PM, Nikolay Shirokovskiy wrote: Add vz statistics for network, cpu and memory. CHANGES from v1. subject prefix changed from 'parallels' to 'vz' CHANGES from v2. 1.

Re: [libvirt] [PATCH v3 0/4] vz: add statistics

2015-06-26 Thread Peter Krempa
On Fri, Jun 26, 2015 at 17:01:25 +0300, Dmitry Guryanov wrote: On 06/26/2015 04:59 PM, Peter Krempa wrote: On Fri, Jun 26, 2015 at 16:51:59 +0300, Dmitry Guryanov wrote: On 06/26/2015 02:24 PM, Nikolay Shirokovskiy wrote: Add vz statistics for network, cpu and memory. CHANGES from v1.

[libvirt] [PATCH 1/2] conf: audit: Audit physical memory size rather than balloon request

2015-06-26 Thread Peter Krempa
Since the balloon driver does not guarantee that it returns memory to the host, using the value in the audit message is not a good idea. This patch removes auditing from updating the balloon size and reports the total physical size at startup. --- src/conf/domain_audit.c | 3 ++-

[libvirt] [PATCH 0/2] conf: qemu: Fix memory auditing

2015-06-26 Thread Peter Krempa
Peter Krempa (2): conf: audit: Audit physical memory size rather than balloon request qemu: Audit memory size with memory hotplug operations src/conf/domain_audit.c | 3 ++- src/qemu/qemu_driver.c | 6 +- src/qemu/qemu_hotplug.c | 20 ++-- 3 files changed, 17

Re: [libvirt] [PATCH 2/3] Temporarily disable admin API

2015-06-26 Thread Martin Kletzander
On Fri, Jun 26, 2015 at 12:45:37PM +0100, Daniel P. Berrange wrote: On Fri, Jun 26, 2015 at 01:42:01PM +0200, Martin Kletzander wrote: Don't listen on the admin socket in the daemon and comment out the admin devel files out of specfile. Library is still being compiled and installed in order to

Re: [libvirt] [PATCH 00/20] cpu_map.xml: Make CPU definitions easier to review

2015-06-26 Thread Daniel P. Berrange
On Fri, Jun 26, 2015 at 03:16:59PM +0200, Jiri Denemark wrote: Inheritance among CPU model is cool but it makes reviewing CPU model definitions and comparing them to CPU models from QEMU rather hard and unpleasant. Let's define all CPU models from scratch with a sorted list of features. Just

Re: [libvirt] [PATCH 00/20] cpu_map.xml: Make CPU definitions easier to review

2015-06-26 Thread Jiri Denemark
On Fri, Jun 26, 2015 at 15:05:28 +0100, Daniel P. Berrange wrote: On Fri, Jun 26, 2015 at 03:16:59PM +0200, Jiri Denemark wrote: Inheritance among CPU model is cool but it makes reviewing CPU model definitions and comparing them to CPU models from QEMU rather hard and unpleasant. Let's

Re: [libvirt] [sandbox PATCH 01/10] Add an utility function for guessing filetype from file extension

2015-06-26 Thread Daniel P. Berrange
On Fri, Jun 26, 2015 at 03:27:36PM +0200, Eren Yagdiran wrote: Consider the file name extension as the image type, except for .img that are usually RAW images NB, try to line wrap commit messages at less than 80 chracters diff --git a/libvirt-sandbox/libvirt-sandbox-util.c

Re: [libvirt] [PATCH v3 0/4] vz: add statistics

2015-06-26 Thread Dmitry Guryanov
On 06/26/2015 05:04 PM, Peter Krempa wrote: On Fri, Jun 26, 2015 at 17:01:25 +0300, Dmitry Guryanov wrote: On 06/26/2015 04:59 PM, Peter Krempa wrote: On Fri, Jun 26, 2015 at 16:51:59 +0300, Dmitry Guryanov wrote: On 06/26/2015 02:24 PM, Nikolay Shirokovskiy wrote: Add vz statistics for

[libvirt] [PATCH 2/2] qemu: Audit memory size with memory hotplug operations

2015-06-26 Thread Peter Krempa
The memory device hot(un)plug was missing calls to the auditing code. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1226234 --- src/qemu/qemu_hotplug.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_hotplug.c

Re: [libvirt] [PATCH 3/5] qemu: monitor: Open-code retrieval of wr_highest_offset

2015-06-26 Thread Peter Krempa
On Thu, Jun 25, 2015 at 12:56:02 -0400, John Ferlan wrote: On 06/23/2015 01:15 PM, Peter Krempa wrote: Instead of using qemuMonitorJSONDevGetBlockExtent (which I plan to remove later) extract the data in place. Additionally add a flag that will be set when the wr_highest_offset was

[libvirt] [PATCH v2 1/3] spec: Remove admin package specification

2015-06-26 Thread Martin Kletzander
Its only file must be included in the daemon package anyway, since the daemon is linked with the admin library and so then it's just an empty package until we have virt-admin binary which we can decide later on whether to just move it to clients or create a new package for it. Signed-off-by:

[libvirt] [PATCH v2 3/3] Revert Change livbirt version to 1.3.0 for the next release

2015-06-26 Thread Martin Kletzander
This reverts commit 9a8d916e89173890d7f7ce538b1ab781192b8440. Also some changes that were introduced after that commit are fixed to use 1.2.17 instead of 1.3.0 --- configure.ac | 2 +- docs/formatdomain.html.in | 6 +++--- src/libvirt_public.syms | 2 +- src/vz/vz_driver.c

[libvirt] [PATCH v2 0/3] Defer Admin API enablement post-release

2015-06-26 Thread Martin Kletzander
Even when rushing, you sometimes don't finish what you want. And I'd rather chosen safe road and avoid risks. And we have no usable API function in the admin API or a client binary just yet. Hence the temporary disablement in the second patch. First patch is a clean-up that's supposed to stay

[libvirt] [PATCH v2 2/3] Temporarily disable admin API

2015-06-26 Thread Martin Kletzander
Don't listen on the admin socket in the daemon and comment out the admin devel files out of specfile. Library is still being compiled and installed in order to link easily without any disturbing modifications to the daemon code. Signed-off-by: Martin Kletzander mklet...@redhat.com ---

[libvirt] [PATCH] vz: Fix build after recent commit

2015-06-26 Thread Peter Krempa
Function prlsdkGetStatsParam was missing a prototype or the static keyword. I went with static since it built successfully. Pushed as a build breaker fix. --- src/vz/vz_sdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index

Re: [libvirt] [PATCH v3 0/4] vz: add statistics

2015-06-26 Thread Dmitry Guryanov
On 06/26/2015 05:04 PM, Peter Krempa wrote: On Fri, Jun 26, 2015 at 17:01:25 +0300, Dmitry Guryanov wrote: On 06/26/2015 04:59 PM, Peter Krempa wrote: On Fri, Jun 26, 2015 at 16:51:59 +0300, Dmitry Guryanov wrote: On 06/26/2015 02:24 PM, Nikolay Shirokovskiy wrote: Add vz statistics for

[libvirt] [PATCH 1/2] docs: Clarification for when allowed to use 'lun' for volume

2015-06-26 Thread John Ferlan
While re-reading what I wrote for commit id '785a8940e', I realized I needed to clarify that being able to present as a 'lun', the mode property for the pool source element needed to be host (or empty) and not direct. It was described correctly later in the mode host description, but this just

[libvirt] [PATCH 0/2] Add configuration time check for invalid lun settings

2015-06-26 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1201143 Patch 1 is just a doc change - more a clarification regarding the 'exact' configuration for https://bugzilla.redhat.com/show_bug.cgi?id=1228007 Patch 2 adds a configuration time check for the correct settings when someone tries to configure a

[libvirt] [PATCH 2/2] conf: Validate disk lun using correct types

2015-06-26 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1201143 The formatdomain.html.in description for disk device 'lun' indicates that it must be either a type 'block' or type 'network' with protocol 'iscsi'; however, we did not make that check until domain startup. This caused issues for virt-manager

Re: [libvirt] [PATCH 2/2] conf: Validate disk lun using correct types

2015-06-26 Thread Laine Stump
On 06/26/2015 02:15 PM, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1201143 The formatdomain.html.in description for disk device 'lun' indicates that you could just say formatdomain.html... it must be either a type 'block' or type 'network' with protocol 'iscsi'; however,

Re: [libvirt] [PATCH 1/2] docs: Clarification for when allowed to use 'lun' for volume

2015-06-26 Thread Laine Stump
On 06/26/2015 02:15 PM, John Ferlan wrote: While re-reading what I wrote for commit id '785a8940e', I realized I needed to clarify that being able to present as a 'lun', the mode property for the pool source element needed to be host (or empty) and not direct. It was described correctly

[libvirt] ANNOUNCE: Oz 0.14.0 release

2015-06-26 Thread Chris Lalancette
All, I'm pleased to announce release 0.14.0 of Oz. Oz is a program for doing automated installation of guest operating systems with limited input from the user. Release 0.14.0 is a bugfix and feature release for Oz. Some of the highlights between Oz 0.13.0 and 0.14.0 are: * Fix a bug in

Re: [libvirt] [sandbox 05/10] Remove init-common dependency on libvirt-sandbox.so

2015-06-26 Thread Daniel P. Berrange
On Thu, Jun 25, 2015 at 06:49:42PM +0200, Cédric Bosdonnat wrote: Removing this dependency avoids getting all libvirt.so dependencies loaded in our container. --- libvirt-sandbox/Makefile.am| 41 +++ libvirt-sandbox/libvirt-sandbox-config-all.h | 61

Re: [libvirt] [PATCH V2] libxl: support domainReset

2015-06-26 Thread Jim Fehlig
On 05/27/2015 01:46 PM, Jim Fehlig wrote: Currently, libxl does not provide a reset function, but domainReset can be implemented in the libxl driver by forcibly destroying the domain and starting it again. Signed-off-by: Jim Fehlig jfeh...@suse.com --- This is essentially a V2 of a patch

[libvirt] [PATCH v3] nodeinfo: fix to parse present cpus rather than possible cpus

2015-06-26 Thread Kothapally Madhu Pavan
Currently we are parsing all the possible cpus to get the nodeinfo. This fix will perform a check for present cpus before parsing. Signed-off-by: Kothapally Madhu Pavan k...@linux.vnet.ibm.com --- src/nodeinfo.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/nodeinfo.c

[libvirt] [libvirt-php][PATCH 4/8] Makefile: Introduce 'rpm' target

2015-06-26 Thread Michal Privoznik
It allows you to 'make rpm'. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- Makefile.am | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Makefile.am b/Makefile.am index 78ada5b..9db368a 100644 --- a/Makefile.am +++ b/Makefile.am @@ -3,3 +3,6 @@ SUBDIRS = tools src docs tests

Re: [libvirt] Gathering CPUID data for x86 CPUs

2015-06-26 Thread Jiri Denemark
On Thu, Jun 25, 2015 at 14:12:16 +0200, Jiri Denemark wrote: Hi all, I'm working on improving our host CPU detection logic and I'd like to gather test data for various CPUs and include them in the libvirt's CPU unit test to make sure I don't introduce regressions. If you are willing to

[libvirt] [libvirt-php][PATCH 3/8] configure: Fix build with --prefix

2015-06-26 Thread Michal Privoznik
If source was configured with different --prefix than usual, local state and sysconfig dir might have improper values. Check that in configure and set the correct ones. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- configure.ac | 11 +++ 1 file changed, 11 insertions(+) diff

[libvirt] [PATCH] conf: qemu: Taint VMs using custom device tree blob

2015-06-26 Thread Peter Krempa
Using a custom device tree image may cause unexpected behavior in architectures that use this approach to detect platform devices. Since usually the device tree is generated by qemu and thus it's not normally used let's taint VMs using it to make it obvious as a possible source of problems. ---

[libvirt] [libvirt-php][PATCH 6/8] libvirt-php.spec.in: Drop spaces at EOL

2015-06-26 Thread Michal Privoznik
Signed-off-by: Michal Privoznik mpriv...@redhat.com --- libvirt-php.spec.in | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/libvirt-php.spec.in b/libvirt-php.spec.in index d2a6707..e5437d7 100644 --- a/libvirt-php.spec.in +++ b/libvirt-php.spec.in @@ -1,10 +1,10

[libvirt] [libvirt-php][PATCH 0/8] Build rpms again

2015-06-26 Thread Michal Privoznik
There's is a spec file within the sources, but it's outdated and doesn't work. However, in order to fix it, couple of other places need fixing too. Michal Privoznik (8): configure: Prefer /bin/echo before printf Distribute the spec file too configure: Fix build with --prefix Makefile:

Re: [libvirt] Plans for next release

2015-06-26 Thread Martin Kletzander
On Fri, Jun 26, 2015 at 09:51:26AM +0100, Daniel P. Berrange wrote: On Thu, Jun 25, 2015 at 09:50:42PM +0200, Martin Kletzander wrote: [adding Dan to Cc as he asked me about this right before I had to leave for an appointment] On Thu, Jun 25, 2015 at 10:08:10PM +0800, Daniel Veillard wrote:

[libvirt] [libvirt-php][PATCH 7/8] libvirt-php.spec.in: Cleanup

2015-06-26 Thread Michal Privoznik
Fix default attributes and add unpackaged files. At the same time, don't explicitly require any specific libvirt version. Let rpm to collect dependencies from .so files. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- libvirt-php.spec.in | 8 1 file changed, 4 insertions(+), 4

[libvirt] [libvirt-php][PATCH 1/8] configure: Prefer /bin/echo before printf

2015-06-26 Thread Michal Privoznik
For some reason, configure think it's good to use 'printf %s\n' as $(ECHO). Well, it's not. Problem is, the \n at the end - it does not do what you think. It merely adds 'n' at the end of each printed string. Therefore, use echo which does not need anything special. Signed-off-by: Michal

[libvirt] [libvirt-php][PATCH 2/8] Distribute the spec file too

2015-06-26 Thread Michal Privoznik
So far, only spec.in is distributed. But preprocessed file should be distributed too, so rpm can be built right from distributed archive. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am

[libvirt] [libvirt-php][PATCH 5/8] libvirt-php.spec: Don't run configure twice

2015-06-26 Thread Michal Privoznik
Currently, the configure script is run twice, Firstly with arguments defined by rpmbuild, then with our hardcoded ones. This does not make any sense, since the latter overwrites any result from the former. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- libvirt-php.spec.in | 3 +-- 1

[libvirt] [libvirt-php][PATCH 8/8] Require newer libvirt

2015-06-26 Thread Michal Privoznik
Currently, we require 0.6.2 which is just ancient. While we do some checks and export only those functions for which libvirt counter-part exist, 0.6.2 is just too old. Moreover, not all functions are wrapped by libvirt version check (e.g. libvirt_connect_get_all_domain_stats). Require 1.2.8 at

Re: [libvirt] Plans for next release

2015-06-26 Thread Daniel P. Berrange
On Fri, Jun 26, 2015 at 11:06:01AM +0200, Martin Kletzander wrote: On Fri, Jun 26, 2015 at 09:51:26AM +0100, Daniel P. Berrange wrote: On Thu, Jun 25, 2015 at 09:50:42PM +0200, Martin Kletzander wrote: [adding Dan to Cc as he asked me about this right before I had to leave for an appointment]

Re: [libvirt] Gathering CPUID data for x86 CPUs

2015-06-26 Thread Daniel P. Berrange
On Fri, Jun 26, 2015 at 11:05:48AM +0200, Jiri Denemark wrote: On Thu, Jun 25, 2015 at 14:12:16 +0200, Jiri Denemark wrote: Hi all, I'm working on improving our host CPU detection logic and I'd like to gather test data for various CPUs and include them in the libvirt's CPU unit test to

[libvirt] RFC: add Intel CMT feature support

2015-06-26 Thread Ren, Qiaowei
Hi All, Some Intel processor families (e.g. the Intel Xeon processor E5 v3 family) introduced some PQos (Platform Qos) features to monitor or control shared resource. - CMT (Cache Monitoring Technology): measure the usage of cache by applications running on the platform. - CAT (Cache

Re: [libvirt] [PATCH] conf: Don't allow duplicated targets regardless of bus

2015-06-26 Thread John Ferlan
ping? Tks - John On 06/18/2015 04:12 PM, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1142631 Commit id 'e0e290552' added a check to determine if the same bus had the same target value. It seems that's not quite good enough as the check should check the target name

[libvirt] [PATCH v3 3/4] vz: add vcpu statistics

2015-06-26 Thread Nikolay Shirokovskiy
From: Nikolay Shirokovskiy nshirokovs...@parallels.com Comments. Replace vzDomObjFromDomain/virObjectUnlock pair to vzDomObjFromDomainRef/virDomainObjEndAPI as we use prlsdkGetStatsParam. See previous statistics comments. Signed-off-by: Nikolay Shirokovskiy nshirokovs...@virtuozzo.com ---

[libvirt] [PATCH v3 1/4] vz: add net dev statistiscs

2015-06-26 Thread Nikolay Shirokovskiy
From: Nikolay Shirokovskiy nshirokovs...@parallels.com Populate counters SDK currenly supports: rx_bytes rx_packets tx_bytes tx_packets Comments. Use vzDomObjFromDomainRef/virDomainObjEndAPI pair to get domain object as we use prlsdkGetStatsParam that can release domain object lock and thus

[libvirt] [PATCH 1/3] spec: Remove admin package specification

2015-06-26 Thread Martin Kletzander
Its only file must be included in the daemon package anyway, since the daemon is linked with the admin library and so then it's just an empty package until we have virt-admin binary which we can decide later on whether to just move it to clients or create a new package for it. Signed-off-by:

[libvirt] [sandbox PATCH 06/10] Add gvir_sandbox_config_has_disks function

2015-06-26 Thread Eren Yagdiran
From: Cédric Bosdonnat cbosdon...@suse.com Add helper function to check if a config contains disk devices. --- libvirt-sandbox/libvirt-sandbox-config.c | 7 +++ libvirt-sandbox/libvirt-sandbox-config.h | 1 + libvirt-sandbox/libvirt-sandbox.sym | 1 + 3 files changed, 9 insertions(+)

[libvirt] [sandbox PATCH 00/10] Patches for Libvirt-sandbox

2015-06-26 Thread Eren Yagdiran
Hello, These patches provide disk support for libvirt-sandbox. Implemented '--disk' parameter will be useful when integrating Docker image support for libvirt-sandbox. --Main diffs compared to previous patches. Since many hypervisors, including kvm, will not even honour requested names for

[libvirt] [sandbox PATCH 10/10] Common-builder: /dev/disk/by-tag/thetag to /dev/vdN

2015-06-26 Thread Eren Yagdiran
Common builder counts the disks devices and populates disks.cfg according to that.Disk devices are always come first than host-based images.In builder-machine, mounts of the host-based images will be mounted later. --- libvirt-sandbox/libvirt-sandbox-builder-machine.c | 6 +-

[libvirt] [sandbox PATCH 05/10] Add disk support to machine builder

2015-06-26 Thread Eren Yagdiran
Use the new disk configuration in the container builder to provide disks in qemu sandboxes. The disks are virtio devices, but those shouldn't be known by the user. --- libvirt-sandbox/libvirt-sandbox-builder-machine.c | 38 --- 1 file changed, 34 insertions(+), 4 deletions(-)

[libvirt] [sandbox PATCH 02/10] Add configuration object for disk support

2015-06-26 Thread Eren Yagdiran
Add the config gobject, functions to store and load the new configuration fragments and test. This will allow creating sandboxes with attached disk with a parameter formatted like file:tag=/source/file.qcow2,format=qcow2 --- libvirt-sandbox/Makefile.am | 2 +

[libvirt] [sandbox PATCH 04/10] Add disk support to the container builder

2015-06-26 Thread Eren Yagdiran
Use the new disk configuration in the container builder to provide disks in lxc containers sandboxes. --- .../libvirt-sandbox-builder-container.c| 33 +- 1 file changed, 32 insertions(+), 1 deletion(-) diff --git

[libvirt] [sandbox PATCH 03/10] Add disk parameter to virt-sandbox

2015-06-26 Thread Eren Yagdiran
Allow users to add disk images to their sandbox. Only disk images are supported so far, but the parameter is intentionally designed for future changes. --- bin/virt-sandbox.c | 37 + 1 file changed, 37 insertions(+) diff --git a/bin/virt-sandbox.c

[libvirt] [sandbox PATCH 09/10] Common-init: Building symlink from disks.cfg

2015-06-26 Thread Eren Yagdiran
Similar to the existing mounts.cfg, the mapping between the device and the tag is passed by a new disks.cfg file. Common-init reads disks.cfg and maps the tags to corresponding devices --- libvirt-sandbox/libvirt-sandbox-init-common.c | 54 ++- 1 file changed, 52

[libvirt] [sandbox PATCH 01/10] Add an utility function for guessing filetype from file extension

2015-06-26 Thread Eren Yagdiran
Consider the file name extension as the image type, except for .img that are usually RAW images --- libvirt-sandbox/Makefile.am| 1 + libvirt-sandbox/libvirt-sandbox-util.c | 72 ++ libvirt-sandbox/libvirt-sandbox-util.h | 5 +++ po/POTFILES.in

[libvirt] [sandbox PATCH 08/10] Init-util : Common directory functions for init-common and init-qemu

2015-06-26 Thread Eren Yagdiran
Init-util provides common functions for creating directories for both Init-common and Init-qemu. Error handling needs to be done in calling function. --- libvirt-sandbox/Makefile.am | 4 +- libvirt-sandbox/libvirt-sandbox-init-qemu.c | 51 +++---

[libvirt] [sandbox PATCH 07/10] qemu: use devtmpfs rather than tmpfs to auto-populate /dev

2015-06-26 Thread Eren Yagdiran
From: Cédric Bosdonnat cbosdon...@suse.com When using devtmpfs we don't need to care about the device nodes creation: it's less risk to forget some. It also eases the creation of the devices in the init-qemu. --- libvirt-sandbox/libvirt-sandbox-init-qemu.c | 94 + 1

[libvirt] [PATCH v3 1/2] Storage: Introduce shadow vol for refresh while the main vol builds.

2015-06-26 Thread Prerna Saxena
Libvirt periodically refreshes all volumes in a storage pool, including the volumes being cloned. While cloning a storage volume from parent, we drop pool locks. Subsequent volume refresh sometimes changes allocation for an ongoing copy, and leads to corrupt images. Fix: Introduce a shadow volume

Re: [libvirt] [PATCH] lxc: Bind mount container TTYs

2015-06-26 Thread Martin Kletzander
On Tue, Jun 23, 2015 at 04:38:57PM +0200, Richard Weinberger wrote: Instead of creating symlinks, bind mount the devices to /dev/pts/XY. Using bind mounts it is no longer needed to add pts devices to files like /dev/securetty. I guess you meant /etc/securetty. This patch makes sense, but if

[libvirt] [PATCH 06/20] cpu_map.xml: Expand coreduo CPU model

2015-06-26 Thread Jiri Denemark
Inheritance among CPU model is cool but it makes reviewing CPU model definitions and comparing them to CPU models from QEMU rather hard and unpleasant. Let's define all CPU models from scratch. Signed-off-by: Jiri Denemark jdene...@redhat.com --- src/cpu/cpu_map.xml | 26

[libvirt] [PATCH 17/20] cpu_map.xml: Expand Haswell-noTSX CPU model

2015-06-26 Thread Jiri Denemark
Inheritance among CPU model is cool but it makes reviewing CPU model definitions and comparing them to CPU models from QEMU rather hard and unpleasant. Let's define all CPU models from scratch. Signed-off-by: Jiri Denemark jdene...@redhat.com --- src/cpu/cpu_map.xml | 50

[libvirt] [PATCH 13/20] cpu_map.xml: Expand Penryn CPU model

2015-06-26 Thread Jiri Denemark
Inheritance among CPU model is cool but it makes reviewing CPU model definitions and comparing them to CPU models from QEMU rather hard and unpleasant. Let's define all CPU models from scratch. Signed-off-by: Jiri Denemark jdene...@redhat.com --- src/cpu/cpu_map.xml | 31

[libvirt] [PATCH 12/20] cpu_map.xml: Expand Conroe CPU model

2015-06-26 Thread Jiri Denemark
Inheritance among CPU model is cool but it makes reviewing CPU model definitions and comparing them to CPU models from QEMU rather hard and unpleasant. Let's define all CPU models from scratch. Signed-off-by: Jiri Denemark jdene...@redhat.com --- src/cpu/cpu_map.xml | 29

[libvirt] [PATCH 07/20] cpu_map.xml: Expand n270 CPU model

2015-06-26 Thread Jiri Denemark
Inheritance among CPU model is cool but it makes reviewing CPU model definitions and comparing them to CPU models from QEMU rather hard and unpleasant. Let's define all CPU models from scratch. Signed-off-by: Jiri Denemark jdene...@redhat.com --- src/cpu/cpu_map.xml | 27

[libvirt] [PATCH 10/20] cpu_map.xml: Expand cpu64-rhel5 CPU model

2015-06-26 Thread Jiri Denemark
Inheritance among CPU model is cool but it makes reviewing CPU model definitions and comparing them to CPU models from QEMU rather hard and unpleasant. Let's define all CPU models from scratch. Signed-off-by: Jiri Denemark jdene...@redhat.com --- src/cpu/cpu_map.xml | 104

[libvirt] [PATCH 16/20] cpu_map.xml: Expand SandyBridge CPU model

2015-06-26 Thread Jiri Denemark
Inheritance among CPU model is cool but it makes reviewing CPU model definitions and comparing them to CPU models from QEMU rather hard and unpleasant. Let's define all CPU models from scratch. Signed-off-by: Jiri Denemark jdene...@redhat.com --- src/cpu/cpu_map.xml | 40

  1   2   >